AW: AW: AW: [11u] RFR (S): 8251367: [windows] harfbuzz.dll not found causes failure to load sun.font.SunFontManager

[Doerr, Martin]

Excellent! Thanks a lot!

Best regards,
Martin

Von: Andrew Brygin <abrygin at azul.com>
Datum: Freitag, 7. Mai 2021 um 18:36
An: Doerr, Martin <martin.doerr at sap.com>, jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>
Betreff: Re: AW: AW: [11u] RFR (S): 8251367: [windows] harfbuzz.dll not found causes failure to load sun.font.SunFontManager
Hi Martin,

 thanks for review. I agree that 8251367 and 8255790 should be pushed
together.

 I will put the fix request comment into 8251367, just as reference to
this review thread, but postpone the fix request label until 8255790
will be ready for 11u. Is it OK?

Thanks,
Andrew



On 07/05/2021 19:29, Doerr, Martin wrote:
> Hi Andrew,
>
>
>
> thanks for checking. You can consider your 8251367 backport as reviewed,
> but I think it should get pushed together with 8255790 if possible. Do
> you agree?
>
>
>
> Best regards,
>
> Martin
>
>
>
>
>
> *Von: *Andrew Brygin <abrygin at azul.com>
> *Datum: *Freitag, 7. Mai 2021 um 18:25
> *An: *Doerr, Martin <martin.doerr at sap.com>,
> jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>
> *Betreff: *Re: AW: [11u] RFR (S): 8251367: [windows] harfbuzz.dll not
> found causes failure to load sun.font.SunFontManager
>
> Hi Martin,
>
>  yes, I think we have to backport JDK-8255790 as well: it actually
> reverts the harfbuzz separation (JDK-8249821) for windows, so the
> problem with exe4j apps will be resolved without modification of
> FontManagerNativeLibrary.java.
>
> Thanks,
> Andrew
>
> On 07/05/2021 18:55, Doerr, Martin wrote:
>> Hi Andrew,
>>
>>
>>
>> looks like correctly backported.
>>
>> However, the code added to FontManagerNativeLibrary.java was removed
> again:
>>
>>
> https://github.com/openjdk/jdk/commit/05fe06a6bafc089c6466ccbdea335e5dbfdaf335
> <https://github.com/openjdk/jdk/commit/05fe06a6bafc089c6466ccbdea335e5dbfdaf335>
>>
>> Are you planning to backport that one, too?
>>
>>
>>
>> Best regards,
>>
>> Martin
>>
>>
>>
>>
>>
>> *Von: *jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> im
>> Auftrag von Andrew Brygin <abrygin at azul.com>
>> *Datum: *Freitag, 7. Mai 2021 um 11:07
>> *An: *jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>
>> *Betreff: *[11u] RFR (S): 8251367: [windows] harfbuzz.dll not found
>> causes failure to load sun.font.SunFontManager
>>
>> Hello,
>>
>>  I would like to propose a backport of 8251367 for 11u:
>>
>>  The fix for 8249821: Separate libharfbuzz from libfontmanager is
>> already backported into 11u, so fontmanager.dll now has two
>> dependencies: freetype.dl and harfbuzz.dll which should be handled in
>> the same manner.
>>
>>  The absence of explicit loading of harfbuzz.dll affects some
>> exe4j/install4j deployments which do not use standard java/javaw
> launchers.
>>
>> Original issue: https://bugs.openjdk.java.net/browse/JDK-8251367
> <https://bugs.openjdk.java.net/browse/JDK-8251367>
>> <https://bugs.openjdk.java.net/browse/JDK-8251367
> <https://bugs.openjdk.java.net/browse/JDK-8251367>>
>> Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/21c664a5b7e2
> <https://hg.openjdk.java.net/jdk/jdk/rev/21c664a5b7e2>
>> <https://hg.openjdk.java.net/jdk/jdk/rev/21c664a5b7e2
> <https://hg.openjdk.java.net/jdk/jdk/rev/21c664a5b7e2>>
>> Webrev: http://cr.openjdk.java.net/~bae/11u/8251367/webrev.00/
> <http://cr.openjdk.java.net/~bae/11u/8251367/webrev.00/>
>> <http://cr.openjdk.java.net/~bae/11u/8251367/webrev.00/
> <http://cr.openjdk.java.net/~bae/11u/8251367/webrev.00/>>
>>
>>  The patch for Awt2dLibraries.gmk required some adjustments due to the
>> file rename (make/modules/java.desktop/lib/Awt2dLibraries.gmk ->
>> make/lib/Awt2dLibraries.gmk) and context differences.
>>
>> Thanks,
>> Andrew
>>
>