[External] : Re: [11u] RFR 8218458: [TESTBUG] runtime/NMT/CheckForProperDetailStackTrace.java fails with Expected stack trace missing from output

[Harold Seigel]

Hi Zhengyu,

The changes look good.

Thanks, Harold

On 5/10/2021 1:23 PM, Zhengyu Gu wrote:
>>
>> I think this line should also be changed to locked_create_entry_or_null.
>>
>>     83 private static String expectedSymbol = "locked_create_entry";
>
> Right, updated: 
> http://cr.openjdk.java.net/~zgu/JDK-8218458-11u/webrev.02/
>
> Thanks again, Harold.
>
> -Zhengyu
>
>>
>> Thanks, Harold
>>
>> On 5/10/2021 9:07 AM, Zhengyu Gu wrote:
>>> Thanks Harold for catching this.
>>>
>>> Updated and retested.
>>>
>>> http://cr.openjdk.java.net/~zgu/JDK-8218458-11u/webrev.01/
>>>
>>> -Zhengyu
>>>
>>> On 5/4/21 8:55 AM, Harold Seigel wrote:
>>>> Hi Zhengyu,
>>>>
>>>> Should "locked_create_entry" be changed to 
>>>> "locked_create_entry_or_null" in the below change?
>>>>
>>>>     + private static String stackTraceAlternate =
>>>>     + ".*Hashtable.*allocate_new_entry.*\n" +
>>>>     + ".*ModuleEntryTable.*locked_create_entry.*\n" +
>>>>
>>>> Thanks, Harold
>>>>
>>>> On 5/3/2021 5:03 PM, Zhengyu Gu wrote:
>>>>> I would like to backport this patch to 11u for parity with Oracle 
>>>>> 11.0.13.
>>>>>
>>>>> The original bug: https://bugs.openjdk.java.net/browse/JDK-8218458
>>>>> The original patch: 
>>>>> http://hg.openjdk.java.net/jdk/jdk/rev/b02d1d829b09
>>>>>
>>>>> The original patch does not apply cleanly to 11u.
>>>>>
>>>>> 1) CheckForProperDetailStackTrace.java is not in 11u's 
>>>>> ProblemList.txt
>>>>> 2) 11u does not have JDK-8217660. Therefore, context is bit off in
>>>>>   CheckForProperDetailStackTrace.java, resolved manually.
>>>>>
>>>>> 11u webrev: 
>>>>> http://cr.openjdk.java.net/~zgu/JDK-8218458-11u/webrev.00/
>>>>>
>>>>>
>>>>> Test:
>>>>>  The test passed on Linux x86_64.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> -Zhengyu
>>>>>
>>>>
>>>
>