[EXTERNAL] [11u] RFR 8216184: CDS/appCDS tests failed on Windows due to long path to a classlist file

[Reka Kovacs]

Hi,
 
I'm a new member of Microsoft's Java Engineering team, and I've been looking to backport this fix as a way to familiarize myself with the contribution process, so I'd be happy to help review it.
 
There is an existing bug for the backport (https://bugs.openjdk.java.net/browse/JDK-8266708), Monica has now assigned it to you.
 
The changes look good, my only note is that if we are already touching the copyright years, it might make sense to update them to 2021.
 
All jtreg tier1 tests pass on Windows x64 and Linux x64.
 
- Reka


-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On Behalf Of Zhengyu Gu
Sent: Monday, May 10, 2021 9:28 AM
To: jdk-updates-dev at openjdk.java.net
Subject: [EXTERNAL] [11u] RFR 8216184: CDS/appCDS tests failed on Windows due to long path to a classlist file

I would like to backport this patch to 11u for parity with Oracle 11.0.13.

The original bug: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8216184&data=04%7C01%7Crekakovacs%40microsoft.com%7C9cf27efdff8648bdb16708d913d0a8f5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637562609175817059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=EwQfCaCjRJq%2B2%2FOPJwflgNeS77m61mp%2FtmtGu0OKHoU%3D&reserved=0
The original patch: https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fhg.openjdk.java.net%2Fjdk%2Fjdk%2Frev%2Fb7dca420fa0c&data=04%7C01%7Crekakovacs%40microsoft.com%7C9cf27efdff8648bdb16708d913d0a8f5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637562609175817059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gSrr9aWqZgrRidr782%2BPgGbc8F0%2FgRn64NyX1%2Bek4gY%3D&reserved=0

The original patch does not apply cleanly, due to JDK-8206470 moved surrounding lines (_line_no and _interfaces) in classListParser.cpp down, that resulted merge conflict, and this is the only conflict.

11u webrev: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~zgu%2FJDK-8216184-11u%2Fwebrev.00%2F&data=04%7C01%7Crekakovacs%40microsoft.com%7C9cf27efdff8648bdb16708d913d0a8f5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637562609175817059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6N6gJ6Z%2F0zho4RcCKe2KQ17sgdp71uv%2FGQSK1sLZHsE%3D&reserved=0

Test:
   hotspot_cds on Linux x86_64 and Windows 64.

Thanks,

-Zhengyu