[EXTERNAL] [11u] RFR 8216184: CDS/appCDS tests failed on Windows due to long path to a classlist file

[Reka Kovacs]

Ah, that's good to know. Thanks, Zhengyu!

- Reka


-----Original Message-----
From: Zhengyu Gu <zgu at redhat.com> 
Sent: Tuesday, May 11, 2021 5:06 AM
To: Reka Kovacs <rekakovacs at microsoft.com>; jdk-updates-dev at openjdk.java.net
Subject: Re: [EXTERNAL] [11u] RFR 8216184: CDS/appCDS tests failed on Windows due to long path to a classlist file

Hi Reka,

Thanks for reviewing.

>   
> The changes look good, my only note is that if we are already touching the copyright years, it might make sense to update them to 2021.
>   
I think it is the convention that we keep patch's copyright years for backports. If possible, we would like to keep backports as clean as possible.

-Zhengyu

> All jtreg tier1 tests pass on Windows x64 and Linux x64.
>   
> - Reka
> 
> 
> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On 
> Behalf Of Zhengyu Gu
> Sent: Monday, May 10, 2021 9:28 AM
> To: jdk-updates-dev at openjdk.java.net
> Subject: [EXTERNAL] [11u] RFR 8216184: CDS/appCDS tests failed on 
> Windows due to long path to a classlist file
> 
> I would like to backport this patch to 11u for parity with Oracle 11.0.13.
> 
> The original bug: 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
> .openjdk.java.net%2Fbrowse%2FJDK-8216184&data=04%7C01%7Crekakovacs
> %40microsoft.com%7Ca0f29e1bc5f24539d20008d914753769%7C72f988bf86f141af
> 91ab2d7cd011db47%7C1%7C0%7C637563315938225900%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1
> 000&sdata=uBVtDC2ecOmo3UpIDBUk7KCOsMrlYDy2KSYl6Ev6OIQ%3D&reser
> ved=0 The original patch: 
> https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fhg.op
> enjdk.java.net%2Fjdk%2Fjdk%2Frev%2Fb7dca420fa0c&data=04%7C01%7Crek
> akovacs%40microsoft.com%7Ca0f29e1bc5f24539d20008d914753769%7C72f988bf8
> 6f141af91ab2d7cd011db47%7C1%7C0%7C637563315938225900%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> %3D%7C1000&sdata=6C8LbIivI5tuSskq2IVTU26SytZXIH8OngE1HSG%2BUow%3D&
> amp;reserved=0
> 
> The original patch does not apply cleanly, due to JDK-8206470 moved surrounding lines (_line_no and _interfaces) in classListParser.cpp down, that resulted merge conflict, and this is the only conflict.
> 
> 11u webrev: 
> https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.open
> jdk.java.net%2F~zgu%2FJDK-8216184-11u%2Fwebrev.00%2F&data=04%7C01%
> 7Crekakovacs%40microsoft.com%7Ca0f29e1bc5f24539d20008d914753769%7C72f9
> 88bf86f141af91ab2d7cd011db47%7C1%7C0%7C637563315938225900%7CUnknown%7C
> TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> I6Mn0%3D%7C1000&sdata=15ahtUMRQIwiS1n2pgbjfGhH7QQ5QYJkbh4aNPDB47U%
> 3D&reserved=0
> 
> Test:
>     hotspot_cds on Linux x86_64 and Windows 64.
> 
> Thanks,
> 
> -Zhengyu
>