AW: [11u] RFR: 8250521 - Configure initial RTO to use minimal retry for loopback connections on Windows

[Doerr, Martin]

Hi,

seems like this one has fallen through the cracks.

The 11u webrev looks good to me.
If you want to backport both changes at once, please add both bug ids to the commit message.

Best regards,
Martin


Von: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> im Auftrag von Mat Carter <Matthew.Carter at microsoft.com>
Datum: Montag, 5. April 2021 um 18:29
An: jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>
Betreff: Re: [11u] RFR: 8250521 - Configure initial RTO to use minimal retry for loopback connections on Windows
Bump!

I've been monitoring the jdk11u backports for the last 2 months and seen a number of items move past these two fixes (enhancements).

I just wanted to check that I've not missed a step in the process as they've not been tagged as "request denied"

Note that David Grieve submitted the requests on my behalf

https://bugs.openjdk.java.net/browse/JDK-8250521
https://bugs.openjdk.java.net/browse/JDK-8255264

Cheers
Mat

Sent from Outlook


From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of Mat Carter <Matthew.Carter at microsoft.com>
Sent: Friday, January 22, 2021 5:18 PM
To: jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>
Subject: [11u] RFR: 8250521 - Configure initial RTO to use minimal retry for loopback connections on Windows

I'd like to propose the backport of JDK-8250521 and subsequent JDK-8255264 to 11u.

The patch applied cleanly but had no effect as 11u only used PlainSocketImpl whereas tip uses NIOSokectImpl, so I made comparable changes to PlainSocketImpl.

I kept the original changes to support NIOSocketImpl in case its ever backported.  However, I don't foresee pushing the changes to PlanSocketImpl to tip as its not used by default.

Passes all tier1 tests

JBS : https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8250521&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655279564%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=iFXbQOHEvBhOnkA6TlLy30Bxk8FXxIXRm8GNhQptQR8%3D&reserved=0
Original fix: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhg.openjdk.java.net%2Fjdk%2Fjdk%2Frev%2F035cdb28aa4c&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655279564%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=7qBKPLtXpedIDcVk8rXoEHl8BZYQh5kOitWMNEjqG8Y%3D&reserved=0
Original webrev: https://nam06.safelinks.protection.outlook.com/?url=https:%2F%2Fcr.openjdk.java.net%2F~adityam%2Fnikola%2Ffast_connect_loopback_3%2F&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655279564%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=SE65puvz3q6D4A04QEYIhze%2BzWfE3RLbNnUVpRkWM%2BA%3D&reserved=0

JBS : https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8255264&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655289515%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MBxv58ht3VnIvMjfn4JzHXx7CNO6RKdCU25oO0JQ7dA%3D&reserved=0
Original fix: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fcommit%2F7e01bc96&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655289515%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=IWfdxpo06CJLxQRso1%2Fne%2FVW64f8GEIbKMS2Wdkrq3E%3D&reserved=0
Original PR: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fpull%2F1523&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655289515%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=eACOp2IEdvd6vEB4qPNjkYlufUGq6fgjF6kFeVky9rg%3D&reserved=0

webrev for 11u: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~adityam%2Fmat%2F8250521_jdk11%2F&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655289515%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=dvT%2FQBwf7Pv8%2FrOWCpuYNUbK%2Fu23qxAs5xKNf64O2%2FI%3D&reserved=0

Thanks in advance
Mat