RFR [jdk11]: 8232084: HotSpot build failed with GCC 9.2.1
Baesken, Matthias
matthias.baesken at sap.com
Wed May 12 11:02:35 UTC 2021
>However, to disable warnings in third party libraries like liblcms, we can disable them at the makefile for them.
>In case of liblcms, it is prefer to disable stringop-truncation at Awt2dLibraries.gmk .
>
Hi Yasumasa , are you fine with the rest of the patch ?
Regarding disabling of stringop-truncation , I first disabled it only for liblcms but this was not sufficient.
(there is indeed another change 8220074 for liblcms that disabled this warning for GCC 8.3 )
There are more issues related to the no-stringop-truncation warning and I did not even found a good place to disable them locally in a nice way .
(some strange jvmti related test coding I think those are single file compilations , no real lib??)
Best regards, Matthias
>On 2021/05/12 16:47, Baesken, Matthias wrote:
>> Hello, I please review the backport of 8232084 to jdk11 .
>>
>> This is needed to make jdk11 buildable with gcc-9 (tested on linux x86_64) .
>>
>> Changes in the jdk11 backport compared to jdk/jdk :
>>
>> hotspot/cpu/x86/macroAssembler_x86.hpp change is not needed in jdk11
>>
>> src/hotspot/share/utilities/compilerWarnings_gcc.hpp does not exist in jdk11 so the compilerWarnings_gcc.hpp change goes to compilerWarnings.hpp
>>
>> additionally to be able to build with gcc-9 in make/autoconf/flags-cflags.m4 -Wno-stringop-truncation has to be set (issues in jvmti test coding and liblcms )
>
>I heard that we should disable warnings as narrow as possible in the review. (I forget what ticket it is about)
>However, to disable warnings in third party libraries like liblcms, we can disable them at the makefile for them.
>In case of liblcms, it is prefer to disable stringop-truncation at Awt2dLibraries.gmk .
More information about the jdk-updates-dev
mailing list