[11u] RFR: 8250521 - Configure initial RTO to use minimal retry for loopback connections on Windows

Mon May 17 16:39:38 UTC 2021

Hi Christoph / Martin

Thanks for the feedback, I've created a JBS issue [1] for adding support to PlainSocketImpl on tip, once this new PR is completed I'll update the commit message for the backport to include all 3 JBS bug ids [1,2,3]

In the meantime I'll remove the jdk11u-fix-request tag and add it back once its ready

Cheers
Mat

[1] https://bugs.openjdk.java.net/browse/JDK-8267256
[2] https://bugs.openjdk.java.net/browse/JDK-8250521
[3] https://bugs.openjdk.java.net/browse/JDK-8255264

Sent from Outlook

From: Langer, Christoph <christoph.langer at sap.com>
Sent: Wednesday, May 12, 2021 8:26 AM
To: Mat Carter <Matthew.Carter at microsoft.com>
Cc: jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>; Doerr, Martin <martin.doerr at sap.com>
Subject: RE: [11u] RFR: 8250521 - Configure initial RTO to use minimal retry for loopback connections on Windows 

Hi Mat,

yes, sorry for ignoring this backport for so long.

I see that you made a complementary change to src/java.base/windows/native/libnet/PlainSocketImpl.c for JDK-8250521. You're right in that PlainSocketImpl is only existing in head jdk/jdk as a fallback. I however would very much prefer if you could do this change in head first and then backport it. There should still be active regression tests for PlainSocketImpl in head. Could you please consider that?

Thanks
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> Behalf Of Doerr, Martin
> Sent: Mittwoch, 12. Mai 2021 11:57
> To: Mat Carter <Matthew.Carter at microsoft.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: [DMARC FAILURE] AW: [11u] RFR: 8250521 - Configure initial RTO to
> use minimal retry for loopback connections on Windows
> 
> Hi,
> 
> seems like this one has fallen through the cracks.
> 
> The 11u webrev looks good to me.
> If you want to backport both changes at once, please add both bug ids to the
> commit message.
> 
> Best regards,
> Martin
> 
> 
> Von: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> im
> Auftrag von Mat Carter <Matthew.Carter at microsoft.com>
> Datum: Montag, 5. April 2021 um 18:29
> An: jdk-updates-dev at openjdk.java.net <jdk-updates-
> dev at openjdk.java.net>
> Betreff: Re: [11u] RFR: 8250521 - Configure initial RTO to use minimal retry for
> loopback connections on Windows
> Bump!
> 
> I've been monitoring the jdk11u backports for the last 2 months and seen a
> number of items move past these two fixes (enhancements).
> 
> I just wanted to check that I've not missed a step in the process as they've
> not been tagged as "request denied"
> 
> Note that David Grieve submitted the requests on my behalf
> 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8250521&data=04%7C01%7CMatthew.Carter%40microsoft.com%7Cc59c13675e10446ab41f08d9155a56ba%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637564300023508503%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=kbvjmgzC7k1CJHLsU18mD%2FHudswVDNWJttLUUGj5V2w%3D&reserved=0
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8255264&data=04%7C01%7CMatthew.Carter%40microsoft.com%7Cc59c13675e10446ab41f08d9155a56ba%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637564300023508503%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=XJbY6JQSXNTYMy8pla7L5a7WJTz1vXDia02CSUWpMyM%3D&reserved=0
> 
> Cheers
> Mat
> 
> Sent from Outlook
> 
> 
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on
> behalf of Mat Carter <Matthew.Carter at microsoft.com>
> Sent: Friday, January 22, 2021 5:18 PM
> To: jdk-updates-dev at openjdk.java.net <jdk-updates-
> dev at openjdk.java.net>
> Subject: [11u] RFR: 8250521 - Configure initial RTO to use minimal retry for
> loopback connections on Windows
> 
> I'd like to propose the backport of JDK-8250521 and subsequent JDK-8255264
> to 11u.
> 
> The patch applied cleanly but had no effect as 11u only used PlainSocketImpl
> whereas tip uses NIOSokectImpl, so I made comparable changes to
> PlainSocketImpl.
> 
> I kept the original changes to support NIOSocketImpl in case its ever
> backported.  However, I don't foresee pushing the changes to
> PlanSocketImpl to tip as its not used by default.
> 
> Passes all tier1 tests
> 
> JBS :
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
> .openjdk.java.net%2Fbrowse%2FJDK-
> 8250521&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e7
> 3bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C
> 1%7C0%7C637469615655279564%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000
> &sdata=iFXbQOHEvBhOnkA6TlLy30Bxk8FXxIXRm8GNhQptQR8%3D&am
> p;reserved=0
> Original fix:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhg.o
> penjdk.java.net%2Fjdk%2Fjdk%2Frev%2F035cdb28aa4c&data=04%7C01
> %7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3ce
> a9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655279
> 564%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=7qBKPLtXpedI
> DcVk8rXoEHl8BZYQh5kOitWMNEjqG8Y%3D&reserved=0
> Original webrev:
> https://nam06.safelinks.protection.outlook.com/?url=https:%2F%2Fcr.openj
> dk.java.net%2F~adityam%2Fnikola%2Ffast_connect_loopback_3%2F&d
> ata=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f931
> 3b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6374
> 69615655279564%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=SE6
> 5puvz3q6D4A04QEYIhze%2BzWfE3RLbNnUVpRkWM%2BA%3D&reserve
> d=0
> 
> JBS :
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
> .openjdk.java.net%2Fbrowse%2FJDK-
> 8255264&data=04%7C01%7Cmatthew.carter%40microsoft.com%7Cf7e7
> 3bbae0c442f9313b08d8bf3cea9c%7C72f988bf86f141af91ab2d7cd011db47%7C
> 1%7C0%7C637469615655289515%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000
> &sdata=MBxv58ht3VnIvMjfn4JzHXx7CNO6RKdCU25oO0JQ7dA%3D&am
> p;reserved=0
> Original fix:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Fopenjdk%2Fjdk%2Fcommit%2F7e01bc96&data=04%7C01%7
> Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c
> %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655289515
> %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=IWfdxpo06CJLxQRs
> o1%2Fne%2FVW64f8GEIbKMS2Wdkrq3E%3D&reserved=0
> Original PR:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Fopenjdk%2Fjdk%2Fpull%2F1523&data=04%7C01%7Cmatthe
> w.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3cea9c%7C72f9
> 88bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655289515%7CUnk
> nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6I
> k1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=eACOp2IEdvd6vEB4qPNjkYl
> ufUGq6fgjF6kFeVky9rg%3D&reserved=0
> 
> webrev for 11u:
> https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openj
> dk.java.net%2F~adityam%2Fmat%2F8250521_jdk11%2F&data=04%7C01
> %7Cmatthew.carter%40microsoft.com%7Cf7e73bbae0c442f9313b08d8bf3ce
> a9c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637469615655289
> 515%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=dvT%2FQBwf7
> Pv8%2FrOWCpuYNUbK%2Fu23qxAs5xKNf64O2%2FI%3D&reserved=0
> 
> Thanks in advance
> Mat