[11u] RFR 8177068: incomplete classpath causes NPE in Flow

[Hohensee, Paul]

That’s what I get for not actually looking at the issue before responding… :)

From: "Langer, Christoph" <christoph.langer at sap.com>
Date: Monday, May 17, 2021 at 11:24 AM
To: "Hohensee, Paul" <hohensee at amazon.com>, "Astigeevich, Evgeny" <eastig at amazon.co.uk>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Cc: "compiler-dev at openjdk.java.net" <compiler-dev at openjdk.java.net>
Subject: RE: [11u] RFR 8177068: incomplete classpath causes NPE in Flow

Hi Paul,

you not only requested approval. You also got it and then pushed (on 21st of April). ��

I guess Evgeny’s mail popped up again on the mailing list for some reason…

Cheers
Christoph

From: compiler-dev <compiler-dev-retn at openjdk.java.net> On Behalf Of Hohensee, Paul
Sent: Montag, 17. Mai 2021 20:11
To: Astigeevich, Evgeny <eastig at amazon.co.uk>; jdk-updates-dev at openjdk.java.net
Cc: compiler-dev at openjdk.java.net
Subject: Re: [11u] RFR 8177068: incomplete classpath causes NPE in Flow

Hi, Evgeny.

I reviewed this backport last month and tagged the issue. Waiting on maintainer (Christoph?) approval.

Thanks,
Paul

From: compiler-dev <compiler-dev-retn at openjdk.java.net<mailto:compiler-dev-retn at openjdk.java.net>> on behalf of "Astigeevich, Evgeny" <eastig at amazon.co.uk<mailto:eastig at amazon.co.uk>>
Date: Saturday, May 15, 2021 at 3:05 PM
To: "jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>" <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
Cc: "compiler-dev at openjdk.java.net<mailto:compiler-dev at openjdk.java.net>" <compiler-dev at openjdk.java.net<mailto:compiler-dev at openjdk.java.net>>
Subject: [11u] RFR 8177068: incomplete classpath causes NPE in Flow

Hi,

Please review the backport of JDK-8177068 to 11u.

Bug: https://bugs.openjdk.java.net/browse/JDK-8177068
Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/a3c63a9dfb2c

The original patch does not apply cleanly to 11u. In the original patch, file DeferredAttr.java, calls of ‘attribSpeculative’ to be changed have the argument AttributionMode.SPECULATIVE. The original patch does not change this. In 11u ‘attribSpeculative’ does not have the parameter AttributionMode. I changed the affected calls to 11u API.

11u  webrev: http://cr.openjdk.java.net/~eastigeevich/8177068/webrev.00/

Tested: Amazon Linux 2 x86_64, tier1, tier2, langtools/tools/javac/T8177068/NoCompletionFailureSkipOnSpeculativeAttribution.java
Note: There is a failing test: sun/security/pkcs11/Secmod/AddTrustedCert.java. It fails without the patch as well. Details: https://bugs.openjdk.java.net/browse/JDK-8232153

Thanks,
Evgeny




Amazon Development Centre (London) Ltd.Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.