[jdk16u] RFR: 8267345: VM crashes during dumping classlist with -Xshare:dump option [v2]

[Ioi Lam]

On Wed, 19 May 2021 23:41:44 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Hi, Please review
>>   The problem is caused by JDK-8247536: Support for pre-generated java.lang.invoke classes in CDS static archive
>>    Usually the dump with an appointed class list file, -XX:SharedClassListFile=<classlist>, the 'classlist' is collected by pre-run the application with -XX:DumpLoadedClassList, so it is rare case using -Xshare:dump and -XX:DumpLoadedClassList together, though we can do that.
>>    It is reproducible by run
>>    java -Xshare:dump -XX:DumpLoadedClassList=<any valid file name>
>>    The problem happened when regenerating lambda form invoker's holder classes, with which the re-generated class stream without a source associated (class is generated on fly).  Referencing to NULL source failed. Fix checks if source is valid.
>> 
>> Tests: tier1,tier2,tier3,tier4
>> 
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed skipping printout, changed Copyright year

LGTM.
I think the behavior of printing of %s with NULL is undefined, so your change is the safe way to do it.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk16u/pull/119