AW: [11u] RFR 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873

[Doerr, Martin]

Hi Reka,

I’ve pushed it and also JDK-8251031.

Several emails from jdk-updates-dev haven’t reached us but mailing to us directly works.

Best regards,
Martin


Von: Reka Kovacs <rekakovacs at microsoft.com>
Datum: Donnerstag, 20. Mai 2021 um 02:51
An: mdoerr at openjdk.java.net <mdoerr at openjdk.java.net>
Cc: jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>
Betreff: RE: [11u] RFR 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
Hi Martin,

I'm responding to your comment<https://bugs.openjdk.java.net/browse/JDK-8254634?focusedCommentId=14421702&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14421702> on the backport bug, I hope you'll receive it this time.

Thank you for the review, and for setting the fix-request tag for me. Could you please sponsor the change?
I'm hoping to earn authorship soon, to be able to do some of the administrative steps myself.

Thanks again,
Reka

From: Reka Kovacs
Sent: Monday, May 17, 2021 4:16 PM
To: jdk-updates-dev at openjdk.java.net
Cc: Monica Beckwith <Monica.Beckwith at microsoft.com>
Subject: [11u] RFR 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873

Hi,

I would like to backport this change as it eliminates build failures on Windows with VS2019, which is now the generally recommended version of Visual Studio. Could someone please review?

Original bug: https://bugs.openjdk.java.net/browse/JDK-8241087
Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/c616656f7e01
Bug for backport: https://bugs.openjdk.java.net/browse/JDK-8254634
Webrev: http://cr.openjdk.java.net/~mbeckwit/8241087/webrev.00/

The original patch does not apply cleanly to jdk11u, because the copyright year in awt_DnDDT.cpp has already been changed to 2021. The updated patch does not touch that line. Monica kindly hosted the webrev for me.

Tested: build and tier1 on x86_64 Windows, Linux and MacOS.

Thank you,
Reka