[11u] RFR: JDK-8227609 backport: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size

[Hohensee, Paul]

I filed https://bugs.openjdk.java.net/browse/JDK-8267641: [11u] 8227609 backport typo to fix it. Pls review the patch (separate email).

Thanks,
Paul

-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of "Hohensee, Paul" <hohensee at amazon.com>
Date: Monday, May 24, 2021 at 1:18 PM
To: Dmitry Chuyko <dmitry.chuyko at bell-sw.com>, Ilarion Nakonechnyy <ilarion at azul.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Subject: Re: [11u] RFR: JDK-8227609 backport: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size

"8227609" was't in the webrev.

http://cr.openjdk.java.net/~yan/8227609_wr/webrew.00/src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java.udiff.html

Looks like a transcription error on the push. Yan?

-----Original Message-----
From: Dmitry Chuyko <dmitry.chuyko at bell-sw.com>
Date: Monday, May 24, 2021 at 11:55 AM
To: "Hohensee, Paul" <hohensee at amazon.com>, Ilarion Nakonechnyy <ilarion at azul.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Subject: RE: [11u] RFR: JDK-8227609 backport: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size

Hi,

It looks like the push was not clean:

jdk11u-dev/src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java:130:
error: ';' expected
                     newPos = size;8227609

https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/file/dce73d35ee28/src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java#l130

-Dmitry

On 5/21/21 8:20 PM, Hohensee, Paul wrote:
> Looks like you're referencing the the bug number list in Misc.java. Lgtm.
>
> Thanks,
> Paul
>
> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of Ilarion Nakonechnyy <ilarion at azul.com>
> Date: Friday, May 21, 2021 at 7:08 AM
> To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
> Subject: Re: [11u] RFR: JDK-8227609 backport: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size
>
> Hi, I’d like to backport JDK-8227609 to JDK11.
>
> The patch applied unclear, a small correction in comment was done. Build successfully and run tier-1 on mac x86_64.
> Could you please review the changes?
> webrev: http://cr.openjdk.java.net/~yan/8227609_wr/webrew.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8227609
>
> Thanks.
>