AW: [11u] RFR 8266352: Add parallel heap iteration for jmap –histo

Doerr, Martin martin.doerr at sap.com
Tue May 25 12:06:43 UTC 2021


Hi Buddy,

Let me make this clearer: I only suggested to push them at once.
But we still need 3 individual commits to keep the history and JBS sane.
Please make sure they don’t get merged into one commit.
Can you upload your 3 patches, too, please?

Best regards,
Martin


Von: buddyliao(廖彬) <buddyliao at tencent.com>
Datum: Montag, 24. Mai 2021 um 10:36
An: jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>
Cc: Doerr, Martin <martin.doerr at sap.com>
Betreff: [11u] RFR 8266352: Add parallel heap iteration for jmap –histo
Hi all,

Would you help me to review the following backport from jdk-master?
The following three patches should be backport together for the reason of bugfix.

Original bug:
https://bugs.openjdk.java.net/browse/JDK-8215624
http://hg.openjdk.java.net/jdk/jdk/rev/b1afb7c82d59

https://bugs.openjdk.java.net/browse/JDK-8251570<https://bugs.openjdk.java.net/browse/JDK-8215624>
https://hg.openjdk.java.net/jdk/jdk/rev/dd827a012e43

https://bugs.openjdk.java.net/browse/JDK-8253763
https://git.openjdk.java.net/jdk/commit/6d19fe65


Original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed.
Notably, I had to change the src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java<http://hg.openjdk.java.net/jdk/jdk/file/b1afb7c82d59/src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java> to make it matches 11u-dev

Thank you for Matin’s suggestion, I combined all above three patches together and backport it.

11u webrev:
    https://cr.openjdk.java.net/~lzang/BuddyLiao/8266352/webrev02/

Testing: x86_64 build, affected tests, tier1

Thanks,
-Buddy



More information about the jdk-updates-dev mailing list