[jdk11u-dev] RFR: 8234930: Use MAP_JIT when allocating pages for code cache on macOS [v2]

[Thomas Stuefe]

On Tue, 2 Nov 2021 20:05:45 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Please review this backport of JDK-8234930 to jdk11u-dev.
>> This is a prerequest for mac-aarch64
>> It's not applying clean due to the miss of these two patches
>> JDK-8253639: Change os::attempt_reserve_memory_at parameter order
>> JDK-8253650: Cleanup: remove alignment_hint parameter from os::reserve_memory
>> But they aren't critical and the patch can easily be modified
>
> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix up windows

We see new crashes with the three-patch-chain on PPC:


Thu Nov 04 21:44:45 CET 2021
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (src/hotspot/share/runtime/handles.hpp:168), pid=27135, tid=28626
#  assert(_value != __null) failed: resolving NULL _value
#
# JRE version: OpenJDK Runtime Environment (11.0.14) (fastdebug build 11.0.14-internal+0-adhoc.openjdk.jdk11u-dev)
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 11.0.14-internal+0-adhoc.openjdk.jdk11u-dev, compiled mode, tiered, compressed oops, g1 gc, linux-ppc64le)
# Core dump will be written. Default location: /jtreg_hotspot_work/JTwork/serviceability/jvmti/CompiledMethodLoad/Zombie/core.27135
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp

Stack: [0x00003fff94660000,0x00003fff94860000],  sp=0x00003fff9485ddc0,  free space=2039k
Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0x1a53fb4]  VMError::report_and_die(Thread*, void*, char const*, int, char const*, char const*, char*)+0x54
V  [libjvm.so+0xa87330]  report_vm_error(char const*, int, char const*, char const*, ...)+0xf0
V  [libjvm.so+0x1212d68]  JvmtiMethodEventMark::JvmtiMethodEventMark(JavaThread*, methodHandle const&)+0x2c8
V  [libjvm.so+0x120eb14]  JvmtiExport::post_compiled_method_load(JvmtiEnv*, nmethod*)+0x104
V  [libjvm.so+0x121ee98]  JvmtiDeferredEventQueue::post(JvmtiEnv*)+0x138
V  [libjvm.so+0x1254738]  JvmtiThreadState::post_events(JvmtiEnv*)+0x38
V  [libjvm.so+0x114cb44]  JvmtiCodeBlobEvents::generate_compiled_method_load_events(JvmtiEnv*)+0xb54
V  [libjvm.so+0x11d9ffc]  JvmtiEnv::GenerateEvents(jvmtiEvent)+0x7c
V  [libjvm.so+0x1155b2c]  jvmti_GenerateEvents+0x2cc
C  [libCompiledZombie.so+0xab0]  GenerateEventsThread+0x90
V  [libjvm.so+0x12197dc]  JvmtiAgentThread::call_start_function()+0x2cc
V  [libjvm.so+0x194ad1c]  JavaThread::thread_main_inner()+0x34c
V  [libjvm.so+0x1945310]  Thread::call_run()+0xc0
V  [libjvm.so+0x15c105c]  thread_native_entry(Thread*)+0x16c
C  [libpthread.so.0+0x8cd4]  start_thread+0x104
`
[crash-ppc-vladimir.log](https://github.com/openjdk/jdk11u-dev/files/7480863/crash-ppc-vladimir.log)
``

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/580