[jdk11u-dev] Integrated: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"

David Holmes david.holmes at oracle.com
Wed Nov 10 22:45:03 UTC 2021 

On 9/11/2021 10:50 pm, Lindenmaier, Goetz wrote:
> Hi Zhengyu,
> 
> Since this change has been pushed, we see four test crashing in our CI,
> see below.  Do you have an idea what is wrong with these?

 From JBS:

"The original patch applies cleanly, but needs to take additional 
MultiArray_lock on CDS path to get it work correctly. "

but that additional change is broken as you can't hold the lock on that 
path due to the linking that can occur which requires a call up to Java 
which can't be done when holding the mutex. I don't know why Zhengyu 
thought that was neccessary.

David
-----

> Best regards,
>    Goetz.
> 
> runtime/appcds/UnusedCPDuringDump.java
> runtime/appcds/VerifierTest_1A.java
> runtime/appcds/VerifierTest_1B.java
> runtime/appcds/VerifierTest_2.java
> 
> # A fatal error has been detected by the Java Runtime Environment:
> #
> #  Internal Error (/sapmnt/sapjvm_work/openjdk/nb/darwinintel64/jdk11u-dev/src/hotspot/share/runtime/javaCalls.cpp:60), pid=24040, tid=9987
> #  assert(!thread->owns_locks()) failed: must release all locks when leaving VM
> #
> # JRE version: OpenJDK Runtime Environment (11.0.14) (fastdebug build 11.0.14-internal+0-adhoc.openjdk.jdk11u-dev)
> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 11.0.14-internal+0-adhoc.openjdk.jdk11u-dev, interpreted mode, compressed oops, g1 gc, bsd-amd64)
> # Core dump will be written. Default location: ./core.24040
> #
> # If you would like to submit a bug report, please visit:
> #   https://bugreport.java.com/bugreport/crash.jsp
> #
> 
> ---------------  S U M M A R Y ------------
> 
> Command Line: -Xmx768m -Djava.awt.headless=true -Djava.util.prefs.userRoot=/System/Volumes/Data/priv/jvmtests/output_openjdk11_dev_dbgU_darwinintel64/jtreg_hotspot_runtime_work/tmp -Djava.io.tmpdir=/System/Volumes/Data/priv/jvmtests/output_openjdk11_dev_dbgU_darwinintel64/jtreg_hotspot_runtime_work/tmp -Djdk.test.lib.artifacts.devkit-macosx_x64=/net/usr.work/jvmtests/devkit/Xcode9.2-MacOSX10.13-devkit -ea -esa -Xshare:dump -Xlog:cds,cds+hashtables -XX:ExtraSharedClassListFile=/System/Volumes/Data/priv/jvmtests/output_openjdk11_dev_dbgU_darwinintel64/jtreg_hotspot_runtime_work/JTwork/classes/runtime/appcds/UnusedCPDuringDump.d/runtime.appcds.UnusedCPDuringDump.java-test.classlist -XX:SharedArchiveFile=/System/Volumes/Data/priv/jvmtests/output_openjdk11_dev_dbgU_darwinintel64/jtreg_hotspot_runtime_work/JTwork/runtime/appcds/UnusedCPDuringDump/appcds-22h03m26s830.jsa -Xlog:class+path=info,class+load=debug
> 
> Host: wdfmacphy0129.wdf.global.corp.sap, MacPro7,1 x86_64 3200 MHz, 32 cores, 96G, Darwin 20.6.0
> Time: Sun Nov  7 22:03:27 2021 CET elapsed time: 0.853748 seconds (0d 0h 0m 0s)
> 
> ---------------  T H R E A D  ---------------
> 
> Current thread (0x00007fe56f808620):  JavaThread "main" [_thread_in_vm, id=9987, stack(0x0000700002ad5000,0x0000700002bd5000)]
> 
> Stack: [0x0000700002ad5000,0x0000700002bd5000],  sp=0x0000700002bd2430,  free space=1013k
> Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code)
> V  [libjvm.dylib+0xbe93f6]  VMError::report_and_die(int, char const*, char const*, __va_list_tag*, Thread*, unsigned char*, void*, void*, char const*, int, unsigned long)+0x6ba
> V  [libjvm.dylib+0xbe9b31]  VMError::report_and_die(Thread*, void*, char const*, int, char const*, char const*, __va_list_tag*)+0x3f
> V  [libjvm.dylib+0x4470a3]  report_vm_error(char const*, int, char const*, char const*, ...)+0xcc
> V  [libjvm.dylib+0x63c9c6]  JavaCallWrapper::JavaCallWrapper(methodHandle const&, Handle, JavaValue*, Thread*)+0xce
> V  [libjvm.dylib+0x63e5bd]  JavaCalls::call_helper(JavaValue*, methodHandle const&, JavaCallArguments*, Thread*)+0x387
> V  [libjvm.dylib+0x63d07d]  JavaCalls::call_virtual(JavaValue*, Klass*, Symbol*, Symbol*, JavaCallArguments*, Thread*)+0x255
> V  [libjvm.dylib+0x63d382]  JavaCalls::call_virtual(JavaValue*, Handle, Klass*, Symbol*, Symbol*, Handle, Thread*)+0xc6
> V  [libjvm.dylib+0xb4b17a]  SystemDictionary::load_instance_class(Symbol*, Handle, Thread*)+0x156
> V  [libjvm.dylib+0xb49f67]  SystemDictionary::resolve_instance_class_or_null(Symbol*, Handle, Handle, Thread*)+0x6bd
> V  [libjvm.dylib+0xb4943d]  SystemDictionary::resolve_or_fail(Symbol*, Handle, Handle, bool, Thread*)+0x1b
> V  [libjvm.dylib+0xbc0f34]  VerificationType::resolve_and_check_assignability(InstanceKlass*, Symbol*, Symbol*, bool, bool, bool, Thread*)+0xa8
> V  [libjvm.dylib+0xbc11f2]  VerificationType::is_reference_assignable_from(VerificationType const&, ClassVerifier*, bool, Thread*) const+0x12a
> V  [libjvm.dylib+0xbcfa3a]  ClassVerifier::verify_invoke_instructions(RawBytecodeStream*, unsigned int, StackMapFrame*, bool, bool*, VerificationType, constantPoolHandle const&, StackMapTable*, Thread*)+0x86a
> V  [libjvm.dylib+0xbc40f3]  ClassVerifier::verify_method(methodHandle const&, Thread*)+0x8cb
> V  [libjvm.dylib+0xbc233e]  ClassVerifier::verify_class(Thread*)+0xa0
> V  [libjvm.dylib+0xbc1eba]  Verifier::verify(InstanceKlass*, Verifier::Mode, bool, Thread*)+0x1f6
> V  [libjvm.dylib+0x617788]  InstanceKlass::link_class_impl(bool, Thread*)+0x2ac
> V  [libjvm.dylib+0x6185ea]  InstanceKlass::link_class(Thread*)+0x6e
> V  [libjvm.dylib+0x97f8e5]  MetaspaceShared::try_link_class(InstanceKlass*, Thread*)+0xc5
> V  [libjvm.dylib+0x981a2a]  LinkSharedClassesClosure::do_klass(Klass*)+0x4a
> V  [libjvm.dylib+0x369ff8]  ClassLoaderData::loaded_classes_do(KlassClosure*)+0x16a
> V  [libjvm.dylib+0x36cc75]  ClassLoaderDataGraph::loaded_classes_do(KlassClosure*)+0xad
> V  [libjvm.dylib+0x97f2af]  MetaspaceShared::link_and_cleanup_shared_classes(Thread*)+0x5f
> V  [libjvm.dylib+0x97f525]  MetaspaceShared::preload_and_dump(Thread*)+0x1bb
> V  [libjvm.dylib+0xb8196c]  Threads::create_vm(JavaVMInitArgs*, bool*)+0x972
> V  [libjvm.dylib+0x6ef71c]  JNI_CreateJavaVM+0xac
> C  [libjli.dylib+0x52bb]  JavaMain+0x10b
> C  [libjli.dylib+0x7e32]  ThreadJavaMain+0x9
> C  [libsystem_pthread.dylib+0x68fc]  _pthread_start+0xe0
> C  [libsystem_pthread.dylib+0x2443]  thread_start+0xf
> 
> 
> 
> 
> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On Behalf Of Zhengyu Gu
> Sent: Samstag, 6. November 2021 23:29
> To: jdk-updates-dev at openjdk.java.net
> Subject: [jdk11u-dev] Integrated: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
> 
> On Thu, 4 Nov 2021 16:32:16 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
> 
>> Backport for parity with Oracle 11.0.15.
>>
>> The original patch applies cleanly, but some of CDS tests fail due to following new assertion in `ClassLoaderData::loaded_classes_do()`
>>
>> `  // To call this, one must have the MultiArray_lock held, but the _klasses list still has lock free reads.
>>    assert_locked_or_safepoint(MultiArray_lock);
>> `
>> The solution is to take `MultiArray_lock` in `MetaspaceShared::link_and_cleanup_shared_classes()` method
>>
>> Test:
>> - [x]  tier1
> 
> This pull request has now been integrated.
> 
> Changeset: 3a351580
> Author:    Zhengyu Gu <zgu at openjdk.org>
> URL:       https://git.openjdk.java.net/jdk11u-dev/commit/3a3515807cd76b571aa9cf5f19203bca7be7f970
> Stats:     9 lines in 3 files changed: 9 ins; 0 del; 0 mod
> 
> 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
> 
> Reviewed-by: phh
> Backport-of: 172aed1a2d75756b140cb723133ac5fb67f7745e
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk11u-dev/pull/584
>

More information about the jdk-updates-dev mailing list