[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v11]

[Reka Kovacs]

On Wed, 10 Nov 2021 10:18:28 GMT, Andrew Haley <aph at openjdk.org> wrote:

> Thanks. That looks pretty clean to me now. I think we need one more reviewer, and we're good.

Thanks so much for the review, @theRealAph.
Could you please suggest someone as the other reviewer?

> src/hotspot/cpu/aarch64/c1_FpuStackSim_aarch64.cpp line 31:
> 
>> 29: 
>> 30: // No FPU stack on AARCH64
>> 31: #include "precompiled.hpp"
> 
> Why does Windows need this change?

It seems that MSVC gives an [error](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/fatal-error-c1010?view=msvc-170) if a PCH specified on the command line is not included in the file. Since the use of precompiled headers is enabled by default, this compilation command gets the same PCH related arguments as the others. An alternative solution I found to be working is to add this file to the PCH exclude list here: [make/hotspot/lib/JvmOverrideFiles.gmk#L191](https://github.com/openjdk/jdk11u-dev/blob/6ec651fdc1c5ea0fe22731077446de1dd39cb24d/make/hotspot/lib/JvmOverrideFiles.gmk#L191), and then the include can be removed. Which one do you prefer?

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301