[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v11]

[Andrew Dinn]

On Tue, 9 Nov 2021 23:14:51 GMT, Reka Kovacs <rkovacs at openjdk.org> wrote:

>> Main commit of the Windows/AArch64 port.
>> 
>> Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build.
>> 
>> Depends on #274 and #299.
>
> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Remove unnecessary warning pragma
>  - Remove unnecessary changes
>  - Backport 9604ee82690f89320614b37bfef4178abc869777

This all looks fine as far as any effect on existing code is concerned (n.b. I am not in a position to comment on Windows-specific changes).
Only one minor change is recommended. It would be a good idea to comment the include of precompiled.hpp in empty file c1_FpuStackSim_aarch64.cpp so that no one decides it is redundant and deletes it.

Marked as reviewed by adinn (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301