[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v12]

[Reka Kovacs]

On Thu, 18 Nov 2021 03:23:06 GMT, Reka Kovacs <rkovacs at openjdk.org> wrote:

>> Main commit of the Windows/AArch64 port.
>> 
>> Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build.
>> 
>> Depends on #274 and #299.
>
> Reka Kovacs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment to explain PCH include
>   
>   And a single space for consistency

Some fresh test results for the two Arm64 platforms:

**Linux-Arm64** fastdebug before the patch:

  | Total | Passed | Failed | Error
-- | -- | -- | -- | --
jdk tier1 | 1845 | 1845 | 0 | 0
hotspot tier1 | 1514 | 1514 | 0 | 0
langtools all | 3926 | 3926 | 0 | 0

**Linux-Arm64** fastdebug after the patch:

  | Total | Passed | Failed | Error
-- | -- | -- | -- | --
jdk tier1 | 1845 | 1845 | 0 | 0
hotspot tier1 | 1514 | 1514 | 0 | 0
langtools all | 3926 | 3926 | 0 | 0

**Windows-Arm64** fastdebug:

  | Total | Passed | Failed | Error
-- | -- | -- | -- | --
jdk tier1 | 1865 | 1864 | 0 | 0
hotspot tier1 | 1246 | 1238 | 8 | 0
langtools all | 3925 | 3925 | 0 | 0

[Here](https://gist.github.com/rnkovacs/edfa07b7b86ae720c26e788db230f872)'s a list of the failing hotspot tests.

We've been battling issues with both Cygwin and MSVC. We've reported a [bad arm64 codegen bug](https://developercommunity.visualstudio.com/t/arm64-incorrect-code-gen-when-compiler-decides-to/1541140) that causes assert failures in a bunch of tests, and is still present in VS 2022 (closed as fixed incorrectly - we're contacting the engineers directly). We got our results by using a [workaround](https://gist.github.com/rnkovacs/8b67a8513d19b43343185dc5f86fe3fe) that seems to fix the issue.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301