[jdk11u-dev] RFR: 8222825: ARM32 SIGILL issue on single core CPU (not supported PLDW instruction) [v2]
Aleksey Shipilev
shade at openjdk.java.net
Thu Nov 25 11:23:02 UTC 2021
On Wed, 24 Nov 2021 07:31:34 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
>> This is the request to backport the fix to jdk11u.
>> The change fixes SIGILL on ARM machines without the Multiprocessing Extensions and brings no risk for other platforms.
>>
>> The original patch [1] has minor conflicts with os::is_MP [2] and AArch64 Port [3] removal updates.
>> [1] https://github.com/openjdk/jdk/commit/989fa190
>> [2] https://github.com/openjdk/jdk/commit/a3cd6a1a
>> [3] https://github.com/openjdk/jdk/commit/05027c12
>>
>> The jtreg tests are Ok.
>
> Boris Ulasevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
Looks fine to me.
The original patch has this definition, which is missing from the backport, but I don't see how it affects anything.
+ static bool _has_mp_ext;
(Old) AArch64 code looks fine too (not that we care at this junction), we should be using the same match rule.
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk11u-dev/pull/652
More information about the jdk-updates-dev
mailing list