[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v13]

[Goetz Lindenmaier]

On Wed, 24 Nov 2021 19:40:35 GMT, Reka Kovacs <rkovacs at openjdk.org> wrote:

>> Main commit of the Windows/AArch64 port.
>> 
>> Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build.
>> 
>> Depends on #274 and #299.
>
> Reka Kovacs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Work around MSVC bug on argument passing

Hi,
I would vote for approving the change. Why?
- It is well reviewed.
- The shared changes are mostly procedural changes resolving dependencies but not affecting the core functionality (interpreter, jit, runtime…). Obviously, the windows x86/x64 and linux aarch64 ports are affected more by this change than the other ports, as there are a row of files touched because they are now shared with the windows aarch64 port.  But this also limits the risk to a subset of the ports.
- There are still four weeks rampdown, and basically it is the idea of rampdown to test the changes approved and pushed before.
- The change is live upstream for quite a while now, so issues should only result from adaptions to 11, there should not be an unexpected high ratio of uncaught basic issues in the port.
- Availability of a new port is valuable.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301