[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v13]

Fri Nov 26 21:53:07 UTC 2021

On Fri, 26 Nov 2021 20:30:48 GMT, Andrew Haley <aph at openjdk.org> wrote:

> > > Could you /reviewer credit me too? Thanks
> > 
> > 
> > Sorry I thought you are. It seems like it picks up people who actually approve the PR.
> 
> I'm looking at the OpenJDK census, and vkempik seems to be a committer, not a reviewer. It would be quite wrong for us to record a non-reviewer as a reviewer.

No, everybody who reviews a PR (marks the PR as reviewed) and has a census entry will be credited as a reviewer by Skara. But only if somebody is a project Reviewer - by census role - this will be an authoritative review, allowing the author to merge a PR. And I also think that's right, anybody who spent time and effort to review a particular change should also be credited, no matter of project role.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301