[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v13]

[Monica Beckwith]

On Fri, 26 Nov 2021 21:56:01 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Could you /reviewer credit me too? Thanks
>
>> OK, I hope @VladimirKempik and @magicus will be credited correctly, but they should. The preliminary commit message in the commit above is hopefully misleading.
> 
> Hm, my hope was wrong, I'm sorry, @VladimirKempik. I now think you would have had to approve the PR in GitHub once again...

I agree with @RealCLanger. The original work was done by 3 contributors, so I think it is appreciable (and should be encouraged) if any of the original contributors spent their time reviewing the backport, and hence they should be listed as reviewers (despite their project status). Similarly, @VladimirKempik and @magicus spent their time and effort helping out with the original work and the backport as well. For some reason, I don't see them both in the reviewer for the backport and I don't see any of their code comments when I click on their `review comments` icon in the top right area. So maybe @VladimirKempik and @magicus would need to manually mark this backport as reviewed to get the credit. Thanks for having this discussion.

> > > > Could you /reviewer credit me too? Thanks
> > > 
> > > 
> > > Sorry I thought you are. It seems like it picks up people who actually approve the PR.
> > 
> > 
> > I'm looking at the OpenJDK census, and vkempik seems to be a committer, not a reviewer. It would be quite wrong for us to record a non-reviewer as a reviewer.
> 
> No, everybody who reviews a PR (marks the PR as reviewed) and has a census entry will be credited as a reviewer by Skara. But only if somebody is a project Reviewer - by census role - this will be an authoritative review, allowing the author to merge a PR. And I also think that's right, anybody who spent time and effort to review a particular change should also be credited, no matter of project role.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301