[jdk11u-dev] RFR: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182

[Jonathan Dowland]

On Thu, 23 Sep 2021 12:48:26 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Please consider this backport for jdk11u. It depends upon JDK-8266182 (https://github.com/openjdk/jdk11u-dev/pull/376) which in turn depends on JDK-8180571 (https://github.com/openjdk/jdk11u-dev/pull/396).
>> 
>> MultipleLogins.sh compiles all files under lib/jdk/test/lib/artifacts, Since JDK-8266182 added a new file OpensslArtifactFetcher.java which requires libraries outside of MultipleLogin.sh's classpath, it fails to build it.
>> The patch move and renames OpensslArtifactFetcher to resolve this.
>> 
>> The patch applies cleanly and MultipleLogins.sh passes after applying. Note that in my testing, in 11u, the test does not fail prior to applying: although it's clear from the output that it failed to build OpensslArtifactFetcher.
>
> Seems like this is not a proper "dependent PR". I'd select the old PR as diff target when creating the new PR.
> But I think it is also ok if you just rebase this one once the other one is integrated.

@TheRealMDoerr wrote:
> Seems like this is not a proper "dependent PR". I'd select the old PR as diff target when creating the new PR.

Yes I think you're right, I didn't pick that up from the Skara mail I read, but it stands to reason.

> But I think it is also ok if you just rebase this one once the other one is integrated.

I've done that now.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/400