[jdk11u-dev] RFR: 8273547: [11u] [JVMCI] Partial module-info.java backport of JDK-8223332 [v2]

[Christoph Langer]

On Thu, 9 Sep 2021 14:26:27 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this trivial partial backport of JDK-8223332. The full patch is too large and isn't worth the risk to backport in full. The issue at hand can be resolved by adding only the exports to the `jdk.internal.vm.ci` module. Thoughts?
>> 
>> Testing: jvmci tests, jvmci bootstrap tests, manual testing of the reproducer and tier1 on Linux x86_64
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix test

Marked as reviewed by clanger (Reviewer).

test/jdk/jdk/modules/etc/JdkQualifiedExportTest.java line 77:

> 75:                "jdk.internal.vm.ci/jdk.vm.ci.hotspot",
> 76:                "jdk.internal.vm.ci/jdk.vm.ci.meta",
> 77:                "jdk.jsobject/jdk.internal.netscape.javascript.spi");

The order of packages in the original change is hotspot, meta, code. Maybe you should use exactly this? Other than that, looks reasonable.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/318