[jdk11u-dev] RFR: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit

[Christoph Langer]

On Wed, 30 Jun 2021 12:35:01 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> I would like to backport this change to JDK-11 since this flag helps us analyzing metaspace problems, and beyond that its completely harmless.
> 
> The original patch does not properly apply, since the flag definition format in globals.hpp has changed since JDK11. Other than that, the patch is trivial.
> 
> Nightlies at SAP ran through with this patch for several weeks now.

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.

Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

src/hotspot/share/runtime/globals.hpp line 1828:

> 1826:                                                                             \
> 1827:   diagnostic(bool, PrintMetaspaceStatisticsAtExit, false,                   \
> 1828:                   "Print metaspace statistics upon VM exit.")               \

Could you fix the indentation of this line to match the formatting for the other flags around here?

src/hotspot/share/runtime/globals.hpp line 1830:

> 1828:                   "Print metaspace statistics upon VM exit.")               \
> 1829:                                                                             \
> 1830:                                                                             \

one empty line is enough, I'd say.

-------------

Changes requested by clanger (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/83