[jdk11u-dev] RFR: Backport 0f43de9f026

[Jonathan Dowland]

On Thu, 16 Sep 2021 11:48:38 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> This is a test-only backport. This test fix was merged in 11.0.13-oracle.
>> 
>> The test started to fail in JDK mainline after JDK-8241072, but that change is not in-scope for jdk11u. The test in jdk11u right now passes (for me) before and after applying. The test fix seems reasonable to me despite the failure not triggering in 11u (yet?)
>
> Hi Jon,
> 
> can you rename the PR title to "Backport <commit hash\>" (0f43de9f026d5405dd7a38799e499312ef8df890)? That way the bots will pick up the change and recognize it properly as a backport. It would also be nice to enable Github Actions on your repository to have some tier1 test results.
> 
> Cheers
> Christoph

@RealCLanger, @jerboaa thank you for your feedback. I've retitled the PR and enabled actions in my fork (although I haven't imported any actions to it, yet, perhaps I need to do that too. Investigating further).

Severin wrote:
> @jmtd This has some useful info on backporting using the Git workflow: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix

I've read that, but I hadn't realised that the `git commit -m` in 2.c) was mandatory rather than illustrative. Noted for next time, thanks!

I assume (since the page doesn't say otherwise) that steps 1-4 are required even for clean backports?

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/356