[jdk11u-dev] RFR: 8180571: Refactor sun/security/pkcs11 shell tests to plain java tests and fix failures
Martin Doerr
mdoerr at openjdk.java.net
Thu Sep 23 12:39:23 UTC 2021
On Wed, 22 Sep 2021 14:07:43 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:
> Please consider this backport of [JDK-8180571](https://bugs.openjdk.java.net/browse/JDK-8180571) to 11u.
>
> It's not a clean backport. cherry-pick conflicts manually resolved:
>
> * all file deletions didn't succeed due to hunk differences
> * all: copyright year differences
> * `ReadConfInUTF16Env.java`: upstream hunks differ due to removed SPARC support
> * `PKCS11Test.java`: import list differences (nio imports not present in 11u's copy, resolved by including them as this change needs them)
>
> The test `Login.java` needed further alterations for 11u:
>
> * two uses of JDK12+ `instanceof` pattern matching needed unsugaring
> * Removed @run argument `-Djava.security.manager=allow`. This is invalid for JDK11 (and corresponds to the JDK11 behaviour when specified for 12+)
>
> All included tests now pass for me. Awaiting GitHub's tier1 test results.
It was me who put it into our nightly testing. Results are fine.
-------------
PR: https://git.openjdk.java.net/jdk11u-dev/pull/396
More information about the jdk-updates-dev
mailing list