[jdk11u-dev] RFR: 8224214: [AIX] Remove support for legacy xlc compiler [v2]

Tyler Steele duke at openjdk.java.net
Wed Apr 6 17:07:36 UTC 2022


On Tue, 5 Apr 2022 14:11:25 GMT, Tyler Steele <duke at openjdk.java.net> wrote:

>> #993 
>> 
>> Backport of:
>> 
>> 8224214: [AIX] Remove support for legacy xlc compiler
>> 
>> Reviewed-by: erikj, kbarrett, mdoerr, dholmes
>> 
>> Backport Notes:
>> 
>> - ptrQueue.hpp The backport added procedure definitions to the hpp file that were not implemented in the cpp file. I removed these.
>> - oopStorage.hpp The backport added procedure definitions to the hpp file that were not implemented in the cpp file. I removed these.
>> - globalDefinitions_xlc.hpp Add version check for xlc 16.
>
> Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8224214: [AIX] Remove support for legacy xlc compiler
>   
>   Reviewed-by: erikj, kbarrett, mdoerr, dholmes
>   
>   Backport Conflicts:
>   - make/autoconf/toolchain.m4: Update header year.
>   - src/hotspot/share/gc/g1/ptrQueue.hpp: Remove procedure definition (cpp
>   does not contian impl).
>   - src/hotspot/share/gc/shared/oopStorage.hpp: Remove procedure
>   definition (cpp does not contain impl).
>   - src/hotspot/share/runtime/vm_version.cpp: Remove ~100 lines not
>   present in base version.
>   - src/hotspot/share/utilities/globalDefinitions_xlc.hpp: Add xlc version
>   check.

After some discussion with others, I realized that this would make building with an older version of xlc and using the `-with-harfbuzz=system` workaround impossible. As a result, I'm closing this PR and removing it from the order proposed in #993. The other PRs should not affect support for older xlc versions.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/996


More information about the jdk-updates-dev mailing list