[jdk17u-dev] RFR: 8285727: Unify fix for JDK-8284920 with version from head
Christoph Langer
clanger at openjdk.java.net
Fri Apr 29 06:21:55 UTC 2022
On Thu, 28 Apr 2022 10:39:20 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
> Worth to note the new DOT_STR is not aligned stylistically with the rest of String tokens like DDOT and DCOLON, so I don't feel the new change is elegant, but it is a matter of personal taste.
OK, sorry, I shouldn't have used the word "elegant" without really looking at the implementation. What I rather wanted to point out was the fact that Oracle's change was touching less LOC.
I think, after all, we should have the same code in all OpenJDK versions. That's why I would still suggest to do this backport and additionally improve the implementation in OpenJDK head and then backport this enhancement. WDYT?
@AntonKozlov, would you mind proposing your changes in jdk/jdk?
-------------
PR: https://git.openjdk.java.net/jdk17u-dev/pull/373
More information about the jdk-updates-dev
mailing list