From paul at kungfoocoder.org Mon Aug 1 00:37:18 2022 From: paul at kungfoocoder.org (Paul Wagland) Date: Mon, 1 Aug 2022 02:37:18 +0200 Subject: Massive slowdown in regex processing while GC log fills with ICBufferFull messages Message-ID: <48755CD4-2A8B-471B-865F-FACE080213A9@kungfoocoder.org> Hi all, We have been running into a problem with Java 17.0.1, 17.0.2, and now 17.0.3. # java --version openjdk 17.0.3 2022-04-19 OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7) OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode, sharing) The issue that we are seeing is very similar in behaviour to https://bugs.openjdk.org/browse/JDK-8277212 , with a couple of notable exceptions: 1. We are seeing this issue in 17.0.3, whereas JDK-8277212 was resolved in either 17.0.2 or 17.0.3-oracle. 2. We are using G1GC, not ZGC Unfortunately, we don?t know how to reproduce this issue, we are seeing it happen about once a week across our fleet. We have about 300 instances of Java running various different workloads. What happens is that on a machine where this occurs, after a period of time we see CPU usage suddenly spike, and the gc logs suddenly start getting flooded with ICBufferFull messages, at the rate of about 430 a second. When doing thread dumps to see what is happening at that time, we find most threads end up very deep in a regex processing stack, unfortunately we have one of these fairly central to the product, so this ends up affecting most threads. It seems that almost everything that isn?t thread parsing operates at, or near to, full speed. This is one of the reasons that this feels similar to JDK-8277212, since that was mashing the VTABLES, and because of the way that regexes work, they would appear to use a lot of VTABLE lookups, so any slowdown in that area, is likely to affect them greatly. Note that this is pure supposition, and I would love to know if there is any way if we can prove, or disprove this, either via testing, or additional logging. Unfortunately, as mentioned above, we are not able to reproduce this in our test environments, and we are only seeing this in customer environments, and then not with any clearly identifiable cause. We have seen the issue about a dozen times, over 17.0.1, 17.0.2, and recently, 17.0.3. We have done some performance testing, and during the slow-down we get, for our regex processing test: 10 iterations of testString 1 took 10700ms (1070004460ns/match) (matched=false) 10 iterations of testString 2 took 8965ms (896560879ns/match) (matched=true) Normal timings looks like: 18503 iterations of testString 1 took 1000ms (54047ns/match) (matched=false) 40954 iterations of testString 2 took 1000ms (24417ns/match) (matched=true) So that represents a slowdown of roughly 20,000 times! We have another test that is mostly map lookup heavy, and during the high CPU it has: doMapOperations:2:31076ns doMapOperations:3:16951ns doMapOperations:4:14192ns While normally it has: doMapOperations:2:27392ns doMapOperations:3:7987ns doMapOperations:4:6079ns So a slowdown of maybe a factor of 2, which is perfectly explainable by the very high CPU/system load. Our startup arguments are: JVM startup arguments: -javaagent:/opt/jmx-exporter/jmx-exporter.jar=9404:/opt/jmx-exporter/config.yaml --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED -Dnop -Djava.security.egd=file:/dev/./urandom -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/opt/?/logs -Djava.awt.headless=true -XX:+PrintFlagsFinal -DRP_CONTEXTPATH= -DRP_UNPACKWAR=true -XX:FlightRecorderOptions=stackdepth=256 -XX:+UnlockDiagnosticVMOptions -XX:+DebugNonSafepoints -Xlog:gc*,safepoint=info:file=/opt/?/logs/verbosegc.log:time,uptimemillis:filecount=10,filesize=50M -Xlog:class*=info:file=/opt/?/logs/classload.log:time,uptimemillis,level,tags:filecount=10,filesize=50M -XX:+UseG1GC -XX:G1PeriodicGCInterval=10000 -XX:+ParallelRefProcEnabled -XX:MaxDirectMemorySize=25M -XX:MaxMetaspaceSize=300M -XX:MetaspaceSize=100M -Xss1024K -XX:ReservedCodeCacheSize=150M -XX:+SegmentedCodeCache -Xmx862m -XX:MaxMetaspaceFreeRatio=20 -XX:MinMetaspaceFreeRatio=5 -XX:MaxHeapFreeRatio=40 -XX:MinHeapFreeRatio=5 -Djdk.nio.maxCachedBufferSize=8192 -XX:SoftMaxHeapSize=646m -Dlog4j2.disableJmx=true -Djdk.tls.ephemeralDHKeySize=2048 -Djava.protocol.handler.pkgs=org.apache.catalina.webresources -Dorg.apache.catalina.security.SecurityListener.UMASK=0027 -Dignore.endorsed.dirs= -Dcatalina.base=/opt/?/server1 -Dcatalina.home=/opt/?/tomcat -Djava.io.tmpdir=/opt/?/temp Can anyone think of anything that we can do to ameliorate this problem, apart from not using regexes, which we are moving towards, but I think that they are the victim here, not the cause of the problem, since in normal use, they are ?fast enough?. If there is any information that I can add, please let me know! Cheers, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz at openjdk.org Mon Aug 1 06:40:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 06:40:52 GMT Subject: [jdk11u-dev] RFR: 8269039: Disable SHA-1 Signed JARs In-Reply-To: References: Message-ID: On Wed, 20 Jul 2022 07:44:55 GMT, Goetz Lindenmaier wrote: > src/java.base/share/conf/security/java.security > Does not resolve because 11 mentions "include jdk.disabled.namedCurves" > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java > Some hunks did not apply because DISABLED_CHECK was renamed > to JAR_DISABLED_CHECK in 17. > Other hunks patch methods not in 11: checkWeakKey(), checkWeakAlg() > as well as the calls to these methods. > > test/jdk/java/security/Security/signedfirst/Dyn.sh > test/jdk/java/security/Security/signedfirst/Static.sh > Deleting did not apply. > > test/jdk/java/util/jar/JarInputStream/signed.jar > Patching this binary file failed. I just copied > the file from 17. > > test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java > Patch skipped, test not in 11. > > test/jdk/sun/security/tools/jarsigner/TimestampCheck.java > Resolved. Checked output differed. > > test/lib/jdk/test/lib/security/SecurityUtils.java > The change to this file was already backported. > > In addition, I adapted > sun/security/tools/jarsigner/DefaultOptions.java > sun/security/tools/jarsigner/NameClash.java > sun/security/tools/jarsigner/EC.java > according to > "8172404: Tools should warn if weak algorithms are used before restricting them" > which makes the tests pass. Hi Martin, I filed 8291595: [17u] Delete files missed in backport of 8269039 Also, I had a look at 8259401. It can be backported clean and passes our testing. But it comes with a release note about the warning, and there is no such note for 11. So I think we should rather not backport this change. So should I remove the argument? On the other side, eventual follow up backports apply better if I keep it as-is, and this should not harm performance as it is only called for printing. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1244 From goetz at openjdk.org Mon Aug 1 08:34:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:34:39 GMT Subject: [jdk17u-dev] Integrated: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 14:25:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 0b31a9f5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0b31a9f5679a8902f0c49b0c881b66c62b3773aa Stats: 306 lines in 1 file changed: 121 ins; 141 del; 44 mod 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java Backport-of: c5c84b8fdc0d52bc45ed7290011b39337f3bbe35 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/603 From goetz at openjdk.org Mon Aug 1 08:35:40 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:35:40 GMT Subject: [jdk11u-dev] Integrated: 8264792: The NumberFormat for locale sq_XK formats price incorrectly. In-Reply-To: <7KGx_Yia5lg6vkJfuNKJzyBc66vXy_tvOtpuvIPWLdo=.76596587-4685-4a52-931b-587eb30f00c9@github.com> References: <7KGx_Yia5lg6vkJfuNKJzyBc66vXy_tvOtpuvIPWLdo=.76596587-4685-4a52-931b-587eb30f00c9@github.com> Message-ID: On Thu, 28 Jul 2022 14:04:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 39577311 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/395773111785ed7c59da4da833990b83bcf7e34f Stats: 13 lines in 3 files changed: 6 ins; 0 del; 7 mod 8264792: The NumberFormat for locale sq_XK formats price incorrectly. Backport-of: 25ad9d6ba3862c73cb3ec44d3da0edaf18fc4178 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1279 From goetz at openjdk.org Mon Aug 1 08:40:32 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:40:32 GMT Subject: [jdk17u-dev] Integrated: 8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 15:41:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 11dddf15 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/11dddf15fb69a80c86f670a4a708d928e051ee54 Stats: 12 lines in 1 file changed: 5 ins; 5 del; 2 mod 8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" Backport-of: cd07b3cab00e6656e73a29f82210e2dedf26df8c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/605 From goetz at openjdk.org Mon Aug 1 08:42:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:42:56 GMT Subject: [jdk11u-dev] Integrated: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 14:29:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: d928ab76 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d928ab7697667c6d6038b26a4ea71ca6b31d62c5 Stats: 306 lines in 1 file changed: 121 ins; 141 del; 44 mod 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java Backport-of: c5c84b8fdc0d52bc45ed7290011b39337f3bbe35 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1280 From goetz at openjdk.org Mon Aug 1 08:43:14 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:43:14 GMT Subject: [jdk17u-dev] Integrated: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 15:50:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 7488823f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7488823fbab63912ea88a8d338d842b538d99151 Stats: 32 lines in 1 file changed: 15 ins; 1 del; 16 mod 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test Backport-of: b3f45f868d9c91d630a118e43cef54cdb3216fd0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/606 From goetz at openjdk.org Mon Aug 1 08:45:38 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:45:38 GMT Subject: [jdk11u-dev] Integrated: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test In-Reply-To: References: Message-ID: <-TKeA1kZAvNp63R6TRJA441XzM2waV6sTr5WC3QGQjI=.deaf6cae-4f02-4202-9106-78d836612a60@github.com> On Thu, 28 Jul 2022 15:54:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 4b851893 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/4b8518934f68e01668558d36392a4aa17158e2ee Stats: 32 lines in 1 file changed: 15 ins; 1 del; 16 mod 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test Backport-of: b3f45f868d9c91d630a118e43cef54cdb3216fd0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1283 From goetz at openjdk.org Mon Aug 1 08:46:45 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:46:45 GMT Subject: [jdk17u-dev] Integrated: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr In-Reply-To: References: Message-ID: On Fri, 29 Jul 2022 15:14:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: a6462223 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/a6462223df1f3936de33ebe1d1956475bede8760 Stats: 26 lines in 1 file changed: 19 ins; 0 del; 7 mod 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr Backport-of: db502d30a42847f69273f48378f230d9d55eb8d6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/607 From goetz at openjdk.org Mon Aug 1 08:53:41 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:53:41 GMT Subject: [jdk11u-dev] Integrated: 8280913: Create a regression test for JRootPane.setDefaultButton() method In-Reply-To: <9lGVSA7RqNULcCrDUBOB9qbUToL78fK4R7f2WWvRHY0=.21563c55-9b02-4d89-915a-d4dcd73fb6b8@github.com> References: <9lGVSA7RqNULcCrDUBOB9qbUToL78fK4R7f2WWvRHY0=.21563c55-9b02-4d89-915a-d4dcd73fb6b8@github.com> Message-ID: On Fri, 29 Jul 2022 15:27:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: a92d71d4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/a92d71d4bbb4ac6d462ed199b4f82b87a0545a41 Stats: 111 lines in 1 file changed: 111 ins; 0 del; 0 mod 8280913: Create a regression test for JRootPane.setDefaultButton() method Backport-of: 51b53a821bb3cfb962f80a637f5fb8cde988975a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1285 From goetz at openjdk.org Mon Aug 1 08:53:54 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:53:54 GMT Subject: [jdk17u-dev] Integrated: 8282789: Create a regression test for the JTree usecase of JDK-4618767 In-Reply-To: <9Qj6TfzDt_FcsGNXNHFHt5CVtlQSoczf0uaGB170Bw4=.707c0290-393e-4a8c-ae15-2c0654b6ad5d@github.com> References: <9Qj6TfzDt_FcsGNXNHFHt5CVtlQSoczf0uaGB170Bw4=.707c0290-393e-4a8c-ae15-2c0654b6ad5d@github.com> Message-ID: On Fri, 29 Jul 2022 15:53:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 11e8a916 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/11e8a91619fea3f58ad5f5c1d0c152a351984cb4 Stats: 226 lines in 1 file changed: 226 ins; 0 del; 0 mod 8282789: Create a regression test for the JTree usecase of JDK-4618767 Backport-of: 83a1c90433343107eaa2a7fa41b9b07f86b6ce19 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/609 From goetz at openjdk.org Mon Aug 1 08:54:14 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:54:14 GMT Subject: [jdk17u-dev] Integrated: 8280913: Create a regression test for JRootPane.setDefaultButton() method In-Reply-To: <74NWJSKpr-g5psO7fLwVHJKIL6Z5xRKWB72wjo_aKHA=.3f7679c0-6c55-4e85-adf1-ef507bec7ff3@github.com> References: <74NWJSKpr-g5psO7fLwVHJKIL6Z5xRKWB72wjo_aKHA=.3f7679c0-6c55-4e85-adf1-ef507bec7ff3@github.com> Message-ID: On Fri, 29 Jul 2022 15:23:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: d52a8992 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d52a8992127d0da28ffc2d7bf42a87dc76fa36eb Stats: 111 lines in 1 file changed: 111 ins; 0 del; 0 mod 8280913: Create a regression test for JRootPane.setDefaultButton() method Backport-of: 51b53a821bb3cfb962f80a637f5fb8cde988975a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/608 From goetz at openjdk.org Mon Aug 1 08:54:19 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:54:19 GMT Subject: [jdk11u-dev] Integrated: 8282789: Create a regression test for the JTree usecase of JDK-4618767 In-Reply-To: References: Message-ID: On Fri, 29 Jul 2022 15:56:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 672e3c23 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/672e3c23643eada99b0c2d90fc8c8831b3d9791e Stats: 226 lines in 1 file changed: 226 ins; 0 del; 0 mod 8282789: Create a regression test for the JTree usecase of JDK-4618767 Backport-of: 83a1c90433343107eaa2a7fa41b9b07f86b6ce19 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1286 From goetz at openjdk.org Mon Aug 1 08:55:34 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:55:34 GMT Subject: [jdk17u-dev] Integrated: 8283493: Create an automated regression test for RFE 4231298 In-Reply-To: References: Message-ID: On Fri, 29 Jul 2022 16:11:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 488e6a35 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/488e6a355f92fa6602d5fd6454902176dce50d2f Stats: 184 lines in 1 file changed: 184 ins; 0 del; 0 mod 8283493: Create an automated regression test for RFE 4231298 Backport-of: 6917c39e450e0564b8db7c96be132881a6b0a112 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/610 From goetz at openjdk.org Mon Aug 1 08:56:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:56:52 GMT Subject: [jdk17u-dev] Integrated: 8283015: Create a test for JDK-4715496 In-Reply-To: <3LO9p7OZ6U0X_oDqUXlMpzAWAWvnNGjq8LtDtu48aME=.80bdcfeb-38aa-45d0-bad9-7a5028c9618e@github.com> References: <3LO9p7OZ6U0X_oDqUXlMpzAWAWvnNGjq8LtDtu48aME=.80bdcfeb-38aa-45d0-bad9-7a5028c9618e@github.com> Message-ID: On Fri, 29 Jul 2022 16:14:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 3822bbdb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/3822bbdb006962d0719d9a792113bba81c7d3a41 Stats: 90 lines in 1 file changed: 90 ins; 0 del; 0 mod 8283015: Create a test for JDK-4715496 Backport-of: bfd9c2b30f17d3341cbe7f48d13d36708e5fafbf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/611 From goetz at openjdk.org Mon Aug 1 08:59:48 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 08:59:48 GMT Subject: [jdk11u-dev] Integrated: 8283493: Create an automated regression test for RFE 4231298 In-Reply-To: References: Message-ID: On Fri, 29 Jul 2022 16:13:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: fc4868ec Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/fc4868ecb4d03cebb7d5368e80b90939329efac2 Stats: 184 lines in 1 file changed: 184 ins; 0 del; 0 mod 8283493: Create an automated regression test for RFE 4231298 Backport-of: 6917c39e450e0564b8db7c96be132881a6b0a112 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1287 From goetz at openjdk.org Mon Aug 1 09:00:15 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 09:00:15 GMT Subject: [jdk17u-dev] Integrated: 8288992: AArch64: CMN should be handled the same way as CMP In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 08:07:24 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: b9749f41 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b9749f41784977ce95a8e80873eceee16bcf254f Stats: 9 lines in 2 files changed: 3 ins; 0 del; 6 mod 8288992: AArch64: CMN should be handled the same way as CMP Backport-of: cc2b79270445ccfb2181894fed2edfd4518a2904 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/602 From goetz at openjdk.org Mon Aug 1 09:00:16 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 09:00:16 GMT Subject: [jdk11u-dev] Integrated: 8283015: Create a test for JDK-4715496 In-Reply-To: References: Message-ID: On Fri, 29 Jul 2022 16:24:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 81ffdc18 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/81ffdc1878296f06c0022b41d9b8f35107f3a0c8 Stats: 90 lines in 1 file changed: 90 ins; 0 del; 0 mod 8283015: Create a test for JDK-4715496 Backport-of: bfd9c2b30f17d3341cbe7f48d13d36708e5fafbf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1288 From goetz at openjdk.org Mon Aug 1 09:02:12 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 09:02:12 GMT Subject: [jdk11u-dev] Integrated: 8286314: Trampoline not created for far runtime targets outside small CodeCache In-Reply-To: <_HbtKMGFOeKNcT60HDIIC_mrAFIAW-XYPBegRKKqGfM=.fdd20f4a-7e56-4624-ada9-6caf14a9110d@github.com> References: <_HbtKMGFOeKNcT60HDIIC_mrAFIAW-XYPBegRKKqGfM=.fdd20f4a-7e56-4624-ada9-6caf14a9110d@github.com> Message-ID: <5fuIDGrUGeTsIIMQbdqyyAxP10fpSlXdfI88vDxPUC0=.070b9bcb-ae91-4780-9cc9-cf516b8b2da0@github.com> On Thu, 28 Jul 2022 10:19:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 8a88a695 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/8a88a69546350e42d3d6ca171006d606485ceb6c Stats: 17 lines in 1 file changed: 15 ins; 0 del; 2 mod 8286314: Trampoline not created for far runtime targets outside small CodeCache Backport-of: bf0623b11fd95f09fe953822af71d965bdab8d0f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1276 From goetz at openjdk.org Mon Aug 1 09:04:59 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 09:04:59 GMT Subject: [jdk11u-dev] Integrated: 8290246: test fails "assert(init != __null) failed: initialization not found" In-Reply-To: <-Abph0v7tZGD2ibM6AJfQuk_Otjvj-pFITnQO1pvGqk=.064532f2-92b7-409b-b5e8-fa81669a26e2@github.com> References: <-Abph0v7tZGD2ibM6AJfQuk_Otjvj-pFITnQO1pvGqk=.064532f2-92b7-409b-b5e8-fa81669a26e2@github.com> Message-ID: On Thu, 28 Jul 2022 15:46:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 60a68901 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/60a68901f7f0c0129248fcafb4a46993b242082a Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod 8290246: test fails "assert(init != __null) failed: initialization not found" Backport-of: 70fce07a382896a8091413d7269bb16f33122505 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1282 From goetz at openjdk.org Mon Aug 1 09:06:44 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 09:06:44 GMT Subject: [jdk11u-dev] Integrated: 8290334: Update FreeType to 2.12.1 In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 15:45:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 5f79e3ba Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/5f79e3ba8a06694f1445c02aca19445c567d2c9c Stats: 67 lines in 19 files changed: 10 ins; 8 del; 49 mod 8290334: Update FreeType to 2.12.1 Backport-of: ea8b75cfe453f5806a96ca85dd5e31724750a88f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1281 From goetz.lindenmaier at sap.com Mon Aug 1 09:33:09 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 1 Aug 2022 09:33:09 +0000 Subject: Bots for backports down? Message-ID: Hi, my recent backports have not been handled by the bots: https://github.com/openjdk/jdk17u-dev/pull/616 https://github.com/openjdk/jdk11u-dev/pull/1294 Is this issue known already? Could someone please have a look? Thanks! Goetz. -------------- next part -------------- An HTML attachment was scrubbed... URL: From yan at azul.com Mon Aug 1 09:39:26 2022 From: yan at azul.com (Yuri Nesterenko) Date: Mon, 1 Aug 2022 12:39:26 +0300 Subject: Bots for backports down? In-Reply-To: References: Message-ID: Bots definitely don't like JDK-8287672! On 01.08.2022 12:33, Lindenmaier, Goetz wrote: > Hi, > > my recent backports have not been handled by the bots: > https://github.com/openjdk/jdk17u-dev/pull/616 > https://github.com/openjdk/jdk11u-dev/pull/1294 > > Is this issue known already? > Could someone please have a look? > > Thanks! > Goetz. > From goetz at openjdk.org Mon Aug 1 09:42:44 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 09:42:44 GMT Subject: [jdk11u-dev] RFR: 8269039: Disable SHA-1 Signed JARs In-Reply-To: References: Message-ID: On Wed, 20 Jul 2022 07:44:55 GMT, Goetz Lindenmaier wrote: > src/java.base/share/conf/security/java.security > Does not resolve because 11 mentions "include jdk.disabled.namedCurves" > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java > Some hunks did not apply because DISABLED_CHECK was renamed > to JAR_DISABLED_CHECK in 17. > Other hunks patch methods not in 11: checkWeakKey(), checkWeakAlg() > as well as the calls to these methods. > > test/jdk/java/security/Security/signedfirst/Dyn.sh > test/jdk/java/security/Security/signedfirst/Static.sh > Deleting did not apply. > > test/jdk/java/util/jar/JarInputStream/signed.jar > Patching this binary file failed. I just copied > the file from 17. > > test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java > Patch skipped, test not in 11. > > test/jdk/sun/security/tools/jarsigner/TimestampCheck.java > Resolved. Checked output differed. > > test/lib/jdk/test/lib/security/SecurityUtils.java > The change to this file was already backported. > > In addition, I adapted > sun/security/tools/jarsigner/DefaultOptions.java > sun/security/tools/jarsigner/NameClash.java > sun/security/tools/jarsigner/EC.java > according to > "8172404: Tools should warn if weak algorithms are used before restricting them" > which makes the tests pass. Having double-checked with my colleagues I would like to push it as-is. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1244 From goetz at openjdk.org Mon Aug 1 12:54:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:54:47 GMT Subject: [jdk17u-dev] RFR: 8291595: [17u] Delete files missed in backport of 8269039 Message-ID: <_VA0YFMq2Tl83yKOXKX291QFqD1_X0Rs0Hb7RYxk41A=.fdac3c19-1983-4dcf-b24b-df8a3e54fad9@github.com> Just deleted the files. I missed deleting them when I backported 8269039: Disable SHA-1 Signed JARs ------------- Commit messages: - 8291595: [17u] Delete file missed in backport of 8269039 Changes: https://git.openjdk.org/jdk17u-dev/pull/617/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=617&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291595 Stats: 0 lines in 2 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/617.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/617/head:pull/617 PR: https://git.openjdk.org/jdk17u-dev/pull/617 From stuefe at openjdk.org Mon Aug 1 12:54:48 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 1 Aug 2022 12:54:48 GMT Subject: [jdk17u-dev] RFR: 8291595: [17u] Delete files missed in backport of 8269039 In-Reply-To: <_VA0YFMq2Tl83yKOXKX291QFqD1_X0Rs0Hb7RYxk41A=.fdac3c19-1983-4dcf-b24b-df8a3e54fad9@github.com> References: <_VA0YFMq2Tl83yKOXKX291QFqD1_X0Rs0Hb7RYxk41A=.fdac3c19-1983-4dcf-b24b-df8a3e54fad9@github.com> Message-ID: On Sun, 31 Jul 2022 16:10:06 GMT, Goetz Lindenmaier wrote: > Just deleted the files. > I missed deleting them when I backported 8269039: Disable SHA-1 Signed JARs +1 ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/617 From goetz at openjdk.org Mon Aug 1 12:55:10 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:55:10 GMT Subject: [jdk11u-dev] RFR: 8267880: Upgrade the default PKCS12 MAC algorithm Message-ID: I backport this for parity with 11.0.17-oracle. I crafted this according to JDK-8153005, JDK-8267599 ------------- Commit messages: - 8267880: Upgrade the default PKCS12 MAC algorithm Changes: https://git.openjdk.org/jdk11u-dev/pull/1296/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1296&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267880 Stats: 14 lines in 3 files changed: 0 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1296.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1296/head:pull/1296 PR: https://git.openjdk.org/jdk11u-dev/pull/1296 From goetz at openjdk.org Mon Aug 1 12:57:28 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:57:28 GMT Subject: [jdk17u-dev] RFR: 8283623: Create an automated regression test for JDK-4525475 Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport 7381868afe316a9c62baa4618c49b68a5c43be01 Changes: https://git.openjdk.org/jdk17u-dev/pull/612/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=612&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283623 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/612.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/612/head:pull/612 PR: https://git.openjdk.org/jdk17u-dev/pull/612 From goetz at openjdk.org Mon Aug 1 12:57:28 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:57:28 GMT Subject: [jdk17u-dev] RFR: 8283623: Create an automated regression test for JDK-4525475 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 12:29:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. Pre-submit tests: ant download failed. Unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/612 From goetz at openjdk.org Mon Aug 1 12:59:04 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:59:04 GMT Subject: [jdk17u-dev] RFR: 8283245: Create a test for JDK-4670319 Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport 4ce3cf12bff025441f658e1857e92486b5d73ee6 Changes: https://git.openjdk.org/jdk17u-dev/pull/615/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=615&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283245 Stats: 115 lines in 1 file changed: 115 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/615.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/615/head:pull/615 PR: https://git.openjdk.org/jdk17u-dev/pull/615 From goetz at openjdk.org Mon Aug 1 12:59:12 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:59:12 GMT Subject: [jdk17u-dev] RFR: 8282933: Create a test for JDK-4529616 Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport a0b984a778c1f9a89fd3e1e474b5a5165a0841b0 Changes: https://git.openjdk.org/jdk17u-dev/pull/616/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=616&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282933 Stats: 92 lines in 1 file changed: 92 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/616.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/616/head:pull/616 PR: https://git.openjdk.org/jdk17u-dev/pull/616 From goetz at openjdk.org Mon Aug 1 12:59:33 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:59:33 GMT Subject: [jdk17u-dev] RFR: 8283621: Write a regression test for CCC4400728 Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport 632825c6d2933c8f1e63569199413ecaa74b6740 Changes: https://git.openjdk.org/jdk17u-dev/pull/613/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=613&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283621 Stats: 77 lines in 1 file changed: 77 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/613.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/613/head:pull/613 PR: https://git.openjdk.org/jdk17u-dev/pull/613 From goetz at openjdk.org Mon Aug 1 12:59:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:59:39 GMT Subject: [jdk11u-dev] RFR: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test Message-ID: I backport this for parity with 11.0.17-oracle. Clean backport from 17. 17 includes a test infra file needed for the backport. I had to adapt a string literal in PrintGlyphVectorTest to make it compile with 11. ------------- Commit messages: - Backport 37c9cd1555484db9c47d97cb21aa3259519fb2fc Changes: https://git.openjdk.org/jdk11u-dev/pull/1295/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1295&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283803 Stats: 122 lines in 1 file changed: 57 ins; 41 del; 24 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1295.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1295/head:pull/1295 PR: https://git.openjdk.org/jdk11u-dev/pull/1295 From stuefe at openjdk.org Mon Aug 1 12:59:40 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 1 Aug 2022 12:59:40 GMT Subject: [jdk11u-dev] RFR: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test In-Reply-To: References: Message-ID: On Mon, 1 Aug 2022 09:21:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. > > Clean backport from 17. 17 includes a test infra file needed for the backport. > I had to adapt a string literal in PrintGlyphVectorTest to make it compile with 11. I'm confused here. The original patch contains the file test/jdk/java/awt/regtesthelpers/PassFailJFrame.java which is missing from this patch. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1295 From goetz at openjdk.org Mon Aug 1 12:59:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 12:59:52 GMT Subject: [jdk17u-dev] RFR: 8283507: Create a regression test for RFE 4287690 Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport 7edd18612155b8e66f214a17e65ef775b470955e Changes: https://git.openjdk.org/jdk17u-dev/pull/614/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=614&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283507 Stats: 200 lines in 1 file changed: 200 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/614.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/614/head:pull/614 PR: https://git.openjdk.org/jdk17u-dev/pull/614 From kevin.rushforth at oracle.com Mon Aug 1 13:00:22 2022 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 1 Aug 2022 06:00:22 -0700 Subject: Bots for backports down? In-Reply-To: References: Message-ID: There was a general problem with the bots getting stuck. It should be resolved now. -- Kevin On 8/1/2022 2:33 AM, Lindenmaier, Goetz wrote: > > Hi, > > my recent backports have not been handled by the bots: > > https://github.com/openjdk/jdk17u-dev/pull/616 > > https://github.com/openjdk/jdk11u-dev/pull/1294 > > Is this issue known already? > > Could someone please have a look? > > Thanks! > > ? Goetz. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz at openjdk.org Mon Aug 1 13:00:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 13:00:47 GMT Subject: [jdk11u-dev] RFR: 8283623: Create an automated regression test for JDK-4525475 Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 7381868afe316a9c62baa4618c49b68a5c43be01 Changes: https://git.openjdk.org/jdk11u-dev/pull/1290/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1290&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283623 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1290.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1290/head:pull/1290 PR: https://git.openjdk.org/jdk11u-dev/pull/1290 From goetz at openjdk.org Mon Aug 1 13:00:55 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 13:00:55 GMT Subject: [jdk11u-dev] RFR: 8283245: Create a test for JDK-4670319 Message-ID: <9MWI5jpA5raukjHJR9Zq643tUFM3CwzHRJItNknSJgM=.f484ebe4-be8c-4ee9-b0d6-ee0779d856c9@github.com> I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 4ce3cf12bff025441f658e1857e92486b5d73ee6 Changes: https://git.openjdk.org/jdk11u-dev/pull/1292/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1292&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283245 Stats: 115 lines in 1 file changed: 115 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1292.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1292/head:pull/1292 PR: https://git.openjdk.org/jdk11u-dev/pull/1292 From goetz at openjdk.org Mon Aug 1 13:00:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 13:00:56 GMT Subject: [jdk11u-dev] RFR: 8283245: Create a test for JDK-4670319 In-Reply-To: <9MWI5jpA5raukjHJR9Zq643tUFM3CwzHRJItNknSJgM=.f484ebe4-be8c-4ee9-b0d6-ee0779d856c9@github.com> References: <9MWI5jpA5raukjHJR9Zq643tUFM3CwzHRJItNknSJgM=.f484ebe4-be8c-4ee9-b0d6-ee0779d856c9@github.com> Message-ID: On Sun, 31 Jul 2022 12:43:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. Pre-submit tests: CompensatedSums failed. This happens sporadic. Unrelatred. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1292 From goetz at openjdk.org Mon Aug 1 13:01:03 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 13:01:03 GMT Subject: [jdk11u-dev] RFR: 8283507: Create a regression test for RFE 4287690 Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 7edd18612155b8e66f214a17e65ef775b470955e Changes: https://git.openjdk.org/jdk11u-dev/pull/1294/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1294&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283507 Stats: 200 lines in 1 file changed: 200 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1294.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1294/head:pull/1294 PR: https://git.openjdk.org/jdk11u-dev/pull/1294 From goetz at openjdk.org Mon Aug 1 13:01:08 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 13:01:08 GMT Subject: [jdk11u-dev] RFR: 8283621: Write a regression test for CCC4400728 Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 632825c6d2933c8f1e63569199413ecaa74b6740 Changes: https://git.openjdk.org/jdk11u-dev/pull/1291/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1291&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283621 Stats: 77 lines in 1 file changed: 77 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1291.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1291/head:pull/1291 PR: https://git.openjdk.org/jdk11u-dev/pull/1291 From goetz at openjdk.org Mon Aug 1 13:01:19 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 13:01:19 GMT Subject: [jdk11u-dev] RFR: 8282933: Create a test for JDK-4529616 Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport a0b984a778c1f9a89fd3e1e474b5a5165a0841b0 Changes: https://git.openjdk.org/jdk11u-dev/pull/1293/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1293&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282933 Stats: 92 lines in 1 file changed: 92 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1293.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1293/head:pull/1293 PR: https://git.openjdk.org/jdk11u-dev/pull/1293 From goetz at openjdk.org Mon Aug 1 13:01:20 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 1 Aug 2022 13:01:20 GMT Subject: [jdk11u-dev] RFR: 8282933: Create a test for JDK-4529616 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 12:56:27 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. Pre-submit tests: unpacking the tests failde, infra problem. Unrealted. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1293 From yan at openjdk.org Mon Aug 1 13:04:11 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 1 Aug 2022 13:04:11 GMT Subject: [jdk13u-dev] RFR: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run Message-ID: Clean backport of a test fix. The fixed test passed OK. ------------- Commit messages: - Backport 7e211d7daac32dca8f26f408d1a3b2c7805b5a2e Changes: https://git.openjdk.org/jdk13u-dev/pull/385/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=385&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287672 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/385.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/385/head:pull/385 PR: https://git.openjdk.org/jdk13u-dev/pull/385 From yan at openjdk.org Mon Aug 1 13:08:56 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 1 Aug 2022 13:08:56 GMT Subject: [jdk15u-dev] RFR: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run Message-ID: <6_4V0yWuqlt_FkasbAVaLTE1-8xJuu6ur01NXVBULnQ=.c3dda3f3-976a-4557-9f61-86ad3b1dc8b1@github.com> Clean backport of a test fix. The fixed test passed OK. ------------- Commit messages: - Backport 7e211d7daac32dca8f26f408d1a3b2c7805b5a2e Changes: https://git.openjdk.org/jdk15u-dev/pull/249/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=249&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287672 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/249.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/249/head:pull/249 PR: https://git.openjdk.org/jdk15u-dev/pull/249 From yan at openjdk.org Mon Aug 1 13:35:12 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 1 Aug 2022 13:35:12 GMT Subject: [jdk15u-dev] Integrated: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run In-Reply-To: <6_4V0yWuqlt_FkasbAVaLTE1-8xJuu6ur01NXVBULnQ=.c3dda3f3-976a-4557-9f61-86ad3b1dc8b1@github.com> References: <6_4V0yWuqlt_FkasbAVaLTE1-8xJuu6ur01NXVBULnQ=.c3dda3f3-976a-4557-9f61-86ad3b1dc8b1@github.com> Message-ID: On Mon, 1 Aug 2022 08:53:56 GMT, Yuri Nesterenko wrote: > Clean backport of a test fix. The fixed test passed OK. This pull request has now been integrated. Changeset: e3c3e3d0 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/e3c3e3d0eeaa37378c92506445e125450686e160 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run Backport-of: 7e211d7daac32dca8f26f408d1a3b2c7805b5a2e ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/249 From yan at openjdk.org Mon Aug 1 13:36:27 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 1 Aug 2022 13:36:27 GMT Subject: [jdk13u-dev] Integrated: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run In-Reply-To: References: Message-ID: On Mon, 1 Aug 2022 08:53:52 GMT, Yuri Nesterenko wrote: > Clean backport of a test fix. The fixed test passed OK. This pull request has now been integrated. Changeset: 76d36926 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/76d36926a7b2cff8050a830c0aadb1efc17d0420 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run Backport-of: 7e211d7daac32dca8f26f408d1a3b2c7805b5a2e ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/385 From clanger at openjdk.org Mon Aug 1 15:47:07 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 1 Aug 2022 15:47:07 GMT Subject: [jdk11u-dev] RFR: 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available [v4] In-Reply-To: References: Message-ID: > This is a backport of [JDK-8238268](https://bugs.openjdk.org/browse/JDK-8238268). We need it, because the backport of [JDK-8215544](https://bugs.openjdk.org/browse/JDK-8215544) has added code that calls `sudo -E` on MacOS without the option `-n`. This call might not return when sudo starts prompting for a password. In our CI it leads to hanging processes when subsequent tests call sudo, even with the -n option. This fix rectifies that behavior. And, after all, it improves test coverage on MacOS, so it's a good backport candidate. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Add back missing statement to ClhsdbLauncher.java - Merge branch 'master' into RealCLanger-backport-a1476361 - Backport a147636157c011dac5d8c7aa6809c3c55f1384fa ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1269/files - new: https://git.openjdk.org/jdk11u-dev/pull/1269/files/53f80c49..aa2890bd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1269&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1269&range=02-03 Stats: 61336 lines in 365 files changed: 34043 ins; 19735 del; 7558 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1269.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1269/head:pull/1269 PR: https://git.openjdk.org/jdk11u-dev/pull/1269 From clanger at openjdk.org Mon Aug 1 15:47:10 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 1 Aug 2022 15:47:10 GMT Subject: [jdk11u-dev] RFR: 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available [v3] In-Reply-To: References: Message-ID: On Sat, 23 Jul 2022 09:32:05 GMT, Christoph Langer wrote: >> This is a backport of [JDK-8238268](https://bugs.openjdk.org/browse/JDK-8238268). We need it, because the backport of [JDK-8215544](https://bugs.openjdk.org/browse/JDK-8215544) has added code that calls `sudo -E` on MacOS without the option `-n`. This call might not return when sudo starts prompting for a password. In our CI it leads to hanging processes when subsequent tests call sudo, even with the -n option. This fix rectifies that behavior. And, after all, it improves test coverage on MacOS, so it's a good backport candidate. > > Christoph Langer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport a147636157c011dac5d8c7aa6809c3c55f1384fa Hi Goetz, thanks for the review. Yes, I have the patch running in the SAP tests without regressions, as far as I can tell. > test/hotspot/jtreg/serviceability/sa/ClhsdbLauncher.java Why do you remove `processBuilder.redirectError(ProcessBuilder.Redirect.INHERIT);` Hm, when I looked at [JDK-8234277](https://bugs.openjdk.org/browse/JDK-8234277), I thought it could be a good idea to do the removal in this change already but maybe you're right and we should keep it consistent. I'm actually not sure about the effects so I'll re-add it. > test/lib/jdk/test/lib/Platform.java Imports were adapted. isSignedOSX() is added. What is the original change of this? Please mention in the JBS FixRequest comment that you include code from that change. This originally comes from [JDK-8238196](https://bugs.openjdk.org/browse/JDK-8238196). Since merely all of the code of that bug is part of this PR as well (either as is or augmented), I'll add JDK-8238196 to this backport, too. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1269 From clanger at openjdk.org Mon Aug 1 21:46:08 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 1 Aug 2022 21:46:08 GMT Subject: [jdk11u-dev] RFR: 8239708: Split basics.m4 into basic.m4 and util.m4 In-Reply-To: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> References: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> Message-ID: On Thu, 28 Jul 2022 12:44:22 GMT, George Adams wrote: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. > > This backport will also considerably help many build/toolchain backports going forwards as this one nearly always trips me up when I backport patches. > > This backport will allow me to more easily backport [8257679: Improved unix compatibility layer in Windows build (winenv)](https://github.com/openjdk/jdk/commit/d29c78da). > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. I've finally managed to review this backport a bit more in depth. First of all, there are some other changes of which you bring in some parts but not everything. There are a few which are good candidates for backports as well, so I would recommend to do so before merging this patch. Namely: https://bugs.openjdk.org/browse/JDK-8218413 (https://github.com/openjdk/jdk/commit/9efdb33a59f7db7b4b39e113265a3b3ba513c5d3) https://bugs.openjdk.org/browse/JDK-8217032 (https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf) https://bugs.openjdk.org/browse/JDK-8221907 (https://github.com/openjdk/jdk/commit/0974861dd800fdb44b3888e68b08c570f1985b58) https://bugs.openjdk.org/browse/JDK-8233712 (https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9) Then, from https://bugs.openjdk.org/browse/JDK-8211724 (https://github.com/openjdk/jdk/commit/d3458328a28704288daccc1ed036bae3df6a37e6) you bring a little hunk: `BASIC_REQUIRE_PROGS(MKDIR, [gmkdir mkdir])`. That's ok and the rest of the change is too much, so that's alright. https://bugs.openjdk.org/browse/JDK-8206125 (https://github.com/openjdk/jdk/commit/7ae384b2ad25d39f271f936ee98ab28a5f92fa94) is partly implemented in your change. Some hunks in new util_windows.m4 are missing, however. Please make sure it's completely contained in your backport and add the issue to this PR then. https://bugs.openjdk.org/browse/JDK-8213239 (https://github.com/openjdk/jdk/commit/68dbbf566d8d504308367005048d274aebfd5b50) is contained in your PR. Please mark as backported by adding it to this PR. https://bugs.openjdk.org/browse/JDK-8240972: Make sure that the changes don't get lost. The implementation file is a different before and after this change. See: https://github.com/openjdk/jdk11u-dev/commit/f771367f73bd01648a454fdd0298b8b4479a3ca0 vs. https://github.com/openjdk/jdk/commit/e30b89e1389ccd7bd2c6bb2265a3110f6fcd31de Then, the backport of https://bugs.openjdk.org/browse/JDK-8285728 (https://github.com/openjdk/jdk11u-dev/commit/f00776b653b9d0e1d556c6b44446fe18d72617c1) must not be lost which it currently would. And finally, we should thoroughly check whether the fix for `8226346: Build better binary builders` (non-public bug, contained in a CPU release) is still intact after this PR. The implementation file is also different, see https://github.com/openjdk/jdk11u-dev/commit/3e9a9c9c4955185ae2be6dd97ddf1c03a4588395 vs. https://github.com/openjdk/jdk/commit/4df99aa7aeaed0d6132ca5c86f803f1096df8841 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1277 From clanger at openjdk.org Mon Aug 1 22:42:05 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 1 Aug 2022 22:42:05 GMT Subject: [jdk11u-dev] RFR: 8221871: javadoc should not set role=region on
elements [v6] In-Reply-To: References: Message-ID: On Fri, 29 Jul 2022 08:26:07 GMT, psoujany wrote: >> Backport javadoc should not set role=region on
elements. >> >> The bug report for the same : https://bugs.openjdk.org/browse/JDK-8221871 > > psoujany has updated the pull request incrementally with one additional commit since the last revision: > > Fixing whitespace errors Looks good now. SAP regression testing shows no problems any more. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1219 From phh at openjdk.org Mon Aug 1 23:17:16 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 1 Aug 2022 23:17:16 GMT Subject: [jdk17u-dev] RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java [v3] In-Reply-To: References: Message-ID: On Tue, 26 Jul 2022 08:10:05 GMT, Shruthi wrote: >> OpenJDK PR : https://github.com/openjdk/jdk/pull/9369 >> OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471 > > Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport?987656d69065b5b61d658cec3704a181a4aef18b Shruthi, do you need a spnsor? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/598 From goetz at openjdk.org Tue Aug 2 06:48:55 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 06:48:55 GMT Subject: [jdk11u-dev] RFR: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.17-oracle. > > Clean backport from 17. 17 includes a test infra file needed for the backport. > I had to adapt a string literal in PrintGlyphVectorTest to make it compile with 11. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add forgotten file ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1295/files - new: https://git.openjdk.org/jdk11u-dev/pull/1295/files/7bbdb108..b8d7bba9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1295&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1295&range=00-01 Stats: 321 lines in 1 file changed: 321 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1295.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1295/head:pull/1295 PR: https://git.openjdk.org/jdk11u-dev/pull/1295 From goetz at openjdk.org Tue Aug 2 06:48:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 06:48:56 GMT Subject: [jdk11u-dev] RFR: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test In-Reply-To: References: Message-ID: On Mon, 1 Aug 2022 09:21:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. > > Clean backport from 17. 17 includes a test infra file needed for the backport. > I had to adapt a string literal in PrintGlyphVectorTest to make it compile with 11. Sorry, I just forgot to git add the file. Fixed. t is unchanged from 17. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1295 From stuefe at openjdk.org Tue Aug 2 06:55:18 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 2 Aug 2022 06:55:18 GMT Subject: [jdk11u-dev] RFR: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v2] In-Reply-To: References: Message-ID: <7cQ3I-Q0ef50j4dqlw47E2VIMVqM8zlxE0Jx0Urny90=.3b1139b0-e189-4149-b98a-f9f5a4369689@github.com> On Tue, 2 Aug 2022 06:48:55 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.17-oracle. >> >> Clean backport from 17. 17 includes a test infra file needed for the backport. >> I had to adapt a string literal in PrintGlyphVectorTest to make it compile with 11. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add forgotten file LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1295 From stuefe at openjdk.org Tue Aug 2 06:55:20 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 2 Aug 2022 06:55:20 GMT Subject: [jdk11u-dev] RFR: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 06:45:36 GMT, Goetz Lindenmaier wrote: > Sorry, I just forgot to git add the file. Fixed. t is unchanged from 17. No problem. I thought you wanted to test me. :-) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1295 From clanger at openjdk.org Tue Aug 2 07:26:56 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 07:26:56 GMT Subject: [jdk11u-dev] RFR: 8221871: javadoc should not set role=region on
elements [v2] In-Reply-To: References: <88SeUqsDT280tnYkHZlYbvSrBxx8FXUKcP-SVmaXIow=.8260b901-e756-461f-a650-0ac2d6dc775f@github.com> Message-ID: On Thu, 28 Jul 2022 15:32:29 GMT, psoujany wrote: >> Our testing shows failures in jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java, please have a look. > >> Our testing shows failures in jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java, please have a look. > > Fixed the test failures, Could you please check once. Thank you. @psoujany You must not integrate a fix in a JDK Updates project before requesting (and receiving) maintainer approval. Please refer to the [Wiki](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix), especially point 6. In case you don't have JBS access, I can add the fix request on your behalf. In that case, please post the text for the fix request comment here and I'll copy&paste it over. Thx. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1219 From christoph.langer at sap.com Tue Aug 2 08:33:32 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 2 Aug 2022 08:33:32 +0000 Subject: Bots for backports down? In-Reply-To: References: Message-ID: Hi, looks like the bot got stuck again: https://github.com/openjdk/jdk11u-dev/pull/1297 Best regards Christoph From: jdk-updates-dev On Behalf Of Kevin Rushforth Sent: Montag, 1. August 2022 15:00 To: Lindenmaier, Goetz ; ops at openjdk.java.net Cc: jdk-updates-dev Subject: Re: Bots for backports down? There was a general problem with the bots getting stuck. It should be resolved now. -- Kevin On 8/1/2022 2:33 AM, Lindenmaier, Goetz wrote: Hi, my recent backports have not been handled by the bots: https://github.com/openjdk/jdk17u-dev/pull/616 https://github.com/openjdk/jdk11u-dev/pull/1294 Is this issue known already? Could someone please have a look? Thanks! Goetz. -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz at openjdk.org Tue Aug 2 08:48:44 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 08:48:44 GMT Subject: [jdk17u-dev] Integrated: 8283623: Create an automated regression test for JDK-4525475 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 12:29:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: cbfb6549 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/cbfb65495886856ccee8618b0f58de9675aeba5c Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod 8283623: Create an automated regression test for JDK-4525475 Backport-of: 7381868afe316a9c62baa4618c49b68a5c43be01 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/612 From goetz at openjdk.org Tue Aug 2 09:03:30 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:03:30 GMT Subject: [jdk11u-dev] Integrated: 8269039: Disable SHA-1 Signed JARs In-Reply-To: References: Message-ID: On Wed, 20 Jul 2022 07:44:55 GMT, Goetz Lindenmaier wrote: > src/java.base/share/conf/security/java.security > Does not resolve because 11 mentions "include jdk.disabled.namedCurves" > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java > Some hunks did not apply because DISABLED_CHECK was renamed > to JAR_DISABLED_CHECK in 17. > Other hunks patch methods not in 11: checkWeakKey(), checkWeakAlg() > as well as the calls to these methods. > > test/jdk/java/security/Security/signedfirst/Dyn.sh > test/jdk/java/security/Security/signedfirst/Static.sh > Deleting did not apply. > > test/jdk/java/util/jar/JarInputStream/signed.jar > Patching this binary file failed. I just copied > the file from 17. > > test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java > Patch skipped, test not in 11. > > test/jdk/sun/security/tools/jarsigner/TimestampCheck.java > Resolved. Checked output differed. > > test/lib/jdk/test/lib/security/SecurityUtils.java > The change to this file was already backported. > > In addition, I adapted > sun/security/tools/jarsigner/DefaultOptions.java > sun/security/tools/jarsigner/NameClash.java > sun/security/tools/jarsigner/EC.java > according to > "8172404: Tools should warn if weak algorithms are used before restricting them" > which makes the tests pass. This pull request has now been integrated. Changeset: 5a0824ba Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8 Stats: 638 lines in 28 files changed: 300 ins; 214 del; 124 mod 8269039: Disable SHA-1 Signed JARs Reviewed-by: mbalao Backport-of: 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1244 From goetz at openjdk.org Tue Aug 2 09:05:40 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:05:40 GMT Subject: [jdk11u-dev] Integrated: 8283623: Create an automated regression test for JDK-4525475 In-Reply-To: References: Message-ID: <8--JqpEk8FW0sdeRVdaHsVSUzDE0y-gZ4i2T9y9T3kA=.4298f540-e140-4336-9bc3-f66c0a4ee2e7@github.com> On Sun, 31 Jul 2022 12:31:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: b235f51c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b235f51c7288043852a71e08fa873b2745881aec Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod 8283623: Create an automated regression test for JDK-4525475 Backport-of: 7381868afe316a9c62baa4618c49b68a5c43be01 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1290 From goetz at openjdk.org Tue Aug 2 09:05:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:05:47 GMT Subject: [jdk17u-dev] Integrated: 8283621: Write a regression test for CCC4400728 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 12:31:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 016e5004 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/016e5004571f48934e3d9011bf096a7126837dfc Stats: 77 lines in 1 file changed: 77 ins; 0 del; 0 mod 8283621: Write a regression test for CCC4400728 Backport-of: 632825c6d2933c8f1e63569199413ecaa74b6740 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/613 From goetz at openjdk.org Tue Aug 2 09:07:30 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:07:30 GMT Subject: [jdk11u-dev] Integrated: 8283621: Write a regression test for CCC4400728 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 12:35:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 15335203 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/15335203a838112dbd46813e69a3474f07f2876b Stats: 77 lines in 1 file changed: 77 ins; 0 del; 0 mod 8283621: Write a regression test for CCC4400728 Backport-of: 632825c6d2933c8f1e63569199413ecaa74b6740 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1291 From goetz at openjdk.org Tue Aug 2 09:07:37 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:07:37 GMT Subject: [jdk11u-dev] Integrated: 8283507: Create a regression test for RFE 4287690 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 13:09:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 1ab3f82e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/1ab3f82ea905f64c2ceba1a4b9041c8db25fe163 Stats: 200 lines in 1 file changed: 200 ins; 0 del; 0 mod 8283507: Create a regression test for RFE 4287690 Backport-of: 7edd18612155b8e66f214a17e65ef775b470955e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1294 From goetz at openjdk.org Tue Aug 2 09:12:50 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:12:50 GMT Subject: [jdk17u-dev] Integrated: 8282933: Create a test for JDK-4529616 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 13:15:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 17982d84 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/17982d846d6750dc32552c07541959eef653e524 Stats: 92 lines in 1 file changed: 92 ins; 0 del; 0 mod 8282933: Create a test for JDK-4529616 Backport-of: a0b984a778c1f9a89fd3e1e474b5a5165a0841b0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/616 From goetz at openjdk.org Tue Aug 2 09:13:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:13:02 GMT Subject: [jdk11u-dev] Integrated: 8282933: Create a test for JDK-4529616 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 12:56:27 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 88713032 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/88713032621dd6ed39894df60e913632fa04bae0 Stats: 92 lines in 1 file changed: 92 ins; 0 del; 0 mod 8282933: Create a test for JDK-4529616 Backport-of: a0b984a778c1f9a89fd3e1e474b5a5165a0841b0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1293 From goetz at openjdk.org Tue Aug 2 09:16:53 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:16:53 GMT Subject: [jdk17u-dev] Integrated: 8283507: Create a regression test for RFE 4287690 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 13:05:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 64db633e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/64db633e9152dd54296e09963304312c361ad6b2 Stats: 200 lines in 1 file changed: 200 ins; 0 del; 0 mod 8283507: Create a regression test for RFE 4287690 Backport-of: 7edd18612155b8e66f214a17e65ef775b470955e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/614 From goetz at openjdk.org Tue Aug 2 09:19:41 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:19:41 GMT Subject: [jdk11u-dev] RFR: 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available [v4] In-Reply-To: References: Message-ID: On Mon, 1 Aug 2022 15:47:07 GMT, Christoph Langer wrote: >> This is a backport of [JDK-8238268](https://bugs.openjdk.org/browse/JDK-8238268). We need it, because the backport of [JDK-8215544](https://bugs.openjdk.org/browse/JDK-8215544) has added code that calls `sudo -E` on MacOS without the option `-n`. This call might not return when sudo starts prompting for a password. In our CI it leads to hanging processes when subsequent tests call sudo, even with the -n option. This fix rectifies that behavior. And, after all, it improves test coverage on MacOS, so it's a good backport candidate. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Add back missing statement to ClhsdbLauncher.java > - Merge branch 'master' into RealCLanger-backport-a1476361 > - Backport a147636157c011dac5d8c7aa6809c3c55f1384fa Thanks for the clarifications. LGTM. ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1269 From goetz at openjdk.org Tue Aug 2 09:32:16 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 09:32:16 GMT Subject: [jdk11u-dev] RFR: 8267880: Upgrade the default PKCS12 MAC algorithm [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.17-oracle. > > I crafted this according to JDK-8153005, JDK-8267599 Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8267880: Upgrade the default PKCS12 MAC algorithm ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1296/files - new: https://git.openjdk.org/jdk11u-dev/pull/1296/files/cfab0608..ca4059d3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1296&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1296&range=00-01 Stats: 9 lines in 1 file changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1296.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1296/head:pull/1296 PR: https://git.openjdk.org/jdk11u-dev/pull/1296 From duke at openjdk.org Tue Aug 2 10:02:58 2022 From: duke at openjdk.org (Shruthi) Date: Tue, 2 Aug 2022 10:02:58 GMT Subject: [jdk17u-dev] RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java [v3] In-Reply-To: References: Message-ID: On Mon, 1 Aug 2022 23:14:51 GMT, Paul Hohensee wrote: > Shruthi, do you need a spnsor? Yes Paul ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/598 From duke at openjdk.org Tue Aug 2 10:12:24 2022 From: duke at openjdk.org (George Adams) Date: Tue, 2 Aug 2022 10:12:24 GMT Subject: [jdk11u-dev] RFR: 8290000: Bump macOS GitHub actions to macOS 11 Message-ID: macOS 10.15 has been deprecated for some time and will be removed completely on August 30th. See https://github.com/actions/virtual-environments#available-environments and https://github.com/actions/virtual-environments/issues/5583 for context. This PR doesn't apply cleanly because it was added to the GitHub actions rewrite in tip. As it's unlikely that I will have a backported rewrite by August 30th my preference is to backport this way round. ------------- Commit messages: - Backport 4e6cd67fec3d978f4c8c1aed95a1d09b544eff68 Changes: https://git.openjdk.org/jdk11u-dev/pull/1297/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1297&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290000 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1297.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1297/head:pull/1297 PR: https://git.openjdk.org/jdk11u-dev/pull/1297 From clanger at openjdk.org Tue Aug 2 10:12:24 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 10:12:24 GMT Subject: [jdk11u-dev] RFR: 8290000: Bump macOS GitHub actions to macOS 11 In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 07:50:45 GMT, George Adams wrote: > macOS 10.15 has been deprecated for some time and will be removed completely on August 30th. See https://github.com/actions/virtual-environments#available-environments and https://github.com/actions/virtual-environments/issues/5583 for context. > > This PR doesn't apply cleanly because it was added to the GitHub actions rewrite in tip. As it's unlikely that I will have a backported rewrite by August 30th my preference is to backport this way round. Makes sense. Let's see if the GHA builds remain green. ? ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1297 From mbaesken at openjdk.org Tue Aug 2 10:42:33 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 2 Aug 2022 10:42:33 GMT Subject: [jdk11u-dev] RFR: 8267880: Upgrade the default PKCS12 MAC algorithm [v2] In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 09:32:16 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.17-oracle. >> >> In 11.0.12, "JDK-8153005 Upgrade the default PKCS12 encryption/MAC algorithms" was pushed. >> Some parts of it were reverted right away in "JDK-8267599 Revert the change to the default PKCS12 macAlgorithm and macIterationCount props for 11u/8u/7u". >> This change now again enables 8153005. It is basically the reverse patch of 8267599, >> where ParamsTest.java has been renamed to KeytoolOpensslInteropTest.java. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8267880: Upgrade the default PKCS12 MAC algorithm LGTM, but be aware of the issues described here https://bugs.openjdk.org/browse/JDK-8267599 ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1296 From jdowland at openjdk.org Tue Aug 2 10:45:20 2022 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 2 Aug 2022 10:45:20 GMT Subject: [jdk11u-dev] RFR: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier Message-ID: This pull request contains a backport of commit [fe807217](https://github.com/openjdk/jdk/commit/fe807217a79753f84c00432e7451c17baa6645c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Yoshiki Sato on 15 Jun 2022 and was reviewed by Mandy Chung. I wish to backport it for Oracle parity. It does not apply cleanly due to a renamed file in jdk master subsequent to 11u: src/java.base/macosx/classes/{java/lang => jdk/internal/loader}/ClassLoaderHelper.java Manual testing results forthcoming; I'll add them as a comment on this PR. ------------- Commit messages: - 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier Changes: https://git.openjdk.org/jdk11u-dev/pull/1298/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1298&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287917 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1298.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1298/head:pull/1298 PR: https://git.openjdk.org/jdk11u-dev/pull/1298 From jdowland at openjdk.org Tue Aug 2 10:45:21 2022 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 2 Aug 2022 10:45:21 GMT Subject: [jdk11u-dev] RFR: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 10:12:51 GMT, Jonathan Dowland wrote: > This pull request contains a backport of commit [fe807217](https://github.com/openjdk/jdk/commit/fe807217a79753f84c00432e7451c17baa6645c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Yoshiki Sato on 15 Jun 2022 and was reviewed by Mandy Chung. > > I wish to backport it for Oracle parity. > > It does not apply cleanly due to a renamed file in jdk master subsequent to 11u: > > src/java.base/macosx/classes/{java/lang => jdk/internal/loader}/ClassLoaderHelper.java > > Manual testing results forthcoming; I'll add them as a comment on this PR. Test passes after manually building the native component ([as with the 17u backport](https://github.com/openjdk/jdk17u-dev/pull/506)): $ pushd test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache $ cc exeLibraryCache.c -o LibraryCache $ popd $ $JT_HOME/bin/jtreg -jdk:build/macosx-x86_64-server-release/images/jdk \ -nativepath:test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache \ test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache/LibraryFromCache.java ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1298 From duke at openjdk.org Tue Aug 2 10:49:49 2022 From: duke at openjdk.org (psoujany) Date: Tue, 2 Aug 2022 10:49:49 GMT Subject: [jdk11u-dev] RFR: 8221871: javadoc should not set role=region on
elements [v2] In-Reply-To: References: <88SeUqsDT280tnYkHZlYbvSrBxx8FXUKcP-SVmaXIow=.8260b901-e756-461f-a650-0ac2d6dc775f@github.com> Message-ID: On Tue, 2 Aug 2022 07:23:02 GMT, Christoph Langer wrote: >>> Our testing shows failures in jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java, please have a look. >> >> Fixed the test failures, Could you please check once. Thank you. > > @psoujany You must not integrate a fix in a JDK Updates project before requesting (and receiving) maintainer approval. Please refer to the [Wiki](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix), especially point 6. > > In case you don't have JBS access, I can add the fix request on your behalf. In that case, please post the text for the fix request comment here and I'll copy&paste it over. Thx. @RealCLanger Apologies for adding integrate tag. I don't have access to JBS. Please add _Fix Request 11_. This is actual openjdk bug https://bugs.openjdk.org/browse/JDK-8221871 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1219 From goetz at openjdk.org Tue Aug 2 10:54:54 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 10:54:54 GMT Subject: [jdk11u-dev] RFR: 8267880: Upgrade the default PKCS12 MAC algorithm [v2] In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 09:32:16 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.17-oracle. >> >> In 11.0.12, "JDK-8153005 Upgrade the default PKCS12 encryption/MAC algorithms" was pushed. >> Some parts of it were reverted right away in "JDK-8267599 Revert the change to the default PKCS12 macAlgorithm and macIterationCount props for 11u/8u/7u". >> This change now again enables 8153005. It is basically the reverse patch of 8267599, >> where ParamsTest.java has been renamed to KeytoolOpensslInteropTest.java. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8267880: Upgrade the default PKCS12 MAC algorithm Thanks for the review. Obviously this again introduces the incompatibilities this had been backed out for. But given the security roadmap and the fact that this comes in 7, 8 and 11 of Oracle I think this is bearable. Also, for 5 releases (11.0.12 to 11.0.17) there was the chance to adapt applications. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1296 From goetz.lindenmaier at sap.com Tue Aug 2 10:57:39 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 2 Aug 2022 10:57:39 +0000 Subject: [11u] integrate outstanding backport 8287432 In-Reply-To: References: Message-ID: Hi Andrew, Could you please integrate this backport of yours? Best regards, Goetz. From: Lindenmaier, Goetz Sent: Thursday, July 28, 2022 1:38 PM To: Andrew Haley Subject: [11u] integrate outstanding backport 8287432 Hi Andrew, Could you please integrate this change? Is there a reason not to push it? https://bugs.openjdk.org/browse/JDK-8287432 https://github.com/openjdk/jdk11u-dev/pull/1190 Best regards, Goetz. -------------- next part -------------- An HTML attachment was scrubbed... URL: From clanger at openjdk.org Tue Aug 2 11:01:00 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 11:01:00 GMT Subject: [jdk11u-dev] RFR: 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available [v4] In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 09:15:55 GMT, Goetz Lindenmaier wrote: > Thanks for the clarifications. LGTM. Thanks for review and approval. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1269 From clanger at openjdk.org Tue Aug 2 11:01:02 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 11:01:02 GMT Subject: [jdk11u-dev] Integrated: 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available In-Reply-To: References: Message-ID: On Fri, 22 Jul 2022 22:04:47 GMT, Christoph Langer wrote: > This is a backport of [JDK-8238268](https://bugs.openjdk.org/browse/JDK-8238268). We need it, because the backport of [JDK-8215544](https://bugs.openjdk.org/browse/JDK-8215544) has added code that calls `sudo -E` on MacOS without the option `-n`. This call might not return when sudo starts prompting for a password. In our CI it leads to hanging processes when subsequent tests call sudo, even with the -n option. This fix rectifies that behavior. And, after all, it improves test coverage on MacOS, so it's a good backport candidate. This pull request has now been integrated. Changeset: e80c7e18 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/e80c7e1868982a70fffa83954ca8081256009b90 Stats: 491 lines in 40 files changed: 220 ins; 118 del; 153 mod 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available 8238196: tests that use SA Attach should not be allowed to run against signed binaries on Mac OS X 10.14.5 and later Reviewed-by: goetz Backport-of: a147636157c011dac5d8c7aa6809c3c55f1384fa ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1269 From evergizova at openjdk.org Tue Aug 2 11:13:25 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 2 Aug 2022 11:13:25 GMT Subject: [jdk15u-dev] RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. Message-ID: I'd like to backport JDK-8280684 to 15u for parity with 11u. The patch doesn't apply cleanly due to copyright years and context difference in jfrJavaSupport.cpp, jfrJavaSupport.hpp and jfrStreamWriterHost.inline.hpp (JDK-8252685 and JDK-8183227 are not in 15u). Additionally, similar to 11u backport, the original condition `error_msg != NULL` is left without replacing NULL with nullptr, because C++14 Language Features was enabled since jdk16 (JDK-8208089). Tested with jdk/jfr and tier1. ------------- Commit messages: - Backport 9471f24ca191832669a13e5a1ea73f7097a25927 Changes: https://git.openjdk.org/jdk15u-dev/pull/250/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=250&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280684 Stats: 14 lines in 3 files changed: 8 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/250.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/250/head:pull/250 PR: https://git.openjdk.org/jdk15u-dev/pull/250 From clanger at openjdk.org Tue Aug 2 11:14:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 11:14:55 GMT Subject: [jdk17u-dev] RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java [v3] In-Reply-To: References: Message-ID: On Tue, 26 Jul 2022 08:10:05 GMT, Shruthi wrote: >> OpenJDK PR : https://github.com/openjdk/jdk/pull/9369 >> OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471 > > Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport?987656d69065b5b61d658cec3704a181a4aef18b > /integrate Before integration, this needs maintainer approval. See point 6 of the [Wiki](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix). Maybe Paul can help you to set the request label/comment. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/598 From goetz at openjdk.org Tue Aug 2 11:20:51 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 11:20:51 GMT Subject: [jdk11u-dev] RFR: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 3f5e48a44ee77d07dea3d2c4ae52aaf19b8dc7cb Changes: https://git.openjdk.org/jdk11u-dev/pull/1299/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1299&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288781 Stats: 58 lines in 2 files changed: 57 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1299.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1299/head:pull/1299 PR: https://git.openjdk.org/jdk11u-dev/pull/1299 From duke at openjdk.org Tue Aug 2 11:21:48 2022 From: duke at openjdk.org (Shruthi) Date: Tue, 2 Aug 2022 11:21:48 GMT Subject: [jdk17u-dev] RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java [v3] In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 11:12:40 GMT, Christoph Langer wrote: > > /integrate > > Before integration, this needs maintainer approval. See point 6 of the [Wiki](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix). Maybe Paul can help you to set the request label/comment. OK ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/598 From clanger at openjdk.org Tue Aug 2 11:26:49 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 11:26:49 GMT Subject: [jdk11u-dev] RFR: 8221871: javadoc should not set role=region on
elements [v2] In-Reply-To: References: <88SeUqsDT280tnYkHZlYbvSrBxx8FXUKcP-SVmaXIow=.8260b901-e756-461f-a650-0ac2d6dc775f@github.com> Message-ID: On Tue, 2 Aug 2022 07:23:02 GMT, Christoph Langer wrote: >>> Our testing shows failures in jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java, please have a look. >> >> Fixed the test failures, Could you please check once. Thank you. > > @psoujany You must not integrate a fix in a JDK Updates project before requesting (and receiving) maintainer approval. Please refer to the [Wiki](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix), especially point 6. > > In case you don't have JBS access, I can add the fix request on your behalf. In that case, please post the text for the fix request comment here and I'll copy&paste it over. Thx. > @RealCLanger Apologies for adding integrate tag. I don't have access to JBS. Please add _Fix Request 11_. This is actual openjdk bug https://bugs.openjdk.org/browse/JDK-8221871. Thank you. I've added the fix request metadata to the JBS bug. Let's wait for approval. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1219 From clanger at openjdk.org Tue Aug 2 11:30:38 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 11:30:38 GMT Subject: [jdk11u-dev] RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java In-Reply-To: References: Message-ID: <2qVuhqpq7t_yuqaL4lSApXJtaJirx_C-tn8DqSQRV0s=.98a72462-73a1-465f-9a3f-6a77dfc3769c@github.com> On Thu, 28 Jul 2022 20:48:33 GMT, Paul Hohensee wrote: >> OpenJDK PR : https://github.com/openjdk/jdk/pull/9369 >> OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471 > > Looks clean, lgtm. Same here: Before integration, this needs maintainer approval. See point 6 of the [Wiki](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix). @phohensee ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1273 From phh at openjdk.org Tue Aug 2 11:37:54 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 2 Aug 2022 11:37:54 GMT Subject: [jdk17u-dev] RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java [v3] In-Reply-To: References: Message-ID: <10-PlsavM-hoCaLoG0qAtA8TEr5qYcszZ8Y9NP1AgOs=.02b73629-ea6c-4939-a3e3-ca4edd5588ae@github.com> On Tue, 26 Jul 2022 08:10:05 GMT, Shruthi wrote: >> OpenJDK PR : https://github.com/openjdk/jdk/pull/9369 >> OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471 > > Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport?987656d69065b5b61d658cec3704a181a4aef18b Pre-submit test failure looks like an infrastructure issue. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/598 From evergizova at openjdk.org Tue Aug 2 11:39:28 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 2 Aug 2022 11:39:28 GMT Subject: [jdk13u-dev] RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. Message-ID: I'd like to backport JDK-8280684 to 13u for parity with 11u. The patch doesn't apply cleanly due to copyright years and context difference in jfrJavaSupport.cpp, jfrJavaSupport.hpp and jfrStreamWriterHost.inline.hpp (JDK-8252685 and JDK-8183227 are not in 13u). Additionally, similar to 11u backport, the original condition `error_msg != NULL` is left without replacing NULL with nullptr, because C++14 Language Features was enabled since jdk16 (JDK-8208089). Tested with jdk/jfr and tier1. ------------- Commit messages: - Backport 9471f24ca191832669a13e5a1ea73f7097a25927 Changes: https://git.openjdk.org/jdk13u-dev/pull/386/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=386&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280684 Stats: 14 lines in 3 files changed: 8 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/386.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/386/head:pull/386 PR: https://git.openjdk.org/jdk13u-dev/pull/386 From yan at openjdk.org Tue Aug 2 11:43:06 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 2 Aug 2022 11:43:06 GMT Subject: [jdk13u-dev] RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 11:29:21 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8280684 to 13u for parity with 11u. > The patch doesn't apply cleanly due to copyright years and context difference in jfrJavaSupport.cpp, jfrJavaSupport.hpp and jfrStreamWriterHost.inline.hpp (JDK-8252685 and JDK-8183227 are not in 13u). > Additionally, similar to 11u backport, the original condition `error_msg != NULL` is left without replacing NULL with nullptr, because C++14 Language Features was enabled since jdk16 (JDK-8208089). > > Tested with jdk/jfr and tier1. Marked as reviewed by yan (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/386 From yan at openjdk.org Tue Aug 2 11:43:48 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 2 Aug 2022 11:43:48 GMT Subject: [jdk15u-dev] RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 11:03:32 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8280684 to 15u for parity with 11u. > The patch doesn't apply cleanly due to copyright years and context difference in jfrJavaSupport.cpp, jfrJavaSupport.hpp and jfrStreamWriterHost.inline.hpp (JDK-8252685 and JDK-8183227 are not in 15u). > Additionally, similar to 11u backport, the original condition `error_msg != NULL` is left without replacing NULL with nullptr, because C++14 Language Features was enabled since jdk16 (JDK-8208089). > > Tested with jdk/jfr and tier1. Marked as reviewed by yan (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/250 From evergizova at openjdk.org Tue Aug 2 11:55:43 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 2 Aug 2022 11:55:43 GMT Subject: [jdk13u-dev] Integrated: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. In-Reply-To: References: Message-ID: <2wewMRQLI0LuY5YxXVAqQNkPZ4s0WTb_r7FFUnogfgY=.b50e96f0-1b00-4dc8-abcd-0cf5a589efbb@github.com> On Tue, 2 Aug 2022 11:29:21 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8280684 to 13u for parity with 11u. > The patch doesn't apply cleanly due to copyright years and context difference in jfrJavaSupport.cpp, jfrJavaSupport.hpp and jfrStreamWriterHost.inline.hpp (JDK-8252685 and JDK-8183227 are not in 13u). > Additionally, similar to 11u backport, the original condition `error_msg != NULL` is left without replacing NULL with nullptr, because C++14 Language Features was enabled since jdk16 (JDK-8208089). > > Tested with jdk/jfr and tier1. This pull request has now been integrated. Changeset: 0a6b1a08 Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk13u-dev/commit/0a6b1a08d90c9a17b25f6a9f45936433f8f880db Stats: 14 lines in 3 files changed: 8 ins; 1 del; 5 mod 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. Reviewed-by: yan Backport-of: 9471f24ca191832669a13e5a1ea73f7097a25927 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/386 From evergizova at openjdk.org Tue Aug 2 11:56:40 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 2 Aug 2022 11:56:40 GMT Subject: [jdk15u-dev] Integrated: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 11:03:32 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8280684 to 15u for parity with 11u. > The patch doesn't apply cleanly due to copyright years and context difference in jfrJavaSupport.cpp, jfrJavaSupport.hpp and jfrStreamWriterHost.inline.hpp (JDK-8252685 and JDK-8183227 are not in 15u). > Additionally, similar to 11u backport, the original condition `error_msg != NULL` is left without replacing NULL with nullptr, because C++14 Language Features was enabled since jdk16 (JDK-8208089). > > Tested with jdk/jfr and tier1. This pull request has now been integrated. Changeset: ed0200ad Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk15u-dev/commit/ed0200ad98eb666dc8b67e9afd5c788075056b9a Stats: 14 lines in 3 files changed: 8 ins; 1 del; 5 mod 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. Reviewed-by: yan Backport-of: 9471f24ca191832669a13e5a1ea73f7097a25927 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/250 From jdowland at openjdk.org Tue Aug 2 12:20:47 2022 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 2 Aug 2022 12:20:47 GMT Subject: [jdk17u-dev] RFR: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac In-Reply-To: References: Message-ID: On Fri, 1 Jul 2022 09:38:24 GMT, Jonathan Dowland wrote: > Hello, this is a backport of [4c3491bfa5f296b80c56a37cb4fffd6497323ac2 from openjdk/jdk](https://github.com/openjdk/jdk/commit/4c3491bfa5f296b80c56a37cb4fffd6497323ac2) originally by > Alexander Zuev committed on 29 Oct 2021. > > This is a backport to jdk17u-dev for Oracle parity. > > The patch does not apply clean: conflicts to resolve in ProblemList.txt. The other hunks are clean. > > The patch rewrites a test. The written test passes for me on a local macOS system. > > JBS: https://bugs.openjdk.org/browse/JDK-8017175 Addressed with #583, closing. Sorry I missed review comments here, I was on PTO ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/521 From jdowland at openjdk.org Tue Aug 2 12:20:48 2022 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 2 Aug 2022 12:20:48 GMT Subject: [jdk17u-dev] Withdrawn: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac In-Reply-To: References: Message-ID: On Fri, 1 Jul 2022 09:38:24 GMT, Jonathan Dowland wrote: > Hello, this is a backport of [4c3491bfa5f296b80c56a37cb4fffd6497323ac2 from openjdk/jdk](https://github.com/openjdk/jdk/commit/4c3491bfa5f296b80c56a37cb4fffd6497323ac2) originally by > Alexander Zuev committed on 29 Oct 2021. > > This is a backport to jdk17u-dev for Oracle parity. > > The patch does not apply clean: conflicts to resolve in ProblemList.txt. The other hunks are clean. > > The patch rewrites a test. The written test passes for me on a local macOS system. > > JBS: https://bugs.openjdk.org/browse/JDK-8017175 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/521 From duke at openjdk.org Tue Aug 2 12:33:25 2022 From: duke at openjdk.org (George Adams) Date: Tue, 2 Aug 2022 12:33:25 GMT Subject: [jdk11u-dev] RFR: 8218413: make reconfigure ignores configure-time AUTOCONF environment variable Message-ID: Backport applies cleanly and is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 ------------- Commit messages: - Backport 9efdb33a59f7db7b4b39e113265a3b3ba513c5d3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1300/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1300&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8218413 Stats: 8 lines in 3 files changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1300.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1300/head:pull/1300 PR: https://git.openjdk.org/jdk11u-dev/pull/1300 From duke at openjdk.org Tue Aug 2 12:42:32 2022 From: duke at openjdk.org (George Adams) Date: Tue, 2 Aug 2022 12:42:32 GMT Subject: [jdk11u-dev] RFR: 8221907: make reconfigure breaks when configured with relative paths Message-ID: Backport applies cleanly other than [`make/Init.gmk`](https://github.com/openjdk/jdk/commit/0974861dd800fdb44b3888e68b08c570f1985b58#diff-0bff77b1e720a2f054706fa08e621af3034963c0e132a5537b006670fed865a5R282) Which doesn't have `AUTOCONF="$(AUTOCONF)"` in JDK11u. Backport is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 ------------- Commit messages: - Backport 0974861dd800fdb44b3888e68b08c570f1985b58 Changes: https://git.openjdk.org/jdk11u-dev/pull/1301/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1301&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8221907 Stats: 55 lines in 5 files changed: 44 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1301.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1301/head:pull/1301 PR: https://git.openjdk.org/jdk11u-dev/pull/1301 From duke at openjdk.org Tue Aug 2 12:54:21 2022 From: duke at openjdk.org (George Adams) Date: Tue, 2 Aug 2022 12:54:21 GMT Subject: [jdk11u-dev] RFR: 8211727: Adjust default concurrency settings for running tests on Sparc Message-ID: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> Backport doesn't apply cleanly due to a diff between https://github.com/openjdk/jdk/blob/03a8cdece5e1dabcae0cd4f7ce9c0165daa1e476/test/hotspot/jtreg/compiler/jsr292/ContinuousCallSiteTargetChange.java and https://github.com/openjdk/jdk11u-dev/blob/master/test/hotspot/jtreg/compiler/jsr292/ContinuousCallSiteTargetChange.java. This change allows me to merge https://github.com/openjdk/jdk/commit/1804d6ce65816a529489e3058d9a035d8f772f61 and https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 cleanly ------------- Commit messages: - Backport 03a8cdece5e1dabcae0cd4f7ce9c0165daa1e476 Changes: https://git.openjdk.org/jdk11u-dev/pull/1302/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1302&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8211727 Stats: 14 lines in 2 files changed: 10 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1302.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1302/head:pull/1302 PR: https://git.openjdk.org/jdk11u-dev/pull/1302 From goetz at openjdk.org Tue Aug 2 12:55:20 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 12:55:20 GMT Subject: [jdk17u-dev] RFR: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception Message-ID: I backport this for parity with 17.0.5-oracle. test/jdk/java/awt/regtesthelpers/PassFailJFrame.java was already backported in JDK-8283803 As this is a pure omit of a file I will mark this as /clean. ------------- Commit messages: - Backport 3f26d84f6a03030080328e36a1fd1a08c982838c Changes: https://git.openjdk.org/jdk17u-dev/pull/618/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=618&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284535 Stats: 86 lines in 1 file changed: 36 ins; 31 del; 19 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/618.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/618/head:pull/618 PR: https://git.openjdk.org/jdk17u-dev/pull/618 From duke at openjdk.org Tue Aug 2 13:01:47 2022 From: duke at openjdk.org (George Adams) Date: Tue, 2 Aug 2022 13:01:47 GMT Subject: [jdk11u-dev] RFR: 8221907: make reconfigure breaks when configured with relative paths [v2] In-Reply-To: References: Message-ID: > Backport applies cleanly except for missing some WSL-specific patches. Backport is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: - Backport 0974861dd800fdb44b3888e68b08c570f1985b58 - Backport 9efdb33a59f7db7b4b39e113265a3b3ba513c5d3 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1301/files - new: https://git.openjdk.org/jdk11u-dev/pull/1301/files/4ab9bbaa..005f2e6f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1301&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1301&range=00-01 Stats: 49 lines in 5 files changed: 5 ins; 40 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1301.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1301/head:pull/1301 PR: https://git.openjdk.org/jdk11u-dev/pull/1301 From clanger at openjdk.org Tue Aug 2 13:01:49 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 13:01:49 GMT Subject: [jdk11u-dev] RFR: 8221907: make reconfigure breaks when configured with relative paths In-Reply-To: References: Message-ID: <71S8kIhdhjniKWHRmhislq04G5VGRu9zaYj5S97g2rw=.dd109a49-0d14-4561-adce-2f40e68f8851@github.com> On Tue, 2 Aug 2022 12:33:38 GMT, George Adams wrote: > Backport applies cleanly except for missing some WSL-specific patches. Backport is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 > Backport applies cleanly other than [`make/Init.gmk`](https://github.com/openjdk/jdk/commit/0974861dd800fdb44b3888e68b08c570f1985b58#diff-0bff77b1e720a2f054706fa08e621af3034963c0e132a5537b006670fed865a5R282) Which doesn't have `AUTOCONF="$(AUTOCONF)"` in JDK11u. Backport is a prerequisite of #1277 Maybe you want to make this a dependent PR of #1300 and it would then be clean? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1301 From goetz at openjdk.org Tue Aug 2 13:02:34 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:02:34 GMT Subject: [jdk17u-dev] RFR: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport d41331e6f2255aa07dbbbbccf62e39c50269e269 Changes: https://git.openjdk.org/jdk17u-dev/pull/619/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=619&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223543 Stats: 51 lines in 1 file changed: 18 ins; 25 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/619.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/619/head:pull/619 PR: https://git.openjdk.org/jdk17u-dev/pull/619 From duke at openjdk.org Tue Aug 2 13:04:27 2022 From: duke at openjdk.org (George Adams) Date: Tue, 2 Aug 2022 13:04:27 GMT Subject: [jdk11u-dev] RFR: 8221907: make reconfigure breaks when configured with relative paths [v2] In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 13:01:47 GMT, George Adams wrote: >> Backport applies cleanly except for missing some WSL-specific patches. Backport is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 > > George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: > > - Backport 0974861dd800fdb44b3888e68b08c570f1985b58 > - Backport 9efdb33a59f7db7b4b39e113265a3b3ba513c5d3 > Maybe you want to make this a dependent PR of https://github.com/openjdk/jdk11u-dev/pull/1300 and it would then be clean? @RealCLanger I was planning on doing so - just waiting for the branch to be created ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1301 From goetz at openjdk.org Tue Aug 2 13:11:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:11:39 GMT Subject: [jdk11u-dev] RFR: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues Message-ID: <_a9nB4oZNHCYxG_T3SLxtvZM-A4qGjAC08fj7ph-AQ8=.a48752b7-e34b-45b9-87cd-e44c21f30ba2@github.com> I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport d41331e6f2255aa07dbbbbccf62e39c50269e269 Changes: https://git.openjdk.org/jdk11u-dev/pull/1303/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1303&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223543 Stats: 51 lines in 1 file changed: 18 ins; 25 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1303.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1303/head:pull/1303 PR: https://git.openjdk.org/jdk11u-dev/pull/1303 From goetz at openjdk.org Tue Aug 2 13:14:37 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:14:37 GMT Subject: [jdk17u-dev] RFR: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test Message-ID: <1QzyYztikufeidJ6FdBYBF0EXlJ__vCs8ZvTUqed2Ck=.5c78c27b-026f-4969-bc0f-2a91433224fb@github.com> I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport e7c3b9de649d4b28ba16844e042afcf3c89323e5 Changes: https://git.openjdk.org/jdk17u-dev/pull/620/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=620&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285617 Stats: 49 lines in 1 file changed: 26 ins; 7 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/620.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/620/head:pull/620 PR: https://git.openjdk.org/jdk17u-dev/pull/620 From goetz at openjdk.org Tue Aug 2 13:24:27 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:24:27 GMT Subject: [jdk17u-dev] RFR: 8284077: Create an automated test for JDK-4170173 Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport 6db2e16b948ccb78839285051e136b8a023b2f7b Changes: https://git.openjdk.org/jdk17u-dev/pull/621/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=621&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284077 Stats: 251 lines in 2 files changed: 251 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/621.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/621/head:pull/621 PR: https://git.openjdk.org/jdk17u-dev/pull/621 From kevin.rushforth at oracle.com Tue Aug 2 13:27:17 2022 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 2 Aug 2022 06:27:17 -0700 Subject: [External] : RE: Bots for backports down? In-Reply-To: References: Message-ID: <47102e56-1c04-ccba-c52b-83b4c77f3817@oracle.com> I see that the bots were restarted again overnight, and are working again. -- Kevin On 8/2/2022 1:33 AM, Langer, Christoph wrote: > > Hi, > > looks like the bot got stuck again: > https://github.com/openjdk/jdk11u-dev/pull/1297 > > > Best regards > > Christoph > > *From:*jdk-updates-dev *On Behalf > Of *Kevin Rushforth > *Sent:* Montag, 1. August 2022 15:00 > *To:* Lindenmaier, Goetz ; ops at openjdk.java.net > *Cc:* jdk-updates-dev > *Subject:* Re: Bots for backports down? > > There was a general problem with the bots getting stuck. It should be > resolved now. > > -- Kevin > > On 8/1/2022 2:33 AM, Lindenmaier, Goetz wrote: > > Hi, > > my recent backports have not been handled by the bots: > > https://github.com/openjdk/jdk17u-dev/pull/616 > > > https://github.com/openjdk/jdk11u-dev/pull/1294 > > > Is this issue known already? > > Could someone please have a look? > > Thanks! > > ? Goetz. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz at openjdk.org Tue Aug 2 13:27:23 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:27:23 GMT Subject: [jdk17u-dev] RFR: 8283624: Create an automated regression test for RFE-4390885 Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport 99388eff8da2cb3dc0bb34f05e8784795edb790e Changes: https://git.openjdk.org/jdk17u-dev/pull/622/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=622&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283624 Stats: 281 lines in 1 file changed: 281 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/622.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/622/head:pull/622 PR: https://git.openjdk.org/jdk17u-dev/pull/622 From goetz at openjdk.org Tue Aug 2 13:27:33 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:27:33 GMT Subject: [jdk11u-dev] RFR: 8284077: Create an automated test for JDK-4170173 Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 6db2e16b948ccb78839285051e136b8a023b2f7b Changes: https://git.openjdk.org/jdk11u-dev/pull/1304/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1304&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284077 Stats: 251 lines in 2 files changed: 251 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1304.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1304/head:pull/1304 PR: https://git.openjdk.org/jdk11u-dev/pull/1304 From goetz at openjdk.org Tue Aug 2 13:31:44 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:31:44 GMT Subject: [jdk11u-dev] Integrated: 8267880: Upgrade the default PKCS12 MAC algorithm In-Reply-To: References: Message-ID: On Mon, 1 Aug 2022 10:44:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. > > In 11.0.12, "JDK-8153005 Upgrade the default PKCS12 encryption/MAC algorithms" was pushed. > Some parts of it were reverted right away in "JDK-8267599 Revert the change to the default PKCS12 macAlgorithm and macIterationCount props for 11u/8u/7u". > This change now again enables 8153005. It is basically the reverse patch of 8267599, > where ParamsTest.java has been renamed to KeytoolOpensslInteropTest.java. This pull request has now been integrated. Changeset: 9cf9879a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/9cf9879a4e4a78ed8e6d9b1f979de1eb7f75badf Stats: 23 lines in 4 files changed: 0 ins; 0 del; 23 mod 8267880: Upgrade the default PKCS12 MAC algorithm Reviewed-by: mbaesken ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1296 From goetz at openjdk.org Tue Aug 2 13:33:32 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:33:32 GMT Subject: [jdk17u-dev] RFR: 8285693: Create an automated test for JDK-4702199 Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport 158d871d0574970c9e5609dd037aaa0ead668a3b Changes: https://git.openjdk.org/jdk17u-dev/pull/623/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=623&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285693 Stats: 96 lines in 1 file changed: 96 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/623.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/623/head:pull/623 PR: https://git.openjdk.org/jdk17u-dev/pull/623 From goetz at openjdk.org Tue Aug 2 13:38:08 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:38:08 GMT Subject: [jdk11u-dev] RFR: 8283624: Create an automated regression test for RFE-4390885 Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 99388eff8da2cb3dc0bb34f05e8784795edb790e Changes: https://git.openjdk.org/jdk11u-dev/pull/1305/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1305&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283624 Stats: 281 lines in 1 file changed: 281 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1305.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1305/head:pull/1305 PR: https://git.openjdk.org/jdk11u-dev/pull/1305 From aph at openjdk.org Tue Aug 2 13:38:33 2022 From: aph at openjdk.org (Andrew Haley) Date: Tue, 2 Aug 2022 13:38:33 GMT Subject: [jdk11u-dev] Integrated: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node In-Reply-To: <0lGeRTvjMWHZqnvYQykG74px-sRMZ-DkI1hsfDd0Tvc=.6bd92e88-8022-4f05-b830-d9329165e3b4@github.com> References: <0lGeRTvjMWHZqnvYQykG74px-sRMZ-DkI1hsfDd0Tvc=.6bd92e88-8022-4f05-b830-d9329165e3b4@github.com> Message-ID: On Thu, 30 Jun 2022 14:35:36 GMT, Andrew Haley wrote: > Trivial backport, fixes the test case. This pull request has now been integrated. Changeset: 954d57ae Author: Andrew Haley URL: https://git.openjdk.org/jdk11u-dev/commit/954d57ae503e5e25c263d662a8e2eba978bd62b2 Stats: 56 lines in 2 files changed: 55 ins; 0 del; 1 mod 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node Backport-of: 78d371266ae8a629db8176ced4d48e9521702cce ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1190 From goetz at openjdk.org Tue Aug 2 13:39:57 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Aug 2022 13:39:57 GMT Subject: [jdk11u-dev] RFR: 8285693: Create an automated test for JDK-4702199 Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 158d871d0574970c9e5609dd037aaa0ead668a3b Changes: https://git.openjdk.org/jdk11u-dev/pull/1306/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1306&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285693 Stats: 96 lines in 1 file changed: 96 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1306.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1306/head:pull/1306 PR: https://git.openjdk.org/jdk11u-dev/pull/1306 From aleonard at openjdk.org Tue Aug 2 15:18:56 2022 From: aleonard at openjdk.org (Andrew Leonard) Date: Tue, 2 Aug 2022 15:18:56 GMT Subject: [jdk17u-dev] RFR: 8288399: MacOS debug symbol files not always deterministic in reproducible builds Message-ID: <1l0HcGxFL00u_5KgqBQN8oRl-Cf5vzTEUvPf0gXMjxA=.2a36a26d-069b-413b-bf5b-617b2687baf3@github.com> On MacOS builds enable -fdebug-prefix-map and -frandom-seed to enable fully reproducible builds, that are currently non-deterministic when debug symbols are created due to absolute debug symbol paths and non-deterministic random symbol name generation. ------------- Commit messages: - Backport 6633855ca78ff0f5f1213a2a1424436678a30e55 Changes: https://git.openjdk.org/jdk17u-dev/pull/624/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=624&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288399 Stats: 17 lines in 2 files changed: 13 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/624.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/624/head:pull/624 PR: https://git.openjdk.org/jdk17u-dev/pull/624 From phh at openjdk.org Tue Aug 2 16:28:53 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 2 Aug 2022 16:28:53 GMT Subject: [jdk17u-dev] RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java [v3] In-Reply-To: References: Message-ID: On Tue, 26 Jul 2022 08:10:05 GMT, Shruthi wrote: >> OpenJDK PR : https://github.com/openjdk/jdk/pull/9369 >> OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471 > > Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport?987656d69065b5b61d658cec3704a181a4aef18b Tagged and commented on the JBS issue. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/598 From phh at openjdk.org Tue Aug 2 16:29:53 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 2 Aug 2022 16:29:53 GMT Subject: [jdk11u-dev] RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java In-Reply-To: References: Message-ID: On Tue, 26 Jul 2022 07:32:29 GMT, Shruthi wrote: > OpenJDK PR : https://github.com/openjdk/jdk/pull/9369 > OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471 Tagged and commented on the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1273 From phh at openjdk.org Tue Aug 2 18:15:42 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 2 Aug 2022 18:15:42 GMT Subject: [jdk11u-dev] RFR: 8218413: make reconfigure ignores configure-time AUTOCONF environment variable In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 12:25:03 GMT, George Adams wrote: > Backport applies cleanly and is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1300 From clanger at openjdk.org Tue Aug 2 18:28:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 18:28:55 GMT Subject: [jdk11u-dev] RFR: 8218413: make reconfigure ignores configure-time AUTOCONF environment variable In-Reply-To: References: Message-ID: <_x4OVwjjHtIHTS6LmT0n4Px2N9TYADQcmE6yErZU8fc=.468181f1-3e8d-4552-8785-9a15a7d280a4@github.com> On Tue, 2 Aug 2022 18:12:09 GMT, Paul Hohensee wrote: > Tagged the JBS issue. Thanks. However, George made it to become an author now. ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1300 From clanger at openjdk.org Tue Aug 2 18:45:54 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 2 Aug 2022 18:45:54 GMT Subject: [jdk17u-dev] RFR: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism Message-ID: Hi all, This pull request contains a backport of [JDK-8280944](https://bugs.openjdk.java.net/browse/JDK-8280944), commit [87ab0994](https://github.com/openjdk/jdk/commit/87ab0994ded3b535a160bb87b6540bd072042c44) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Since [JDK-8280233](https://bugs.openjdk.org/browse/JDK-8280233) was brought to jdk17u, @dfuch suggested to bring this one along. The commit being backported was authored by Michael McMahon on 2 Feb 2022 and was reviewed by Daniel Fuchs and Alan Bateman. Thanks! ------------- Commit messages: - Backport 87ab0994ded3b535a160bb87b6540bd072042c44 Changes: https://git.openjdk.org/jdk17u-dev/pull/625/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=625&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280944 Stats: 35 lines in 3 files changed: 22 ins; 1 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/625.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/625/head:pull/625 PR: https://git.openjdk.org/jdk17u-dev/pull/625 From phh at openjdk.org Tue Aug 2 21:11:48 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 2 Aug 2022 21:11:48 GMT Subject: [jdk11u-dev] RFR: 8218413: make reconfigure ignores configure-time AUTOCONF environment variable In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 12:25:03 GMT, George Adams wrote: > Backport applies cleanly and is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 Ok! Congrats, George. :) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1300 From goetz at openjdk.org Wed Aug 3 06:00:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 06:00:52 GMT Subject: [jdk11u-dev] RFR: 8221871: javadoc should not set role=region on
elements [v2] In-Reply-To: References: <88SeUqsDT280tnYkHZlYbvSrBxx8FXUKcP-SVmaXIow=.8260b901-e756-461f-a650-0ac2d6dc775f@github.com> Message-ID: <-6bl2ryJ-OsYtikQ3Zw3zuKeY7danIeB4ZailPaZoaY=.fef90bbf-439f-4c5a-868f-3542b8ac5881@github.com> On Tue, 2 Aug 2022 10:46:17 GMT, psoujany wrote: >> @psoujany You must not integrate a fix in a JDK Updates project before requesting (and receiving) maintainer approval. Please refer to the [Wiki](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix), especially point 6. >> >> In case you don't have JBS access, I can add the fix request on your behalf. In that case, please post the text for the fix request comment here and I'll copy&paste it over. Thx. > > @RealCLanger Apologies for adding integrate tag. I don't have access to JBS. Please add _Fix Request 11_. This is actual openjdk bug https://bugs.openjdk.org/browse/JDK-8221871. Thank you. Hi @psoujany, next time please closely follow the backport instructions.https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix If you don't understand them, ask before acting. * Test your change. GHA is only a final check! * Tell what you have tested * State what you resolved if it is not clean * Don't integrate if you don't have the tag. I'll apporve the change now. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1219 From duke at openjdk.org Wed Aug 3 06:00:54 2022 From: duke at openjdk.org (psoujany) Date: Wed, 3 Aug 2022 06:00:54 GMT Subject: [jdk11u-dev] RFR: 8221871: javadoc should not set role=region on
elements [v6] In-Reply-To: References: Message-ID: On Fri, 29 Jul 2022 08:26:07 GMT, psoujany wrote: >> Backport javadoc should not set role=region on
elements. >> >> The bug report for the same : https://bugs.openjdk.org/browse/JDK-8221871 > > psoujany has updated the pull request incrementally with one additional commit since the last revision: > > Fixing whitespace errors Sure, Thank you. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1219 From goetz at openjdk.org Wed Aug 3 06:07:01 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 06:07:01 GMT Subject: [jdk17u-dev] RFR: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 12:47:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java was already backported in JDK-8283803 > > As this is a pure omit of a file I will mark this as /clean. Pre-submit failure: ant download failed. Unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/618 From goetz at openjdk.org Wed Aug 3 06:17:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 06:17:52 GMT Subject: [jdk11u-dev] RFR: 8285693: Create an automated test for JDK-4702199 In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 13:28:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. Pre-submit test hangs. unrelated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1306 From goetz at openjdk.org Wed Aug 3 06:19:09 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 06:19:09 GMT Subject: [jdk17u-dev] RFR: 8283624: Create an automated regression test for RFE-4390885 In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 13:20:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. Pre-submit fialure: TestStringDeduplicationAgeThreshold.java#id1 known to be failing sporadically. Unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/622 From goetz at openjdk.org Wed Aug 3 06:20:04 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 06:20:04 GMT Subject: [jdk17u-dev] RFR: 8285693: Create an automated test for JDK-4702199 In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 13:23:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. Pre-submit failure: build hangs. Unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/623 From duke at openjdk.org Wed Aug 3 07:39:40 2022 From: duke at openjdk.org (psoujany) Date: Wed, 3 Aug 2022 07:39:40 GMT Subject: [jdk11u-dev] Integrated: 8221871: javadoc should not set role=region on
elements In-Reply-To: References: Message-ID: <0JX1y5yP0ygiIl0VPlwIY4gdYfnh0nu7SmPBWhnVQ7A=.15cc5058-5b3e-45ab-8425-1367043c44dd@github.com> On Tue, 12 Jul 2022 10:59:13 GMT, psoujany wrote: > Backport javadoc should not set role=region on
elements. > > The bug report for the same : https://bugs.openjdk.org/browse/JDK-8221871 This pull request has now been integrated. Changeset: 7318cdcd Author: Pasam Soujanya1 Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/7318cdcdb113323233651355e4c2fa4801f96350 Stats: 78 lines in 5 files changed: 0 ins; 23 del; 55 mod 8221871: javadoc should not set role=region on
elements Reviewed-by: clanger Backport-of: 0abdc381b72f9dca86ac8f9c8943980eda7fd853 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1219 From duke at openjdk.org Wed Aug 3 07:40:01 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 07:40:01 GMT Subject: [jdk11u-dev] Integrated: 8218413: make reconfigure ignores configure-time AUTOCONF environment variable In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 12:25:03 GMT, George Adams wrote: > Backport applies cleanly and is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 This pull request has now been integrated. Changeset: 93666aea Author: George Adams Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/93666aeaf73bfdf708c6d2f1347461914e2dde7f Stats: 8 lines in 3 files changed: 5 ins; 0 del; 3 mod 8218413: make reconfigure ignores configure-time AUTOCONF environment variable Backport-of: 9efdb33a59f7db7b4b39e113265a3b3ba513c5d3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1300 From duke at openjdk.org Wed Aug 3 08:00:04 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 08:00:04 GMT Subject: [jdk11u-dev] RFR: 8221907: make reconfigure breaks when configured with relative paths [v3] In-Reply-To: References: Message-ID: > Backport applies cleanly except for missing some WSL-specific patches. Backport is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - Backport 0974861dd800fdb44b3888e68b08c570f1985b58 - Backport 9efdb33a59f7db7b4b39e113265a3b3ba513c5d3 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1301/files - new: https://git.openjdk.org/jdk11u-dev/pull/1301/files/005f2e6f..58bbd677 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1301&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1301&range=01-02 Stats: 157 lines in 11 files changed: 55 ins; 23 del; 79 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1301.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1301/head:pull/1301 PR: https://git.openjdk.org/jdk11u-dev/pull/1301 From goetz at openjdk.org Wed Aug 3 08:09:00 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:09:00 GMT Subject: [jdk17u-dev] Integrated: 8283245: Create a test for JDK-4670319 In-Reply-To: References: Message-ID: On Sun, 31 Jul 2022 13:10:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: fb82b73b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fb82b73b8f607979fca56fa19907f59a0842393b Stats: 115 lines in 1 file changed: 115 ins; 0 del; 0 mod 8283245: Create a test for JDK-4670319 Backport-of: 4ce3cf12bff025441f658e1857e92486b5d73ee6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/615 From goetz at openjdk.org Wed Aug 3 08:15:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:15:47 GMT Subject: [jdk11u-dev] Integrated: 8283245: Create a test for JDK-4670319 In-Reply-To: <9MWI5jpA5raukjHJR9Zq643tUFM3CwzHRJItNknSJgM=.f484ebe4-be8c-4ee9-b0d6-ee0779d856c9@github.com> References: <9MWI5jpA5raukjHJR9Zq643tUFM3CwzHRJItNknSJgM=.f484ebe4-be8c-4ee9-b0d6-ee0779d856c9@github.com> Message-ID: On Sun, 31 Jul 2022 12:43:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 3210c993 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/3210c99384688a70af20da8dbce57b11387f4f5c Stats: 115 lines in 1 file changed: 115 ins; 0 del; 0 mod 8283245: Create a test for JDK-4670319 Backport-of: 4ce3cf12bff025441f658e1857e92486b5d73ee6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1292 From goetz at openjdk.org Wed Aug 3 08:18:14 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:18:14 GMT Subject: [jdk11u-dev] Integrated: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues In-Reply-To: <_a9nB4oZNHCYxG_T3SLxtvZM-A4qGjAC08fj7ph-AQ8=.a48752b7-e34b-45b9-87cd-e44c21f30ba2@github.com> References: <_a9nB4oZNHCYxG_T3SLxtvZM-A4qGjAC08fj7ph-AQ8=.a48752b7-e34b-45b9-87cd-e44c21f30ba2@github.com> Message-ID: On Tue, 2 Aug 2022 13:01:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 9796aac8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/9796aac8381394778a9e31a5113d4e92ce645722 Stats: 51 lines in 1 file changed: 18 ins; 25 del; 8 mod 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues Backport-of: d41331e6f2255aa07dbbbbccf62e39c50269e269 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1303 From goetz at openjdk.org Wed Aug 3 08:18:53 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:18:53 GMT Subject: [jdk17u-dev] Integrated: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 12:47:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java was already backported in JDK-8283803 > > As this is a pure omit of a file I will mark this as /clean. This pull request has now been integrated. Changeset: 7ac74ca2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7ac74ca21363e7448077d6305a6cfb1309252fd3 Stats: 86 lines in 1 file changed: 36 ins; 31 del; 19 mod 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception 8283712: Create a manual test framework class Backport-of: 3f26d84f6a03030080328e36a1fd1a08c982838c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/618 From goetz at openjdk.org Wed Aug 3 08:20:49 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:20:49 GMT Subject: [jdk11u-dev] Integrated: 8283624: Create an automated regression test for RFE-4390885 In-Reply-To: References: Message-ID: <_zdcse3Dptx4XPrWMPlzkel4WmzLCDJjKAmWRMbYNYU=.f94666d0-5fe3-4b6b-a667-f731dd912252@github.com> On Tue, 2 Aug 2022 13:25:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: d647021e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d647021e2298d4c6e514ab57c25f7c6f5c5e27fa Stats: 281 lines in 1 file changed: 281 ins; 0 del; 0 mod 8283624: Create an automated regression test for RFE-4390885 Backport-of: 99388eff8da2cb3dc0bb34f05e8784795edb790e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1305 From goetz at openjdk.org Wed Aug 3 08:21:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:21:02 GMT Subject: [jdk17u-dev] Integrated: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 12:54:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 53cb0028 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/53cb0028b52e043515a677e6899f33b688a10243 Stats: 51 lines in 1 file changed: 18 ins; 25 del; 8 mod 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues Backport-of: d41331e6f2255aa07dbbbbccf62e39c50269e269 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/619 From goetz at openjdk.org Wed Aug 3 08:21:55 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:21:55 GMT Subject: [jdk11u-dev] RFR: 8288928: Incorrect GPL header in pnglibconf.h In-Reply-To: References: <-2saPL2vlqv5ZGVFHEizB07SRE852wqocJhzc6YRwpE=.468256da-34c7-49c6-8e89-0be2481d7fcb@github.com> Message-ID: On Sat, 2 Jul 2022 01:01:48 GMT, Sergey Bylokhov wrote: >> Hi all, >> This pull request contains a backport of commit [70762d39](https://github.com/openjdk/jdk/commit/70762d397267f85ce81727ec0c89c9448967798e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> The commit being backported was authored by Sergey Bylokhov on 7 Oct 2019 and was reviewed by Phil Race. >> Thanks! >> >> Backport is clean, but I have to create a new JBS issue, the initial one is closed. > > @kevinrushforth @prrace Do you know is it possible to open an initial JBS issue? > https://github.com/openjdk/jdk/commit/70762d397267f85ce81727ec0c89c9448967798e @mrserb, could you please handle above remarks and integrate? Thanks! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1169 From goetz at openjdk.org Wed Aug 3 08:23:53 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:23:53 GMT Subject: [jdk17u-dev] Integrated: 8283624: Create an automated regression test for RFE-4390885 In-Reply-To: References: Message-ID: <579Sew06CBVO_qZmdc2VHzJA1BUlLZXs6rwwaB5nltc=.848ed251-46ce-4666-98f9-3ce793accde8@github.com> On Tue, 2 Aug 2022 13:20:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 5885a8e6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5885a8e67217afae318337df42694118701e90a8 Stats: 281 lines in 1 file changed: 281 ins; 0 del; 0 mod 8283624: Create an automated regression test for RFE-4390885 Backport-of: 99388eff8da2cb3dc0bb34f05e8784795edb790e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/622 From goetz at openjdk.org Wed Aug 3 08:26:53 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 08:26:53 GMT Subject: [jdk17u-dev] Integrated: 8291595: [17u] Delete files missed in backport of 8269039 In-Reply-To: <_VA0YFMq2Tl83yKOXKX291QFqD1_X0Rs0Hb7RYxk41A=.fdac3c19-1983-4dcf-b24b-df8a3e54fad9@github.com> References: <_VA0YFMq2Tl83yKOXKX291QFqD1_X0Rs0Hb7RYxk41A=.fdac3c19-1983-4dcf-b24b-df8a3e54fad9@github.com> Message-ID: <5OeWFzQHb3Dp3El66ALQmdVGK72OtPjTMx6306hmvw4=.60b18cfe-d5d4-4f2c-9880-1eb239665ad1@github.com> On Sun, 31 Jul 2022 16:10:06 GMT, Goetz Lindenmaier wrote: > Just deleted the files. > I missed deleting them when I backported 8269039: Disable SHA-1 Signed JARs This pull request has now been integrated. Changeset: c430a945 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c430a9457698fd57a7926e6fab065a639ccfdeb4 Stats: 0 lines in 2 files changed: 0 ins; 0 del; 0 mod 8291595: [17u] Delete files missed in backport of 8269039 Reviewed-by: stuefe ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/617 From duke at openjdk.org Wed Aug 3 08:32:33 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 08:32:33 GMT Subject: [jdk11u-dev] RFR: 8214003: Limit default test jobs based on memory size Message-ID: <40452h2cVaFe3ACJMjHsiVLRFxKMcvDURhtrOnqk-Xc=.4632d536-9a17-4722-a9e5-b07b68ea9e49@github.com> This patch was partially backported in https://github.com/openjdk/jdk11u-dev/commit/abcacaefe01e427c7a643b578479e3aedd0b6949. This PR adds the remaining patch to `make/RunTests.gmk`. This backport is a prerequisite to backporting https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1302 Commit messages: - Backport 1804d6ce65816a529489e3058d9a035d8f772f61 Changes: https://git.openjdk.org/jdk11u-dev/pull/1307/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1307&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8214003 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1307.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1307/head:pull/1307 PR: https://git.openjdk.org/jdk11u-dev/pull/1307 From duke at openjdk.org Wed Aug 3 08:46:39 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 08:46:39 GMT Subject: [jdk11u-dev] RFR: 8233712: Limit default tests jobs based on ulimit -u setting Message-ID: Applies cleanly. This backport is a prerequisite to landing https://github.com/openjdk/jdk11u-dev/pull/1277 ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1307 Commit messages: - Backport 753c58b7f556fedd7828da487a34b8b228785ff9 Changes: https://git.openjdk.org/jdk11u-dev/pull/1308/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1308&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8233712 Stats: 43 lines in 4 files changed: 43 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1308.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1308/head:pull/1308 PR: https://git.openjdk.org/jdk11u-dev/pull/1308 From duke at openjdk.org Wed Aug 3 09:34:58 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 09:34:58 GMT Subject: [jdk11u-dev] Integrated: 8290000: Bump macOS GitHub actions to macOS 11 In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 07:50:45 GMT, George Adams wrote: > macOS 10.15 has been deprecated for some time and will be removed completely on August 30th. See https://github.com/actions/virtual-environments#available-environments and https://github.com/actions/virtual-environments/issues/5583 for context. > > This PR doesn't apply cleanly because it was added to the GitHub actions rewrite in tip. As it's unlikely that I will have a backported rewrite by August 30th my preference is to backport this way round. This pull request has now been integrated. Changeset: ac89673b Author: George Adams Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/ac89673b07a30b10931cc39c4367047b741d1f04 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 8290000: Bump macOS GitHub actions to macOS 11 Reviewed-by: clanger Backport-of: 4e6cd67fec3d978f4c8c1aed95a1d09b544eff68 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1297 From clanger at openjdk.org Wed Aug 3 09:48:42 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 3 Aug 2022 09:48:42 GMT Subject: [jdk11u-dev] RFR: 8211727: Adjust default concurrency settings for running tests on Sparc In-Reply-To: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> References: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> Message-ID: On Tue, 2 Aug 2022 12:44:24 GMT, George Adams wrote: > Backport doesn't apply cleanly due to a diff between https://github.com/openjdk/jdk/blob/03a8cdece5e1dabcae0cd4f7ce9c0165daa1e476/test/hotspot/jtreg/compiler/jsr292/ContinuousCallSiteTargetChange.java and https://github.com/openjdk/jdk11u-dev/blob/master/test/hotspot/jtreg/compiler/jsr292/ContinuousCallSiteTargetChange.java. > > This change allows me to merge https://github.com/openjdk/jdk/commit/1804d6ce65816a529489e3058d9a035d8f772f61 and https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 cleanly I've reviewed this one now and it gave me a little headache. I initially thought: That's weird, [JDK-8211727](https://bugs.openjdk.org/browse/JDK-8211727) was already backported in 11.0.5 and there's also a [commit](https://github.com/openjdk/jdk11u-dev/commit/2c4aa733a367f3fb2bd6a498053f986d71471448) for it. But looking deeper this unveiled a problem with my later backport of [JDK-8212028](https://bugs.openjdk.org/browse/JDK-8212028) in 11.0.6: https://github.com/openjdk/jdk11u-dev/commit/abcacaefe01e427c7a643b578479e3aedd0b6949. This introduced section "Setup global test running parameters" in RunTests.gmk again with the old code. That's the part you would be patching now. So' it's good to fix this. But I would suggest that you create a new JBS issue named "[11u] Repair backport of JDK-8211727". For that, you can use this change and then please remove the duplicate section "Setup global test running parameters" in RunTests.gmk in line 35ff. Thanks for your efforts! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1302 From duke at openjdk.org Wed Aug 3 09:57:33 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 09:57:33 GMT Subject: [jdk11u-dev] RFR: 8291794: [11u] Repair backport of JDK-8211727 [v2] In-Reply-To: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> References: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> Message-ID: > Backport doesn't apply cleanly due to a diff between https://github.com/openjdk/jdk/blob/03a8cdece5e1dabcae0cd4f7ce9c0165daa1e476/test/hotspot/jtreg/compiler/jsr292/ContinuousCallSiteTargetChange.java and https://github.com/openjdk/jdk11u-dev/blob/master/test/hotspot/jtreg/compiler/jsr292/ContinuousCallSiteTargetChange.java. > > This change allows me to merge https://github.com/openjdk/jdk/commit/1804d6ce65816a529489e3058d9a035d8f772f61 and https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 cleanly George Adams has updated the pull request incrementally with one additional commit since the last revision: remove duplicate code section ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1302/files - new: https://git.openjdk.org/jdk11u-dev/pull/1302/files/10c33d87..1540f710 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1302&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1302&range=00-01 Stats: 37 lines in 1 file changed: 0 ins; 37 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1302.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1302/head:pull/1302 PR: https://git.openjdk.org/jdk11u-dev/pull/1302 From clanger at openjdk.org Wed Aug 3 10:06:38 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 3 Aug 2022 10:06:38 GMT Subject: [jdk11u-dev] RFR: 8214003: Limit default test jobs based on memory size In-Reply-To: <40452h2cVaFe3ACJMjHsiVLRFxKMcvDURhtrOnqk-Xc=.4632d536-9a17-4722-a9e5-b07b68ea9e49@github.com> References: <40452h2cVaFe3ACJMjHsiVLRFxKMcvDURhtrOnqk-Xc=.4632d536-9a17-4722-a9e5-b07b68ea9e49@github.com> Message-ID: On Wed, 3 Aug 2022 08:22:45 GMT, George Adams wrote: > This patch was partially backported in https://github.com/openjdk/jdk11u-dev/commit/abcacaefe01e427c7a643b578479e3aedd0b6949. This PR adds the remaining patch to `make/RunTests.gmk`. > > This backport is a prerequisite to backporting https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 Hm, this one also rectifies things after the [JDK-8212028](https://bugs.openjdk.org/browse/JDK-8212028) backport. Again, [JDK-8214003](https://bugs.openjdk.org/browse/JDK-8214003) was already backported. Can you meld these changes into #1302 (and adapt [JDK-8291794](https://bugs.openjdk.org/browse/JDK-8291794) accordingly) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1307 From duke at openjdk.org Wed Aug 3 10:10:43 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 10:10:43 GMT Subject: [jdk11u-dev] Withdrawn: 8214003: Limit default test jobs based on memory size In-Reply-To: <40452h2cVaFe3ACJMjHsiVLRFxKMcvDURhtrOnqk-Xc=.4632d536-9a17-4722-a9e5-b07b68ea9e49@github.com> References: <40452h2cVaFe3ACJMjHsiVLRFxKMcvDURhtrOnqk-Xc=.4632d536-9a17-4722-a9e5-b07b68ea9e49@github.com> Message-ID: On Wed, 3 Aug 2022 08:22:45 GMT, George Adams wrote: > This patch was partially backported in https://github.com/openjdk/jdk11u-dev/commit/abcacaefe01e427c7a643b578479e3aedd0b6949. This PR adds the remaining patch to `make/RunTests.gmk`. > > This backport is a prerequisite to backporting https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1307 From duke at openjdk.org Wed Aug 3 10:12:17 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 10:12:17 GMT Subject: [jdk11u-dev] RFR: 8291794: [11u] Repair backport of JDK-8211727 [v3] In-Reply-To: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> References: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> Message-ID: > This change allows me to merge https://github.com/openjdk/jdk/commit/1804d6ce65816a529489e3058d9a035d8f772f61 and https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 cleanly George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Repair backport of JDK-8211727 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1302/files - new: https://git.openjdk.org/jdk11u-dev/pull/1302/files/1540f710..91b6da48 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1302&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1302&range=01-02 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1302.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1302/head:pull/1302 PR: https://git.openjdk.org/jdk11u-dev/pull/1302 From duke at openjdk.org Wed Aug 3 10:13:11 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 10:13:11 GMT Subject: [jdk11u-dev] RFR: 8233712: Limit default tests jobs based on ulimit -u setting [v2] In-Reply-To: References: Message-ID: > Applies cleanly. This backport is a prerequisite to landing https://github.com/openjdk/jdk11u-dev/pull/1277 George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Backport 753c58b7f556fedd7828da487a34b8b228785ff9 - Repair backport of JDK-8211727 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1308/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1308&range=01 Stats: 96 lines in 5 files changed: 55 ins; 37 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1308.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1308/head:pull/1308 PR: https://git.openjdk.org/jdk11u-dev/pull/1308 From duke at openjdk.org Wed Aug 3 10:52:50 2022 From: duke at openjdk.org (Shruthi) Date: Wed, 3 Aug 2022 10:52:50 GMT Subject: [jdk17u-dev] Integrated: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java In-Reply-To: References: Message-ID: On Tue, 26 Jul 2022 07:49:51 GMT, Shruthi wrote: > OpenJDK PR : https://github.com/openjdk/jdk/pull/9369 > OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471 This pull request has now been integrated. Changeset: 951fff54 Author: Shruthi Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/951fff5462051181cedd490f604d448e3fb085bc Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java Reviewed-by: phh Backport-of: 987656d69065b5b61d658cec3704a181a4aef18b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/598 From duke at openjdk.org Wed Aug 3 10:54:46 2022 From: duke at openjdk.org (Shruthi) Date: Wed, 3 Aug 2022 10:54:46 GMT Subject: [jdk11u-dev] Integrated: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java In-Reply-To: References: Message-ID: On Tue, 26 Jul 2022 07:32:29 GMT, Shruthi wrote: > OpenJDK PR : https://github.com/openjdk/jdk/pull/9369 > OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471 This pull request has now been integrated. Changeset: 1c96cac9 Author: Shruthi Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/1c96cac91d499ceca65ab2931304ebe1ebf4a490 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java Reviewed-by: phh Backport-of: 987656d69065b5b61d658cec3704a181a4aef18b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1273 From goetz at openjdk.org Wed Aug 3 13:36:48 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 13:36:48 GMT Subject: [jdk11u-dev] Integrated: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 11:12:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: ce8367f4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ce8367f438a14a797a3d79b6d3c171a252ab9c43 Stats: 58 lines in 2 files changed: 57 ins; 0 del; 1 mod 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small Backport-of: 3f5e48a44ee77d07dea3d2c4ae52aaf19b8dc7cb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1299 From goetz at openjdk.org Wed Aug 3 13:39:38 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 13:39:38 GMT Subject: [jdk17u-dev] Integrated: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test In-Reply-To: <1QzyYztikufeidJ6FdBYBF0EXlJ__vCs8ZvTUqed2Ck=.5c78c27b-026f-4969-bc0f-2a91433224fb@github.com> References: <1QzyYztikufeidJ6FdBYBF0EXlJ__vCs8ZvTUqed2Ck=.5c78c27b-026f-4969-bc0f-2a91433224fb@github.com> Message-ID: On Tue, 2 Aug 2022 13:03:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 91b5c0a3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/91b5c0a39d818cd85ac99c7578c5f91b0aafee88 Stats: 49 lines in 1 file changed: 26 ins; 7 del; 16 mod 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test Backport-of: e7c3b9de649d4b28ba16844e042afcf3c89323e5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/620 From goetz at openjdk.org Wed Aug 3 13:44:58 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 13:44:58 GMT Subject: [jdk17u-dev] Integrated: 8284077: Create an automated test for JDK-4170173 In-Reply-To: References: Message-ID: <-SmGifaEm666r9TzWTvESJpfD5l2dl2ua0mKLKXgwLQ=.dfc15e60-e88b-4d91-8417-9c4154436601@github.com> On Tue, 2 Aug 2022 13:15:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 6bfe87dc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6bfe87dc436bfe10e2a64e9e2ed7aaedfb425db4 Stats: 251 lines in 2 files changed: 251 ins; 0 del; 0 mod 8284077: Create an automated test for JDK-4170173 Backport-of: 6db2e16b948ccb78839285051e136b8a023b2f7b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/621 From goetz at openjdk.org Wed Aug 3 13:54:50 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 13:54:50 GMT Subject: [jdk11u-dev] Integrated: 8284077: Create an automated test for JDK-4170173 In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 13:19:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 9180dcb9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/9180dcb97503b1755ba2b99150a162b87f8361a1 Stats: 251 lines in 2 files changed: 251 ins; 0 del; 0 mod 8284077: Create an automated test for JDK-4170173 Backport-of: 6db2e16b948ccb78839285051e136b8a023b2f7b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1304 From goetz at openjdk.org Wed Aug 3 13:54:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 13:54:52 GMT Subject: [jdk17u-dev] Integrated: 8285693: Create an automated test for JDK-4702199 In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 13:23:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: 1fe8777f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1fe8777f3b17f977286c573be92e6b09723faceb Stats: 96 lines in 1 file changed: 96 ins; 0 del; 0 mod 8285693: Create an automated test for JDK-4702199 Backport-of: 158d871d0574970c9e5609dd037aaa0ead668a3b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/623 From goetz at openjdk.org Wed Aug 3 13:56:44 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 13:56:44 GMT Subject: [jdk11u-dev] Integrated: 8285693: Create an automated test for JDK-4702199 In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 13:28:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 0106d848 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/0106d8480f87679f8089381e671bb3dec13fceb9 Stats: 96 lines in 1 file changed: 96 ins; 0 del; 0 mod 8285693: Create an automated test for JDK-4702199 Backport-of: 158d871d0574970c9e5609dd037aaa0ead668a3b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1306 From goetz at openjdk.org Wed Aug 3 14:14:10 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 14:14:10 GMT Subject: [jdk11u-dev] RFR: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception Message-ID: I backport this for parity with 11.0.17-oracle. I had to adapt the String literal in PrintLatinCJKTest.java to Java 11 syntax. ------------- Commit messages: - Backport 3f26d84f6a03030080328e36a1fd1a08c982838c Changes: https://git.openjdk.org/jdk11u-dev/pull/1309/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1309&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284535 Stats: 361 lines in 2 files changed: 311 ins; 31 del; 19 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1309.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1309/head:pull/1309 PR: https://git.openjdk.org/jdk11u-dev/pull/1309 From duke at openjdk.org Wed Aug 3 14:40:45 2022 From: duke at openjdk.org (Jan Kratochvil) Date: Wed, 3 Aug 2022 14:40:45 GMT Subject: [jdk15u-dev] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle Message-ID: There was [an accepted backport to OpenJDK-17](https://github.com/openjdk/jdk17u-dev/pull/575). This OpenJDK-15 backport: The first condition // CDS does not handle useImplMethodHandle if (useImplMethodHandle) return generateInnerClass(); was not applied cleanly as OpenJDK-15 is missing: - [8257241](https://bugs.openjdk.java.net/browse/JDK-8257241): CDS should not handle disableEagerInitialization for archived lambda proxy classes This OpenJDK-15 backport: Original commit errors on OpenJDK-15 with: ` TEST RESULT: Error. can't find jdk.test.lib.helpers.ClassFileInstaller in test directory or libraries` as OpenJDK-15 is missing: - [8263412](https://bugs.openjdk.org/browse/JDK-8263412): ClassFileInstaller can't be used by classes outside of default package This OpenJDK-15 backport: Original commit errors on OpenJDK-15 with: error: cannot find symbol symbol: method dumpClassList(String,String,String,String) location: class CDSTestUtils as OpenJDK-15 is missing: - [8213226](https://bugs.openjdk.org/browse/JDK-8213226): [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog() I am not yet an Author - I do not have JBS account. I have run the testsuite on Linux x86_64 and there is no change of the results. Two new testcases are added and they are both Passing. The testcases are still Passing after backporting them to 15u-dev. +Passed: runtime/cds/appcds/LambdaWithUseImplMethodHandle.java +Passed: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java ------------- Commit messages: - whitespace fix - OpenJDK-15 backport: Original commit errors on OpenJDK-15 with: - OpenJDK-15 backport: Original commit errors on OpenJDK-15 with: - 8290417: CDS cannot archive lamda proxy with useImplMethodHandle Changes: https://git.openjdk.org/jdk15u-dev/pull/251/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=251&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290417 Stats: 439 lines in 7 files changed: 439 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/251.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/251/head:pull/251 PR: https://git.openjdk.org/jdk15u-dev/pull/251 From duke at openjdk.org Wed Aug 3 17:28:12 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 17:28:12 GMT Subject: [jdk11u-dev] RFR: 8214003: Limit default test jobs based on memory size [v2] In-Reply-To: <40452h2cVaFe3ACJMjHsiVLRFxKMcvDURhtrOnqk-Xc=.4632d536-9a17-4722-a9e5-b07b68ea9e49@github.com> References: <40452h2cVaFe3ACJMjHsiVLRFxKMcvDURhtrOnqk-Xc=.4632d536-9a17-4722-a9e5-b07b68ea9e49@github.com> Message-ID: > This patch was partially backported in https://github.com/openjdk/jdk11u-dev/commit/abcacaefe01e427c7a643b578479e3aedd0b6949. This PR adds the remaining patch to `make/RunTests.gmk`. > > This backport is a prerequisite to backporting https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1307/files - new: https://git.openjdk.org/jdk11u-dev/pull/1307/files/8e348a6c..8e348a6c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1307&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1307&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1307.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1307/head:pull/1307 PR: https://git.openjdk.org/jdk11u-dev/pull/1307 From serb at openjdk.org Wed Aug 3 19:57:34 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 3 Aug 2022 19:57:34 GMT Subject: [jdk11u-dev] RFR: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u In-Reply-To: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> References: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> Message-ID: On Fri, 29 Jul 2022 20:24:05 GMT, Andrew John Hughes wrote: > So, the story goes: > > * [JDK-8250984](https://bugs.openjdk.org/browse/JDK-8250984) was backported in 11.0.10 > * [JDK-8231111](https://bugs.openjdk.org/browse/JDK-8231111) was backported in 11.0.16 > * In later JDKs, these changes occur in the opposite order. So, when 8250984 was backported, changes related to 8231111 were stripped from it. > * Now 8231111 has been backported, the testcase needs to be updated to recognise `OSCONTAINER_ERROR` (which is `-2`) as a valid return value from the CGroups v2 code. > > Without this fix, we're seeing the testcase failing on newer systems. This change syncs the testcase with trunk. Marked as reviewed by serb (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1289 From serb at openjdk.org Wed Aug 3 20:17:05 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 3 Aug 2022 20:17:05 GMT Subject: [jdk11u-dev] Integrated: 8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041) In-Reply-To: <-2saPL2vlqv5ZGVFHEizB07SRE852wqocJhzc6YRwpE=.468256da-34c7-49c6-8e89-0be2481d7fcb@github.com> References: <-2saPL2vlqv5ZGVFHEizB07SRE852wqocJhzc6YRwpE=.468256da-34c7-49c6-8e89-0be2481d7fcb@github.com> Message-ID: On Tue, 21 Jun 2022 23:37:28 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [70762d39](https://github.com/openjdk/jdk/commit/70762d397267f85ce81727ec0c89c9448967798e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 7 Oct 2019 and was reviewed by Phil Race. > Thanks! > > Backport is clean, but I have to create a new JBS issue, the initial one is closed. This pull request has now been integrated. Changeset: 39ec4361 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/39ec43618136abffdd071b066dc9a5d56317348b Stats: 8 lines in 1 file changed: 1 ins; 5 del; 2 mod 8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041) Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1169 From clanger at openjdk.org Wed Aug 3 20:39:46 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 3 Aug 2022 20:39:46 GMT Subject: [jdk11u-dev] RFR: 8221907: make reconfigure breaks when configured with relative paths [v3] In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 08:00:04 GMT, George Adams wrote: >> Backport applies cleanly except for missing some WSL-specific patches. Backport is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - Backport 0974861dd800fdb44b3888e68b08c570f1985b58 > - Backport 9efdb33a59f7db7b4b39e113265a3b3ba513c5d3 This looks fine and passes SAP nightlies. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1301 From goetz at openjdk.org Wed Aug 3 20:58:50 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 20:58:50 GMT Subject: [jdk17u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport c4dc58e12e197562dce90c0027aa74c29047cea6 Changes: https://git.openjdk.org/jdk17u-dev/pull/626/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=626&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283277 Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/626.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/626/head:pull/626 PR: https://git.openjdk.org/jdk17u-dev/pull/626 From goetz at openjdk.org Wed Aug 3 20:59:05 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Aug 2022 20:59:05 GMT Subject: [jdk11u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update Message-ID: I backport this for parity with 11.0.17-oracle. I had to resolve adding the bugid to @bugs in LocaleDataTest.java. This is most trivial, will mark as /clean. ------------- Commit messages: - Backport c4dc58e12e197562dce90c0027aa74c29047cea6 Changes: https://git.openjdk.org/jdk11u-dev/pull/1310/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1310&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283277 Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1310.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1310/head:pull/1310 PR: https://git.openjdk.org/jdk11u-dev/pull/1310 From duke at openjdk.org Wed Aug 3 22:09:32 2022 From: duke at openjdk.org (George Adams) Date: Wed, 3 Aug 2022 22:09:32 GMT Subject: [jdk11u-dev] RFR: 8233712: Limit default tests jobs based on ulimit -u setting [v3] In-Reply-To: References: Message-ID: > Applies cleanly. This backport is a prerequisite to landing https://github.com/openjdk/jdk11u-dev/pull/1277 George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 753c58b7f556fedd7828da487a34b8b228785ff9 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1308/files - new: https://git.openjdk.org/jdk11u-dev/pull/1308/files/7a780521..a3a64c8a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1308&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1308&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1308.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1308/head:pull/1308 PR: https://git.openjdk.org/jdk11u-dev/pull/1308 From duke at openjdk.org Thu Aug 4 00:00:01 2022 From: duke at openjdk.org (duke) Date: Thu, 4 Aug 2022 00:00:01 GMT Subject: [jdk11u-dev] Withdrawn: 8282467: add extra diagnostics for JDK-8268184 In-Reply-To: References: Message-ID: On Tue, 7 Jun 2022 11:06:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1125 From ysatowse at openjdk.org Thu Aug 4 01:17:56 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Thu, 4 Aug 2022 01:17:56 GMT Subject: [jdk19u] RFR: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier Message-ID: Please review this PR. This PR is clean backport of [JDK-8028265](https://bugs.openjdk.org/browse/JDK-8028265). ------------- Commit messages: - Backport fe807217a79753f84c00432e7451c17baa6645c5 Changes: https://git.openjdk.org/jdk19u/pull/9/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=9&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287917 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk19u/pull/9.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/9/head:pull/9 PR: https://git.openjdk.org/jdk19u/pull/9 From ysatowse at openjdk.org Thu Aug 4 01:36:10 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Thu, 4 Aug 2022 01:36:10 GMT Subject: [jdk19u] RFR: 8028265: Add legacy tz tests to OpenJDK Message-ID: Please review this PR. The PR open sources the closed timezone tests. The fix is exact same change as the original fix. [JDK-8028265](https://bugs.openjdk.org/browse/JDK-8028265) ------------- Commit messages: - Backport 92deab546549ca549408a983fe361d9536d2cd37 Changes: https://git.openjdk.org/jdk19u/pull/10/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=10&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8028265 Stats: 1221 lines in 9 files changed: 1221 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/10.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/10/head:pull/10 PR: https://git.openjdk.org/jdk19u/pull/10 From ysatowse at openjdk.org Thu Aug 4 01:36:10 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Thu, 4 Aug 2022 01:36:10 GMT Subject: [jdk19u] RFR: 8028265: Add legacy tz tests to OpenJDK In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 01:26:02 GMT, Yoshiki Sato wrote: > Please review this PR. The PR open sources the closed timezone tests. > The fix is exact same change as the original fix. [JDK-8028265](https://bugs.openjdk.org/browse/JDK-8028265) @coffeys Can I ask you to help reviewing this PR? ------------- PR: https://git.openjdk.org/jdk19u/pull/10 From clanger at openjdk.org Thu Aug 4 05:31:11 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 4 Aug 2022 05:31:11 GMT Subject: [jdk11u-dev] RFR: 8291794: [11u] Corrections after backport of JDK-8212028 [v3] In-Reply-To: References: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> Message-ID: On Wed, 3 Aug 2022 10:12:17 GMT, George Adams wrote: >> This change allows me to merge https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 cleanly > > George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Repair backport of JDK-8211727 This looks good to me. SAP nightlies passed. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1302 From clanger at openjdk.org Thu Aug 4 05:33:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 4 Aug 2022 05:33:55 GMT Subject: [jdk11u-dev] RFR: 8233712: Limit default tests jobs based on ulimit -u setting [v3] In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 22:09:32 GMT, George Adams wrote: >> Applies cleanly. This backport is a prerequisite to landing https://github.com/openjdk/jdk11u-dev/pull/1277 > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 753c58b7f556fedd7828da487a34b8b228785ff9 SAP nightlies passed. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1308 From duke at openjdk.org Thu Aug 4 07:12:13 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 07:12:13 GMT Subject: [jdk11u-dev] Integrated: 8221907: make reconfigure breaks when configured with relative paths In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 12:33:38 GMT, George Adams wrote: > Backport applies cleanly except for missing some WSL-specific patches. Backport is a prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 This pull request has now been integrated. Changeset: 4046ee2a Author: George Adams Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/4046ee2a6957e54b5191550c492ee90b2c6fd1ac Stats: 17 lines in 5 files changed: 4 ins; 0 del; 13 mod 8221907: make reconfigure breaks when configured with relative paths Reviewed-by: clanger Backport-of: 0974861dd800fdb44b3888e68b08c570f1985b58 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1301 From duke at openjdk.org Thu Aug 4 07:26:11 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 07:26:11 GMT Subject: [jdk11u-dev] Integrated: 8291794: [11u] Corrections after backport of JDK-8212028 In-Reply-To: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> References: <7zm40KgaQp_I1raH7jin-OPQVUV4EYJRQEAyVcTqFIA=.8b617d74-9fed-443c-97f3-aeaa7235fc75@github.com> Message-ID: On Tue, 2 Aug 2022 12:44:24 GMT, George Adams wrote: > This change allows me to merge https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9 cleanly This pull request has now been integrated. Changeset: 761e5684 Author: George Adams Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/761e56849f1289693c59ebd2ccb2c476031616c6 Stats: 53 lines in 2 files changed: 12 ins; 37 del; 4 mod 8291794: [11u] Corrections after backport of JDK-8212028 Reviewed-by: clanger Backport-of: 03a8cdece5e1dabcae0cd4f7ce9c0165daa1e476 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1302 From goetz at openjdk.org Thu Aug 4 07:44:22 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Aug 2022 07:44:22 GMT Subject: [jdk17u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 20:43:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. Pre-submit failures: x86 TestStringDeduplicationAgeThreshold.java#id1 Unrelated. max: ant download failed, unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/626 From duke at openjdk.org Thu Aug 4 07:46:21 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 07:46:21 GMT Subject: [jdk11u-dev] RFR: 8233712: Limit default tests jobs based on ulimit -u setting [v4] In-Reply-To: References: Message-ID: <7yQjyyyE_WMyld2dvdfjOlc0Yb5Jw_izC3xf9-3qpH4=.d84167f9-3eaa-4d9b-b20e-1589656dafa1@github.com> > Applies cleanly. This backport is a prerequisite to landing https://github.com/openjdk/jdk11u-dev/pull/1277 George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - Backport 753c58b7f556fedd7828da487a34b8b228785ff9 - Repair backport of JDK-8211727 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1308/files - new: https://git.openjdk.org/jdk11u-dev/pull/1308/files/a3a64c8a..91a28d4d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1308&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1308&range=02-03 Stats: 1051 lines in 28 files changed: 883 ins; 53 del; 115 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1308.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1308/head:pull/1308 PR: https://git.openjdk.org/jdk11u-dev/pull/1308 From dcherepanov at openjdk.org Thu Aug 4 08:01:01 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Thu, 4 Aug 2022 08:01:01 GMT Subject: [jdk15u-dev] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 14:33:12 GMT, Jan Kratochvil wrote: > There was [an accepted backport to OpenJDK-17](https://github.com/openjdk/jdk17u-dev/pull/575). > > This OpenJDK-15 backport: The first condition > > // CDS does not handle useImplMethodHandle > if (useImplMethodHandle) > return generateInnerClass(); > > was not applied cleanly as OpenJDK-15 is missing: > - [8257241](https://bugs.openjdk.java.net/browse/JDK-8257241): CDS should not handle disableEagerInitialization for archived lambda proxy classes > > I was considering whether to backport also [8257241](https://bugs.openjdk.java.net/browse/JDK-8257241) but I do not think it is right as [8257241](https://bugs.openjdk.java.net/browse/JDK-8257241): > - does not fix any bug, it is only a code cleanup > - it modifies runtime introspection and possibly performance > > This OpenJDK-15 backport: Original commit errors on OpenJDK-15 with: > ` TEST RESULT: Error. can't find jdk.test.lib.helpers.ClassFileInstaller in test directory or libraries` > as OpenJDK-15 is missing: > - [8263412](https://bugs.openjdk.org/browse/JDK-8263412): ClassFileInstaller can't be used by classes outside of default package > > This OpenJDK-15 backport: Original commit errors on OpenJDK-15 with: > > error: cannot find symbol > symbol: method dumpClassList(String,String,String,String) > location: class CDSTestUtils > > as OpenJDK-15 is missing: > - [8213226](https://bugs.openjdk.org/browse/JDK-8213226): [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog() > > > I am not yet an Author - I do not have JBS account. > I have run the testsuite on Linux x86_64 and there is no change of the results. Two new testcases are added and they are both Passing. The testcases are still Passing after backporting them to 15u-dev. > > +Passed: runtime/cds/appcds/LambdaWithUseImplMethodHandle.java > +Passed: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/251 From coffeys at openjdk.org Thu Aug 4 08:04:32 2022 From: coffeys at openjdk.org (Sean Coffey) Date: Thu, 4 Aug 2022 08:04:32 GMT Subject: [jdk19u] RFR: 8028265: Add legacy tz tests to OpenJDK In-Reply-To: References: Message-ID: <9fqLI6LZkRNEtkERbyOrxFbUf6SOCVzo3bUgHMNC7tE=.59217150-f240-4ea1-b589-de4223ae7177@github.com> On Thu, 4 Aug 2022 01:26:02 GMT, Yoshiki Sato wrote: > Please review this PR. The PR open sources the closed timezone tests. > The fix is exact same change as the original fix. [JDK-8028265](https://bugs.openjdk.org/browse/JDK-8028265) Marked as reviewed by coffeys (Reviewer). ------------- PR: https://git.openjdk.org/jdk19u/pull/10 From duke at openjdk.org Thu Aug 4 08:21:07 2022 From: duke at openjdk.org (Jan Kratochvil) Date: Thu, 4 Aug 2022 08:21:07 GMT Subject: [jdk15u-dev] Integrated: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 14:33:12 GMT, Jan Kratochvil wrote: > There was [an accepted backport to OpenJDK-17](https://github.com/openjdk/jdk17u-dev/pull/575). > > This OpenJDK-15 backport: The first condition > > // CDS does not handle useImplMethodHandle > if (useImplMethodHandle) > return generateInnerClass(); > > was not applied cleanly as OpenJDK-15 is missing: > - [8257241](https://bugs.openjdk.java.net/browse/JDK-8257241): CDS should not handle disableEagerInitialization for archived lambda proxy classes > > I was considering whether to backport also [8257241](https://bugs.openjdk.java.net/browse/JDK-8257241) but I do not think it is right as [8257241](https://bugs.openjdk.java.net/browse/JDK-8257241): > - does not fix any bug, it is only a code cleanup > - it modifies runtime introspection and possibly performance > > This OpenJDK-15 backport: Original commit errors on OpenJDK-15 with: > ` TEST RESULT: Error. can't find jdk.test.lib.helpers.ClassFileInstaller in test directory or libraries` > as OpenJDK-15 is missing: > - [8263412](https://bugs.openjdk.org/browse/JDK-8263412): ClassFileInstaller can't be used by classes outside of default package > > This OpenJDK-15 backport: Original commit errors on OpenJDK-15 with: > > error: cannot find symbol > symbol: method dumpClassList(String,String,String,String) > location: class CDSTestUtils > > as OpenJDK-15 is missing: > - [8213226](https://bugs.openjdk.org/browse/JDK-8213226): [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog() > > > I am not yet an Author - I do not have JBS account. > I have run the testsuite on Linux x86_64 and there is no change of the results. Two new testcases are added and they are both Passing. The testcases are still Passing after backporting them to 15u-dev. > > +Passed: runtime/cds/appcds/LambdaWithUseImplMethodHandle.java > +Passed: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java This pull request has now been integrated. Changeset: b176776d Author: Jan Kratochvil Committer: Dmitry Cherepanov URL: https://git.openjdk.org/jdk15u-dev/commit/b176776dad1bde8e638a7be3de8f406e163d8bfa Stats: 439 lines in 7 files changed: 439 ins; 0 del; 0 mod 8290417: CDS cannot archive lamda proxy with useImplMethodHandle Reviewed-by: dcherepanov Backport-of: 4dc421caa02caedd7061ede6a5ec44dbb6ec738e ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/251 From duke at openjdk.org Thu Aug 4 08:31:15 2022 From: duke at openjdk.org (duke) Date: Thu, 4 Aug 2022 08:31:15 GMT Subject: [jdk18u] Withdrawn: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset In-Reply-To: References: Message-ID: On Wed, 8 Jun 2022 21:03:35 GMT, Zhengyu Gu wrote: > A clean backport to fix memory leaks. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk18u/pull/150 From duke at openjdk.org Thu Aug 4 08:31:24 2022 From: duke at openjdk.org (duke) Date: Thu, 4 Aug 2022 08:31:24 GMT Subject: [jdk18u] Withdrawn: 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment In-Reply-To: References: Message-ID: On Wed, 8 Jun 2022 20:28:11 GMT, Zhengyu Gu wrote: > A clean backport to fix memory leaks. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk18u/pull/149 From duke at openjdk.org Thu Aug 4 08:36:48 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 08:36:48 GMT Subject: [jdk11u-dev] Integrated: 8233712: Limit default tests jobs based on ulimit -u setting In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 08:37:37 GMT, George Adams wrote: > Applies cleanly. This backport is a prerequisite to landing https://github.com/openjdk/jdk11u-dev/pull/1277 This pull request has now been integrated. Changeset: 08e51f5b Author: George Adams Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/08e51f5b154044fcbbe50457edc59a3517755e1c Stats: 43 lines in 4 files changed: 43 ins; 0 del; 0 mod 8233712: Limit default tests jobs based on ulimit -u setting Reviewed-by: clanger Backport-of: 753c58b7f556fedd7828da487a34b8b228785ff9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1308 From duke at openjdk.org Thu Aug 4 08:47:51 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 08:47:51 GMT Subject: [jdk11u-dev] RFR: 8178317: Create man pages using pandoc from markdown sources Message-ID: The only diff is in https://github.com/gdams/jdk11u-dev/blob/39b843f26365ce6a5bd5f0ee6d8e1bec57df59d4/make/launcher/LauncherCommon.gmk#L30 which has the additional include (`include TextFileProcessing.gmk`). Other than that the patch was applied cleanly. Also includes the patch [8215635: Pandoc check in Docs.gmk does not work on Windows](https://github.com/openjdk/jdk/commit/9f1d035d8d862fc0e827c1df7e34f4b4c062c6a1) as this no longer seems to have a JBS issue (maybe deleted) prerequisite to https://github.com/openjdk/jdk/commit/9f1d035d8d862fc0e827c1df7e34f4b4c062c6a1 and https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf ------------- Commit messages: - Backport 2ddd78e8259652c7c88a5bb7150d7b6ab0e089e2 - Backport 6217349ee65fa4f564b0679774877716594981d3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1312/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1312&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8178317 Stats: 58827 lines in 180 files changed: 396 ins; 58384 del; 47 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1312.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1312/head:pull/1312 PR: https://git.openjdk.org/jdk11u-dev/pull/1312 From ysatowse at openjdk.org Thu Aug 4 08:57:14 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Thu, 4 Aug 2022 08:57:14 GMT Subject: [jdk19u] Integrated: 8028265: Add legacy tz tests to OpenJDK In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 01:26:02 GMT, Yoshiki Sato wrote: > Please review this PR. The PR open sources the closed timezone tests. > The fix is exact same change as the original fix. [JDK-8028265](https://bugs.openjdk.org/browse/JDK-8028265) This pull request has now been integrated. Changeset: 4d1e9b3b Author: Yoshiki Sato Committer: Sean Coffey URL: https://git.openjdk.org/jdk19u/commit/4d1e9b3b153963079815180ceef4d41482d1a610 Stats: 1221 lines in 9 files changed: 1221 ins; 0 del; 0 mod 8028265: Add legacy tz tests to OpenJDK Reviewed-by: coffeys Backport-of: 92deab546549ca549408a983fe361d9536d2cd37 ------------- PR: https://git.openjdk.org/jdk19u/pull/10 From duke at openjdk.org Thu Aug 4 08:57:52 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 08:57:52 GMT Subject: [jdk11u-dev] RFR: 8215635: Pandoc check in Docs.gmk does not work on Windows Message-ID: patch applies cleanly - prerequisite to https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1312 Commit messages: - Backport 9f1d035d8d862fc0e827c1df7e34f4b4c062c6a1 Changes: https://git.openjdk.org/jdk11u-dev/pull/1313/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1313&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8215635 Stats: 10 lines in 4 files changed: 8 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1313.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1313/head:pull/1313 PR: https://git.openjdk.org/jdk11u-dev/pull/1313 From coffeys at openjdk.org Thu Aug 4 09:11:21 2022 From: coffeys at openjdk.org (Sean Coffey) Date: Thu, 4 Aug 2022 09:11:21 GMT Subject: [jdk19u] RFR: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier In-Reply-To: References: Message-ID: <3uOrBxV9WdupE1-ca1TNvO-iPW_MqZ3v3c1riVOCgf0=.7c4389d7-abf2-45d9-b286-655ed419ecc5@github.com> On Thu, 4 Aug 2022 01:03:12 GMT, Yoshiki Sato wrote: > Please review this PR. This PR is clean backport of [JDK-8028265](https://bugs.openjdk.org/browse/JDK-8028265). Marked as reviewed by coffeys (Reviewer). ------------- PR: https://git.openjdk.org/jdk19u/pull/9 From ysatowse at openjdk.org Thu Aug 4 09:16:45 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Thu, 4 Aug 2022 09:16:45 GMT Subject: [jdk19u] Integrated: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier In-Reply-To: References: Message-ID: <-25UYMv3FNKtUzQzE3mhkf0G8ffsYCa0wOc-AU6TsDs=.965f4251-c948-4f1e-97f6-5a5c5f5d6d2f@github.com> On Thu, 4 Aug 2022 01:03:12 GMT, Yoshiki Sato wrote: > Please review this PR. This PR is clean backport of [JDK-8028265](https://bugs.openjdk.org/browse/JDK-8028265). This pull request has now been integrated. Changeset: 2ff243c9 Author: Yoshiki Sato Committer: Sean Coffey URL: https://git.openjdk.org/jdk19u/commit/2ff243c904b067af661b76a960c3be6fedcae1bb Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier Reviewed-by: coffeys Backport-of: fe807217a79753f84c00432e7451c17baa6645c5 ------------- PR: https://git.openjdk.org/jdk19u/pull/9 From serb at openjdk.org Thu Aug 4 09:21:44 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 4 Aug 2022 09:21:44 GMT Subject: [jdk15u-dev] RFR: 8276841: Add support for Visual Studio 2022 Message-ID: <7O6xW26qdAMqetqzepGgtoZf8HIIsU9ivIlpklPEqxc=.8c660dfb-a478-4fba-b581-cf2c7e4e12cf@github.com> Hi all, This pull request contains a backport of commit [f65db88b](https://github.com/openjdk/jdk/commit/f65db88b74911e5896d2ff536c4ac97e7f62d98b) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Yasumasa Suenaga on 9 Nov 2021 and was reviewed by Erik Joelsson and Magnus Ihse Bursie. The change is not "clean" because the jdk15u supports more versions than the jdk/jdk. I have tested the build using VS 2019 and 2022, results of tier1/tier2 are the same. Thanks! ------------- Commit messages: - Backport f65db88b74911e5896d2ff536c4ac97e7f62d98b Changes: https://git.openjdk.org/jdk15u-dev/pull/252/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=252&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276841 Stats: 17 lines in 1 file changed: 15 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/252.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/252/head:pull/252 PR: https://git.openjdk.org/jdk15u-dev/pull/252 From duke at openjdk.org Thu Aug 4 09:29:48 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 09:29:48 GMT Subject: [jdk11u-dev] RFR: 8215131: Pandoc 2.3/build documentation fixes Message-ID: changes apply cleanly except for the cross-compile markdown table which was updated in https://github.com/openjdk/jdk11u-dev/commit/90ac8aea0372a6f26592015ca42b98b109ac89f7 Prerequisite to backporting https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1313 Commit messages: - Backport 8c00337375d67f6e7991073da8a93e2a6d733a24 Changes: https://git.openjdk.org/jdk11u-dev/pull/1314/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1314&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8215131 Stats: 35 lines in 3 files changed: 14 ins; 1 del; 20 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1314.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1314/head:pull/1314 PR: https://git.openjdk.org/jdk11u-dev/pull/1314 From duke at openjdk.org Thu Aug 4 09:38:38 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 09:38:38 GMT Subject: [jdk11u-dev] RFR: 8217032: Check pandoc capabilities in configure Message-ID: Backport applies cleanly other than the [following two lines](https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf#diff-b2617a3c263800cf342a5a17bf7bd8dde629a6445bee9eca59c40686dca7932bR621-R622) not being present in JDK11u. This backport is the final prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1314 Commit messages: - Backport 4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf Changes: https://git.openjdk.org/jdk11u-dev/pull/1315/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1315&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8217032 Stats: 39 lines in 3 files changed: 31 ins; 7 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1315.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1315/head:pull/1315 PR: https://git.openjdk.org/jdk11u-dev/pull/1315 From duke at openjdk.org Thu Aug 4 10:05:34 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 10:05:34 GMT Subject: [jdk11u-dev] RFR: 8239708: Split basics.m4 into basic.m4 and util.m4 [v2] In-Reply-To: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> References: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. > > This backport will also considerably help many build/toolchain backports going forwards as this one nearly always trips me up when I backport patches. > > This backport will allow me to more easily backport [8257679: Improved unix compatibility layer in Windows build (winenv)](https://github.com/openjdk/jdk/commit/d29c78da). > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 63f939636a5fe9871f5f9057c93ed5b1a9924265 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1277/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1277&range=01 Stats: 4185 lines in 20 files changed: 2110 ins; 1939 del; 136 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1277.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1277/head:pull/1277 PR: https://git.openjdk.org/jdk11u-dev/pull/1277 From duke at openjdk.org Thu Aug 4 10:05:34 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 10:05:34 GMT Subject: [jdk11u-dev] RFR: 8239708: Split basics.m4 into basic.m4 and util.m4 In-Reply-To: References: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> Message-ID: On Mon, 1 Aug 2022 21:40:47 GMT, Christoph Langer wrote: > https://bugs.openjdk.org/browse/JDK-8218413 (https://github.com/openjdk/jdk/commit/9efdb33a59f7db7b4b39e113265a3b3ba513c5d3) Done via https://github.com/openjdk/jdk11u-dev/pull/1300 > https://bugs.openjdk.org/browse/JDK-8217032 (https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf) Done via https://github.com/openjdk/jdk11u-dev/pull/1315 > https://bugs.openjdk.org/browse/JDK-8221907 (https://github.com/openjdk/jdk/commit/0974861dd800fdb44b3888e68b08c570f1985b58) Done via https://github.com/openjdk/jdk11u-dev/pull/1301 > https://bugs.openjdk.org/browse/JDK-8233712 (https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9) Done via https://github.com/openjdk/jdk11u-dev/pull/1308 > https://bugs.openjdk.org/browse/JDK-8206125 (https://github.com/openjdk/jdk/commit/7ae384b2ad25d39f271f936ee98ab28a5f92fa94) is partly implemented in your change. Some hunks in new util_windows.m4 are missing, however. Please make sure it's completely contained in your backport and add the issue to this PR then. I've added the remaining chunk, issue added to backport > https://bugs.openjdk.org/browse/JDK-8213239 (https://github.com/openjdk/jdk/commit/68dbbf566d8d504308367005048d274aebfd5b50) is contained in your PR. Please mark as backported by adding it to this PR. Issue added to backport > https://bugs.openjdk.org/browse/JDK-8240972: Make sure that the changes don't get lost. The implementation file is a different before and after this change. See: https://github.com/openjdk/jdk11u-dev/commit/f771367f73bd01648a454fdd0298b8b4479a3ca0 vs. https://github.com/openjdk/jdk/commit/e30b89e1389ccd7bd2c6bb2265a3110f6fcd31de I've reimplemented this > Then, the backport of https://bugs.openjdk.org/browse/JDK-8285728 (https://github.com/openjdk/jdk11u-dev/commit/f00776b653b9d0e1d556c6b44446fe18d72617c1) must not be lost which it currently would. I've reimplemented this > And finally, we should thoroughly check whether the fix for 8226346: Build better binary builders (non-public bug, contained in a CPU release) is still intact after this PR. The implementation file is also different, see https://github.com/openjdk/jdk11u-dev/commit/3e9a9c9c4955185ae2be6dd97ddf1c03a4588395 vs. https://github.com/openjdk/jdk/commit/4df99aa7aeaed0d6132ca5c86f803f1096df8841 I've carried over the change to `basics.m4`. This should be okay now ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1277 From duke at openjdk.org Thu Aug 4 10:06:26 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 10:06:26 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v2] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/cafc444b..cafc444b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From goetz.lindenmaier at sap.com Thu Aug 4 10:16:02 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 4 Aug 2022 10:16:02 +0000 Subject: Result: New JDK Updates Committer: Jie Fu Message-ID: Voting for Jie Fu [1] is now closed. Yes: 11 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Best regards, Goetz [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-July/015837.html -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Thu Aug 4 10:52:38 2022 From: duke at openjdk.org (psoujany) Date: Thu, 4 Aug 2022 10:52:38 GMT Subject: [jdk11u-dev] RFR: 8209052: Low contrast in docs/api/constant-values.html Message-ID: 8209052: Low contrast in docs/api/constant-values.html ------------- Commit messages: - Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 Changes: https://git.openjdk.org/jdk11u-dev/pull/1316/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1316&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8209052 Stats: 12 lines in 1 file changed: 4 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1316.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1316/head:pull/1316 PR: https://git.openjdk.org/jdk11u-dev/pull/1316 From duke at openjdk.org Thu Aug 4 11:23:01 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:23:01 GMT Subject: [jdk11u-dev] RFR: 8215131: Pandoc 2.3/build documentation fixes In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 09:20:44 GMT, George Adams wrote: > changes apply cleanly except for the cross-compile markdown table which was updated in https://github.com/openjdk/jdk11u-dev/commit/90ac8aea0372a6f26592015ca42b98b109ac89f7 > > Prerequisite to backporting https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf https://github.com/openjdk/jdk11u-dev/pull/1277 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1314 From duke at openjdk.org Thu Aug 4 11:22:59 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:22:59 GMT Subject: [jdk11u-dev] Withdrawn: 8217032: Check pandoc capabilities in configure In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 09:31:17 GMT, George Adams wrote: > Backport applies cleanly other than the [following two lines](https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf#diff-b2617a3c263800cf342a5a17bf7bd8dde629a6445bee9eca59c40686dca7932bR621-R622) not being present in JDK11u. > > This backport is the final prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1315 From duke at openjdk.org Thu Aug 4 11:23:02 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:23:02 GMT Subject: [jdk11u-dev] Withdrawn: 8215131: Pandoc 2.3/build documentation fixes In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 09:20:44 GMT, George Adams wrote: > changes apply cleanly except for the cross-compile markdown table which was updated in https://github.com/openjdk/jdk11u-dev/commit/90ac8aea0372a6f26592015ca42b98b109ac89f7 > > Prerequisite to backporting https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1314 From duke at openjdk.org Thu Aug 4 11:22:59 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:22:59 GMT Subject: [jdk11u-dev] RFR: 8217032: Check pandoc capabilities in configure In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 09:31:17 GMT, George Adams wrote: > Backport applies cleanly other than the [following two lines](https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf#diff-b2617a3c263800cf342a5a17bf7bd8dde629a6445bee9eca59c40686dca7932bR621-R622) not being present in JDK11u. > > This backport is the final prerequisite of https://github.com/openjdk/jdk11u-dev/pull/1277 https://github.com/openjdk/jdk11u-dev/pull/1277 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1315 From duke at openjdk.org Thu Aug 4 11:24:01 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:24:01 GMT Subject: [jdk11u-dev] RFR: 8178317: Create man pages using pandoc from markdown sources In-Reply-To: References: Message-ID: <-NqYAOpr9tTNp0Wdno3bt72APR8nP_OiKty_ooKOau8=.fce9d5e8-4816-41c4-b893-2810dbb18335@github.com> On Thu, 4 Aug 2022 08:39:15 GMT, George Adams wrote: > The only diff is in https://github.com/gdams/jdk11u-dev/blob/39b843f26365ce6a5bd5f0ee6d8e1bec57df59d4/make/launcher/LauncherCommon.gmk#L30 which has the additional include (`include TextFileProcessing.gmk`). Other than that the patch was applied cleanly. > > Also includes the patch [8215635: Pandoc check in Docs.gmk does not work on Windows](https://github.com/openjdk/jdk/commit/9f1d035d8d862fc0e827c1df7e34f4b4c062c6a1) as this no longer seems to have a JBS issue (maybe deleted) > > prerequisite to https://github.com/openjdk/jdk/commit/9f1d035d8d862fc0e827c1df7e34f4b4c062c6a1 and https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf closing as no longer needed to backport https://github.com/openjdk/jdk11u-dev/pull/1277 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1312 From duke at openjdk.org Thu Aug 4 11:24:02 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:24:02 GMT Subject: [jdk11u-dev] Withdrawn: 8178317: Create man pages using pandoc from markdown sources In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 08:39:15 GMT, George Adams wrote: > The only diff is in https://github.com/gdams/jdk11u-dev/blob/39b843f26365ce6a5bd5f0ee6d8e1bec57df59d4/make/launcher/LauncherCommon.gmk#L30 which has the additional include (`include TextFileProcessing.gmk`). Other than that the patch was applied cleanly. > > Also includes the patch [8215635: Pandoc check in Docs.gmk does not work on Windows](https://github.com/openjdk/jdk/commit/9f1d035d8d862fc0e827c1df7e34f4b4c062c6a1) as this no longer seems to have a JBS issue (maybe deleted) > > prerequisite to https://github.com/openjdk/jdk/commit/9f1d035d8d862fc0e827c1df7e34f4b4c062c6a1 and https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1312 From duke at openjdk.org Thu Aug 4 11:24:11 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:24:11 GMT Subject: [jdk11u-dev] RFR: 8215635: Pandoc check in Docs.gmk does not work on Windows In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 08:49:00 GMT, George Adams wrote: > patch applies cleanly - prerequisite to https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf https://github.com/openjdk/jdk11u-dev/pull/1277 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1313 From duke at openjdk.org Thu Aug 4 11:24:12 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:24:12 GMT Subject: [jdk11u-dev] Withdrawn: 8215635: Pandoc check in Docs.gmk does not work on Windows In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 08:49:00 GMT, George Adams wrote: > patch applies cleanly - prerequisite to https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1313 From duke at openjdk.org Thu Aug 4 11:28:00 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:28:00 GMT Subject: [jdk11u-dev] RFR: 8239708: Split basics.m4 into basic.m4 and util.m4 [v3] In-Reply-To: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> References: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. > > This backport will also considerably help many build/toolchain backports going forwards as this one nearly always trips me up when I backport patches. > > This backport will allow me to more easily backport [8257679: Improved unix compatibility layer in Windows build (winenv)](https://github.com/openjdk/jdk/commit/d29c78da). > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 63f939636a5fe9871f5f9057c93ed5b1a9924265 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1277/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1277&range=02 Stats: 4149 lines in 20 files changed: 2080 ins; 1933 del; 136 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1277.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1277/head:pull/1277 PR: https://git.openjdk.org/jdk11u-dev/pull/1277 From duke at openjdk.org Thu Aug 4 11:31:21 2022 From: duke at openjdk.org (George Adams) Date: Thu, 4 Aug 2022 11:31:21 GMT Subject: [jdk11u-dev] RFR: 8239708: Split basics.m4 into basic.m4 and util.m4 [v4] In-Reply-To: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> References: <_uZb64GesM3wvNTBp2MQ0wWphI3AUB1QNwGQL13Vmdg=.a501fa6b-9895-438d-8cce-ad17b1f5e814@github.com> Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. > > This backport will also considerably help many build/toolchain backports going forwards as this one nearly always trips me up when I backport patches. > > This backport will allow me to more easily backport [8257679: Improved unix compatibility layer in Windows build (winenv)](https://github.com/openjdk/jdk/commit/d29c78da). > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 63f939636a5fe9871f5f9057c93ed5b1a9924265 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1277/files - new: https://git.openjdk.org/jdk11u-dev/pull/1277/files/3ed3057a..76209878 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1277&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1277&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1277.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1277/head:pull/1277 PR: https://git.openjdk.org/jdk11u-dev/pull/1277 From clanger at openjdk.org Thu Aug 4 12:05:16 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 4 Aug 2022 12:05:16 GMT Subject: [jdk17u-dev] Integrated: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism In-Reply-To: References: Message-ID: On Tue, 2 Aug 2022 18:35:40 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8280944](https://bugs.openjdk.java.net/browse/JDK-8280944), commit [87ab0994](https://github.com/openjdk/jdk/commit/87ab0994ded3b535a160bb87b6540bd072042c44) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Since [JDK-8280233](https://bugs.openjdk.org/browse/JDK-8280233) was brought to jdk17u, @dfuch suggested to bring this one along. > > The commit being backported was authored by Michael McMahon on 2 Feb 2022 and was reviewed by Daniel Fuchs and Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: b2848515 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/b2848515430a2a3fbb7cd3fd28bd313b097a8c0c Stats: 35 lines in 3 files changed: 22 ins; 1 del; 12 mod 8280944: Enable Unix domain sockets in Windows Selector notification mechanism Backport-of: 87ab0994ded3b535a160bb87b6540bd072042c44 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/625 From phh at openjdk.org Thu Aug 4 12:24:07 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 4 Aug 2022 12:24:07 GMT Subject: [jdk15u-dev] RFR: 8276841: Add support for Visual Studio 2022 In-Reply-To: <7O6xW26qdAMqetqzepGgtoZf8HIIsU9ivIlpklPEqxc=.8c660dfb-a478-4fba-b581-cf2c7e4e12cf@github.com> References: <7O6xW26qdAMqetqzepGgtoZf8HIIsU9ivIlpklPEqxc=.8c660dfb-a478-4fba-b581-cf2c7e4e12cf@github.com> Message-ID: On Wed, 3 Aug 2022 21:54:14 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [f65db88b](https://github.com/openjdk/jdk/commit/f65db88b74911e5896d2ff536c4ac97e7f62d98b) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Yasumasa Suenaga on 9 Nov 2021 and was reviewed by Erik Joelsson and Magnus Ihse Bursie. > > The change is not "clean" because the jdk15u supports more versions than the jdk/jdk. > I have tested the build using VS 2019 and 2022, results of tier1/tier2 are the same. > > Thanks! Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk15u-dev/pull/252 From goetz at openjdk.org Thu Aug 4 14:14:58 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Aug 2022 14:14:58 GMT Subject: [jdk17u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update Message-ID: I backport this for parity with 17.0.5-oracle. In 17, file CurrencyData.properties is at make/data/currency/ while in head it is at src/java.base/share/data/currency/ Directing the patch to the right file makes it apply clean. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/626 Commit messages: - Backport 604ea90d55ac8354fd7287490ef59b8e3ce020d1 Changes: https://git.openjdk.org/jdk17u-dev/pull/627/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=627&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289549 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/627.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/627/head:pull/627 PR: https://git.openjdk.org/jdk17u-dev/pull/627 From duke at openjdk.org Thu Aug 4 15:53:19 2022 From: duke at openjdk.org (duke) Date: Thu, 4 Aug 2022 15:53:19 GMT Subject: [jdk17u-dev] Withdrawn: 8155701: The compiler fails with an AssertionError: typeSig ERROR In-Reply-To: References: Message-ID: On Thu, 9 Jun 2022 09:38:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/453 From phh at openjdk.org Thu Aug 4 16:38:17 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 4 Aug 2022 16:38:17 GMT Subject: [jdk11u-dev] RFR: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 14:04:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. > > I had to adapt the String literal in PrintLatinCJKTest.java to Java 11 syntax. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1309 From duke at openjdk.org Thu Aug 4 20:14:09 2022 From: duke at openjdk.org (Dan Lutker) Date: Thu, 4 Aug 2022 20:14:09 GMT Subject: [jdk11u-dev] RFR: 7131823: bug in GIFImageReader Message-ID: <7E7txzeypEU9mAMBOMRZCuXqYZNbg6pIsQcFwwjmbiw=.2d17b087-388e-4844-a705-7b51ae028c4b@github.com> This is a backport of JDK-7131823: bug in GIFImageReader Original patch applied cleanly and all imageio tests pass on linux x64 including the new `javax/imageio/plugins/gif/GIFLargeTableIndexTest.java`. Summary: jdk_imageio TEST STATS: name=jdk_imageio run=196 pass=196 fail=0 All teir1 passed as well. ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier1 1461 1461 0 0 jtreg:test/jdk:tier1 1874 1874 0 0 jtreg:test/langtools:tier1 3924 3924 0 0 jtreg:test/nashorn:tier1 0 0 0 0 jtreg:test/jaxp:tier1 0 0 0 0 ============================== TEST SUCCESS ------------- Commit messages: - Backport a31130fd4056907edcb420761722c629a33273eb Changes: https://git.openjdk.org/jdk11u-dev/pull/1317/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1317&range=00 Issue: https://bugs.openjdk.org/browse/JDK-7131823 Stats: 175 lines in 2 files changed: 158 ins; 4 del; 13 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1317.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1317/head:pull/1317 PR: https://git.openjdk.org/jdk11u-dev/pull/1317 From goetz.lindenmaier at sap.com Thu Aug 4 20:30:18 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 4 Aug 2022 20:30:18 +0000 Subject: C2 exhausts system memory compiling SSLEngineInputRecord::decodeInputRecord In-Reply-To: References: <2049aeed-5902-4f94-b7c5-d713da8fda38@www.fastmail.com> Message-ID: I guess this should also go to jdk-updates. Best regards, Goetz. From: Lindenmaier, Goetz Sent: Thursday, August 4, 2022 10:29 PM To: Carter Kozak ; hotspot-compiler-dev at openjdk.org Subject: RE: C2 exhausts system memory compiling SSLEngineInputRecord::decodeInputRecord Hi, We ran into the presumable same issue. We already narrowed it down to the same change. I had opened [JDK-8291919] [11u] High compiler native memory consumption after 8280799 - Java Bug System (openjdk.org) For this. Best regards, Goetz. From: hotspot-compiler-dev > On Behalf Of Carter Kozak Sent: Thursday, August 4, 2022 9:57 PM To: hotspot-compiler-dev at openjdk.org Subject: C2 exhausts system memory compiling SSLEngineInputRecord::decodeInputRecord Hi, I filed JDK-8291665 [1] which was originally closed as "This is not a java bug, the crash is on zulu build"; however, I've since been able to reproduce the issue on standard OpenJDK builds consistently with a compiler replay log [2]. Unfortunately I lack the permissions to update the ticket myself, so I'd like to share my findings here, and hopefully work toward a solution. This impacts OpenJDK jdk-11.0.16-ga [3] (Latest OpenJDK 11 hotfix which resolves a cvss 9.8 vulnerability) observed using public builds as well as a build I created from source. The crash impacted dozens of applications repeatedly within the first day of rollout, as the pattern which triggers the failure exists within the JDK itself, used within TLS. The failure presents as a jvm crash after the compiler consumes all physical memory. Some applications crash after 50-90 seconds around ~30% of launches, while others crash less frequently. In all cases I've observed, the failure has been within C2 compilation of SSLEngineInputRecord::decodeInputRecord The failure is reproducible using the compiler replay log with a debug-enabled jdk-11.0.16-ga and produces an hs_err_pid log as seen below: ./linux-x86_64-normal-server-fastdebug-jdk-11.0.16-ga/bin/java -XX:+ReplayCompiles -XX:ReplayDataFile=replay.log I have verified that the failure is not reproducible using the previous release jdk-11.0.15-ga. The failure appears to be the result of commit 9ce8530c [4] (JDK-8279219 [REDO] C2 crash when allocating array of size too large [5]), reverting this commit allows the replay to complete successfully (not to imply the commit itself should be reverted as I don't have context on what it resolves, but it should help narrow the search space). Thanks, Carter Kozak [1] https://bugs.openjdk.org/browse/JDK-8291665 [2] Compiler replay log can be found here: https://gist.github.com/carterkozak/4aff21e72e74d42320b4427953a56385 [3] https://github.com/openjdk/jdk11u/releases/tag/jdk-11.0.16-ga [4] https://github.com/openjdk/jdk11u/commit/9ce8530c5d5f179fa42e1060447aead887570124 [5] https://bugs.openjdk.org/browse/JDK-8279219 # To suppress the following error report, specify this argument # after -XX: or in .hotspotrc: SuppressErrorAt=/split_if.cpp:131 # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/home/user/code/openjdk/jdk11u-dev/src/hotspot/share/opto/split_if.cpp:131), pid=165552, tid=165579 # assert(use->is_If() || use->is_CMove() || use->Opcode() == Op_Opaque1 || use->is_AllocateArray()) failed: unexpected node type # # JRE version: OpenJDK Runtime Environment (11.0.16) (fastdebug build 11.0.16-internal+0-adhoc.user.jdk11u-dev) # Java VM: OpenJDK 64-Bit Server VM (fastdebug 11.0.16-internal+0-adhoc.user.jdk11u-dev, mixed mode, tiered, compressed oops, g1 gc, linux-amd64) # Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport -p%p -s%s -c%c -d%d -P%P -u%u -g%g -- %E" (or dumping to /home/user/jvm-debugging/core.165552) # # An error report file with more information is saved as: # /home/user/jvm-debugging/hs_err_pid165552.log # # If you would like to submit a bug report, please visit: # https://bugreport.java.com/bugreport/crash.jsp # Current thread is 165579 Dumping core ... zsh: abort (core dumped) ./linux-x86_64-normal-server-fastdebug-jdk-11.0.16-ga/bin/jav # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/home/user/code/openjdk/jdk11u-dev/src/hotspot/share/opto/split_if.cpp:131), pid=165552, tid=165579 # assert(use->is_If() || use->is_CMove() || use->Opcode() == Op_Opaque1 || use->is_AllocateArray()) failed: unexpected node type # # JRE version: OpenJDK Runtime Environment (11.0.16) (fastdebug build 11.0.16-internal+0-adhoc.user.jdk11u-dev) # Java VM: OpenJDK 64-Bit Server VM (fastdebug 11.0.16-internal+0-adhoc.user.jdk11u-dev, mixed mode, tiered, compressed oops, g1 gc, linux-amd64) # Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport -p%p -s%s -c%c -d%d -P%P -u%u -g%g -- %E" (or dumping to /home/user/jvm-debugging/core.165552) # # If you would like to submit a bug report, please visit: # https://bugreport.java.com/bugreport/crash.jsp # --------------- S U M M A R Y ------------ Command Line: -XX:+ReplayCompiles -XX:ReplayDataFile=replay.log Host: linux, Intel(R) Xeon(R) W-2175 CPU @ 2.50GHz, 28 cores, 62G, Ubuntu 20.04.4 LTS Time: Thu Aug 4 08:27:42 2022 EDT elapsed time: 0.606943 seconds (0d 0h 0m 0s) --------------- T H R E A D --------------- Current thread (0x00007f75003c8800): JavaThread "C2 CompilerThread0" daemon [_thread_in_native, id=165579, stack(0x00007f74b6434000,0x00007f74b6535000)] Current CompileTask: C2: 606 27 !b 4 sun.security.ssl.SSLEngineInputRecord::decodeInputRecord (812 bytes) Stack: [0x00007f74b6434000,0x00007f74b6535000], sp=0x00007f74b652e030, free space=1000k Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x1a6ea5a] VMError::report_and_die(int, char const*, char const*, __va_list_tag*, Thread*, unsigned char*, void*, void*, char const*, int, unsigned long)+0x1ca V [libjvm.so+0x1a6fbc5] VMError::report_and_die(Thread*, void*, char const*, int, char const*, char const*, __va_list_tag*)+0x35 V [libjvm.so+0xc302aa] report_vm_error(char const*, int, char const*, char const*, ...)+0x10a V [libjvm.so+0x187b68d] PhaseIdealLoop::split_up(Node*, Node*, Node*) [clone .part.0]+0x173d V [libjvm.so+0x187f8e3] PhaseIdealLoop::do_split_if(Node*)+0x763 V [libjvm.so+0x1442420] PhaseIdealLoop::split_if_with_blocks_post(Node*, bool)+0xf20 V [libjvm.so+0x144267d] PhaseIdealLoop::split_if_with_blocks(VectorSet&, Node_Stack&, bool)+0x20d V [libjvm.so+0x14378a3] PhaseIdealLoop::build_and_optimize()+0x1133 V [libjvm.so+0xb3f881] Compile::optimize_loops(int&, PhaseIterGVN&, LoopOptsMode) [clone .part.0]+0x311 V [libjvm.so+0xb4418f] Compile::Optimize()+0xd1f V [libjvm.so+0xb46116] Compile::Compile(ciEnv*, C2Compiler*, ciMethod*, int, bool, bool, bool, bool, DirectiveSet*)+0x1ae6 V [libjvm.so+0x915c24] C2Compiler::compile_method(ciEnv*, ciMethod*, int, DirectiveSet*)+0x334 V [libjvm.so+0xb57250] CompileBroker::invoke_compiler_on_method(CompileTask*)+0x540 V [libjvm.so+0xb588f8] CompileBroker::compiler_thread_loop()+0x678 V [libjvm.so+0x19a4c52] JavaThread::thread_main_inner()+0x252 V [libjvm.so+0x199d62b] Thread::call_run()+0x7b V [libjvm.so+0x1693926] thread_native_entry(Thread*)+0x106 --------------- P R O C E S S --------------- uid : 1000 euid : 1000 gid : 1000 egid : 1000 umask: 0002 (-------w-) Threads class SMR info: _java_thread_list=0x00007f7500885270, length=9, elements={ 0x00007f7500032000, 0x00007f750039e000, 0x00007f75003a0800, 0x00007f75003c3800, 0x00007f75003c6000, 0x00007f75003c8800, 0x00007f75003cb000, 0x00007f75003cd800, 0x00007f7500886000 } _java_thread_list_alloc_cnt=10, _java_thread_list_free_cnt=9, _java_thread_list_max=9, _nested_thread_list_max=0 _tlh_cnt=34, _tlh_times=0, avg_tlh_time=0.00, _tlh_time_max=0 _delete_lock_wait_cnt=0, _delete_lock_wait_max=0 _to_delete_list_cnt=0, _to_delete_list_max=1 Java Threads: ( => current thread ) 0x00007f7500032000 JavaThread "main" [_thread_blocked, id=165553, stack(0x00007f7505585000,0x00007f7505686000)] 0x00007f750039e000 JavaThread "Reference Handler" daemon [_thread_blocked, id=165573, stack(0x00007f74b6da8000,0x00007f74b6ea9000)] 0x00007f75003a0800 JavaThread "Finalizer" daemon [_thread_blocked, id=165574, stack(0x00007f74b6ca7000,0x00007f74b6da8000)] 0x00007f75003c3800 JavaThread "Signal Dispatcher" daemon [_thread_blocked, id=165577, stack(0x00007f74b6636000,0x00007f74b6737000)] 0x00007f75003c6000 JavaThread "Service Thread" daemon [_thread_blocked, id=165578, stack(0x00007f74b6535000,0x00007f74b6636000)] =>0x00007f75003c8800 JavaThread "C2 CompilerThread0" daemon [_thread_in_native, id=165579, stack(0x00007f74b6434000,0x00007f74b6535000)] 0x00007f75003cb000 JavaThread "C1 CompilerThread0" daemon [_thread_blocked, id=165580, stack(0x00007f74b6333000,0x00007f74b6434000)] 0x00007f75003cd800 JavaThread "Sweeper thread" daemon [_thread_blocked, id=165581, stack(0x00007f74b6232000,0x00007f74b6333000)] 0x00007f7500886000 JavaThread "Common-Cleaner" daemon [_thread_blocked, id=165612, stack(0x00007f74b59d1000,0x00007f74b5ad2000)] Other Threads: 0x00007f7500388000 VMThread "VM Thread" [stack: 0x00007f74b6eab000,0x00007f74b6fab000] [id=165572] 0x00007f75004c1800 WatcherThread [stack: 0x00007f74b6132000,0x00007f74b6232000] [id=165586] 0x00007f7500052000 GCTaskThread "GC Thread#0" [stack: 0x00007f750521e000,0x00007f750531e000] [id=165558] 0x00007f7500091000 ConcurrentGCThread "G1 Main Marker" [stack: 0x00007f74e8218000,0x00007f74e8318000] [id=165563] 0x00007f7500093000 ConcurrentGCThread "G1 Conc#0" [stack: 0x00007f74e8116000,0x00007f74e8216000] [id=165564] 0x00007f750026b800 ConcurrentGCThread "G1 Refine#0" [stack: 0x00007f74b79fb000,0x00007f74b7afb000] [id=165566] 0x00007f750026e000 ConcurrentGCThread "G1 Young RemSet Sampling" [stack: 0x00007f74b78f9000,0x00007f74b79f9000] [id=165567] Threads with active compile tasks: C2 CompilerThread0 614 27 !b 4 sun.security.ssl.SSLEngineInputRecord::decodeInputRecord (812 bytes) -------------- next part -------------- An HTML attachment was scrubbed... URL: From stuefe at openjdk.org Fri Aug 5 04:59:01 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 5 Aug 2022 04:59:01 GMT Subject: [jdk11u-dev] RFR: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 14:04:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. > > I had to adapt the String literal in PrintLatinCJKTest.java to Java 11 syntax. LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1309 From stuefe at openjdk.org Fri Aug 5 05:16:14 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 5 Aug 2022 05:16:14 GMT Subject: [jdk17u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 13:59:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. > > In 17, file CurrencyData.properties is at make/data/currency/ while in head it is at src/java.base/share/data/currency/ > Directing the patch to the right file makes it apply clean. LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/627 From duke at openjdk.org Fri Aug 5 06:35:04 2022 From: duke at openjdk.org (duke) Date: Fri, 5 Aug 2022 06:35:04 GMT Subject: [jdk11u-dev] Withdrawn: 8228609: G1 copy cost prediction uses used vs. actual copied bytes In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 07:45:31 GMT, Yude Lin wrote: > I would like to backport 8228609 which fixes a prediction error regarding cost per bytes copied. > > The patch does not apply cleanly, so this backport is basically changing the calculation of copied bytes. > > https://bugs.openjdk.java.net/browse/JDK-8227442 is not in 11u. So this patch also uses G1ParScanThreadState::surviving_young_words() in place of _surviving_young_words to adjust for the correct cset index. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/927 From dcherepanov at openjdk.org Fri Aug 5 08:13:53 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 5 Aug 2022 08:13:53 GMT Subject: [jdk15u-dev] RFR: 8276841: Add support for Visual Studio 2022 In-Reply-To: <7O6xW26qdAMqetqzepGgtoZf8HIIsU9ivIlpklPEqxc=.8c660dfb-a478-4fba-b581-cf2c7e4e12cf@github.com> References: <7O6xW26qdAMqetqzepGgtoZf8HIIsU9ivIlpklPEqxc=.8c660dfb-a478-4fba-b581-cf2c7e4e12cf@github.com> Message-ID: On Wed, 3 Aug 2022 21:54:14 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [f65db88b](https://github.com/openjdk/jdk/commit/f65db88b74911e5896d2ff536c4ac97e7f62d98b) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Yasumasa Suenaga on 9 Nov 2021 and was reviewed by Erik Joelsson and Magnus Ihse Bursie. > > The change is not "clean" because the jdk15u supports more versions than the jdk/jdk. > I have tested the build using VS 2019 and 2022, results of tier1/tier2 are the same. > > Thanks! Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/252 From goetz at openjdk.org Sat Aug 6 20:58:54 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Aug 2022 20:58:54 GMT Subject: [jdk11u-dev] Integrated: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: <2sKLDheXwSlVaqKFeEzZncnUNlvJt4m2NZi1rdQET3E=.eebb99dc-46bb-40ee-9900-e08eab94f78b@github.com> On Wed, 3 Aug 2022 20:43:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. > > I had to resolve adding the bugid to @bugs in LocaleDataTest.java. > This is most trivial, will mark as /clean. This pull request has now been integrated. Changeset: d6cbc3b8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d6cbc3b882e34e376b1ca2bfe69ae78bd4903430 Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod 8283277: ISO 4217 Amendment 171 Update Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1310 From goetz at openjdk.org Sat Aug 6 21:00:25 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Aug 2022 21:00:25 GMT Subject: [jdk17u-dev] Integrated: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 20:43:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: bb31cd9a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/bb31cd9af12cd4dbb7857b4779e600228677f74a Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod 8283277: ISO 4217 Amendment 171 Update Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/626 From goetz at openjdk.org Sat Aug 6 21:02:26 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Aug 2022 21:02:26 GMT Subject: [jdk11u-dev] Integrated: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception In-Reply-To: References: Message-ID: On Wed, 3 Aug 2022 14:04:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. > > I had to adapt the String literal in PrintLatinCJKTest.java to Java 11 syntax. This pull request has now been integrated. Changeset: 16536292 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/165362923880eaf4ce5b867dc93a1f34dae53dce Stats: 361 lines in 2 files changed: 311 ins; 31 del; 19 mod 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception 8283712: Create a manual test framework class Reviewed-by: phh, stuefe Backport-of: 3f26d84f6a03030080328e36a1fd1a08c982838c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1309 From goetz at openjdk.org Sat Aug 6 21:04:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Aug 2022 21:04:47 GMT Subject: [jdk11u-dev] RFR: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.17-oracle. > > Clean backport from 17. 17 includes a test infra file needed for the backport. > I had to adapt a string literal in PrintGlyphVectorTest to make it compile with 11. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into goetz_backport_8283803 - Add forgotten file - Backport 37c9cd1555484db9c47d97cb21aa3259519fb2fc ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1295/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1295&range=02 Stats: 205 lines in 2 files changed: 109 ins; 48 del; 48 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1295.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1295/head:pull/1295 PR: https://git.openjdk.org/jdk11u-dev/pull/1295 From goetz at openjdk.org Sat Aug 6 21:06:28 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Aug 2022 21:06:28 GMT Subject: [jdk17u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.5-oracle. > > In 17, file CurrencyData.properties is at make/data/currency/ while in head it is at src/java.base/share/data/currency/ > Directing the patch to the right file makes it apply clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/627/files - new: https://git.openjdk.org/jdk17u-dev/pull/627/files/2c3eb962..2c3eb962 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=627&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=627&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/627.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/627/head:pull/627 PR: https://git.openjdk.org/jdk17u-dev/pull/627 From goetz at openjdk.org Sun Aug 7 17:10:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 7 Aug 2022 17:10:56 GMT Subject: [jdk17u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.5-oracle. > > In 17, file CurrencyData.properties is at make/data/currency/ while in head it is at src/java.base/share/data/currency/ > Directing the patch to the right file makes it apply clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8289549 - Backport 604ea90d55ac8354fd7287490ef59b8e3ce020d1 - Backport c4dc58e12e197562dce90c0027aa74c29047cea6 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/627/files - new: https://git.openjdk.org/jdk17u-dev/pull/627/files/2c3eb962..ac41fb0d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=627&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=627&range=01-02 Stats: 35 lines in 3 files changed: 22 ins; 1 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/627.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/627/head:pull/627 PR: https://git.openjdk.org/jdk17u-dev/pull/627 From goetz at openjdk.org Sun Aug 7 17:20:59 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 7 Aug 2022 17:20:59 GMT Subject: [jdk11u-dev] Integrated: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test In-Reply-To: References: Message-ID: On Mon, 1 Aug 2022 09:21:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. > > Clean backport from 17. 17 includes a test infra file needed for the backport. > I had to adapt a string literal in PrintGlyphVectorTest to make it compile with 11. This pull request has now been integrated. Changeset: 74daa996 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/74daa996b5212deddc19c806b07f7f1f924ce1e6 Stats: 205 lines in 2 files changed: 109 ins; 48 del; 48 mod 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test 8284898: Enhance PassFailJFrame Reviewed-by: stuefe Backport-of: 37c9cd1555484db9c47d97cb21aa3259519fb2fc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1295 From goetz at openjdk.org Sun Aug 7 17:57:05 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 7 Aug 2022 17:57:05 GMT Subject: [jdk17u-dev] Integrated: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: References: Message-ID: <3oCyct4sRt67N2Byen-sL_3lzvRryoYeiQmcMiHdc4M=.98b1b449-f8aa-4068-8f68-e883e15acd84@github.com> On Thu, 4 Aug 2022 13:59:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. > > In 17, file CurrencyData.properties is at make/data/currency/ while in head it is at src/java.base/share/data/currency/ > Directing the patch to the right file makes it apply clean. This pull request has now been integrated. Changeset: 9168aa25 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9168aa252d32d48a3bda9a6e28e3215805fe60c5 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8289549: ISO 4217 Amendment 172 Update Reviewed-by: stuefe Backport-of: 604ea90d55ac8354fd7287490ef59b8e3ce020d1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/627 From goetz at openjdk.org Sun Aug 7 20:51:34 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 7 Aug 2022 20:51:34 GMT Subject: [jdk11u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update Message-ID: I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 9168aa252d32d48a3bda9a6e28e3215805fe60c5 Changes: https://git.openjdk.org/jdk11u-dev/pull/1318/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1318&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289549 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1318.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1318/head:pull/1318 PR: https://git.openjdk.org/jdk11u-dev/pull/1318 From anleonar at redhat.com Mon Aug 8 09:32:00 2022 From: anleonar at redhat.com (Andrew Leonard) Date: Mon, 8 Aug 2022 10:32:00 +0100 Subject: [jdk17u-dev] Sponsor request: 8288399: MacOS debug symbol files not always deterministic in reproducible builds Message-ID: Please can I get a "sponsor" for this approved jdk17u-dev backport ? https://github.com/openjdk/jdk17u-dev/pull/624 Thanks Andrew -------------- next part -------------- An HTML attachment was scrubbed... URL: From adinn at redhat.com Mon Aug 8 10:06:38 2022 From: adinn at redhat.com (Andrew Dinn) Date: Mon, 8 Aug 2022 11:06:38 +0100 Subject: [jdk17u-dev] Sponsor request: 8288399: MacOS debug symbol files not always deterministic in reproducible builds In-Reply-To: References: Message-ID: On 08/08/2022 10:32, Andrew Leonard wrote: > Please can I get a "sponsor" for this approved jdk17u-dev backport ? > https://github.com/openjdk/jdk17u-dev/pull/624 > Done. regards, Andrew Dinn ----------- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill From aleonard at openjdk.org Mon Aug 8 10:12:31 2022 From: aleonard at openjdk.org (Andrew Leonard) Date: Mon, 8 Aug 2022 10:12:31 GMT Subject: [jdk17u-dev] Integrated: 8288399: MacOS debug symbol files not always deterministic in reproducible builds In-Reply-To: <1l0HcGxFL00u_5KgqBQN8oRl-Cf5vzTEUvPf0gXMjxA=.2a36a26d-069b-413b-bf5b-617b2687baf3@github.com> References: <1l0HcGxFL00u_5KgqBQN8oRl-Cf5vzTEUvPf0gXMjxA=.2a36a26d-069b-413b-bf5b-617b2687baf3@github.com> Message-ID: <5_XK32DcDX_G610pRTDWNi0ojou-xjsKtxU5urESr08=.24db03ae-6271-4850-8794-3b28ed24471e@github.com> On Tue, 2 Aug 2022 15:09:02 GMT, Andrew Leonard wrote: > On MacOS builds enable -fdebug-prefix-map and -frandom-seed to enable fully reproducible builds, that are currently non-deterministic when debug symbols are created due to absolute debug symbol paths and non-deterministic random symbol name generation. This pull request has now been integrated. Changeset: f74269cd Author: Andrew Leonard Committer: Andrew Dinn URL: https://git.openjdk.org/jdk17u-dev/commit/f74269cdaa6abcec463be378415049e688d51750 Stats: 17 lines in 2 files changed: 13 ins; 0 del; 4 mod 8288399: MacOS debug symbol files not always deterministic in reproducible builds Backport-of: 6633855ca78ff0f5f1213a2a1424436678a30e55 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/624 From lgxbslgx at gmail.com Mon Aug 8 20:25:25 2022 From: lgxbslgx at gmail.com (Guoxiong Li) Date: Tue, 9 Aug 2022 04:25:25 +0800 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> Message-ID: Hi all, I re-read your comments about this enhancement recently. And I also made a mistake when I backport a patch to jdk11u-dev [1] although I have backported several times. So SKARA must direct the developers accurately and help developers complete the duplicated work to avoid the unnecessary mistakes. Now I propose the following dev flow. Please only focus on the dev flow instead of the code implementation here. *- When a backport PR is created in Github.* 1. A new checkbox item `[ ] Change must be properly approved by the maintainers` will be added to the `Progress` part of the current PR body. 2. A comment is posted by the bot like below (the italic content) to direct the developers: *This is a backport pull request. Please add a comment to the main issue [JDK-XXXX](link)* *to state the related condition (the backport reason, the risk of the patch, the amount of* *work and so on). Below is an example for you:* *```* *Fix Request(jdk17u-dev)* *The code applies cleanly and the test in this change fails without the patch and succeeds after applying it.* *The risk of this backport is low because the change is little and the issue fixed by this change also exists in jdk xy.* *```* *If you don't have permission to add a comment in JBS. Please use the command `request-approval` to provide* *the related content, then the bot can help you add a comment by using the content you provided. Below is an example for you:* *```* */request-approval* *Fix Request(jdk17u-dev)* *The code applies cleanly and the test in this change fails without the patch and succeeds after applying it.* *The risk of this backport is low because the change is little and the issue fixed by this change also exists in jdk xy.* *```* *Please note you have to contact the maintainers **directly **in the issue [JDK-XXXX](link)* *or by using the command **`request-approval` **repeatedly** instead of in this pull request.* *And you don't need to add the fix request label manually to the issue like before,* *now the bot can help you add the label automatically when this pull request is ready **for maintainers to approve.* *- When the backport PR is ready for approval *(other checks have succeeded and other progresses have been done) 1. The bot adds a label named `jdkXXu-fix-request` to *all the issues* of the PR 2. The bot adds a blocked label named `approval` in PR, like `csr` or other blocked labels These two labels are convenient for maintainers to filter the issues and PRs which need to be handled now. *- It is time for maintainers to approve* The maintainers can add the label `jdkXXu-fix-yes` or `jdkXXu-fix-no` in the issue or use the command `/approval yes|no|y|n` in the PR to approve or object the patch. This newly added command `approval` can be very convenient if one backport PR has many corresponding issues. After using this command, the bot will add the related label to *all the issues* just like the label `jdkXXu-fix-request` it had added. *- Then the commit or sponsor flow will continue as usual.* After approval, if the maintainer said 'yes', the PR will become ready to be integrated. If the maintainer said 'no', the PR can be closed by the bot with a comment like "The maintainers disapproved of this patch so this pull request will be closed automatically". No matter 'yes' or 'no', the label `approval` in the PR will be removed. Above is all the dev flow. And next, I will give more information about the new commands `*request-approval` and `approval`.* *- "request-approval" command* It is similar to the `summary` command which permits multiline content. And this command can be used multi times if the author of the PR wants to. Each time this command is used, the bot will post the content to a new comment in the issue. Because the author who has no permission may want to contact/talk with the maintainers. The related record will be recorded in the issue instead of PR which is your intention in your previous comments. *- "approval" command* The command `/approval yes` or `/approval y` mean `approved`. And the command `/approval no` or `/approval n` mean `dispproved`. This command can be used multiple times and only the last time is valid. Please note when the `/approval no` or `/approval n` is used, the bot will close the PR, and when the `/approval yes` or `/approval y` later is used, the bot will open the PR automatically. That is all. Thanks for reading and providing feedback. And I will try to implement these features if I have time and hear no objection after discussion. [1] https://github.com/openjdk/jdk11u-dev/pull/1218#issuecomment-1184235601 Best Regards, -- Guoxiong -------------- next part -------------- An HTML attachment was scrubbed... URL: From cushon at openjdk.org Tue Aug 9 02:23:06 2022 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 9 Aug 2022 02:23:06 GMT Subject: [jdk11u-dev] RFR: 8247546: Pattern matching does not skip correctly over supplementary characters Message-ID: This is a backport of [JDK-8247546: Pattern matching does not skip correctly over supplementary characters](https://bugs.openjdk.org/browse/JDK-8247546) Original patch applied cleanly except for a merge conflict on the `@bug` comment in the test. All tier1 tests passed. ------------- Commit messages: - Backport 4946a162aa6119416cfdb94b8e3d09200f28d837 Changes: https://git.openjdk.org/jdk11u-dev/pull/1319/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1319&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8247546 Stats: 36 lines in 3 files changed: 28 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1319.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1319/head:pull/1319 PR: https://git.openjdk.org/jdk11u-dev/pull/1319 From sgehwolf at redhat.com Tue Aug 9 08:43:28 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Tue, 09 Aug 2022 10:43:28 +0200 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> Message-ID: <158074e04fcf69679b242b4e6e1f79e377447662.camel@redhat.com> Hi, On Tue, 2022-08-09 at 04:25 +0800, Guoxiong Li wrote: > Hi all, > > I re-read your comments about this enhancement recently. > And I also made a mistake when I backport a patch to > jdk11u-dev [1] although I have backported several times. > So SKARA must direct the developers accurately and help? > developers complete the duplicated work to avoid the unnecessary > mistakes. > > Now I propose the following dev flow. Please only focus on the dev > flow instead of the code implementation here. > > - When a backport PR is created in Github. > 1. A new checkbox item `[ ] Change must be properly approved by the > maintainers`? > will be added to the `Progress` part of the current PR body. > 2. A comment is posted by the bot like below (the italic content) to > direct the developers: > This is a backport pull request. Please add a comment to the main > issue [JDK-XXXX](link) > to state the?related condition (the backport reason, the risk of the > patch, the amount of > work and so on). Below is an example for you: > ``` > Fix Request(jdk17u-dev) > The code applies cleanly and the test in this change fails without > the patch and succeeds after applying it. > The risk of this backport is low because the change is little and the > issue fixed by this change also exists in jdk xy. > ``` > If you don't have permission to add a comment in JBS. Please use the > command `request-approval` to provide > the related content, then?the bot can help you add a comment by using > the content you provided.?Below is an example for you: > ``` > /request-approval > Fix Request(jdk17u-dev) > The code applies cleanly and the test in this change fails without > the patch and succeeds after applying it. > The risk of this backport is low because the change is little and the > issue fixed by this change also exists in jdk xy. > ``` > Please note you have to contact the maintainers?directly?in the > issue?[JDK-XXXX](link)? > or by using the command?`request-approval`?repeatedly?instead of in > this pull request. > And you don't need to add the fix request label manually to the issue > like before, > now the bot can help you add the label automatically when this pull > request is ready?for maintainers to approve. > > - When the backport PR is ready for approval (other checks have > succeeded and other progresses have been done) > 1. The bot adds a label named `jdkXXu-fix-request` to all the issues > of the PR > 2. The bot adds a blocked label named `approval` in PR, like `csr` or > other blocked labels > These two labels are convenient for maintainers to filter the issues > and PRs which need to be handled now. > > - It is time for maintainers to approve > The maintainers can add the label `jdkXXu-fix-yes` or `jdkXXu-fix-no` > in the issue or use the command? > `/approval yes|no|y|n` in the PR to approve or object the patch. This > newly added command `approval`? > can be very convenient if one backport PR has many corresponding > issues. After using this command, > the bot will add the related label to all the issues just like the > label `jdkXXu-fix-request`?it had added. > > - Then the commit or sponsor flow will continue as usual. > After approval, if the maintainer said 'yes', the PR will become > ready to be integrated. > If the maintainer said 'no', the PR can be closed?by the bot with a > comment like > "The maintainers disapproved of this patch so this pull request will > be closed automatically". > No matter 'yes' or 'no', the label `approval` in the PR will be > removed. > > Above is all the dev flow. And next, I will give more information > about the new commands `request-approval` and `approval`. > > - "request-approval" command > It is similar to the `summary` command which permits multiline > content. And this command can be used? > multi times if the author of the PR wants to. Each time this command > is used, the bot will post the content? > to a new comment in the issue. Because the author who has no > permission may want to contact/talk with the maintainers. > The related record will be recorded in the issue instead of PR which > is your intention in your previous comments. > > - "approval" command > The command `/approval yes` or `/approval y` mean `approved`. > And the command `/approval no` or `/approval n` mean `dispproved`. > This command can be used multiple times and only the last time is > valid. > Please note when the `/approval no` or `/approval n` is used, the bot > will close the PR, > and when the `/approval yes` or `/approval y` later is used, the bot > will open the PR automatically. > > > That is all. Thanks for reading and providing feedback.? > And I will try to implement these features if I have time and hear no > objection?after discussion. > This sounds good to me. +1. Perhaps we should move this discussion and implementation proposal to the bug tracking this issue as it is hard to find those mailing list posts later on? https://bugs.openjdk.org/browse/SKARA-1199 It also seems to be in-line with what Andrew Hughes suggested in [i]. Thanks, Severin [i] https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-March/013278.html > [1]? > https://github.com/openjdk/jdk11u-dev/pull/1218#issuecomment-11842356 > 01 > > Best Regards, > -- Guoxiong From joe.darcy at oracle.com Tue Aug 9 17:20:32 2022 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 9 Aug 2022 10:20:32 -0700 Subject: Request for comment on adding "Under Review" as a substate of bugs In-Reply-To: <558af4a0-c758-9150-32bc-a9287a928f54@oracle.com> References: <98d35bbf-9431-902a-3a63-d926e74cdfcf@oracle.com> <558af4a0-c758-9150-32bc-a9287a928f54@oracle.com> Message-ID: The "In Review" substate is now available in JBS. The Understanding field is now also displayed under the Edit window. Cheers, -Joe On 7/15/2022 10:04 AM, Joe Darcy wrote: > After hearing no objections, and hearing several assents off-list, > I'll work with the JBS team to move forward with this change. > > Thanks, > > -Joe > > On 7/6/2022 9:45 PM, Joseph D. Darcy wrote: >> Hello, >> >> To allow better tracking of the state of in-progress bugs in JBS, I >> propose to add an "Under Review" substate to go alongside "Cause >> Known" and "Fix Understood" for the "understanding" field. The Skara >> bots could set that state as an aspect of PR management >> (https://bugs.openjdk.org/browse/SKARA-803). If it goes forward, some >> adjustments may be made to the JBS configuration to better support >> this capability. >> >> If you have comments or concerns, please respond on this thread or >> leave a comment on the SKARA-803 issue. >> >> Cheers, >> >> -Joe >> From mbaesken at openjdk.org Wed Aug 10 11:11:19 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 10 Aug 2022 11:11:19 GMT Subject: [jdk17u-dev] RFR: 8285730: unify _WIN32_WINNT settings Message-ID: <_qoTH7R4tqEY1WreH9Sa1Pk6JcnhgkFnwKS5gBKB9uQ=.5401cf5a-66aa-4fc1-a3eb-a36bdb2781ea@github.com> 8285730: unify _WIN32_WINNT settings ------------- Commit messages: - Backport 4fd79a6ad2683e4863bd4e311cb01cbc30ebf57f Changes: https://git.openjdk.org/jdk17u-dev/pull/628/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=628&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285730 Stats: 33 lines in 7 files changed: 2 ins; 25 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/628.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/628/head:pull/628 PR: https://git.openjdk.org/jdk17u-dev/pull/628 From mbaesken at openjdk.org Wed Aug 10 11:43:03 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 10 Aug 2022 11:43:03 GMT Subject: [jdk17u-dev] RFR: 8289910: unify os::message_box across posix platforms Message-ID: 8289910: unify os::message_box across posix platforms ------------- Commit messages: - Backport e5491a2605177a9dca87a060d99aa5ea4fd4a239 Changes: https://git.openjdk.org/jdk17u-dev/pull/629/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=629&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289910 Stats: 77 lines in 4 files changed: 20 ins; 57 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/629.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/629/head:pull/629 PR: https://git.openjdk.org/jdk17u-dev/pull/629 From duke at openjdk.org Wed Aug 10 13:28:26 2022 From: duke at openjdk.org (psoujany) Date: Wed, 10 Aug 2022 13:28:26 GMT Subject: [jdk11u-dev] RFR: 8210047: some pages contain content outside of landmark region Message-ID: <-XJ-XnNQsNRs0ggI1XJHnhlUGhXRV4WNvjXhZrvI6yM=.e97bd723-351a-4e91-832c-f3df34966c34@github.com> Backport of 8210047: some pages contain content outside of landmark region OpenJDK Bug : https://bugs.openjdk.org/browse/JDK-8210047 ------------- Commit messages: - Fixed testcase failure - Backport a17816f881fadca8dc3bfd49458445873ae762cd Changes: https://git.openjdk.org/jdk11u-dev/pull/1320/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1320&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8210047 Stats: 501 lines in 12 files changed: 277 ins; 90 del; 134 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1320.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1320/head:pull/1320 PR: https://git.openjdk.org/jdk11u-dev/pull/1320 From lgxbslgx at gmail.com Wed Aug 10 18:31:05 2022 From: lgxbslgx at gmail.com (Guoxiong Li) Date: Thu, 11 Aug 2022 02:31:05 +0800 Subject: Request for comment on adding "Under Review" as a substate of bugs In-Reply-To: References: <98d35bbf-9431-902a-3a63-d926e74cdfcf@oracle.com> <558af4a0-c758-9150-32bc-a9287a928f54@oracle.com> Message-ID: Hi Joe, Thanks for the work. It is very convenient to edit the `understanding` field directly. But I find it is unable to click the `Start Work` button if someone is not the assignee of the issue. So when solving SKARA-803 [1], I find we need to assign the issue to the bot, then "click" the `Start Work` button to transfer the status to `In Progress`, and at last assign the issue back to the actual developer. This situation is similar to the previous `understanding` field. The three steps (self-assign, Start work, assign back) solution is a workaround but it seems to be not very elegant. So I want to ask: can this be improved? Or can the bot accounts or other administrators' accounts click the `Start Work` button directly without as an assignee? [1] https://bugs.openjdk.org/browse/SKARA-803 Best Regards, -- Guoxiong -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Wed Aug 10 19:35:01 2022 From: duke at openjdk.org (Martijn Verburg) Date: Wed, 10 Aug 2022 19:35:01 GMT Subject: [jdk17u-dev] RFR: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider Message-ID: Backport of 5e5500cbd79b40a32c20547ea0cdb81ef6904a3d On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges. "Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc keystore functionality and API remains unchanged, the local machine keystore types require the manual tests to run in admin mode Tested on windows, passes tier1 (via GH Actions) and manual tests provided in the patch ------------- Commit messages: - Backport 5e5500cbd79b40a32c20547ea0cdb81ef6904a3d Changes: https://git.openjdk.org/jdk17u-dev/pull/630/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=630&range=00 Issue: https://bugs.openjdk.org/browse/JDK-6782021 Stats: 187 lines in 5 files changed: 155 ins; 1 del; 31 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/630.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/630/head:pull/630 PR: https://git.openjdk.org/jdk17u-dev/pull/630 From alvdavi at amazon.com Thu Aug 11 04:01:44 2022 From: alvdavi at amazon.com (Alvarez, David) Date: Wed, 10 Aug 2022 21:01:44 -0700 Subject: [jdk11u-dev] Impact of JDK-8279219 and potential patch update 11.0.16.1 Message-ID: <47ce474d-d3a4-747f-dba1-3ffb9c723898@amazon.com> Hi, We have been seeing the same crashes mentioned in a previous email [1] to this list. For one of our customers this crash is affecting approximately 1% of all java invocations. We have been able to confirm that crashes do go away after backing out JDK-8279219 [4][5]. We are advocating for a patch release (11.0.16.1) to address this issue. We don't believe it is appropriate to roll back given there was a high severity CVE addressed in 11.0.16. Regarding 17 and 18, we are working on a reproducer. We believe this issue affects them as well. This is the error reported initially as JDK-8291665 [2] (and also as JDK-8291919 [3] which was closed as duplicate). David ---- [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-August/016434.html [2] https://bugs.openjdk.org/browse/JDK-8291665 [3] https://bugs.openjdk.org/browse/JDK-8291919 [4] https://bugs.openjdk.org/browse/JDK-8279219 [5] https://github.com/openjdk/jdk11u-dev/commit/9ce8530c5d5f179fa42e1060447aead887570124 From duke at openjdk.org Thu Aug 11 04:54:33 2022 From: duke at openjdk.org (psoujany) Date: Thu, 11 Aug 2022 04:54:33 GMT Subject: [jdk11u-dev] RFR: 8210047: some pages contain content outside of landmark region In-Reply-To: <-XJ-XnNQsNRs0ggI1XJHnhlUGhXRV4WNvjXhZrvI6yM=.e97bd723-351a-4e91-832c-f3df34966c34@github.com> References: <-XJ-XnNQsNRs0ggI1XJHnhlUGhXRV4WNvjXhZrvI6yM=.e97bd723-351a-4e91-832c-f3df34966c34@github.com> Message-ID: On Wed, 10 Aug 2022 13:19:28 GMT, psoujany wrote: > Backport of 8210047: some pages contain content outside of landmark region > > OpenJDK Bug : https://bugs.openjdk.org/browse/JDK-8210047 @RealCLanger Could you please review this backport. Thank you. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1320 From duke at openjdk.org Thu Aug 11 05:06:21 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 11 Aug 2022 05:06:21 GMT Subject: [jdk11u-dev] RFR: 8251152: ARM32: jtreg c2 Test8202414 test crash Message-ID: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> Backport of 8251152: ARM32: jtreg c2 Test8202414 test crash Backport is not clean because JDK 11 does not include [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). The patch removed the `@requires` line, but the line is present in JDK 11. * @test * @bug 8202414 * @summary Unsafe write after primitive array creation may result in array length change * @requires (os.arch != "sparc") & (os.arch != "sparcv9") * @run main/othervm compiler.c2.Test8202414 Manual fix is trivial. We just paste the new lines under the `@requires` line ------------- Commit messages: - 8251152: ARM32: jtreg c2 Test8202414 test crash Changes: https://git.openjdk.org/jdk11u-dev/pull/1321/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1321&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8251152 Stats: 15 lines in 2 files changed: 11 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1321.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1321/head:pull/1321 PR: https://git.openjdk.org/jdk11u-dev/pull/1321 From duke at openjdk.org Thu Aug 11 05:24:10 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 11 Aug 2022 05:24:10 GMT Subject: [jdk17u-dev] RFR: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Message-ID: clean backport ------------- Commit messages: - 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Changes: https://git.openjdk.org/jdk17u-dev/pull/631/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=631&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279032 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/631.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/631/head:pull/631 PR: https://git.openjdk.org/jdk17u-dev/pull/631 From duke at openjdk.org Thu Aug 11 06:15:44 2022 From: duke at openjdk.org (psoujany) Date: Thu, 11 Aug 2022 06:15:44 GMT Subject: [jdk11u-dev] RFR: 8209052: Low contrast in docs/api/constant-values.html In-Reply-To: References: Message-ID: On Thu, 4 Aug 2022 10:43:08 GMT, psoujany wrote: > 8209052: Low contrast in docs/api/constant-values.html @GoeLin Could you please sponser this backport. Thank you. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1316 From aph-open at littlepinkcloud.com Thu Aug 11 12:12:18 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Thu, 11 Aug 2022 13:12:18 +0100 Subject: [jdk11u-dev] Impact of JDK-8279219 and potential patch update 11.0.16.1 In-Reply-To: <47ce474d-d3a4-747f-dba1-3ffb9c723898@amazon.com> References: <47ce474d-d3a4-747f-dba1-3ffb9c723898@amazon.com> Message-ID: <7adcea99-726e-1e35-7e25-e50846e2574f@littlepinkcloud.com> On 8/11/22 05:01, Alvarez, David wrote: > We have been seeing the same crashes mentioned in a previous email [1] > to this list. For one of our customers this crash is affecting > approximately 1% of all java invocations. > > We have been able to confirm that crashes do go away after backing out > JDK-8279219 [4][5]. > > We are advocating for a patch release (11.0.16.1) to address this issue. > We don't believe it is appropriate to roll back given there was a high > severity CVE addressed in 11.0.16. > > Regarding 17 and 18, we are working on a reproducer. We believe this > issue affects them as well. But not JDK head, to which the fix was applied? > This is the error reported initially as JDK-8291665 [2] (and also as > JDK-8291919 [3] which was closed as duplicate). OK, but (presumably) we'd still have to deal with the bug which was fixed by JDK-8279219. In that case we'd need to do another fix, to back-port JDK-8279219 properly. Or is it the case that the 8279219 is not important? Roland Westrelin will be back in a few days' time, and he will be able to analyse the problem. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From duke at openjdk.org Thu Aug 11 15:06:22 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 11 Aug 2022 15:06:22 GMT Subject: [jdk11u-dev] RFR: 8214078: SecureDirectoryStream not supported on arm32 Message-ID: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> Clean backport. Passes test on our arm32 machine. ------------- Commit messages: - 8214078: SecureDirectoryStream not supported on arm32 Changes: https://git.openjdk.org/jdk11u-dev/pull/1322/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1322&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8214078 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1322.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1322/head:pull/1322 PR: https://git.openjdk.org/jdk11u-dev/pull/1322 From ckozak at ckozak.net Thu Aug 11 15:57:15 2022 From: ckozak at ckozak.net (Carter Kozak) Date: Thu, 11 Aug 2022 11:57:15 -0400 Subject: [jdk11u-dev] Impact of JDK-8279219 and potential patch update 11.0.16.1 In-Reply-To: <7adcea99-726e-1e35-7e25-e50846e2574f@littlepinkcloud.com> References: <47ce474d-d3a4-747f-dba1-3ffb9c723898@amazon.com> <7adcea99-726e-1e35-7e25-e50846e2574f@littlepinkcloud.com> Message-ID: <3aa13546-6320-4259-8b6b-cecd5ef04472@www.fastmail.com> I would advocate strongly in favor of a 11.0.16.1 patch release prior to the planned 11.0.17 update in October based on my observations in deployed Java-based applications.I don?t think David is suggesting that we should simply revert the linked commit and I certainly wouldn?t presume to suggest that?s the correct solution for a hotfix release, only that this issue is causing massive impact across Java applications which use TLS and once a fix is known and validated, it would be valuable to release prior to 11.0.17. As a temporary workaround, we are disabling compilation of SSLEngineInputRecord.decodeInputRecord via -XX:CompileCommand=exclude,sun/security/ssl/SSLEngineInputRecord.decodeInputRecord as this code structure is the trigger from our observed crashes; however, there may be similar code structures that could trigger this failure mode and lead to JVM crashes. We are also exploring the impacts of disabling split if blocks via -XX:-SplitIfBlocks. Best, Carter Kozak From gil at azul.com Thu Aug 11 16:42:57 2022 From: gil at azul.com (Gil Tene) Date: Thu, 11 Aug 2022 16:42:57 +0000 Subject: [jdk11u-dev] Impact of JDK-8279219 and potential patch update 11.0.16.1 In-Reply-To: <7adcea99-726e-1e35-7e25-e50846e2574f@littlepinkcloud.com> References: <47ce474d-d3a4-747f-dba1-3ffb9c723898@amazon.com> <7adcea99-726e-1e35-7e25-e50846e2574f@littlepinkcloud.com> Message-ID: <11558CFD-CB81-441C-9AD2-D256423F6048@azul.com> > On Aug 11, 2022, at 5:12 AM, Andrew Haley wrote: > > On 8/11/22 05:01, Alvarez, David wrote: >> We have been seeing the same crashes mentioned in a previous email [1] >> to this list. For one of our customers this crash is affecting >> approximately 1% of all java invocations. >> We have been able to confirm that crashes do go away after backing out >> JDK-8279219 [4][5]. >> We are advocating for a patch release (11.0.16.1) to address this issue. >> We don't believe it is appropriate to roll back given there was a high >> severity CVE addressed in 11.0.16. I'd like to voice support for David's position above. We too have had multiple crash reports from the field related to this issue, rising to the point where people are stuck between the demonstrated destabilization resulting from wide 11.0.16 rollout and accepting continued exposure to a high severity CVE. That is not a good place to be. Some are choosing to systemically roll back or otherwise delay the rollout of 11.0.16. We believe that this should raise the priority of JDK-8291665 to a P1, that an 11.0.16.1 is warranted in this case, and the need for a stable 11.0.16(.1) is fairly urgent. >> Regarding 17 and 18, we are working on a reproducer. We believe this >> issue affects them as well. Agreed. While we have not gotten specific reports of crashes in 17.0.4, we believe a 17.0.4.1 may be warranted as well, for the same reasons. Whether or not to push out an 18.0.2.1 may be a more debate-able thing. 11 and 17 are positioned and used as LTS releases. 18 is not, and 18.0.2 was meant to be the last update for 18. Whether or not that last update is fixed for stability with an 18.0.2.1 update is much less critical (IMO) than having the LTS updates containing the latest security updates be stable. > > But not JDK head, to which the fix was applied? The urgency for fixing this in the JDK head is much lower than in the LTS updates IMO. It may be a good idea to revert the fix for JDK-8279219 in the head as well, until a reworked fix that does not destabilize in 11 is done. > >> This is the error reported initially as JDK-8291665 [2] (and also as >> JDK-8291919 [3] which was closed as duplicate). > > OK, but (presumably) we'd still have to deal with the bug which was fixed > by JDK-8279219. In that case we'd need to do another fix, to back-port > JDK-8279219 properly. Or is it the case that the 8279219 is not important? This would be most easily depicted by re-prioritizing JDK-8291665 to a P1? > > Roland Westrelin will be back in a few days' time, and he will be able > to analyse the problem. > Given the urgency of getting a stable 11.0.16.1 out, I don't think we should wait a few days with analysis. ------ [2] https://bugs.openjdk.org/browse/JDK-8291665 [4] https://bugs.openjdk.org/browse/JDK-8279219 -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: Message signed with OpenPGP URL: From aph-open at littlepinkcloud.com Thu Aug 11 17:08:36 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Thu, 11 Aug 2022 18:08:36 +0100 Subject: [jdk11u-dev] Impact of JDK-8279219 and potential patch update 11.0.16.1 In-Reply-To: <11558CFD-CB81-441C-9AD2-D256423F6048@azul.com> References: <47ce474d-d3a4-747f-dba1-3ffb9c723898@amazon.com> <7adcea99-726e-1e35-7e25-e50846e2574f@littlepinkcloud.com> <11558CFD-CB81-441C-9AD2-D256423F6048@azul.com> Message-ID: <9f5ac273-27ca-e7b9-1a5b-69c6573c4bdf@littlepinkcloud.com> On 8/11/22 17:42, Gil Tene wrote: > Given the urgency of getting a stable 11.0.16.1 out, I don't think we should > wait a few days with analysis. Understood. OK, let's respin ASAP. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From sgehwolf at redhat.com Thu Aug 11 18:58:13 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 11 Aug 2022 20:58:13 +0200 Subject: [jdk11u-dev] Impact of JDK-8279219 and potential patch update 11.0.16.1 In-Reply-To: <9f5ac273-27ca-e7b9-1a5b-69c6573c4bdf@littlepinkcloud.com> References: <47ce474d-d3a4-747f-dba1-3ffb9c723898@amazon.com> <7adcea99-726e-1e35-7e25-e50846e2574f@littlepinkcloud.com> <11558CFD-CB81-441C-9AD2-D256423F6048@azul.com> <9f5ac273-27ca-e7b9-1a5b-69c6573c4bdf@littlepinkcloud.com> Message-ID: On Thu, 2022-08-11 at 18:08 +0100, Andrew Haley wrote: > On 8/11/22 17:42, Gil Tene wrote: > > Given the urgency of getting a stable 11.0.16.1 out, I don't think we should > > wait a few days with analysis. > > Understood. OK, let's respin ASAP. As for the version number changes, well be using 11.0.16.1 and 17.0.4.1 as well as DEFAULT_VERSION_DATE=2022-08-12. See: https://bugs.openjdk.org/browse/JDK-8292255 https://bugs.openjdk.org/browse/JDK-8292258 Thanks, Severin From sgehwolf at redhat.com Thu Aug 11 19:04:46 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 11 Aug 2022 21:04:46 +0200 Subject: [jdk11u-dev] Impact of JDK-8279219 and potential patch update 11.0.16.1 In-Reply-To: References: <47ce474d-d3a4-747f-dba1-3ffb9c723898@amazon.com> <7adcea99-726e-1e35-7e25-e50846e2574f@littlepinkcloud.com> <11558CFD-CB81-441C-9AD2-D256423F6048@azul.com> <9f5ac273-27ca-e7b9-1a5b-69c6573c4bdf@littlepinkcloud.com> Message-ID: <610ffbdf0dfb1080f2c10559a40dc3eabf695d20.camel@redhat.com> On Thu, 2022-08-11 at 20:58 +0200, Severin Gehwolf wrote: > On Thu, 2022-08-11 at 18:08 +0100, Andrew Haley wrote: > > On 8/11/22 17:42, Gil Tene wrote: > > > Given the urgency of getting a stable 11.0.16.1 out, I don't > > > think we should > > > wait a few days with analysis. > > > > Understood. OK, let's respin ASAP. > > As for the version number changes, well be using 11.0.16.1 and > 17.0.4.1 as well as > DEFAULT_VERSION_DATE=2022-08-12. > > See: > https://bugs.openjdk.org/browse/JDK-8292255 > https://bugs.openjdk.org/browse/JDK-8292258 Backout bug is: https://bugs.openjdk.org/browse/JDK-8292260 Thanks, Severin From phh at openjdk.org Thu Aug 11 19:43:56 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 11 Aug 2022 19:43:56 GMT Subject: [jdk11u-dev] RFR: 8214078: SecureDirectoryStream not supported on arm32 In-Reply-To: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> References: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> Message-ID: On Thu, 11 Aug 2022 14:59:40 GMT, Joshua Cao wrote: > Clean backport. Passes test on our arm32 machine. Please fix the PR/JBS issue title mismatch. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1322 From phh at openjdk.org Thu Aug 11 19:48:32 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 11 Aug 2022 19:48:32 GMT Subject: [jdk17u-dev] RFR: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 In-Reply-To: References: Message-ID: <6Ho5x2AvRiXeY_mwfuc-I0bwZ_hXjt7qK6RAj3j9zSw=.2b6cb2be-951f-4e9f-b5bf-b8b79c57495c@github.com> On Thu, 11 Aug 2022 05:03:08 GMT, Joshua Cao wrote: > clean backport Lgtm. Single test configuration change, so pre-submit testing unnecessary. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/631 From duke at openjdk.org Thu Aug 11 20:18:40 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 11 Aug 2022 20:18:40 GMT Subject: [jdk11u-dev] RFR: 8214078: (fs) SecureDirectoryStream not supported on arm32 In-Reply-To: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> References: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> Message-ID: On Thu, 11 Aug 2022 14:59:40 GMT, Joshua Cao wrote: > Clean backport. Passes test on our arm32 machine. done ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1322 From phh at openjdk.org Thu Aug 11 20:31:03 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 11 Aug 2022 20:31:03 GMT Subject: [jdk11u-dev] RFR: 8214078: (fs) SecureDirectoryStream not supported on arm32 In-Reply-To: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> References: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> Message-ID: On Thu, 11 Aug 2022 14:59:40 GMT, Joshua Cao wrote: > Clean backport. Passes test on our arm32 machine. Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1322 From phh at openjdk.org Thu Aug 11 20:26:10 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 11 Aug 2022 20:26:10 GMT Subject: [jdk11u-dev] RFR: 8214078: (fs) SecureDirectoryStream not supported on arm32 In-Reply-To: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> References: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> Message-ID: On Thu, 11 Aug 2022 14:59:40 GMT, Joshua Cao wrote: > Clean backport. Passes test on our arm32 machine. Makes arm32 same as x86-32. Pre-submit failure on Windows looks unrelated since the code change is Linux-only. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1322 From phh at openjdk.org Thu Aug 11 21:44:21 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 11 Aug 2022 21:44:21 GMT Subject: [jdk11u-dev] RFR: 8251152: ARM32: jtreg c2 Test8202414 test crash In-Reply-To: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> References: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> Message-ID: On Thu, 11 Aug 2022 04:39:05 GMT, Joshua Cao wrote: > Backport of 8251152: ARM32: jtreg c2 Test8202414 test crash > > Backport is not clean because JDK 11 does not include [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > The patch removed the `@requires` line, but the line is present in JDK 11. > > > * @test > * @bug 8202414 > * @summary Unsafe write after primitive array creation may result in array length change > * @requires (os.arch != "sparc") & (os.arch != "sparcv9") > * @run main/othervm compiler.c2.Test8202414 > > > Manual fix is trivial. We just paste the new lines under the `@requires` line Lgtm. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1321 From duke at openjdk.org Thu Aug 11 22:39:23 2022 From: duke at openjdk.org (Salander) Date: Thu, 11 Aug 2022 22:39:23 GMT Subject: [jdk11u-dev] RFR: 8229258: Backport patch from JDK 14 to allow building with Clang 13 Message-ID: This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. See the following for more information: https://bugs.openjdk.java.net/browse/JDK-8229258 https://bugs.gentoo.org/817995 https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html https://reviews.llvm.org/D99790#2678384 This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. ------------- Commit messages: - 8229258: Backport patch from JDK 14 to allow building with Clang 13 Changes: https://git.openjdk.org/jdk11u-dev/pull/1284/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8229258 Stats: 788 lines in 103 files changed: 51 ins; 6 del; 731 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From sgehwolf at openjdk.org Fri Aug 12 07:05:08 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 07:05:08 GMT Subject: [jdk11u] RFR: 8292255: Bump update version for OpenJDK: jdk-11.0.16.1 Message-ID: <-jXvWY1VA-krHT56FRZG0nUxLF2RlcvaUJFSjIFzkTY=.329a5be2-0439-457a-91e6-ee50907b515a@github.com> Version bump for the patch update. ------------- Commit messages: - 8292255: Bump update version for OpenJDK: jdk-11.0.16.1 Changes: https://git.openjdk.org/jdk11u/pull/48/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=48&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292255 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u/pull/48.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/48/head:pull/48 PR: https://git.openjdk.org/jdk11u/pull/48 From stuefe at openjdk.org Fri Aug 12 07:20:16 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 12 Aug 2022 07:20:16 GMT Subject: [jdk11u] RFR: 8292255: Bump update version for OpenJDK: jdk-11.0.16.1 In-Reply-To: <-jXvWY1VA-krHT56FRZG0nUxLF2RlcvaUJFSjIFzkTY=.329a5be2-0439-457a-91e6-ee50907b515a@github.com> References: <-jXvWY1VA-krHT56FRZG0nUxLF2RlcvaUJFSjIFzkTY=.329a5be2-0439-457a-91e6-ee50907b515a@github.com> Message-ID: On Fri, 12 Aug 2022 06:59:09 GMT, Severin Gehwolf wrote: > Version bump for the patch update. Looks good. ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk11u/pull/48 From sgehwolf at openjdk.org Fri Aug 12 07:31:23 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 07:31:23 GMT Subject: [jdk17u] RFR: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1 Message-ID: <2zn3BTHXhluCWPFpQ9H6N2mW9XjvWGoGu9J9sGDXp-o=.869c1d92-bbf1-4320-a06c-9705e5761bce@github.com> Version bump for the patch release. ------------- Commit messages: - 8292258: Bump update version for OpenJDK: jdk-17.0.4.1 Changes: https://git.openjdk.org/jdk17u/pull/349/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=349&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292258 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u/pull/349.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/349/head:pull/349 PR: https://git.openjdk.org/jdk17u/pull/349 From stuefe at openjdk.org Fri Aug 12 08:09:42 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 12 Aug 2022 08:09:42 GMT Subject: [jdk17u] RFR: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1 In-Reply-To: <2zn3BTHXhluCWPFpQ9H6N2mW9XjvWGoGu9J9sGDXp-o=.869c1d92-bbf1-4320-a06c-9705e5761bce@github.com> References: <2zn3BTHXhluCWPFpQ9H6N2mW9XjvWGoGu9J9sGDXp-o=.869c1d92-bbf1-4320-a06c-9705e5761bce@github.com> Message-ID: On Fri, 12 Aug 2022 07:23:29 GMT, Severin Gehwolf wrote: > Version bump for the patch release. LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk17u/pull/349 From sgehwolf at openjdk.org Fri Aug 12 08:29:38 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 08:29:38 GMT Subject: [jdk17u] RFR: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1 In-Reply-To: <2zn3BTHXhluCWPFpQ9H6N2mW9XjvWGoGu9J9sGDXp-o=.869c1d92-bbf1-4320-a06c-9705e5761bce@github.com> References: <2zn3BTHXhluCWPFpQ9H6N2mW9XjvWGoGu9J9sGDXp-o=.869c1d92-bbf1-4320-a06c-9705e5761bce@github.com> Message-ID: On Fri, 12 Aug 2022 07:23:29 GMT, Severin Gehwolf wrote: > Version bump for the patch release. Thanks for the review! ------------- PR: https://git.openjdk.org/jdk17u/pull/349 From sgehwolf at openjdk.org Fri Aug 12 08:31:33 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 08:31:33 GMT Subject: [jdk11u] RFR: 8292255: Bump update version for OpenJDK: jdk-11.0.16.1 In-Reply-To: <-jXvWY1VA-krHT56FRZG0nUxLF2RlcvaUJFSjIFzkTY=.329a5be2-0439-457a-91e6-ee50907b515a@github.com> References: <-jXvWY1VA-krHT56FRZG0nUxLF2RlcvaUJFSjIFzkTY=.329a5be2-0439-457a-91e6-ee50907b515a@github.com> Message-ID: On Fri, 12 Aug 2022 06:59:09 GMT, Severin Gehwolf wrote: > Version bump for the patch update. Thanks for the review! ------------- PR: https://git.openjdk.org/jdk11u/pull/48 From sgehwolf at openjdk.org Fri Aug 12 08:31:34 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 08:31:34 GMT Subject: [jdk11u] Integrated: 8292255: Bump update version for OpenJDK: jdk-11.0.16.1 In-Reply-To: <-jXvWY1VA-krHT56FRZG0nUxLF2RlcvaUJFSjIFzkTY=.329a5be2-0439-457a-91e6-ee50907b515a@github.com> References: <-jXvWY1VA-krHT56FRZG0nUxLF2RlcvaUJFSjIFzkTY=.329a5be2-0439-457a-91e6-ee50907b515a@github.com> Message-ID: On Fri, 12 Aug 2022 06:59:09 GMT, Severin Gehwolf wrote: > Version bump for the patch update. This pull request has now been integrated. Changeset: e068eba6 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u/commit/e068eba6222ecb1cf583d3830cc2daa0c09e3d33 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8292255: Bump update version for OpenJDK: jdk-11.0.16.1 Reviewed-by: stuefe ------------- PR: https://git.openjdk.org/jdk11u/pull/48 From sgehwolf at openjdk.org Fri Aug 12 08:31:44 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 08:31:44 GMT Subject: [jdk17u] Integrated: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1 In-Reply-To: <2zn3BTHXhluCWPFpQ9H6N2mW9XjvWGoGu9J9sGDXp-o=.869c1d92-bbf1-4320-a06c-9705e5761bce@github.com> References: <2zn3BTHXhluCWPFpQ9H6N2mW9XjvWGoGu9J9sGDXp-o=.869c1d92-bbf1-4320-a06c-9705e5761bce@github.com> Message-ID: On Fri, 12 Aug 2022 07:23:29 GMT, Severin Gehwolf wrote: > Version bump for the patch release. This pull request has now been integrated. Changeset: 27057f84 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u/commit/27057f84af7712dbe769caf804db6c55b2b58a81 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8292258: Bump update version for OpenJDK: jdk-17.0.4.1 Reviewed-by: stuefe ------------- PR: https://git.openjdk.org/jdk17u/pull/349 From sgehwolf at openjdk.org Fri Aug 12 08:59:04 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 08:59:04 GMT Subject: [jdk11u] RFR: 8292260: Backout [REDO] C2 crash when allocating array of size too large Message-ID: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. ------------- Commit messages: - 8292260: Backout [REDO] C2 crash when allocating array of size too large Changes: https://git.openjdk.org/jdk11u/pull/49/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=49&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292260 Stats: 308 lines in 11 files changed: 53 ins; 233 del; 22 mod Patch: https://git.openjdk.org/jdk11u/pull/49.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/49/head:pull/49 PR: https://git.openjdk.org/jdk11u/pull/49 From mbaesken at openjdk.org Fri Aug 12 09:18:27 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 12 Aug 2022 09:18:27 GMT Subject: [jdk17u-dev] RFR: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr Message-ID: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr ------------- Commit messages: - Backport c89556f6cd4d0b64f3e9e2f1dc7c51634522f205 Changes: https://git.openjdk.org/jdk17u-dev/pull/632/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=632&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291633 Stats: 16 lines in 6 files changed: 0 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/632.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/632/head:pull/632 PR: https://git.openjdk.org/jdk17u-dev/pull/632 From sgehwolf at openjdk.org Fri Aug 12 09:26:45 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 09:26:45 GMT Subject: [jdk17u] RFR: 8292260: Backout [REDO] C2 crash when allocating array of size too large Message-ID: PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. ------------- Commit messages: - 8292260: Backout [REDO] C2 crash when allocating array of size too large Changes: https://git.openjdk.org/jdk17u/pull/350/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=350&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292260 Stats: 308 lines in 11 files changed: 53 ins; 232 del; 23 mod Patch: https://git.openjdk.org/jdk17u/pull/350.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/350/head:pull/350 PR: https://git.openjdk.org/jdk17u/pull/350 From stuefe at openjdk.org Fri Aug 12 09:45:22 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 12 Aug 2022 09:45:22 GMT Subject: [jdk11u] RFR: 8292260: Backout [REDO] C2 crash when allocating array of size too large In-Reply-To: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> References: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> Message-ID: On Fri, 12 Aug 2022 08:54:03 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. Backout looks clean. I also applied it and checked delta between this PR and the commit before 8279219. Affected files look identical apart from opto/split_if.cpp which was modified with as part of "8280799: ?2: assert(false) failed: cyclic dependency prevents range check elimination" 22f8e216eef4efc2685986067dee10e24301b6dc ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk11u/pull/49 From sgehwolf at openjdk.org Fri Aug 12 21:45:33 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 12 Aug 2022 21:45:33 GMT Subject: [jdk11u] Integrated: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> References: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> Message-ID: On Fri, 12 Aug 2022 08:54:03 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. This pull request has now been integrated. Changeset: 63e4b5c8 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u/commit/63e4b5c8acdb678f17541b755205e0e4feb5809c Stats: 308 lines in 11 files changed: 53 ins; 233 del; 22 mod 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large Reviewed-by: stuefe Backport-of: 967a28c3d85fdde6d5eb48aa0edd8f7597772469 ------------- PR: https://git.openjdk.org/jdk11u/pull/49 From phh at openjdk.org Fri Aug 12 22:03:24 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 12 Aug 2022 22:03:24 GMT Subject: [jdk11u-dev] RFR: 8251152: ARM32: jtreg c2 Test8202414 test crash In-Reply-To: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> References: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> Message-ID: On Thu, 11 Aug 2022 04:39:05 GMT, Joshua Cao wrote: > Backport of 8251152: ARM32: jtreg c2 Test8202414 test crash > > Backport is not clean because JDK 11 does not include [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > The patch removed the `@requires` line, but the line is present in JDK 11. > > > * @test > * @bug 8202414 > * @summary Unsafe write after primitive array creation may result in array length change > * @requires (os.arch != "sparc") & (os.arch != "sparcv9") > * @run main/othervm compiler.c2.Test8202414 > > > Manual fix is trivial. We just paste the new lines under the `@requires` line JBS issue tagged. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1321 From wkemper at openjdk.org Fri Aug 12 22:29:54 2022 From: wkemper at openjdk.org (William Kemper) Date: Fri, 12 Aug 2022 22:29:54 GMT Subject: [jdk11u-dev] RFR: 8252145: Unify Info.plist files with correct version strings Message-ID: This is a backport of https://bugs.openjdk.org/browse/JDK-8252145. Backport ticket is https://bugs.openjdk.org/browse/JDK-8292307. The Skara bot said this was not a clean backport: https://github.com/openjdk/jdk/commit/7df86108cb42079df8ade07b4d07587c1f0cbe83#commitcomment-81065611, but it was clean for me when I performed it locally. ------------- Commit messages: - Backport 7df86108cb42079df8ade07b4d07587c1f0cbe83 Changes: https://git.openjdk.org/jdk11u-dev/pull/1323/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1323&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8252145 Stats: 144 lines in 9 files changed: 70 ins; 53 del; 21 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1323.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1323/head:pull/1323 PR: https://git.openjdk.org/jdk11u-dev/pull/1323 From joe.darcy at oracle.com Fri Aug 12 23:08:23 2022 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 12 Aug 2022 16:08:23 -0700 Subject: Request for comment on adding "Under Review" as a substate of bugs In-Reply-To: References: <98d35bbf-9431-902a-3a63-d926e74cdfcf@oracle.com> <558af4a0-c758-9150-32bc-a9287a928f54@oracle.com> Message-ID: Hi Guoxiong, Feedback noted; we'll look into changing the workflow to make setting the state in question easier for the Skara bots. Thanks, -Joe On 8/10/2022 11:31 AM, Guoxiong Li wrote: > Hi Joe, > > Thanks for the work. It is very convenient?to edit the `understanding` > field directly. > > But I find it is unable to click the `Start Work` button if someone is > not the assignee of the issue. > So when solving SKARA-803 [1], I find we need to assign the issue to > the bot, then "click" > the `Start Work` button to transfer the status to `In Progress`, > and at last assign the issue back to the actual developer. > This situation is similar to the previous `understanding` field. > > The three?steps (self-assign, Start work, assign back) solution is a > workaround > but it seems to be not very elegant. > So I want to ask: can this be improved? > Or can the bot accounts or other administrators' accounts > click the?`Start Work` button directly without as an assignee? > > [1] https://bugs.openjdk.org/browse/SKARA-803 > > Best Regards, > -- Guoxiong -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Sat Aug 13 15:12:50 2022 From: duke at openjdk.org (Joshua Cao) Date: Sat, 13 Aug 2022 15:12:50 GMT Subject: [jdk11u-dev] RFR: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl Message-ID: <8jaja33KPI1g6HibPgr2niFR_PMG35dT12Te01q-cgY=.887e4cd0-3986-4fb6-a0ca-8871bc44485a@github.com> Not a clean backport since surrounding lines are different, but changes are simple enough. This change passes ProcessBuilder/Basic.java jtreg test on our Alpine systems. ------------- Commit messages: - 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl Changes: https://git.openjdk.org/jdk11u-dev/pull/1324/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1324&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289569 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1324.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1324/head:pull/1324 PR: https://git.openjdk.org/jdk11u-dev/pull/1324 From kvn at openjdk.org Sat Aug 13 15:13:24 2022 From: kvn at openjdk.org (Vladimir Kozlov) Date: Sat, 13 Aug 2022 15:13:24 GMT Subject: [jdk11u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> References: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> Message-ID: On Fri, 12 Aug 2022 08:54:03 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. @jerboaa I don't see corresponding backport bug linked to JDK-8292260. ------------- PR: https://git.openjdk.org/jdk11u/pull/49 From duke at openjdk.org Sat Aug 13 15:28:45 2022 From: duke at openjdk.org (Joshua Cao) Date: Sat, 13 Aug 2022 15:28:45 GMT Subject: [jdk11u-dev] RFR: 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation Message-ID: clean backport. passes TestJFRIntrinsic.java on our systems. ------------- Commit messages: - 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation Changes: https://git.openjdk.org/jdk11u-dev/pull/1325/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1325&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8239423 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1325.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1325/head:pull/1325 PR: https://git.openjdk.org/jdk11u-dev/pull/1325 From duke at openjdk.org Sun Aug 14 12:29:09 2022 From: duke at openjdk.org (VVD) Date: Sun, 14 Aug 2022 12:29:09 GMT Subject: [jdk11u-dev] RFR: 8229258: Backport patch from JDK 14 to allow building with Clang 13 In-Reply-To: References: Message-ID: <0rOsu55NBsOSYRrxm9m8zvdM1mTrZN6KZ9PDyJqTyUk=.feb37a7e-bd4b-40ca-aceb-d9321278bf40@github.com> On Thu, 28 Jul 2022 21:01:32 GMT, Salander wrote: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Is this patch already merged? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From christoph.langer at sap.com Mon Aug 15 06:01:55 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 15 Aug 2022 06:01:55 +0000 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: <158074e04fcf69679b242b4e6e1f79e377447662.camel@redhat.com> References: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> <158074e04fcf69679b242b4e6e1f79e377447662.camel@redhat.com> Message-ID: Hi Guoxiong, +1 from me as well. Would be absolutely great if this part of the backport process could be improved soon. ? Best regards Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Severin Gehwolf > Sent: Dienstag, 9. August 2022 10:43 > To: Guoxiong Li ; jdk8u-dev at openjdk.org; jdk-updates- > dev at openjdk.org; skara-dev at openjdk.org > Subject: Re: [Proposal] Maintainer Approvals and SKARA > > Hi, > > On Tue, 2022-08-09 at 04:25 +0800, Guoxiong Li wrote: > > Hi all, > > > > I re-read your comments about this enhancement recently. > > And I also made a mistake when I backport a patch to jdk11u-dev [1] > > although I have backported several times. > > So SKARA must direct the developers accurately and help developers > > complete the duplicated work to avoid the unnecessary mistakes. > > > > Now I propose the following dev flow. Please only focus on the dev > > flow instead of the code implementation here. > > > > - When a backport PR is created in Github. > > 1. A new checkbox item `[ ] Change must be properly approved by the > > maintainers` will be added to the `Progress` part of the current PR > > body. > > 2. A comment is posted by the bot like below (the italic content) to > > direct the developers: > > This is a backport pull request. Please add a comment to the main > > issue [JDK-XXXX](link) to state the?related condition (the backport > > reason, the risk of the patch, the amount of work and so on). Below is > > an example for you: > > ``` > > Fix Request(jdk17u-dev) > > The code applies cleanly and the test in this change fails without the > > patch and succeeds after applying it. > > The risk of this backport is low because the change is little and the > > issue fixed by this change also exists in jdk xy. > > ``` > > If you don't have permission to add a comment in JBS. Please use the > > command `request-approval` to provide the related content, then?the > > bot can help you add a comment by using the content you provided. > > Below is an example for you: > > ``` > > /request-approval > > Fix Request(jdk17u-dev) > > The code applies cleanly and the test in this change fails without the > > patch and succeeds after applying it. > > The risk of this backport is low because the change is little and the > > issue fixed by this change also exists in jdk xy. > > ``` > > Please note you have to contact the maintainers?directly?in the issue > > [JDK-XXXX](link) or by using the command?`request-approval`?repeatedly > > instead of in this pull request. > > And you don't need to add the fix request label manually to the issue > > like before, now the bot can help you add the label automatically when > > this pull request is ready?for maintainers to approve. > > > > - When the backport PR is ready for approval (other checks have > > succeeded and other progresses have been done) 1. The bot adds a label > > named `jdkXXu-fix-request` to all the issues of the PR 2. The bot adds > > a blocked label named `approval` in PR, like `csr` or other blocked > > labels These two labels are convenient for maintainers to filter the > > issues and PRs which need to be handled now. > > > > - It is time for maintainers to approve The maintainers can add the > > label `jdkXXu-fix-yes` or `jdkXXu-fix-no` in the issue or use the > > command `/approval yes|no|y|n` in the PR to approve or object the > > patch. This newly added command `approval` can be very convenient if > > one backport PR has many corresponding issues. After using this > > command, the bot will add the related label to all the issues just > > like the label `jdkXXu-fix-request`?it had added. > > > > - Then the commit or sponsor flow will continue as usual. > > After approval, if the maintainer said 'yes', the PR will become ready > > to be integrated. > > If the maintainer said 'no', the PR can be closed?by the bot with a > > comment like "The maintainers disapproved of this patch so this pull > > request will be closed automatically". > > No matter 'yes' or 'no', the label `approval` in the PR will be > > removed. > > > > Above is all the dev flow. And next, I will give more information > > about the new commands `request-approval` and `approval`. > > > > - "request-approval" command > > It is similar to the `summary` command which permits multiline > > content. And this command can be used multi times if the author of the > > PR wants to. Each time this command is used, the bot will post the > > content to a new comment in the issue. Because the author who has no > > permission may want to contact/talk with the maintainers. > > The related record will be recorded in the issue instead of PR which > > is your intention in your previous comments. > > > > - "approval" command > > The command `/approval yes` or `/approval y` mean `approved`. > > And the command `/approval no` or `/approval n` mean `dispproved`. > > This command can be used multiple times and only the last time is > > valid. > > Please note when the `/approval no` or `/approval n` is used, the bot > > will close the PR, and when the `/approval yes` or `/approval y` later > > is used, the bot will open the PR automatically. > > > > > > That is all. Thanks for reading and providing feedback. And I will try > > to implement these features if I have time and hear no objection?after > > discussion. > > > > This sounds good to me. +1. Perhaps we should move this discussion and > implementation proposal to the bug tracking this issue as it is hard to find > those mailing list posts later on? > https://bugs.openjdk.org/browse/SKARA-1199 > > It also seems to be in-line with what Andrew Hughes suggested in [i]. > > Thanks, > Severin > > [i] https://mail.openjdk.org/pipermail/jdk-updates-dev/2022- > March/013278.html > > > [1] > > https://github.com/openjdk/jdk11u-dev/pull/1218#issuecomment-11842356 > > 01 > > > > Best Regards, > > -- Guoxiong From duke at openjdk.org Mon Aug 15 06:08:35 2022 From: duke at openjdk.org (psoujany) Date: Mon, 15 Aug 2022 06:08:35 GMT Subject: [jdk11u-dev] Integrated: 8209052: Low contrast in docs/api/constant-values.html In-Reply-To: References: Message-ID: <5B3xcksDwaw6lDVmktI7fQ1hBUuc3BpyTrAtaOOSs-g=.025c911b-a56a-4c2c-a28b-c35ba6c1d673@github.com> On Thu, 4 Aug 2022 10:43:08 GMT, psoujany wrote: > 8209052: Low contrast in docs/api/constant-values.html This pull request has now been integrated. Changeset: 7d32ed97 Author: Pasam Soujanya1 Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/7d32ed97021996066bfb6d91a748a273d9bc85e3 Stats: 12 lines in 1 file changed: 4 ins; 4 del; 4 mod 8209052: Low contrast in docs/api/constant-values.html Backport-of: e2eab3c1b7d55860e705ae6f924a2a3976f76f48 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1316 From goetz.lindenmaier at sap.com Mon Aug 15 06:11:04 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 15 Aug 2022 06:11:04 +0000 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> <158074e04fcf69679b242b4e6e1f79e377447662.camel@redhat.com> Message-ID: Hi, +1, This is a good improval. Please remember that the instructions should not talk about backports, but about changes to an updates repository. Sometimes there are genuine changes for an update repository, these have to follow the very same approval rules. > > > This is a backport pull request. Please add a comment to the main > > > issue [JDK-XXXX](link) to state the related condition (the backport > > > reason, the risk of the patch, the amount of work and so on). Below is > > > an example for you: "This is a change to an updates repository. Please add a comment to the JBS issue, in case of a backport to the existing main issue [JDK-XXXX](link). State the related condition (Why you do the change/backport, the risk of the patch, the amount of work and so on). Below is an example for you: ... Best regards, Goetz > -----Original Message----- > From: skara-dev On Behalf Of Langer, Christoph > Sent: Montag, 15. August 2022 08:02 > To: Severin Gehwolf ; Guoxiong Li > ; jdk8u-dev at openjdk.org; jdk-updates- > dev at openjdk.org; skara-dev at openjdk.org > Subject: RE: [Proposal] Maintainer Approvals and SKARA > > Hi Guoxiong, > > +1 from me as well. Would be absolutely great if this part of the backport > process could be improved soon. ? > > Best regards > Christoph > > > -----Original Message----- > > From: jdk-updates-dev On Behalf Of > > Severin Gehwolf > > Sent: Dienstag, 9. August 2022 10:43 > > To: Guoxiong Li ; jdk8u-dev at openjdk.org; jdk-updates- > > dev at openjdk.org; skara-dev at openjdk.org > > Subject: Re: [Proposal] Maintainer Approvals and SKARA > > > > Hi, > > > > On Tue, 2022-08-09 at 04:25 +0800, Guoxiong Li wrote: > > > Hi all, > > > > > > I re-read your comments about this enhancement recently. > > > And I also made a mistake when I backport a patch to jdk11u-dev [1] > > > although I have backported several times. > > > So SKARA must direct the developers accurately and help developers > > > complete the duplicated work to avoid the unnecessary mistakes. > > > > > > Now I propose the following dev flow. Please only focus on the dev > > > flow instead of the code implementation here. > > > > > > - When a backport PR is created in Github. > > > 1. A new checkbox item `[ ] Change must be properly approved by the > > > maintainers` will be added to the `Progress` part of the current PR > > > body. > > > 2. A comment is posted by the bot like below (the italic content) to > > > direct the developers: > > > This is a backport pull request. Please add a comment to the main > > > issue [JDK-XXXX](link) to state the?related condition (the backport > > > reason, the risk of the patch, the amount of work and so on). Below is > > > an example for you: > > > ``` > > > Fix Request(jdk17u-dev) > > > The code applies cleanly and the test in this change fails without the > > > patch and succeeds after applying it. > > > The risk of this backport is low because the change is little and the > > > issue fixed by this change also exists in jdk xy. > > > ``` > > > If you don't have permission to add a comment in JBS. Please use the > > > command `request-approval` to provide the related content, then?the > > > bot can help you add a comment by using the content you provided. > > > Below is an example for you: > > > ``` > > > /request-approval > > > Fix Request(jdk17u-dev) > > > The code applies cleanly and the test in this change fails without the > > > patch and succeeds after applying it. > > > The risk of this backport is low because the change is little and the > > > issue fixed by this change also exists in jdk xy. > > > ``` > > > Please note you have to contact the maintainers?directly?in the issue > > > [JDK-XXXX](link) or by using the command?`request-approval`?repeatedly > > > instead of in this pull request. > > > And you don't need to add the fix request label manually to the issue > > > like before, now the bot can help you add the label automatically when > > > this pull request is ready?for maintainers to approve. > > > > > > - When the backport PR is ready for approval (other checks have > > > succeeded and other progresses have been done) 1. The bot adds a label > > > named `jdkXXu-fix-request` to all the issues of the PR 2. The bot adds > > > a blocked label named `approval` in PR, like `csr` or other blocked > > > labels These two labels are convenient for maintainers to filter the > > > issues and PRs which need to be handled now. > > > > > > - It is time for maintainers to approve The maintainers can add the > > > label `jdkXXu-fix-yes` or `jdkXXu-fix-no` in the issue or use the > > > command `/approval yes|no|y|n` in the PR to approve or object the > > > patch. This newly added command `approval` can be very convenient if > > > one backport PR has many corresponding issues. After using this > > > command, the bot will add the related label to all the issues just > > > like the label `jdkXXu-fix-request`?it had added. > > > > > > - Then the commit or sponsor flow will continue as usual. > > > After approval, if the maintainer said 'yes', the PR will become ready > > > to be integrated. > > > If the maintainer said 'no', the PR can be closed?by the bot with a > > > comment like "The maintainers disapproved of this patch so this pull > > > request will be closed automatically". > > > No matter 'yes' or 'no', the label `approval` in the PR will be > > > removed. > > > > > > Above is all the dev flow. And next, I will give more information > > > about the new commands `request-approval` and `approval`. > > > > > > - "request-approval" command > > > It is similar to the `summary` command which permits multiline > > > content. And this command can be used multi times if the author of the > > > PR wants to. Each time this command is used, the bot will post the > > > content to a new comment in the issue. Because the author who has no > > > permission may want to contact/talk with the maintainers. > > > The related record will be recorded in the issue instead of PR which > > > is your intention in your previous comments. > > > > > > - "approval" command > > > The command `/approval yes` or `/approval y` mean `approved`. > > > And the command `/approval no` or `/approval n` mean `dispproved`. > > > This command can be used multiple times and only the last time is > > > valid. > > > Please note when the `/approval no` or `/approval n` is used, the bot > > > will close the PR, and when the `/approval yes` or `/approval y` later > > > is used, the bot will open the PR automatically. > > > > > > > > > That is all. Thanks for reading and providing feedback. And I will try > > > to implement these features if I have time and hear no objection?after > > > discussion. > > > > > > > This sounds good to me. +1. Perhaps we should move this discussion and > > implementation proposal to the bug tracking this issue as it is hard to find > > those mailing list posts later on? > > https://bugs.openjdk.org/browse/SKARA-1199 > > > > It also seems to be in-line with what Andrew Hughes suggested in [i]. > > > > Thanks, > > Severin > > > > [i] https://mail.openjdk.org/pipermail/jdk-updates-dev/2022- > > March/013278.html > > > > > [1] > > > https://github.com/openjdk/jdk11u-dev/pull/1218#issuecomment- > 11842356 > > > 01 > > > > > > Best Regards, > > > -- Guoxiong From clanger at openjdk.org Mon Aug 15 06:15:21 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 15 Aug 2022 06:15:21 GMT Subject: [jdk11u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> Message-ID: On Sat, 13 Aug 2022 15:11:23 GMT, Vladimir Kozlov wrote: > @jerboaa I don't see corresponding backport bug linked to JDK-8292260. I believe a backport bug will be created once we merge this back into the master branch. Let's see what happens. If Skara bots fail to do so, we need to create one manually. ------------- PR: https://git.openjdk.org/jdk11u/pull/49 From yan at openjdk.org Mon Aug 15 09:03:30 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 15 Aug 2022 09:03:30 GMT Subject: [jdk15u-dev] RFR: 8276841: Add support for Visual Studio 2022 In-Reply-To: <7O6xW26qdAMqetqzepGgtoZf8HIIsU9ivIlpklPEqxc=.8c660dfb-a478-4fba-b581-cf2c7e4e12cf@github.com> References: <7O6xW26qdAMqetqzepGgtoZf8HIIsU9ivIlpklPEqxc=.8c660dfb-a478-4fba-b581-cf2c7e4e12cf@github.com> Message-ID: On Wed, 3 Aug 2022 21:54:14 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [f65db88b](https://github.com/openjdk/jdk/commit/f65db88b74911e5896d2ff536c4ac97e7f62d98b) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Yasumasa Suenaga on 9 Nov 2021 and was reviewed by Erik Joelsson and Magnus Ihse Bursie. > > The change is not "clean" because the jdk15u supports more versions than the jdk/jdk. > I have tested the build using VS 2019 and 2022, results of tier1/tier2 are the same. > > Thanks! @mrserb could you please add fix request and jdk15u-fix-request label to the JBS bug? (and BTW you have _ready_ https://github.com/openjdk/jdk15u-dev/pull/225 since Jun 20, also requiring jdk15u-fix-request) ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/252 From sgehwolf at openjdk.org Mon Aug 15 11:29:20 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 15 Aug 2022 11:29:20 GMT Subject: [jdk11u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> References: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> Message-ID: On Fri, 12 Aug 2022 08:54:03 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. We've only integrated this into the `jdk11.0.16.1` branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create on manually for 11.0.16.1. ------------- PR: https://git.openjdk.org/jdk11u/pull/49 From kcr at openjdk.org Mon Aug 15 12:56:59 2022 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 15 Aug 2022 12:56:59 GMT Subject: [jdk11u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> Message-ID: On Mon, 15 Aug 2022 11:25:49 GMT, Severin Gehwolf wrote: > We've only integrated this into the jdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create on manually for 11.0.16.1. @jerboaa I alerted @erikj79 who has discovered the reason that the JBS backport record wasn't created and the commit URL wasn't added as a comment. It should be fixed shortly, so you should not have to manually create the record. ------------- PR: https://git.openjdk.org/jdk11u/pull/49 From sgehwolf at openjdk.org Mon Aug 15 13:37:49 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 15 Aug 2022 13:37:49 GMT Subject: [jdk11u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> Message-ID: <4m3meQlb64ejLIMwoWCowxndiA9gKfU830TSMx51Qn0=.c15fcd30-a2c8-4c00-8f97-1025c4ed9f42@github.com> On Mon, 15 Aug 2022 12:53:57 GMT, Kevin Rushforth wrote: >> PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. > >> We've only integrated this into the jdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create on manually for 11.0.16.1. > > @jerboaa I alerted @erikj79 who has discovered the reason that the JBS backport record wasn't created and the commit URL wasn't added as a comment. It should be fixed shortly, so you should not have to manually create the record. @kevinrushforth OK. Thank you! ------------- PR: https://git.openjdk.org/jdk11u/pull/49 From yan at openjdk.org Mon Aug 15 14:17:21 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 15 Aug 2022 14:17:21 GMT Subject: [jdk15u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update Message-ID: Regular (someway belated) change for every release train. Not formally clean backport: different lists of bugs in the tests. All currency, resources tests run fine. ------------- Commit messages: - Backport c4dc58e12e197562dce90c0027aa74c29047cea6 Changes: https://git.openjdk.org/jdk15u-dev/pull/253/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=253&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283277 Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/253.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/253/head:pull/253 PR: https://git.openjdk.org/jdk15u-dev/pull/253 From yan at openjdk.org Mon Aug 15 14:31:15 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 15 Aug 2022 14:31:15 GMT Subject: [jdk13u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update Message-ID: Regular (someway belated here) change for every release train. Not formally clean backport: different lists of bugs in the tests. All currency, resources tests run fine. ------------- Commit messages: - Backport c4dc58e12e197562dce90c0027aa74c29047cea6 Changes: https://git.openjdk.org/jdk13u-dev/pull/387/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=387&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283277 Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/387.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/387/head:pull/387 PR: https://git.openjdk.org/jdk13u-dev/pull/387 From dcherepanov at openjdk.org Mon Aug 15 14:33:40 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 15 Aug 2022 14:33:40 GMT Subject: [jdk13u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 14:20:13 GMT, Yuri Nesterenko wrote: > Regular (someway belated here) change for every release train. Not formally clean backport: different lists of bugs in the tests. All currency, resources tests run fine. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/387 From dcherepanov at openjdk.org Mon Aug 15 14:35:26 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 15 Aug 2022 14:35:26 GMT Subject: [jdk15u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 14:07:28 GMT, Yuri Nesterenko wrote: > Regular (someway belated) change for every release train. Not formally clean backport: different lists of bugs in the tests. All currency, resources tests run fine. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/253 From duke at openjdk.org Mon Aug 15 15:12:07 2022 From: duke at openjdk.org (Joshua Cao) Date: Mon, 15 Aug 2022 15:12:07 GMT Subject: [jdk11u-dev] RFR: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package Message-ID: clean backport. Primary motivation for this backport is that this patch is a dependency of [8242188](https://bugs.openjdk.org/browse/JDK-8242188), which fixes a JFR test bug. Opening a separate PR for that. ------------- Commit messages: - 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package Changes: https://git.openjdk.org/jdk11u-dev/pull/1326/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1326&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8239265 Stats: 557 lines in 18 files changed: 127 ins; 157 del; 273 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1326.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1326/head:pull/1326 PR: https://git.openjdk.org/jdk11u-dev/pull/1326 From clanger at openjdk.org Mon Aug 15 15:25:47 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 15 Aug 2022 15:25:47 GMT Subject: [jdk17u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Fri, 12 Aug 2022 09:20:53 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. Looks good. JDK-8284369 is backouted by this as well but that was a specific fix for/after JDK-8279219 anyway. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk17u/pull/350 From clanger at openjdk.org Mon Aug 15 15:31:28 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 15 Aug 2022 15:31:28 GMT Subject: [jdk11u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: <27aXGZh5xwF4wzDNQYbKxaadF0IdBRVOIdrj3J85tFA=.c9dc1ee4-0e7d-45a1-9860-c838914f716a@github.com> Message-ID: On Mon, 15 Aug 2022 12:53:57 GMT, Kevin Rushforth wrote: > > We've only integrated this into the jdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create on manually for 11.0.16.1. > > @jerboaa I alerted @erikj79 who has discovered the reason that the JBS backport record wasn't created and the commit URL wasn't added as a comment. It should be fixed shortly, so you should not have to manually create the record. Looks like this is resolved now. Good to know that the Skara bots also operate on branches. ------------- PR: https://git.openjdk.org/jdk11u/pull/49 From duke at openjdk.org Mon Aug 15 15:38:10 2022 From: duke at openjdk.org (Joshua Cao) Date: Mon, 15 Aug 2022 15:38:10 GMT Subject: [jdk11u-dev] RFR: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 Message-ID: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> clean backport after https://github.com/openjdk/jdk11u-dev/pull/1326 ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1326 Commit messages: - 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 Changes: https://git.openjdk.org/jdk11u-dev/pull/1327/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1327&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8242188 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1327.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1327/head:pull/1327 PR: https://git.openjdk.org/jdk11u-dev/pull/1327 From christoph.langer at sap.com Mon Aug 15 15:38:26 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 15 Aug 2022 15:38:26 +0000 Subject: [17u, 11u] Release Engineering Notification: Fixed format of some 11.0.16.1 and 17.0.4.1 tags (force-push) Message-ID: Hi, I have repaired the tags 11.0.16.1+0 [0], 11.0.16.1+1 [1], 11.0.16.1-ga [2], 17.0.4.1+0 [3] to be annotated tags as per the usual convention. They had wrongly been issued as lightweight tags. While the tags still point to the same commits I could not avoid force-pushing them. I hope it doesn?t break any scripts or CI integration. If so, I?m sorry for the inconvenience caused. Best regards Christoph [0] https://github.com/openjdk/jdk11u/releases/tag/jdk-11.0.16.1%2B0 [1] https://github.com/openjdk/jdk11u/releases/tag/jdk-11.0.16.1%2B1 [2] https://github.com/openjdk/jdk11u/releases/tag/jdk-11.0.16.1-ga [3] https://github.com/openjdk/jdk17u/releases/tag/jdk-17.0.4.1%2B0 -------------- next part -------------- An HTML attachment was scrubbed... URL: From phh at openjdk.org Mon Aug 15 19:13:23 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 15 Aug 2022 19:13:23 GMT Subject: [jdk11u-dev] RFR: 8252145: Unify Info.plist files with correct version strings In-Reply-To: References: Message-ID: On Fri, 12 Aug 2022 22:23:24 GMT, William Kemper wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8252145. Backport ticket is https://bugs.openjdk.org/browse/JDK-8292307. The Skara bot said this was not a clean backport: https://github.com/openjdk/jdk/commit/7df86108cb42079df8ade07b4d07587c1f0cbe83#commitcomment-81065611, but it was clean for me when I performed it locally. The pre-submit Windows test failure appears unrelated to this patch. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1323 From duke at openjdk.org Mon Aug 15 19:57:14 2022 From: duke at openjdk.org (Gaurav Chaudhari) Date: Mon, 15 Aug 2022 19:57:14 GMT Subject: [jdk11u-dev] RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable Message-ID: Backport changes from JDK-8288377 ------------- Commit messages: - Backport 3c3256414f7df049cdd6c8519fbcea0d818a1a33 Changes: https://git.openjdk.org/jdk11u-dev/pull/1328/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1328&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288377 Stats: 129 lines in 2 files changed: 80 ins; 34 del; 15 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1328.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1328/head:pull/1328 PR: https://git.openjdk.org/jdk11u-dev/pull/1328 From duke at openjdk.org Tue Aug 16 00:01:32 2022 From: duke at openjdk.org (duke) Date: Tue, 16 Aug 2022 00:01:32 GMT Subject: [jdk11u-dev] Withdrawn: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 20:46:13 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [ebfa27b9](https://github.com/openjdk/jdk/commit/ebfa27b9f06aee8ceceabc564a78a351903ce9a1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov. > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1162 From duke at openjdk.org Tue Aug 16 00:26:44 2022 From: duke at openjdk.org (duke) Date: Tue, 16 Aug 2022 00:26:44 GMT Subject: [jdk17u-dev] Withdrawn: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 20:43:18 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [ebfa27b9](https://github.com/openjdk/jdk/commit/ebfa27b9f06aee8ceceabc564a78a351903ce9a1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov. > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/480 From yan at openjdk.org Tue Aug 16 07:01:28 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 16 Aug 2022 07:01:28 GMT Subject: [jdk15u-dev] Integrated: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 14:07:28 GMT, Yuri Nesterenko wrote: > Regular (someway belated) change for every release train. Not formally clean backport: different lists of bugs in the tests. All currency, resources tests run fine. This pull request has now been integrated. Changeset: 1e3901d0 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/1e3901d02d8cfa76d6fe5cb13e3ff92a7d380d69 Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod 8283277: ISO 4217 Amendment 171 Update Reviewed-by: dcherepanov Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/253 From yan at openjdk.org Tue Aug 16 07:03:27 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 16 Aug 2022 07:03:27 GMT Subject: [jdk13u-dev] Integrated: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 14:20:13 GMT, Yuri Nesterenko wrote: > Regular (someway belated here) change for every release train. Not formally clean backport: different lists of bugs in the tests. All currency, resources tests run fine. This pull request has now been integrated. Changeset: 668ca51c Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/668ca51cdc179fbdb6f31d5f92c5076e7c122492 Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod 8283277: ISO 4217 Amendment 171 Update Reviewed-by: dcherepanov Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/387 From clanger at openjdk.org Tue Aug 16 07:47:42 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 07:47:42 GMT Subject: [jdk17u-dev] RFR: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider In-Reply-To: References: Message-ID: On Wed, 10 Aug 2022 18:50:49 GMT, Martijn Verburg wrote: > Backport of 5e5500cbd79b40a32c20547ea0cdb81ef6904a3d > > On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges. > > "Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc > > keystore functionality and API remains unchanged, the local machine keystore types require the manual tests to run in admin mode > > Tested on windows, passes tier1 (via GH Actions) and manual tests provided in the patch I've approved the backport and can help to sponsor it. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/630 From clanger at openjdk.org Tue Aug 16 08:31:34 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 08:31:34 GMT Subject: [jdk17u-dev] RFR: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 In-Reply-To: References: Message-ID: On Thu, 11 Aug 2022 05:03:08 GMT, Joshua Cao wrote: > clean backport @caojoshua, can you change the title to "Backport 928e34773694dda5373027848a3363887bcaf4f4" in order to have the bots recognize this as a backport? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/631 From sgehwolf at openjdk.org Tue Aug 16 08:32:05 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 16 Aug 2022 08:32:05 GMT Subject: [jdk17u] Integrated: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Fri, 12 Aug 2022 09:20:53 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. This pull request has now been integrated. Changeset: 02fa4be6 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u/commit/02fa4be6c4452ffa5fae8200024953e4ba1afd83 Stats: 308 lines in 11 files changed: 53 ins; 232 del; 23 mod 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large Reviewed-by: clanger Backport-of: 967a28c3d85fdde6d5eb48aa0edd8f7597772469 ------------- PR: https://git.openjdk.org/jdk17u/pull/350 From clanger at openjdk.org Tue Aug 16 08:36:39 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 08:36:39 GMT Subject: [jdk17u-dev] RFR: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 In-Reply-To: References: Message-ID: On Thu, 11 Aug 2022 05:03:08 GMT, Joshua Cao wrote: > clean backport an, please also enable Github Actions on your repository to get the PR checks ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/631 From yan at openjdk.org Tue Aug 16 08:49:29 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 16 Aug 2022 08:49:29 GMT Subject: [jdk13u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update Message-ID: I'm backporting this recurrent change to be on par with most other releases. The only difference from original is, CurrencyData.properties is still in make/data subdirectory. All relevant tests run fine. ------------- Commit messages: - Backport 604ea90d55ac8354fd7287490ef59b8e3ce020d1 Changes: https://git.openjdk.org/jdk13u-dev/pull/388/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=388&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289549 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/388.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/388/head:pull/388 PR: https://git.openjdk.org/jdk13u-dev/pull/388 From yan at openjdk.org Tue Aug 16 09:01:28 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 16 Aug 2022 09:01:28 GMT Subject: [jdk15u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update Message-ID: I'm backporting this recurrent change to be on par with most other releases. The only difference from original is, CurrencyData.properties is still in make/data subdirectory. All relevant tests run fine. ------------- Commit messages: - Backport 604ea90d55ac8354fd7287490ef59b8e3ce020d1 Changes: https://git.openjdk.org/jdk15u-dev/pull/254/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=254&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289549 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/254.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/254/head:pull/254 PR: https://git.openjdk.org/jdk15u-dev/pull/254 From clanger at openjdk.org Tue Aug 16 09:13:33 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 09:13:33 GMT Subject: [jdk11u-dev] RFR: 8214078: (fs) SecureDirectoryStream not supported on arm32 In-Reply-To: References: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> Message-ID: On Thu, 11 Aug 2022 20:15:42 GMT, Joshua Cao wrote: >> Clean backport. Passes test on our arm32 machine. > > done @caojoshua please rename PR to "Backport 10cd386ac3508c19bd4e7202a8b07e03dcc0462b" to have the bots pick it up correctly. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1322 From dcherepanov at openjdk.org Tue Aug 16 10:17:23 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Tue, 16 Aug 2022 10:17:23 GMT Subject: [jdk15u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 08:50:57 GMT, Yuri Nesterenko wrote: > I'm backporting this recurrent change to be on par with most other releases. > The only difference from original is, CurrencyData.properties is still in make/data subdirectory. > All relevant tests run fine. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/254 From dcherepanov at openjdk.org Tue Aug 16 10:17:28 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Tue, 16 Aug 2022 10:17:28 GMT Subject: [jdk13u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 08:39:07 GMT, Yuri Nesterenko wrote: > I'm backporting this recurrent change to be on par with most other releases. > The only difference from original is, CurrencyData.properties is still in make/data subdirectory. > All relevant tests run fine. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/388 From yan at openjdk.org Tue Aug 16 10:36:16 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 16 Aug 2022 10:36:16 GMT Subject: [jdk13u-dev] Integrated: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: References: Message-ID: <5Y1zvjkZw85ytyP2ZvTPRtPPNchHwysrZc-qhiqe3zM=.388c590f-5252-41ce-8629-f5ec583e3782@github.com> On Tue, 16 Aug 2022 08:39:07 GMT, Yuri Nesterenko wrote: > I'm backporting this recurrent change to be on par with most other releases. > The only difference from original is, CurrencyData.properties is still in make/data subdirectory. > All relevant tests run fine. This pull request has now been integrated. Changeset: d9202d65 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/d9202d6515357b89a91a75823e9f4cb1f0e5880c Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8289549: ISO 4217 Amendment 172 Update Reviewed-by: dcherepanov Backport-of: 604ea90d55ac8354fd7287490ef59b8e3ce020d1 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/388 From yan at openjdk.org Tue Aug 16 10:40:26 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 16 Aug 2022 10:40:26 GMT Subject: [jdk15u-dev] Integrated: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 08:50:57 GMT, Yuri Nesterenko wrote: > I'm backporting this recurrent change to be on par with most other releases. > The only difference from original is, CurrencyData.properties is still in make/data subdirectory. > All relevant tests run fine. This pull request has now been integrated. Changeset: 0af73588 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/0af73588a0e4195bce536174d7f815316db968c8 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8289549: ISO 4217 Amendment 172 Update Reviewed-by: dcherepanov Backport-of: 604ea90d55ac8354fd7287490ef59b8e3ce020d1 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/254 From goetz at openjdk.org Tue Aug 16 10:47:28 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Aug 2022 10:47:28 GMT Subject: [jdk11u-dev] RFR: 7131823: bug in GIFImageReader In-Reply-To: <7E7txzeypEU9mAMBOMRZCuXqYZNbg6pIsQcFwwjmbiw=.2d17b087-388e-4844-a705-7b51ae028c4b@github.com> References: <7E7txzeypEU9mAMBOMRZCuXqYZNbg6pIsQcFwwjmbiw=.2d17b087-388e-4844-a705-7b51ae028c4b@github.com> Message-ID: On Thu, 4 Aug 2022 20:06:16 GMT, Dan Lutker wrote: > This is a backport of JDK-7131823: bug in GIFImageReader > > Original patch applied cleanly and all imageio tests pass on linux x64 including the new `javax/imageio/plugins/gif/GIFLargeTableIndexTest.java`. > > Summary: jdk_imageio > TEST STATS: name=jdk_imageio run=196 pass=196 fail=0 > > > All teir1 passed as well. > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1461 1461 0 0 > jtreg:test/jdk:tier1 1874 1874 0 0 > jtreg:test/langtools:tier1 3924 3924 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS Please enable the GHA pre-submit tests. If you merge head, they will run again. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1317 From duke at openjdk.org Tue Aug 16 11:49:18 2022 From: duke at openjdk.org (xpbob) Date: Tue, 16 Aug 2022 11:49:18 GMT Subject: [jdk17u] RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode Message-ID: Backport a625bfdba45d49bc717bcc9be4112db93b50f50a ------------- Commit messages: - Backport a625bfdba45d49bc717bcc9be4112db93b50f50a Changes: https://git.openjdk.org/jdk17u/pull/351/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=351&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283903 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u/pull/351.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/351/head:pull/351 PR: https://git.openjdk.org/jdk17u/pull/351 From clanger at openjdk.org Tue Aug 16 12:21:27 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 12:21:27 GMT Subject: [jdk17u] RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode In-Reply-To: References: Message-ID: <8NG4KcFPhJyNc29BUN4ETjBwu_l-Bg8lD_dIAx9qfdo=.fe8fa1fe-ddea-4147-9fcd-1ada6be25ba4@github.com> On Tue, 16 Aug 2022 11:41:37 GMT, xpbob wrote: > Backport a625bfdba45d49bc717bcc9be4112db93b50f50a Woow - that was too quick. ? First, this is the wrong repository. Please open the PR at the [jdk17u-dev](https://github.com/openjdk/jdk17u-dev) repository (and close this one). Then, please enable GitHub Actions for your repository clone that we see some tier1 acceptance testing. And, furthermore, for a backport please don't do /integrate before it has been approved in JBS via the appropriate fix-yes label. For more details about the backporting processs, please consider reading https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix ------------- PR: https://git.openjdk.org/jdk17u/pull/351 From duke at openjdk.org Tue Aug 16 12:23:05 2022 From: duke at openjdk.org (xpbob) Date: Tue, 16 Aug 2022 12:23:05 GMT Subject: [jdk17u] Withdrawn: 8283903: GetContainerCpuLoad does not return the correct result in share mode In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 11:41:37 GMT, xpbob wrote: > Backport a625bfdba45d49bc717bcc9be4112db93b50f50a This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u/pull/351 From clanger at openjdk.org Tue Aug 16 12:29:44 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 12:29:44 GMT Subject: [jdk11u-dev] RFR: 8247546: Pattern matching does not skip correctly over supplementary characters In-Reply-To: References: Message-ID: On Tue, 9 Aug 2022 02:13:19 GMT, Liam Miller-Cushon wrote: > This is a backport of [JDK-8247546: Pattern matching does not skip correctly over supplementary characters](https://bugs.openjdk.org/browse/JDK-8247546) > > Original patch applied cleanly except for a merge conflict on the `@bug` comment in the test. > > All tier1 tests passed. LGTM ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1319 From duke at openjdk.org Tue Aug 16 12:42:54 2022 From: duke at openjdk.org (xpbob) Date: Tue, 16 Aug 2022 12:42:54 GMT Subject: [jdk17u-dev] RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode Message-ID: <53DWujVgVMM7OnjDpKh4Ms7VXff36qITY-GkfBPiycg=.01d3b95b-98a9-4afd-8934-cb156086db98@github.com> Backport a625bfdba45d49bc717bcc9be4112db93b50f50a ------------- Commit messages: - Backport a625bfdba45d49bc717bcc9be4112db93b50f50a Changes: https://git.openjdk.org/jdk17u-dev/pull/633/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=633&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283903 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/633.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/633/head:pull/633 PR: https://git.openjdk.org/jdk17u-dev/pull/633 From clanger at openjdk.org Tue Aug 16 12:47:25 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 12:47:25 GMT Subject: [jdk11u-dev] RFR: 8251152: ARM32: jtreg c2 Test8202414 test crash In-Reply-To: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> References: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> Message-ID: On Thu, 11 Aug 2022 04:39:05 GMT, Joshua Cao wrote: > Backport of 8251152: ARM32: jtreg c2 Test8202414 test crash > > Backport is not clean because JDK 11 does not include [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > The patch removed the `@requires` line, but the line is present in JDK 11. > > > * @test > * @bug 8202414 > * @summary Unsafe write after primitive array creation may result in array length change > * @requires (os.arch != "sparc") & (os.arch != "sparcv9") > * @run main/othervm compiler.c2.Test8202414 > > > Manual fix is trivial. We just paste the new lines under the `@requires` line Again, please rename to `Backport 70d5cac961db663f96223bd9efbc8b5ca77cc88a` to get it correctly picked up as backport by the bots. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1321 From clanger at openjdk.org Tue Aug 16 12:55:25 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 12:55:25 GMT Subject: [jdk11u-dev] RFR: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl In-Reply-To: <8jaja33KPI1g6HibPgr2niFR_PMG35dT12Te01q-cgY=.887e4cd0-3986-4fb6-a0ca-8871bc44485a@github.com> References: <8jaja33KPI1g6HibPgr2niFR_PMG35dT12Te01q-cgY=.887e4cd0-3986-4fb6-a0ca-8871bc44485a@github.com> Message-ID: On Sat, 13 Aug 2022 15:07:40 GMT, Joshua Cao wrote: > Not a clean backport since surrounding lines are different, but changes are simple enough. This change passes ProcessBuilder/Basic.java jtreg test on our Alpine systems. Here the PR title would be "Backport a8edd7a12f955fe843c7c9ad4273e9c653a80c5a" ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1324 From clanger at openjdk.org Tue Aug 16 13:02:26 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 13:02:26 GMT Subject: [jdk11u-dev] RFR: 8210047: some pages contain content outside of landmark region In-Reply-To: References: <-XJ-XnNQsNRs0ggI1XJHnhlUGhXRV4WNvjXhZrvI6yM=.e97bd723-351a-4e91-832c-f3df34966c34@github.com> Message-ID: On Thu, 11 Aug 2022 04:52:09 GMT, psoujany wrote: >> Backport of 8210047: some pages contain content outside of landmark region >> >> OpenJDK Bug : https://bugs.openjdk.org/browse/JDK-8210047 > > @RealCLanger Could you please review this backport. Thank you. @psoujany, do you have any hints on what you had to modify for this backport? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1320 From clanger at openjdk.org Tue Aug 16 13:03:34 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 13:03:34 GMT Subject: [jdk11u-dev] RFR: 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation In-Reply-To: References: Message-ID: On Sat, 13 Aug 2022 15:21:45 GMT, Joshua Cao wrote: > clean backport. passes TestJFRIntrinsic.java on our systems. Please also change the PR title to the according "Backport ". ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1325 From duke at openjdk.org Tue Aug 16 13:32:18 2022 From: duke at openjdk.org (psoujany) Date: Tue, 16 Aug 2022 13:32:18 GMT Subject: [jdk11u-dev] RFR: 8210047: some pages contain content outside of landmark region In-Reply-To: References: <-XJ-XnNQsNRs0ggI1XJHnhlUGhXRV4WNvjXhZrvI6yM=.e97bd723-351a-4e91-832c-f3df34966c34@github.com> Message-ID: <5eJTsZsDX6SAnwcYR9gPu-989TjPT179d5Y6u8-DXnI=.29e0a9f6-1fe0-464e-93db-255a7ba73efa@github.com> On Tue, 16 Aug 2022 12:58:53 GMT, Christoph Langer wrote: >> @RealCLanger Could you please review this backport. Thank you. > > @psoujany, do you have any hints on what you had to modify for this backport? @RealCLanger After applying the backport, I've modified the below testcase i.e, TestHtmlVersion.java https://github.com/openjdk/jdk11u-dev/pull/1320/files#diff-758d666ce824475aacf00bdbd1af556809a342f6fa24eb177e5a4540f11801a5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1320 From clanger at openjdk.org Tue Aug 16 13:38:18 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 13:38:18 GMT Subject: [jdk11u-dev] RFR: 8229258: Backport patch from JDK 14 to allow building with Clang 13 In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 21:01:32 GMT, Salander wrote: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Hi, that's quite a big patch. Can this be made smaller - if the purpose is only to make clang13 work? Furthermore, as this is no full backport of JDK-8229258, I suggest to change the title into just "Allow building with Clang 13" for the time being. I think, if this is ever going to be reviewed and accepted, we'll need to open a specific JBS bug for this, targeting JDK 11. I'm also not sure where support for clang13 is needed in the OpenJDK so far. Usually, linux versions are built with gcc. clang is only used on MacOS and AIX but for these OS versions we're not yet at clang version 13, I believe. Anyway, if it fixes UB and XCode will go to clang13 soon, a fix for this issue might be needed sooner or later. Another hint/requirement: Please enable GitHub Actions on your repository so as to have some basic tier1 acceptance testing for the PR. Cheers Christoph ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From goetz at openjdk.org Tue Aug 16 13:40:24 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Aug 2022 13:40:24 GMT Subject: [jdk11u-dev] Integrated: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: References: Message-ID: On Sun, 7 Aug 2022 20:41:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 03a5c254 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/03a5c254d36a51d478b3c1042f0fb6f2c7453dc6 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8289549: ISO 4217 Amendment 172 Update Backport-of: 9168aa252d32d48a3bda9a6e28e3215805fe60c5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1318 From clanger at openjdk.org Tue Aug 16 13:43:23 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 13:43:23 GMT Subject: [jdk11u-dev] RFR: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 15:04:25 GMT, Joshua Cao wrote: > clean backport. Primary motivation for this backport is that this patch is a dependency of [8242188](https://bugs.openjdk.org/browse/JDK-8242188), which fixes a JFR test bug. Opening a separate PR for that. Please fix the PR title as well. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1326 From clanger at openjdk.org Tue Aug 16 13:47:24 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 13:47:24 GMT Subject: [jdk11u-dev] RFR: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 In-Reply-To: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> References: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> Message-ID: On Mon, 15 Aug 2022 15:20:01 GMT, Joshua Cao wrote: > clean backport after https://github.com/openjdk/jdk11u-dev/pull/1326 Needs renaming to "Backport " as well... ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1327 From clanger at openjdk.org Tue Aug 16 13:55:27 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 13:55:27 GMT Subject: [jdk11u-dev] RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 19:49:14 GMT, Gaurav Chaudhari wrote: > Backport changes from JDK-8288377 @Deigue: I suggest you backport this fix to jdk19u and jdk17u first before attempting to go back to jdk11u. Please also enable GitHub Actions on your repository to have some validation results. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1328 From clanger at openjdk.org Tue Aug 16 14:25:33 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 14:25:33 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge changes for jdk-17.0.4.1 from jdk17u ------------- Commit messages: - Merge 'jdk17.0.4.1' into master - 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large - 8292258: Bump update version for OpenJDK: jdk-17.0.4.1 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/634/files Stats: 308 lines in 11 files changed: 53 ins; 232 del; 23 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/634.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/634/head:pull/634 PR: https://git.openjdk.org/jdk17u-dev/pull/634 From clanger at openjdk.org Tue Aug 16 15:58:06 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 15:58:06 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master [v2] In-Reply-To: References: Message-ID: > Merge changes for jdk-17.0.4.1 from jdk17u Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/634/files - new: https://git.openjdk.org/jdk17u-dev/pull/634/files/cf0abb89..cf0abb89 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=634&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=634&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/634.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/634/head:pull/634 PR: https://git.openjdk.org/jdk17u-dev/pull/634 From iris at openjdk.org Tue Aug 16 15:58:09 2022 From: iris at openjdk.org (Iris Clark) Date: Tue, 16 Aug 2022 15:58:09 GMT Subject: [jdk17u-dev] Withdrawn: Merge jdk17u:master In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 14:18:57 GMT, Christoph Langer wrote: > Merge changes for jdk-17.0.4.1 from jdk17u This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/634 From clanger at openjdk.org Tue Aug 16 15:58:31 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 15:58:31 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge back changes of jdk-11.0.16.1 ------------- Commit messages: - Merge jdk-11.0.16.1 into master - 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large - 8292255: Bump update version for OpenJDK: jdk-11.0.16.1 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/1329/files Stats: 308 lines in 11 files changed: 53 ins; 233 del; 22 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1329.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1329/head:pull/1329 PR: https://git.openjdk.org/jdk11u-dev/pull/1329 From clanger at openjdk.org Tue Aug 16 15:59:46 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 15:59:46 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 14:18:57 GMT, Christoph Langer wrote: > Merge changes for jdk-17.0.4.1 from jdk17u As it could be done by fast forward, I pushed the changes directly. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/634 From cushon at openjdk.org Tue Aug 16 16:48:09 2022 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 16 Aug 2022 16:48:09 GMT Subject: [jdk11u-dev] Integrated: 8247546: Pattern matching does not skip correctly over supplementary characters In-Reply-To: References: Message-ID: On Tue, 9 Aug 2022 02:13:19 GMT, Liam Miller-Cushon wrote: > This is a backport of [JDK-8247546: Pattern matching does not skip correctly over supplementary characters](https://bugs.openjdk.org/browse/JDK-8247546) > > Original patch applied cleanly except for a merge conflict on the `@bug` comment in the test. > > All tier1 tests passed. This pull request has now been integrated. Changeset: 38c632f1 Author: Liam Miller-Cushon Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/38c632f157f1caacd3e98e08b30e818142dea266 Stats: 36 lines in 3 files changed: 28 ins; 0 del; 8 mod 8247546: Pattern matching does not skip correctly over supplementary characters Reviewed-by: clanger Backport-of: 4946a162aa6119416cfdb94b8e3d09200f28d837 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1319 From duke at openjdk.org Tue Aug 16 16:51:36 2022 From: duke at openjdk.org (Salander) Date: Tue, 16 Aug 2022 16:51:36 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 13:34:33 GMT, Christoph Langer wrote: > that's quite a big patch. Can this be made smaller - if the purpose is only to make clang13 work? Renaming the `markOopDesc` class to `markOop` could be reverted which would reduce the diff down to ~58 changed files. Beyond that I'm not sure which changes could be dropped while still fixing the issue. > Furthermore, as this is no full backport of JDK-8229258, I suggest to change the title into just "Allow building with Clang 13" for the time being. I think, if this is ever going to be reviewed and accepted, we'll need to open a specific JBS bug for this, targeting JDK 11. I'll rename it. Not sure if I have the ability to create a JBS account, I did the password reset but didn't receive an email. > I'm also not sure where support for clang13 is needed in the OpenJDK so far. Usually, linux versions are built with gcc. clang is only used on MacOS and AIX but for these OS versions we're not yet at clang version 13, I believe. A few Linux distributions have switched to building with Clang because the end result is significantly smaller package sizes. FreeBSD also builds with clang and had to pin to clang12. > Another hint/requirement: Please enable GitHub Actions on your repository so as to have some basic tier1 acceptance testing for the PR. Will do! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From duke at openjdk.org Tue Aug 16 17:09:24 2022 From: duke at openjdk.org (Dan Lutker) Date: Tue, 16 Aug 2022 17:09:24 GMT Subject: [jdk11u-dev] RFR: 7131823: bug in GIFImageReader [v2] In-Reply-To: <7E7txzeypEU9mAMBOMRZCuXqYZNbg6pIsQcFwwjmbiw=.2d17b087-388e-4844-a705-7b51ae028c4b@github.com> References: <7E7txzeypEU9mAMBOMRZCuXqYZNbg6pIsQcFwwjmbiw=.2d17b087-388e-4844-a705-7b51ae028c4b@github.com> Message-ID: > This is a backport of JDK-7131823: bug in GIFImageReader > > Original patch applied cleanly and all imageio tests pass on linux x64 including the new `javax/imageio/plugins/gif/GIFLargeTableIndexTest.java`. > > Summary: jdk_imageio > TEST STATS: name=jdk_imageio run=196 pass=196 fail=0 > > > All teir1 passed as well. > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1461 1461 0 0 > jtreg:test/jdk:tier1 1874 1874 0 0 > jtreg:test/langtools:tier1 3924 3924 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport a31130fd4056907edcb420761722c629a33273eb ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1317/files - new: https://git.openjdk.org/jdk11u-dev/pull/1317/files/09d25d17..25746e31 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1317&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1317&range=00-01 Stats: 593 lines in 13 files changed: 448 ins; 76 del; 69 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1317.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1317/head:pull/1317 PR: https://git.openjdk.org/jdk11u-dev/pull/1317 From sgehwolf at openjdk.org Tue Aug 16 18:05:28 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 16 Aug 2022 18:05:28 GMT Subject: [jdk17u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: <3W0hlTGt6LNQigWqTs3kSGTs19sgEZKDO_nbVcpS94M=.d02eda48-c3fe-4b48-8c4a-fcdb8b9154ee@github.com> On Fri, 12 Aug 2022 09:20:53 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. @erikj79 @kevinrushforth Would either of you know why we didn't get a `17.0.4.1` backport bug for this? Similar issue to https://github.com/openjdk/jdk11u/pull/49#issuecomment-1214976726 ? ------------- PR: https://git.openjdk.org/jdk17u/pull/350 From duke at openjdk.org Tue Aug 16 18:14:22 2022 From: duke at openjdk.org (Mat Carter) Date: Tue, 16 Aug 2022 18:14:22 GMT Subject: [jdk17u-dev] RFR: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider In-Reply-To: References: Message-ID: <1uMSpRSprkhtI9jHSU5qZ5ayGKhOFpjG-HzES02yCsg=.af993cbb-a63b-4317-8375-c55746c2836e@github.com> On Tue, 16 Aug 2022 07:45:39 GMT, Christoph Langer wrote: >> Backport of 5e5500cbd79b40a32c20547ea0cdb81ef6904a3d >> >> On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges. >> >> "Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc >> >> keystore functionality and API remains unchanged, the local machine keystore types require the manual tests to run in admin mode >> >> Tested on windows, passes tier1 (via GH Actions) and manual tests provided in the patch > > I've approved the backport and can help to sponsor it. Thanks @RealCLanger , much appreciated - @karianna is away this week, I've been helping him through the backport process, can you or I '/integrate" this? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/630 From lancea at openjdk.org Tue Aug 16 18:16:55 2022 From: lancea at openjdk.org (Lance Andersen) Date: Tue, 16 Aug 2022 18:16:55 GMT Subject: [jdk19u] RFR: 8292487: Back out the fix forJDK-8281962 from jdk19u Message-ID: Hi, Please review this PR which reverts the fix for [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) that unfortunately introduced a regression. The fix for the regression is being addressed via [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327). Mach5 tiers 1-3 are currently running. The intent is to give the fix for [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327) more time to bake in the main openjdk workspace (for JDK 20) and in the meantime revert [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) in jdk19u. ------------- Commit messages: - Back out the fix forJDK-8281962 from jdk19u Changes: https://git.openjdk.org/jdk19u/pull/11/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=11&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292487 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk19u/pull/11.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/11/head:pull/11 PR: https://git.openjdk.org/jdk19u/pull/11 From alanb at openjdk.org Tue Aug 16 19:04:57 2022 From: alanb at openjdk.org (Alan Bateman) Date: Tue, 16 Aug 2022 19:04:57 GMT Subject: [jdk19u] RFR: 8292487: Back out the fix forJDK-8281962 from jdk19u In-Reply-To: References: Message-ID: <54vbdMeC7AP0oePtrz32njNr0x4irDOcvpVwwNgkvcA=.df179853-600d-453c-bceb-303d3916040a@github.com> On Tue, 16 Aug 2022 18:09:13 GMT, Lance Andersen wrote: > Hi, > > Please review this PR which reverts the fix for [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) that unfortunately introduced a regression. The fix for the regression is being addressed via [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327). > > Mach5 tiers 1-3 are currently running. > > The intent is to give the fix for [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327) more time to bake in the main openjdk workspace (for JDK 20) and in the meantime revert [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) in jdk19u. Marked as reviewed by alanb (Reviewer). ------------- PR: https://git.openjdk.org/jdk19u/pull/11 From clanger at openjdk.org Tue Aug 16 19:20:27 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 19:20:27 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 16:48:56 GMT, Salander wrote: > > that's quite a big patch. Can this be made smaller - if the purpose is only to make clang13 work? > > Renaming the `markOopDesc` class to `markOop` could be reverted which would reduce the diff down to ~58 changed files. Beyond that I'm not sure which changes could be dropped while still fixing the issue. I think it would be a good start. > > Furthermore, as this is no full backport of JDK-8229258, I suggest to change the title into just "Allow building with Clang 13" for the time being. I think, if this is ever going to be reviewed and accepted, we'll need to open a specific JBS bug for this, targeting JDK 11. > > I'll rename it. Not sure if I have the ability to create a JBS account, I did the password reset but didn't receive an email. If you aren't in the OpenJDK Census, you won't get an account, unless you have made some 3 commits to the OpenJDK. However, I can create a JBS issue for you. > > Another hint/requirement: Please enable GitHub Actions on your repository so as to have some basic tier1 acceptance testing for the PR. > > Will do! Great. And we already see build failures ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From clanger at openjdk.org Tue Aug 16 19:24:36 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 19:24:36 GMT Subject: [jdk17u-dev] RFR: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider In-Reply-To: References: Message-ID: <2IQBeer0O6upCdbmO_fUx2-sUAE6rpR3yIuS4NJIelE=.cd0756a4-61ab-4284-ba41-4cd53e0bc6ce@github.com> On Tue, 16 Aug 2022 07:45:39 GMT, Christoph Langer wrote: >> Backport of 5e5500cbd79b40a32c20547ea0cdb81ef6904a3d >> >> On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges. >> >> "Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc >> >> keystore functionality and API remains unchanged, the local machine keystore types require the manual tests to run in admin mode >> >> Tested on windows, passes tier1 (via GH Actions) and manual tests provided in the patch > > I've approved the backport and can help to sponsor it. > Thanks @RealCLanger , much appreciated - @karianna is away this week, I've been helping him through the backport process, can you or I '/integrate" this? Nope, we'll have to wait. The alternative is that you create another PR with the same content. But I guess it's not a problem since there will be further transports from jdk17u-dev to jdk17u until 30th of August. So it'll hit the October CPU still when you integrate it next week. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/630 From clanger at openjdk.org Tue Aug 16 19:31:22 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 19:31:22 GMT Subject: [jdk19u] RFR: 8292487: Back out the fix forJDK-8281962 from jdk19u In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 18:09:13 GMT, Lance Andersen wrote: > Hi, > > Please review this PR which reverts the fix for [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) that unfortunately introduced a regression. The fix for the regression is being addressed via [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327). > > Mach5 tiers 1-3 are currently running. > > The intent is to give the fix for [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327) more time to bake in the main openjdk workspace (for JDK 20) and in the meantime revert [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) in jdk19u. Hm, as @simonis writes [here](https://bugs.openjdk.org/browse/JDK-8292327?focusedCommentId=14517812&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14517812), wouldn't it make more sense to either back it out from jdk19 or to backport the fix of [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327)? The first one would really play on the safe side and the latter one would help to give some more air to the regression fix. ------------- PR: https://git.openjdk.org/jdk19u/pull/11 From clanger at openjdk.org Tue Aug 16 19:40:18 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 19:40:18 GMT Subject: [jdk11u-dev] RFR: 8214078: (fs) SecureDirectoryStream not supported on arm32 In-Reply-To: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> References: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> Message-ID: On Thu, 11 Aug 2022 14:59:40 GMT, Joshua Cao wrote: > Clean backport. Passes test on our arm32 machine. This one is good for integration. GHA issue on Windows seems unrelated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1322 From clanger at openjdk.org Tue Aug 16 19:41:19 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 19:41:19 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master [v2] In-Reply-To: References: Message-ID: > Merge back changes of jdk-11.0.16.1 Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1329/files - new: https://git.openjdk.org/jdk11u-dev/pull/1329/files/ba804261..ba804261 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1329&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1329&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1329.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1329/head:pull/1329 PR: https://git.openjdk.org/jdk11u-dev/pull/1329 From clanger at openjdk.org Tue Aug 16 19:42:44 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 Aug 2022 19:42:44 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 15:51:52 GMT, Christoph Langer wrote: > Merge back changes of jdk-11.0.16.1 This pull request has now been integrated. Changeset: 44e1ff45 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/44e1ff456bbd527027cbf318c5a02f1ad813209e Stats: 308 lines in 11 files changed: 53 ins; 233 del; 22 mod Merge Merge changes of jdk-11.0.16.1 into jdk11u-dev ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1329 From lancea at openjdk.org Tue Aug 16 20:09:38 2022 From: lancea at openjdk.org (Lance Andersen) Date: Tue, 16 Aug 2022 20:09:38 GMT Subject: [jdk19u] RFR: 8292487: Back out the fix forJDK-8281962 from jdk19u In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 19:27:43 GMT, Christoph Langer wrote: > Hm, as @simonis writes [here](https://bugs.openjdk.org/browse/JDK-8292327?focusedCommentId=14517812&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14517812), wouldn't it make more sense to either back it out from jdk19 or to backport the fix of [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327)? The first one would really play on the safe side and the latter one would help to give some more air to the regression fix. Please see https://github.com/openjdk/jdk/pull/9881#issuecomment-1216417086 for the reasoning why this PR was created and targeted for 19u ------------- PR: https://git.openjdk.org/jdk19u/pull/11 From erikj at openjdk.org Tue Aug 16 20:35:41 2022 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 16 Aug 2022 20:35:41 GMT Subject: [jdk17u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Fri, 12 Aug 2022 09:20:53 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. (I don't currently have any github notifications turned on so tagging me doesn't help) The reason this commit hasn't been notified to JBS is that Skara is currently choking on a tag that was updated/changed in this repo. A fix for that is currently on review in SKARA-1355. I will manually go and get this unstuck for now. ------------- PR: https://git.openjdk.org/jdk17u/pull/350 From duke at openjdk.org Tue Aug 16 22:02:16 2022 From: duke at openjdk.org (Dan Lutker) Date: Tue, 16 Aug 2022 22:02:16 GMT Subject: [jdk11u-dev] Integrated: 7131823: bug in GIFImageReader In-Reply-To: <7E7txzeypEU9mAMBOMRZCuXqYZNbg6pIsQcFwwjmbiw=.2d17b087-388e-4844-a705-7b51ae028c4b@github.com> References: <7E7txzeypEU9mAMBOMRZCuXqYZNbg6pIsQcFwwjmbiw=.2d17b087-388e-4844-a705-7b51ae028c4b@github.com> Message-ID: On Thu, 4 Aug 2022 20:06:16 GMT, Dan Lutker wrote: > This is a backport of JDK-7131823: bug in GIFImageReader > > Original patch applied cleanly and all imageio tests pass on linux x64 including the new `javax/imageio/plugins/gif/GIFLargeTableIndexTest.java`. > > Summary: jdk_imageio > TEST STATS: name=jdk_imageio run=196 pass=196 fail=0 > > > All teir1 passed as well. > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1461 1461 0 0 > jtreg:test/jdk:tier1 1874 1874 0 0 > jtreg:test/langtools:tier1 3924 3924 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS This pull request has now been integrated. Changeset: faf1f86f Author: Dan Lutker Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/faf1f86f95117a5e2a0d52b67647dee893311545 Stats: 175 lines in 2 files changed: 158 ins; 4 del; 13 mod 7131823: bug in GIFImageReader Backport-of: a31130fd4056907edcb420761722c629a33273eb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1317 From jiefu at openjdk.org Wed Aug 17 02:17:36 2022 From: jiefu at openjdk.org (Jie Fu) Date: Wed, 17 Aug 2022 02:17:36 GMT Subject: [jdk17u-dev] RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode In-Reply-To: <53DWujVgVMM7OnjDpKh4Ms7VXff36qITY-GkfBPiycg=.01d3b95b-98a9-4afd-8934-cb156086db98@github.com> References: <53DWujVgVMM7OnjDpKh4Ms7VXff36qITY-GkfBPiycg=.01d3b95b-98a9-4afd-8934-cb156086db98@github.com> Message-ID: On Tue, 16 Aug 2022 12:33:42 GMT, xpbob wrote: > Backport a625bfdba45d49bc717bcc9be4112db93b50f50a Fix request had been approved. So integrate it. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/633 From duke at openjdk.org Wed Aug 17 02:17:36 2022 From: duke at openjdk.org (xpbob) Date: Wed, 17 Aug 2022 02:17:36 GMT Subject: [jdk17u-dev] Integrated: 8283903: GetContainerCpuLoad does not return the correct result in share mode In-Reply-To: <53DWujVgVMM7OnjDpKh4Ms7VXff36qITY-GkfBPiycg=.01d3b95b-98a9-4afd-8934-cb156086db98@github.com> References: <53DWujVgVMM7OnjDpKh4Ms7VXff36qITY-GkfBPiycg=.01d3b95b-98a9-4afd-8934-cb156086db98@github.com> Message-ID: On Tue, 16 Aug 2022 12:33:42 GMT, xpbob wrote: > Backport a625bfdba45d49bc717bcc9be4112db93b50f50a This pull request has now been integrated. Changeset: 2c988d18 Author: bobpengxie Committer: Jie Fu URL: https://git.openjdk.org/jdk17u-dev/commit/2c988d184291c4200659ee0e1e68294460c685d3 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8283903: GetContainerCpuLoad does not return the correct result in share mode Backport-of: a625bfdba45d49bc717bcc9be4112db93b50f50a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/633 From clanger at openjdk.org Wed Aug 17 05:28:12 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 17 Aug 2022 05:28:12 GMT Subject: [jdk17u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Fri, 12 Aug 2022 09:20:53 GMT, Severin Gehwolf wrote: > PR to backout the change of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). I'll change this to the proper backport title once JDK 19 backout is done. Thanks. I already thought, force-pushing the tag would cause trouble somehwere. But it seems like in this case it helps to get the tooling more robust ? One other thing I noted: The backport for 17.0.4.1 now mentions "Resolved in build: master". However, the b01 tag was already set, so it should be b01. Is that an expected outcome due to working on another branch in the repo? Or because 17.0.5 tags are already in place as well? ------------- PR: https://git.openjdk.org/jdk17u/pull/350 From clanger at openjdk.org Wed Aug 17 05:29:43 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 17 Aug 2022 05:29:43 GMT Subject: [jdk19u] RFR: 8292487: Back out the fix forJDK-8281962 from jdk19u In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 18:09:13 GMT, Lance Andersen wrote: > Hi, > > Please review this PR which reverts the fix for [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) that unfortunately introduced a regression. The fix for the regression is being addressed via [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327). > > Mach5 tiers 1-3 are currently running. > > The intent is to give the fix for [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327) more time to bake in the main openjdk workspace (for JDK 20) and in the meantime revert [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) in jdk19u. > > Hm, as @simonis writes [here](https://bugs.openjdk.org/browse/JDK-8292327?focusedCommentId=14517812&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14517812), wouldn't it make more sense to either back it out from jdk19 or to backport the fix of [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327)? The first one would really play on the safe side and the latter one would help to give some more air to the regression fix. > > Please see [openjdk/jdk#9881 (comment)](https://github.com/openjdk/jdk/pull/9881#issuecomment-1216417086) for the reasoning why this PR was created and targeted for 19u OK. So be it then. ? ------------- PR: https://git.openjdk.org/jdk19u/pull/11 From duke at openjdk.org Wed Aug 17 06:04:32 2022 From: duke at openjdk.org (duke) Date: Wed, 17 Aug 2022 06:04:32 GMT Subject: [jdk11u-dev] Withdrawn: 8287113: JFR: Periodic task thread uses period for method sampling events In-Reply-To: References: Message-ID: On Thu, 26 May 2022 12:41:34 GMT, Jaroslav Bachorik wrote: > Mostly clean backport. > The only conflict was due to the 'largeSize' field in `PlatformEventType` class which is not available in JDK 11. > The conflict is resolved in a separate commit for easier review. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1110 From christoph.langer at sap.com Wed Aug 17 06:13:17 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 17 Aug 2022 06:13:17 +0000 Subject: [11u, 17u] Maintainer notification: 11.0.16.1 and 17.0.4.1 releases tagged Message-ID: Hi, OpenJDK Update releases 11.0.16.1 and 17.0.4.1, based on 11.0.16 and 17.0.4 and containing a backout of JDK-8279219 have been created. The backout bug is JDK-8292260 [0]. The backout has been transported to the master branches as well. You will find the according jdk release tags in the repositories. Best regards Christoph [0] https://bugs.openjdk.org/browse/JDK-8292260 -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Wed Aug 17 06:30:40 2022 From: duke at openjdk.org (duke) Date: Wed, 17 Aug 2022 06:30:40 GMT Subject: [jdk18u] Withdrawn: 8283457: [macos] libpng build failures with Xcode13.3 In-Reply-To: References: Message-ID: On Tue, 21 Jun 2022 20:49:19 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [33eb89df](https://github.com/openjdk/jdk/commit/33eb89dfeb4a43e1ad2c3dd657ec3b6ee7abbb3a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Phil Race on 22 Mar 2022 and was reviewed by Erik Joelsson. > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk18u/pull/174 From serb at openjdk.org Wed Aug 17 06:37:13 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 17 Aug 2022 06:37:13 GMT Subject: [jdk18u] RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2] In-Reply-To: <9asiWdvOqxpobN4kGz1WLhSA4UVs0qytlUZji-ZLgMY=.7298da47-f9e7-4cf5-91e0-36bab6a2018a@github.com> References: <9asiWdvOqxpobN4kGz1WLhSA4UVs0qytlUZji-ZLgMY=.7298da47-f9e7-4cf5-91e0-36bab6a2018a@github.com> Message-ID: > Hi all, > This pull request contains a backport of commit [50d47de8](https://github.com/openjdk/jdk/commit/50d47de8358e2f22bf3a4a165d660c25ef6eacbc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen. > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk18u/pull/175/files - new: https://git.openjdk.org/jdk18u/pull/175/files/1ed6354c..1ed6354c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk18u&pr=175&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk18u&pr=175&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk18u/pull/175.diff Fetch: git fetch https://git.openjdk.org/jdk18u pull/175/head:pull/175 PR: https://git.openjdk.org/jdk18u/pull/175 From mbaesken at openjdk.org Wed Aug 17 07:00:16 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Aug 2022 07:00:16 GMT Subject: [jdk17u-dev] Integrated: 8289910: unify os::message_box across posix platforms In-Reply-To: References: Message-ID: On Wed, 10 Aug 2022 11:37:40 GMT, Matthias Baesken wrote: > 8289910: unify os::message_box across posix platforms This pull request has now been integrated. Changeset: cb294d9e Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/cb294d9ecf0767dbd0dd167222e1e7861e28be3b Stats: 77 lines in 4 files changed: 20 ins; 57 del; 0 mod 8289910: unify os::message_box across posix platforms Backport-of: e5491a2605177a9dca87a060d99aa5ea4fd4a239 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/629 From mbaesken at openjdk.org Wed Aug 17 07:00:37 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Aug 2022 07:00:37 GMT Subject: [jdk17u-dev] Integrated: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr In-Reply-To: References: Message-ID: <3Va5hsi5ULa1VLfBIP-56O2xkIqDFCEtRGzp9xKyapA=.4c99b3b1-fa73-4c86-9aee-8940d56c657f@github.com> On Fri, 12 Aug 2022 09:10:27 GMT, Matthias Baesken wrote: > 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr This pull request has now been integrated. Changeset: 92571e34 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/92571e346582fe359a211eca0a8869ae96ee58f7 Stats: 16 lines in 6 files changed: 0 ins; 0 del; 16 mod 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr Backport-of: c89556f6cd4d0b64f3e9e2f1dc7c51634522f205 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/632 From mbaesken at openjdk.org Wed Aug 17 07:04:23 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Aug 2022 07:04:23 GMT Subject: [jdk17u-dev] Integrated: 8285730: unify _WIN32_WINNT settings In-Reply-To: <_qoTH7R4tqEY1WreH9Sa1Pk6JcnhgkFnwKS5gBKB9uQ=.5401cf5a-66aa-4fc1-a3eb-a36bdb2781ea@github.com> References: <_qoTH7R4tqEY1WreH9Sa1Pk6JcnhgkFnwKS5gBKB9uQ=.5401cf5a-66aa-4fc1-a3eb-a36bdb2781ea@github.com> Message-ID: On Wed, 10 Aug 2022 11:04:11 GMT, Matthias Baesken wrote: > 8285730: unify _WIN32_WINNT settings This pull request has now been integrated. Changeset: e650bdcd Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/e650bdcde02cb9781d073dd0ba003025e80b7a5c Stats: 33 lines in 7 files changed: 2 ins; 25 del; 6 mod 8285730: unify _WIN32_WINNT settings Backport-of: 4fd79a6ad2683e4863bd4e311cb01cbc30ebf57f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/628 From abakhtin at openjdk.org Wed Aug 17 09:29:16 2022 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 17 Aug 2022 09:29:16 GMT Subject: [jdk13u-dev] RFR: 8269039: Disable SHA-1 Signed JARs Message-ID: <2G5qNmM6gyECJifiJpeqKX_FcuNn5BGdD69zUOvhEGA=.7fa129f8-3da0-4b2a-9711-627e09627581@github.com> Backport from JDK18 is not applied clean, resolved with help o JDK11 patch: - src/java.base/share/conf/security/java.security - is not applied clean because 13 mentions "include jdk.disabled.namedCurves" added by JDK-8233228 - src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java - Some hunks did not apply because DISABLED_CHECK was renamed to JAR_DISABLED_CHECK in 17 by JDK-8266225. - Other hunks patch methods not in 13: checkWeakKey(), checkWeakAlg() as well as the calls to these methods. - test/jdk/java/security/Security/signedfirst/Dyn.sh and test/jdk/java/security/Security/signedfirst/Static.sh - Deleting did not apply because of SunOS declaration. - JAR files changes are not applied, copied from JDK11 - test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java - Patch skipped, test not in 13. - test/jdk/sun/security/tools/jarsigner/TimestampCheck.java - Resolved using JDK11 patch. - test/lib/jdk/test/lib/security/SecurityUtils.java - The change to this file was already backported. All sun/security/tools/jarsigner java/security/Security/signedfirst tests passed ------------- Commit messages: - Fixed trailing witespace - Backport 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7 Changes: https://git.openjdk.org/jdk13u-dev/pull/389/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=389&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269039 Stats: 630 lines in 25 files changed: 300 ins; 214 del; 116 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/389.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/389/head:pull/389 PR: https://git.openjdk.org/jdk13u-dev/pull/389 From roland at openjdk.org Wed Aug 17 09:34:40 2022 From: roland at openjdk.org (Roland Westrelin) Date: Wed, 17 Aug 2022 09:34:40 GMT Subject: [jdk17u-dev] Integrated: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible In-Reply-To: <41HJgW_gQkSJU135pyxzRauhs6soI5z7AwzRRBa6kq0=.449fb93b-a8ac-4c60-b389-9ea680322152@github.com> References: <41HJgW_gQkSJU135pyxzRauhs6soI5z7AwzRRBa6kq0=.449fb93b-a8ac-4c60-b389-9ea680322152@github.com> Message-ID: On Thu, 21 Jul 2022 15:50:26 GMT, Roland Westrelin wrote: > clean backport to jdk17u-dev This pull request has now been integrated. Changeset: 38fdbd43 Author: Roland Westrelin URL: https://git.openjdk.org/jdk17u-dev/commit/38fdbd43564f7a8de74fa701c856e923bdb3fca7 Stats: 86 lines in 2 files changed: 83 ins; 0 del; 3 mod 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible Backport-of: 4f3f74c14121d0a80f0dcf1d593b4cf1c3e4a64c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/579 From simonis at openjdk.org Wed Aug 17 09:40:31 2022 From: simonis at openjdk.org (Volker Simonis) Date: Wed, 17 Aug 2022 09:40:31 GMT Subject: [jdk19u] RFR: 8292487: Back out the fix forJDK-8281962 from jdk19u In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 18:09:13 GMT, Lance Andersen wrote: > Hi, > > Please review this PR which reverts the fix for [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) that unfortunately introduced a regression. The fix for the regression is being addressed via [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327). > > Mach5 tiers 1-3 are currently running. > > The intent is to give the fix for [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327) more time to bake in the main openjdk workspace (for JDK 20) and in the meantime revert [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) in jdk19u. I tend to agree with @RealCLanger for the [reasons outlined in my JBS comment](https://bugs.openjdk.org/browse/JDK-8292327?focusedCommentId=14517812&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14517812) but in the end it's your decision. Back out looks good. ------------- Marked as reviewed by simonis (Reviewer). PR: https://git.openjdk.org/jdk19u/pull/11 From sgehwolf at openjdk.org Wed Aug 17 10:01:49 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 17 Aug 2022 10:01:49 GMT Subject: [jdk17u] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Wed, 17 Aug 2022 05:24:56 GMT, Christoph Langer wrote: > One other thing I noted: The backport for 17.0.4.1 now mentions "Resolved in build: master". However, the b01 tag was already set, so it should be b01. Fixed this manually. Still interested to hear why that didn't work. ------------- PR: https://git.openjdk.org/jdk17u/pull/350 From alanb at openjdk.org Wed Aug 17 12:08:33 2022 From: alanb at openjdk.org (Alan Bateman) Date: Wed, 17 Aug 2022 12:08:33 GMT Subject: [jdk19u] RFR: 8292487: Back out the fix forJDK-8281962 from jdk19u In-Reply-To: References: Message-ID: <4NJxwgRoebuv4_S4Du2WYXXF9Q6_UYz0R2uzPixdpHg=.6bd8426c-8e1a-49a1-812c-285489d950ab@github.com> On Tue, 16 Aug 2022 18:09:13 GMT, Lance Andersen wrote: > Hi, > > Please review this PR which reverts the fix for [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) that unfortunately introduced a regression. The fix for the regression is being addressed via [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327). > > Mach5 tiers 1-3 are currently running. > > The intent is to give the fix for [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327) more time to bake in the main openjdk workspace (for JDK 20) and in the meantime revert [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) in jdk19u. The timing is unfortunate. If this issue has been reported a week or two earlier then we may have been able to do something for JDK 19. The 19.0.1 release is about a month after 19 GA so the regression will be short lived (assuming it gets approved for 19.0.1 of course). ------------- PR: https://git.openjdk.org/jdk19u/pull/11 From yan at openjdk.org Wed Aug 17 12:58:23 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 17 Aug 2022 12:58:23 GMT Subject: [jdk13u-dev] RFR: 8269039: Disable SHA-1 Signed JARs In-Reply-To: <2G5qNmM6gyECJifiJpeqKX_FcuNn5BGdD69zUOvhEGA=.7fa129f8-3da0-4b2a-9711-627e09627581@github.com> References: <2G5qNmM6gyECJifiJpeqKX_FcuNn5BGdD69zUOvhEGA=.7fa129f8-3da0-4b2a-9711-627e09627581@github.com> Message-ID: <2tbS585wqXSDXpNbuttKbn9ILe3PRhCrEeoyA8Qn7M8=.b19e0d80-0804-4ea0-8fa1-27cc74b0a591@github.com> On Tue, 16 Aug 2022 16:28:33 GMT, Alexey Bakhtin wrote: > Backport from JDK18 is not applied clean, resolved with help o JDK11 patch: > - src/java.base/share/conf/security/java.security > > - is not applied clean because 13 mentions "include jdk.disabled.namedCurves" added by JDK-8233228 > - src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java > > - Some hunks did not apply because DISABLED_CHECK was renamed > to JAR_DISABLED_CHECK in 17 by JDK-8266225. > > - Other hunks patch methods not in 13: checkWeakKey(), checkWeakAlg() > as well as the calls to these methods. > - test/jdk/java/security/Security/signedfirst/Dyn.sh > and test/jdk/java/security/Security/signedfirst/Static.sh > > - Deleting did not apply because of SunOS declaration. > - JAR files changes are not applied, copied from JDK11 > - test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java > - > Patch skipped, test not in 13. > - test/jdk/sun/security/tools/jarsigner/TimestampCheck.java > > - Resolved using JDK11 patch. > - test/lib/jdk/test/lib/security/SecurityUtils.java > > - The change to this file was already backported. > > All sun/security/tools/jarsigner java/security/Security/signedfirst tests passed Marked as reviewed by yan (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/389 From adinn at openjdk.org Wed Aug 17 13:41:43 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Wed, 17 Aug 2022 13:41:43 GMT Subject: [jdk17u-dev] RFR: 8256811: Delayed/missed jdwp class unloading events Message-ID: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> Backport of patch to fix class unloading event notification. This backport was originally developed by @zhengyu123 and involved some minor changes to the original patch. n.b. the original patch required a follow up fix (cf JDK-8290908) which also needs backporting after this has been included. ------------- Commit messages: - Backport 54854d9300479c22c416fd9d2fdb5c29fc1884bc Changes: https://git.openjdk.org/jdk17u-dev/pull/635/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=635&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256811 Stats: 495 lines in 12 files changed: 254 ins; 147 del; 94 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/635.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/635/head:pull/635 PR: https://git.openjdk.org/jdk17u-dev/pull/635 From adinn at openjdk.org Wed Aug 17 16:03:07 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Wed, 17 Aug 2022 16:03:07 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM Message-ID: Backport of follow up fix to correct JCK failure after 8256811. The backport involved minor adjustment of the original patch to allow for interbening changes. This backport is dependent on prior backport of JDK-8256811 ------------- Commit messages: - 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM - Backport 54854d9300479c22c416fd9d2fdb5c29fc1884bc Changes: https://git.openjdk.org/jdk17u-dev/pull/636/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=636&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290908 Stats: 503 lines in 13 files changed: 258 ins; 151 del; 94 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/636.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/636/head:pull/636 PR: https://git.openjdk.org/jdk17u-dev/pull/636 From sgehwolf at openjdk.org Wed Aug 17 16:23:44 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 17 Aug 2022 16:23:44 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM In-Reply-To: References: Message-ID: <1FrGx8xtItVZ9TBlsNKBF4-pxHfpZKKdS2GCTKafb-c=.71775d46-ac67-4fe6-8947-38ff23be103a@github.com> On Wed, 17 Aug 2022 15:54:39 GMT, Andrew Dinn wrote: > Backport of follow up fix to correct JCK failure after 8256811. > > The backport involved minor adjustment of the original patch to allow for interbening changes. > > This backport is dependent on prior backport of JDK-8256811 @adinn Please use PR title `Backport 0ae834105740f7cf73fe96be22e0f564ad29b18d` as we know the sha of the mainline patch. Please also target branch `pr/635` over `master` since that's the PR this depends on (uses the depending pull requests feature). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/636 From clanger at openjdk.org Wed Aug 17 17:30:33 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 17 Aug 2022 17:30:33 GMT Subject: [jdk17u-dev] RFR: 8256811: Delayed/missed jdwp class unloading events In-Reply-To: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> References: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> Message-ID: On Wed, 17 Aug 2022 13:24:49 GMT, Andrew Dinn wrote: > Backport of patch to fix class unloading event notification. > > This backport was originally developed by @zhengyu123 and involved some minor changes to the original patch. > > n.b. the original patch required a follow up fix (cf JDK-8290908) which also needs backporting after this has been included. @adinn: could you please enable GitHub actions on your repository and trigger a run via the workflow-dispatch event? Same goes for #636. Thanks! You might as well merge master into your branch and push it after you've enabled GHA. Then we'll get the run automatically. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/635 From phh at openjdk.org Wed Aug 17 17:49:35 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 17 Aug 2022 17:49:35 GMT Subject: [jdk17u-dev] RFR: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 In-Reply-To: References: Message-ID: <7dJhelNFdGY4uSk-9Jz6xXJ5uyBi778wJWLUd6qrGHo=.5d0e87c0-21cc-4b90-b8ba-b71704ca530b@github.com> On Thu, 11 Aug 2022 05:03:08 GMT, Joshua Cao wrote: > clean backport Tagged the issue on behalf of Josh. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/631 From zgu at openjdk.org Wed Aug 17 18:44:38 2022 From: zgu at openjdk.org (Zhengyu Gu) Date: Wed, 17 Aug 2022 18:44:38 GMT Subject: [jdk17u-dev] RFR: 8256811: Delayed/missed jdwp class unloading events In-Reply-To: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> References: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> Message-ID: On Wed, 17 Aug 2022 13:24:49 GMT, Andrew Dinn wrote: > Backport of patch to fix class unloading event notification. > > This backport was originally developed by @zhengyu123 and involved some minor changes to the original patch. > > n.b. the original patch required a follow up fix (cf JDK-8290908) which also needs backporting after this has been included. This fix results a couple of followup CRs: JDK-8290908 and JDK-8291456. JDK-8291456 has yet been resolved, probably this backport should wait till JDK-8291456 is resolved. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/635 From abakhtin at openjdk.org Wed Aug 17 20:32:27 2022 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 17 Aug 2022 20:32:27 GMT Subject: [jdk13u-dev] Integrated: 8269039: Disable SHA-1 Signed JARs In-Reply-To: <2G5qNmM6gyECJifiJpeqKX_FcuNn5BGdD69zUOvhEGA=.7fa129f8-3da0-4b2a-9711-627e09627581@github.com> References: <2G5qNmM6gyECJifiJpeqKX_FcuNn5BGdD69zUOvhEGA=.7fa129f8-3da0-4b2a-9711-627e09627581@github.com> Message-ID: <7EvQl063XKL5Gu1Nu5mVbexwMfNYXKBhlVsHY8wCK4Y=.7995fdd6-533c-4801-8695-6cf08b5fed23@github.com> On Tue, 16 Aug 2022 16:28:33 GMT, Alexey Bakhtin wrote: > Backport from JDK18 is not applied clean, resolved with help o JDK11 patch: > - src/java.base/share/conf/security/java.security > > - is not applied clean because 13 mentions "include jdk.disabled.namedCurves" added by JDK-8233228 > - src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java > > - Some hunks did not apply because DISABLED_CHECK was renamed > to JAR_DISABLED_CHECK in 17 by JDK-8266225. > > - Other hunks patch methods not in 13: checkWeakKey(), checkWeakAlg() > as well as the calls to these methods. > - test/jdk/java/security/Security/signedfirst/Dyn.sh > and test/jdk/java/security/Security/signedfirst/Static.sh > > - Deleting did not apply because of SunOS declaration. > - JAR files changes are not applied, copied from JDK11 > - test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java > - > Patch skipped, test not in 13. > - test/jdk/sun/security/tools/jarsigner/TimestampCheck.java > > - Resolved using JDK11 patch. > - test/lib/jdk/test/lib/security/SecurityUtils.java > > - The change to this file was already backported. > > All sun/security/tools/jarsigner java/security/Security/signedfirst tests passed This pull request has now been integrated. Changeset: 79497f63 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk13u-dev/commit/79497f637a40ae41d8d5ea27e60b224172f28b23 Stats: 630 lines in 25 files changed: 300 ins; 214 del; 116 mod 8269039: Disable SHA-1 Signed JARs Reviewed-by: yan Backport-of: 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/389 From wkemper at openjdk.org Wed Aug 17 20:44:50 2022 From: wkemper at openjdk.org (William Kemper) Date: Wed, 17 Aug 2022 20:44:50 GMT Subject: [jdk11u-dev] Integrated: 8252145: Unify Info.plist files with correct version strings In-Reply-To: References: Message-ID: On Fri, 12 Aug 2022 22:23:24 GMT, William Kemper wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8252145. Backport ticket is https://bugs.openjdk.org/browse/JDK-8292307. The Skara bot said this was not a clean backport: https://github.com/openjdk/jdk/commit/7df86108cb42079df8ade07b4d07587c1f0cbe83#commitcomment-81065611, but it was clean for me when I performed it locally. This pull request has now been integrated. Changeset: 3db29c40 Author: William Kemper Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/3db29c409d46ea0377c237a07bacb7026f7987dc Stats: 144 lines in 9 files changed: 70 ins; 53 del; 21 mod 8252145: Unify Info.plist files with correct version strings Reviewed-by: phh Backport-of: 7df86108cb42079df8ade07b4d07587c1f0cbe83 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1323 From duke at openjdk.org Wed Aug 17 21:00:31 2022 From: duke at openjdk.org (Joshua Cao) Date: Wed, 17 Aug 2022 21:00:31 GMT Subject: [jdk11u-dev] Integrated: 8214078: (fs) SecureDirectoryStream not supported on arm32 In-Reply-To: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> References: <30_4TP9CwMYFrkTDRTcg1KchtVQFhrgiZvSiYD4ttqg=.d41fafdf-04b9-4193-85e5-eab2873a304d@github.com> Message-ID: On Thu, 11 Aug 2022 14:59:40 GMT, Joshua Cao wrote: > Clean backport. Passes test on our arm32 machine. This pull request has now been integrated. Changeset: 58076db0 Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/58076db0c1f923127ca76f29eab50f1aa3a9f4e8 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod 8214078: (fs) SecureDirectoryStream not supported on arm32 Reviewed-by: phh Backport-of: 10cd386ac3508c19bd4e7202a8b07e03dcc0462b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1322 From duke at openjdk.org Wed Aug 17 21:01:13 2022 From: duke at openjdk.org (Joshua Cao) Date: Wed, 17 Aug 2022 21:01:13 GMT Subject: [jdk11u-dev] Integrated: 8251152: ARM32: jtreg c2 Test8202414 test crash In-Reply-To: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> References: <6vCb5OgKMAL8lP64kvFt03-ZU7OXOeyavDHwrIh8ze0=.35252e8c-c5c1-40b2-a82d-7576a26e5c62@github.com> Message-ID: On Thu, 11 Aug 2022 04:39:05 GMT, Joshua Cao wrote: > Backport of 8251152: ARM32: jtreg c2 Test8202414 test crash > > Backport is not clean because JDK 11 does not include [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > The patch removed the `@requires` line, but the line is present in JDK 11. > > > * @test > * @bug 8202414 > * @summary Unsafe write after primitive array creation may result in array length change > * @requires (os.arch != "sparc") & (os.arch != "sparcv9") > * @run main/othervm compiler.c2.Test8202414 > > > Manual fix is trivial. We just paste the new lines under the `@requires` line This pull request has now been integrated. Changeset: ad2e6e4d Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/ad2e6e4d2526f036a5525913fd529c9a5cf12f0c Stats: 15 lines in 2 files changed: 11 ins; 1 del; 3 mod 8251152: ARM32: jtreg c2 Test8202414 test crash Some CPUs (like ARM32) does not support unaligned memory accesses. To avoid JVM crashes tests that perform such accesses should be skipped on corresponding platforms. Reviewed-by: phh Backport-of: 70d5cac961db663f96223bd9efbc8b5ca77cc88a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1321 From duke at openjdk.org Wed Aug 17 22:52:30 2022 From: duke at openjdk.org (Joshua Cao) Date: Wed, 17 Aug 2022 22:52:30 GMT Subject: [jdk17u-dev] Integrated: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 In-Reply-To: References: Message-ID: On Thu, 11 Aug 2022 05:03:08 GMT, Joshua Cao wrote: > clean backport This pull request has now been integrated. Changeset: 129484da Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/129484da3bd5ae1053b9275b7c706e908003e0b8 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Reviewed-by: phh Backport-of: 928e34773694dda5373027848a3363887bcaf4f4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/631 From phh at openjdk.org Wed Aug 17 23:38:22 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 17 Aug 2022 23:38:22 GMT Subject: [jdk11u-dev] RFR: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 15:04:25 GMT, Joshua Cao wrote: > clean backport. Primary motivation for this backport is that this patch is a dependency of [8242188](https://bugs.openjdk.org/browse/JDK-8242188), which fixes a JFR test bug. Opening a separate PR for that. Pre-submit failures appear unrelated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1326 From phh at openjdk.org Wed Aug 17 23:49:23 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 17 Aug 2022 23:49:23 GMT Subject: [jdk11u-dev] RFR: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 15:04:25 GMT, Joshua Cao wrote: > clean backport. Primary motivation for this backport is that this patch is a dependency of [8242188](https://bugs.openjdk.org/browse/JDK-8242188), which fixes a JFR test bug. Opening a separate PR for that. Do the updated tests run correctly? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1326 From duke at openjdk.org Wed Aug 17 23:58:12 2022 From: duke at openjdk.org (Joshua Cao) Date: Wed, 17 Aug 2022 23:58:12 GMT Subject: [jdk11u-dev] RFR: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package In-Reply-To: References: Message-ID: <256rseVqN6y-a4YNEES8qNZYeL5CnNnozsByle0vIb0=.34835932-464b-4e95-a9f5-0244bad1a988@github.com> On Mon, 15 Aug 2022 15:04:25 GMT, Joshua Cao wrote: > clean backport. Primary motivation for this backport is that this patch is a dependency of [8242188](https://bugs.openjdk.org/browse/JDK-8242188), which fixes a JFR test bug. Opening a separate PR for that. All tests updated by this PR are passing. With the addition of https://github.com/openjdk/jdk11u-dev/pull/1327, we also pass TestRecordedFrame.java. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1326 From phh at openjdk.org Wed Aug 17 23:58:25 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 17 Aug 2022 23:58:25 GMT Subject: [jdk11u-dev] RFR: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 In-Reply-To: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> References: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> Message-ID: On Mon, 15 Aug 2022 15:20:01 GMT, Joshua Cao wrote: > clean backport after https://github.com/openjdk/jdk11u-dev/pull/1326 JBS issue tagged. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1327 From phh at openjdk.org Wed Aug 17 23:58:13 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 17 Aug 2022 23:58:13 GMT Subject: [jdk11u-dev] RFR: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package In-Reply-To: References: Message-ID: <1q5wsZpz0k3lbBRvyWNlsPu1hxKU6xXdmLhY0ysUJyg=.c1b9090c-cb33-479c-a58b-1b957be29484@github.com> On Mon, 15 Aug 2022 15:04:25 GMT, Joshua Cao wrote: > clean backport. Primary motivation for this backport is that this patch is a dependency of [8242188](https://bugs.openjdk.org/browse/JDK-8242188), which fixes a JFR test bug. Opening a separate PR for that. JBS issue tagged. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1326 From phh at openjdk.org Thu Aug 18 00:06:18 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 18 Aug 2022 00:06:18 GMT Subject: [jdk11u-dev] RFR: 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation In-Reply-To: References: Message-ID: On Sat, 13 Aug 2022 15:21:45 GMT, Joshua Cao wrote: > clean backport. passes TestJFRIntrinsic.java on our systems. Tagged JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1325 From phh at openjdk.org Thu Aug 18 00:12:14 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 18 Aug 2022 00:12:14 GMT Subject: [jdk11u-dev] RFR: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl In-Reply-To: <8jaja33KPI1g6HibPgr2niFR_PMG35dT12Te01q-cgY=.887e4cd0-3986-4fb6-a0ca-8871bc44485a@github.com> References: <8jaja33KPI1g6HibPgr2niFR_PMG35dT12Te01q-cgY=.887e4cd0-3986-4fb6-a0ca-8871bc44485a@github.com> Message-ID: <0bdCm22BjpwyDEXYsWAfnf5KlFxW5GZUG2i5aYfBk5U=.a7e2efd7-c5bd-4b7a-b804-6b2486308925@github.com> On Sat, 13 Aug 2022 15:07:40 GMT, Joshua Cao wrote: > Not a clean backport since surrounding lines are different, but changes are simple enough. This change passes ProcessBuilder/Basic.java jtreg test on our Alpine systems. Tagged JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1324 From duke at openjdk.org Thu Aug 18 02:39:57 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 18 Aug 2022 02:39:57 GMT Subject: [jdk11u-dev] RFR: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Message-ID: clean backport ------------- Commit messages: - 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Changes: https://git.openjdk.org/jdk11u-dev/pull/1331/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1331&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279032 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1331.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1331/head:pull/1331 PR: https://git.openjdk.org/jdk11u-dev/pull/1331 From duke at openjdk.org Thu Aug 18 03:08:51 2022 From: duke at openjdk.org (xpbob) Date: Thu, 18 Aug 2022 03:08:51 GMT Subject: [jdk11u-dev] RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode Message-ID: Backport a625bfdba45d49bc717bcc9be4112db93b50f50a ------------- Commit messages: - Backport a625bfdba45d49bc717bcc9be4112db93b50f50a Changes: https://git.openjdk.org/jdk11u-dev/pull/1332/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1332&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283903 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1332.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1332/head:pull/1332 PR: https://git.openjdk.org/jdk11u-dev/pull/1332 From clanger at openjdk.org Thu Aug 18 06:17:15 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 18 Aug 2022 06:17:15 GMT Subject: [jdk11u-dev] RFR: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 15:04:25 GMT, Joshua Cao wrote: > clean backport. Primary motivation for this backport is that this patch is a dependency of [8242188](https://bugs.openjdk.org/browse/JDK-8242188), which fixes a JFR test bug. Opening a separate PR for that. GHA failures seem unrelated infrastructure problems. @caojoshua For the next time: Please only integrate after the appropriate jdk*u-fix-yes label was set in JBS. I'll approve the backport now, so: ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1326 From duke at openjdk.org Thu Aug 18 06:19:44 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 18 Aug 2022 06:19:44 GMT Subject: [jdk11u-dev] Integrated: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package In-Reply-To: References: Message-ID: On Mon, 15 Aug 2022 15:04:25 GMT, Joshua Cao wrote: > clean backport. Primary motivation for this backport is that this patch is a dependency of [8242188](https://bugs.openjdk.org/browse/JDK-8242188), which fixes a JFR test bug. Opening a separate PR for that. This pull request has now been integrated. Changeset: a77dd697 Author: Joshua Cao Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/a77dd69747137561bfe67a42dd49c319e333aeb6 Stats: 557 lines in 18 files changed: 127 ins; 157 del; 273 mod 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package Backport-of: f75f78ae3a24d958088b1086861bb1149f3209ac ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1326 From duke at openjdk.org Thu Aug 18 06:24:18 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 18 Aug 2022 06:24:18 GMT Subject: [jdk11u-dev] RFR: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 [v2] In-Reply-To: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> References: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> Message-ID: <9s1AwWZG170Ti7v2B10ZLQJnRUbCppQi-kWVHGPlXlM=.cc01820a-fc77-4b59-900a-81da6e0d579f@github.com> > clean backport after https://github.com/openjdk/jdk11u-dev/pull/1326 Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1327/files - new: https://git.openjdk.org/jdk11u-dev/pull/1327/files/31d983e2..31d983e2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1327&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1327&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1327.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1327/head:pull/1327 PR: https://git.openjdk.org/jdk11u-dev/pull/1327 From jvanek at openjdk.org Thu Aug 18 08:14:41 2022 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 18 Aug 2022 08:14:41 GMT Subject: [jdk17u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: <8aRkbC8QCLLeJHnt2XRQFct95hSW7aUNLOyCCr9tv7A=.33f8e0bf-d0c8-4c5e-8734-6b3f5e5b450f@github.com> On Fri, 15 Jul 2022 12:07:31 GMT, Ji?? Van?k wrote: > 8282947: JFR: Dump on shutdown live-locks in some conditions ping please? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/555 From adinn at openjdk.org Thu Aug 18 09:23:36 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 09:23:36 GMT Subject: [jdk17u-dev] RFR: 8256811: Delayed/missed jdwp class unloading events In-Reply-To: References: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> Message-ID: On Wed, 17 Aug 2022 17:27:01 GMT, Christoph Langer wrote: >> Backport of patch to fix class unloading event notification. >> >> This backport was originally developed by @zhengyu123 and involved some minor changes to the original patch. >> >> n.b. the original patch required a follow up fix (cf JDK-8290908) which also needs backporting after this has been included. > > @adinn: could you please enable GitHub actions on your repository and trigger a run via the workflow-dispatch event? Same goes for #636. Thanks! > > You might as well merge master into your branch and push it after you've enabled GHA. Then we'll get the run automatically. @RealCLanger The settings for my repo look like they already enable actions. Under Actions/General/Actions Permissions the radio button is selected for Allow all actions and reusable workflows. Do I need to set something else? What do you mean by 'trigger a run via the workflow-dispatch event'? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/635 From adinn at openjdk.org Thu Aug 18 09:23:37 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 09:23:37 GMT Subject: [jdk17u-dev] RFR: 8256811: Delayed/missed jdwp class unloading events In-Reply-To: References: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> Message-ID: On Wed, 17 Aug 2022 18:42:08 GMT, Zhengyu Gu wrote: >> Backport of patch to fix class unloading event notification. >> >> This backport was originally developed by @zhengyu123 and involved some minor changes to the original patch. >> >> n.b. the original patch required a follow up fix (cf JDK-8290908) which also needs backporting after this has been included. > > This fix results a couple of followup CRs: JDK-8290908 and JDK-8291456. JDK-8291456 has yet been resolved, probably this backport should wait till JDK-8291456 is resolved. @zhengyu123 Thanks for the heads-up regarding JDK-8291456. I was not aware there was another dependent issue. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/635 From adinn at openjdk.org Thu Aug 18 09:25:40 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 09:25:40 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM In-Reply-To: <1FrGx8xtItVZ9TBlsNKBF4-pxHfpZKKdS2GCTKafb-c=.71775d46-ac67-4fe6-8947-38ff23be103a@github.com> References: <1FrGx8xtItVZ9TBlsNKBF4-pxHfpZKKdS2GCTKafb-c=.71775d46-ac67-4fe6-8947-38ff23be103a@github.com> Message-ID: On Wed, 17 Aug 2022 16:19:39 GMT, Severin Gehwolf wrote: >> Backport of follow up fix to correct JCK failure after 8256811. >> >> The backport involved minor adjustment of the original patch to allow for interbening changes. >> >> This backport is dependent on prior backport of JDK-8256811 > > @adinn Please use PR title `Backport 0ae834105740f7cf73fe96be22e0f564ad29b18d` as we know the sha of the mainline patch. Please also target branch `pr/635` over `master` since that's the PR this depends on (uses the depending pull requests feature). @jerboaa How do I make this patch target pr/635? n.b. I raised the PR from a branch that is derived from the one used to raise pr/635. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/636 From sgehwolf at openjdk.org Thu Aug 18 09:47:25 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 18 Aug 2022 09:47:25 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM In-Reply-To: References: <1FrGx8xtItVZ9TBlsNKBF4-pxHfpZKKdS2GCTKafb-c=.71775d46-ac67-4fe6-8947-38ff23be103a@github.com> Message-ID: On Thu, 18 Aug 2022 09:21:29 GMT, Andrew Dinn wrote: >> @adinn Please use PR title `Backport 0ae834105740f7cf73fe96be22e0f564ad29b18d` as we know the sha of the mainline patch. Please also target branch `pr/635` over `master` since that's the PR this depends on (uses the depending pull requests feature). > > @jerboaa How do I make this patch target pr/635? n.b. I raised the PR from a branch that is derived from the one used to raise pr/635. @adinn In the UI when you create a PR, the target branch should be `openjdk:pr/635` instead of `openjdk:master`. "See [adinn](https://github.com/adinn) wants to merge 2 commits into [openjdk:master](https://github.com/openjdk/jdk17u-dev) from [adinn:JDK-8290908](https://github.com/adinn/jdk17u-dev/tree/JDK-8290908)" above. You can re-use the branch you have, but by comparing it to `pr/635` only the changes on top would show up in the "changes" tab. It might mean you'd have to recreate the PR and close this one. Not sure if you have a widget to change the target branch (I don't, but I didn't create the PR). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/636 From adinn at openjdk.org Thu Aug 18 10:22:23 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 10:22:23 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM In-Reply-To: References: <1FrGx8xtItVZ9TBlsNKBF4-pxHfpZKKdS2GCTKafb-c=.71775d46-ac67-4fe6-8947-38ff23be103a@github.com> Message-ID: <-0mwpR06D5ofPh5tw5uscuoIUurqK7mCOyxJ2mis9WA=.4372c95c-04eb-42d2-9250-824e39efad53@github.com> On Thu, 18 Aug 2022 09:43:26 GMT, Severin Gehwolf wrote: >> @jerboaa How do I make this patch target pr/635? n.b. I raised the PR from a branch that is derived from the one used to raise pr/635. > > @adinn In the UI when you create a PR, the target branch should be `openjdk:pr/635` instead of `openjdk:master`. "See [adinn](https://github.com/adinn) wants to merge 2 commits into [openjdk:master](https://github.com/openjdk/jdk17u-dev) from [adinn:JDK-8290908](https://github.com/adinn/jdk17u-dev/tree/JDK-8290908)" above. You can re-use the branch you have, but by comparing it to `pr/635` only the changes on top would show up in the "changes" tab. It might mean you'd have to recreate the PR and close this one. Not sure if you have a widget to change the target branch (I don't, but I didn't create the PR). @jerboaa I have created a new backport PR that targets pr/635. I am closing this one. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/636 From adinn at openjdk.org Thu Aug 18 10:22:25 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 10:22:25 GMT Subject: [jdk17u-dev] Withdrawn: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM In-Reply-To: References: Message-ID: On Wed, 17 Aug 2022 15:54:39 GMT, Andrew Dinn wrote: > Backport of follow up fix to correct JCK failure after 8256811. > > The backport involved minor adjustment of the original patch to allow for interbening changes. > > This backport is dependent on prior backport of JDK-8256811 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/636 From adinn at openjdk.org Thu Aug 18 10:27:52 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 10:27:52 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM Message-ID: Backport of follow up fix to correct JCK failure after 8256811. The backport involved minor adjustment of the original patch to allow for intervening changes. This backport is dependent on prior backport of JDK-8256811. It also requires a subsequent backport of JDK-8291456. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/635 Commit messages: - 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM Changes: https://git.openjdk.org/jdk17u-dev/pull/637/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=637&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290908 Stats: 8 lines in 1 file changed: 4 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/637.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/637/head:pull/637 PR: https://git.openjdk.org/jdk17u-dev/pull/637 From adinn at openjdk.org Thu Aug 18 10:36:24 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 10:36:24 GMT Subject: [jdk17u-dev] RFR: 8256811: Delayed/missed jdwp class unloading events [v2] In-Reply-To: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> References: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> Message-ID: > Backport of patch to fix class unloading event notification. > > This backport was originally developed by @zhengyu123 and involved some minor changes to the original patch. > > n.b. the original patch required a follow up fix (cf JDK-8290908) which also needs backporting after this has been included. Andrew Dinn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8256811 - Backport 54854d9300479c22c416fd9d2fdb5c29fc1884bc ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/635/files - new: https://git.openjdk.org/jdk17u-dev/pull/635/files/d7e00531..25678462 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=635&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=635&range=00-01 Stats: 524 lines in 32 files changed: 160 ins; 314 del; 50 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/635.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/635/head:pull/635 PR: https://git.openjdk.org/jdk17u-dev/pull/635 From adinn at openjdk.org Thu Aug 18 10:42:47 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 10:42:47 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM [v2] In-Reply-To: References: Message-ID: > Backport of follow up fix to correct JCK failure after 8256811. > > The backport involved minor adjustment of the original patch to allow for intervening changes. > > This backport is dependent on prior backport of JDK-8256811. > > It also requires a subsequent backport of JDK-8291456. Andrew Dinn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'JDK-8256811' into JDK-8290908 - 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM Reviewed-by: cjplummer, amenkov ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/637/files - new: https://git.openjdk.org/jdk17u-dev/pull/637/files/2193bb9e..94a13dbd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=637&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=637&range=00-01 Stats: 524 lines in 32 files changed: 160 ins; 314 del; 50 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/637.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/637/head:pull/637 PR: https://git.openjdk.org/jdk17u-dev/pull/637 From adinn at openjdk.org Thu Aug 18 10:43:21 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 10:43:21 GMT Subject: [jdk17u-dev] RFR: 8256811: Delayed/missed jdwp class unloading events In-Reply-To: References: <0M3cbi13mMqfZEsHjtR8oI7GWfSPdHpstjG89D973ns=.4b591818-a5c3-4ef9-ac03-40db92299cf7@github.com> Message-ID: <5urpNjtGtgWGJUMI5ZJk6285bKriGN7mACAGt3mdkE4=.eaefd18a-4fcc-4806-ad91-4d212998243a@github.com> On Wed, 17 Aug 2022 17:27:01 GMT, Christoph Langer wrote: >> Backport of patch to fix class unloading event notification. >> >> This backport was originally developed by @zhengyu123 and involved some minor changes to the original patch. >> >> n.b. the original patch required a follow up fix (cf JDK-8290908) which also needs backporting after this has been included. > > @adinn: could you please enable GitHub actions on your repository and trigger a run via the workflow-dispatch event? Same goes for #636. Thanks! > > You might as well merge master into your branch and push it after you've enabled GHA. Then we'll get the run automatically. @RealCLanger Ah, ok, I think I see now what you mean. I merged master and pushed and I can see that workflows are now running for the updated branch. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/635 From adinn at openjdk.org Thu Aug 18 10:44:10 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 18 Aug 2022 10:44:10 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 10:18:57 GMT, Andrew Dinn wrote: > Backport of follow up fix to correct JCK failure after 8256811. > > The backport involved minor adjustment of the original patch to allow for intervening changes. > > This backport is dependent on prior backport of JDK-8256811. > > It also requires a subsequent backport of JDK-8291456. I merged master into the branch for pr/635 to kick off a workflow. The above merge does the same for this branch. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/637 From duke at openjdk.org Thu Aug 18 15:43:58 2022 From: duke at openjdk.org (Richard-Rogalski) Date: Thu, 18 Aug 2022 15:43:58 GMT Subject: [jdk11u-dev] RFR: 8230708: Hotspot fails to build on linux-sparc with gcc-9 Message-ID: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> Backport of bug 8230708. Tested and worked for me and one other user of sparc/linux. I signed the OCA: it is under review, will update when it goes through. This should be fairly low risk: it only touches sparc-specific code. I appreciate your time :^) ------------- Commit messages: - Fix jdk11 building on sparc/linux with GCC=>9 :D Changes: https://git.openjdk.org/jdk11u-dev/pull/1330/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1330&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8230708 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1330.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1330/head:pull/1330 PR: https://git.openjdk.org/jdk11u-dev/pull/1330 From phh at openjdk.org Thu Aug 18 16:11:34 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 18 Aug 2022 16:11:34 GMT Subject: [jdk11u-dev] RFR: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 02:33:37 GMT, Joshua Cao wrote: > clean backport JBS issue tagged. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1331 From abakhtin at openjdk.org Thu Aug 18 16:24:36 2022 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 18 Aug 2022 16:24:36 GMT Subject: [jdk15u-dev] RFR: 8269039: Disable SHA-1 Signed JARs Message-ID: Backport from JDK18 is not applied clean, resolved with help of JDK13 patch: * src/java.base/share/conf/security/java.security * is not applied clean because 15 mentions "include jdk.disabled.namedCurves" added by JDK-8233228 * src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java * Some hunks did not apply because DISABLED_CHECK was renamed to JAR_DISABLED_CHECK in 17 by JDK-8266225. * Other hunks patch methods not in 15: checkWeakKey(), checkWeakAlg() as well as the calls to these methods. * JAR files changes are not applied, copied from JDK13 * test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java * Patch skipped, test not in 15. * test/jdk/sun/security/tools/jarsigner/TimestampCheck.java * Resolved using JDK13 patch. * test/lib/jdk/test/lib/security/SecurityUtils.java * The change to this file was already backported. All sun/security/tools/jarsigner java/security/Security/signedfirst tests passed ------------- Commit messages: - Backport 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7 Changes: https://git.openjdk.org/jdk15u-dev/pull/255/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=255&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269039 Stats: 622 lines in 25 files changed: 300 ins; 206 del; 116 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/255.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/255/head:pull/255 PR: https://git.openjdk.org/jdk15u-dev/pull/255 From duke at openjdk.org Thu Aug 18 16:37:24 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 18 Aug 2022 16:37:24 GMT Subject: [jdk11u-dev] Integrated: 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation In-Reply-To: References: Message-ID: On Sat, 13 Aug 2022 15:21:45 GMT, Joshua Cao wrote: > clean backport. passes TestJFRIntrinsic.java on our systems. This pull request has now been integrated. Changeset: 501352cc Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/501352cc8f593a3f17d5dcdaa300d8559085e7b8 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation Backport-of: 2298819af84e96ddeed17c7ee3b7ca044266b7cc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1325 From duke at openjdk.org Thu Aug 18 18:49:41 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 18 Aug 2022 18:49:41 GMT Subject: [jdk11u-dev] RFR: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 [v2] In-Reply-To: <9s1AwWZG170Ti7v2B10ZLQJnRUbCppQi-kWVHGPlXlM=.cc01820a-fc77-4b59-900a-81da6e0d579f@github.com> References: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> <9s1AwWZG170Ti7v2B10ZLQJnRUbCppQi-kWVHGPlXlM=.cc01820a-fc77-4b59-900a-81da6e0d579f@github.com> Message-ID: On Thu, 18 Aug 2022 06:24:18 GMT, Joshua Cao wrote: >> clean backport after https://github.com/openjdk/jdk11u-dev/pull/1326 > > Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. pushed merge from master ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1327 From duke at openjdk.org Thu Aug 18 19:04:14 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 18 Aug 2022 19:04:14 GMT Subject: [jdk11u-dev] RFR: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 [v3] In-Reply-To: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> References: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> Message-ID: > clean backport after https://github.com/openjdk/jdk11u-dev/pull/1326 Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of https://git.openjdk.org/jdk11u-dev into 8242188 - 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 - 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1327/files - new: https://git.openjdk.org/jdk11u-dev/pull/1327/files/31d983e2..5e2fd291 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1327&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1327&range=01-02 Stats: 704 lines in 32 files changed: 328 ins; 296 del; 80 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1327.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1327/head:pull/1327 PR: https://git.openjdk.org/jdk11u-dev/pull/1327 From clanger at openjdk.org Thu Aug 18 20:57:32 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 18 Aug 2022 20:57:32 GMT Subject: [jdk11u-dev] RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 03:00:52 GMT, xpbob wrote: > Backport a625bfdba45d49bc717bcc9be4112db93b50f50a Backport can be considered clean, just copyright diff. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1332 From clanger at openjdk.org Thu Aug 18 21:03:39 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 18 Aug 2022 21:03:39 GMT Subject: [jdk17u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: <8aRkbC8QCLLeJHnt2XRQFct95hSW7aUNLOyCCr9tv7A=.33f8e0bf-d0c8-4c5e-8734-6b3f5e5b450f@github.com> References: <8aRkbC8QCLLeJHnt2XRQFct95hSW7aUNLOyCCr9tv7A=.33f8e0bf-d0c8-4c5e-8734-6b3f5e5b450f@github.com> Message-ID: <-HCBhxogaXRlzVIrXCdVjCQT6bSwvAGYKEeiw-Cuj2c=.abde2c2e-4b33-4434-8cf9-6c723caed848@github.com> On Thu, 18 Aug 2022 08:10:48 GMT, Ji?? Van?k wrote: > ping please? The backport is clean and tests are green. Maintainers didn't become aware of it because no jdk17u-fix-request flag was set in JBS. As I saw you already added aFix Request comment, I have added both, jdk17u-fix-request and jdk17u-fix-yes. So you can consider it approved and this PR is ready to be integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/555 From clanger at openjdk.org Thu Aug 18 21:05:37 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 18 Aug 2022 21:05:37 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM In-Reply-To: References: <1FrGx8xtItVZ9TBlsNKBF4-pxHfpZKKdS2GCTKafb-c=.71775d46-ac67-4fe6-8947-38ff23be103a@github.com> Message-ID: On Thu, 18 Aug 2022 09:43:26 GMT, Severin Gehwolf wrote: >> @jerboaa How do I make this patch target pr/635? n.b. I raised the PR from a branch that is derived from the one used to raise pr/635. > > @adinn In the UI when you create a PR, the target branch should be `openjdk:pr/635` instead of `openjdk:master`. "See [adinn](https://github.com/adinn) wants to merge 2 commits into [openjdk:master](https://github.com/openjdk/jdk17u-dev) from [adinn:JDK-8290908](https://github.com/adinn/jdk17u-dev/tree/JDK-8290908)" above. You can re-use the branch you have, but by comparing it to `pr/635` only the changes on top would show up in the "changes" tab. It might mean you'd have to recreate the PR and close this one. Not sure if you have a widget to change the target branch (I don't, but I didn't create the PR). > @jerboaa I have created a new backport PR that targets pr/635. I am closing this one. That was not necessary. As a PR author, you can change the target branch via an edit button that you should have. But it's ok this way either. ? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/636 From duke at openjdk.org Thu Aug 18 21:31:03 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 18 Aug 2022 21:31:03 GMT Subject: [jdk11u-dev] Integrated: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 In-Reply-To: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> References: <2pbEThGLoxx5X6sIacftZYT1dwK9943QecGogXFjZmI=.eb00bac3-a13c-4d81-a9ec-ffa37b8feecf@github.com> Message-ID: On Mon, 15 Aug 2022 15:20:01 GMT, Joshua Cao wrote: > clean backport after https://github.com/openjdk/jdk11u-dev/pull/1326 This pull request has now been integrated. Changeset: fa8c0d64 Author: Joshua Cao Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/fa8c0d641c0c9aa6dfdb6f71cd1babf6183ffc53 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64 Backport-of: 820f7227b776658db13c108c29a79f38fb8a7ffa ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1327 From duke at openjdk.org Thu Aug 18 23:17:09 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 18 Aug 2022 23:17:09 GMT Subject: [jdk17u-dev] RFR: 8227651: Tests fail with SSLProtocolException: Input record too big Message-ID: Clean backport. On our systems, LargePackage.java fails more than half of the time, and SSLEngineExplorerWithSrv.java fails occassionally. This change seems to stabilize those tests. ------------- Commit messages: - 8227651: Tests fail with SSLProtocolException: Input record too big Changes: https://git.openjdk.org/jdk17u-dev/pull/639/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=639&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8227651 Stats: 51 lines in 8 files changed: 5 ins; 5 del; 41 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/639.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/639/head:pull/639 PR: https://git.openjdk.org/jdk17u-dev/pull/639 From phh at openjdk.org Fri Aug 19 00:22:49 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 19 Aug 2022 00:22:49 GMT Subject: [jdk17u-dev] RFR: 8227651: Tests fail with SSLProtocolException: Input record too big In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 22:59:44 GMT, Joshua Cao wrote: > Clean backport. > > On our systems, LargePackage.java fails more than half of the time, and SSLEngineExplorerWithSrv.java fails occassionally. This change seems to stabilize those tests. Tagged both JBS issues. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/639 From duke at openjdk.org Fri Aug 19 00:44:02 2022 From: duke at openjdk.org (Joshua Cao) Date: Fri, 19 Aug 2022 00:44:02 GMT Subject: [jdk11u-dev] Integrated: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl In-Reply-To: <8jaja33KPI1g6HibPgr2niFR_PMG35dT12Te01q-cgY=.887e4cd0-3986-4fb6-a0ca-8871bc44485a@github.com> References: <8jaja33KPI1g6HibPgr2niFR_PMG35dT12Te01q-cgY=.887e4cd0-3986-4fb6-a0ca-8871bc44485a@github.com> Message-ID: On Sat, 13 Aug 2022 15:07:40 GMT, Joshua Cao wrote: > Not a clean backport since surrounding lines are different, but changes are simple enough. This change passes ProcessBuilder/Basic.java jtreg test on our Alpine systems. This pull request has now been integrated. Changeset: a491f0d8 Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/a491f0d8cdaada887b8f1e5ff673222bd2d8755f Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl Backport-of: a8edd7a12f955fe843c7c9ad4273e9c653a80c5a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1324 From duke at openjdk.org Fri Aug 19 00:51:42 2022 From: duke at openjdk.org (Joshua Cao) Date: Fri, 19 Aug 2022 00:51:42 GMT Subject: [jdk17u-dev] Integrated: 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs In-Reply-To: References: Message-ID: <5Efa0S3C0nFJ3NliU8i50f8tVDMkBUxiBhdiJDJNqRc=.cff2cc1e-fc83-469b-9ebe-b5af47979f83@github.com> On Thu, 18 Aug 2022 17:18:33 GMT, Joshua Cao wrote: > clean backport. This change passes TestOverUnrolling2.java. This pull request has now been integrated. Changeset: 3d2d300b Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/3d2d300bcda0ff5cfc67e8df4609499cb54dc32d Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs Backport-of: d959c22a9574359e2d5134ac8365e8a9df4f7cef ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/638 From duke at openjdk.org Fri Aug 19 00:51:43 2022 From: duke at openjdk.org (Joshua Cao) Date: Fri, 19 Aug 2022 00:51:43 GMT Subject: [jdk11u-dev] Integrated: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 02:33:37 GMT, Joshua Cao wrote: > clean backport This pull request has now been integrated. Changeset: 76cab61f Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/76cab61f238cd60c6fba372ef80c37fb45baef86 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Backport-of: 928e34773694dda5373027848a3363887bcaf4f4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1331 From duke at openjdk.org Fri Aug 19 01:15:52 2022 From: duke at openjdk.org (xpbob) Date: Fri, 19 Aug 2022 01:15:52 GMT Subject: [jdk11u-dev] Integrated: 8283903: GetContainerCpuLoad does not return the correct result in share mode In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 03:00:52 GMT, xpbob wrote: > Backport a625bfdba45d49bc717bcc9be4112db93b50f50a This pull request has now been integrated. Changeset: 42dc282b Author: bobpengxie Committer: Jie Fu URL: https://git.openjdk.org/jdk11u-dev/commit/42dc282b04da77cc5270fd9a46ecc0b0b08d1aa6 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8283903: GetContainerCpuLoad does not return the correct result in share mode Reviewed-by: clanger Backport-of: a625bfdba45d49bc717bcc9be4112db93b50f50a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1332 From jvanek at openjdk.org Fri Aug 19 07:40:58 2022 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 19 Aug 2022 07:40:58 GMT Subject: [jdk17u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Fri, 15 Jul 2022 12:07:31 GMT, Ji?? Van?k wrote: > 8282947: JFR: Dump on shutdown live-locks in some conditions tyvm! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/555 From jvanek at openjdk.org Fri Aug 19 07:46:59 2022 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 19 Aug 2022 07:46:59 GMT Subject: [jdk17u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Fri, 15 Jul 2022 12:07:31 GMT, Ji?? Van?k wrote: > 8282947: JFR: Dump on shutdown live-locks in some conditions Looking for sponsor, if you would be so kind. TYVM! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/555 From jvanek at openjdk.org Fri Aug 19 07:54:11 2022 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 19 Aug 2022 07:54:11 GMT Subject: [jdk17u-dev] Integrated: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Fri, 15 Jul 2022 12:07:31 GMT, Ji?? Van?k wrote: > 8282947: JFR: Dump on shutdown live-locks in some conditions This pull request has now been integrated. Changeset: 70a51d48 Author: Ji?? Van?k Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/70a51d482a1a72a74c07d7df25c7bbaf4fba5cb8 Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod 8282947: JFR: Dump on shutdown live-locks in some conditions Backport-of: 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/555 From jvanek at openjdk.org Fri Aug 19 08:14:07 2022 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 19 Aug 2022 08:14:07 GMT Subject: [jdk17u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: <_8D4laCxSvv4Jta6KhIPSUpzPcZ-u7GK543hCgu12ZU=.3cedd415-a216-4335-b705-ab8250629f8f@github.com> On Fri, 15 Jul 2022 12:07:31 GMT, Ji?? Van?k wrote: > 8282947: JFR: Dump on shutdown live-locks in some conditions TYVM! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/555 From jvanek at openjdk.org Fri Aug 19 09:28:40 2022 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 19 Aug 2022 09:28:40 GMT Subject: [jdk11u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions Message-ID: 8282947: JFR: Dump on shutdown live-locks in some conditions ------------- Commit messages: - Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 Changes: https://git.openjdk.org/jdk11u-dev/pull/1334/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1334&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282947 Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1334.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1334/head:pull/1334 PR: https://git.openjdk.org/jdk11u-dev/pull/1334 From adinn at openjdk.org Fri Aug 19 09:49:44 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Fri, 19 Aug 2022 09:49:44 GMT Subject: [jdk17u-dev] RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM In-Reply-To: References: Message-ID: <9Z63waIBNt0vZPzSCn9SbEyG-Z0NyDttmU9aHUhdY9U=.a57f16a9-dc57-4b88-99fe-599c561ff088@github.com> On Wed, 17 Aug 2022 15:54:39 GMT, Andrew Dinn wrote: > Backport of follow up fix to correct JCK failure after 8256811. > > The backport involved minor adjustment of the original patch to allow for interbening changes. > > This backport is dependent on prior backport of JDK-8256811 Right, I found the button too late -- in case anyone else is as clueless a n00b as me I'll mention: it pops up after you click on Edit on the top right of the PR title. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/636 From roland at openjdk.org Fri Aug 19 13:02:17 2022 From: roland at openjdk.org (Roland Westrelin) Date: Fri, 19 Aug 2022 13:02:17 GMT Subject: [jdk11u-dev] RFR: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389 Message-ID: This fixes an issue with the backport of https://bugs.openjdk.org/browse/JDK-8223363: https://github.com/openjdk/jdk11u/commit/5f40afc10909061b5b4e17ec59856611e160e474 where a line that should have been removed wasn't. ------------- Commit messages: - test - fix Changes: https://git.openjdk.org/jdk11u-dev/pull/1335/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1335&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291713 Stats: 64 lines in 2 files changed: 63 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1335.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1335/head:pull/1335 PR: https://git.openjdk.org/jdk11u-dev/pull/1335 From gnu.andrew at redhat.com Fri Aug 19 15:07:44 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Fri, 19 Aug 2022 16:07:44 +0100 Subject: OpenJDK 11.0.16.1 Released Message-ID: We are pleased to announce the release of OpenJDK 11.0.16.1. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.16.1+1.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.16.1+1.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: c4e592a2b76c04a0c96cdd96bdcd08092e26646cafd952c8cc6113ff7a3a5960 openjdk-11.0.16.1+1.tar.xz ba00a4605e9ca0080204940ab85f553776d3a3804616f5f0c252083070cfde0b openjdk-11.0.16.1+1.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.16.1+1.sha256 New in release OpenJDK 11.0.16.1 (2022-08-12): ============================================= Live versions of these release notes can be found at: * https://bit.ly/openjdk110161 * https://builds.shipilev.net/backports-monitor/release-notes-11.0.16.1.txt * Other changes - JDK-8292255: Bump update version for OpenJDK: jdk-11.0.16.1 - JDK-8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large Notes on individual issues: =========================== hotspot/compiler: JDK-8292396: C2 Compilation Errors Unpredictably Crashes JVM ============================================================ Fixes a regression in the C2 JIT compiler which caused the Java Runtime to crash unpredictably. Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From gnu.andrew at redhat.com Fri Aug 19 15:22:57 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Fri, 19 Aug 2022 16:22:57 +0100 Subject: OpenJDK 17.0.4.1 Released Message-ID: We are pleased to announce the release of OpenJDK 17.0.4.1. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk17/openjdk-17.0.4.1+1.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk17/openjdk-17.0.4.1+1.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: 47e0dade506e8a4b6f73b698c38f96ee3543084b25f56740941305d1ce488b46 openjdk-17.0.4.1+1.tar.xz c5c6b8b783166500258ae587bd444f346a640e4f6987f583e407ebbb29103e80 openjdk-17.0.4.1+1.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk17/openjdk-17.0.4.1+1.sha256 New in release OpenJDK 17.0.4.1 (2022-08-16): ============================================= Live versions of these release notes can be found at: * https://bit.ly/openjdk17041 * https://builds.shipilev.net/backports-monitor/release-notes-17.0.4.1.txt * Other changes - JDK-8292258: Bump update version for OpenJDK: jdk-17.0.4.1 - JDK-8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large Notes on individual issues: =========================== hotspot/compiler: JDK-8292396: C2 Compilation Errors Unpredictably Crashes JVM ============================================================ Fixes a regression in the C2 JIT compiler which caused the Java Runtime to crash unpredictably. Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From gnu.andrew at redhat.com Fri Aug 19 15:33:17 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Fri, 19 Aug 2022 16:33:17 +0100 Subject: Result: New JDK Updates Committer: Jonathan Dowland Message-ID: Voting for Jonathan Dowland [0] is now closed. Yes: 7 Veto: 0 Abstain: 0 Turnout: 2% (7/316) According to the Bylaws definition of Lazy Consensus [1], this is sufficient to approve the nomination. [0] https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-July/015455.html [1] https://openjdk.java.net/bylaws#lazy-consensus Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From duke at openjdk.org Fri Aug 19 15:45:26 2022 From: duke at openjdk.org (Salander) Date: Fri, 19 Aug 2022 15:45:26 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v2] In-Reply-To: References: Message-ID: <0U6NdAGthSmWHzkBtFLr7Lk06C1UEhgvNazqlwbLjMQ=.7d876ce8-8f6f-4d60-bd9d-b6608bf11029@github.com> > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Allow building with Clang 13 This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. See here: https://bugs.openjdk.java.net/browse/JDK-8229258 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1284/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=01 Stats: 788 lines in 103 files changed: 51 ins; 6 del; 731 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From lancea at openjdk.org Fri Aug 19 15:53:16 2022 From: lancea at openjdk.org (Lance Andersen) Date: Fri, 19 Aug 2022 15:53:16 GMT Subject: [jdk19u] Integrated: 8292487: Back out the fix forJDK-8281962 from jdk19u In-Reply-To: References: Message-ID: On Tue, 16 Aug 2022 18:09:13 GMT, Lance Andersen wrote: > Hi, > > Please review this PR which reverts the fix for [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) that unfortunately introduced a regression. The fix for the regression is being addressed via [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327). > > Mach5 tiers 1-3 are currently running. > > The intent is to give the fix for [JDK-8292327](https://bugs.openjdk.org/browse/JDK-8292327) more time to bake in the main openjdk workspace (for JDK 20) and in the meantime revert [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) in jdk19u. This pull request has now been integrated. Changeset: 030ff3ad Author: Lance Andersen URL: https://git.openjdk.org/jdk19u/commit/030ff3ad576776c008b7c962e3b1fd2c37735026 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8292487: Back out the fix forJDK-8281962 from jdk19u Reviewed-by: alanb, simonis ------------- PR: https://git.openjdk.org/jdk19u/pull/11 From duke at openjdk.org Fri Aug 19 16:03:00 2022 From: duke at openjdk.org (Salander) Date: Fri, 19 Aug 2022 16:03:00 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v3] In-Reply-To: References: Message-ID: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request incrementally with one additional commit since the last revision: Update klass.inline.hpp ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1284/files - new: https://git.openjdk.org/jdk11u-dev/pull/1284/files/39597158..a118f6fe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From duke at openjdk.org Fri Aug 19 16:14:31 2022 From: duke at openjdk.org (Salander) Date: Fri, 19 Aug 2022 16:14:31 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v4] In-Reply-To: References: Message-ID: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request incrementally with one additional commit since the last revision: Fix aarch64 build ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1284/files - new: https://git.openjdk.org/jdk11u-dev/pull/1284/files/a118f6fe..cc879f2c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From duke at openjdk.org Fri Aug 19 16:40:40 2022 From: duke at openjdk.org (Salander) Date: Fri, 19 Aug 2022 16:40:40 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v5] In-Reply-To: References: Message-ID: <5tdmH92aycV7xmCKeyWVV0lIKDuvZAV7PDpI0ZsIOJU=.303daff8-afbd-4765-917b-cc26c5aba4f9@github.com> > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request incrementally with one additional commit since the last revision: fix bfsClosure.cpp ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1284/files - new: https://git.openjdk.org/jdk11u-dev/pull/1284/files/cc879f2c..ffdd2c94 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From duke at openjdk.org Fri Aug 19 16:53:55 2022 From: duke at openjdk.org (Salander) Date: Fri, 19 Aug 2022 16:53:55 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v6] In-Reply-To: References: Message-ID: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request incrementally with one additional commit since the last revision: More build fixes ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1284/files - new: https://git.openjdk.org/jdk11u-dev/pull/1284/files/ffdd2c94..5d711156 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=04-05 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From duke at openjdk.org Fri Aug 19 17:30:53 2022 From: duke at openjdk.org (Salander) Date: Fri, 19 Aug 2022 17:30:53 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v7] In-Reply-To: References: Message-ID: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request incrementally with one additional commit since the last revision: More build fixes ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1284/files - new: https://git.openjdk.org/jdk11u-dev/pull/1284/files/5d711156..8b96d6be Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=05-06 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From duke at openjdk.org Fri Aug 19 19:34:34 2022 From: duke at openjdk.org (Dan Lutker) Date: Fri, 19 Aug 2022 19:34:34 GMT Subject: [jdk11u-dev] RFR: 8275008: gtest build failure due to stringop-overflow warning with gcc11 Message-ID: Backport of c55dd365e3463670697b09de0ff70877203e5a69, which did not apply cleanly due to changes in tip that reworked the make file. Corretto is requiring this when building as a RPM on a hardened base OS with GCC 11.3 ------------- Commit messages: - Backport c55dd365e3463670697b09de0ff70877203e5a69 Changes: https://git.openjdk.org/jdk11u-dev/pull/1333/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1333&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275008 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1333.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1333/head:pull/1333 PR: https://git.openjdk.org/jdk11u-dev/pull/1333 From duke at openjdk.org Fri Aug 19 19:36:00 2022 From: duke at openjdk.org (Salander) Date: Fri, 19 Aug 2022 19:36:00 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v8] In-Reply-To: References: Message-ID: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request incrementally with one additional commit since the last revision: More build fixes ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1284/files - new: https://git.openjdk.org/jdk11u-dev/pull/1284/files/8b96d6be..7578a4b5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=06-07 Stats: 11 lines in 5 files changed: 1 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From duke at openjdk.org Fri Aug 19 20:16:25 2022 From: duke at openjdk.org (Salander) Date: Fri, 19 Aug 2022 20:16:25 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v9] In-Reply-To: References: Message-ID: <1pI5dmjx8yM8nRpsWpSHWD78rp09UT65Q1hSDbRKKQ4=.005bd67c-416e-48d4-84a4-797c78124b0b@github.com> > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request incrementally with two additional commits since the last revision: - Fix github action - Temporarily build linux with clang as well for testing ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1284/files - new: https://git.openjdk.org/jdk11u-dev/pull/1284/files/7578a4b5..dc8bedce Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=07-08 Stats: 367 lines in 1 file changed: 367 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From phh at openjdk.org Fri Aug 19 22:09:05 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 19 Aug 2022 22:09:05 GMT Subject: [jdk11u-dev] RFR: 8275008: gtest build failure due to stringop-overflow warning with gcc11 In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 23:01:27 GMT, Dan Lutker wrote: > Backport of c55dd365e3463670697b09de0ff70877203e5a69, which did not apply cleanly due to changes in tip that reworked the make file. > > Corretto is requiring this when building as a RPM on a hardened base OS with GCC 11.3 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1333 From phh at openjdk.org Fri Aug 19 22:17:49 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 19 Aug 2022 22:17:49 GMT Subject: [jdk11u-dev] RFR: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389 In-Reply-To: References: Message-ID: On Fri, 19 Aug 2022 12:54:38 GMT, Roland Westrelin wrote: > This fixes an issue with the backport of > https://bugs.openjdk.org/browse/JDK-8223363: > > https://github.com/openjdk/jdk11u/commit/5f40afc10909061b5b4e17ec59856611e160e474 > > where a line that should have been removed wasn't. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1335 From xliu at openjdk.org Fri Aug 19 23:07:29 2022 From: xliu at openjdk.org (Xin Liu) Date: Fri, 19 Aug 2022 23:07:29 GMT Subject: [jdk11u-dev] RFR: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389 In-Reply-To: References: Message-ID: <_UHks-6XZViYQfP5n4d2SzjqqOCRssouTfj7ALbkbro=.ccc3832c-8394-4616-b907-a93d1058ad10@github.com> On Fri, 19 Aug 2022 12:54:38 GMT, Roland Westrelin wrote: > This fixes an issue with the backport of > https://bugs.openjdk.org/browse/JDK-8223363: > > https://github.com/openjdk/jdk11u/commit/5f40afc10909061b5b4e17ec59856611e160e474 > > where a line that should have been removed wasn't. LGTM. I am not a reviewer. Double check that the original patch did replacement here. We introduced an side-effect (+=) when we backported it. the fix is correct. - uint require_nodes(uint require) { + uint require_nodes(uint require, uint minreq = REQUIRE_MIN) { precond(require > 0); - _nodes_required += MAX2(100u, require); // Keep requests at minimum 100. + _nodes_required += MAX2(require, minreq); return _nodes_required; } ------------- Marked as reviewed by xliu (no project role). PR: https://git.openjdk.org/jdk11u-dev/pull/1335 From phh at openjdk.org Sun Aug 21 17:16:43 2022 From: phh at openjdk.org (Paul Hohensee) Date: Sun, 21 Aug 2022 17:16:43 GMT Subject: [jdk18u] RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2] In-Reply-To: References: <9asiWdvOqxpobN4kGz1WLhSA4UVs0qytlUZji-ZLgMY=.7298da47-f9e7-4cf5-91e0-36bab6a2018a@github.com> Message-ID: On Wed, 17 Aug 2022 06:37:13 GMT, Sergey Bylokhov wrote: >> Hi all, >> This pull request contains a backport of commit [50d47de8](https://github.com/openjdk/jdk/commit/50d47de8358e2f22bf3a4a165d660c25ef6eacbc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen. >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Clean backport. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk18u/pull/175 From duke at openjdk.org Mon Aug 22 03:05:17 2022 From: duke at openjdk.org (xpbob) Date: Mon, 22 Aug 2022 03:05:17 GMT Subject: [jdk17u-dev] RFR: 8284950: CgroupV1 detection code should consider memory.swappiness Message-ID: Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 ------------- Commit messages: - Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 Changes: https://git.openjdk.org/jdk17u-dev/pull/641/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=641&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284950 Stats: 142 lines in 4 files changed: 137 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/641.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/641/head:pull/641 PR: https://git.openjdk.org/jdk17u-dev/pull/641 From duke at openjdk.org Mon Aug 22 03:20:08 2022 From: duke at openjdk.org (xpbob) Date: Mon, 22 Aug 2022 03:20:08 GMT Subject: [jdk11u-dev] RFR: 8284950: CgroupV1 detection code should consider memory.swappiness Message-ID: Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 ------------- Commit messages: - Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 Changes: https://git.openjdk.org/jdk11u-dev/pull/1336/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1336&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284950 Stats: 142 lines in 4 files changed: 137 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1336.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1336/head:pull/1336 PR: https://git.openjdk.org/jdk11u-dev/pull/1336 From yan at openjdk.org Mon Aug 22 07:43:51 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 22 Aug 2022 07:43:51 GMT Subject: [jdk15u-dev] RFR: 8269039: Disable SHA-1 Signed JARs In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 15:56:59 GMT, Alexey Bakhtin wrote: > Backport from JDK18 is not applied clean, resolved with help of JDK13 patch: > > * src/java.base/share/conf/security/java.security > > * is not applied clean because 15 mentions "include jdk.disabled.namedCurves" added by JDK-8233228 > * src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java > > * Some hunks did not apply because DISABLED_CHECK was renamed > to JAR_DISABLED_CHECK in 17 by JDK-8266225. > > * Other hunks patch methods not in 15: checkWeakKey(), checkWeakAlg() > as well as the calls to these methods. > * JAR files changes are not applied, copied from JDK13 > * test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java > * > Patch skipped, test not in 15. > * test/jdk/sun/security/tools/jarsigner/TimestampCheck.java > > * Resolved using JDK13 patch. > * test/lib/jdk/test/lib/security/SecurityUtils.java > > * The change to this file was already backported. > > All sun/security/tools/jarsigner java/security/Security/signedfirst tests passed Marked as reviewed by yan (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/255 From duke at openjdk.org Mon Aug 22 08:03:22 2022 From: duke at openjdk.org (Yi-Fan Tsai) Date: Mon, 22 Aug 2022 08:03:22 GMT Subject: [jdk17u-dev] RFR: 8282528: AArch64: Incorrect replicate2L_zero rule Message-ID: Another commit 9d3379b9755e9739f0b8f5c29deb1d28d0f3aa81, "8267356: AArch64: Vector API SVE codegen support", adds "UseSVE == 0" to all predicates expanded from replicate$3$4$5, but it is not backported. It causes this backport not clean. This backport instead preserves the predicate in replicate$3$4$5 prior to commit 9d3379 and preserves one more argument in the invocations. The predicates are expanded from replicate$3$4$5 by m4 and verified as unmodified. ------------- Commit messages: - Backport c35590282d54d8388f2f7501a30365e0a912bfda Changes: https://git.openjdk.org/jdk17u-dev/pull/642/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=642&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282528 Stats: 471 lines in 7 files changed: 372 ins; 20 del; 79 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/642.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/642/head:pull/642 PR: https://git.openjdk.org/jdk17u-dev/pull/642 From duke at openjdk.org Mon Aug 22 08:03:26 2022 From: duke at openjdk.org (Yi-Fan Tsai) Date: Mon, 22 Aug 2022 08:03:26 GMT Subject: [jdk17u-dev] RFR: 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding Message-ID: Backport b4490386fe348250e88347526172c1c27ef01eba ------------- Commit messages: - 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding Changes: https://git.openjdk.org/jdk17u-dev/pull/640/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=640&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288445 Stats: 115 lines in 4 files changed: 83 ins; 0 del; 32 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/640.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/640/head:pull/640 PR: https://git.openjdk.org/jdk17u-dev/pull/640 From abakhtin at openjdk.org Mon Aug 22 08:10:26 2022 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 22 Aug 2022 08:10:26 GMT Subject: [jdk15u-dev] Integrated: 8269039: Disable SHA-1 Signed JARs In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 15:56:59 GMT, Alexey Bakhtin wrote: > Backport from JDK18 is not applied clean, resolved with help of JDK13 patch: > > * src/java.base/share/conf/security/java.security > > * is not applied clean because 15 mentions "include jdk.disabled.namedCurves" added by JDK-8233228 > * src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java > > * Some hunks did not apply because DISABLED_CHECK was renamed > to JAR_DISABLED_CHECK in 17 by JDK-8266225. > > * Other hunks patch methods not in 15: checkWeakKey(), checkWeakAlg() > as well as the calls to these methods. > * JAR files changes are not applied, copied from JDK13 > * test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java > * > Patch skipped, test not in 15. > * test/jdk/sun/security/tools/jarsigner/TimestampCheck.java > > * Resolved using JDK13 patch. > * test/lib/jdk/test/lib/security/SecurityUtils.java > > * The change to this file was already backported. > > All sun/security/tools/jarsigner java/security/Security/signedfirst tests passed This pull request has now been integrated. Changeset: 0ec5a527 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk15u-dev/commit/0ec5a527e13b0a5a9ad1248d47c9e0a48e13a66e Stats: 622 lines in 25 files changed: 300 ins; 206 del; 116 mod 8269039: Disable SHA-1 Signed JARs Reviewed-by: yan Backport-of: 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/255 From duke at openjdk.org Mon Aug 22 08:42:20 2022 From: duke at openjdk.org (Alexey Pavlyutkin) Date: Mon, 22 Aug 2022 08:42:20 GMT Subject: [jdk17u-dev] RFR: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData Message-ID: <8QCOUsmBpDj1zRD2iOc_bQS1d8s3k9c2FYzYbwMkA8E=.73649a93-1a56-4b46-a5ab-e19a53a63b92@github.com> Hi! Here is backport of 8272417 that fixes a crash in ClassLoaderData logging that takes place for debug build. The patch is applied cleanly Verification (amd64 / Ubuntu 20.04) alex at alex-VirtualBox:~/8272417$ echo "public class A { public static void main(String... args) { System.gc(); } }" > A.java alex at alex-VirtualBox:~/8272417$ ./build/linux-x86_64-server-fastdebug/images/jdk/bin/java -XX:+UseZGC -XX:+VerifyAfterGC -Xlog:gc*=trace A.java ------------- Commit messages: - Backport 741f58c18c3dc49c5e1b793e411d8479770f2772 Changes: https://git.openjdk.org/jdk17u-dev/pull/643/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=643&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272417 Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/643.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/643/head:pull/643 PR: https://git.openjdk.org/jdk17u-dev/pull/643 From evergizova at openjdk.org Mon Aug 22 10:36:18 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 22 Aug 2022 10:36:18 GMT Subject: [jdk15u-dev] RFR: 8261354: SIGSEGV at MethodIteratorHost Message-ID: <-2sNpEhDqQu6UvrzwVPHNMsriUtxaMG3QZh-0QPiA_k=.d14ce9d4-1bab-415a-bfd4-7c573b0a0fbc@github.com> I'd like to backport JDK-8261354 to 15u for parity with 11u. The patch applies cleanly. Tested with jdk/jfr and tier1 tests. ------------- Commit messages: - Backport 24623167ffbf8e192ef539fd0a969412719f850c Changes: https://git.openjdk.org/jdk15u-dev/pull/256/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=256&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261354 Stats: 4 lines in 1 file changed: 1 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/256.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/256/head:pull/256 PR: https://git.openjdk.org/jdk15u-dev/pull/256 From evergizova at openjdk.org Mon Aug 22 10:38:26 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 22 Aug 2022 10:38:26 GMT Subject: [jdk13u-dev] RFR: 8261354: SIGSEGV at MethodIteratorHost Message-ID: <3ggvbG3llTOXtm052W58nrCDdk9B4jsZS4GDkEWGLmg=.43679f49-268f-4486-ac99-a013f7f9ddae@github.com> I'd like to backport JDK-8261354 to 13u for parity with 11u. The patch applies cleanly. Tested with jdk/jfr and tier1 tests. ------------- Commit messages: - Backport 24623167ffbf8e192ef539fd0a969412719f850c Changes: https://git.openjdk.org/jdk13u-dev/pull/390/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=390&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261354 Stats: 4 lines in 1 file changed: 1 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/390.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/390/head:pull/390 PR: https://git.openjdk.org/jdk13u-dev/pull/390 From evergizova at openjdk.org Mon Aug 22 11:57:39 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 22 Aug 2022 11:57:39 GMT Subject: [jdk15u-dev] Integrated: 8261354: SIGSEGV at MethodIteratorHost In-Reply-To: <-2sNpEhDqQu6UvrzwVPHNMsriUtxaMG3QZh-0QPiA_k=.d14ce9d4-1bab-415a-bfd4-7c573b0a0fbc@github.com> References: <-2sNpEhDqQu6UvrzwVPHNMsriUtxaMG3QZh-0QPiA_k=.d14ce9d4-1bab-415a-bfd4-7c573b0a0fbc@github.com> Message-ID: On Mon, 22 Aug 2022 10:27:36 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8261354 to 15u for parity with 11u. > The patch applies cleanly. > Tested with jdk/jfr and tier1 tests. This pull request has now been integrated. Changeset: 3bcf79bb Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk15u-dev/commit/3bcf79bb682c78e2cbfa796f77ca3b4dbe589afb Stats: 4 lines in 1 file changed: 1 ins; 2 del; 1 mod 8261354: SIGSEGV at MethodIteratorHost Backport-of: 24623167ffbf8e192ef539fd0a969412719f850c ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/256 From evergizova at openjdk.org Mon Aug 22 11:57:35 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 22 Aug 2022 11:57:35 GMT Subject: [jdk13u-dev] Integrated: 8261354: SIGSEGV at MethodIteratorHost In-Reply-To: <3ggvbG3llTOXtm052W58nrCDdk9B4jsZS4GDkEWGLmg=.43679f49-268f-4486-ac99-a013f7f9ddae@github.com> References: <3ggvbG3llTOXtm052W58nrCDdk9B4jsZS4GDkEWGLmg=.43679f49-268f-4486-ac99-a013f7f9ddae@github.com> Message-ID: On Mon, 22 Aug 2022 10:28:17 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8261354 to 13u for parity with 11u. > The patch applies cleanly. > Tested with jdk/jfr and tier1 tests. This pull request has now been integrated. Changeset: 8b0b375e Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk13u-dev/commit/8b0b375e213fe26d00f9be4920a63d9efdf8b481 Stats: 4 lines in 1 file changed: 1 ins; 2 del; 1 mod 8261354: SIGSEGV at MethodIteratorHost Backport-of: 24623167ffbf8e192ef539fd0a969412719f850c ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/390 From christoph.langer at sap.com Mon Aug 22 18:05:06 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 22 Aug 2022 18:05:06 +0000 Subject: Will jdk 18.0.2.1 be published? Message-ID: Hi Rob, will the tag jdk-18.0.2.1 for the backout of https://bugs.openjdk.org/browse/JDK-8292260 be published in jdk18u (soon)? Thanks & Best regards Christoph -------------- next part -------------- An HTML attachment was scrubbed... URL: From clanger at openjdk.org Mon Aug 22 18:05:36 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 22 Aug 2022 18:05:36 GMT Subject: [jdk18u] RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2] In-Reply-To: References: <9asiWdvOqxpobN4kGz1WLhSA4UVs0qytlUZji-ZLgMY=.7298da47-f9e7-4cf5-91e0-36bab6a2018a@github.com> Message-ID: On Wed, 17 Aug 2022 06:37:13 GMT, Sergey Bylokhov wrote: >> Hi all, >> This pull request contains a backport of commit [50d47de8](https://github.com/openjdk/jdk/commit/50d47de8358e2f22bf3a4a165d660c25ef6eacbc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen. >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. I think this one can be closed. jdk18u is done. ------------- PR: https://git.openjdk.org/jdk18u/pull/175 From rob.mckenna at oracle.com Mon Aug 22 18:18:57 2022 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Mon, 22 Aug 2022 18:18:57 +0000 Subject: Will jdk 18.0.2.1 be published? In-Reply-To: References: Message-ID: Yes, done, apologies for the delay. -Rob ________________________________________ From: Langer, Christoph Sent: Monday 22 August 2022 19:05 To: Robert Mckenna; jdk-updates-dev at openjdk.org Subject: [External] : Will jdk 18.0.2.1 be published? Hi Rob, will the tag jdk-18.0.2.1 for the backout of https://bugs.openjdk.org/browse/JDK-8292260 be published in jdk18u (soon)? Thanks & Best regards Christoph From christoph.langer at sap.com Mon Aug 22 18:34:17 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 22 Aug 2022 18:34:17 +0000 Subject: Will jdk 18.0.2.1 be published? In-Reply-To: References: Message-ID: Great. Thank you! > -----Original Message----- > From: Robert Mckenna > Sent: Montag, 22. August 2022 20:19 > To: Langer, Christoph ; jdk-updates- > dev at openjdk.org > Subject: Re: Will jdk 18.0.2.1 be published? > > Yes, done, apologies for the delay. > > -Rob > > ________________________________________ > From: Langer, Christoph > Sent: Monday 22 August 2022 19:05 > To: Robert Mckenna; jdk-updates-dev at openjdk.org > Subject: [External] : Will jdk 18.0.2.1 be published? > > Hi Rob, > > will the tag jdk-18.0.2.1 for the backout of > https://bugs.openjdk.org/browse/JDK-8292260 be published in jdk18u (soon)? > > Thanks & Best regards > Christoph From duke at openjdk.org Mon Aug 22 20:36:03 2022 From: duke at openjdk.org (Martijn Verburg) Date: Mon, 22 Aug 2022 20:36:03 GMT Subject: [jdk17u-dev] Integrated: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider In-Reply-To: References: Message-ID: On Wed, 10 Aug 2022 18:50:49 GMT, Martijn Verburg wrote: > Backport of 5e5500cbd79b40a32c20547ea0cdb81ef6904a3d > > On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges. > > "Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc > > keystore functionality and API remains unchanged, the local machine keystore types require the manual tests to run in admin mode > > Tested on windows, passes tier1 (via GH Actions) and manual tests provided in the patch This pull request has now been integrated. Changeset: e3c178d6 Author: Martijn Verburg Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/e3c178d6d87c9e0e2a75cddc72d802cf9124420e Stats: 187 lines in 5 files changed: 155 ins; 1 del; 31 mod 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider Backport-of: 5e5500cbd79b40a32c20547ea0cdb81ef6904a3d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/630 From clanger at openjdk.org Mon Aug 22 21:20:43 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 22 Aug 2022 21:20:43 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v9] In-Reply-To: <1pI5dmjx8yM8nRpsWpSHWD78rp09UT65Q1hSDbRKKQ4=.005bd67c-416e-48d4-84a4-797c78124b0b@github.com> References: <1pI5dmjx8yM8nRpsWpSHWD78rp09UT65Q1hSDbRKKQ4=.005bd67c-416e-48d4-84a4-797c78124b0b@github.com> Message-ID: <5Gc-m9mr2Ku4SS8mn-NsCOMEIWnLhE6rT-QrOrl0fos=.8b91d64e-14b2-4797-a81f-44cea6322d86@github.com> On Fri, 19 Aug 2022 20:16:25 GMT, Salander wrote: >> This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. >> >> See the following for more information: >> >> https://bugs.openjdk.java.net/browse/JDK-8229258 >> https://bugs.gentoo.org/817995 >> https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html >> https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html >> https://reviews.llvm.org/D99790#2678384 >> >> This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. > > Salander has updated the pull request incrementally with two additional commits since the last revision: > > - Fix github action > - Temporarily build linux with clang as well for testing The more I look at this, I think we should strive for a clean & full backport of https://bugs.openjdk.java.net/browse/JDK-8229258 if this is required to enable clang13 compilation. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From clanger at openjdk.org Mon Aug 22 21:24:31 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 22 Aug 2022 21:24:31 GMT Subject: [jdk11u-dev] RFR: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389 In-Reply-To: References: Message-ID: On Fri, 19 Aug 2022 12:54:38 GMT, Roland Westrelin wrote: > This fixes an issue with the backport of > https://bugs.openjdk.org/browse/JDK-8223363: > > https://github.com/openjdk/jdk11u/commit/5f40afc10909061b5b4e17ec59856611e160e474 > > where a line that should have been removed wasn't. Good catch. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1335 From duke at openjdk.org Mon Aug 22 21:27:39 2022 From: duke at openjdk.org (Dan Lutker) Date: Mon, 22 Aug 2022 21:27:39 GMT Subject: [jdk11u-dev] RFR: 8275008: gtest build failure due to stringop-overflow warning with gcc11 [v2] In-Reply-To: References: Message-ID: <6QxGOqLBOg2p-ksFJnqAIKogOB_v1UsUiLYRSTyU1so=.2f3e0522-c2d7-4b8b-95de-29149d476fee@github.com> > Backport of c55dd365e3463670697b09de0ff70877203e5a69, which did not apply cleanly due to changes in tip that reworked the make file. > > Corretto is requiring this when building as a RPM on a hardened base OS with GCC 11.3 Dan Lutker has updated the pull request incrementally with one additional commit since the last revision: Remove extra / in copyright ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1333/files - new: https://git.openjdk.org/jdk11u-dev/pull/1333/files/767195be..60860b45 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1333&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1333&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1333.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1333/head:pull/1333 PR: https://git.openjdk.org/jdk11u-dev/pull/1333 From clanger at openjdk.org Mon Aug 22 21:27:40 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 22 Aug 2022 21:27:40 GMT Subject: [jdk11u-dev] RFR: 8275008: gtest build failure due to stringop-overflow warning with gcc11 [v2] In-Reply-To: <6QxGOqLBOg2p-ksFJnqAIKogOB_v1UsUiLYRSTyU1so=.2f3e0522-c2d7-4b8b-95de-29149d476fee@github.com> References: <6QxGOqLBOg2p-ksFJnqAIKogOB_v1UsUiLYRSTyU1so=.2f3e0522-c2d7-4b8b-95de-29149d476fee@github.com> Message-ID: <2C8vfkqYkPzniBfgX_9PM1c7WWhc9XEsZFUSXqAsdwM=.4913ac91-d74c-451a-a969-5e0debc8e244@github.com> On Mon, 22 Aug 2022 21:24:38 GMT, Dan Lutker wrote: >> Backport of c55dd365e3463670697b09de0ff70877203e5a69, which did not apply cleanly due to changes in tip that reworked the make file. >> >> Corretto is requiring this when building as a RPM on a hardened base OS with GCC 11.3 > > Dan Lutker has updated the pull request incrementally with one additional commit since the last revision: > > Remove extra / in copyright Changes requested by clanger (Reviewer). make/hotspot/lib/CompileGtest.gmk line 2: > 1: # > 2: # Copyright (c) 2016, 2021/, Oracle and/or its affiliates. All rights reserved. I think a / sneaked in here. Please fix. ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1333 From duke at openjdk.org Mon Aug 22 21:27:41 2022 From: duke at openjdk.org (Dan Lutker) Date: Mon, 22 Aug 2022 21:27:41 GMT Subject: [jdk11u-dev] RFR: 8275008: gtest build failure due to stringop-overflow warning with gcc11 [v2] In-Reply-To: <2C8vfkqYkPzniBfgX_9PM1c7WWhc9XEsZFUSXqAsdwM=.4913ac91-d74c-451a-a969-5e0debc8e244@github.com> References: <6QxGOqLBOg2p-ksFJnqAIKogOB_v1UsUiLYRSTyU1so=.2f3e0522-c2d7-4b8b-95de-29149d476fee@github.com> <2C8vfkqYkPzniBfgX_9PM1c7WWhc9XEsZFUSXqAsdwM=.4913ac91-d74c-451a-a969-5e0debc8e244@github.com> Message-ID: On Mon, 22 Aug 2022 21:19:07 GMT, Christoph Langer wrote: >> Dan Lutker has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove extra / in copyright > > make/hotspot/lib/CompileGtest.gmk line 2: > >> 1: # >> 2: # Copyright (c) 2016, 2021/, Oracle and/or its affiliates. All rights reserved. > > I think a / sneaked in here. Please fix. ? Doh, thanks for catching. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1333 From duke at openjdk.org Mon Aug 22 21:28:42 2022 From: duke at openjdk.org (Salander) Date: Mon, 22 Aug 2022 21:28:42 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v9] In-Reply-To: <5Gc-m9mr2Ku4SS8mn-NsCOMEIWnLhE6rT-QrOrl0fos=.8b91d64e-14b2-4797-a81f-44cea6322d86@github.com> References: <1pI5dmjx8yM8nRpsWpSHWD78rp09UT65Q1hSDbRKKQ4=.005bd67c-416e-48d4-84a4-797c78124b0b@github.com> <5Gc-m9mr2Ku4SS8mn-NsCOMEIWnLhE6rT-QrOrl0fos=.8b91d64e-14b2-4797-a81f-44cea6322d86@github.com> Message-ID: On Mon, 22 Aug 2022 21:17:15 GMT, Christoph Langer wrote: > The more I look at this, I think we should strive for a clean & full backport of https://bugs.openjdk.java.net/browse/JDK-8229258 if this is required to enable clang13 compilation. Yes, I agree. I was going to suggest that myself but I'm temporarily without reliable internet so I haven't been able to work on this for a while. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From clanger at openjdk.org Mon Aug 22 21:33:39 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 22 Aug 2022 21:33:39 GMT Subject: [jdk11u-dev] RFR: 8275008: gtest build failure due to stringop-overflow warning with gcc11 [v2] In-Reply-To: <6QxGOqLBOg2p-ksFJnqAIKogOB_v1UsUiLYRSTyU1so=.2f3e0522-c2d7-4b8b-95de-29149d476fee@github.com> References: <6QxGOqLBOg2p-ksFJnqAIKogOB_v1UsUiLYRSTyU1so=.2f3e0522-c2d7-4b8b-95de-29149d476fee@github.com> Message-ID: On Mon, 22 Aug 2022 21:27:39 GMT, Dan Lutker wrote: >> Backport of c55dd365e3463670697b09de0ff70877203e5a69, which did not apply cleanly due to changes in tip that reworked the make file. >> >> Corretto is requiring this when building as a RPM on a hardened base OS with GCC 11.3 > > Dan Lutker has updated the pull request incrementally with one additional commit since the last revision: > > Remove extra / in copyright Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1333 From duke at openjdk.org Tue Aug 23 06:22:47 2022 From: duke at openjdk.org (Alexey Pavlyutkin) Date: Tue, 23 Aug 2022 06:22:47 GMT Subject: [jdk17u-dev] Integrated: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData In-Reply-To: <8QCOUsmBpDj1zRD2iOc_bQS1d8s3k9c2FYzYbwMkA8E=.73649a93-1a56-4b46-a5ab-e19a53a63b92@github.com> References: <8QCOUsmBpDj1zRD2iOc_bQS1d8s3k9c2FYzYbwMkA8E=.73649a93-1a56-4b46-a5ab-e19a53a63b92@github.com> Message-ID: On Mon, 22 Aug 2022 08:31:01 GMT, Alexey Pavlyutkin wrote: > Hi! Here is backport of 8272417 that fixes a crash in ClassLoaderData logging that takes place for debug build. The patch is applied cleanly > > Verification (amd64 / Ubuntu 20.04) > > alex at alex-VirtualBox:~/8272417$ echo "public class A { public static void main(String... args) { System.gc(); } }" > A.java > alex at alex-VirtualBox:~/8272417$ ./build/linux-x86_64-server-fastdebug/images/jdk/bin/java -XX:+UseZGC -XX:+VerifyAfterGC -Xlog:gc*=trace A.java This pull request has now been integrated. Changeset: 2796eca9 Author: Alexey Pavlyutkin Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk17u-dev/commit/2796eca91c45e28329a1017ed6f27fb1cae770f1 Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData Backport-of: 741f58c18c3dc49c5e1b793e411d8479770f2772 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/643 From roland at openjdk.org Tue Aug 23 07:30:56 2022 From: roland at openjdk.org (Roland Westrelin) Date: Tue, 23 Aug 2022 07:30:56 GMT Subject: [jdk11u-dev] Integrated: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389 In-Reply-To: References: Message-ID: On Fri, 19 Aug 2022 12:54:38 GMT, Roland Westrelin wrote: > This fixes an issue with the backport of > https://bugs.openjdk.org/browse/JDK-8223363: > > https://github.com/openjdk/jdk11u/commit/5f40afc10909061b5b4e17ec59856611e160e474 > > where a line that should have been removed wasn't. This pull request has now been integrated. Changeset: 5d344f1a Author: Roland Westrelin URL: https://git.openjdk.org/jdk11u-dev/commit/5d344f1a2fb974e9e315ce81b6d9ec68ef9834ef Stats: 64 lines in 2 files changed: 63 ins; 1 del; 0 mod 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389 Reviewed-by: phh, xliu, clanger ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1335 From duke at openjdk.org Tue Aug 23 09:45:38 2022 From: duke at openjdk.org (xpbob) Date: Tue, 23 Aug 2022 09:45:38 GMT Subject: [jdk11u-dev] Integrated: 8284950: CgroupV1 detection code should consider memory.swappiness In-Reply-To: References: Message-ID: On Mon, 22 Aug 2022 03:12:03 GMT, xpbob wrote: > Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 This pull request has now been integrated. Changeset: 317f79cc Author: bobpengxie Committer: Jie Fu URL: https://git.openjdk.org/jdk11u-dev/commit/317f79cc80cd46fc61899f885e3946de989d8bdf Stats: 142 lines in 4 files changed: 137 ins; 0 del; 5 mod 8284950: CgroupV1 detection code should consider memory.swappiness Backport-of: 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1336 From duke at openjdk.org Tue Aug 23 09:45:59 2022 From: duke at openjdk.org (xpbob) Date: Tue, 23 Aug 2022 09:45:59 GMT Subject: [jdk17u-dev] Integrated: 8284950: CgroupV1 detection code should consider memory.swappiness In-Reply-To: References: Message-ID: On Mon, 22 Aug 2022 02:59:44 GMT, xpbob wrote: > Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 This pull request has now been integrated. Changeset: b30d962f Author: bobpengxie Committer: Jie Fu URL: https://git.openjdk.org/jdk17u-dev/commit/b30d962f27024448a43f2b45d30730b4d88626b8 Stats: 142 lines in 4 files changed: 137 ins; 0 del; 5 mod 8284950: CgroupV1 detection code should consider memory.swappiness Backport-of: 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/641 From yan at openjdk.org Tue Aug 23 12:19:06 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 23 Aug 2022 12:19:06 GMT Subject: [jdk15u-dev] RFR: 8282071: Update java.xml module-info Message-ID: <8DBT8DrlQmapSE3fWcHMJsD5qDfNAoKNL8nTupXJjWM=.f613540f-ef5c-4fc9-aff8-9ac29848a9e0@github.com> Fix of a cut/paste typo in module-info.java file. First hunk is dropped as not applicable, and all the environment of that document in older releases is completely different, so the change applied manually, all its three lines. ------------- Commit messages: - Backport c86c51cc72e3457756434b9150b0c5ef2f5d496d Changes: https://git.openjdk.org/jdk15u-dev/pull/257/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=257&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282071 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/257.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/257/head:pull/257 PR: https://git.openjdk.org/jdk15u-dev/pull/257 From yan at openjdk.org Tue Aug 23 12:26:02 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 23 Aug 2022 12:26:02 GMT Subject: [jdk13u-dev] RFR: 8282071: Update java.xml module-info Message-ID: <0Q0sno-08JFzdivmY8Vuf9wKDq47f67VVazE2_rRVAU=.514bb8dd-deaa-46e7-828c-b1c3312e322e@github.com> Fix of a cut/paste typo in module-info.java file. First hunk is dropped as not applicable, and all the environment of that document in older releases is completely different, so the change applied manually, all its three lines. ------------- Commit messages: - Backport c86c51cc72e3457756434b9150b0c5ef2f5d496d Changes: https://git.openjdk.org/jdk13u-dev/pull/391/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=391&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282071 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/391.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/391/head:pull/391 PR: https://git.openjdk.org/jdk13u-dev/pull/391 From dcherepanov at openjdk.org Tue Aug 23 12:32:33 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Tue, 23 Aug 2022 12:32:33 GMT Subject: [jdk13u-dev] RFR: 8282071: Update java.xml module-info In-Reply-To: <0Q0sno-08JFzdivmY8Vuf9wKDq47f67VVazE2_rRVAU=.514bb8dd-deaa-46e7-828c-b1c3312e322e@github.com> References: <0Q0sno-08JFzdivmY8Vuf9wKDq47f67VVazE2_rRVAU=.514bb8dd-deaa-46e7-828c-b1c3312e322e@github.com> Message-ID: <5a6DAJkhyKeOwTipeBbpC9FwwxsjtGanQK4AevAwerc=.5905bf27-63ac-4df6-81bc-2a9ddd8a4d8d@github.com> On Tue, 23 Aug 2022 12:19:00 GMT, Yuri Nesterenko wrote: > Fix of a cut/paste typo in module-info.java file. First hunk is dropped as not applicable, and all the environment of that document in older releases is completely different, so the change applied manually, all its three lines. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/391 From dcherepanov at openjdk.org Tue Aug 23 12:33:29 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Tue, 23 Aug 2022 12:33:29 GMT Subject: [jdk15u-dev] RFR: 8282071: Update java.xml module-info In-Reply-To: <8DBT8DrlQmapSE3fWcHMJsD5qDfNAoKNL8nTupXJjWM=.f613540f-ef5c-4fc9-aff8-9ac29848a9e0@github.com> References: <8DBT8DrlQmapSE3fWcHMJsD5qDfNAoKNL8nTupXJjWM=.f613540f-ef5c-4fc9-aff8-9ac29848a9e0@github.com> Message-ID: <0TtQKW2Lu1bX-Ri3ZU_2p-aLmjfxrOOTr-JHzm0n_eM=.3b97553b-761c-4494-96c9-1ca027a1de45@github.com> On Tue, 23 Aug 2022 12:10:19 GMT, Yuri Nesterenko wrote: > Fix of a cut/paste typo in module-info.java file. First hunk is dropped as not applicable, and all the environment of that document in older releases is completely different, so the change applied manually, all its three lines. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/257 From yan at openjdk.org Tue Aug 23 12:37:24 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 23 Aug 2022 12:37:24 GMT Subject: [jdk13u-dev] Integrated: 8282071: Update java.xml module-info In-Reply-To: <0Q0sno-08JFzdivmY8Vuf9wKDq47f67VVazE2_rRVAU=.514bb8dd-deaa-46e7-828c-b1c3312e322e@github.com> References: <0Q0sno-08JFzdivmY8Vuf9wKDq47f67VVazE2_rRVAU=.514bb8dd-deaa-46e7-828c-b1c3312e322e@github.com> Message-ID: On Tue, 23 Aug 2022 12:19:00 GMT, Yuri Nesterenko wrote: > Fix of a cut/paste typo in module-info.java file. First hunk is dropped as not applicable, and all the environment of that document in older releases is completely different, so the change applied manually, all its three lines. This pull request has now been integrated. Changeset: 1e900aca Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/1e900aca0284e5e1adc24ce01fbb687351a3f950 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8282071: Update java.xml module-info Reviewed-by: dcherepanov Backport-of: c86c51cc72e3457756434b9150b0c5ef2f5d496d ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/391 From yan at openjdk.org Tue Aug 23 12:39:47 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 23 Aug 2022 12:39:47 GMT Subject: [jdk15u-dev] Integrated: 8282071: Update java.xml module-info In-Reply-To: <8DBT8DrlQmapSE3fWcHMJsD5qDfNAoKNL8nTupXJjWM=.f613540f-ef5c-4fc9-aff8-9ac29848a9e0@github.com> References: <8DBT8DrlQmapSE3fWcHMJsD5qDfNAoKNL8nTupXJjWM=.f613540f-ef5c-4fc9-aff8-9ac29848a9e0@github.com> Message-ID: On Tue, 23 Aug 2022 12:10:19 GMT, Yuri Nesterenko wrote: > Fix of a cut/paste typo in module-info.java file. First hunk is dropped as not applicable, and all the environment of that document in older releases is completely different, so the change applied manually, all its three lines. This pull request has now been integrated. Changeset: a8a31041 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/a8a310412981c7ba444ded56953aa80121c4751b Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8282071: Update java.xml module-info Reviewed-by: dcherepanov Backport-of: c86c51cc72e3457756434b9150b0c5ef2f5d496d ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/257 From duke at openjdk.org Tue Aug 23 13:02:47 2022 From: duke at openjdk.org (Joshua Cao) Date: Tue, 23 Aug 2022 13:02:47 GMT Subject: [jdk17u-dev] Integrated: 8227651: Tests fail with SSLProtocolException: Input record too big In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 22:59:44 GMT, Joshua Cao wrote: > Clean backport. > > On our systems, LargePackage.java fails more than half of the time, and SSLEngineExplorerWithSrv.java fails occassionally. This change seems to stabilize those tests. This pull request has now been integrated. Changeset: 6d2cddf5 Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/6d2cddf54b9e74fa15bc3579a4c4f9e841c94d12 Stats: 51 lines in 8 files changed: 5 ins; 5 del; 41 mod 8227651: Tests fail with SSLProtocolException: Input record too big 8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch Backport-of: 7b029ea6ba1d44d361fdf980816732d8454b8194 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/639 From clanger at openjdk.org Tue Aug 23 21:12:30 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 23 Aug 2022 21:12:30 GMT Subject: [jdk19u] RFR: 8227651: Tests fail with SSLProtocolException: Input record too big Message-ID: Hi all, This pull request contains a backport of https://bugs.openjdk.org/browse/JDK-8227651, commit [7b029ea6](https://github.com/openjdk/jdk/commit/7b029ea6ba1d44d361fdf980816732d8454b8194) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Daniel Jeli?ski on 10 Aug 2022 and was reviewed by Sean Coffey and Xue-Lei Andrew Fan. Thanks! ------------- Commit messages: - Backport 7b029ea6ba1d44d361fdf980816732d8454b8194 Changes: https://git.openjdk.org/jdk19u/pull/12/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=12&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8227651 Stats: 51 lines in 8 files changed: 5 ins; 5 del; 41 mod Patch: https://git.openjdk.org/jdk19u/pull/12.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/12/head:pull/12 PR: https://git.openjdk.org/jdk19u/pull/12 From duke at openjdk.org Tue Aug 23 22:02:13 2022 From: duke at openjdk.org (Dan Lutker) Date: Tue, 23 Aug 2022 22:02:13 GMT Subject: [jdk11u-dev] Integrated: 8275008: gtest build failure due to stringop-overflow warning with gcc11 In-Reply-To: References: Message-ID: On Thu, 18 Aug 2022 23:01:27 GMT, Dan Lutker wrote: > Backport of c55dd365e3463670697b09de0ff70877203e5a69, which did not apply cleanly due to changes in tip that reworked the make file. > > Corretto is requiring this when building as a RPM on a hardened base OS with GCC 11.3 This pull request has now been integrated. Changeset: e0d592b9 Author: Dan Lutker <61068077+lutkerd at users.noreply.github.com> Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/e0d592b9ce0715c4d0c18d8ac79e949d15e67a7e Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8275008: gtest build failure due to stringop-overflow warning with gcc11 Reviewed-by: phh, clanger Backport-of: c55dd365e3463670697b09de0ff70877203e5a69 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1333 From clanger at openjdk.org Wed Aug 24 04:43:33 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 04:43:33 GMT Subject: [jdk11u-dev] RFR: 8284950: CgroupV1 detection code should consider memory.swappiness In-Reply-To: References: Message-ID: On Mon, 22 Aug 2022 03:12:03 GMT, xpbob wrote: > Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 @xpbob, the test case is failing. Did you run this at all when you backported it? test result: Error. can't find jdk.test.lib.helpers.ClassFileInstaller in test directory or libraries Looks like ClassFileInstaller lives in another place in 11u. Please fix this asap! Thanks ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1336 From clanger at openjdk.org Wed Aug 24 05:56:40 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 05:56:40 GMT Subject: [jdk19u] RFR: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist Message-ID: Hi all, This pull request contains a backport of https://bugs.openjdk.org/browse/JDK-8284977, commit [444a0d98](https://github.com/openjdk/jdk/commit/444a0d98ac06ab043e3b11281234fd515abff302) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Matthias Baesken on 15 Jun 2022 and was reviewed by Severin Gehwolf and Martin Doerr. Thanks! ------------- Commit messages: - Backport 444a0d98ac06ab043e3b11281234fd515abff302 Changes: https://git.openjdk.org/jdk19u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=13&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284977 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/13.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/13/head:pull/13 PR: https://git.openjdk.org/jdk19u/pull/13 From duke at openjdk.org Wed Aug 24 06:15:31 2022 From: duke at openjdk.org (xpbob) Date: Wed, 24 Aug 2022 06:15:31 GMT Subject: [jdk11u-dev] RFR: 8284950: CgroupV1 detection code should consider memory.swappiness In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 04:38:44 GMT, Christoph Langer wrote: >> Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 > > @xpbob, the test case is failing. Did you run this at all when you backported it? > > test result: Error. can't find jdk.test.lib.helpers.ClassFileInstaller in test directory or libraries > > Looks like ClassFileInstaller lives in another place in 11u. > > Please fix this asap! Thanks @RealCLanger Sorry for this bug. I'll look at it immediately. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1336 From duke at openjdk.org Wed Aug 24 08:14:26 2022 From: duke at openjdk.org (xpbob) Date: Wed, 24 Aug 2022 08:14:26 GMT Subject: [jdk11u-dev] RFR: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 Message-ID: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 Changed the startup command This test case succeeded on my machine ------------- Commit messages: - 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 Changes: https://git.openjdk.org/jdk11u-dev/pull/1337/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1337&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292852 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1337.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1337/head:pull/1337 PR: https://git.openjdk.org/jdk11u-dev/pull/1337 From duke at openjdk.org Wed Aug 24 08:15:26 2022 From: duke at openjdk.org (xpbob) Date: Wed, 24 Aug 2022 08:15:26 GMT Subject: [jdk11u-dev] RFR: 8284950: CgroupV1 detection code should consider memory.swappiness In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 04:38:44 GMT, Christoph Langer wrote: >> Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 > > @xpbob, the test case is failing. Did you run this at all when you backported it? > > test result: Error. can't find jdk.test.lib.helpers.ClassFileInstaller in test directory or libraries > > Looks like ClassFileInstaller lives in another place in 11u. > > Please fix this asap! Thanks @RealCLanger I fix it in this pr https://github.com/openjdk/jdk11u-dev/pull/1337 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1336 From clanger at openjdk.org Wed Aug 24 08:37:05 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 08:37:05 GMT Subject: [jdk11u-dev] RFR: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 08:06:47 GMT, xpbob wrote: > 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 > > Changed the startup command > > This test case succeeded on my machine Thanks for fixing. Looks good and trivial. Please flag the bug with jdk11u-fix-request. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1337 From duke at openjdk.org Wed Aug 24 09:07:02 2022 From: duke at openjdk.org (xpbob) Date: Wed, 24 Aug 2022 09:07:02 GMT Subject: [jdk11u-dev] RFR: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 08:33:48 GMT, Christoph Langer wrote: >> 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 >> >> Changed the startup command >> >> This test case succeeded on my machine > > Thanks for fixing. Looks good and trivial. > > Please flag the bug with jdk11u-fix-request. @RealCLanger Thanks for review I've flagged the bug with jdk11u-fix-request ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1337 From duke at openjdk.org Wed Aug 24 09:15:39 2022 From: duke at openjdk.org (George Adams) Date: Wed, 24 Aug 2022 09:15:39 GMT Subject: [jdk11u-dev] RFR: 8242468: VS2019 build missing vcruntime140_1.dll [v2] In-Reply-To: <0xc2htZtTmpcl8SRH2YR3BppPelv-lalDvxn22zdM8s=.458dac49-a6ff-475e-a406-514835db63f2@github.com> References: <0xc2htZtTmpcl8SRH2YR3BppPelv-lalDvxn22zdM8s=.458dac49-a6ff-475e-a406-514835db63f2@github.com> Message-ID: <43Aqj9mAfbadZdJD8Bd0byUR-Nk1puIKl15Vt1s3PGs=.41b133c0-e25e-47c0-8a87-2b5a23f14ed5@github.com> > Fixes an issue observed at Adoptium when bumping the compiler to VS 2019 (https://github.com/adoptium/temurin-build/issues/3052) George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 165fa2450c1a7550d723be4c62bf54de464798bb ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1247/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1247&range=01 Stats: 68 lines in 9 files changed: 63 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1247.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1247/head:pull/1247 PR: https://git.openjdk.org/jdk11u-dev/pull/1247 From duke at openjdk.org Wed Aug 24 09:15:40 2022 From: duke at openjdk.org (George Adams) Date: Wed, 24 Aug 2022 09:15:40 GMT Subject: [jdk11u-dev] RFR: 8242468: VS2019 build missing vcruntime140_1.dll In-Reply-To: <0xc2htZtTmpcl8SRH2YR3BppPelv-lalDvxn22zdM8s=.458dac49-a6ff-475e-a406-514835db63f2@github.com> References: <0xc2htZtTmpcl8SRH2YR3BppPelv-lalDvxn22zdM8s=.458dac49-a6ff-475e-a406-514835db63f2@github.com> Message-ID: On Wed, 20 Jul 2022 11:52:50 GMT, George Adams wrote: > Fixes an issue observed at Adoptium when bumping the compiler to VS 2019 (https://github.com/adoptium/temurin-build/issues/3052) > Hm, as you are backporting 8239708 in https://github.com/openjdk/jdk11u-dev/pull/1277, I think you should do this backport afterwards. It'll then probably apply cleanly. As of now it looks as if you'd have forgotten this change in basics.m4 in https://github.com/openjdk/jdk11u-dev/pull/1277 I've switched the base now so this should be good ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1247 From duke at openjdk.org Wed Aug 24 09:16:07 2022 From: duke at openjdk.org (George Adams) Date: Wed, 24 Aug 2022 09:16:07 GMT Subject: [jdk11u-dev] RFR: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows [v3] In-Reply-To: <4Z2b5lNigLLz7Xt6P87NFZOfnEfElt34K9XvbA8KpM8=.075192ab-4464-4e30-b65d-30ae2aa82644@github.com> References: <4Z2b5lNigLLz7Xt6P87NFZOfnEfElt34K9XvbA8KpM8=.075192ab-4464-4e30-b65d-30ae2aa82644@github.com> Message-ID: > depends on https://github.com/openjdk/jdk11u-dev/pull/1247. CC @GoeLin who requested this backport be raised in parallel. George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport bcc668b77f0a0c22db49ef048286a9df5c04a308 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1275/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1275&range=02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1275.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1275/head:pull/1275 PR: https://git.openjdk.org/jdk11u-dev/pull/1275 From duke at openjdk.org Wed Aug 24 09:18:24 2022 From: duke at openjdk.org (xpbob) Date: Wed, 24 Aug 2022 09:18:24 GMT Subject: [jdk11u-dev] Integrated: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 08:06:47 GMT, xpbob wrote: > 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 > > Changed the startup command > > This test case succeeded on my machine This pull request has now been integrated. Changeset: 75e4cb38 Author: bobpengxie Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/75e4cb38910948634b816e4f4db36b8525d232c8 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1337 From clanger at openjdk.org Wed Aug 24 09:51:37 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 09:51:37 GMT Subject: [jdk11u-dev] RFR: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 08:33:48 GMT, Christoph Langer wrote: >> 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 >> >> Changed the startup command >> >> This test case succeeded on my machine > > Thanks for fixing. Looks good and trivial. > > Please flag the bug with jdk11u-fix-request. > @RealCLanger Thanks for review I've flagged the bug with jdk11u-fix-request Thanks for the quick fix! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1337 From aoqi at openjdk.org Wed Aug 24 10:20:08 2022 From: aoqi at openjdk.org (Ao Qi) Date: Wed, 24 Aug 2022 10:20:08 GMT Subject: [jdk11u-dev] RFR: 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled Message-ID: I backport this for parity with 11.0.18-oracle. Low risk, only a test change. Clean backport. ------------- Commit messages: - Backport 7552915d3ff1bf2cb57cf10ec67b57ddf8321d87 Changes: https://git.openjdk.org/jdk11u-dev/pull/1338/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1338&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8238586 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1338.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1338/head:pull/1338 PR: https://git.openjdk.org/jdk11u-dev/pull/1338 From sgehwolf at openjdk.org Wed Aug 24 15:08:41 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 24 Aug 2022 15:08:41 GMT Subject: [jdk11u-dev] RFR: 8287073: NPE from CgroupV2Subsystem.getInstance() Message-ID: Backport fixing a potential NPE on cgroups v2. ------------- Commit messages: - Backport 744b822ab194a0f7ef4e7a4053be32c6a0889efc Changes: https://git.openjdk.org/jdk11u-dev/pull/1339/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1339&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287073 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1339.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1339/head:pull/1339 PR: https://git.openjdk.org/jdk11u-dev/pull/1339 From rob.mckenna at oracle.com Wed Aug 24 16:33:31 2022 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Wed, 24 Aug 2022 16:33:31 +0000 Subject: [19u Communication] Heads up: Final few days for 19.0.1 fixes Message-ID: Please get your fixes in by Monday. -Rob From aoqi at openjdk.org Wed Aug 24 17:35:10 2022 From: aoqi at openjdk.org (Ao Qi) Date: Wed, 24 Aug 2022 17:35:10 GMT Subject: [jdk19u] RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName Message-ID: <4ZDLjgOwlHKOgoy1d_wD00VNFn5JGgQuRJN_To8GooA=.1a508467-9d67-444c-9229-d0642251619c@github.com> I would like to backport this test fix. Low risk, only test changes. Clean backport. The changed tests passed. ------------- Commit messages: - Backport dedc05cb40617f7b7e2cc235528b1892dcba4cd3 Changes: https://git.openjdk.org/jdk19u/pull/15/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=15&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291640 Stats: 5 lines in 3 files changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk19u/pull/15.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/15/head:pull/15 PR: https://git.openjdk.org/jdk19u/pull/15 From aoqi at openjdk.org Wed Aug 24 17:38:04 2022 From: aoqi at openjdk.org (Ao Qi) Date: Wed, 24 Aug 2022 17:38:04 GMT Subject: [jdk19u] RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" Message-ID: I would like to backport this test fix. Low risk, only test changes. Clean backport. The changed tests passed. ------------- Commit messages: - Backport 0cc49fd9eac5259543a3c41b7a32b6e01a1b0ad5 Changes: https://git.openjdk.org/jdk19u/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=14&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291508 Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/14.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/14/head:pull/14 PR: https://git.openjdk.org/jdk19u/pull/14 From sgehwolf at openjdk.org Wed Aug 24 17:46:22 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 24 Aug 2022 17:46:22 GMT Subject: [jdk11u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller Message-ID: <8mCJLmVWCWtVzwXyqw7XMqFGmjN-dQT20c1Y2nAOdVc=.c43c842a-a768-4f03-a73b-dd64e47a1817@github.com> Clean backport. Issue present on 11.0.16 too, low risk. ------------- Commit messages: - Backport 704b9a66bba0dc8adb62be80fd62864b9c687c3f Changes: https://git.openjdk.org/jdk11u-dev/pull/1340/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1340&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287107 Stats: 117 lines in 3 files changed: 114 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1340.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1340/head:pull/1340 PR: https://git.openjdk.org/jdk11u-dev/pull/1340 From sgehwolf at openjdk.org Wed Aug 24 17:55:03 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 24 Aug 2022 17:55:03 GMT Subject: [jdk11u-dev] RFR: 8287663: Add a regression test for JDK-8287073 Message-ID: Clean backport after "[JDK-8287107](https://bugs.openjdk.org/browse/JDK-8287107): CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller". Mostly a regression test, low risk. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1340 Commit messages: - 8287663: Add a regression test for JDK-8287073 Changes: https://git.openjdk.org/jdk11u-dev/pull/1341/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1341&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287663 Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1341.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1341/head:pull/1341 PR: https://git.openjdk.org/jdk11u-dev/pull/1341 From christoph.langer at sap.com Wed Aug 24 20:08:42 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 24 Aug 2022 20:08:42 +0000 Subject: [17u Communication] JDK 17.0.5 Rampdown starts Tuesday, August 30, 18:00 CET. Message-ID: Hi, I would like to remind everybody who is working on JDK 17 updates that Rampdown of 17.0.5 starts next Tuesday, August 30, at 18:00 CET. At that point in time the last merge from jdk17u-dev to jdk17u will take place. Please push all changes you want to get to 17.0.5 before that date. After that, changes for 17.0.5 must be requested with jdk17u-critical-request tags, and they need to be pushed directly to jdk17u. Best regards, Christoph See also https://wiki.openjdk.org/display/JDKUpdates/JDK+17u -------------- next part -------------- An HTML attachment was scrubbed... URL: From christoph.langer at sap.com Wed Aug 24 20:08:50 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 24 Aug 2022 20:08:50 +0000 Subject: [11u Communication] JDK 11.0.17 Rampdown starts Tuesday, August 30, 18:00 CET. Message-ID: Hi, I would like to remind everybody who is working on JDK 11 updates that Rampdown of 11.0.17 starts next Tuesday, August 30, at 18:00 CET. At that point in time the last merge from jdk11u-dev to jdk11u will take place. Please push all changes you want to get to 11.0.17 before that date. After that, changes for 11.0.17 must be requested with jdk11u-critical-request tags, and they need to be pushed directly to jdk11u. Best regards, Christoph See also https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u -------------- next part -------------- An HTML attachment was scrubbed... URL: From clanger at openjdk.org Wed Aug 24 20:22:38 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 20:22:38 GMT Subject: [jdk11u-dev] RFR: 8276841: Add support for Visual Studio 2022 In-Reply-To: References: Message-ID: On Tue, 12 Jul 2022 02:53:38 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [f65db88b](https://github.com/openjdk/jdk/commit/f65db88b74911e5896d2ff536c4ac97e7f62d98b) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Yasumasa Suenaga on 9 Nov 2021 and was reviewed by Erik Joelsson and Magnus Ihse Bursie. > > The change is not "clean" because the jdk11u supports more versions than the jdk/jdk. > I have tested the build using VS 2019 and 2022, results of tier1/tier2 are the same. > > Thanks! @mrserb would you mind to integrate this before 11.0.17 rampdown next week? Thanks! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1216 From clanger at openjdk.org Wed Aug 24 20:25:34 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 20:25:34 GMT Subject: [jdk11u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Fri, 19 Aug 2022 09:15:39 GMT, Ji?? Van?k wrote: > 8282947: JFR: Dump on shutdown live-locks in some conditions @judovana Would you mind to integrate this PR before rampdown of 11.0.17 next week? Thanks! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1334 From clanger at openjdk.org Wed Aug 24 20:35:38 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 20:35:38 GMT Subject: [jdk11u-dev] RFR: 8230708: Hotspot fails to build on linux-sparc with gcc-9 In-Reply-To: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> References: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> Message-ID: On Thu, 18 Aug 2022 02:26:26 GMT, Richard-Rogalski wrote: > Backport of bug 8230708. Tested and worked for me and one other user of sparc/linux. > > I signed the OCA: it is under review, will update when it goes through. > > This should be fairly low risk: it only touches sparc-specific code. > > I appreciate your time :^) @Richard-Rogalski Before integrating a PR via `/integrate`, you need to request maintainer approval by flagging the JBS issue with jdk11u-fix-request and adding a fix request comment, stating why you want to bring in this backport, some risk assessment and state what testing you did. Only when it is approved via the jdk11u-fix-yes label, you are allowed to merge. For some more detailed instruction about the backport process, please consult our [Wiki page](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix). As I assume, you don't have a JBS user account, I can add the request on your behalf. Please write me some text that I can use as fix request comment. Furthermore, I'd like to ask you to run Github Actions testing as a basic acceptance check. You have to enable Actions on your forked repository. You can trigger a run by merging master into this PR. Thanks, Christoph ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1330 From duke at openjdk.org Wed Aug 24 20:46:06 2022 From: duke at openjdk.org (Salander) Date: Wed, 24 Aug 2022 20:46:06 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v10] In-Reply-To: References: Message-ID: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > > https://bugs.openjdk.java.net/browse/JDK-8229258 > https://bugs.gentoo.org/817995 > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > https://reviews.llvm.org/D99790#2678384 > > This is a re-do of @Serebit's PR that erroneously targeted the jdk11u repository ([link](https://github.com/openjdk/jdk11u/pull/23)), the only difference is that some errors in the backport were corrected in the `shenandoahForwarding.inline.hpp` file to fix some compilation errors when compiling with `shenandoahgc` enabled. Salander has updated the pull request incrementally with one additional commit since the last revision: Rework markOops into markWord ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1284/files - new: https://git.openjdk.org/jdk11u-dev/pull/1284/files/dc8bedce..a24726d6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=09 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1284&range=08-09 Stats: 2033 lines in 165 files changed: 550 ins; 616 del; 867 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk11u-dev/pull/1284 From clanger at openjdk.org Wed Aug 24 20:48:51 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 20:48:51 GMT Subject: [jdk11u-dev] RFR: 8292887: Bump update version for OpenJDK: jdk-11.0.18 Message-ID: Prepare for 11.0.18 development. ------------- Commit messages: - JDK-8292887 Changes: https://git.openjdk.org/jdk11u-dev/pull/1342/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1342&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292887 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1342.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1342/head:pull/1342 PR: https://git.openjdk.org/jdk11u-dev/pull/1342 From clanger at openjdk.org Wed Aug 24 20:54:29 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 24 Aug 2022 20:54:29 GMT Subject: [jdk17u-dev] RFR: 8292888: Bump update version for OpenJDK: jdk-17.0.6 Message-ID: Prepare for 17.0.6 development ------------- Commit messages: - JDK-8292888 Changes: https://git.openjdk.org/jdk17u-dev/pull/644/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=644&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292888 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/644.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/644/head:pull/644 PR: https://git.openjdk.org/jdk17u-dev/pull/644 From aoqi at openjdk.org Thu Aug 25 03:23:43 2022 From: aoqi at openjdk.org (Ao Qi) Date: Thu, 25 Aug 2022 03:23:43 GMT Subject: [jdk11u-dev] RFR: 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 10:11:54 GMT, Ao Qi wrote: > I backport this for parity with 11.0.18-oracle. Low risk, only a test change. Clean backport. The changed test passes. Got the `jdk11u-fix-yes`. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1338 From aoqi at openjdk.org Thu Aug 25 03:35:31 2022 From: aoqi at openjdk.org (Ao Qi) Date: Thu, 25 Aug 2022 03:35:31 GMT Subject: [jdk11u-dev] Integrated: 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 10:11:54 GMT, Ao Qi wrote: > I backport this for parity with 11.0.18-oracle. Low risk, only a test change. Clean backport. The changed test passes. This pull request has now been integrated. Changeset: 1d7b2929 Author: Ao Qi Committer: Jie Fu URL: https://git.openjdk.org/jdk11u-dev/commit/1d7b2929ffa096423a5d37534466ed145c0ae526 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled Backport-of: 7552915d3ff1bf2cb57cf10ec67b57ddf8321d87 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1338 From aoqi at openjdk.org Thu Aug 25 03:40:30 2022 From: aoqi at openjdk.org (Ao Qi) Date: Thu, 25 Aug 2022 03:40:30 GMT Subject: [jdk11u-dev] RFR: 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 10:11:54 GMT, Ao Qi wrote: > I backport this for parity with 11.0.18-oracle. Low risk, only a test change. Clean backport. The changed test passes. Thanks, @DamonFool ! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1338 From clanger at openjdk.org Thu Aug 25 05:38:48 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 25 Aug 2022 05:38:48 GMT Subject: [jdk11u-dev] RFR: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output Message-ID: Backport does not apply cleanly which unveils a shortcoming of the fix https://bugs.openjdk.org/browse/JDK-8267880 https://github.com/openjdk/jdk11u-dev/commit/9cf9879a4e4a78ed8e6d9b1f979de1eb7f75badf The test had been adapted at various places from sha1->sha256 but the two modified locations are still at sha1. We see the test failing on a few systems which should be fixed herewith. I will also backport the follow-up https://bugs.openjdk.org/browse/JDK-8279385 ------------- Commit messages: - Backport 8b5ff4bdffc8f32317d67b00c085071d6c772b30 Changes: https://git.openjdk.org/jdk11u-dev/pull/1343/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1343&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278344 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1343.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1343/head:pull/1343 PR: https://git.openjdk.org/jdk11u-dev/pull/1343 From clanger at openjdk.org Thu Aug 25 06:57:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 25 Aug 2022 06:57:55 GMT Subject: [jdk11u-dev] RFR: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 Message-ID: Follow up after [JDK-8278344](https://bugs.openjdk.org/browse/JDK-8278344). ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1343 Commit messages: - Backport 01f93ddf18daea5c0798ac949c6717c37d9cefa0 Changes: https://git.openjdk.org/jdk11u-dev/pull/1344/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1344&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279385 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1344.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1344/head:pull/1344 PR: https://git.openjdk.org/jdk11u-dev/pull/1344 From clanger at openjdk.org Thu Aug 25 07:24:35 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 25 Aug 2022 07:24:35 GMT Subject: [jdk11u-dev] RFR: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output [v2] In-Reply-To: References: Message-ID: > Backport does not apply cleanly which unveils a shortcoming of the fix > https://bugs.openjdk.org/browse/JDK-8267880 > https://github.com/openjdk/jdk11u-dev/commit/9cf9879a4e4a78ed8e6d9b1f979de1eb7f75badf > > The test had been adapted at various places from sha1->sha256 but the two modified locations are still at sha1. > > We see the test failing on a few systems which should be fixed herewith. > > I will also backport the follow-up https://bugs.openjdk.org/browse/JDK-8279385 Christoph Langer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 8b5ff4bdffc8f32317d67b00c085071d6c772b30 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1343/files - new: https://git.openjdk.org/jdk11u-dev/pull/1343/files/b64b0f84..10fca979 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1343&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1343&range=00-01 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1343.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1343/head:pull/1343 PR: https://git.openjdk.org/jdk11u-dev/pull/1343 From clanger at openjdk.org Thu Aug 25 07:27:35 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 25 Aug 2022 07:27:35 GMT Subject: [jdk11u-dev] RFR: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 [v2] In-Reply-To: References: Message-ID: <4utDXOPQitmvVcZU4y6ZFS3HYtgDn7LuY6l9Fh2GPZ8=.a13aea3c-823a-4663-945e-c4758e486952@github.com> > Follow up after [JDK-8278344](https://bugs.openjdk.org/browse/JDK-8278344). Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 01f93ddf18daea5c0798ac949c6717c37d9cefa0 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1344/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1344&range=01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1344.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1344/head:pull/1344 PR: https://git.openjdk.org/jdk11u-dev/pull/1344 From clanger at openjdk.org Thu Aug 25 07:40:45 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 25 Aug 2022 07:40:45 GMT Subject: [jdk11u-dev] RFR: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output [v2] In-Reply-To: References: Message-ID: <3WbuFTixQTPtRmtFrp7SB6ACzzPsfMZBG0QRlXNpbSo=.05db3852-e987-4de2-98e7-ce4de7a105fd@github.com> On Thu, 25 Aug 2022 07:24:35 GMT, Christoph Langer wrote: >> Backport does not apply cleanly which unveils a shortcoming of the fix >> https://bugs.openjdk.org/browse/JDK-8267880 >> https://github.com/openjdk/jdk11u-dev/commit/9cf9879a4e4a78ed8e6d9b1f979de1eb7f75badf >> >> The test had been adapted at various places from sha1->sha256 but the two modified locations are still at sha1. >> >> We see the test failing on a few systems which should be fixed herewith. >> >> I will also backport the follow-up https://bugs.openjdk.org/browse/JDK-8279385 > > Christoph Langer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 8b5ff4bdffc8f32317d67b00c085071d6c772b30 I took the chance to fix some minor nits to match the code up with head, incorporating diffs from https://bugs.openjdk.org/browse/JDK-8153005 https://bugs.openjdk.org/browse/JDK-8076190 See: https://github.com/openjdk/jdk/blame/master/test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1343 From yan at openjdk.org Thu Aug 25 09:16:49 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 25 Aug 2022 09:16:49 GMT Subject: [jdk15u-dev] RFR: 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups Message-ID: Backporting this fix as an important follow-up to JDK-8251329. Clean backport. Tier1, zipfs -specific tests pass. ------------- Commit messages: - Backport 80cf9f3464c599fb7860432bf4ed506a3b298d8e Changes: https://git.openjdk.org/jdk15u-dev/pull/258/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=258&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286594 Stats: 73 lines in 1 file changed: 31 ins; 38 del; 4 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/258.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/258/head:pull/258 PR: https://git.openjdk.org/jdk15u-dev/pull/258 From yan at openjdk.org Thu Aug 25 09:22:27 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 25 Aug 2022 09:22:27 GMT Subject: [jdk13u-dev] RFR: 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups Message-ID: Backporting this fix as an important follow-up to JDK-8251329. Clean backport. Tier1, zipfs -specific tests pass. ------------- Commit messages: - Backport 80cf9f3464c599fb7860432bf4ed506a3b298d8e Changes: https://git.openjdk.org/jdk13u-dev/pull/392/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=392&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286594 Stats: 73 lines in 1 file changed: 31 ins; 38 del; 4 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/392.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/392/head:pull/392 PR: https://git.openjdk.org/jdk13u-dev/pull/392 From yan at openjdk.org Thu Aug 25 09:25:27 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 25 Aug 2022 09:25:27 GMT Subject: [jdk15u-dev] Integrated: 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 09:06:05 GMT, Yuri Nesterenko wrote: > Backporting this fix as an important follow-up to JDK-8251329. Clean backport. Tier1, zipfs -specific tests pass. This pull request has now been integrated. Changeset: 297b9673 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/297b96730f55d4a2a0674d94ccfd567fc375e930 Stats: 73 lines in 1 file changed: 31 ins; 38 del; 4 mod 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups Backport-of: 80cf9f3464c599fb7860432bf4ed506a3b298d8e ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/258 From yan at openjdk.org Thu Aug 25 09:26:10 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 25 Aug 2022 09:26:10 GMT Subject: [jdk13u-dev] Integrated: 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 09:14:54 GMT, Yuri Nesterenko wrote: > Backporting this fix as an important follow-up to JDK-8251329. Clean backport. Tier1, zipfs -specific tests pass. This pull request has now been integrated. Changeset: 09da466c Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/09da466c714dae0cc9f1189c3168f18bc9281eb9 Stats: 73 lines in 1 file changed: 31 ins; 38 del; 4 mod 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups Backport-of: 80cf9f3464c599fb7860432bf4ed506a3b298d8e ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/392 From jvanek at openjdk.org Thu Aug 25 11:22:25 2022 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 25 Aug 2022 11:22:25 GMT Subject: [jdk11u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Fri, 19 Aug 2022 09:15:39 GMT, Ji?? Van?k wrote: > 8282947: JFR: Dump on shutdown live-locks in some conditions Looking for sponsor, if you would be so kind. TYVM! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1334 From jvanek at openjdk.org Thu Aug 25 11:31:49 2022 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 25 Aug 2022 11:31:49 GMT Subject: [jdk11u-dev] Integrated: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Fri, 19 Aug 2022 09:15:39 GMT, Ji?? Van?k wrote: > 8282947: JFR: Dump on shutdown live-locks in some conditions This pull request has now been integrated. Changeset: 01db4763 Author: Ji?? Van?k Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/01db4763e81c90ab4f3dcaab48d20fde515c6f83 Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod 8282947: JFR: Dump on shutdown live-locks in some conditions Backport-of: 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1334 From yan at openjdk.org Thu Aug 25 14:04:10 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 25 Aug 2022 14:04:10 GMT Subject: [jdk13u-dev] RFR: 7131823: bug in GIFImageReader Message-ID: <685qT3Upqerx5ZlVTGtsR1Lmrf7QiWXHMRyOqguN4BI=.ed642b2e-9ab3-4486-81f5-116c9ee3c8ea@github.com> Backporting this fix for parity with LTS releases. Clean ports; jdk/javax/imageio tests pass. ------------- Commit messages: - Backport a31130fd4056907edcb420761722c629a33273eb Changes: https://git.openjdk.org/jdk13u-dev/pull/393/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=393&range=00 Issue: https://bugs.openjdk.org/browse/JDK-7131823 Stats: 175 lines in 2 files changed: 158 ins; 4 del; 13 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/393.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/393/head:pull/393 PR: https://git.openjdk.org/jdk13u-dev/pull/393 From yan at openjdk.org Thu Aug 25 14:26:07 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 25 Aug 2022 14:26:07 GMT Subject: [jdk15u-dev] RFR: 7131823: bug in GIFImageReader Message-ID: Backporting this fix for parity with LTS releases. Clean ports; jdk/javax/imageio tests pass. ------------- Commit messages: - Backport a31130fd4056907edcb420761722c629a33273eb Changes: https://git.openjdk.org/jdk15u-dev/pull/259/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=259&range=00 Issue: https://bugs.openjdk.org/browse/JDK-7131823 Stats: 175 lines in 2 files changed: 158 ins; 4 del; 13 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/259.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/259/head:pull/259 PR: https://git.openjdk.org/jdk15u-dev/pull/259 From sgehwolf at openjdk.org Thu Aug 25 14:35:41 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 25 Aug 2022 14:35:41 GMT Subject: [jdk11u-dev] RFR: 8292887: Bump update version for OpenJDK: jdk-11.0.18 In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 20:43:30 GMT, Christoph Langer wrote: > Prepare for 11.0.18 development. LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1342 From sgehwolf at openjdk.org Thu Aug 25 14:50:52 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 25 Aug 2022 14:50:52 GMT Subject: [jdk17u-dev] RFR: 8292888: Bump update version for OpenJDK: jdk-17.0.6 In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 20:46:29 GMT, Christoph Langer wrote: > Prepare for 17.0.6 development Looks good. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/644 From yan at openjdk.org Thu Aug 25 15:56:40 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 25 Aug 2022 15:56:40 GMT Subject: [jdk13u-dev] Integrated: 7131823: bug in GIFImageReader In-Reply-To: <685qT3Upqerx5ZlVTGtsR1Lmrf7QiWXHMRyOqguN4BI=.ed642b2e-9ab3-4486-81f5-116c9ee3c8ea@github.com> References: <685qT3Upqerx5ZlVTGtsR1Lmrf7QiWXHMRyOqguN4BI=.ed642b2e-9ab3-4486-81f5-116c9ee3c8ea@github.com> Message-ID: <0lB6UKDR0qO6WmrGqaTtTn51rlfjlO7kZ1Kjf7cCDjM=.6f14f123-bd98-4fe3-a483-50c1575de75c@github.com> On Thu, 25 Aug 2022 12:46:24 GMT, Yuri Nesterenko wrote: > Backporting this fix for parity with LTS releases. Clean ports; jdk/javax/imageio tests pass. This pull request has now been integrated. Changeset: cab6b371 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/cab6b371e021d6d697ed7f75d2e5fc3561a74596 Stats: 175 lines in 2 files changed: 158 ins; 4 del; 13 mod 7131823: bug in GIFImageReader Backport-of: a31130fd4056907edcb420761722c629a33273eb ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/393 From yan at openjdk.org Thu Aug 25 16:06:39 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 25 Aug 2022 16:06:39 GMT Subject: [jdk15u-dev] Integrated: 7131823: bug in GIFImageReader In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 12:46:05 GMT, Yuri Nesterenko wrote: > Backporting this fix for parity with LTS releases. Clean ports; jdk/javax/imageio tests pass. This pull request has now been integrated. Changeset: 03bf615f Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/03bf615f2dc97926b6da0aaf69720dac4c796123 Stats: 175 lines in 2 files changed: 158 ins; 4 del; 13 mod 7131823: bug in GIFImageReader Backport-of: a31130fd4056907edcb420761722c629a33273eb ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/259 From sgehwolf at openjdk.org Thu Aug 25 16:08:19 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 25 Aug 2022 16:08:19 GMT Subject: [jdk17u-dev] RFR: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun Message-ID: Clean backport. Test only (affecting podman on cg2). Low risk. ------------- Commit messages: - Backport ac6be165196457a26d837760b5f5030fe010d633 Changes: https://git.openjdk.org/jdk17u-dev/pull/645/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=645&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289695 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/645.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/645/head:pull/645 PR: https://git.openjdk.org/jdk17u-dev/pull/645 From sgehwolf at openjdk.org Thu Aug 25 17:49:28 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 25 Aug 2022 17:49:28 GMT Subject: [jdk11u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Message-ID: Follow-up backport (for hotspot) to https://bugs.openjdk.org/browse/JDK-8287107 applies clean. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1340 Commit messages: - 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Changes: https://git.openjdk.org/jdk11u-dev/pull/1345/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1345&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287741 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1345.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1345/head:pull/1345 PR: https://git.openjdk.org/jdk11u-dev/pull/1345 From duke at openjdk.org Fri Aug 26 02:27:15 2022 From: duke at openjdk.org (Richard-Rogalski) Date: Fri, 26 Aug 2022 02:27:15 GMT Subject: [jdk11u-dev] RFR: 8230708: Hotspot fails to build on linux-sparc with gcc-9 In-Reply-To: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> References: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> Message-ID: On Thu, 18 Aug 2022 02:26:26 GMT, Richard-Rogalski wrote: > Backport of bug 8230708. Tested and worked for me and one other user of sparc/linux. > > I signed the OCA: it is under review, will update when it goes through. > > This should be fairly low risk: it only touches sparc-specific code. > > I appreciate your time :^) I think I ran the github actions, let me know if that didn't work. Nope, I don't have an account on the JBS, and I don't see an option to create one: so I appreciate your help :) Here is what you can use for the comment: Fix Request 11u Backporting this patch enables building to sparc/linux with GCC 9. Patch applies cleanly to 11u. This patch is necessary to support jdk11 on gentoo/sparc, as every user builds from source, and GCC 8 has been unmaintained for a while now. This patch has been tested on my and at least one other sparc/linux system, and works as expected. I appreciate your time and patience =^D ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1330 From stuefe at openjdk.org Fri Aug 26 05:28:04 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 26 Aug 2022 05:28:04 GMT Subject: [jdk11u-dev] RFR: 8230708: Hotspot fails to build on linux-sparc with gcc-9 In-Reply-To: References: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> Message-ID: On Fri, 26 Aug 2022 02:24:45 GMT, Richard-Rogalski wrote: >> Backport of bug 8230708. Tested and worked for me and one other user of sparc/linux. >> >> I signed the OCA: it is under review, will update when it goes through. >> >> This should be fairly low risk: it only touches sparc-specific code. >> >> I appreciate your time :^) > > I think I ran the github actions, let me know if that didn't work. > > Nope, I don't have an account on the JBS, and I don't see an option to create one: so I appreciate your help :) > Here is what you can use for the comment: > > Fix Request 11u > > Backporting this patch enables building to sparc/linux with GCC 9. Patch applies cleanly to 11u. This patch is necessary to support jdk11 on gentoo/sparc, as every user builds from source, and GCC 8 has been unmaintained for a while now. This patch has been tested on my and at least one other sparc/linux system, and works as expected. > > I appreciate your time and patience =^D > @Richard-Rogalski Before integrating a PR via `/integrate`, you need to request maintainer approval by flagging the JBS issue with jdk11u-fix-request and adding a fix request comment, stating why you want to bring in this backport, some risk assessment and state what testing you did. Only when it is approved via the jdk11u-fix-yes label, you are allowed to merge. For some more detailed instruction about the backport process, please consult our [Wiki page](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix). > It is also customary to get a PR *reviewed* before pushing :-), especially in a maintenance release. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1330 From stuefe at openjdk.org Fri Aug 26 07:42:12 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 26 Aug 2022 07:42:12 GMT Subject: [jdk11u-dev] RFR: 8230708: Hotspot fails to build on linux-sparc with gcc-9 In-Reply-To: References: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> Message-ID: On Fri, 26 Aug 2022 02:24:45 GMT, Richard-Rogalski wrote: >> Backport of bug 8230708. Tested and worked for me and one other user of sparc/linux. >> >> I signed the OCA: it is under review, will update when it goes through. >> >> This should be fairly low risk: it only touches sparc-specific code. >> >> I appreciate your time :^) > > I think I ran the github actions, let me know if that didn't work. > > Nope, I don't have an account on the JBS, and I don't see an option to create one: so I appreciate your help :) > Here is what you can use for the comment: > > Fix Request 11u > > Backporting this patch enables building to sparc/linux with GCC 9. Patch applies cleanly to 11u. This patch is necessary to support jdk11 on gentoo/sparc, as every user builds from source, and GCC 8 has been unmaintained for a while now. This patch has been tested on my and at least one other sparc/linux system, and works as expected. > > I appreciate your time and patience =^D > > @Richard-Rogalski Before integrating a PR via `/integrate`, you need to request maintainer approval by flagging the JBS issue with jdk11u-fix-request and adding a fix request comment, stating why you want to bring in this backport, some risk assessment and state what testing you did. Only when it is approved via the jdk11u-fix-yes label, you are allowed to merge. For some more detailed instruction about the backport process, please consult our [Wiki page](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix). > > It is also customary to get a PR _reviewed_ before pushing :-), especially in a maintenance release. Ah, just seeing this was a clean backport from 14. Okay, no PR review needed then, just JBS approval. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1330 From clanger at openjdk.org Fri Aug 26 07:53:06 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 26 Aug 2022 07:53:06 GMT Subject: [jdk11u-dev] RFR: 8230708: Hotspot fails to build on linux-sparc with gcc-9 In-Reply-To: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> References: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> Message-ID: On Thu, 18 Aug 2022 02:26:26 GMT, Richard-Rogalski wrote: > Backport of bug 8230708. Tested and worked for me and one other user of sparc/linux. > > I signed the OCA: it is under review, will update when it goes through. > > This should be fairly low risk: it only touches sparc-specific code. > > I appreciate your time :^) Thanks for running GHA (which looks green) and providing the Fix Request comment. I added the data to the JBS ticket and also approved it. I'll sponsor now. Thanks for helping to maintain OpenJDK 11u. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1330 From duke at openjdk.org Fri Aug 26 07:55:33 2022 From: duke at openjdk.org (Richard-Rogalski) Date: Fri, 26 Aug 2022 07:55:33 GMT Subject: [jdk11u-dev] Integrated: 8230708: Hotspot fails to build on linux-sparc with gcc-9 In-Reply-To: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> References: <0OZqVj7KifhfJBiBfQRyJKlcqKcnKDah-Sr8oO6GUqA=.f5537c6c-cb8d-4f14-981e-1c2e9753edf0@github.com> Message-ID: On Thu, 18 Aug 2022 02:26:26 GMT, Richard-Rogalski wrote: > Backport of bug 8230708. Tested and worked for me and one other user of sparc/linux. > > I signed the OCA: it is under review, will update when it goes through. > > This should be fairly low risk: it only touches sparc-specific code. > > I appreciate your time :^) This pull request has now been integrated. Changeset: cbbec738 Author: Richard-Rogalski Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/cbbec73800f5d3da4c2aefdda5d36cc30042b810 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8230708: Hotspot fails to build on linux-sparc with gcc-9 Backport-of: 5f29e88563de8fa38109489a11fb6a465f604d66 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1330 From mbaesken at openjdk.org Fri Aug 26 07:58:13 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 26 Aug 2022 07:58:13 GMT Subject: [jdk11u-dev] RFR: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output [v2] In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 07:24:35 GMT, Christoph Langer wrote: >> Backport does not apply cleanly which unveils a shortcoming of the fix >> https://bugs.openjdk.org/browse/JDK-8267880 >> https://github.com/openjdk/jdk11u-dev/commit/9cf9879a4e4a78ed8e6d9b1f979de1eb7f75badf >> >> The test had been adapted at various places from sha1->sha256 but the two modified locations are still at sha1. >> >> We see the test failing on a few systems which should be fixed herewith. >> >> I will also backport the follow-up https://bugs.openjdk.org/browse/JDK-8279385 > > Christoph Langer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 8b5ff4bdffc8f32317d67b00c085071d6c772b30 Looks good to me. ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1343 From clanger at openjdk.org Fri Aug 26 08:09:13 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 26 Aug 2022 08:09:13 GMT Subject: [jdk19u] Integrated: 8227651: Tests fail with SSLProtocolException: Input record too big In-Reply-To: References: Message-ID: On Tue, 23 Aug 2022 21:01:39 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of https://bugs.openjdk.org/browse/JDK-8227651, commit [7b029ea6](https://github.com/openjdk/jdk/commit/7b029ea6ba1d44d361fdf980816732d8454b8194) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Daniel Jeli?ski on 10 Aug 2022 and was reviewed by Sean Coffey and Xue-Lei Andrew Fan. > > Thanks! This pull request has now been integrated. Changeset: 8934a84c Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/8934a84cb43da48dc27b7949d04390698a8d4ffb Stats: 51 lines in 8 files changed: 5 ins; 5 del; 41 mod 8227651: Tests fail with SSLProtocolException: Input record too big 8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch Backport-of: 7b029ea6ba1d44d361fdf980816732d8454b8194 ------------- PR: https://git.openjdk.org/jdk19u/pull/12 From clanger at openjdk.org Fri Aug 26 08:10:11 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 26 Aug 2022 08:10:11 GMT Subject: [jdk19u] Integrated: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 05:47:05 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of https://bugs.openjdk.org/browse/JDK-8284977, commit [444a0d98](https://github.com/openjdk/jdk/commit/444a0d98ac06ab043e3b11281234fd515abff302) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 15 Jun 2022 and was reviewed by Severin Gehwolf and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: d10e902a Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/d10e902ad899a2908acc0f196b720768160644ff Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist Backport-of: 444a0d98ac06ab043e3b11281234fd515abff302 ------------- PR: https://git.openjdk.org/jdk19u/pull/13 From sgehwolf at openjdk.org Fri Aug 26 08:41:29 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 26 Aug 2022 08:41:29 GMT Subject: [jdk11u-dev] Integrated: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller In-Reply-To: <8mCJLmVWCWtVzwXyqw7XMqFGmjN-dQT20c1Y2nAOdVc=.c43c842a-a768-4f03-a73b-dd64e47a1817@github.com> References: <8mCJLmVWCWtVzwXyqw7XMqFGmjN-dQT20c1Y2nAOdVc=.c43c842a-a768-4f03-a73b-dd64e47a1817@github.com> Message-ID: On Wed, 24 Aug 2022 17:37:09 GMT, Severin Gehwolf wrote: > Clean backport. Issue present on 11.0.16 too, low risk. This pull request has now been integrated. Changeset: 81c29583 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/81c295838c3a8b0bf5b67d6bc25cfff3c462d22a Stats: 117 lines in 3 files changed: 114 ins; 0 del; 3 mod 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1340 From sgehwolf at openjdk.org Fri Aug 26 08:43:45 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 26 Aug 2022 08:43:45 GMT Subject: [jdk11u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete [v2] In-Reply-To: References: Message-ID: > Follow-up backport (for hotspot) to https://bugs.openjdk.org/browse/JDK-8287107 applies clean. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Reviewed-by: iklam - 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f - 8230708: Hotspot fails to build on linux-sparc with gcc-9 Backport-of: 5f29e88563de8fa38109489a11fb6a465f604d66 - 8282947: JFR: Dump on shutdown live-locks in some conditions Backport-of: 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 - 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled Backport-of: 7552915d3ff1bf2cb57cf10ec67b57ddf8321d87 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1345/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1345&range=01 Stats: 195 lines in 9 files changed: 182 ins; 1 del; 12 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1345.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1345/head:pull/1345 PR: https://git.openjdk.org/jdk11u-dev/pull/1345 From sgehwolf at openjdk.org Fri Aug 26 08:44:03 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 26 Aug 2022 08:44:03 GMT Subject: [jdk17u-dev] Integrated: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 14:28:58 GMT, Severin Gehwolf wrote: > Clean backport. Test only (affecting podman on cg2). Low risk. This pull request has now been integrated. Changeset: d13038aa Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/d13038aa90a70ffd3db47c63f3f16117314a67d7 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun Backport-of: ac6be165196457a26d837760b5f5030fe010d633 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/645 From sgehwolf at openjdk.org Fri Aug 26 08:47:03 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 26 Aug 2022 08:47:03 GMT Subject: [jdk11u-dev] Integrated: 8287073: NPE from CgroupV2Subsystem.getInstance() In-Reply-To: References: Message-ID: <5gi48h8drCR_LTozrP3wTZhRHEXuNTE-75JPuPundYU=.859e80b8-5e95-4878-b380-b85830c42e82@github.com> On Wed, 24 Aug 2022 14:59:26 GMT, Severin Gehwolf wrote: > Backport fixing a potential NPE on cgroups v2. This pull request has now been integrated. Changeset: 1afd1f49 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/1afd1f49847c9572813a74d93ed80e3ca1e3c349 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8287073: NPE from CgroupV2Subsystem.getInstance() Backport-of: 744b822ab194a0f7ef4e7a4053be32c6a0889efc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1339 From sgehwolf at openjdk.org Fri Aug 26 08:49:06 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 26 Aug 2022 08:49:06 GMT Subject: [jdk11u-dev] RFR: 8287663: Add a regression test for JDK-8287073 [v2] In-Reply-To: References: Message-ID: > Clean backport after "[JDK-8287107](https://bugs.openjdk.org/browse/JDK-8287107): CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller". Mostly a regression test, low risk. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8287663: Add a regression test for JDK-8287073 Backport-of: 2d8c6490540e3ccea23b81129b2e4073915071e0 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1341/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1341&range=01 Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1341.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1341/head:pull/1341 PR: https://git.openjdk.org/jdk11u-dev/pull/1341 From sgehwolf at openjdk.org Fri Aug 26 08:52:09 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 26 Aug 2022 08:52:09 GMT Subject: [jdk11u-dev] Integrated: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 17:29:23 GMT, Severin Gehwolf wrote: > Follow-up backport (for hotspot) to https://bugs.openjdk.org/browse/JDK-8287107 applies clean. This pull request has now been integrated. Changeset: 90a64188 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/90a64188535a784b3c6f1368635c4b03630bc6c4 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Backport-of: 8d28734ede0ed3922c92451a172d1fa676e484e9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1345 From clanger at openjdk.org Fri Aug 26 08:56:59 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 26 Aug 2022 08:56:59 GMT Subject: [jdk11u-dev] Integrated: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 05:32:00 GMT, Christoph Langer wrote: > Backport does not apply cleanly which unveils a shortcoming of the fix > https://bugs.openjdk.org/browse/JDK-8267880 > https://github.com/openjdk/jdk11u-dev/commit/9cf9879a4e4a78ed8e6d9b1f979de1eb7f75badf > > The test had been adapted at various places from sha1->sha256 but the two modified locations are still at sha1. > > We see the test failing on a few systems which should be fixed herewith. > > I will also backport the follow-up https://bugs.openjdk.org/browse/JDK-8279385 This pull request has now been integrated. Changeset: 0cd49f59 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/0cd49f5955738b5ed48a16241f8165ce55632e22 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output Reviewed-by: mbaesken Backport-of: 8b5ff4bdffc8f32317d67b00c085071d6c772b30 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1343 From clanger at openjdk.org Fri Aug 26 09:14:18 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 26 Aug 2022 09:14:18 GMT Subject: [jdk11u-dev] RFR: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 [v3] In-Reply-To: References: Message-ID: > Follow up after [JDK-8278344](https://bugs.openjdk.org/browse/JDK-8278344). Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into RealCLanger-backport-01f93ddf - Backport 01f93ddf18daea5c0798ac949c6717c37d9cefa0 - Backport 8b5ff4bdffc8f32317d67b00c085071d6c772b30 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1344/files - new: https://git.openjdk.org/jdk11u-dev/pull/1344/files/d69b4bee..020ae150 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1344&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1344&range=01-02 Stats: 199 lines in 9 files changed: 183 ins; 1 del; 15 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1344.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1344/head:pull/1344 PR: https://git.openjdk.org/jdk11u-dev/pull/1344 From sgehwolf at openjdk.org Fri Aug 26 09:42:02 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 26 Aug 2022 09:42:02 GMT Subject: [jdk11u-dev] Integrated: 8287663: Add a regression test for JDK-8287073 In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 17:48:13 GMT, Severin Gehwolf wrote: > Clean backport after "[JDK-8287107](https://bugs.openjdk.org/browse/JDK-8287107): CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller". Mostly a regression test, low risk. This pull request has now been integrated. Changeset: 351508cc Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/351508cc5457613b22c101296e0397588e34fa85 Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod 8287663: Add a regression test for JDK-8287073 Backport-of: 2d8c6490540e3ccea23b81129b2e4073915071e0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1341 From yan at openjdk.org Fri Aug 26 11:52:57 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 26 Aug 2022 11:52:57 GMT Subject: [jdk13u-dev] RFR: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int) Message-ID: Backporting the fix to be on par with LTS releases. Non-ignored hotspot tests run fine. ------------- Commit messages: - Backport 947869609ce6b74d4d28f79724b823d8781adbed Changes: https://git.openjdk.org/jdk13u-dev/pull/394/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=394&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283441 Stats: 106 lines in 5 files changed: 94 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/394.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/394/head:pull/394 PR: https://git.openjdk.org/jdk13u-dev/pull/394 From yan at openjdk.org Fri Aug 26 12:17:07 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 26 Aug 2022 12:17:07 GMT Subject: [jdk13u-dev] Integrated: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int) In-Reply-To: References: Message-ID: On Fri, 26 Aug 2022 11:44:22 GMT, Yuri Nesterenko wrote: > Backporting the fix to be on par with LTS releases. Non-ignored hotspot tests run fine. This pull request has now been integrated. Changeset: bd0ca303 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/bd0ca30382fca9d78bc41453f95b804d8745f92f Stats: 106 lines in 5 files changed: 94 ins; 0 del; 12 mod 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int) Backport-of: 947869609ce6b74d4d28f79724b823d8781adbed ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/394 From yan at openjdk.org Fri Aug 26 13:37:04 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 26 Aug 2022 13:37:04 GMT Subject: [jdk15u-dev] RFR: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int) Message-ID: Backporting the fix to be on par with LTS releases. Non-ignored hotspot tests run fine. ------------- Commit messages: - Backport 947869609ce6b74d4d28f79724b823d8781adbed Changes: https://git.openjdk.org/jdk15u-dev/pull/261/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=261&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283441 Stats: 106 lines in 5 files changed: 94 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/261.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/261/head:pull/261 PR: https://git.openjdk.org/jdk15u-dev/pull/261 From yan at openjdk.org Fri Aug 26 13:38:32 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 26 Aug 2022 13:38:32 GMT Subject: [jdk15u-dev] Integrated: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int) In-Reply-To: References: Message-ID: <2l77gVABIqLBxW2lqMTmXvyUXkIZy4GboSkCgnariJ8=.0b9410a8-95a6-4789-8fad-bdac439ef4eb@github.com> On Fri, 26 Aug 2022 13:26:16 GMT, Yuri Nesterenko wrote: > Backporting the fix to be on par with LTS releases. Non-ignored hotspot tests run fine. This pull request has now been integrated. Changeset: e7fdc3a6 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/e7fdc3a6e2ca9d7959f0242436d46bed6fb5e540 Stats: 106 lines in 5 files changed: 94 ins; 0 del; 12 mod 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int) Backport-of: 947869609ce6b74d4d28f79724b823d8781adbed ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/261 From jdowland at openjdk.org Fri Aug 26 13:56:48 2022 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 26 Aug 2022 13:56:48 GMT Subject: [jdk17u-dev] RFR: 8292083: Detected container memory limit may exceed physical machine memory Message-ID: This is a backport of 8292083 for jdk17u-dev. I wish to backport this to get the bug fix out to JDK17 users as we have seen it in live deployments. The backport is not clean: * unrelated changes in src/hotspot/os/linux/os_linux.hpp * in src /hotspot/os/linux/cgroupV1Subsystem_linux.cpp, the original patch modified CgroupV1Subsystem::kernel_memory_limit_in_bytes, which does not yet exist in jdk17u. It is introduced in 8287011. I don't know whether that will get backported to 17u in future. ------------- Commit messages: - 8292083: Detected container memory limit may exceed physical machine memory Changes: https://git.openjdk.org/jdk17u-dev/pull/646/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=646&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292083 Stats: 90 lines in 7 files changed: 63 ins; 19 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/646.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/646/head:pull/646 PR: https://git.openjdk.org/jdk17u-dev/pull/646 From sgehwolf at openjdk.org Fri Aug 26 14:26:11 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 26 Aug 2022 14:26:11 GMT Subject: [jdk17u-dev] RFR: 8292083: Detected container memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: On Fri, 26 Aug 2022 13:50:10 GMT, Jonathan Dowland wrote: > This is a backport of 8292083 for jdk17u-dev. I wish to backport this to get the bug fix out > to JDK17 users as we have seen it in live deployments. > > The backport is not clean: > > * unrelated changes in src/hotspot/os/linux/os_linux.hpp > * in src /hotspot/os/linux/cgroupV1Subsystem_linux.cpp, the original patch modified > CgroupV1Subsystem::kernel_memory_limit_in_bytes, which does not yet exist in jdk17u. > It is introduced in 8287011. I don't know whether that will get backported to 17u in future. Please use `Backport f694f8a7671002559e7d23fdb65d5e9c768f9c03` as the PR title, so that the bots recognize it as a backport. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/646 From evergizova at openjdk.org Fri Aug 26 19:06:49 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Fri, 26 Aug 2022 19:06:49 GMT Subject: [jdk15u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions Message-ID: I'd like to backport JDK-8282947 to 15u for parity with 11u. The patch applies cleanly. Tested with jdk/jfr and tier1 tests; added test fails without the patch and passes with it on Linux. ------------- Commit messages: - Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 Changes: https://git.openjdk.org/jdk15u-dev/pull/262/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=262&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282947 Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/262.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/262/head:pull/262 PR: https://git.openjdk.org/jdk15u-dev/pull/262 From evergizova at openjdk.org Fri Aug 26 19:14:29 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Fri, 26 Aug 2022 19:14:29 GMT Subject: [jdk13u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions Message-ID: I'd like to backport JDK-8282947 to 13u for parity with 11u. The patch applies cleanly. Tested with jdk/jfr and tier1 tests; added test fails without the patch and passes with it on Linux. ------------- Commit messages: - Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 Changes: https://git.openjdk.org/jdk13u-dev/pull/395/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=395&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282947 Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/395.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/395/head:pull/395 PR: https://git.openjdk.org/jdk13u-dev/pull/395 From jdowland at openjdk.org Sat Aug 27 07:54:49 2022 From: jdowland at openjdk.org (Jonathan Dowland) Date: Sat, 27 Aug 2022 07:54:49 GMT Subject: [jdk11u-dev] RFR: 8292083: Detected container memory limit may exceed physical machine memory Message-ID: <1foa53hgFnqpH087GdLidBOWCxw-Rj6MXc_NCCkbq9E=.081c4ee6-0c8f-4325-82dc-5451b0ad82e7@github.com> This is a backport of JDK-8292083 for jdk11u-dev. I wish to backport this to get the bug fix out to JDK11 users as we have seen it in live deployments. The backport is not clean: * unrelated changes in src/hotspot/os/linux/os_linux.hpp (slightly different to the 17u backport) * in src /hotspot/os/linux/cgroupV1Subsystem_linux.cpp, the original patch modified CgroupV1Subsystem::kernel_memory_limit_in_bytes, which does not yet exist in jdk17u. It is introduced in 8287011. I don't know whether that will get backported to 17u in future. ------------- Commit messages: - Backport f694f8a7671002559e7d23fdb65d5e9c768f9c03 Changes: https://git.openjdk.org/jdk11u-dev/pull/1346/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1346&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292083 Stats: 91 lines in 7 files changed: 64 ins; 19 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1346.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1346/head:pull/1346 PR: https://git.openjdk.org/jdk11u-dev/pull/1346 From clanger at openjdk.org Sat Aug 27 10:07:17 2022 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 27 Aug 2022 10:07:17 GMT Subject: [jdk11u-dev] Integrated: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 06:50:55 GMT, Christoph Langer wrote: > Follow up after [JDK-8278344](https://bugs.openjdk.org/browse/JDK-8278344). This pull request has now been integrated. Changeset: c9f31357 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/c9f313574a20ef8069c2028d85d003f7b9c49b05 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 Backport-of: 01f93ddf18daea5c0798ac949c6717c37d9cefa0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1344 From aoqi at openjdk.org Mon Aug 29 02:07:36 2022 From: aoqi at openjdk.org (Ao Qi) Date: Mon, 29 Aug 2022 02:07:36 GMT Subject: [jdk19u] RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName In-Reply-To: <4ZDLjgOwlHKOgoy1d_wD00VNFn5JGgQuRJN_To8GooA=.1a508467-9d67-444c-9229-d0642251619c@github.com> References: <4ZDLjgOwlHKOgoy1d_wD00VNFn5JGgQuRJN_To8GooA=.1a508467-9d67-444c-9229-d0642251619c@github.com> Message-ID: On Wed, 24 Aug 2022 17:27:59 GMT, Ao Qi wrote: > I would like to backport this test fix. Low risk, only test changes. Clean backport. The changed tests passed. Got the jdk19u-fix-yes. ------------- PR: https://git.openjdk.org/jdk19u/pull/15 From aoqi at openjdk.org Mon Aug 29 02:08:28 2022 From: aoqi at openjdk.org (Ao Qi) Date: Mon, 29 Aug 2022 02:08:28 GMT Subject: [jdk19u] RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 17:27:26 GMT, Ao Qi wrote: > I would like to backport this test fix. Low risk, only test changes. Clean backport. The changed tests passed. Got the jdk19u-fix-yes. ------------- PR: https://git.openjdk.org/jdk19u/pull/14 From mbaesken at openjdk.org Mon Aug 29 07:41:14 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 29 Aug 2022 07:41:14 GMT Subject: [jdk17u-dev] RFR: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output Message-ID: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output ------------- Commit messages: - Backport d8f4e97bd3f4e50902e80b4b6b4eb3268c6d4a9d Changes: https://git.openjdk.org/jdk17u-dev/pull/647/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=647&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289146 Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/647.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/647/head:pull/647 PR: https://git.openjdk.org/jdk17u-dev/pull/647 From mbaesken at openjdk.org Mon Aug 29 10:20:18 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 29 Aug 2022 10:20:18 GMT Subject: [jdk17u-dev] RFR: 8290456: remove os::print_statistics() Message-ID: 8290456: remove os::print_statistics() ------------- Commit messages: - Backport 612d8c6cb1d0861957d3f6af96556e2739283800 Changes: https://git.openjdk.org/jdk17u-dev/pull/648/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=648&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290456 Stats: 13 lines in 5 files changed: 0 ins; 13 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/648.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/648/head:pull/648 PR: https://git.openjdk.org/jdk17u-dev/pull/648 From evergizova at openjdk.org Mon Aug 29 12:07:33 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 29 Aug 2022 12:07:33 GMT Subject: [jdk13u-dev] Integrated: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Fri, 26 Aug 2022 19:04:38 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8282947 to 13u for parity with 11u. > The patch applies cleanly. > Tested with jdk/jfr and tier1 tests; added test fails without the patch and passes with it on Linux. This pull request has now been integrated. Changeset: 0292f8a8 Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk13u-dev/commit/0292f8a81d313fbd0c8c5e74d0b30d1de0b75c7b Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod 8282947: JFR: Dump on shutdown live-locks in some conditions Backport-of: 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/395 From evergizova at openjdk.org Mon Aug 29 12:08:32 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 29 Aug 2022 12:08:32 GMT Subject: [jdk15u-dev] Integrated: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Fri, 26 Aug 2022 18:59:00 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8282947 to 15u for parity with 11u. > The patch applies cleanly. > Tested with jdk/jfr and tier1 tests; added test fails without the patch and passes with it on Linux. This pull request has now been integrated. Changeset: 68f09d4a Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk15u-dev/commit/68f09d4ad15eed16d34684ccca38713a1ddec458 Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod 8282947: JFR: Dump on shutdown live-locks in some conditions Backport-of: 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/262 From evergizova at openjdk.org Mon Aug 29 16:22:51 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 29 Aug 2022 16:22:51 GMT Subject: [jdk17u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows Message-ID: I'd like to backport JDK-8287463 to 17u. This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows. Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null". The test is added by JDK-8282947 which is already backported to 17u. The patch applies cleanly. ------------- Commit messages: - Backport 0df4748216ab71937cfcfb86a2d66f3568bced1e Changes: https://git.openjdk.org/jdk17u-dev/pull/649/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=649&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287463 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/649.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/649/head:pull/649 PR: https://git.openjdk.org/jdk17u-dev/pull/649 From evergizova at openjdk.org Mon Aug 29 16:27:13 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 29 Aug 2022 16:27:13 GMT Subject: [jdk13u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows Message-ID: I'd like to backport JDK-8287463 to 13u. This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows. Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null". The test is added by JDK-8282947 which is already backported to 13u. The patch applies cleanly. ------------- Commit messages: - Backport 0df4748216ab71937cfcfb86a2d66f3568bced1e Changes: https://git.openjdk.org/jdk13u-dev/pull/396/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=396&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287463 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/396.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/396/head:pull/396 PR: https://git.openjdk.org/jdk13u-dev/pull/396 From duke at openjdk.org Mon Aug 29 19:57:08 2022 From: duke at openjdk.org (Gaurav Chaudhari) Date: Mon, 29 Aug 2022 19:57:08 GMT Subject: [jdk11u-dev] RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable [v2] In-Reply-To: References: Message-ID: > Backport changes from JDK-8288377 Gaurav Chaudhari has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into customtz-dst-fix-backport-3c32564 - Backport 3c3256414f7df049cdd6c8519fbcea0d818a1a33 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1328/files - new: https://git.openjdk.org/jdk11u-dev/pull/1328/files/712f18be..1195a019 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1328&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1328&range=00-01 Stats: 1723 lines in 70 files changed: 885 ins; 455 del; 383 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1328.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1328/head:pull/1328 PR: https://git.openjdk.org/jdk11u-dev/pull/1328 From andrew at openjdk.org Tue Aug 30 00:37:11 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 30 Aug 2022 00:37:11 GMT Subject: [jdk11u-dev] RFR: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u In-Reply-To: References: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> Message-ID: On Wed, 3 Aug 2022 19:42:10 GMT, Sergey Bylokhov wrote: >> So, the story goes: >> >> * [JDK-8250984](https://bugs.openjdk.org/browse/JDK-8250984) was backported in 11.0.10 >> * [JDK-8231111](https://bugs.openjdk.org/browse/JDK-8231111) was backported in 11.0.16 >> * In later JDKs, these changes occur in the opposite order. So, when 8250984 was backported, changes related to 8231111 were stripped from it. >> * Now 8231111 has been backported, the testcase needs to be updated to recognise `OSCONTAINER_ERROR` (which is `-2`) as a valid return value from the CGroups v2 code. >> >> Without this fix, we're seeing the testcase failing on newer systems. This change syncs the testcase with trunk. > > Marked as reviewed by serb (Reviewer). Thanks @mrserb Added `jdk11u-fix-request` ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1289 From andrew at openjdk.org Tue Aug 30 03:23:37 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 30 Aug 2022 03:23:37 GMT Subject: [jdk17u-dev] RFR: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305 Message-ID: Hi all, This pull request contains a backport of commit [b6bd190d](https://github.com/openjdk/jdk/commit/b6bd190d8d10fdb177f9fb100c9f44c9f57a3cb5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Zdenek Zambersky on 29 Jun 2022 and was reviewed by Valerie Peng. The patch applies cleanly. The test fails on an unpatched install of 17.0.4 and passes on a patched build. Thanks! ------------- Commit messages: - Backport b6bd190d8d10fdb177f9fb100c9f44c9f57a3cb5 Changes: https://git.openjdk.org/jdk17u-dev/pull/650/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=650&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288985 Stats: 96 lines in 2 files changed: 95 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/650.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/650/head:pull/650 PR: https://git.openjdk.org/jdk17u-dev/pull/650 From sgehwolf at openjdk.org Tue Aug 30 09:22:14 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 30 Aug 2022 09:22:14 GMT Subject: [jdk11u-dev] RFR: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u In-Reply-To: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> References: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> Message-ID: On Fri, 29 Jul 2022 20:24:05 GMT, Andrew John Hughes wrote: > So, the story goes: > > * [JDK-8250984](https://bugs.openjdk.org/browse/JDK-8250984) was backported in 11.0.10 > * [JDK-8231111](https://bugs.openjdk.org/browse/JDK-8231111) was backported in 11.0.16 > * In later JDKs, these changes occur in the opposite order. So, when 8250984 was backported, changes related to 8231111 were stripped from it. > * Now 8231111 has been backported, the testcase needs to be updated to recognise `OSCONTAINER_ERROR` (which is `-2`) as a valid return value from the CGroups v2 code. > > Without this fix, we're seeing the testcase failing on newer systems. This change syncs the testcase with trunk. LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1289 From evergizova at openjdk.org Tue Aug 30 10:19:10 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 30 Aug 2022 10:19:10 GMT Subject: [jdk15u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows Message-ID: I'd like to backport JDK-8287463 to 15u. This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows. Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null". The test is added by JDK-8282947 which is already backported to 15u. The patch applies cleanly. ------------- Commit messages: - Backport 0df4748216ab71937cfcfb86a2d66f3568bced1e Changes: https://git.openjdk.org/jdk15u-dev/pull/264/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=264&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287463 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/264.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/264/head:pull/264 PR: https://git.openjdk.org/jdk15u-dev/pull/264 From evergizova at openjdk.org Tue Aug 30 10:51:47 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 30 Aug 2022 10:51:47 GMT Subject: [jdk13u-dev] Integrated: 8287463: JFR: Disable TestDevNull.java on Windows In-Reply-To: References: Message-ID: On Mon, 29 Aug 2022 16:18:33 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8287463 to 13u. > This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows. > Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null". > The test is added by JDK-8282947 which is already backported to 13u. > The patch applies cleanly. This pull request has now been integrated. Changeset: df4ddba8 Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk13u-dev/commit/df4ddba872c82ee0b013d21616dd8faf0b4946de Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8287463: JFR: Disable TestDevNull.java on Windows Backport-of: 0df4748216ab71937cfcfb86a2d66f3568bced1e ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/396 From evergizova at openjdk.org Tue Aug 30 10:52:20 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 30 Aug 2022 10:52:20 GMT Subject: [jdk15u-dev] Integrated: 8287463: JFR: Disable TestDevNull.java on Windows In-Reply-To: References: Message-ID: On Tue, 30 Aug 2022 10:09:57 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8287463 to 15u. > This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows. > Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null". > The test is added by JDK-8282947 which is already backported to 15u. > The patch applies cleanly. This pull request has now been integrated. Changeset: 899d5f84 Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk15u-dev/commit/899d5f8414bf1c440b685504096efe397275498a Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8287463: JFR: Disable TestDevNull.java on Windows Backport-of: 0df4748216ab71937cfcfb86a2d66f3568bced1e ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/264 From evergizova at openjdk.org Tue Aug 30 12:22:37 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 30 Aug 2022 12:22:37 GMT Subject: [jdk11u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows Message-ID: I'd like to backport JDK-8287463 to 11u. This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows. Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null". The test is added by JDK-8282947 which is already backported to 11u. The patch applies cleanly. ------------- Commit messages: - Backport 0df4748216ab71937cfcfb86a2d66f3568bced1e Changes: https://git.openjdk.org/jdk11u-dev/pull/1347/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1347&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287463 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1347.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1347/head:pull/1347 PR: https://git.openjdk.org/jdk11u-dev/pull/1347 From sgehwolf at openjdk.org Tue Aug 30 14:11:37 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 30 Aug 2022 14:11:37 GMT Subject: [jdk17u-dev] RFR: 8292083: Detected container memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: On Fri, 26 Aug 2022 13:50:10 GMT, Jonathan Dowland wrote: > This is a backport of 8292083 for jdk17u-dev. I wish to backport this to get the bug fix out > to JDK17 users as we have seen it in live deployments. > > The backport is not clean: > > * unrelated changes in src/hotspot/os/linux/os_linux.hpp > * in src /hotspot/os/linux/cgroupV1Subsystem_linux.cpp, the original patch modified > CgroupV1Subsystem::kernel_memory_limit_in_bytes, which does not yet exist in jdk17u. > It is introduced in 8287011. I don't know whether that will get backported to 17u in future. Looks good to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/646 From sgehwolf at openjdk.org Tue Aug 30 14:22:16 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 30 Aug 2022 14:22:16 GMT Subject: [jdk11u-dev] RFR: 8292083: Detected container memory limit may exceed physical machine memory In-Reply-To: <1foa53hgFnqpH087GdLidBOWCxw-Rj6MXc_NCCkbq9E=.081c4ee6-0c8f-4325-82dc-5451b0ad82e7@github.com> References: <1foa53hgFnqpH087GdLidBOWCxw-Rj6MXc_NCCkbq9E=.081c4ee6-0c8f-4325-82dc-5451b0ad82e7@github.com> Message-ID: On Sat, 27 Aug 2022 07:08:28 GMT, Jonathan Dowland wrote: > This is a backport of JDK-8292083 for jdk11u-dev. I wish to backport this to get the bug fix out > to JDK11 users as we have seen it in live deployments. > > The backport is not clean: > > * unrelated changes in src/hotspot/os/linux/os_linux.hpp (slightly different to the 17u backport) > * in src /hotspot/os/linux/cgroupV1Subsystem_linux.cpp, the original patch modified > CgroupV1Subsystem::kernel_memory_limit_in_bytes, which does not yet exist in jdk11u. > It is introduced in 8287011. I don't know whether that will get backported to 11u in future. Looks good. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1346 From duke at openjdk.org Tue Aug 30 20:50:11 2022 From: duke at openjdk.org (Gaurav Chaudhari) Date: Tue, 30 Aug 2022 20:50:11 GMT Subject: [jdk11u-dev] RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable [v2] In-Reply-To: References: Message-ID: On Mon, 29 Aug 2022 19:57:08 GMT, Gaurav Chaudhari wrote: >> Backport changes from JDK-8288377 > > Gaurav Chaudhari has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into customtz-dst-fix-backport-3c32564 > - Backport 3c3256414f7df049cdd6c8519fbcea0d818a1a33 Yes, I will prep the PR for jdk17 and jdk19 repos. After looking at the error on enabling Github Actions here though, looks like a method from `ProcessTools` used in my jtreg test is using a different method signature in this repo, and might be the case in the other repos (jdk17,jdk19) as well. Not sure if an additional commit will be needed to fix it on the other repos, but I will check there and see. Otherwise, only will be needed to fix it here later on. Did not have the error occurring in the openjdk repo initially, so wasn't expecting errors. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1328 From evergizova at openjdk.org Tue Aug 30 20:59:21 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 30 Aug 2022 20:59:21 GMT Subject: [jdk11u-dev] Integrated: 8287463: JFR: Disable TestDevNull.java on Windows In-Reply-To: References: Message-ID: On Tue, 30 Aug 2022 12:14:40 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8287463 to 11u. > This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows. > Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null". > The test is added by JDK-8282947 which is already backported to 11u. > The patch applies cleanly. This pull request has now been integrated. Changeset: 9186b3c0 Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk11u-dev/commit/9186b3c074ac2c6e7e27069bf505588d594c1906 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8287463: JFR: Disable TestDevNull.java on Windows Backport-of: 0df4748216ab71937cfcfb86a2d66f3568bced1e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1347 From evergizova at openjdk.org Tue Aug 30 20:59:42 2022 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 30 Aug 2022 20:59:42 GMT Subject: [jdk17u-dev] Integrated: 8287463: JFR: Disable TestDevNull.java on Windows In-Reply-To: References: Message-ID: On Mon, 29 Aug 2022 16:17:20 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8287463 to 17u. > This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows. > Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null". > The test is added by JDK-8282947 which is already backported to 17u. > The patch applies cleanly. This pull request has now been integrated. Changeset: d3197e76 Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk17u-dev/commit/d3197e7628524d0838e0cbbbf261c7b6ab29d761 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8287463: JFR: Disable TestDevNull.java on Windows Backport-of: 0df4748216ab71937cfcfb86a2d66f3568bced1e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/649 From duke at openjdk.org Tue Aug 30 21:16:28 2022 From: duke at openjdk.org (Mat Carter) Date: Tue, 30 Aug 2022 21:16:28 GMT Subject: [jdk11u-dev] RFR: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider Message-ID: <-E0nIKf8iH2NhEF-Ot-TCZicQKY86wTXg7j2lb98jfM=.4356f7e8-d8da-4440-a87e-2afe9365956b@github.com> Backport of e3c178d6d87c9e0e2a75cddc72d802cf9124420e On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges. "Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc keystore functionality and API remains unchanged, the local machine keystore types require the manual tests to run in admin mode Tested on windows, passes tier1 (via GH Actions) and manual tests provided in the patch ------------- Commit messages: - Backport e3c178d6d87c9e0e2a75cddc72d802cf9124420e Changes: https://git.openjdk.org/jdk11u-dev/pull/1348/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1348&range=00 Issue: https://bugs.openjdk.org/browse/JDK-6782021 Stats: 187 lines in 5 files changed: 155 ins; 1 del; 31 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1348.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1348/head:pull/1348 PR: https://git.openjdk.org/jdk11u-dev/pull/1348 From duke at openjdk.org Tue Aug 30 22:04:51 2022 From: duke at openjdk.org (Roman Marchenko) Date: Tue, 30 Aug 2022 22:04:51 GMT Subject: [jdk15u-dev] RFR: 8268361: Fix the infinite loop in next_line Message-ID: Bakport of JDK-8268361 to 15u. It needs to be ported due to similar problems as 17u has. Fix applies cleanly. Tests tier1 passed after the fix without regression. ------------- Commit messages: - Backport 72672277e4dddf8e72f1c705cd5f57de40745635 Changes: https://git.openjdk.org/jdk15u-dev/pull/260/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=260&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8268361 Stats: 15 lines in 1 file changed: 11 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/260.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/260/head:pull/260 PR: https://git.openjdk.org/jdk15u-dev/pull/260 From robilad at openjdk.org Tue Aug 30 22:04:51 2022 From: robilad at openjdk.org (Dalibor Topic) Date: Tue, 30 Aug 2022 22:04:51 GMT Subject: [jdk15u-dev] RFR: 8268361: Fix the infinite loop in next_line In-Reply-To: References: Message-ID: On Fri, 26 Aug 2022 10:43:35 GMT, Roman Marchenko wrote: > Bakport of JDK-8268361 to 15u. > It needs to be ported due to similar problems as 17u has. > Fix applies cleanly. Tests tier1 passed after the fix without regression. Hi, please send an e-Mail to Dalibor.topic at oracle.com so that I can verify your account. ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/260 From andrew at openjdk.org Wed Aug 31 01:10:39 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 31 Aug 2022 01:10:39 GMT Subject: [jdk11u-dev] RFR: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u In-Reply-To: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> References: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> Message-ID: On Fri, 29 Jul 2022 20:24:05 GMT, Andrew John Hughes wrote: > So, the story goes: > > * [JDK-8250984](https://bugs.openjdk.org/browse/JDK-8250984) was backported in 11.0.10 > * [JDK-8231111](https://bugs.openjdk.org/browse/JDK-8231111) was backported in 11.0.16 > * In later JDKs, these changes occur in the opposite order. So, when 8250984 was backported, changes related to 8231111 were stripped from it. > * Now 8231111 has been backported, the testcase needs to be updated to recognise `OSCONTAINER_ERROR` (which is `-2`) as a valid return value from the CGroups v2 code. > > Without this fix, we're seeing the testcase failing on newer systems. This change syncs the testcase with trunk. I see `jdk11u-fix-yes` ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1289 From andrew at openjdk.org Wed Aug 31 01:10:39 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 31 Aug 2022 01:10:39 GMT Subject: [jdk11u-dev] Integrated: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u In-Reply-To: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> References: <5efBaoiGQGPKyx75TtO2xbBHmLC5aFiyjagLdSouaFk=.78727974-bf0a-4afe-b73f-21d7d7d418c5@github.com> Message-ID: On Fri, 29 Jul 2022 20:24:05 GMT, Andrew John Hughes wrote: > So, the story goes: > > * [JDK-8250984](https://bugs.openjdk.org/browse/JDK-8250984) was backported in 11.0.10 > * [JDK-8231111](https://bugs.openjdk.org/browse/JDK-8231111) was backported in 11.0.16 > * In later JDKs, these changes occur in the opposite order. So, when 8250984 was backported, changes related to 8231111 were stripped from it. > * Now 8231111 has been backported, the testcase needs to be updated to recognise `OSCONTAINER_ERROR` (which is `-2`) as a valid return value from the CGroups v2 code. > > Without this fix, we're seeing the testcase failing on newer systems. This change syncs the testcase with trunk. This pull request has now been integrated. Changeset: 2f0f34ce Author: Andrew John Hughes URL: https://git.openjdk.org/jdk11u-dev/commit/2f0f34ce4cbe0f51a1bcc3145eb4d7ade9287d5d Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u Reviewed-by: serb, sgehwolf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1289 From andrew at openjdk.org Wed Aug 31 01:10:50 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 31 Aug 2022 01:10:50 GMT Subject: [jdk17u-dev] RFR: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305 In-Reply-To: References: Message-ID: On Tue, 30 Aug 2022 03:14:23 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [b6bd190d](https://github.com/openjdk/jdk/commit/b6bd190d8d10fdb177f9fb100c9f44c9f57a3cb5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Zdenek Zambersky on 29 Jun 2022 and was reviewed by Valerie Peng. > > The patch applies cleanly. The test fails on an unpatched install of 17.0.4 and passes on a patched build. > > Thanks! I see `jdk17u-fix-yes` ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/650 From andrew at openjdk.org Wed Aug 31 01:12:25 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 31 Aug 2022 01:12:25 GMT Subject: [jdk17u-dev] Integrated: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305 In-Reply-To: References: Message-ID: On Tue, 30 Aug 2022 03:14:23 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [b6bd190d](https://github.com/openjdk/jdk/commit/b6bd190d8d10fdb177f9fb100c9f44c9f57a3cb5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Zdenek Zambersky on 29 Jun 2022 and was reviewed by Valerie Peng. > > The patch applies cleanly. The test fails on an unpatched install of 17.0.4 and passes on a patched build. > > Thanks! This pull request has now been integrated. Changeset: 00445e86 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/00445e86fdb0afb60cfd67fa0abb6d80ac393cd2 Stats: 96 lines in 2 files changed: 95 ins; 0 del; 1 mod 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305 Backport-of: b6bd190d8d10fdb177f9fb100c9f44c9f57a3cb5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/650 From mbaesken at openjdk.org Wed Aug 31 06:45:20 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 31 Aug 2022 06:45:20 GMT Subject: [jdk17u-dev] Integrated: 8290456: remove os::print_statistics() In-Reply-To: References: Message-ID: On Mon, 29 Aug 2022 10:12:20 GMT, Matthias Baesken wrote: > 8290456: remove os::print_statistics() This pull request has now been integrated. Changeset: bf7e3bf0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/bf7e3bf070d0c063c85367746bde2292c66fb987 Stats: 13 lines in 5 files changed: 0 ins; 13 del; 0 mod 8290456: remove os::print_statistics() Backport-of: 612d8c6cb1d0861957d3f6af96556e2739283800 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/648 From duke at openjdk.org Wed Aug 31 08:11:15 2022 From: duke at openjdk.org (Roman Marchenko) Date: Wed, 31 Aug 2022 08:11:15 GMT Subject: [jdk15u-dev] Integrated: 8268361: Fix the infinite loop in next_line In-Reply-To: References: Message-ID: On Fri, 26 Aug 2022 10:43:35 GMT, Roman Marchenko wrote: > Backport of JDK-8268361 to 15u. > It needs to be ported due to similar problems as 17u has. > Fix applies cleanly. Tests tier1 passed after the fix without regression. This pull request has now been integrated. Changeset: 8392a311 Author: Roman Marchenko Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/8392a311b8c1bc8d5aa53c66367ef7df4630ff72 Stats: 15 lines in 1 file changed: 11 ins; 0 del; 4 mod 8268361: Fix the infinite loop in next_line Backport-of: 72672277e4dddf8e72f1c705cd5f57de40745635 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/260 From yan at openjdk.org Wed Aug 31 08:23:18 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 31 Aug 2022 08:23:18 GMT Subject: [jdk15u-dev] RFR: 8287162: (zipfs) Performance regression related to support for POSIX file permissions Message-ID: This fix should be ported here, too, to be on par with later releases. All test/jdk/java/util/zip test/jdk/jdk/nio/zipfs tests pass but one: jdk/java/util/zip/ZipFile/TestZipFile.java should be updated with 8207936 (there's no getMetaInfEntryNames() in ZipFile.java in 15u) ------------- Commit messages: - Backport a10c5597d93c4402bafdbb570437aac052b10027 Changes: https://git.openjdk.org/jdk15u-dev/pull/265/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=265&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287162 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/265.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/265/head:pull/265 PR: https://git.openjdk.org/jdk15u-dev/pull/265 From yan at openjdk.org Wed Aug 31 08:33:13 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 31 Aug 2022 08:33:13 GMT Subject: [jdk15u-dev] Integrated: 8287162: (zipfs) Performance regression related to support for POSIX file permissions In-Reply-To: References: Message-ID: On Wed, 31 Aug 2022 08:13:18 GMT, Yuri Nesterenko wrote: > This fix should be ported here, too, to be on par with later releases. > All test/jdk/java/util/zip test/jdk/jdk/nio/zipfs tests pass but one: jdk/java/util/zip/ZipFile/TestZipFile.java should be updated with 8207936 (there's no getMetaInfEntryNames() in ZipFile.java in 15u) This pull request has now been integrated. Changeset: fa427af2 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/fa427af2e63a51544f16a35949cc8429c657a7f3 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8287162: (zipfs) Performance regression related to support for POSIX file permissions Backport-of: a10c5597d93c4402bafdbb570437aac052b10027 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/265 From yan at openjdk.org Wed Aug 31 09:11:16 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 31 Aug 2022 09:11:16 GMT Subject: [jdk15u-dev] RFR: 8207936: TestZipFile failed with java.lang.AssertionError exception Message-ID: This change should be backported here, too, because otherwise the test fails for the simple reason: looking for getMetaInfEntryNames() in ZipFile. It does pass after the fix. ------------- Commit messages: - Backport 65455ff60b4f33996c698029e0b2cff65c7f45f5 Changes: https://git.openjdk.org/jdk15u-dev/pull/266/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=266&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8207936 Stats: 64 lines in 1 file changed: 10 ins; 21 del; 33 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/266.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/266/head:pull/266 PR: https://git.openjdk.org/jdk15u-dev/pull/266 From yan at openjdk.org Wed Aug 31 09:12:33 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 31 Aug 2022 09:12:33 GMT Subject: [jdk15u-dev] Integrated: 8207936: TestZipFile failed with java.lang.AssertionError exception In-Reply-To: References: Message-ID: <_0aASaybDJK4y2m56IB-YfzqRNk-1FIwwzfUJfzM3ow=.1a1f91c0-c4ca-4900-82d9-a2f28fe61d62@github.com> On Wed, 31 Aug 2022 09:02:54 GMT, Yuri Nesterenko wrote: > This change should be backported here, too, because otherwise the test fails for the simple reason: looking for getMetaInfEntryNames() in ZipFile. > It does pass after the fix. This pull request has now been integrated. Changeset: 6f169cb9 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/6f169cb9930e1bec2f515f239b851f2463c15f16 Stats: 64 lines in 1 file changed: 10 ins; 21 del; 33 mod 8207936: TestZipFile failed with java.lang.AssertionError exception Backport-of: 65455ff60b4f33996c698029e0b2cff65c7f45f5 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/266 From jdowland at openjdk.org Wed Aug 31 19:43:37 2022 From: jdowland at openjdk.org (Jonathan Dowland) Date: Wed, 31 Aug 2022 19:43:37 GMT Subject: [jdk11u-dev] RFR: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier In-Reply-To: References: Message-ID: <7U6DWfvhkTW_uFA6XBNw_e3yeUEPLUc1C18U3qY24eg=.101cb8c6-e147-4501-b0a0-ed81acaf8cd0@github.com> On Tue, 2 Aug 2022 10:12:51 GMT, Jonathan Dowland wrote: > This pull request contains a backport of commit [fe807217](https://github.com/openjdk/jdk/commit/fe807217a79753f84c00432e7451c17baa6645c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Yoshiki Sato on 15 Jun 2022 and was reviewed by Mandy Chung. > > I wish to backport it for Oracle parity. > > It does not apply cleanly due to a renamed file in jdk master subsequent to 11u: > > src/java.base/macosx/classes/{java/lang => jdk/internal/loader}/ClassLoaderHelper.java > > Manual testing results forthcoming; I'll add them as a comment on this PR. Ping comment This requires a review. It has been some time since I did it, so I'll check it's still clean Tomorrow. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1298