[jdk11u-dev] RFR: 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available [v3]

[Christoph Langer]

On Sat, 23 Jul 2022 09:32:05 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> This is a backport of [JDK-8238268](https://bugs.openjdk.org/browse/JDK-8238268). We need it, because the backport of [JDK-8215544](https://bugs.openjdk.org/browse/JDK-8215544) has added code that calls `sudo -E` on MacOS without the option `-n`. This call might not return when sudo starts prompting for a password. In our CI it leads to hanging processes when subsequent tests call sudo, even with the -n option. This fix rectifies that behavior. And, after all, it improves test coverage on MacOS, so it's a good backport candidate.
>
> Christoph Langer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport a147636157c011dac5d8c7aa6809c3c55f1384fa

Hi Goetz,

thanks for the review. Yes, I have the patch running in the SAP tests without regressions, as far as I can tell.

> test/hotspot/jtreg/serviceability/sa/ClhsdbLauncher.java Why do you remove `processBuilder.redirectError(ProcessBuilder.Redirect.INHERIT);`

Hm, when I looked at [JDK-8234277](https://bugs.openjdk.org/browse/JDK-8234277), I thought it could be a good idea to do the removal in this change already but maybe you're right and we should keep it consistent. I'm actually not sure about the effects so I'll re-add it.

> test/lib/jdk/test/lib/Platform.java Imports were adapted. isSignedOSX() is added. What is the original change of this? Please mention in the JBS FixRequest comment that you include code from that change.

This originally comes from [JDK-8238196](https://bugs.openjdk.org/browse/JDK-8238196). Since merely all of the code of that bug is part of this PR as well (either as is or augmented), I'll add JDK-8238196 to this backport, too.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1269