[jdk11u-dev] RFR: 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available [v4]

Tue Aug 2 09:19:41 UTC 2022

On Mon, 1 Aug 2022 15:47:07 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> This is a backport of [JDK-8238268](https://bugs.openjdk.org/browse/JDK-8238268). We need it, because the backport of [JDK-8215544](https://bugs.openjdk.org/browse/JDK-8215544) has added code that calls `sudo -E` on MacOS without the option `-n`. This call might not return when sudo starts prompting for a password. In our CI it leads to hanging processes when subsequent tests call sudo, even with the -n option. This fix rectifies that behavior. And, after all, it improves test coverage on MacOS, so it's a good backport candidate.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Add back missing statement to ClhsdbLauncher.java
>  - Merge branch 'master' into RealCLanger-backport-a1476361
>  - Backport a147636157c011dac5d8c7aa6809c3c55f1384fa

Thanks for the clarifications. LGTM.

-------------

Marked as reviewed by goetz (Reviewer).

PR: https://git.openjdk.org/jdk11u-dev/pull/1269