[jdk11u-dev] RFR: 8239708: Split basics.m4 into basic.m4 and util.m4

[George Adams]

On Mon, 1 Aug 2022 21:40:47 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-8218413 (https://github.com/openjdk/jdk/commit/9efdb33a59f7db7b4b39e113265a3b3ba513c5d3)

Done via https://github.com/openjdk/jdk11u-dev/pull/1300

> https://bugs.openjdk.org/browse/JDK-8217032 (https://github.com/openjdk/jdk/commit/4f45b5f9739e5a5e7d1c4f80da9c42e0d77dd0bf)

Done via https://github.com/openjdk/jdk11u-dev/pull/1315

> https://bugs.openjdk.org/browse/JDK-8221907 (https://github.com/openjdk/jdk/commit/0974861dd800fdb44b3888e68b08c570f1985b58)

Done via https://github.com/openjdk/jdk11u-dev/pull/1301

> https://bugs.openjdk.org/browse/JDK-8233712 (https://github.com/openjdk/jdk/commit/753c58b7f556fedd7828da487a34b8b228785ff9)

Done via https://github.com/openjdk/jdk11u-dev/pull/1308


> https://bugs.openjdk.org/browse/JDK-8206125 (https://github.com/openjdk/jdk/commit/7ae384b2ad25d39f271f936ee98ab28a5f92fa94) is partly implemented in your change. Some hunks in new util_windows.m4 are missing, however. Please make sure it's completely contained in your backport and add the issue to this PR then.

I've added the remaining chunk, issue added to backport

> https://bugs.openjdk.org/browse/JDK-8213239 (https://github.com/openjdk/jdk/commit/68dbbf566d8d504308367005048d274aebfd5b50) is contained in your PR. Please mark as backported by adding it to this PR.

Issue added to backport

> https://bugs.openjdk.org/browse/JDK-8240972: Make sure that the changes don't get lost. The implementation file is a different before and after this change. See: https://github.com/openjdk/jdk11u-dev/commit/f771367f73bd01648a454fdd0298b8b4479a3ca0 vs. https://github.com/openjdk/jdk/commit/e30b89e1389ccd7bd2c6bb2265a3110f6fcd31de

I've reimplemented this

> Then, the backport of https://bugs.openjdk.org/browse/JDK-8285728 (https://github.com/openjdk/jdk11u-dev/commit/f00776b653b9d0e1d556c6b44446fe18d72617c1) must not be lost which it currently would.

I've reimplemented this

> And finally, we should thoroughly check whether the fix for 8226346: Build better binary builders (non-public bug, contained in a CPU release) is still intact after this PR. The implementation file is also different, see https://github.com/openjdk/jdk11u-dev/commit/3e9a9c9c4955185ae2be6dd97ddf1c03a4588395 vs. https://github.com/openjdk/jdk/commit/4df99aa7aeaed0d6132ca5c86f803f1096df8841

I've carried over the change to `basics.m4`. This should be okay now

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1277