[jdk11u-dev] RFR: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389
Xin Liu
xliu at openjdk.org
Fri Aug 19 23:07:29 UTC 2022
On Fri, 19 Aug 2022 12:54:38 GMT, Roland Westrelin <roland at openjdk.org> wrote:
> This fixes an issue with the backport of
> https://bugs.openjdk.org/browse/JDK-8223363:
>
> https://github.com/openjdk/jdk11u/commit/5f40afc10909061b5b4e17ec59856611e160e474
>
> where a line that should have been removed wasn't.
LGTM. I am not a reviewer.
Double check that the original patch did replacement here. We introduced an side-effect (+=) when we backported it. the fix is correct.
- uint require_nodes(uint require) {
+ uint require_nodes(uint require, uint minreq = REQUIRE_MIN) {
precond(require > 0);
- _nodes_required += MAX2(100u, require); // Keep requests at minimum 100.
+ _nodes_required += MAX2(require, minreq);
return _nodes_required;
}
-------------
Marked as reviewed by xliu (no project role).
PR: https://git.openjdk.org/jdk11u-dev/pull/1335
More information about the jdk-updates-dev
mailing list