From serb at openjdk.org Thu Dec 1 00:08:56 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 00:08:56 GMT Subject: [jdk11u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 [v3] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1556/files - new: https://git.openjdk.org/jdk11u-dev/pull/1556/files/9e336822..3f81d90c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1556&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1556&range=01-02 Stats: 4878 lines in 61 files changed: 2314 ins; 2189 del; 375 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1556.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1556/head:pull/1556 PR: https://git.openjdk.org/jdk11u-dev/pull/1556 From lzhai at openjdk.org Thu Dec 1 02:32:45 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Thu, 1 Dec 2022 02:32:45 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Tue, 29 Nov 2022 01:57:02 GMT, Leslie Zhai wrote: > Hi, > > Commit d983d108c565654e717e2811d88aa94d982da2f5 fix JDK-8297543: runtime/cds/appcds/cacheObject/ArchivedModuleCompareTest.java fail with jfx > > And dependencies: > > => JDK-8267189: Remove duplicated unregistered classes from dynamic archive > * JDK-8268821: Split systemDictionaryShared.cpp > * JDK-8269004: Implement ResizableResourceHashtable > * JDK-8270061: Change parameter order of ResourceHashtable > * JDK-8270803: Reduce CDS API verbosity > * JDK-8270489: Support archived heap objects in EpsilonGC > * JDK-8275731: CDS archived enums objects are recreated at runtime > > The patch applies clean except manually edit the source file: > > * src/hotspot/share/classfile/systemDictionaryShared.hpp > Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context. > > Tested jtreg tier1~3, no regression. > > Thanks, > Leslie Zhai Hi @iklam Could you sponsor it? Thanks, Leslie Zhai ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From iklam at openjdk.org Thu Dec 1 02:53:36 2022 From: iklam at openjdk.org (Ioi Lam) Date: Thu, 1 Dec 2022 02:53:36 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 02:28:40 GMT, Leslie Zhai wrote: > Hi @iklam > > Could you sponsor it? > > Thanks, Leslie Zhai The bug still has the "jdk17u-fix-request" label. It needs to be approved by jdk17u maintainer first. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From iklam at openjdk.org Thu Dec 1 02:57:29 2022 From: iklam at openjdk.org (Ioi Lam) Date: Thu, 1 Dec 2022 02:57:29 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Tue, 29 Nov 2022 01:57:02 GMT, Leslie Zhai wrote: > Hi, > > Commit d983d108c565654e717e2811d88aa94d982da2f5 fix JDK-8297543: runtime/cds/appcds/cacheObject/ArchivedModuleCompareTest.java fail with jfx > > And dependencies: > > => JDK-8267189: Remove duplicated unregistered classes from dynamic archive > * JDK-8268821: Split systemDictionaryShared.cpp > * JDK-8269004: Implement ResizableResourceHashtable > * JDK-8270061: Change parameter order of ResourceHashtable > * JDK-8270803: Reduce CDS API verbosity > * JDK-8270489: Support archived heap objects in EpsilonGC > * JDK-8275731: CDS archived enums objects are recreated at runtime > > The patch applies clean except manually edit the source file: > > * src/hotspot/share/classfile/systemDictionaryShared.hpp > Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context. > > Tested jtreg tier1~3, no regression. > > Thanks, > Leslie Zhai The description of this PR is not clear. Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? Please avoid mentioning JDK-8297543, as it's already closed as a duplicate of JDK-8275731. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From lzhai at openjdk.org Thu Dec 1 03:05:34 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Thu, 1 Dec 2022 03:05:34 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 02:55:18 GMT, Ioi Lam wrote: >> Hi, >> >> JDK-8275731: CDS archived enums objects are recreated at runtime >> >> Dependencies: >> >> => JDK-8267189: Remove duplicated unregistered classes from dynamic archive >> * JDK-8268821: Split systemDictionaryShared.cpp >> * JDK-8269004: Implement ResizableResourceHashtable >> * JDK-8270061: Change parameter order of ResourceHashtable >> * JDK-8270803: Reduce CDS API verbosity >> * JDK-8270489: Support archived heap objects in EpsilonGC >> >> The patch applies clean except manually edit the source file: >> >> * src/hotspot/share/classfile/systemDictionaryShared.hpp >> Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context. >> >> Tested jtreg tier1~3, no regression. >> >> Thanks, >> Leslie Zhai > > The description of this PR is not clear. Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? > > Please avoid mentioning JDK-8297543, as it's already closed as a duplicate of JDK-8275731. Hi @iklam Thanks for your kind response! > The description of this PR is not clear. I updated the description. Please review it again. > Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? Yes. Thanks, Leslie Zhai ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From serb at openjdk.org Thu Dec 1 04:31:50 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 04:31:50 GMT Subject: [jdk17u-dev] Integrated: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 In-Reply-To: References: Message-ID: <1f733JWLLmZcrAVsMxdPDj4EvQ5eGQbMjT2Oinx5BXg=.53280b8a-5261-485f-a753-575113e38756@github.com> On Mon, 28 Nov 2022 07:06:33 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 8c0c9b41 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/8c0c9b4188433580feb5fa6565d8b0479a972206 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Backport-of: fb6c992f325981c42c7f75109a6c9db7ca8715d8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/937 From yan at azul.com Thu Dec 1 07:08:11 2022 From: yan at azul.com (Yuri Nesterenko) Date: Thu, 1 Dec 2022 10:08:11 +0300 Subject: NB: openjdk13u, openjdk15u in 2023 Message-ID: <0a7078c3-a994-66f2-c3c4-9c7a006c1c54@azul.com> Hi all, according to the initial plans, after the January release I will stop maintaining openjdk 15u and 13u, will send a formal resignation letter, invitation for another maintainer etc. However, if somebody would wish to continue this work in 2023, to keep the process uninterrupted I should create new releases (15.0.11 or 13.0.15 or both) and open -dev repositories on or around December 21, i.e. a month before January release. Please think about it. By default, there will be no releases of 13u and 15u in April. Thank you! --yan From mbaesken at openjdk.org Thu Dec 1 08:16:32 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Dec 2022 08:16:32 GMT Subject: [jdk17u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 08:55:12 GMT, Matthias Baesken wrote: > backport of 8296715; > avoid [make/data/cldr/common/dtd/ldmlSupplemental.dtd](https://github.com/openjdk/jdk/commit/54c986e7d5d0b48a22b4da81c13153ce431c9f2f#diff-0854244a893369539d4984ea67bc7e8788659b4f059c6e5f61a8cdf7f23c80c2) > changes like it has been done in the 19u and 15u backports; test files need manual adjustment because of changes in the stride https://wiki.openjdk.org/display/JDKUpdates/JDK+17u Tuesday, **December 6 2022: Rampdown; last merge from jdk17u-dev to jdk17u** - so no critical request needed. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/942 From mbaesken at openjdk.org Thu Dec 1 08:20:11 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Dec 2022 08:20:11 GMT Subject: [jdk17u-dev] Integrated: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 08:55:12 GMT, Matthias Baesken wrote: > backport of 8296715; > avoid [make/data/cldr/common/dtd/ldmlSupplemental.dtd](https://github.com/openjdk/jdk/commit/54c986e7d5d0b48a22b4da81c13153ce431c9f2f#diff-0854244a893369539d4984ea67bc7e8788659b4f059c6e5f61a8cdf7f23c80c2) > changes like it has been done in the 19u and 15u backports; test files need manual adjustment because of changes in the stride This pull request has now been integrated. Changeset: 3df0e295 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/3df0e29570ca304696ed6910fdc54ed9ea9760d2 Stats: 15 lines in 5 files changed: 6 ins; 6 del; 3 mod 8296715: CLDR v42 update for tzdata 2022f Reviewed-by: mdoerr Backport-of: 55dd90222e2cef11ebca39a2998d8f799aadbb9a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/942 From yan at openjdk.org Thu Dec 1 08:25:15 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 1 Dec 2022 08:25:15 GMT Subject: [jdk15u-dev] RFR: 8290451: Incorrect result when switching to C2 OSR compilation from C1 Message-ID: <8o97V37fSiahOpbPGkO9x8maY8jIflxIwXFHjozATlw=.e4e99303-303f-4720-bb32-6f697af2f880@github.com> Clean backport of a C2 change for parity with LTS releases. Compiler tests do pass. ------------- Commit messages: - Backport afa5d4ced38b7f3752932c28af96d8fc600d1df7 Changes: https://git.openjdk.org/jdk15u-dev/pull/309/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=309&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290451 Stats: 113 lines in 3 files changed: 112 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/309.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/309/head:pull/309 PR: https://git.openjdk.org/jdk15u-dev/pull/309 From serb at openjdk.org Thu Dec 1 09:32:09 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 09:32:09 GMT Subject: [jdk15u-dev] Integrated: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 07:40:12 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 7750a23f Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk15u-dev/commit/7750a23f1b6aa32d7d6a5cb36fc1e86324c940bc Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Backport-of: fb6c992f325981c42c7f75109a6c9db7ca8715d8 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/308 From stuefe at openjdk.org Thu Dec 1 09:42:25 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 1 Dec 2022 09:42:25 GMT Subject: [jdk17u-dev] RFR: 8275320: NMT should perform buffer overrun checks Message-ID: Not a clean downport: - testutils.cpp/.hpp does not exist yet. I took this over (it is just a bunch of test helpers for gtests) - os.cpp, in os::malloc, the size overflow check added with the downport of JDK-8286519 needed to be reformulated. I also added a small, JDK17 only gtest to test for size argument overflow. Ideally that should have been done with JDK-8286519. It is release only since in debug we will get an assert which is fine but I did not feel like adding a death test for it. Note that in head, I am in the process of fixing https://bugs.openjdk.org/browse/JDK-8295865, and that will introduce much more thorough regression tests. Should we ever downport JDK-8295865 to 17, the test introduced here can be removed. ------------- Commit messages: - Backport cf7adae6333c7446048ef0364737927337631f63 Changes: https://git.openjdk.org/jdk17u-dev/pull/842/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=842&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275320 Stats: 570 lines in 11 files changed: 523 ins; 11 del; 36 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/842.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/842/head:pull/842 PR: https://git.openjdk.org/jdk17u-dev/pull/842 From goetz at openjdk.org Thu Dec 1 09:42:26 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 1 Dec 2022 09:42:26 GMT Subject: [jdk17u-dev] RFR: 8275320: NMT should perform buffer overrun checks In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 09:13:26 GMT, Thomas Stuefe wrote: > Not a clean downport: > > - testutils.cpp/.hpp does not exist yet. I took this over (it is just a bunch of test helpers for gtests) > - os.cpp, in os::malloc, the size overflow check added with the downport of JDK-8286519 needed to be reformulated. > > I also added a small, JDK17 only gtest to test for size argument overflow. Ideally that should have been done with JDK-8286519. It is release only since in debug we will get an assert which is fine but I did not feel like adding a death test for it. > > Note that in head, I am in the process of fixing https://bugs.openjdk.org/browse/JDK-8295865, and that will introduce much more thorough regression tests. Should we ever downport JDK-8295865 to 17, the test introduced here can be removed. The only adaption in the live coding I spotted is that below // Check for overflow. in os.cpp. Thanks for adding the thorough testing for the feature. LGTM ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/842 From stuefe at openjdk.org Thu Dec 1 09:42:27 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 1 Dec 2022 09:42:27 GMT Subject: [jdk17u-dev] RFR: 8275320: NMT should perform buffer overrun checks In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 09:13:26 GMT, Thomas Stuefe wrote: > Not a clean downport: > > - testutils.cpp/.hpp does not exist yet. I took this over (it is just a bunch of test helpers for gtests) > - os.cpp, in os::malloc, the size overflow check added with the downport of JDK-8286519 needed to be reformulated. > > I also added a small, JDK17 only gtest to test for size argument overflow. Ideally that should have been done with JDK-8286519. It is release only since in debug we will get an assert which is fine but I did not feel like adding a death test for it. > > Note that in head, I am in the process of fixing https://bugs.openjdk.org/browse/JDK-8295865, and that will introduce much more thorough regression tests. Should we ever downport JDK-8295865 to 17, the test introduced here can be removed. Ping. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/842 From clanger at openjdk.org Thu Dec 1 09:42:28 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 1 Dec 2022 09:42:28 GMT Subject: [jdk17u-dev] RFR: 8275320: NMT should perform buffer overrun checks In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 08:35:44 GMT, Thomas Stuefe wrote: >> Not a clean downport: >> >> - testutils.cpp/.hpp does not exist yet. I took this over (it is just a bunch of test helpers for gtests) >> - os.cpp, in os::malloc, the size overflow check added with the downport of JDK-8286519 needed to be reformulated. >> >> I also added a small, JDK17 only gtest to test for size argument overflow. Ideally that should have been done with JDK-8286519. It is release only since in debug we will get an assert which is fine but I did not feel like adding a death test for it. >> >> Note that in head, I am in the process of fixing https://bugs.openjdk.org/browse/JDK-8295865, and that will introduce much more thorough regression tests. Should we ever downport JDK-8295865 to 17, the test introduced here can be removed. > > Ping. @tstuefe would you mind moving this from draft to non-draft? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/842 From serb at openjdk.org Thu Dec 1 10:04:20 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 10:04:20 GMT Subject: [jdk13u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 [v2] In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 23:13:56 GMT, Sergey Bylokhov wrote: >> Hi all, >> This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ...test message... hm look like for some reason the [branch ](https://github.com/openjdk-bots/jdk13u-dev/tree/mrserb-backport-fb6c992f)is marked as protected. ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/434 From mdoerr at openjdk.org Thu Dec 1 10:14:40 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 1 Dec 2022 10:14:40 GMT Subject: [jdk11u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> References: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> Message-ID: On Wed, 30 Nov 2022 16:03:17 GMT, Matthias Baesken wrote: > Backport of 8296715; es_419.xml has different path, otherwise close to 13u backport Ok, `src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_MX.xml` doesn't contain the part which got modified upstream. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1560 From yan at openjdk.org Thu Dec 1 10:35:39 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 1 Dec 2022 10:35:39 GMT Subject: [jdk11u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> References: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> Message-ID: On Wed, 30 Nov 2022 16:03:17 GMT, Matthias Baesken wrote: > Backport of 8296715; es_419.xml has different path, otherwise close to 13u backport Fine with me! ------------- Marked as reviewed by yan (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1560 From serb at openjdk.org Thu Dec 1 10:37:47 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 10:37:47 GMT Subject: [jdk11u-dev] Integrated: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 In-Reply-To: References: Message-ID: <1Dff2zXTohxlOAEMWTZ-xmJUr-G7nuREsiAxugI6ebI=.5b018d1d-4484-49ce-bada-2e8472c49b9a@github.com> On Mon, 28 Nov 2022 07:47:50 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 31666ecc Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/31666ecc02362cefbb08ed70e20ddff872547824 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Backport-of: fb6c992f325981c42c7f75109a6c9db7ca8715d8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1556 From serb at openjdk.org Thu Dec 1 10:43:39 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 10:43:39 GMT Subject: [jdk13u-dev] Withdrawn: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 07:42:56 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/434 From yan at openjdk.org Thu Dec 1 10:47:07 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 1 Dec 2022 10:47:07 GMT Subject: [jdk13u-dev] RFR: 8290451: Incorrect result when switching to C2 OSR compilation from C1 Message-ID: <8P7g0hYfbX5hbWsIB4_2OvY7lDFjVGhzkuunFVQuIAs=.96a0a04a-7a21-4666-a4fe-9c394cd3d4d1@github.com> Clean backport of a C2 change for parity with LTS releases. Compiler tests do pass. ------------- Commit messages: - Backport afa5d4ced38b7f3752932c28af96d8fc600d1df7 Changes: https://git.openjdk.org/jdk13u-dev/pull/435/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=435&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290451 Stats: 113 lines in 3 files changed: 112 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/435.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/435/head:pull/435 PR: https://git.openjdk.org/jdk13u-dev/pull/435 From yan at openjdk.org Thu Dec 1 10:51:39 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 1 Dec 2022 10:51:39 GMT Subject: [jdk15u-dev] Integrated: 8290451: Incorrect result when switching to C2 OSR compilation from C1 In-Reply-To: <8o97V37fSiahOpbPGkO9x8maY8jIflxIwXFHjozATlw=.e4e99303-303f-4720-bb32-6f697af2f880@github.com> References: <8o97V37fSiahOpbPGkO9x8maY8jIflxIwXFHjozATlw=.e4e99303-303f-4720-bb32-6f697af2f880@github.com> Message-ID: On Thu, 1 Dec 2022 08:14:47 GMT, Yuri Nesterenko wrote: > Clean backport of a C2 change for parity with LTS releases. Compiler tests do pass. This pull request has now been integrated. Changeset: 8dbca0d8 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/8dbca0d8d06eb974147be98bf1ea2f3c5d8cd2d4 Stats: 113 lines in 3 files changed: 112 ins; 0 del; 1 mod 8290451: Incorrect result when switching to C2 OSR compilation from C1 Backport-of: afa5d4ced38b7f3752932c28af96d8fc600d1df7 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/309 From yan at openjdk.org Thu Dec 1 10:54:23 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 1 Dec 2022 10:54:23 GMT Subject: [jdk13u-dev] Integrated: 8290451: Incorrect result when switching to C2 OSR compilation from C1 In-Reply-To: <8P7g0hYfbX5hbWsIB4_2OvY7lDFjVGhzkuunFVQuIAs=.96a0a04a-7a21-4666-a4fe-9c394cd3d4d1@github.com> References: <8P7g0hYfbX5hbWsIB4_2OvY7lDFjVGhzkuunFVQuIAs=.96a0a04a-7a21-4666-a4fe-9c394cd3d4d1@github.com> Message-ID: On Thu, 1 Dec 2022 10:37:58 GMT, Yuri Nesterenko wrote: > Clean backport of a C2 change for parity with LTS releases. Compiler tests do pass. This pull request has now been integrated. Changeset: 246c6c3f Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/246c6c3f2d3695e6c2a97573445ce258610e4920 Stats: 113 lines in 3 files changed: 112 ins; 0 del; 1 mod 8290451: Incorrect result when switching to C2 OSR compilation from C1 Backport-of: afa5d4ced38b7f3752932c28af96d8fc600d1df7 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/435 From serb at openjdk.org Thu Dec 1 10:54:40 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 10:54:40 GMT Subject: [jdk13u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Message-ID: Hi all, This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. This pull request replaces this [one](https://github.com/openjdk/jdk13u-dev/pull/434) Thanks! ------------- Commit messages: - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 Changes: https://git.openjdk.org/jdk13u-dev/pull/436/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=436&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296957 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/436.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/436/head:pull/436 PR: https://git.openjdk.org/jdk13u-dev/pull/436 From vrudomet at openjdk.org Thu Dec 1 11:01:28 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Thu, 1 Dec 2022 11:01:28 GMT Subject: [jdk19u] Integrated: 8295447: NullPointerException with invalid pattern matching construct in constructor call In-Reply-To: <9QqRxO_seqjYOYvVOxh73UMxxy6hIPGLASSf2bn878g=.b1bf214a-cfc7-4d74-9acb-db5c2fe7b784@github.com> References: <9QqRxO_seqjYOYvVOxh73UMxxy6hIPGLASSf2bn878g=.b1bf214a-cfc7-4d74-9acb-db5c2fe7b784@github.com> Message-ID: On Tue, 29 Nov 2022 04:03:51 GMT, Victor Rudometov wrote: > Backport for [JDK-8295447](https://bugs.openjdk.org/browse/JDK-8295447) NullPointerException with invalid pattern matching construct in constructor call > > https://git.openjdk.org/jdk/commit/6c05771b9be3dd5cbcdb40d2e53cc53959926cdd > > Clean backport > JTreg tier1, tier2, jck runtime and jck compiler passed. > Test T8295447.java passes during run. This pull request has now been integrated. Changeset: c9d48579 Author: Victor Rudometov Committer: Sergey Bylokhov URL: https://git.openjdk.org/jdk19u/commit/c9d485792b99233f381dcdfd69838e7b973909bd Stats: 57 lines in 3 files changed: 56 ins; 0 del; 1 mod 8295447: NullPointerException with invalid pattern matching construct in constructor call Backport-of: 6c05771b9be3dd5cbcdb40d2e53cc53959926cdd ------------- PR: https://git.openjdk.org/jdk19u/pull/99 From serb at openjdk.org Thu Dec 1 11:12:53 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 11:12:53 GMT Subject: [jdk19u] RFR: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters Message-ID: Hi all, This pull request contains a backport of commit [87f00f4a](https://github.com/openjdk/jdk/commit/87f00f4a1bfb392be0684edcdfa0254caec4ca03) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 30 Nov 2022 and was reviewed by Phil Race and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 87f00f4a1bfb392be0684edcdfa0254caec4ca03 Changes: https://git.openjdk.org/jdk19u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=102&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296878 Stats: 94 lines in 2 files changed: 79 ins; 2 del; 13 mod Patch: https://git.openjdk.org/jdk19u/pull/102.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/102/head:pull/102 PR: https://git.openjdk.org/jdk19u/pull/102 From serb at openjdk.org Thu Dec 1 11:29:47 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 11:29:47 GMT Subject: [jdk17u-dev] RFR: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters Message-ID: Hi all, This pull request contains a backport of commit [87f00f4a](https://github.com/openjdk/jdk/commit/87f00f4a1bfb392be0684edcdfa0254caec4ca03) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 30 Nov 2022 and was reviewed by Phil Race and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 87f00f4a1bfb392be0684edcdfa0254caec4ca03 Changes: https://git.openjdk.org/jdk17u-dev/pull/943/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=943&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296878 Stats: 94 lines in 2 files changed: 79 ins; 2 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/943.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/943/head:pull/943 PR: https://git.openjdk.org/jdk17u-dev/pull/943 From serb at openjdk.org Thu Dec 1 12:06:35 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Dec 2022 12:06:35 GMT Subject: [jdk13u-dev] Integrated: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 10:44:08 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > > This pull request replaces this [one](https://github.com/openjdk/jdk13u-dev/pull/434) > > Thanks! This pull request has now been integrated. Changeset: e159891b Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk13u-dev/commit/e159891b11421b80cbb210d11f6b58ec0a80231e Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Backport-of: fb6c992f325981c42c7f75109a6c9db7ca8715d8 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/436 From mbaesken at openjdk.org Thu Dec 1 13:59:25 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Dec 2022 13:59:25 GMT Subject: [jdk11u-dev] Integrated: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 11:19:54 GMT, Matthias Baesken wrote: > 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free This pull request has now been integrated. Changeset: 0bf122c0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/0bf122c006e76cbfa25db23f3a4f424828b58f36 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free Backport-of: 996c0e9317ae9ff0b4ad88d4d050caf2ecf64811 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1553 From vrudomet at openjdk.org Thu Dec 1 16:04:46 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Thu, 1 Dec 2022 16:04:46 GMT Subject: [jdk17u-dev] Integrated: 8297481: Create a regression test for JDK-4424517 In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 03:34:28 GMT, Victor Rudometov wrote: > Backport for [JDK-8297481](https://bugs.openjdk.org/browse/JDK-8297481) > Create a regression test for JDK-4424517 > > https://github.com/openjdk/jdk/commit/e2d71c0a0d654841e3e591beeaa04b44c6e6b37f > > Clean backport > New test, low risk. > Test passes during manual run, checked on macos and linux This pull request has now been integrated. Changeset: 1f72ba22 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/1f72ba221429699a501c48bfcf3cf40568d0d36c Stats: 212 lines in 1 file changed: 212 ins; 0 del; 0 mod 8297481: Create a regression test for JDK-4424517 Backport-of: e2d71c0a0d654841e3e591beeaa04b44c6e6b37f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/941 From vrudomet at openjdk.org Thu Dec 1 16:06:16 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Thu, 1 Dec 2022 16:06:16 GMT Subject: [jdk11u-dev] Integrated: 8297481: Create a regression test for JDK-4424517 In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 03:34:31 GMT, Victor Rudometov wrote: > Backport for [JDK-8297481](https://bugs.openjdk.org/browse/JDK-8297481) > Create a regression test for JDK-4424517 > > https://github.com/openjdk/jdk/commit/e2d71c0a0d654841e3e591beeaa04b44c6e6b37f > > Clean backport > New test, low risk. > Test passes during manual run, checked on macos and linux This pull request has now been integrated. Changeset: dcc318c7 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/dcc318c78d79a00e1d2c866d46d1d77b11b53be3 Stats: 212 lines in 1 file changed: 212 ins; 0 del; 0 mod 8297481: Create a regression test for JDK-4424517 Backport-of: e2d71c0a0d654841e3e591beeaa04b44c6e6b37f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1559 From phh at openjdk.org Thu Dec 1 16:23:07 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 1 Dec 2022 16:23:07 GMT Subject: [jdk17u-dev] RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v2] In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 18:10:57 GMT, Ben Taylor wrote: >> Backporting for parity with Oracle JDK 17. Patch is clean after [JDK-8273497](https://bugs.openjdk.org/browse/JDK-8273497) (#914) and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) (#915). > > Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. This PR isn't clean even after https://github.com/openjdk/jdk17u-dev/pull/914 and https://github.com/openjdk/jdk17u-dev/pull/915. Perhaps it needs to be rebased. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/916 From phh at openjdk.org Thu Dec 1 18:57:46 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 1 Dec 2022 18:57:46 GMT Subject: [jdk17u-dev] RFR: 8284578: Relax InterpreterCodelet stub alignment [v5] In-Reply-To: References: <-S-PuYwXrek_TJNEUgFE7-5zClVhBKFK9CKEvX59iYY=.49d64463-b100-4589-a0f3-c0b57bc6935f@github.com> Message-ID: On Thu, 10 Nov 2022 15:45:58 GMT, Dmitry Chuyko wrote: >> This change improves density of interpreter codelets. I have no intent to backport JDK-8281467 [1] (Allow larger OptoLoopAlignment and CodeEntryAlignment), entire JDK-8283298 [2] (productize CodeCacheSegmentSize) and its related change in stubRoutines.cpp JDK-8282355 [3]. >> >> However I suppose that Modification of MethodHandles::generate_adapters() from JDK-8283298 which makes blob size more accurate is related to this fix, so I included it here. JDK-8283298 modifications of TemplateInterpreter::initialize_stub() are overwritten by the changes from the original JDK-8284578 patch. >> >> So this patch consists of >> - Original JDK-8284578 altered to be applicable without JDK-8283298 and JDK-8264207 [4] (can be backported afterwards). >> - MethodHandles::generate_adapters() and copyrights from JDK-8283298. >> >> Testing: tier1, tier2 on x86 and aarch64 (release) >> >> [0] https://bugs.openjdk.org/browse/JDK-8284578 >> [1] https://bugs.openjdk.org/browse/JDK-8281467 >> [2] https://bugs.openjdk.org/browse/JDK-8283298 >> [3] https://bugs.openjdk.org/browse/JDK-8282355 >> [4] https://bugs.openjdk.org/browse/JDK-8264207 > > Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8284578 > - Merge branch 'openjdk:master' into JDK-8284578 > - Backport 2241a057050ed521cfbfbe8a758353e621dee15f Thanks, Dima. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/753 From duke at openjdk.org Thu Dec 1 20:08:57 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 1 Dec 2022 20:08:57 GMT Subject: [jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol Message-ID: Backport for [JDK-8262981](https://bugs.openjdk.org/browse/JDK-8262981) (https://bugs.openjdk.org/browse/JDK-8262981) this backport is related to backport [JDK-8265278](https://bugs.openjdk.org/browse/JDK-8265278) or builds will fail. These backports are a part of a larger series of 28 plus backports [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). ------------- Commit messages: - 8262981: Create implementation for NSAccessibilitySlider protocol - 8256111: Create implementation for NSAccessibilityStaticText protocol - 8256126: Create implementation for NSAccessibilityImage protocol peer - 8261350: Create implementation for NSAccessibilityCheckBox protocol peer - 8261351: Create implementation for NSAccessibilityRadioButton protocol - JDK-8261352 create implementation for component peer for all the components who should be ignored in a11y interactions - 8256110: Create implementation for NSAccessibilityStepper protocol Changes: https://git.openjdk.org/jdk11u-dev/pull/1561/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1561&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8262981 Stats: 1256 lines in 22 files changed: 1201 ins; 51 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1561.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1561/head:pull/1561 PR: https://git.openjdk.org/jdk11u-dev/pull/1561 From iklam at openjdk.org Thu Dec 1 20:26:21 2022 From: iklam at openjdk.org (Ioi Lam) Date: Thu, 1 Dec 2022 20:26:21 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 02:55:18 GMT, Ioi Lam wrote: >> Hi, >> >> JDK-8275731: CDS archived enums objects are recreated at runtime >> >> Dependencies: >> >> => JDK-8267189: Remove duplicated unregistered classes from dynamic archive >> * JDK-8268821: Split systemDictionaryShared.cpp >> * JDK-8269004: Implement ResizableResourceHashtable >> * JDK-8270061: Change parameter order of ResourceHashtable >> * JDK-8270803: Reduce CDS API verbosity >> * JDK-8270489: Support archived heap objects in EpsilonGC >> >> The patch applies clean except manually edit the source file: >> >> * src/hotspot/share/classfile/systemDictionaryShared.hpp >> Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context. >> >> Tested jtreg tier1~3, no regression. >> >> Thanks, >> Leslie Zhai > > The description of this PR is not clear. Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? > > Please avoid mentioning JDK-8297543, as it's already closed as a duplicate of JDK-8275731. > Hi @iklam > > Thanks for your kind response! > > > The description of this PR is not clear. > > I updated the description. Please review it again. > > > Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? > > Yes. > > Thanks, Leslie Zhai I think the wording of this PR should be changed to something like this: * Backporting JDK-8267189 as a prerequisite for JDK-8275731 (CDS archived enums objects are recreated at runtime) You don't need to mention the other issues here. Instead, those issue should be listed in JDK-8275731: * Add label jdk17u-fix-reques to JDK-8275731 * Add a comment in JDK-8275731, with something like * In order to backport this issue to jdk 17u, the following issues must be backported first, in the order of 1. JDK-8267189: Remove duplicated unregistered classes from dynamic archive 2. JDK-XXXXXXX: xxxxxx 3. JDK-XXXXXXX: xxxxxx 4. JDK-XXXXXXX: xxxxxx You should reach an agreement with the jdk17u maintainers first. I would suggest sending mail to the jdk-updates-dev mailing list. See https://mail.openjdk.org/pipermail/jdk-updates-dev/ You listed JDK-8270489 (Support archived heap objects in EpsilonGC) as a prerequisite, but that's a very large change and seems unrelated to the enum problem. More discussion is needed on jdk-updates-dev to decide which set of issues should be backported. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From phh at openjdk.org Thu Dec 1 21:32:36 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 1 Dec 2022 21:32:36 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: Message-ID: <0miEBR4xNtv0rY_IF5NjSfo7zJcG6jz4Vbz3ig_Cf9U=.bf350615-6f9a-4af6-9f12-5ffbe5f397bf@github.com> On Wed, 30 Nov 2022 01:52:47 GMT, Michal Karm Babacek wrote: > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. Looks good except for using getResponse().uri() and a few formatting issues in HandshakeUrlEncodingTest.java. The change to use getResponse().uri() instead of getResponse().body() fixes a bug in tip, so can't be part of a backport. The thing to do is use the buggy code from the original commit in this backport, fix the problem in tip, then backport that fix to 19u, 17u, and 11u. On formatting issues, future backports are easier if you match the original formatting as closely as possible. Looks like you're using and IDE that auto-formats. At line 59: import static java.lang.System.out; import static java.net.http.HttpClient.Builder.NO_PROXY; import static org.testng.Assert.*; should be import static java.net.http.HttpClient.Builder.NO_PROXY; import static org.testng.Assert.*; import static java.lang.System.out; to more closely follow the original. In fact, if all the test uses is assertEquals, assertNotNull, and fail, just use the original commit code. Indent/format the same as the original commit: lines 85-88, 89-92, 106-108, 111, 115, 133-135, 137, 141-146, 153-158, 174-176, 188-190, and missing blank line after 196. Might have missed somthing, but you get the idea. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From vrudomet at openjdk.org Thu Dec 1 21:33:40 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Thu, 1 Dec 2022 21:33:40 GMT Subject: [jdk17u-dev] Integrated: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation In-Reply-To: References: Message-ID: On Tue, 29 Nov 2022 08:18:32 GMT, Victor Rudometov wrote: > Backport for [JDK-8297530](https://bugs.openjdk.org/browse/JDK-8297530) java.lang.IllegalArgumentException: Negative length on strings concatenation > > Clean backport, minor change > Tier1, Tier2, JCK Compiler, JCK Runtime passed > New test during run. This pull request has now been integrated. Changeset: d5239368 Author: Victor Rudometov Committer: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/d5239368721a0f82c5a9df2f14739fbcd5031c0e Stats: 141 lines in 2 files changed: 139 ins; 0 del; 2 mod 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Backport-of: 87d1097d9be1ef804bfd4640a4254126242b1d8c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/940 From btaylor at openjdk.org Thu Dec 1 22:38:39 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 1 Dec 2022 22:38:39 GMT Subject: [jdk17u-dev] RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3] In-Reply-To: References: Message-ID: <2H_v69TaKKe7ujzOQd3OjRRJ7lnn9O9HP5EkrFOWSi0=.b0463392-2b0f-4b07-916e-30ee2473c381@github.com> > Backporting for parity with Oracle JDK 17. Patch is clean after [JDK-8273497](https://bugs.openjdk.org/browse/JDK-8273497) (#914) and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) (#915). Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport f42caefe2e7658bfb5ab8ef938b134bdb6746ff1 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/916/files - new: https://git.openjdk.org/jdk17u-dev/pull/916/files/1a816a5d..07a4bd4b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=916&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=916&range=01-02 Stats: 2522 lines in 64 files changed: 2073 ins; 200 del; 249 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/916.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/916/head:pull/916 PR: https://git.openjdk.org/jdk17u-dev/pull/916 From btaylor at openjdk.org Thu Dec 1 22:38:39 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 1 Dec 2022 22:38:39 GMT Subject: [jdk17u-dev] RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3] In-Reply-To: <2H_v69TaKKe7ujzOQd3OjRRJ7lnn9O9HP5EkrFOWSi0=.b0463392-2b0f-4b07-916e-30ee2473c381@github.com> References: <2H_v69TaKKe7ujzOQd3OjRRJ7lnn9O9HP5EkrFOWSi0=.b0463392-2b0f-4b07-916e-30ee2473c381@github.com> Message-ID: On Thu, 1 Dec 2022 22:17:41 GMT, Ben Taylor wrote: >> Backporting for parity with Oracle JDK 17. Patch is clean after [JDK-8273497](https://bugs.openjdk.org/browse/JDK-8273497) (#914) and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) (#915). > > Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport f42caefe2e7658bfb5ab8ef938b134bdb6746ff1 I'm not sure why those conflicts appeared, after pulling the current `master` and redoing the backport with `git backport --from https://github.com/openjdk/jdk f42caefe2e7658bfb5ab8ef938b134bdb6746ff1` it is clean again. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/916 From serb at openjdk.org Fri Dec 2 00:05:39 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 2 Dec 2022 00:05:39 GMT Subject: [jdk11u-dev] RFR: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters Message-ID: Hi all, This pull request contains a backport of commit [87f00f4a](https://github.com/openjdk/jdk/commit/87f00f4a1bfb392be0684edcdfa0254caec4ca03) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 30 Nov 2022 and was reviewed by Phil Race and Alexey Ivanov. Thanks! ------------- Commit messages: - delete pattern-m in the instanceof - Backport 87f00f4a1bfb392be0684edcdfa0254caec4ca03 Changes: https://git.openjdk.org/jdk11u-dev/pull/1563/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1563&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296878 Stats: 92 lines in 2 files changed: 77 ins; 2 del; 13 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1563.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1563/head:pull/1563 PR: https://git.openjdk.org/jdk11u-dev/pull/1563 From serb at openjdk.org Fri Dec 2 00:05:41 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 2 Dec 2022 00:05:41 GMT Subject: [jdk11u-dev] RFR: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 22:02:50 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [87f00f4a](https://github.com/openjdk/jdk/commit/87f00f4a1bfb392be0684edcdfa0254caec4ca03) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 30 Nov 2022 and was reviewed by Phil Race and Alexey Ivanov. > Thanks! src/java.desktop/share/classes/javax/swing/JPasswordField.java line 290: > 288: DocumentFilter filter = null; > 289: if (doc instanceof AbstractDocument) { > 290: filter = ((AbstractDocument) doc).getDocumentFilter(); The change is not clean because I have to remove pattern matching in this `instanceof `block. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1563 From lzhai at openjdk.org Fri Dec 2 01:29:34 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Fri, 2 Dec 2022 01:29:34 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 20:22:38 GMT, Ioi Lam wrote: >> The description of this PR is not clear. Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? >> >> Please avoid mentioning JDK-8297543, as it's already closed as a duplicate of JDK-8275731. > >> Hi @iklam >> >> Thanks for your kind response! >> >> > The description of this PR is not clear. >> >> I updated the description. Please review it again. >> >> > Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? >> >> Yes. >> >> Thanks, Leslie Zhai > > I think the wording of this PR should be changed to something like this: > > * Backporting JDK-8267189 as a prerequisite for JDK-8275731 (CDS archived enums objects are recreated at runtime) > > You don't need to mention the other issues here. Instead, those issue should be listed in JDK-8275731: > > * Add label jdk17u-fix-reques to JDK-8275731 > * Add a comment in JDK-8275731, with something like > * In order to backport this issue to jdk 17u, the following issues must be backported first, in the order of > 1. JDK-8267189: Remove duplicated unregistered classes from dynamic archive > 2. JDK-XXXXXXX: xxxxxx > 3. JDK-XXXXXXX: xxxxxx > 4. JDK-XXXXXXX: xxxxxx > > You should reach an agreement with the jdk17u maintainers first. I would suggest sending mail to the jdk-updates-dev mailing list. See https://mail.openjdk.org/pipermail/jdk-updates-dev/ > > You listed JDK-8270489 (Support archived heap objects in EpsilonGC) as a prerequisite, but that's a very large change and seems unrelated to the enum problem. More discussion is needed on jdk-updates-dev to decide which set of issues should be backported. Hi @iklam Thanks for your teaching! > I think the wording of this PR should be changed to something like this: Updated. > You don't need to mention the other issues here. Instead, those issue should be listed in JDK-8275731 Added. > You should reach an agreement with the jdk17u maintainers first. I would suggest sending mail to the jdk-updates-dev mailing list. May I just follow the [existing thread](https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-December/019077.html) or create a new thread? > You listed JDK-8270489 (Support archived heap objects in EpsilonGC) as a prerequisite, but that's a very large change and seems unrelated to the enum problem Yes, there is a very large change, and owing to it requires `is_fully_available`: The first commit about `HeapShared::is_fully_available` is for JDK-8270489: Support archived heap objects in EpsilonGC. And the latest commit about `ArchiveHeapLoader::is_fully_available` is for JDK-8293293: Move archive heap loading code out of heapShared.cpp. > More discussion is needed on jdk-updates-dev to decide which set of issues should be backported. Yes! Thanks, Leslie Zhai ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From andrew at openjdk.org Fri Dec 2 02:03:57 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 2 Dec 2022 02:03:57 GMT Subject: [jdk17u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 16:13:37 GMT, Andrew John Hughes wrote: > > Do you plan to handle 11u as well? > > I am preparing an 11u-dev PR as well. Great. Same thing, please aim for 11u so we can get this in with the tzdata 2022f change. > https://wiki.openjdk.org/display/JDKUpdates/JDK+17u Tuesday, **December 6 2022: Rampdown; last merge from jdk17u-dev to jdk17u** - so no critical request needed. > > /integrate Ok this is strange. Why is 11u & 17u rampdown so late? 8u's was last week. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/942 From duke at openjdk.org Fri Dec 2 03:07:33 2022 From: duke at openjdk.org (Gili Tzabari) Date: Fri, 2 Dec 2022 03:07:33 GMT Subject: [jdk19u] RFR: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads In-Reply-To: References: Message-ID: <1RD3q-caeWCypC83YwiyHFP2vB0cnKWoTOqdcPJjMJQ=.1b95e627-a15c-4091-a43f-c6a70e802e33@github.com> On Mon, 28 Nov 2022 06:28:50 GMT, David Holmes wrote: >> Looks good. > > Thanks @TobiHartmann ! @dholmes-ora Thank you for backporting this important fix! ------------- PR: https://git.openjdk.org/jdk19u/pull/97 From duke at openjdk.org Fri Dec 2 04:24:20 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Fri, 2 Dec 2022 04:24:20 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: <0miEBR4xNtv0rY_IF5NjSfo7zJcG6jz4Vbz3ig_Cf9U=.bf350615-6f9a-4af6-9f12-5ffbe5f397bf@github.com> References: <0miEBR4xNtv0rY_IF5NjSfo7zJcG6jz4Vbz3ig_Cf9U=.bf350615-6f9a-4af6-9f12-5ffbe5f397bf@github.com> Message-ID: On Thu, 1 Dec 2022 21:29:48 GMT, Paul Hohensee wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Looks good except for using getResponse().uri() and a few formatting issues in HandshakeUrlEncodingTest.java. > > The change to use getResponse().uri() instead of getResponse().body() fixes a bug in tip, so can't be part of a backport. The thing to do is use the buggy code from the original commit in this backport, fix the problem in tip, then backport that fix to 19u, 17u, and 11u. > > On formatting issues, future backports are easier if you match the original formatting as closely as possible. Looks like you're using and IDE that auto-formats. > > At line 59: > > import static java.lang.System.out; > import static java.net.http.HttpClient.Builder.NO_PROXY; > import static org.testng.Assert.*; > > should be > > import static java.net.http.HttpClient.Builder.NO_PROXY; > import static org.testng.Assert.*; > import static java.lang.System.out; > > to more closely follow the original. In fact, if all the test uses is assertEquals, assertNotNull, and fail, just use the original commit code. > > Indent/format the same as the original commit: lines 85-88, 89-92, 106-108, 111, 115, 133-135, 137, 141-146, 153-158, 174-176, 188-190, and missing blank line after 196. Might have missed somthing, but you get the idea. @phohensee Thank you for the review. Ad formatting: Ack. Will do. Ad > The change to use getResponse().uri() instead of getResponse().body() fixes a bug in tip, so can't be part of a backport. Oh...I see. So the fact that the body is returned even though there was a failure is a bug, not a feature/desirable chage? I will browse the Jira and check the spec to make sure I am not bending the test to a faulty implementation then. Cheers Karm ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From shade at openjdk.org Fri Dec 2 08:05:40 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Dec 2022 08:05:40 GMT Subject: [jdk17u-dev] RFR: 8297309: Memory leak in ShenandoahFullGC In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 12:23:48 GMT, Aleksey Shipilev wrote: > Clean backport to fix a trivial memory leak in Shenandoah. > > Additional testing: > - [x] Linux x86_64 fastdebug, `hotspot_gc_shenandoah` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/938 From shade at openjdk.org Fri Dec 2 08:09:27 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Dec 2022 08:09:27 GMT Subject: [jdk17u-dev] Integrated: 8297309: Memory leak in ShenandoahFullGC In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 12:23:48 GMT, Aleksey Shipilev wrote: > Clean backport to fix a trivial memory leak in Shenandoah. > > Additional testing: > - [x] Linux x86_64 fastdebug, `hotspot_gc_shenandoah` This pull request has now been integrated. Changeset: 87063038 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/87063038cba5852d732988f995a24dd16f19dbe8 Stats: 5 lines in 2 files changed: 5 ins; 0 del; 0 mod 8297309: Memory leak in ShenandoahFullGC Backport-of: b80f5af6981440aec14f4dedbc5ee46364d0254c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/938 From mbaesken at openjdk.org Fri Dec 2 08:12:57 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Dec 2022 08:12:57 GMT Subject: [jdk11u-dev] RFR: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used Message-ID: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used ------------- Commit messages: - Backport 88957a7ce8932b95e3a18e6a7d1ceb3b7f60c781 Changes: https://git.openjdk.org/jdk11u-dev/pull/1564/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1564&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297147 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1564.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1564/head:pull/1564 PR: https://git.openjdk.org/jdk11u-dev/pull/1564 From yan at openjdk.org Fri Dec 2 08:34:03 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 2 Dec 2022 08:34:03 GMT Subject: [jdk15u-dev] RFR: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02 Message-ID: Backporting this update for consistency. Clean backport with language-subtag-registry.txt still in make subtree instead of java.base. ------------- Commit messages: - Backport 7b19226be24356572df493446e3b0a9380b3d217 Changes: https://git.openjdk.org/jdk15u-dev/pull/310/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=310&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267038 Stats: 281 lines in 2 files changed: 271 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/310.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/310/head:pull/310 PR: https://git.openjdk.org/jdk15u-dev/pull/310 From mbaesken at openjdk.org Fri Dec 2 08:36:04 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Dec 2022 08:36:04 GMT Subject: [jdk11u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> References: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> Message-ID: On Wed, 30 Nov 2022 16:03:17 GMT, Matthias Baesken wrote: > Backport of 8296715; es_419.xml has different path, otherwise close to 13u backport Hi Martin and Yuri, thanks for the reviews ! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1560 From mbaesken at openjdk.org Fri Dec 2 08:39:46 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Dec 2022 08:39:46 GMT Subject: [jdk11u-dev] Integrated: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> References: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> Message-ID: <9X7HAIy1xlgdlluXy8SdL3eDyVKn51iNwaSyAcge03s=.c9b929eb-f1ad-442e-b06a-86371bafb535@github.com> On Wed, 30 Nov 2022 16:03:17 GMT, Matthias Baesken wrote: > Backport of 8296715; es_419.xml has different path, otherwise close to 13u backport This pull request has now been integrated. Changeset: da9de488 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/da9de488990ff47fe06343439f2180ec1b2a3061 Stats: 14 lines in 4 files changed: 6 ins; 3 del; 5 mod 8296715: CLDR v42 update for tzdata 2022f Reviewed-by: mdoerr, yan Backport-of: b8e815b6fe0f4818628d8df05f398e92355e35fb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1560 From sgehwolf at openjdk.org Fri Dec 2 08:55:20 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 2 Dec 2022 08:55:20 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: <0miEBR4xNtv0rY_IF5NjSfo7zJcG6jz4Vbz3ig_Cf9U=.bf350615-6f9a-4af6-9f12-5ffbe5f397bf@github.com> Message-ID: On Fri, 2 Dec 2022 04:21:31 GMT, Michal Karm Babacek wrote: > Oh...I see. So the fact that the body is returned even though there was a failure is a bug, not a feature/desirable chage? I will browse the Jira and check the spec to make sure I am not bending the test to a faulty implementation then. Even if you discover a discrepancy, this would need to get fixed in [JDK head](https://github.com/openjdk/jdk) first and then backported. Please keep that in mind. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From yan at openjdk.org Fri Dec 2 08:59:08 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 2 Dec 2022 08:59:08 GMT Subject: [jdk13u-dev] RFR: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02 Message-ID: Backporting this update for consistency. Clean backport with language-subtag-registry.txt still in make subtree instead of java.base. ------------- Commit messages: - Backport 7b19226be24356572df493446e3b0a9380b3d217 Changes: https://git.openjdk.org/jdk13u-dev/pull/437/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=437&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267038 Stats: 281 lines in 2 files changed: 271 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/437.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/437/head:pull/437 PR: https://git.openjdk.org/jdk13u-dev/pull/437 From yan at openjdk.org Fri Dec 2 09:10:43 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 2 Dec 2022 09:10:43 GMT Subject: [jdk13u-dev] Integrated: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02 In-Reply-To: References: Message-ID: <8-0Vkj3VbuqHnWUOqeSFY3Go-zcFLFlO63lxWJfKCNA=.f544b20f-044e-4f37-8f5e-2fd8214a6078@github.com> On Fri, 2 Dec 2022 08:50:48 GMT, Yuri Nesterenko wrote: > Backporting this update for consistency. Clean backport with language-subtag-registry.txt still in make subtree instead of java.base. This pull request has now been integrated. Changeset: 19f4f229 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/19f4f229849e8c19ba20b6875b3c2d25c71e7142 Stats: 281 lines in 2 files changed: 271 ins; 2 del; 8 mod 8267038: Update IANA Language Subtag Registry to Version 2022-03-02 Backport-of: 7b19226be24356572df493446e3b0a9380b3d217 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/437 From yan at openjdk.org Fri Dec 2 09:11:19 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 2 Dec 2022 09:11:19 GMT Subject: [jdk15u-dev] Integrated: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02 In-Reply-To: References: Message-ID: <8lpDArOV4g76xlEvC-FzuijI8DkKmZkfx7g7WNHqZY0=.80d8c1aa-e6e3-43b8-965a-0bdcaad08a3c@github.com> On Fri, 2 Dec 2022 08:19:29 GMT, Yuri Nesterenko wrote: > Backporting this update for consistency. Clean backport with language-subtag-registry.txt still in make subtree instead of java.base. This pull request has now been integrated. Changeset: cb1dee17 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/cb1dee172892a824f8ea7b25ce126ca45b4fe10f Stats: 281 lines in 2 files changed: 271 ins; 2 del; 8 mod 8267038: Update IANA Language Subtag Registry to Version 2022-03-02 Backport-of: 7b19226be24356572df493446e3b0a9380b3d217 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/310 From mbaesken at openjdk.org Fri Dec 2 10:12:13 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Dec 2022 10:12:13 GMT Subject: [jdk11u-dev] Integrated: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used In-Reply-To: References: Message-ID: On Fri, 2 Dec 2022 08:03:31 GMT, Matthias Baesken wrote: > 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used This pull request has now been integrated. Changeset: 5fdb254e Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/5fdb254e0f9fb473677300238f6994be3ed67705 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used Backport-of: 88957a7ce8932b95e3a18e6a7d1ceb3b7f60c781 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1564 From aph-open at littlepinkcloud.com Fri Dec 2 10:55:24 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Fri, 2 Dec 2022 10:55:24 +0000 Subject: JDK-8297656: AArch64: Enable AES/GCM Intrinsics Message-ID: Patch approvals for 17u and 11u, please. https://bugs.openjdk.org/browse/JDK-8297656 -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From yan at openjdk.org Fri Dec 2 11:16:44 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 2 Dec 2022 11:16:44 GMT Subject: [jdk15u-dev] RFR: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08 Message-ID: Backporting this update for parity with Oracle and general consistency. All relevant tests do pass. ------------- Commit messages: - Backport 992f209deffac50635646b42ec4220bfbfc96d39 Changes: https://git.openjdk.org/jdk15u-dev/pull/311/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=311&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287180 Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/311.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/311/head:pull/311 PR: https://git.openjdk.org/jdk15u-dev/pull/311 From yan at openjdk.org Fri Dec 2 11:40:46 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 2 Dec 2022 11:40:46 GMT Subject: [jdk13u-dev] RFR: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08 Message-ID: Backporting this update for parity with Oracle and general consistency. All relevant tests do pass. ------------- Commit messages: - Backport 992f209deffac50635646b42ec4220bfbfc96d39 Changes: https://git.openjdk.org/jdk13u-dev/pull/438/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=438&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287180 Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/438.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/438/head:pull/438 PR: https://git.openjdk.org/jdk13u-dev/pull/438 From yan at openjdk.org Fri Dec 2 11:50:24 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 2 Dec 2022 11:50:24 GMT Subject: [jdk15u-dev] Integrated: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08 In-Reply-To: References: Message-ID: On Fri, 2 Dec 2022 11:06:25 GMT, Yuri Nesterenko wrote: > Backporting this update for parity with Oracle and general consistency. All relevant tests do pass. This pull request has now been integrated. Changeset: 352a2b97 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/352a2b9729f3b85e1deb32d811b7626726ed8aea Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod 8287180: Update IANA Language Subtag Registry to Version 2022-08-08 Backport-of: 992f209deffac50635646b42ec4220bfbfc96d39 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/311 From yan at openjdk.org Fri Dec 2 11:54:03 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 2 Dec 2022 11:54:03 GMT Subject: [jdk13u-dev] Integrated: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08 In-Reply-To: References: Message-ID: On Fri, 2 Dec 2022 11:32:09 GMT, Yuri Nesterenko wrote: > Backporting this update for parity with Oracle and general consistency. All relevant tests do pass. This pull request has now been integrated. Changeset: bddd4b40 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/bddd4b407cbf79202284c9d6f00d0fd209c354b5 Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod 8287180: Update IANA Language Subtag Registry to Version 2022-08-08 Backport-of: 992f209deffac50635646b42ec4220bfbfc96d39 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/438 From aph-open at littlepinkcloud.com Fri Dec 2 12:13:01 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Fri, 2 Dec 2022 12:13:01 +0000 Subject: JDK-8297656: AArch64: Enable AES/GCM Intrinsics In-Reply-To: References: Message-ID: Thanks! On 12/2/22 10:55, Andrew Haley wrote: > Patch approvals for 17u and 11u, please. > > https://bugs.openjdk.org/browse/JDK-8297656 > -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From aph at openjdk.org Fri Dec 2 12:17:50 2022 From: aph at openjdk.org (Andrew Haley) Date: Fri, 2 Dec 2022 12:17:50 GMT Subject: [jdk11u-dev] Integrated: 8297656: AArch64: Enable AES/GCM Intrinsics In-Reply-To: <0IQkbwRsfchhuggkEkvMIFIPf5HkAcEZYKbX0v6S2as=.c47922df-f953-4cbb-9986-7bc55c3e06f0@github.com> References: <0IQkbwRsfchhuggkEkvMIFIPf5HkAcEZYKbX0v6S2as=.c47922df-f953-4cbb-9986-7bc55c3e06f0@github.com> Message-ID: On Fri, 25 Nov 2022 17:49:03 GMT, Andrew Haley wrote: > These have been in mainline for more than a year. Time to enable them. This pull request has now been integrated. Changeset: dbd378c4 Author: Andrew Haley URL: https://git.openjdk.org/jdk11u-dev/commit/dbd378c4a11949aaa1b6f2360d60f4cac57ea7a7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8297656: AArch64: Enable AES/GCM Intrinsics Reviewed-by: adinn ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1555 From aph at openjdk.org Fri Dec 2 12:18:36 2022 From: aph at openjdk.org (Andrew Haley) Date: Fri, 2 Dec 2022 12:18:36 GMT Subject: [jdk17u-dev] Integrated: 8297656: AArch64: Enable AES/GCM Intrinsics In-Reply-To: <0gnkZkHlqtgtTXmHq9ZP9HvpRvuGtqt6Q5miqNo--10=.411dca64-c74e-4106-8ee2-a1354c866fab@github.com> References: <0gnkZkHlqtgtTXmHq9ZP9HvpRvuGtqt6Q5miqNo--10=.411dca64-c74e-4106-8ee2-a1354c866fab@github.com> Message-ID: On Fri, 25 Nov 2022 17:04:42 GMT, Andrew Haley wrote: > These have been in mainline for more than a year. Time to enable them. This pull request has now been integrated. Changeset: 85a655b9 Author: Andrew Haley URL: https://git.openjdk.org/jdk17u-dev/commit/85a655b908abf2bf45db90192e4b26820ed43930 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8297656: AArch64: Enable AES/GCM Intrinsics Reviewed-by: adinn ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/935 From btaylor at openjdk.org Fri Dec 2 13:36:00 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 2 Dec 2022 13:36:00 GMT Subject: [jdk17u-dev] Integrated: 8293550: Optionally add get-task-allow entitlement to macos binaries In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 01:40:22 GMT, Ben Taylor wrote: > Backporting for parity with Oracle JDK 17. Patch is clean after [JDK-8273497](https://bugs.openjdk.org/browse/JDK-8273497) (#914) and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) (#915). This pull request has now been integrated. Changeset: da6fca4d Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/da6fca4d78465625775f7b384ba752185694f699 Stats: 212 lines in 10 files changed: 158 ins; 47 del; 7 mod 8293550: Optionally add get-task-allow entitlement to macos binaries Backport-of: f42caefe2e7658bfb5ab8ef938b134bdb6746ff1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/916 From duke at openjdk.org Fri Dec 2 16:03:17 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Fri, 2 Dec 2022 16:03:17 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: <0miEBR4xNtv0rY_IF5NjSfo7zJcG6jz4Vbz3ig_Cf9U=.bf350615-6f9a-4af6-9f12-5ffbe5f397bf@github.com> References: <0miEBR4xNtv0rY_IF5NjSfo7zJcG6jz4Vbz3ig_Cf9U=.bf350615-6f9a-4af6-9f12-5ffbe5f397bf@github.com> Message-ID: On Thu, 1 Dec 2022 21:29:48 GMT, Paul Hohensee wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Looks good except for using getResponse().uri() and a few formatting issues in HandshakeUrlEncodingTest.java. > > The change to use getResponse().uri() instead of getResponse().body() fixes a bug in tip, so can't be part of a backport. The thing to do is use the buggy code from the original commit in this backport, fix the problem in tip, then backport that fix to 19u, 17u, and 11u. > > On formatting issues, future backports are easier if you match the original formatting as closely as possible. Looks like you're using and IDE that auto-formats. > > At line 59: > > import static java.lang.System.out; > import static java.net.http.HttpClient.Builder.NO_PROXY; > import static org.testng.Assert.*; > > should be > > import static java.net.http.HttpClient.Builder.NO_PROXY; > import static org.testng.Assert.*; > import static java.lang.System.out; > > to more closely follow the original. In fact, if all the test uses is assertEquals, assertNotNull, and fail, just use the original commit code. > > Indent/format the same as the original commit: lines 85-88, 89-92, 106-108, 111, 115, 133-135, 137, 141-146, 153-158, 174-176, 188-190, and missing blank line after 196. Might have missed somthing, but you get the idea. Helo, @phohensee, I changed the behavior of the test in the tip (HEAD), so as I can then backport it along the JDK-8245245 patch to 19u, 17u, and 11u. https://github.com/openjdk/jdk/pull/11486 @jerboaa If I am reading the [spec](https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1) right, there is IMHO no need to change the behavior of the implementation. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From phh at openjdk.org Fri Dec 2 16:31:46 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 2 Dec 2022 16:31:46 GMT Subject: [jdk17u-dev] RFR: 8294310: compare.sh fails on macos after JDK-8293550 Message-ID: Clean backport of required follow-on to 17u backport of [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). ------------- Commit messages: - Backport b9eeec2b6b8f97d2ba33462b27d091f918067f78 Changes: https://git.openjdk.org/jdk17u-dev/pull/944/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=944&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294310 Stats: 14 lines in 3 files changed: 10 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/944.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/944/head:pull/944 PR: https://git.openjdk.org/jdk17u-dev/pull/944 From btaylor at openjdk.org Fri Dec 2 17:00:10 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 2 Dec 2022 17:00:10 GMT Subject: [jdk17u-dev] RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 20:31:49 GMT, Ben Taylor wrote: > Backporting to 17 for improved performance. > Backport is clean. GHA tests are now enabled and passing ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/918 From phh at openjdk.org Fri Dec 2 17:15:24 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 2 Dec 2022 17:15:24 GMT Subject: [jdk17u-dev] RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 20:31:49 GMT, Ben Taylor wrote: > Backporting to 17 for improved performance. > Backport is clean. Testing? Please enable pre-submit testing on your repo. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/918 From phh at openjdk.org Fri Dec 2 17:20:54 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 2 Dec 2022 17:20:54 GMT Subject: [jdk11u-dev] RFR: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 22:02:50 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [87f00f4a](https://github.com/openjdk/jdk/commit/87f00f4a1bfb392be0684edcdfa0254caec4ca03) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 30 Nov 2022 and was reviewed by Phil Race and Alexey Ivanov. > Thanks! Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1563 From phh at openjdk.org Fri Dec 2 17:22:11 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 2 Dec 2022 17:22:11 GMT Subject: [jdk17u-dev] RFR: 8293965: Code signing warnings after JDK-8293550 Message-ID: Clean backport follow-on to [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) 17u backport. ------------- Commit messages: - Backport f91762f56ea7fb27b6fa54d07d3b3b0650bab0bc Changes: https://git.openjdk.org/jdk17u-dev/pull/946/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=946&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293965 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/946.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/946/head:pull/946 PR: https://git.openjdk.org/jdk17u-dev/pull/946 From duke at openjdk.org Fri Dec 2 17:53:17 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Fri, 2 Dec 2022 17:53:17 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: <0miEBR4xNtv0rY_IF5NjSfo7zJcG6jz4Vbz3ig_Cf9U=.bf350615-6f9a-4af6-9f12-5ffbe5f397bf@github.com> Message-ID: On Fri, 2 Dec 2022 08:52:48 GMT, Severin Gehwolf wrote: >> @phohensee Thank you for the review. >> >> Ad formatting: Ack. Will do. >> >> Ad >> >>> The change to use getResponse().uri() instead of getResponse().body() fixes a bug in tip, so can't be part of a backport. >> >> Oh...I see. So the fact that the body is returned even though there was a failure is a bug, not a feature/desirable chage? I will browse the Jira and check the spec to make sure I am not bending the test to a faulty implementation then. >> >> >> Cheers >> Karm > >> Oh...I see. So the fact that the body is returned even though there was a failure is a bug, not a feature/desirable chage? I will browse the Jira and check the spec to make sure I am not bending the test to a faulty implementation then. > > Even if you discover a discrepancy, this would need to get fixed in [JDK head](https://github.com/openjdk/jdk) first and then backported. Please keep that in mind. @jerboaa I realized the patch is already backported to JDK 19 and JDK 17. So it's just JDK 11 I'd like to backport JDK-8245245 to. And IIUC, the change in https://github.com/openjdk/jdk/pull/11486 needed for JDK 11 will need backporting to JDK 19, JDK 17 too. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From btaylor at openjdk.org Fri Dec 2 19:21:21 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 2 Dec 2022 19:21:21 GMT Subject: [jdk17u-dev] RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response [v2] In-Reply-To: References: Message-ID: <4xvvZjEeKQPfSxHP4E4tpFqr3nLmtPAwKXkt1JFkL4g=.af57336c-1b42-40aa-a16d-431e1dcb4b0e@github.com> > Backporting to 17 for improved performance. > Backport is clean. Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' of https://git.openjdk.org/jdk17u-dev into 8297211 - Backport 392ac7055d4697c56fa85ac5572f5bc4dc431f1d ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/918/files - new: https://git.openjdk.org/jdk17u-dev/pull/918/files/dfdaa297..efe5daef Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=918&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=918&range=00-01 Stats: 3150 lines in 78 files changed: 2620 ins; 249 del; 281 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/918.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/918/head:pull/918 PR: https://git.openjdk.org/jdk17u-dev/pull/918 From btaylor at openjdk.org Fri Dec 2 19:21:21 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 2 Dec 2022 19:21:21 GMT Subject: [jdk17u-dev] RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 20:31:49 GMT, Ben Taylor wrote: > Backporting to 17 for improved performance. > Backport is clean. Rebased on current master to try to get tests to run - they are enabled but didn't run for some reason ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/918 From duke at openjdk.org Fri Dec 2 20:22:09 2022 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 2 Dec 2022 20:22:09 GMT Subject: [jdk11u-dev] Withdrawn: 8262981: Create implementation for NSAccessibilitySlider protocol In-Reply-To: References: Message-ID: <1Y_9VVP_NDLm-0ExZ897PTH7tx9FgKhtQVmemfKM-xk=.2e6bf7b4-861c-4d31-8208-0bbf1a222bcc@github.com> On Thu, 1 Dec 2022 19:58:43 GMT, Autumn Capasso wrote: > Backport for [JDK-8262981](https://bugs.openjdk.org/browse/JDK-8262981) (https://bugs.openjdk.org/browse/JDK-8262981) this backport is related to backport [JDK-8265278](https://bugs.openjdk.org/browse/JDK-8265278) or builds will fail. These backports are a part of a larger series of 28 plus backports [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1561 From duke at openjdk.org Fri Dec 2 20:34:24 2022 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 2 Dec 2022 20:34:24 GMT Subject: [jdk11u-dev] RFR: 8256108: Create implementation for NSAccessibilityElement protocol peer Message-ID: Backport [JDK-8256108](https://bugs.openjdk.org/browse/JDK-8256108). This backport wasn't completely clean there was a merge conflict in the java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m. I cleaned it up the file. This backport is part of a series of 28 backports [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). ------------- Commit messages: - Backport 4c095252a540ea799d6014fb42e6ebedb3b24196 - 8256108: Create implementation for NSAccessibilityElement protocol peer Changes: https://git.openjdk.org/jdk11u-dev/pull/1566/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1566&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256108 Stats: 45 lines in 1 file changed: 44 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1566.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1566/head:pull/1566 PR: https://git.openjdk.org/jdk11u-dev/pull/1566 From duke at openjdk.org Sat Dec 3 09:33:18 2022 From: duke at openjdk.org (duke) Date: Sat, 3 Dec 2022 09:33:18 GMT Subject: [jdk19u] Withdrawn: 8170305: URLConnection doesn't handle HTTP/1.1 1xx (informational) messages In-Reply-To: References: Message-ID: On Sun, 18 Sep 2022 15:24:03 GMT, Vladimir Kempik wrote: > Clean backport to jdk19u This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk19u/pull/27 From duke at openjdk.org Sat Dec 3 10:10:59 2022 From: duke at openjdk.org (duke) Date: Sat, 3 Dec 2022 10:10:59 GMT Subject: [jdk17u-dev] Withdrawn: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression In-Reply-To: <5CvyCGTkvzZAUs25YfI1cP-Ks_Es0oBfPZaKbt8xejE=.9449b9da-9218-49d6-affd-bf1168eca759@github.com> References: <5CvyCGTkvzZAUs25YfI1cP-Ks_Es0oBfPZaKbt8xejE=.9449b9da-9218-49d6-affd-bf1168eca759@github.com> Message-ID: On Wed, 21 Sep 2022 06:15:00 GMT, Alexey Pavlyutkin wrote: > Hi! Here is backport of [JDK-8275233](https://bugs.openjdk.org/browse/JDK-8275233) that fixes incorrect `javac -g` flag processing. The issue was introduced by [JDK-8200301](https://bugs.openjdk.org/browse/JDK-8200301). It prevents proper debug info generation for labmdas, in particular it causes wrong line numbers in stack trace upon throwing an exception from a labmda fucntion. > > The original patch applied cleanly > > Verification (amd64/20.04LTS): test/langtools/tools/javac/lambda/deduplication/DeduplicationDebugInfo.java (new test) > Regression (amd64/20.04LTS): test/langtools This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/702 From duke at openjdk.org Sat Dec 3 10:12:45 2022 From: duke at openjdk.org (duke) Date: Sat, 3 Dec 2022 10:12:45 GMT Subject: [jdk17u-dev] Withdrawn: 8293774: Improve TraceOptoParse to dump the bytecode name In-Reply-To: References: Message-ID: <7xX5-nrpABSCcyDuYWYBwtEXt5E2HDKmW-9UKbaViSE=.7006da6d-9a20-4d87-baa8-f9bacec149c6@github.com> On Thu, 15 Sep 2022 02:46:16 GMT, Jie Fu wrote: > 8293774: Improve TraceOptoParse to dump the bytecode name This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/671 From duke at openjdk.org Sat Dec 3 10:13:16 2022 From: duke at openjdk.org (duke) Date: Sat, 3 Dec 2022 10:13:16 GMT Subject: [jdk17u-dev] Withdrawn: 8282047: Enhance StringDecode/Encode microbenchmarks In-Reply-To: References: Message-ID: On Wed, 14 Sep 2022 13:02:55 GMT, Boris Ulasevich wrote: > This change is a backport of "8282047: Enhance StringDecode/Encode microbenchmarks" commit - a benchmarks update as a part of subsequent [JDK-8281146](https://bugs.openjdk.org/browse/JDK-8281146) change. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/666 From sgehwolf at openjdk.org Mon Dec 5 15:39:23 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 5 Dec 2022 15:39:23 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: <0miEBR4xNtv0rY_IF5NjSfo7zJcG6jz4Vbz3ig_Cf9U=.bf350615-6f9a-4af6-9f12-5ffbe5f397bf@github.com> Message-ID: On Fri, 2 Dec 2022 08:52:48 GMT, Severin Gehwolf wrote: >> @phohensee Thank you for the review. >> >> Ad formatting: Ack. Will do. >> >> Ad >> >>> The change to use getResponse().uri() instead of getResponse().body() fixes a bug in tip, so can't be part of a backport. >> >> Oh...I see. So the fact that the body is returned even though there was a failure is a bug, not a feature/desirable chage? I will browse the Jira and check the spec to make sure I am not bending the test to a faulty implementation then. >> >> >> Cheers >> Karm > >> Oh...I see. So the fact that the body is returned even though there was a failure is a bug, not a feature/desirable chage? I will browse the Jira and check the spec to make sure I am not bending the test to a faulty implementation then. > > Even if you discover a discrepancy, this would need to get fixed in [JDK head](https://github.com/openjdk/jdk) first and then backported. Please keep that in mind. > @jerboaa I realized the patch is already backported to JDK 19 and JDK 17. So it's just JDK 11 I'd like to backport JDK-8245245 to. And IIUC, the change in [openjdk/jdk#11486](https://github.com/openjdk/jdk/pull/11486) needed for JDK 11 will need backporting to JDK 19, JDK 17 too. Yes. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From andrew at openjdk.org Tue Dec 6 03:11:37 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 6 Dec 2022 03:11:37 GMT Subject: [jdk11u-dev] RFR: 8293834: Update CLDR data following tzdata 2022c update Message-ID: This patch updates the CLDR data following the tzdata bump in JDK-8292579. This will be handled in trunk by a larger update to CLDRv42. It differs from the 17u version slightly in the bug ID line in the test, as 11u lacks JDK-8261279, but is otherwise clean and the updated test passes. ------------- Commit messages: - Backport e10231248fc100f9dfa08468ac897f60b843857f Changes: https://git.openjdk.org/jdk11u-dev/pull/1567/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1567&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293834 Stats: 20 lines in 2 files changed: 18 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1567.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1567/head:pull/1567 PR: https://git.openjdk.org/jdk11u-dev/pull/1567 From sgehwolf at openjdk.org Tue Dec 6 09:48:11 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 6 Dec 2022 09:48:11 GMT Subject: [jdk11u-dev] RFR: 8293834: Update CLDR data following tzdata 2022c update In-Reply-To: References: Message-ID: On Tue, 6 Dec 2022 03:03:04 GMT, Andrew John Hughes wrote: > This patch updates the CLDR data following the tzdata bump in JDK-8292579. > > This will be handled in trunk by a larger update to CLDRv42. > > It differs from the 17u version slightly in the bug ID line in the test, as 11u lacks JDK-8261279, but is otherwise clean and the updated test passes. Looks fine to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1567 From sgehwolf at openjdk.org Tue Dec 6 10:08:49 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 6 Dec 2022 10:08:49 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 01:52:47 GMT, Michal Karm Babacek wrote: > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. FWIW, since https://bugs.openjdk.org/browse/JDK-8240666 is not in 11u, it would be acceptable to alter the test to account for this. A comment in the test could explain that. I don't think backporting JDK-8240666 would be appropriate (behaviour change) and it looks like getting the test change (account for the optional body) in JDK head might not be wanted. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From dfuchs at openjdk.org Tue Dec 6 13:51:03 2022 From: dfuchs at openjdk.org (Daniel Fuchs) Date: Tue, 6 Dec 2022 13:51:03 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 01:52:47 GMT, Michal Karm Babacek wrote: > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. It is important that the test checks the URI received by the server, and that's probably why the body was used here. The server writes the URI it receives in the response body. This provides an end-to-end check that what was received is what we expected to send. Note that the server doesn't actually supports WebSocket and that's why it always replies with 400. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From andrew at openjdk.org Tue Dec 6 16:45:32 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 6 Dec 2022 16:45:32 GMT Subject: [jdk11u-dev] RFR: 8293834: Update CLDR data following tzdata 2022c update In-Reply-To: References: Message-ID: On Tue, 6 Dec 2022 03:03:04 GMT, Andrew John Hughes wrote: > This patch updates the CLDR data following the tzdata bump in JDK-8292579. > > This will be handled in trunk by a larger update to CLDRv42. > > It differs from the 17u version slightly in the bug ID line in the test, as 11u lacks JDK-8261279, but is otherwise clean and the updated test passes. I see `jdk11u-fix-yes` ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1567 From andrew at openjdk.org Tue Dec 6 16:48:42 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 6 Dec 2022 16:48:42 GMT Subject: [jdk11u-dev] Integrated: 8293834: Update CLDR data following tzdata 2022c update In-Reply-To: References: Message-ID: On Tue, 6 Dec 2022 03:03:04 GMT, Andrew John Hughes wrote: > This patch updates the CLDR data following the tzdata bump in JDK-8292579. > > This will be handled in trunk by a larger update to CLDRv42. > > It differs from the 17u version slightly in the bug ID line in the test, as 11u lacks JDK-8261279, but is otherwise clean and the updated test passes. This pull request has now been integrated. Changeset: 87c8450c Author: Andrew John Hughes URL: https://git.openjdk.org/jdk11u-dev/commit/87c8450c3e776f6b5ad6c01c5cdc5a157c9e84cb Stats: 20 lines in 2 files changed: 18 ins; 0 del; 2 mod 8293834: Update CLDR data following tzdata 2022c update Reviewed-by: sgehwolf Backport-of: e10231248fc100f9dfa08468ac897f60b843857f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1567 From duke at openjdk.org Tue Dec 6 18:19:25 2022 From: duke at openjdk.org (Dan Lutker) Date: Tue, 6 Dec 2022 18:19:25 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v27] In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 15:28:26 GMT, George Adams wrote: >> The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. >> >> This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. >> >> @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > remove make/autoconf/util_windows.m4 This seems to be causing a problem for us at Amazon. I am trying to figure out how but we are loosing a "" in the middle of a path. It should be `C:\tools\cygwin\tmp\fixpath.3ZobaJ\atfile` and not `C:\toolscygwin\tmp\fixpath.3ZobaJ\atfile` Compiling 8 files for BUILD_TOOLS_LANGTOOLS error: file not found: C:\toolscygwin\tmp\fixpath.3ZobaJ\atfile make[3]: *** [ToolsLangtools.gmk:40: /cygdrive/c/wsjdk/corretto11src/installers/windows/zip/corretto-build/buildroot/build/windows-x86_64-normal-server-release/buildtools/langtools_tools_classes/_the.BUILD_TOOLS_LANGTOOLS_batch] Error 3 make[2]: *** [make/Main.gmk:73: buildtools-langtools] Error 2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From clanger at openjdk.org Tue Dec 6 19:54:12 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 6 Dec 2022 19:54:12 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v27] In-Reply-To: References: Message-ID: On Tue, 6 Dec 2022 18:16:54 GMT, Dan Lutker wrote: > This seems to be causing a problem for us at Amazon. I am trying to figure out how but we are loosing a "" in the middle of a path. It should be `C:\tools\cygwin\tmp\fixpath.3ZobaJ\atfile` and not `C:\toolscygwin\tmp\fixpath.3ZobaJ\atfile` > > ``` > Compiling 8 files for BUILD_TOOLS_LANGTOOLS > error: file not found: C:\toolscygwin\tmp\fixpath.3ZobaJ\atfile > make[3]: *** [ToolsLangtools.gmk:40: /cygdrive/c/wsjdk/corretto11src/installers/windows/zip/corretto-build/buildroot/build/windows-x86_64-normal-server-release/buildtools/langtools_tools_classes/_the.BUILD_TOOLS_LANGTOOLS_batch] Error 3 > make[2]: *** [make/Main.gmk:73: buildtools-langtools] Error 2 > ``` Thanks for reporting. Would be good if you could find some more details here. Which make targets do you call? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Tue Dec 6 20:50:29 2022 From: duke at openjdk.org (Dan Lutker) Date: Tue, 6 Dec 2022 20:50:29 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v27] In-Reply-To: References: Message-ID: On Tue, 6 Dec 2022 19:51:43 GMT, Christoph Langer wrote: > Thanks for reporting. Would be good if you could find some more details here. Which make targets do you call? Just figured out the problem and will have the PR shortly to backport [JDK-8258005](https://bugs.openjdk.org/browse/JDK-8258005) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Tue Dec 6 21:03:38 2022 From: duke at openjdk.org (Dan Lutker) Date: Tue, 6 Dec 2022 21:03:38 GMT Subject: [jdk11u-dev] RFR: 8258005: JDK build fails with incorrect fixpath script Message-ID: Fixing issue caused by backport of [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) If the path contains multiple parts then only the 1st `` is escaped which causes a build break. ------------- Commit messages: - Backport 0890620c94cd9d0aca6289e85b3980b64cd122ed Changes: https://git.openjdk.org/jdk11u-dev/pull/1568/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1568&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8258005 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1568.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1568/head:pull/1568 PR: https://git.openjdk.org/jdk11u-dev/pull/1568 From gdams at openjdk.org Tue Dec 6 21:24:23 2022 From: gdams at openjdk.org (George Adams) Date: Tue, 6 Dec 2022 21:24:23 GMT Subject: [jdk11u-dev] RFR: 8258005: JDK build fails with incorrect fixpath script In-Reply-To: References: Message-ID: On Tue, 6 Dec 2022 20:39:47 GMT, Dan Lutker wrote: > Fixing issue caused by backport of [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) in https://github.com/openjdk/jdk11u-dev/pull/1278 > > If the path contains multiple parts then only the 1st `` is escaped which causes a build break. Sorry for missing this, thanks for raising the backport ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1568 From clanger at openjdk.org Tue Dec 6 21:29:13 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 6 Dec 2022 21:29:13 GMT Subject: [jdk11u-dev] RFR: 8258005: JDK build fails with incorrect fixpath script In-Reply-To: References: Message-ID: <5flytZnNzKdQ0Hh8VPs42BMY4VVmGHRzq8ABQKc76m0=.0f1a42af-59d4-4bec-99d2-d7225b99229a@github.com> On Tue, 6 Dec 2022 20:39:47 GMT, Dan Lutker wrote: > Fixing issue caused by backport of [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) in https://github.com/openjdk/jdk11u-dev/pull/1278 > > If the path contains multiple parts then only the 1st `` is escaped which causes a build break. @lutkerd Thanks for finding and fixing this. Please add the jdk11u-fix-request label and I'll approve it. You can go ahead and integrate this immediately because dev close will happen any time soon. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1568 From duke at openjdk.org Tue Dec 6 21:32:30 2022 From: duke at openjdk.org (Dan Lutker) Date: Tue, 6 Dec 2022 21:32:30 GMT Subject: [jdk11u-dev] RFR: 8258005: JDK build fails with incorrect fixpath script In-Reply-To: <5flytZnNzKdQ0Hh8VPs42BMY4VVmGHRzq8ABQKc76m0=.0f1a42af-59d4-4bec-99d2-d7225b99229a@github.com> References: <5flytZnNzKdQ0Hh8VPs42BMY4VVmGHRzq8ABQKc76m0=.0f1a42af-59d4-4bec-99d2-d7225b99229a@github.com> Message-ID: On Tue, 6 Dec 2022 21:26:38 GMT, Christoph Langer wrote: > @lutkerd Thanks for finding and fixing this. Please add the jdk11u-fix-request label and I'll approve it. You can go ahead and integrate this immediately because dev close will happen any time soon. Done! Thanks for the quick turnaround. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1568 From duke at openjdk.org Tue Dec 6 21:43:57 2022 From: duke at openjdk.org (Dan Lutker) Date: Tue, 6 Dec 2022 21:43:57 GMT Subject: [jdk11u-dev] Integrated: 8258005: JDK build fails with incorrect fixpath script In-Reply-To: References: Message-ID: On Tue, 6 Dec 2022 20:39:47 GMT, Dan Lutker wrote: > Fixing issue caused by backport of [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) in https://github.com/openjdk/jdk11u-dev/pull/1278 > > If the path contains multiple parts then only the 1st `` is escaped which causes a build break. This pull request has now been integrated. Changeset: 07399029 Author: Dan Lutker Committer: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/07399029d7fc80a5104791c4abbb2d36be7e620c Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8258005: JDK build fails with incorrect fixpath script Backport-of: 0890620c94cd9d0aca6289e85b3980b64cd122ed ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1568 From andrew at openjdk.org Wed Dec 7 02:30:25 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 7 Dec 2022 02:30:25 GMT Subject: [jdk19u] RFR: 8297804: (tz) Update Timezone Data to 2022g Message-ID: Clean backport of the latest tzdata update. This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass. Thanks! ------------- Commit messages: - Backport ce896731d38866c2bf99cd49525062e150d94160 Changes: https://git.openjdk.org/jdk19u/pull/103/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297804 Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod Patch: https://git.openjdk.org/jdk19u/pull/103.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/103/head:pull/103 PR: https://git.openjdk.org/jdk19u/pull/103 From goetz at openjdk.org Wed Dec 7 08:51:28 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 7 Dec 2022 08:51:28 GMT Subject: [jdk17u-dev] Integrated: 8297259: Bump update version for OpenJDK: jdk-17.0.7 In-Reply-To: References: Message-ID: <2P8jk0sMrJ_m_rQzsQ9Ms-Da795DSeJQ2-e5VJGXJ1w=.dee42358-5653-4103-89c1-65deec505550@github.com> On Sun, 20 Nov 2022 20:17:35 GMT, Goetz Lindenmaier wrote: > The necessary version bump. To be pushed after tag jdk-17.0.7+0. This pull request has now been integrated. Changeset: 26b03b5d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/26b03b5dbe2edbaf3ce8d49b18dd0b28c5cbac5b Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8297259: Bump update version for OpenJDK: jdk-17.0.7 Reviewed-by: shade ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/904 From goetz at openjdk.org Wed Dec 7 09:19:13 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 7 Dec 2022 09:19:13 GMT Subject: [jdk11u-dev] Integrated: 8297257: Bump update version for OpenJDK: jdk-11.0.19 In-Reply-To: References: Message-ID: On Sun, 20 Nov 2022 20:11:44 GMT, Goetz Lindenmaier wrote: > The necessary version bump. To be pushed after tag jdk-11.0.19+0. This pull request has now been integrated. Changeset: 89f9f91d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/89f9f91d3a69b473a61d98fab859b751dd6755c2 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8297257: Bump update version for OpenJDK: jdk-11.0.19 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1536 From clanger at openjdk.org Wed Dec 7 10:29:12 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Dec 2022 10:29:12 GMT Subject: [jdk11u] RFR: 8258005: JDK build fails with incorrect fixpath script Message-ID: <8FgOKApfL3oEXNSiaPHryki2QxZCHnCKsktHyjkRQxM=.ee447ee4-c63e-404c-ab34-ac9f4a52c97b@github.com> Hi all, This pull request contains a backport of [JDK-8258005](https://bugs.openjdk.org/browse/JDK-8258005), commit [07399029](https://github.com/openjdk/jdk11u-dev/commit/07399029d7fc80a5104791c4abbb2d36be7e620c) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. The commit being backported was authored by Dan Lutker on 6 Dec 2022 and had no reviewers. Thanks! ------------- Commit messages: - Backport 07399029d7fc80a5104791c4abbb2d36be7e620c Changes: https://git.openjdk.org/jdk11u/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=62&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8258005 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u/pull/62.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/62/head:pull/62 PR: https://git.openjdk.org/jdk11u/pull/62 From phh at openjdk.org Wed Dec 7 15:22:39 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 7 Dec 2022 15:22:39 GMT Subject: [jdk11u] RFR: 8258005: JDK build fails with incorrect fixpath script In-Reply-To: <8FgOKApfL3oEXNSiaPHryki2QxZCHnCKsktHyjkRQxM=.ee447ee4-c63e-404c-ab34-ac9f4a52c97b@github.com> References: <8FgOKApfL3oEXNSiaPHryki2QxZCHnCKsktHyjkRQxM=.ee447ee4-c63e-404c-ab34-ac9f4a52c97b@github.com> Message-ID: On Wed, 7 Dec 2022 10:21:47 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8258005](https://bugs.openjdk.org/browse/JDK-8258005), commit [07399029](https://github.com/openjdk/jdk11u-dev/commit/07399029d7fc80a5104791c4abbb2d36be7e620c) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Dan Lutker on 6 Dec 2022 and had no reviewers. > > Thanks! This is a clean backport, but if a review is needed, lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u/pull/62 From phh at openjdk.org Wed Dec 7 16:22:19 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 7 Dec 2022 16:22:19 GMT Subject: [jdk17u] RFR: 8294310: compare.sh fails on macos after JDK-8293550 Message-ID: Clean backport of required follow-on to 17u backport of [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). ------------- Commit messages: - Backport b9eeec2b6b8f97d2ba33462b27d091f918067f78 Changes: https://git.openjdk.org/jdk17u/pull/359/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=359&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294310 Stats: 14 lines in 3 files changed: 10 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u/pull/359.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/359/head:pull/359 PR: https://git.openjdk.org/jdk17u/pull/359 From phh at openjdk.org Wed Dec 7 16:25:49 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 7 Dec 2022 16:25:49 GMT Subject: [jdk17u] RFR: 8293965: Code signing warnings after JDK-8293550 Message-ID: Clean backport follow-on to [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) 17u backport. ------------- Commit messages: - Backport f91762f56ea7fb27b6fa54d07d3b3b0650bab0bc Changes: https://git.openjdk.org/jdk17u/pull/360/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=360&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293965 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u/pull/360.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/360/head:pull/360 PR: https://git.openjdk.org/jdk17u/pull/360 From phh at openjdk.org Wed Dec 7 16:31:26 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 7 Dec 2022 16:31:26 GMT Subject: [jdk17u] RFR: 8294310: compare.sh fails on macos after JDK-8293550 In-Reply-To: References: Message-ID: On Wed, 7 Dec 2022 16:13:44 GMT, Paul Hohensee wrote: > Clean backport of required follow-on to 17u backport of [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). Neglected to enable workflows on this fork before creating this PR, but this PR is identical to https://github.com/openjdk/jdk17u-dev/pull/944, for which the pre-submit tests succeeded. ------------- PR: https://git.openjdk.org/jdk17u/pull/359 From phh at openjdk.org Wed Dec 7 16:32:29 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 7 Dec 2022 16:32:29 GMT Subject: [jdk17u] RFR: 8293965: Code signing warnings after JDK-8293550 In-Reply-To: References: Message-ID: <6BVEF3DRj33ljFJxe7sFBPrlWhL-lmHaQAhYgZ0vTwg=.077cb566-4383-4f4c-b756-5a9c2ed4bca5@github.com> On Wed, 7 Dec 2022 16:15:37 GMT, Paul Hohensee wrote: > Clean backport follow-on to [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) 17u backport. Neglected to enable workflows on this fork before creating this PR, but this PR is identical to https://github.com/openjdk/jdk17u-dev/946, for which the pre-submit tests succeeded. ------------- PR: https://git.openjdk.org/jdk17u/pull/360 From btaylor at openjdk.org Wed Dec 7 18:48:46 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 7 Dec 2022 18:48:46 GMT Subject: [jdk17u-dev] Integrated: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 20:31:49 GMT, Ben Taylor wrote: > Backporting to 17 for improved performance. > Backport is clean. This pull request has now been integrated. Changeset: a2fb9ae9 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/a2fb9ae93f65260d69f110f8bb1c2cd348356dbf Stats: 25 lines in 2 files changed: 9 ins; 0 del; 16 mod 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response Backport-of: 392ac7055d4697c56fa85ac5572f5bc4dc431f1d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/918 From yan at openjdk.org Thu Dec 8 09:58:02 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 8 Dec 2022 09:58:02 GMT Subject: [jdk15u-dev] RFR: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out Message-ID: <_PM9X-go-Bx1vt862OhfTqGmbaeCVbNxCbFIzyB1X-c=.3ae511dd-69ed-433e-b4d4-9b6db23fc820@github.com> Backporting this useful test fix as such and as a prerequisite to the related changes ------------- Commit messages: - Backport becee6435bc38c4e3fe5b197c985e68e97fc8e0d Changes: https://git.openjdk.org/jdk15u-dev/pull/312/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=312&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261279 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/312.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/312/head:pull/312 PR: https://git.openjdk.org/jdk15u-dev/pull/312 From yan at openjdk.org Thu Dec 8 10:04:18 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 8 Dec 2022 10:04:18 GMT Subject: [jdk13u-dev] RFR: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out Message-ID: Backporting this useful test fix as such and as a prerequisite to the related changes ------------- Commit messages: - Backport becee6435bc38c4e3fe5b197c985e68e97fc8e0d Changes: https://git.openjdk.org/jdk13u-dev/pull/439/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=439&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261279 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/439.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/439/head:pull/439 PR: https://git.openjdk.org/jdk13u-dev/pull/439 From yan at openjdk.org Thu Dec 8 10:04:35 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 8 Dec 2022 10:04:35 GMT Subject: [jdk15u-dev] Integrated: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out In-Reply-To: <_PM9X-go-Bx1vt862OhfTqGmbaeCVbNxCbFIzyB1X-c=.3ae511dd-69ed-433e-b4d4-9b6db23fc820@github.com> References: <_PM9X-go-Bx1vt862OhfTqGmbaeCVbNxCbFIzyB1X-c=.3ae511dd-69ed-433e-b4d4-9b6db23fc820@github.com> Message-ID: On Thu, 8 Dec 2022 09:49:12 GMT, Yuri Nesterenko wrote: > Backporting this useful test fix as such and as a prerequisite to the related changes This pull request has now been integrated. Changeset: 1f5bae30 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/1f5bae30bc4f9ff90561af0d465dfcf6508f82d6 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out Backport-of: becee6435bc38c4e3fe5b197c985e68e97fc8e0d ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/312 From yan at openjdk.org Thu Dec 8 10:08:11 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 8 Dec 2022 10:08:11 GMT Subject: [jdk13u-dev] Integrated: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 09:54:52 GMT, Yuri Nesterenko wrote: > Backporting this useful test fix as such and as a prerequisite to the related changes This pull request has now been integrated. Changeset: 29d3fa7e Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/29d3fa7ee5f896577114bf9ee8fe5ac87eeb3686 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out Backport-of: becee6435bc38c4e3fe5b197c985e68e97fc8e0d ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/439 From goetz at openjdk.org Thu Dec 8 13:08:27 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 8 Dec 2022 13:08:27 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 20:22:38 GMT, Ioi Lam wrote: >> The description of this PR is not clear. Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? >> >> Please avoid mentioning JDK-8297543, as it's already closed as a duplicate of JDK-8275731. > >> Hi @iklam >> >> Thanks for your kind response! >> >> > The description of this PR is not clear. >> >> I updated the description. Please review it again. >> >> > Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport? >> >> Yes. >> >> Thanks, Leslie Zhai > > I think the wording of this PR should be changed to something like this: > > * Backporting JDK-8267189 as a prerequisite for JDK-8275731 (CDS archived enums objects are recreated at runtime) > > You don't need to mention the other issues here. Instead, those issue should be listed in JDK-8275731: > > * Add label jdk17u-fix-reques to JDK-8275731 > * Add a comment in JDK-8275731, with something like > * In order to backport this issue to jdk 17u, the following issues must be backported first, in the order of > 1. JDK-8267189: Remove duplicated unregistered classes from dynamic archive > 2. JDK-XXXXXXX: xxxxxx > 3. JDK-XXXXXXX: xxxxxx > 4. JDK-XXXXXXX: xxxxxx > > You should reach an agreement with the jdk17u maintainers first. I would suggest sending mail to the jdk-updates-dev mailing list. See https://mail.openjdk.org/pipermail/jdk-updates-dev/ > > You listed JDK-8270489 (Support archived heap objects in EpsilonGC) as a prerequisite, but that's a very large change and seems unrelated to the enum problem. More discussion is needed on jdk-updates-dev to decide which set of issues should be backported. @iklam Hi Ioi, thanks for advising Leslie! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From goetz at openjdk.org Thu Dec 8 13:17:50 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 8 Dec 2022 13:17:50 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Tue, 29 Nov 2022 01:57:02 GMT, Leslie Zhai wrote: > Hi, > > Backporting JDK-8267189 as a prerequisite for JDK-8275731 (CDS archived enums objects are recreated at runtime) > > The patch applies clean except manually edit the source file: > > * src/hotspot/share/classfile/systemDictionaryShared.hpp > Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context. > > Tested jtreg tier1~3, no regression. > > Thanks, > Leslie Zhai @xiangzha Hi Leslie, please have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix You really should not integrate before you have a fix-yes label! Also, please edit the comment in the JBS issue to contain the required information: * Why do you backport the change? * What is the risk of doing so? E.g., will existing archives still work? * How you tested this * Only the fact whether it is clean or required edits is of interest in the JBS issue. How you adapted the change goes into the PR as it is addressed at the reivewers. Fix this for all your backports please. Best, Goetz. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From goetz at openjdk.org Thu Dec 8 15:27:26 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 8 Dec 2022 15:27:26 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v3] In-Reply-To: References: Message-ID: On Tue, 29 Nov 2022 16:32:50 GMT, Jatin Bhateja wrote: >> Clean backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322), due to merge conflicts original patch could not be applied directly by bot. >> >> Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. >> >> Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. >> >> Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) > > Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision: > > Backport 38a81913d33c856d64b7c26f934026815a482e43 Hi @jatin-bhateja, 1. The change is not clean if it requires merges. Using the clean command is not allowed in this case. Obviously you even introduced two formatting errors when resolving (which might make follow up backports unclean). 2. you should not type integrate if you do not have a fix-yes label on the JBS bug. Please follow the instructions in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix for your next backport. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/917 From phh at openjdk.org Thu Dec 8 15:38:39 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 8 Dec 2022 15:38:39 GMT Subject: [jdk17u-dev] Integrated: 8294310: compare.sh fails on macos after JDK-8293550 In-Reply-To: References: Message-ID: On Fri, 2 Dec 2022 16:22:48 GMT, Paul Hohensee wrote: > Clean backport of required follow-on to 17u backport of [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). This pull request has now been integrated. Changeset: cdaf5e3a Author: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/cdaf5e3abfdab6e8139a0e92c4db34a832c227e3 Stats: 14 lines in 3 files changed: 10 ins; 0 del; 4 mod 8294310: compare.sh fails on macos after JDK-8293550 Backport-of: b9eeec2b6b8f97d2ba33462b27d091f918067f78 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/944 From phh at openjdk.org Thu Dec 8 15:42:33 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 8 Dec 2022 15:42:33 GMT Subject: [jdk17u-dev] Integrated: 8293965: Code signing warnings after JDK-8293550 In-Reply-To: References: Message-ID: <7pDBT8N06ZPa9u9n1xvqceDUs_sn2oYZRSWbLycx8vU=.f9f8434b-8663-4e14-b54c-2e476ee4db4c@github.com> On Fri, 2 Dec 2022 17:11:33 GMT, Paul Hohensee wrote: > Clean backport follow-on to [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) 17u backport. This pull request has now been integrated. Changeset: 0f43f8e4 Author: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/0f43f8e4090abbc041b926c248c37c52da78f8fa Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8293965: Code signing warnings after JDK-8293550 Backport-of: f91762f56ea7fb27b6fa54d07d3b3b0650bab0bc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/946 From phh at openjdk.org Thu Dec 8 15:46:16 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 8 Dec 2022 15:46:16 GMT Subject: [jdk17u] Integrated: 8294310: compare.sh fails on macos after JDK-8293550 In-Reply-To: References: Message-ID: On Wed, 7 Dec 2022 16:13:44 GMT, Paul Hohensee wrote: > Clean backport of required follow-on to 17u backport of [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). This pull request has now been integrated. Changeset: d84c61c4 Author: Paul Hohensee URL: https://git.openjdk.org/jdk17u/commit/d84c61c4288da819901f49406bfc9c0890b280e6 Stats: 14 lines in 3 files changed: 10 ins; 0 del; 4 mod 8294310: compare.sh fails on macos after JDK-8293550 Backport-of: b9eeec2b6b8f97d2ba33462b27d091f918067f78 ------------- PR: https://git.openjdk.org/jdk17u/pull/359 From phh at openjdk.org Thu Dec 8 15:51:55 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 8 Dec 2022 15:51:55 GMT Subject: [jdk17u] Integrated: 8293965: Code signing warnings after JDK-8293550 In-Reply-To: References: Message-ID: On Wed, 7 Dec 2022 16:15:37 GMT, Paul Hohensee wrote: > Clean backport follow-on to [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) 17u backport. This pull request has now been integrated. Changeset: d2fdea71 Author: Paul Hohensee URL: https://git.openjdk.org/jdk17u/commit/d2fdea71f7e2d7862ff7742d7997a229b794c02d Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8293965: Code signing warnings after JDK-8293550 Backport-of: f91762f56ea7fb27b6fa54d07d3b3b0650bab0bc ------------- PR: https://git.openjdk.org/jdk17u/pull/360 From goetz at openjdk.org Thu Dec 8 16:34:14 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 8 Dec 2022 16:34:14 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 23:40:29 GMT, Tyler Steele wrote: > See comments in https://github.com/openjdk/jdk11u-dev/pull/1530. > > This backport requires a review. It is not marked clean because it does not change the `@LastModified` dates in several places. In all cases, these dates were newer in the current version of jdk11u-dev. In a similar vein, this change adds to a newer list of bug ids in one place. Hi @mlbridge, @phohensee, this, together with the two predecessors, is a quite big change for 11. While I see why this change (JDK-8223291) is useful for 11, I doubt so for the two predecessors. Unfortunately the original version of PR 1521 seems to be lost, so I can not assess how much adaptions were needed to bring only that one change to 11. For the two others, I am not sure they are side-effect free for all potential code running on 11. Best regards, Goetz. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1532 From duke at openjdk.org Thu Dec 8 20:35:06 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 8 Dec 2022 20:35:06 GMT Subject: [jdk11u-dev] Withdrawn: 8256108: Create implementation for NSAccessibilityElement protocol peer In-Reply-To: References: Message-ID: <7d3JwatNaXF7pDvepEBSwpXFXlNJjlcuVsVc6iq8wlM=.7aa8c286-bd4a-4ed0-a471-272a0fb55e52@github.com> On Fri, 2 Dec 2022 20:26:34 GMT, Autumn Capasso wrote: > Backport [JDK-8256108](https://bugs.openjdk.org/browse/JDK-8256108). This backport wasn't completely clean there was a merge conflict in the java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m. I cleaned it up the file. This backport is part of a series of 28 backports [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1566 From duke at openjdk.org Thu Dec 8 20:43:53 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 8 Dec 2022 20:43:53 GMT Subject: [jdk11u-dev] RFR: 8256108: Create implementation for NSAccessibilityElement protocol peer Message-ID: [JDK-8256108](https://bugs.openjdk.org/browse/JDK-8256108) part of 28. ------------- Commit messages: - Update JavaComponentAccessibility.m - 8256108: Create implementation for NSAccessibilityElement protocol peer Changes: https://git.openjdk.org/jdk11u-dev/pull/1565/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1565&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256108 Stats: 46 lines in 1 file changed: 44 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1565.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1565/head:pull/1565 PR: https://git.openjdk.org/jdk11u-dev/pull/1565 From phh at openjdk.org Thu Dec 8 21:06:07 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 8 Dec 2022 21:06:07 GMT Subject: [jdk11u-dev] RFR: 8256108: Create implementation for NSAccessibilityElement protocol peer In-Reply-To: References: Message-ID: On Fri, 2 Dec 2022 19:38:45 GMT, Autumn Capasso wrote: > [JDK-8256108](https://bugs.openjdk.org/browse/JDK-8256108) part of 28. Please remove the copyright line update, it's already at 2021 so shouldn't go back to 2020. Otherwise, lgtm. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1565 From duke at openjdk.org Thu Dec 8 21:06:08 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 8 Dec 2022 21:06:08 GMT Subject: [jdk11u-dev] RFR: 8256108: Create implementation for NSAccessibilityElement protocol peer In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 20:59:58 GMT, Paul Hohensee wrote: > Please remove the copyright line update, it's already at 2021 so shouldn't go back to 2020. Otherwise, lgtm. Done. Thank you so much. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1565 From duke at openjdk.org Thu Dec 8 21:14:07 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 8 Dec 2022 21:14:07 GMT Subject: [jdk11u-dev] Withdrawn: 8256108: Create implementation for NSAccessibilityElement protocol peer In-Reply-To: References: Message-ID: <0rm1zv-zJyOwJTPxlOLEBcptfl96lh6d3kNJKqougDw=.5f22607b-8500-4195-8edb-1fd0c452ab93@github.com> On Fri, 2 Dec 2022 19:38:45 GMT, Autumn Capasso wrote: > [JDK-8256108](https://bugs.openjdk.org/browse/JDK-8256108) part of 28. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1565 From duke at openjdk.org Thu Dec 8 21:31:28 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 8 Dec 2022 21:31:28 GMT Subject: [jdk11u-dev] RFR: 8256108: Create implementation for NSAccessibilityElement protocol peer Message-ID: [JDK-8256108](https://bugs.openjdk.org/browse/JDK-8256108) Clean part of 28. ------------- Commit messages: - Backport 4c095252a540ea799d6014fb42e6ebedb3b24196 Changes: https://git.openjdk.org/jdk11u-dev/pull/1571/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1571&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256108 Stats: 44 lines in 1 file changed: 44 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1571.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1571/head:pull/1571 PR: https://git.openjdk.org/jdk11u-dev/pull/1571 From duke at openjdk.org Thu Dec 8 21:55:14 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 8 Dec 2022 21:55:14 GMT Subject: [jdk11u-dev] RFR: 8256126: Create implementation for NSAccessibilityImage protocol peer Message-ID: clean backport [JDK-8256126](https://bugs.openjdk.org/browse/JDK-8256126) 3 of 28. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1571 Commit messages: - backport bbb93ca3c80968d4f167bb4cd9e5d3e60e4a6a5b - Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 one of 28. Clean. Changes: https://git.openjdk.org/jdk11u-dev/pull/1572/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1572&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256126 Stats: 86 lines in 4 files changed: 83 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1572.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1572/head:pull/1572 PR: https://git.openjdk.org/jdk11u-dev/pull/1572 From duke at openjdk.org Thu Dec 8 22:10:32 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 8 Dec 2022 22:10:32 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol Message-ID: Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) Had to fix merge request in java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m and update the initWithCapacity to match the roles which was 4. 4 out of 28 backpoorts ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1572 Commit messages: - Backport 5dc5d9401e7a176da53a14293fb59e97b644b31a - Backport 4c095252a540ea799d6014fb42e6ebedb3b24196 Changes: https://git.openjdk.org/jdk11u-dev/pull/1573/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1573&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256110 Stats: 178 lines in 6 files changed: 161 ins; 15 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1573.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1573/head:pull/1573 PR: https://git.openjdk.org/jdk11u-dev/pull/1573 From lzhai at openjdk.org Fri Dec 9 00:56:09 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Fri, 9 Dec 2022 00:56:09 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 13:12:41 GMT, Goetz Lindenmaier wrote: >> Hi, >> >> Backporting JDK-8267189 as a prerequisite for JDK-8275731 (CDS archived enums objects are recreated at runtime) >> >> The patch applies clean except manually edit the source file: >> >> * src/hotspot/share/classfile/systemDictionaryShared.hpp >> Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context. >> >> Tested jtreg tier1~3, no regression. >> >> Thanks, >> Leslie Zhai > > @xiangzha Hi Leslie, > > please have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix > > You really should not integrate before you have a fix-yes label! > > Also, please edit the comment in the JBS issue to contain the required information: > * Why do you backport the change? > * What is the risk of doing so? E.g., will existing archives still work? > * How you tested this > * Only the fact whether it is clean or required edits is of interest in the JBS issue. How you adapted the change goes into the PR as it is addressed at the reivewers. > > Fix this for all your backports please. > Best, Goetz. Hi @GoeLin Thanks for your teaching! > You really should not integrate before you have a fix-yes label! I see. > Also, please edit the comment in the JBS issue to contain the required information: Updated my comment in the JDK-8267189, please review it. Thanks, Leslie Zhai ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/939 From duke at openjdk.org Fri Dec 9 05:06:14 2022 From: duke at openjdk.org (duke) Date: Fri, 9 Dec 2022 05:06:14 GMT Subject: [jdk17u-dev] Withdrawn: 8280481: Duplicated stubs to interpreter for static calls In-Reply-To: <6ar1Z8f5PQBDn3kP8Wyt3IcUaIDPFRt055_t-qv2iVg=.ff7f2212-02d1-432c-a8f9-e71c941084a1@github.com> References: <6ar1Z8f5PQBDn3kP8Wyt3IcUaIDPFRt055_t-qv2iVg=.ff7f2212-02d1-432c-a8f9-e71c941084a1@github.com> Message-ID: On Tue, 11 Oct 2022 18:53:21 GMT, Evgeny Astigeevich wrote: > This is a backport of shared stubs to the interpreter for statically bound Java methods calls. > Stubs to the interpreter are used when an invoked Java method is not compiled. > > The full description of the changes and improvements in saving nmethod memory can be found in https://github.com/openjdk/jdk/pull/8816 > > The backport contains implementations for the aarch64, x86 and x86_64 backends. Other backends are guarded with `Unimplemented()` calls and `constexpr supports_shared_stubs()` returning `false`. > > A risk is between low and moderate. Performance regressions are unlikely because stubs are used to go to the interpreter which will be the main contributor to the execution time. Crashes are unlikely because we either successfully generate a shared stub during compilation or fail. If generation fails, there will be no compiled method with missing stubs. > > Tested with fastdebug and release builds on aarch64, x86 and x86_64: > - `gtest`: Passed > - `tier1`, `tier2`: Passed > > The backport can be considered clean. `git backport` conflicts were caused by changes positioning issues. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/780 From yan at openjdk.org Fri Dec 9 07:20:37 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 9 Dec 2022 07:20:37 GMT Subject: [jdk13u-dev] RFR: 8287076: Document.normalizeDocument() produces different results Message-ID: backporting for parity with LTS releases. Clean backport with only copyright difference. jaxp and jdk/java/xml tests run OK. ------------- Commit messages: - Backport 1f9521e6cb2f701f8712b4ec941ff1dbb45dad4e Changes: https://git.openjdk.org/jdk13u-dev/pull/440/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=440&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287076 Stats: 72 lines in 4 files changed: 52 ins; 3 del; 17 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/440.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/440/head:pull/440 PR: https://git.openjdk.org/jdk13u-dev/pull/440 From yan at openjdk.org Fri Dec 9 07:35:13 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 9 Dec 2022 07:35:13 GMT Subject: [jdk15u-dev] RFR: 8287076: Document.normalizeDocument() produces different results Message-ID: backporting for parity with LTS releases. Clean backport with only copyright difference. jaxp and jdk/java/xml tests run OK. ------------- Commit messages: - Backport 1f9521e6cb2f701f8712b4ec941ff1dbb45dad4e Changes: https://git.openjdk.org/jdk15u-dev/pull/313/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=313&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287076 Stats: 72 lines in 4 files changed: 52 ins; 3 del; 17 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/313.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/313/head:pull/313 PR: https://git.openjdk.org/jdk15u-dev/pull/313 From yan at openjdk.org Fri Dec 9 07:56:05 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 9 Dec 2022 07:56:05 GMT Subject: [jdk13u-dev] Integrated: 8287076: Document.normalizeDocument() produces different results In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 07:12:36 GMT, Yuri Nesterenko wrote: > backporting for parity with LTS releases. > Clean backport with only copyright difference. jaxp and jdk/java/xml tests run OK. This pull request has now been integrated. Changeset: 098f0ea6 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/098f0ea6cc9891331e37d0b17b8781ff3e32c4ca Stats: 72 lines in 4 files changed: 52 ins; 3 del; 17 mod 8287076: Document.normalizeDocument() produces different results Backport-of: 1f9521e6cb2f701f8712b4ec941ff1dbb45dad4e ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/440 From yan at openjdk.org Fri Dec 9 08:19:01 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 9 Dec 2022 08:19:01 GMT Subject: [jdk15u-dev] Integrated: 8287076: Document.normalizeDocument() produces different results In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 07:28:01 GMT, Yuri Nesterenko wrote: > backporting for parity with LTS releases. > Clean backport with only copyright difference. jaxp and jdk/java/xml tests run OK. This pull request has now been integrated. Changeset: 057c00eb Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/057c00eb92d47bb5be8af9172d140b335f8e9cc4 Stats: 72 lines in 4 files changed: 52 ins; 3 del; 17 mod 8287076: Document.normalizeDocument() produces different results Backport-of: 1f9521e6cb2f701f8712b4ec941ff1dbb45dad4e ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/313 From rmarchenko at openjdk.org Fri Dec 9 09:40:31 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 9 Dec 2022 09:40:31 GMT Subject: [jdk11u-dev] RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled Message-ID: Clean backport ------------- Commit messages: - Backport a95ee5ada230a0177517efd3a417f319066169dd Changes: https://git.openjdk.org/jdk11u-dev/pull/1574/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1574&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8065422 Stats: 616 lines in 4 files changed: 613 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1574.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1574/head:pull/1574 PR: https://git.openjdk.org/jdk11u-dev/pull/1574 From rmarchenko at openjdk.org Fri Dec 9 09:57:23 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 9 Dec 2022 09:57:23 GMT Subject: [jdk11u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired Message-ID: <44c22Q6fNW511vUhu86NDv6nWwXSh0PqdaF2Qp-WuNU=.7c1c1a2c-f399-442d-8c33-7aac292f256e@github.com> clean backport ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1574 Commit messages: - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e Changes: https://git.openjdk.org/jdk11u-dev/pull/1575/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1575&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282398 Stats: 202 lines in 2 files changed: 30 ins; 2 del; 170 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1575.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1575/head:pull/1575 PR: https://git.openjdk.org/jdk11u-dev/pull/1575 From rmarchenko at openjdk.org Fri Dec 9 10:07:06 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 9 Dec 2022 10:07:06 GMT Subject: [jdk11u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template Message-ID: clean backport ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1575 Commit messages: - Backport 268fa693188b685de6289927ee5a1e99473a50f6 Changes: https://git.openjdk.org/jdk11u-dev/pull/1576/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1576&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282511 Stats: 218 lines in 2 files changed: 37 ins; 2 del; 179 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1576.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1576/head:pull/1576 PR: https://git.openjdk.org/jdk11u-dev/pull/1576 From yan at openjdk.org Fri Dec 9 13:03:33 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 9 Dec 2022 13:03:33 GMT Subject: [jdk15u-dev] RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Message-ID: backporting because the issue exists here as well. Clean backports, expected test behavior, tier1 OK. ------------- Commit messages: - Backport 87d1097d9be1ef804bfd4640a4254126242b1d8c Changes: https://git.openjdk.org/jdk15u-dev/pull/314/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=314&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297530 Stats: 141 lines in 2 files changed: 139 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/314.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/314/head:pull/314 PR: https://git.openjdk.org/jdk15u-dev/pull/314 From yan at openjdk.org Fri Dec 9 13:07:55 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 9 Dec 2022 13:07:55 GMT Subject: [jdk13u-dev] RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Message-ID: backporting because the issue exists here as well. Clean backport, expected test behavior, tier1 OK. ------------- Commit messages: - Backport 87d1097d9be1ef804bfd4640a4254126242b1d8c Changes: https://git.openjdk.org/jdk13u-dev/pull/441/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=441&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297530 Stats: 141 lines in 2 files changed: 139 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/441.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/441/head:pull/441 PR: https://git.openjdk.org/jdk13u-dev/pull/441 From yan at openjdk.org Fri Dec 9 13:08:54 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 9 Dec 2022 13:08:54 GMT Subject: [jdk15u-dev] Integrated: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation In-Reply-To: References: Message-ID: <44efYEfBAPYPk-VFCfKPoGMXo03I1O426DColqk8ybk=.dd51310c-c15b-4f39-a26c-eac0cbfc45fe@github.com> On Fri, 9 Dec 2022 12:55:25 GMT, Yuri Nesterenko wrote: > backporting because the issue exists here as well. > Clean backports, expected test behavior, tier1 OK. This pull request has now been integrated. Changeset: e9769825 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/e97698256a3f121e39824b118d06e4afea311091 Stats: 141 lines in 2 files changed: 139 ins; 0 del; 2 mod 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Backport-of: 87d1097d9be1ef804bfd4640a4254126242b1d8c ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/314 From mbaesken at openjdk.org Fri Dec 9 13:51:22 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Dec 2022 13:51:22 GMT Subject: [jdk11u-dev] RFR: 8287011: Improve container information Message-ID: Backport 8287011 ------------- Commit messages: - Backport e60939850e5328b9c0f2002ac5ed7744375bf18b Changes: https://git.openjdk.org/jdk11u-dev/pull/1577/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1577&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287011 Stats: 125 lines in 9 files changed: 104 ins; 13 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1577.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1577/head:pull/1577 PR: https://git.openjdk.org/jdk11u-dev/pull/1577 From clanger at openjdk.org Fri Dec 9 17:05:18 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 9 Dec 2022 17:05:18 GMT Subject: [jdk17u-dev] Integrated: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 06:28:49 GMT, Christoph Langer wrote: > I had to adapt the configure changes for the new option to the level of code in jdk17u. > > Furthermore, I regenerated docs/building.html which brings it in sync with building.md and removes a change that should not have been made when backporting [JDK-8280863](https://bugs.openjdk.org/browse/JDK-8280863). This pull request has now been integrated. Changeset: 57e6d92a Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/57e6d92a6ddbfe78cbf250a4502ce0911ee6f75a Stats: 58 lines in 3 files changed: 16 ins; 0 del; 42 mod 8296904: Improve handling of macos xcode toolchain Reviewed-by: mbaesken Backport-of: 470f3424fcce0e41b75cccdd5e3a56771cd07ff5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/931 From clanger at openjdk.org Fri Dec 9 17:41:50 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 9 Dec 2022 17:41:50 GMT Subject: [jdk11u] Integrated: 8258005: JDK build fails with incorrect fixpath script In-Reply-To: <8FgOKApfL3oEXNSiaPHryki2QxZCHnCKsktHyjkRQxM=.ee447ee4-c63e-404c-ab34-ac9f4a52c97b@github.com> References: <8FgOKApfL3oEXNSiaPHryki2QxZCHnCKsktHyjkRQxM=.ee447ee4-c63e-404c-ab34-ac9f4a52c97b@github.com> Message-ID: <4uJ0auyNLdvGBpNhdD7oJZt9k22NHkfD3ihR1Y06rrc=.90b2df0b-f2d0-4612-8c01-3ec2a5d0defd@github.com> On Wed, 7 Dec 2022 10:21:47 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8258005](https://bugs.openjdk.org/browse/JDK-8258005), commit [07399029](https://github.com/openjdk/jdk11u-dev/commit/07399029d7fc80a5104791c4abbb2d36be7e620c) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Dan Lutker on 6 Dec 2022 and had no reviewers. > > Thanks! This pull request has now been integrated. Changeset: 6400cdc7 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u/commit/6400cdc724f5ffeb03dec742494590a301cb3417 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8258005: JDK build fails with incorrect fixpath script Reviewed-by: phh Backport-of: 07399029d7fc80a5104791c4abbb2d36be7e620c ------------- PR: https://git.openjdk.org/jdk11u/pull/62 From duke at openjdk.org Fri Dec 9 18:37:24 2022 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 9 Dec 2022 18:37:24 GMT Subject: [jdk11u-dev] Withdrawn: 8256110: Create implementation for NSAccessibilityStepper protocol In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 22:03:07 GMT, Autumn Capasso wrote: > Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) Had to fix merge request in java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m and update the initWithCapacity to match the roles which was 4. 4 out of 28 backpoorts This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1573 From duke at openjdk.org Fri Dec 9 19:41:28 2022 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 9 Dec 2022 19:41:28 GMT Subject: [jdk11u-dev] Withdrawn: 8256108: Create implementation for NSAccessibilityElement protocol peer In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 21:24:52 GMT, Autumn Capasso wrote: > [JDK-8256108](https://bugs.openjdk.org/browse/JDK-8256108) Clean part of 28. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1571 From duke at openjdk.org Fri Dec 9 20:07:43 2022 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 9 Dec 2022 20:07:43 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol Message-ID: <3o-Vdx80LkVD8hMTdjQ96HaWR3ucfL9Y_1WdOqpK1hw=.45c793c7-b3f8-4400-9313-e99dff4d9b2a@github.com> Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) clean backport. One of 28 https://bugs.openjdk.org/browse/JDK-8152350 ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1572 Commit messages: - 8256110: Create implementation for NSAccessibilityStepper protocol Changes: https://git.openjdk.org/jdk11u-dev/pull/1578/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1578&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256110 Stats: 131 lines in 5 files changed: 114 ins; 15 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1578.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1578/head:pull/1578 PR: https://git.openjdk.org/jdk11u-dev/pull/1578 From duke at openjdk.org Fri Dec 9 20:09:13 2022 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 9 Dec 2022 20:09:13 GMT Subject: [jdk11u-dev] RFR: 8256111: Create implementation for NSAccessibilityStaticText protocol Message-ID: Backport [JDK-8256111](https://bugs.openjdk.org/browse/JDK-8256111) clean backport. One of 28 https://bugs.openjdk.org/browse/JDK-8152350 ------------- Commit messages: - Backport acbcde8c3c004efe3d95166f471ee77ac8415af7 - 8256110: Create implementation for NSAccessibilityStepper protocol - backport bbb93ca3c80968d4f167bb4cd9e5d3e60e4a6a5b - Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 one of 28. Clean. Changes: https://git.openjdk.org/jdk11u-dev/pull/1580/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1580&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256111 Stats: 519 lines in 12 files changed: 502 ins; 15 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1580.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1580/head:pull/1580 PR: https://git.openjdk.org/jdk11u-dev/pull/1580 From duke at openjdk.org Fri Dec 9 20:24:03 2022 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 9 Dec 2022 20:24:03 GMT Subject: [jdk11u-dev] RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol Message-ID: Backport [JDK-8261351](https://bugs.openjdk.org/browse/JDK-8261351). Merge conflict in file java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m had to change initWithCapacity to 7. in the previous commit it was 6 which correlated with the roles in that file. this file has 7 roles, the next backport is 8 with 8 roles. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 ------------- Commit messages: - Backport 6badd22e664696fb7119b1cc9b89cf719edfb92f Changes: https://git.openjdk.org/jdk11u-dev/pull/1581/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1581&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261351 Stats: 82 lines in 3 files changed: 81 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1581.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1581/head:pull/1581 PR: https://git.openjdk.org/jdk11u-dev/pull/1581 From clanger at openjdk.org Sun Dec 11 20:44:59 2022 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 11 Dec 2022 20:44:59 GMT Subject: [jdk11u-dev] RFR: 8296904: Improve handling of macos xcode toolchain Message-ID: This is a backport of JDK-8296904. Changes to make/autoconf/basic.m4 from jdk17u-dev apply cleanly. I resolved building.md to the state of jdk11u-dev and regenerated the html files with Pandoc 2.3.1. This also modified testing.html. ------------- Commit messages: - Backport 57e6d92a6ddbfe78cbf250a4502ce0911ee6f75a Changes: https://git.openjdk.org/jdk11u-dev/pull/1584/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1584&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296904 Stats: 91 lines in 4 files changed: 24 ins; 1 del; 66 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1584.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1584/head:pull/1584 PR: https://git.openjdk.org/jdk11u-dev/pull/1584 From ddong at openjdk.org Mon Dec 12 03:35:32 2022 From: ddong at openjdk.org (Denghui Dong) Date: Mon, 12 Dec 2022 03:35:32 GMT Subject: [jdk11u-dev] RFR: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de Message-ID: <42O0lAuvWpBeKv5Z0kQ9UC5Uok4AIMR0J2HSn17Oz0Q=.14c69e7e-fb6f-4413-9522-748f0808c8b1@github.com> This is a backport of JDK-8283870. It's not clean since there doesn't exist jdeprscan_de.properties in 11 and the other two files have different contexts caused by the license header. Some developers need to use this tool to help java 11 migration, so imo it's necessary to backport it. ------------- Commit messages: - Backport ef25e189c7f987b6c7b049ce481ee832cc7f70aa Changes: https://git.openjdk.org/jdk11u-dev/pull/1585/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1585&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283870 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1585.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1585/head:pull/1585 PR: https://git.openjdk.org/jdk11u-dev/pull/1585 From ddong at openjdk.org Mon Dec 12 03:47:03 2022 From: ddong at openjdk.org (Denghui Dong) Date: Mon, 12 Dec 2022 03:47:03 GMT Subject: [jdk17u-dev] RFR: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de Message-ID: This is a backport of JDK-8283870. It's not clean since there doesn't exist jdeprscan_de.properties in 17. Some developers need to use this tool to help java 17 migration, so imo it's necessary to backport it. ------------- Commit messages: - Backport ef25e189c7f987b6c7b049ce481ee832cc7f70aa Changes: https://git.openjdk.org/jdk17u-dev/pull/949/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=949&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283870 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/949.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/949/head:pull/949 PR: https://git.openjdk.org/jdk17u-dev/pull/949 From clanger at openjdk.org Mon Dec 12 07:00:48 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Dec 2022 07:00:48 GMT Subject: [jdk17u-dev] RFR: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation Message-ID: Hi all, This pull request contains a backport of [JDK-8298459](https://bugs.openjdk.org/browse/JDK-8298459), commit [d624debe](https://github.com/openjdk/jdk20/commit/d624debe23f60d778d7be43f28d06e9454057217) from the [openjdk/jdk20](https://git.openjdk.org/jdk20) repository. The commit being backported was authored by Christoph Langer on 11 Dec 2022 and was reviewed by Erik Joelsson. Thanks! ------------- Commit messages: - Backport d624debe23f60d778d7be43f28d06e9454057217 Changes: https://git.openjdk.org/jdk17u-dev/pull/950/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=950&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298459 Stats: 27 lines in 2 files changed: 20 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/950.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/950/head:pull/950 PR: https://git.openjdk.org/jdk17u-dev/pull/950 From clanger at openjdk.org Mon Dec 12 07:01:25 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Dec 2022 07:01:25 GMT Subject: [jdk19u] RFR: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation Message-ID: Hi all, This pull request contains a backport of [JDK-8298459](https://bugs.openjdk.org/browse/JDK-8298459), commit [d624debe](https://github.com/openjdk/jdk20/commit/d624debe23f60d778d7be43f28d06e9454057217) from the [openjdk/jdk20](https://git.openjdk.org/jdk20) repository. The commit being backported was authored by Christoph Langer on 11 Dec 2022 and was reviewed by Erik Joelsson. Thanks! ------------- Commit messages: - Backport d624debe23f60d778d7be43f28d06e9454057217 Changes: https://git.openjdk.org/jdk19u/pull/104/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298459 Stats: 27 lines in 2 files changed: 20 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk19u/pull/104.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/104/head:pull/104 PR: https://git.openjdk.org/jdk19u/pull/104 From yan at openjdk.org Mon Dec 12 07:28:49 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 07:28:49 GMT Subject: [jdk13u-dev] Integrated: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation In-Reply-To: References: Message-ID: <-l_qPgqfOHeEbRIuZa1OGELMpieNNRGtN-5VyuMzC4E=.663dba6c-ce0b-4250-bbaa-0ed7db8a3472@github.com> On Fri, 9 Dec 2022 12:59:37 GMT, Yuri Nesterenko wrote: > backporting because the issue exists here as well. > Clean backport, expected test behavior, tier1 OK. This pull request has now been integrated. Changeset: c270cfeb Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/c270cfeb0ecaa6dc95626bd8ba00888c36576aaf Stats: 141 lines in 2 files changed: 139 ins; 0 del; 2 mod 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Backport-of: 87d1097d9be1ef804bfd4640a4254126242b1d8c ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/441 From clanger at openjdk.org Mon Dec 12 07:54:56 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Dec 2022 07:54:56 GMT Subject: [jdk11u-dev] RFR: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation Message-ID: <1RdfeUruZaLwpxdZkXeKt1AoJe5S4D4RSECbCnTTkjs=.aa10eb71-05a1-4aff-a8f2-ee38edb4c63c@github.com> I had to resolve make/ZipSource.gmk due to missing JDK-8241073. ------------- Commit messages: - Backport d624debe23f60d778d7be43f28d06e9454057217 Changes: https://git.openjdk.org/jdk11u-dev/pull/1586/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1586&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298459 Stats: 27 lines in 2 files changed: 20 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1586.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1586/head:pull/1586 PR: https://git.openjdk.org/jdk11u-dev/pull/1586 From serb at openjdk.org Mon Dec 12 08:31:39 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Dec 2022 08:31:39 GMT Subject: [jdk17u-dev] Integrated: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters In-Reply-To: References: Message-ID: On Thu, 1 Dec 2022 11:04:36 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [87f00f4a](https://github.com/openjdk/jdk/commit/87f00f4a1bfb392be0684edcdfa0254caec4ca03) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 30 Nov 2022 and was reviewed by Phil Race and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 55159831 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/551598317931370a82e06f8b493bddc1c7ebb9f2 Stats: 94 lines in 2 files changed: 79 ins; 2 del; 13 mod 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters Backport-of: 87f00f4a1bfb392be0684edcdfa0254caec4ca03 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/943 From serb at openjdk.org Mon Dec 12 09:28:51 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Dec 2022 09:28:51 GMT Subject: [jdk11u-dev] Integrated: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters In-Reply-To: References: Message-ID: <8MpXQlNCXbLAqgSyjYoJCxBnBAy9TykdytH1xrTFLZQ=.9d82fe1a-dcad-4174-b17d-f2362371fbe2@github.com> On Thu, 1 Dec 2022 22:02:50 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [87f00f4a](https://github.com/openjdk/jdk/commit/87f00f4a1bfb392be0684edcdfa0254caec4ca03) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 30 Nov 2022 and was reviewed by Phil Race and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 9197181f Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/9197181f4e3e1e000879541678aa7659928da410 Stats: 92 lines in 2 files changed: 77 ins; 2 del; 13 mod 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters Reviewed-by: phh Backport-of: 87f00f4a1bfb392be0684edcdfa0254caec4ca03 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1563 From yan at openjdk.org Mon Dec 12 11:08:30 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 11:08:30 GMT Subject: [jdk15u-dev] RFR: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral Message-ID: backporting for parity with LTS releases. Clean backport, security tests do pass ------------- Commit messages: - Backport 2166ed136917bb68f8155a25e4f4a6c5c7115566 Changes: https://git.openjdk.org/jdk15u-dev/pull/315/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=315&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273894 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/315.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/315/head:pull/315 PR: https://git.openjdk.org/jdk15u-dev/pull/315 From yan at openjdk.org Mon Dec 12 11:38:05 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 11:38:05 GMT Subject: [jdk13u-dev] RFR: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral Message-ID: backporting for parity with LTS releases. Clean backport, security tests do pass ------------- Commit messages: - Backport 2166ed136917bb68f8155a25e4f4a6c5c7115566 Changes: https://git.openjdk.org/jdk13u-dev/pull/442/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=442&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273894 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/442.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/442/head:pull/442 PR: https://git.openjdk.org/jdk13u-dev/pull/442 From yan at openjdk.org Mon Dec 12 11:50:21 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 11:50:21 GMT Subject: [jdk13u-dev] Integrated: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 11:29:54 GMT, Yuri Nesterenko wrote: > backporting for parity with LTS releases. Clean backport, security tests do pass This pull request has now been integrated. Changeset: c9232dfd Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/c9232dfd2a7bec50c5292c0e1fcc8ed4406bb34b Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral Backport-of: 2166ed136917bb68f8155a25e4f4a6c5c7115566 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/442 From yan at openjdk.org Mon Dec 12 11:51:24 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 11:51:24 GMT Subject: [jdk15u-dev] Integrated: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 11:01:29 GMT, Yuri Nesterenko wrote: > backporting for parity with LTS releases. Clean backport, security tests do pass This pull request has now been integrated. Changeset: 78648cbd Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/78648cbdc3051168ac2e2334716db3df209b260e Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral Backport-of: 2166ed136917bb68f8155a25e4f4a6c5c7115566 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/315 From yan at openjdk.org Mon Dec 12 13:01:02 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 13:01:02 GMT Subject: [jdk13u-dev] RFR: 8283323: libharfbuzz optimization level results in extreme build times Message-ID: Backport with path adjustment make/modules/java.desktop/lib/Awt2dLibraries.gmk to make/lib/Awt2dLibraries.gmk and a small context difference. Simple comparison on a single machine yields 2 minutes economy for me. ------------- Commit messages: - Backport 2c43ecb43fa3c94b69478039f1cd70ed4a577768 Changes: https://git.openjdk.org/jdk13u-dev/pull/443/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=443&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283323 Stats: 9 lines in 1 file changed: 8 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/443.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/443/head:pull/443 PR: https://git.openjdk.org/jdk13u-dev/pull/443 From yan at openjdk.org Mon Dec 12 13:07:41 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 13:07:41 GMT Subject: [jdk15u-dev] RFR: 8283323: libharfbuzz optimization level results in extreme build times Message-ID: <0Ok5YmeDb-NbFdKCdN9MOI6ZJ3JYsQPjPsUrfRfvtxU=.0d5d3355-aea5-48ff-a28b-2e3aac3139b8@github.com> Almost clean backport with small context difference. ------------- Commit messages: - Backport 2c43ecb43fa3c94b69478039f1cd70ed4a577768 Changes: https://git.openjdk.org/jdk15u-dev/pull/316/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=316&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283323 Stats: 9 lines in 1 file changed: 8 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/316.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/316/head:pull/316 PR: https://git.openjdk.org/jdk15u-dev/pull/316 From yan at openjdk.org Mon Dec 12 13:34:07 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 13:34:07 GMT Subject: [jdk15u-dev] Integrated: 8283323: libharfbuzz optimization level results in extreme build times In-Reply-To: <0Ok5YmeDb-NbFdKCdN9MOI6ZJ3JYsQPjPsUrfRfvtxU=.0d5d3355-aea5-48ff-a28b-2e3aac3139b8@github.com> References: <0Ok5YmeDb-NbFdKCdN9MOI6ZJ3JYsQPjPsUrfRfvtxU=.0d5d3355-aea5-48ff-a28b-2e3aac3139b8@github.com> Message-ID: On Mon, 12 Dec 2022 12:58:49 GMT, Yuri Nesterenko wrote: > Almost clean backport with small context difference. This pull request has now been integrated. Changeset: f7d5c599 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/f7d5c59932215054d110e9d1aab1425e9c6ff0fd Stats: 9 lines in 1 file changed: 8 ins; 1 del; 0 mod 8283323: libharfbuzz optimization level results in extreme build times Backport-of: 2c43ecb43fa3c94b69478039f1cd70ed4a577768 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/316 From aivanov at openjdk.org Mon Dec 12 13:45:30 2022 From: aivanov at openjdk.org (Alexey Ivanov) Date: Mon, 12 Dec 2022 13:45:30 GMT Subject: [jdk19u] RFR: 8282463: javax/sound/sampled/Clip/DataPusherThreadCheck.java fails Message-ID: Hi all, This pull request contains a backport of commit [2e716375](https://github.com/openjdk/jdk/commit/2e7163759c75cab6ab5ffa04c13d32ccc95f9719) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Andrey Turbanov on 30 Oct 2022 and was reviewed by Phil Race and Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport 2e7163759c75cab6ab5ffa04c13d32ccc95f9719 Changes: https://git.openjdk.org/jdk19u/pull/105/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282463 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/105.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/105/head:pull/105 PR: https://git.openjdk.org/jdk19u/pull/105 From goetz at openjdk.org Mon Dec 12 14:21:20 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 12 Dec 2022 14:21:20 GMT Subject: [jdk11u-dev] RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled In-Reply-To: References: Message-ID: <679ZstRtigSRyPPut3Mz6KoEY6NU2GiCXH78t1Z8KuY=.d6362e8e-1d10-43a9-879e-4c2c2c949094@github.com> On Fri, 9 Dec 2022 09:32:44 GMT, Roman Marchenko wrote: > Clean backport > > Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs > > - #1575 > - #1576 Hi @wkla please give reason why you backport and assess the risk in the JBS fix request comment. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1574 From dcherepanov at openjdk.org Mon Dec 12 14:41:00 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 12 Dec 2022 14:41:00 GMT Subject: [jdk13u-dev] RFR: 8283323: libharfbuzz optimization level results in extreme build times In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 12:54:11 GMT, Yuri Nesterenko wrote: > Backport with path adjustment make/modules/java.desktop/lib/Awt2dLibraries.gmk to make/lib/Awt2dLibraries.gmk and a small context difference. Simple comparison on a single machine yields 2 minutes economy for me. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/443 From yan at openjdk.org Mon Dec 12 14:46:23 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 12 Dec 2022 14:46:23 GMT Subject: [jdk13u-dev] Integrated: 8283323: libharfbuzz optimization level results in extreme build times In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 12:54:11 GMT, Yuri Nesterenko wrote: > Backport with path adjustment make/modules/java.desktop/lib/Awt2dLibraries.gmk to make/lib/Awt2dLibraries.gmk and a small context difference. Simple comparison on a single machine yields 2 minutes economy for me. This pull request has now been integrated. Changeset: 3493d0eb Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/3493d0eb013282e4ed7a25d76ad5ca35c50179f4 Stats: 9 lines in 1 file changed: 8 ins; 1 del; 0 mod 8283323: libharfbuzz optimization level results in extreme build times Reviewed-by: dcherepanov Backport-of: 2c43ecb43fa3c94b69478039f1cd70ed4a577768 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/443 From duke at openjdk.org Mon Dec 12 15:07:11 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Mon, 12 Dec 2022 15:07:11 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: Message-ID: <69An28aw1FdwZWdL_rMuN8aoae0QVjiNACb9UMYpuGs=.e9f86454-c2c6-46a9-bbc9-652516b9bd9b@github.com> On Tue, 6 Dec 2022 13:47:09 GMT, Daniel Fuchs wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > It is important that the test checks the URI received by the server, and that's probably why the body was used here. The server writes the URI it receives in the response body. This provides an end-to-end check that what was received is what we expected to send. Note that the server doesn't actually supports WebSocket and that's why it always replies with 400. Hello @dfuch, @jerboaa, @phohensee, @jaikiran I'd like this tets change to go forward: https://github.com/openjdk/jdk/pull/11486 It correctly fails without JDK-8245245 and passes with it. It is not necessary to be checking the body. When that test change is integrated, I'd initiate its backport. Close this pr (https://github.com/openjdk/jdk11u-dev/pull/1558) and open a new one, that would just cleanly add JDK-8245245... I hope that is all right process wise. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From clanger at openjdk.org Mon Dec 12 15:16:21 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Dec 2022 15:16:21 GMT Subject: [jdk11u-dev] RFR: 8179317: [TESTBUG] rewrite runtime shell tests in java Message-ID: This is a backport of JDK-8179317 and also includes the fix JDK-8247741. Backporting this test fix is a prerequisite for #1554. I had to resolve a few places. Also, test/hotspot/jtreg/runtime/TLS/testtls.sh is not part of jdk11u-dev, so I skipped it. ------------- Commit messages: - Backport ccb4ab5499275888e6a088d8bec2faccd6b4db28 Changes: https://git.openjdk.org/jdk11u-dev/pull/1587/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1587&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8179317 Stats: 704 lines in 17 files changed: 429 ins; 268 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1587.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1587/head:pull/1587 PR: https://git.openjdk.org/jdk11u-dev/pull/1587 From dfuchs at openjdk.org Mon Dec 12 15:22:01 2022 From: dfuchs at openjdk.org (Daniel Fuchs) Date: Mon, 12 Dec 2022 15:22:01 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: <69An28aw1FdwZWdL_rMuN8aoae0QVjiNACb9UMYpuGs=.e9f86454-c2c6-46a9-bbc9-652516b9bd9b@github.com> References: <69An28aw1FdwZWdL_rMuN8aoae0QVjiNACb9UMYpuGs=.e9f86454-c2c6-46a9-bbc9-652516b9bd9b@github.com> Message-ID: On Mon, 12 Dec 2022 15:05:01 GMT, Michal Karm Babacek wrote: > It correctly fails without JDK-8245245 and passes with it. It is not necessary to be checking the body. Thanks for double checking. In that case I believed you're covered, I personally have no objection in that case. I mostly commented because I don't think there's a bug in the original test. It just uses a different method to check for success. As for approval I'll defer to the JDK 11 maintainers. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From clanger at openjdk.org Mon Dec 12 15:36:50 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Dec 2022 15:36:50 GMT Subject: [jdk11u-dev] RFR: 8259267: Refactor LoaderLeak shell test as java test. Message-ID: Another prerequisite for #1554 I had to confirm deletion of LoaderLeak.sh and Main.java due to the absence of JDK-8244224 and JDK-8225648. I'll mark it as clean and will add JDK-8225648 to the list of resolved bugs. ------------- Commit messages: - Backport 75aa15467ec3d88a26f7c28518a24caf132818bf Changes: https://git.openjdk.org/jdk11u-dev/pull/1588/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1588&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8259267 Stats: 439 lines in 6 files changed: 135 ins; 304 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1588.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1588/head:pull/1588 PR: https://git.openjdk.org/jdk11u-dev/pull/1588 From mdoerr at openjdk.org Mon Dec 12 15:43:05 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 12 Dec 2022 15:43:05 GMT Subject: [jdk11u-dev] RFR: 8179317: [TESTBUG] rewrite runtime shell tests in java In-Reply-To: References: Message-ID: <2d19LYFzd9fSPBROIuzgZK9HrEYS_yLfkziPivYNoJo=.3bfc12ec-04f4-47ee-a5bd-73d6a4df610f@github.com> On Mon, 12 Dec 2022 15:09:06 GMT, Christoph Langer wrote: > This is a backport of JDK-8179317 and also includes the fix JDK-8247741. Backporting this test fix is a prerequisite for #1554. > > I had to resolve a few places. Also, test/hotspot/jtreg/runtime/TLS/testtls.sh is not part of jdk11u-dev, so I skipped it. I think this makes sense. Backport looks reasonable. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1587 From mdoerr at openjdk.org Mon Dec 12 15:48:19 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 12 Dec 2022 15:48:19 GMT Subject: [jdk11u-dev] RFR: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation In-Reply-To: <1RdfeUruZaLwpxdZkXeKt1AoJe5S4D4RSECbCnTTkjs=.aa10eb71-05a1-4aff-a8f2-ee38edb4c63c@github.com> References: <1RdfeUruZaLwpxdZkXeKt1AoJe5S4D4RSECbCnTTkjs=.aa10eb71-05a1-4aff-a8f2-ee38edb4c63c@github.com> Message-ID: On Mon, 12 Dec 2022 07:48:29 GMT, Christoph Langer wrote: > I had to resolve make/ZipSource.gmk due to missing JDK-8241073. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1586 From asemenov at openjdk.org Mon Dec 12 15:57:08 2022 From: asemenov at openjdk.org (Artem Semenov) Date: Mon, 12 Dec 2022 15:57:08 GMT Subject: [jdk17u-dev] RFR: 8298457: Instructions in a11y manual tests need to be updated Message-ID: Test instructions: - Accessible Actions Test; - AccessibleJTabbedPaneTest; - Accessible Text Test. contain inaccurate indications of actions in different screen readers. These changes were committed to the [JDK](https://git.openjdk.org/jdk/pull/11607), but could not be applied automatically. ------------- Commit messages: - Backport 9749a436418a2e2bcd1571e2fd6f16e3461cf883 Changes: https://git.openjdk.org/jdk17u-dev/pull/948/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=948&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298457 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/948.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/948/head:pull/948 PR: https://git.openjdk.org/jdk17u-dev/pull/948 From asemenov at openjdk.org Mon Dec 12 15:57:08 2022 From: asemenov at openjdk.org (Artem Semenov) Date: Mon, 12 Dec 2022 15:57:08 GMT Subject: [jdk17u-dev] RFR: 8298457: Instructions in a11y manual tests need to be updated In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 21:18:59 GMT, Artem Semenov wrote: > Test instructions: > - Accessible Actions Test; > - AccessibleJTabbedPaneTest; > - Accessible Text Test. > contain inaccurate indications of actions in different screen readers. > These changes were committed to the [JDK](https://git.openjdk.org/jdk/pull/11607), but could not be applied automatically. @azuev-java please review ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/948 From goetz at openjdk.org Mon Dec 12 15:57:08 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 12 Dec 2022 15:57:08 GMT Subject: [jdk17u-dev] RFR: 8298457: Instructions in a11y manual tests need to be updated In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 21:27:56 GMT, Artem Semenov wrote: >> Test instructions: >> - Accessible Actions Test; >> - AccessibleJTabbedPaneTest; >> - Accessible Text Test. >> contain inaccurate indications of actions in different screen readers. >> These changes were committed to the [JDK](https://git.openjdk.org/jdk/pull/11607), but could not be applied automatically. > > @azuev-java please review Hi @savoptik, before you ask for a review, please fix your PR. Tests are red. Errors are not addressed. Also, especially for the comment in the JBS issue, follow the instructions in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix Label again if your PR is ready. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/948 From andrew at openjdk.org Mon Dec 12 16:27:50 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 12 Dec 2022 16:27:50 GMT Subject: [jdk17u] RFR: 8297804: (tz) Update Timezone Data to 2022g Message-ID: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> Clean backport of the latest tzdata update. This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. Thanks! ------------- Commit messages: - Backport ce896731d38866c2bf99cd49525062e150d94160 Changes: https://git.openjdk.org/jdk17u/pull/361/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=361&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297804 Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod Patch: https://git.openjdk.org/jdk17u/pull/361.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/361/head:pull/361 PR: https://git.openjdk.org/jdk17u/pull/361 From clanger at openjdk.org Mon Dec 12 17:38:12 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Dec 2022 17:38:12 GMT Subject: [jdk17u] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> References: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> Message-ID: On Mon, 12 Dec 2022 16:20:15 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. > > Thanks! Interestingly the PR bot does not recognize the backport as clean. Seems like some files have been moved between head and here which was no issue for the /backport command on the commit in head. Nevermind, I eyeballed it and it looks correct. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk17u/pull/361 From clanger at openjdk.org Mon Dec 12 20:27:21 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Dec 2022 20:27:21 GMT Subject: [jdk11u-dev] RFR: 8259267: Refactor LoaderLeak shell test as java test. [v2] In-Reply-To: References: Message-ID: > Another prerequisite for #1554 > > I had to confirm deletion of LoaderLeak.sh and Main.java due to the absence of JDK-8244224 and JDK-8225648. > I'll mark it as clean and will add JDK-8225648 to the list of resolved bugs. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Make code fit to JDK11 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1588/files - new: https://git.openjdk.org/jdk11u-dev/pull/1588/files/8d71df1c..bb97a3c3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1588&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1588&range=00-01 Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1588.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1588/head:pull/1588 PR: https://git.openjdk.org/jdk11u-dev/pull/1588 From duke at openjdk.org Tue Dec 13 00:55:35 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 00:55:35 GMT Subject: [jdk11u-dev] RFR: 8256126: Create implementation for NSAccessibilityImage protocol peer [v2] In-Reply-To: References: Message-ID: <-ieWOvQljE529OhFkUWyRx2AuHHDpN4tMWxDb1RChfk=.f697b519-82da-43d4-a824-5b88464b328e@github.com> > clean backport [JDK-8256126](https://bugs.openjdk.org/browse/JDK-8256126) 3 of 28. Autumn Capasso has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'origin/JDK-8256126' into JDK-8256126 - backport bbb93ca3c80968d4f167bb4cd9e5d3e60e4a6a5b Signed-off-by: Autumn808 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1572/files - new: https://git.openjdk.org/jdk11u-dev/pull/1572/files/ad75e6d3..4e6a5d76 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1572&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1572&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1572.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1572/head:pull/1572 PR: https://git.openjdk.org/jdk11u-dev/pull/1572 From duke at openjdk.org Tue Dec 13 00:57:27 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 00:57:27 GMT Subject: [jdk11u-dev] Withdrawn: 8256126: Create implementation for NSAccessibilityImage protocol peer In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 21:45:44 GMT, Autumn Capasso wrote: > clean backport [JDK-8256126](https://bugs.openjdk.org/browse/JDK-8256126) 3 of 28. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1572 From duke at openjdk.org Tue Dec 13 01:03:15 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 01:03:15 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol [v2] In-Reply-To: <3o-Vdx80LkVD8hMTdjQ96HaWR3ucfL9Y_1WdOqpK1hw=.45c793c7-b3f8-4400-9313-e99dff4d9b2a@github.com> References: <3o-Vdx80LkVD8hMTdjQ96HaWR3ucfL9Y_1WdOqpK1hw=.45c793c7-b3f8-4400-9313-e99dff4d9b2a@github.com> Message-ID: > Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) clean backport. One of 28 https://bugs.openjdk.org/browse/JDK-8152350 Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1578/files - new: https://git.openjdk.org/jdk11u-dev/pull/1578/files/d7face5c..d7face5c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1578&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1578&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1578.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1578/head:pull/1578 PR: https://git.openjdk.org/jdk11u-dev/pull/1578 From duke at openjdk.org Tue Dec 13 02:48:34 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 02:48:34 GMT Subject: [jdk11u-dev] RFR: 8256126: Create implementation for NSAccessibilityImage protocol peer Message-ID: Clean Backport [JDK-8256126](https://bugs.openjdk.org/browse/JDK-8256126). One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 ------------- Commit messages: - Backport bbb93ca3c80968d4f167bb4cd9e5d3e60e4a6a5b Changes: https://git.openjdk.org/jdk11u-dev/pull/1589/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1589&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256126 Stats: 42 lines in 3 files changed: 39 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1589.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1589/head:pull/1589 PR: https://git.openjdk.org/jdk11u-dev/pull/1589 From duke at openjdk.org Tue Dec 13 02:56:45 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 02:56:45 GMT Subject: [jdk11u-dev] Withdrawn: 8256110: Create implementation for NSAccessibilityStepper protocol In-Reply-To: <3o-Vdx80LkVD8hMTdjQ96HaWR3ucfL9Y_1WdOqpK1hw=.45c793c7-b3f8-4400-9313-e99dff4d9b2a@github.com> References: <3o-Vdx80LkVD8hMTdjQ96HaWR3ucfL9Y_1WdOqpK1hw=.45c793c7-b3f8-4400-9313-e99dff4d9b2a@github.com> Message-ID: On Fri, 9 Dec 2022 19:01:21 GMT, Autumn Capasso wrote: > Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) clean backport. One of 28 https://bugs.openjdk.org/browse/JDK-8152350 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1578 From mdoerr at openjdk.org Tue Dec 13 12:05:48 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 13 Dec 2022 12:05:48 GMT Subject: [jdk17u-dev] RFR: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic Message-ID: Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). ------------- Commit messages: - Backport cd2182a9967917e733e486d918e9aeba3bd35ee8 Changes: https://git.openjdk.org/jdk17u-dev/pull/951/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=951&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295724 Stats: 146 lines in 4 files changed: 143 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/951.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/951/head:pull/951 PR: https://git.openjdk.org/jdk17u-dev/pull/951 From andrew at openjdk.org Tue Dec 13 14:43:12 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 13 Dec 2022 14:43:12 GMT Subject: [jdk17u] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> Message-ID: On Mon, 12 Dec 2022 17:36:05 GMT, Christoph Langer wrote: > Interestingly the PR bot does not recognize the backport as clean. Seems like some files have been moved between head and here which was no issue for the /backport command on the commit in head. Nevermind, I eyeballed it and it looks correct. Strange. The `/backport` command seems to have handled both 17u & 11u fine. Thanks for the review. I've already flagged this with `jdk17u-critical-request` if you'd like to approve. ------------- PR: https://git.openjdk.org/jdk17u/pull/361 From duke at openjdk.org Tue Dec 13 14:47:34 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Tue, 13 Dec 2022 14:47:34 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v2] In-Reply-To: References: Message-ID: <1v84lf6DykyczzQZJv3J9XIRoMf81ovIUAyWXrnUp5c=.d1806b26-fc3c-44ed-b467-bcab91539757@github.com> > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: Makes test independent on JDK-8240666 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1558/files - new: https://git.openjdk.org/jdk11u-dev/pull/1558/files/3f2772ff..5feb6ef4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=00-01 Stats: 11 lines in 1 file changed: 6 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1558.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1558/head:pull/1558 PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From clanger at openjdk.org Tue Dec 13 16:03:18 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 13 Dec 2022 16:03:18 GMT Subject: [jdk17u] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> Message-ID: On Tue, 13 Dec 2022 14:40:45 GMT, Andrew John Hughes wrote: > I've already flagged this with `jdk17u-critical-request` if you'd like to approve. Done. ------------- PR: https://git.openjdk.org/jdk17u/pull/361 From mdoerr at openjdk.org Tue Dec 13 16:28:14 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 13 Dec 2022 16:28:14 GMT Subject: [jdk11u-dev] RFR: 8259267: Refactor LoaderLeak shell test as java test. [v2] In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 20:27:21 GMT, Christoph Langer wrote: >> Another prerequisite for #1554 >> >> I had to confirm deletion of LoaderLeak.sh and Main.java due to the absence of JDK-8244224 and JDK-8225648. >> I'll mark it as clean and will add JDK-8225648 to the list of resolved bugs. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Make code fit to JDK11 11u adaptations are fine. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1588 From kvn at openjdk.org Tue Dec 13 17:44:14 2022 From: kvn at openjdk.org (Vladimir Kozlov) Date: Tue, 13 Dec 2022 17:44:14 GMT Subject: [jdk17u-dev] RFR: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic In-Reply-To: References: Message-ID: On Tue, 13 Dec 2022 11:58:23 GMT, Martin Doerr wrote: > Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: > The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). I start testing. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/951 From duke at openjdk.org Tue Dec 13 18:21:06 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 18:21:06 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol Message-ID: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) Clean. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 --author "Autumn Capasso " ------------- Commit messages: - Backport 5dc5d9401e7a176da53a14293fb59e97b644b31a Changes: https://git.openjdk.org/jdk11u-dev/pull/1591/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1591&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256110 Stats: 133 lines in 5 files changed: 116 ins; 15 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1591.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1591/head:pull/1591 PR: https://git.openjdk.org/jdk11u-dev/pull/1591 From duke at openjdk.org Tue Dec 13 18:21:20 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 18:21:20 GMT Subject: [jdk11u-dev] RFR: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions Message-ID: Backport [JDK-8261352](https://bugs.openjdk.org/browse/JDK-8261352) Merge conflict in file java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m had to changed initWithCapacity. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 Autumn808 ------------- Commit messages: - Backport e543a5009847a8e3ccbb047b93e3cc6fb261ef8c Changes: https://git.openjdk.org/jdk11u-dev/pull/1583/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1583&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261352 Stats: 195 lines in 5 files changed: 157 ins; 37 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1583.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1583/head:pull/1583 PR: https://git.openjdk.org/jdk11u-dev/pull/1583 From duke at openjdk.org Tue Dec 13 18:22:56 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 18:22:56 GMT Subject: [jdk11u-dev] RFR: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer Message-ID: <8TYu3p0TMtzMEcQhbsCFvN8zluxZuJ8X_cKdC0edjIQ=.73941cfe-9bc2-428a-9ae2-5f692bff9196@github.com> [JDK-8261350](https://bugs.openjdk.org/browse/JDK-8261350) Merge conflict in file java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m had to changed initWithCapacity. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 ------------- Commit messages: - Backport 2b00367e1154feb2c05b84a11d62fb5750e46acf Changes: https://git.openjdk.org/jdk11u-dev/pull/1582/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1582&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261350 Stats: 122 lines in 5 files changed: 109 ins; 3 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1582.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1582/head:pull/1582 PR: https://git.openjdk.org/jdk11u-dev/pull/1582 From duke at openjdk.org Tue Dec 13 18:23:09 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 18:23:09 GMT Subject: [jdk11u-dev] Withdrawn: 8256111: Create implementation for NSAccessibilityStaticText protocol In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 19:19:38 GMT, Autumn Capasso wrote: > Backport [JDK-8256111](https://bugs.openjdk.org/browse/JDK-8256111) clean backport. One of 28 https://bugs.openjdk.org/browse/JDK-8152350 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1580 From andrew at openjdk.org Tue Dec 13 18:34:14 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 13 Dec 2022 18:34:14 GMT Subject: [jdk17u] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> References: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> Message-ID: On Mon, 12 Dec 2022 16:20:15 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. > > Thanks! Thanks. ------------- PR: https://git.openjdk.org/jdk17u/pull/361 From andrew at openjdk.org Tue Dec 13 18:36:06 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 13 Dec 2022 18:36:06 GMT Subject: [jdk17u] Integrated: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> References: <8hOG8oaM43PLHtTf17TCRznlY20t9HF6PDLKCF80txA=.2c7632d1-efec-468f-b4c3-8f23ac5a9e0b@github.com> Message-ID: On Mon, 12 Dec 2022 16:20:15 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. > > Thanks! This pull request has now been integrated. Changeset: 12f32dfd Author: Andrew John Hughes URL: https://git.openjdk.org/jdk17u/commit/12f32dfd458268197f1bfa80c27dd8e6bfc4095c Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod 8297804: (tz) Update Timezone Data to 2022g Reviewed-by: clanger Backport-of: ce896731d38866c2bf99cd49525062e150d94160 ------------- PR: https://git.openjdk.org/jdk17u/pull/361 From andrew at openjdk.org Tue Dec 13 18:39:00 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 13 Dec 2022 18:39:00 GMT Subject: [jdk11u] RFR: 8297804: (tz) Update Timezone Data to 2022g Message-ID: Clean backport of the latest tzdata update. This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. Thanks! ------------- Commit messages: - Backport ce896731d38866c2bf99cd49525062e150d94160 Changes: https://git.openjdk.org/jdk11u/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=63&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297804 Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod Patch: https://git.openjdk.org/jdk11u/pull/63.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/63/head:pull/63 PR: https://git.openjdk.org/jdk11u/pull/63 From duke at openjdk.org Tue Dec 13 18:39:17 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 13 Dec 2022 18:39:17 GMT Subject: [jdk11u-dev] RFR: 8256111: Create implementation for NSAccessibilityStaticText protocol Message-ID: Backport [JDK-8256111](https://bugs.openjdk.org/browse/JDK-8256111) One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 By: Autumn808 ------------- Commit messages: - Backport acbcde8c3c004efe3d95166f471ee77ac8415af7 Changes: https://git.openjdk.org/jdk11u-dev/pull/1592/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1592&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256111 Stats: 292 lines in 5 files changed: 290 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1592.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1592/head:pull/1592 PR: https://git.openjdk.org/jdk11u-dev/pull/1592 From phh at openjdk.org Tue Dec 13 22:18:47 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 13 Dec 2022 22:18:47 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol In-Reply-To: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> References: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> Message-ID: On Tue, 13 Dec 2022 18:13:57 GMT, Autumn Capasso wrote: > Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) > Clean. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 > --author "Autumn Capasso " In CommonComponentAccessibility.m, new lines 52 and 53 are part of https://github.com/openjdk/jdk11u-dev/pull/1589, and the difference between old and new lines 49 includes the change from 1589. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1591 From kvn at openjdk.org Wed Dec 14 03:24:30 2022 From: kvn at openjdk.org (Vladimir Kozlov) Date: Wed, 14 Dec 2022 03:24:30 GMT Subject: [jdk17u-dev] RFR: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic In-Reply-To: References: Message-ID: On Tue, 13 Dec 2022 11:58:23 GMT, Martin Doerr wrote: > Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: > The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). My testing of jdk17u with these changes passed. ------------- Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/951 From goetz at openjdk.org Wed Dec 14 07:13:32 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Dec 2022 07:13:32 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.6+7 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8293965: Code signing warnings after JDK-8293550 - 8294310: compare.sh fails on macos after JDK-8293550 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/953/files Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/953.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/953/head:pull/953 PR: https://git.openjdk.org/jdk17u-dev/pull/953 From goetz at openjdk.org Wed Dec 14 07:47:08 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Dec 2022 07:47:08 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 07:06:36 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.6+7 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: 60a7cdd8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/60a7cdd8755a3b555c9ff798770162be2601de95 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/953 From goetz at openjdk.org Wed Dec 14 07:48:29 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Dec 2022 07:48:29 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.18+7 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8258005: JDK build fails with incorrect fixpath script The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/1593/files Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1593.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1593/head:pull/1593 PR: https://git.openjdk.org/jdk11u-dev/pull/1593 From goetz at openjdk.org Wed Dec 14 07:54:06 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Dec 2022 07:54:06 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 07:42:09 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.18+7 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: e5c800c5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e5c800c5ad4a3db82b0d6ca837a55f8f611221e0 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1593 From mbaesken at openjdk.org Wed Dec 14 08:10:00 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Dec 2022 08:10:00 GMT Subject: [jdk11u-dev] RFR: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: <2eQsA0GTcXLcIgHux5-xHh4ouLOwNnKBwxZkHPpsP10=.540a2707-4125-43fc-b26d-6229a95fbe04@github.com> On Sun, 11 Dec 2022 20:38:38 GMT, Christoph Langer wrote: > This is a backport of JDK-8296904. Changes to make/autoconf/basic.m4 from jdk17u-dev apply cleanly. > I resolved building.md to the state of jdk11u-dev and regenerated the html files with Pandoc 2.3.1. This also modified testing.html. looks like we test in basic.m4 for DEVKIT_ROOT in the if check, but we do not use it afterwards and go directly to UTIL_LOOKUP_PROGS using TOOLCHAIN_PATH. This seems to be different in head https://github.com/openjdk/jdk/blob/470f3424fcce0e41b75cccdd5e3a56771cd07ff5/make/autoconf/basic.m4#L137 but on the other hand we do it in 17u-dev the same way. So probably the backport is okay, but maybe not optimal (comparing to head) ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1584 From clanger at openjdk.org Wed Dec 14 09:19:04 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 09:19:04 GMT Subject: [jdk11u-dev] RFR: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: On Sun, 11 Dec 2022 20:38:38 GMT, Christoph Langer wrote: > This is a backport of JDK-8296904. Changes to make/autoconf/basic.m4 from jdk17u-dev apply cleanly. > I resolved building.md to the state of jdk11u-dev and regenerated the html files with Pandoc 2.3.1. This also modified testing.html. Hi, as I've already [commented in the 17u-dev PR](https://github.com/openjdk/jdk17u-dev/pull/931#issuecomment-1327366600), this would be fixed with backporting [JDK-8287254](https://bugs.openjdk.org/browse/JDK-8287254), something we could/should consider independently. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1584 From rrich at openjdk.org Wed Dec 14 09:21:19 2022 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 14 Dec 2022 09:21:19 GMT Subject: [jdk17u-dev] RFR: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame Message-ID: Hi all, This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/bdb4ed0fb136e9e5391cfa520048de6b7f83067d. The commit being backported was authored by Richard Reingruber on 12 Oct 2022 and was reviewed by dholmes and mdoerr. It applied cleanly. The fix passed our CI testing which includes JCK and JTREG tests on the standard platforms and also on Linux/PPC64le. Thanks! ------------- Commit messages: - 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame Changes: https://git.openjdk.org/jdk17u-dev/pull/952/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=952&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294580 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/952.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/952/head:pull/952 PR: https://git.openjdk.org/jdk17u-dev/pull/952 From rrich at openjdk.org Wed Dec 14 09:23:57 2022 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 14 Dec 2022 09:23:57 GMT Subject: [jdk11u-dev] RFR: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame Message-ID: Hi all, This pull request contains a backport of commit [openjdk/jdk at bdb4ed0](https://github.com/openjdk/jdk/commit/bdb4ed0fb136e9e5391cfa520048de6b7f83067d). The commit being backported was authored by Richard Reingruber on 12 Oct 2022 and was reviewed by dholmes and mdoerr. It applied cleanly but did not compile. As a fix, `nullptr` was replaced with `NULL`. The fix passed our CI testing which includes JCK and JTREG tests on the standard platforms and also on Linux/PPC64le. Thanks! ------------- Commit messages: - nullptr requires C++11 - 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame Changes: https://git.openjdk.org/jdk11u-dev/pull/1590/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1590&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294580 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1590.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1590/head:pull/1590 PR: https://git.openjdk.org/jdk11u-dev/pull/1590 From clanger at openjdk.org Wed Dec 14 09:27:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 09:27:55 GMT Subject: [jdk19u] RFR: 8298527: Cygwin's uname -m returns different string than before Message-ID: Hi all, This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [51f0a1ce](https://github.com/openjdk/jdk20/commit/51f0a1ce4b0d72cf7e82e01f7014274d8b7d1575) from the [openjdk/jdk20](https://git.openjdk.org/jdk20) repository. The commit being backported was authored by Christoph Langer on 14 Dec 2022 and was reviewed by Erik Joelsson. Thanks! ------------- Commit messages: - Backport 51f0a1ce4b0d72cf7e82e01f7014274d8b7d1575 Changes: https://git.openjdk.org/jdk19u/pull/106/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=106&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298527 Stats: 73 lines in 1 file changed: 33 ins; 39 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/106.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/106/head:pull/106 PR: https://git.openjdk.org/jdk19u/pull/106 From mdoerr at openjdk.org Wed Dec 14 09:31:21 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 14 Dec 2022 09:31:21 GMT Subject: [jdk17u-dev] RFR: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic In-Reply-To: References: Message-ID: On Tue, 13 Dec 2022 11:58:23 GMT, Martin Doerr wrote: > Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: > The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). Thanks a lot for testing! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/951 From clanger at openjdk.org Wed Dec 14 09:37:37 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 09:37:37 GMT Subject: [jdk17u] RFR: 8298527: Cygwin's uname -m returns different string than before Message-ID: <3A7ZV1m3rMDGWr0eJphyeYQtwkblsmZlUTnwO2Tsgy0=.34d94c6c-50f8-43b8-b7b2-066172055e9c@github.com> Needed to resolve due to missing change for RISCV support. ------------- Commit messages: - Backport 51f0a1ce4b0d72cf7e82e01f7014274d8b7d1575 Changes: https://git.openjdk.org/jdk17u/pull/362/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=362&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298527 Stats: 64 lines in 1 file changed: 33 ins; 30 del; 1 mod Patch: https://git.openjdk.org/jdk17u/pull/362.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/362/head:pull/362 PR: https://git.openjdk.org/jdk17u/pull/362 From mbaesken at openjdk.org Wed Dec 14 09:41:14 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Dec 2022 09:41:14 GMT Subject: [jdk11u-dev] RFR: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: <_vjW4LLWPb_FJXHPrFHUgCdAZg82ugs0D9bLm3fyhRM=.57369f18-79f8-4b5d-90d7-a3de93c0a02f@github.com> On Sun, 11 Dec 2022 20:38:38 GMT, Christoph Langer wrote: > This is a backport of JDK-8296904. Changes to make/autoconf/basic.m4 from jdk17u-dev apply cleanly. > I resolved building.md to the state of jdk11u-dev and regenerated the html files with Pandoc 2.3.1. This also modified testing.html. Marked as reviewed by mbaesken (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1584 From mdoerr at openjdk.org Wed Dec 14 09:56:02 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 14 Dec 2022 09:56:02 GMT Subject: [jdk11u-dev] RFR: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame In-Reply-To: References: Message-ID: On Tue, 13 Dec 2022 14:17:28 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit [openjdk/jdk at bdb4ed0](https://github.com/openjdk/jdk/commit/bdb4ed0fb136e9e5391cfa520048de6b7f83067d). > > The commit being backported was authored by Richard Reingruber on 12 Oct 2022 and was reviewed by dholmes and mdoerr. It applied cleanly but did not compile. As a fix, `nullptr` was replaced with `NULL`. > > The fix passed our CI testing which includes JCK and JTREG tests on the standard platforms and also on Linux/PPC64le. > > Thanks! Adaptation looks good and trivial. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1590 From rrich at openjdk.org Wed Dec 14 09:56:02 2022 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 14 Dec 2022 09:56:02 GMT Subject: [jdk11u-dev] RFR: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame In-Reply-To: References: Message-ID: <3GB3QvDzcalQh3D1DEJLCX5nzciGVhPNoavYj0lDQY0=.635b0eb2-50d4-4a43-90b4-df01a2ce45cf@github.com> On Wed, 14 Dec 2022 09:49:36 GMT, Martin Doerr wrote: > Adaptation looks good and trivial. Thanks for the Review! Richard. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1590 From avoitylov at openjdk.org Wed Dec 14 12:18:57 2022 From: avoitylov at openjdk.org (Aleksei Voitylov) Date: Wed, 14 Dec 2022 12:18:57 GMT Subject: [jdk11u-dev] RFR: 8298737: 8296772 backport to jdk11u caused build error on sparc Message-ID: This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 ------------- Commit messages: - JDK-8298737 Changes: https://git.openjdk.org/jdk11u-dev/pull/1594/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1594&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298737 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1594.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1594/head:pull/1594 PR: https://git.openjdk.org/jdk11u-dev/pull/1594 From goetz at openjdk.org Wed Dec 14 12:49:23 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Dec 2022 12:49:23 GMT Subject: [jdk11u-dev] RFR: 8298737: 8296772 backport to jdk11u caused build error on sparc In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 12:11:33 GMT, Aleksei Voitylov wrote: > This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 Hi @voitylov can you please redo this against jdk11u? As the bug is there too, we should fix it in jdk11u. You need to flag jdk11u-critical-request. I'll grant it if the change passes tests (which it will). Thanks, Goetz. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1594 From avoitylov at openjdk.org Wed Dec 14 13:07:12 2022 From: avoitylov at openjdk.org (Aleksei Voitylov) Date: Wed, 14 Dec 2022 13:07:12 GMT Subject: [jdk11u-dev] RFR: 8298737: 8296772 backport to jdk11u caused build error on sparc In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 12:11:33 GMT, Aleksei Voitylov wrote: > This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 Yep. Done. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1594 From avoitylov at openjdk.org Wed Dec 14 13:12:09 2022 From: avoitylov at openjdk.org (Aleksei Voitylov) Date: Wed, 14 Dec 2022 13:12:09 GMT Subject: [jdk11u] RFR: 8298737: 8296772 backport to jdk11u caused build error on sparc Message-ID: This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 ------------- Commit messages: - JDK-8298737 Changes: https://git.openjdk.org/jdk11u/pull/64/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=64&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298737 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u/pull/64.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/64/head:pull/64 PR: https://git.openjdk.org/jdk11u/pull/64 From andrew at openjdk.org Wed Dec 14 16:12:07 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 14 Dec 2022 16:12:07 GMT Subject: [jdk15u-dev] RFR: 8297804: (tz) Update Timezone Data to 2022g Message-ID: Clean backport of the latest tzdata update. This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. Thanks! ------------- Commit messages: - Backport ce896731d38866c2bf99cd49525062e150d94160 Changes: https://git.openjdk.org/jdk15u-dev/pull/317/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=317&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297804 Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/317.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/317/head:pull/317 PR: https://git.openjdk.org/jdk15u-dev/pull/317 From clanger at openjdk.org Wed Dec 14 16:23:08 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 16:23:08 GMT Subject: [jdk17u-dev] Integrated: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation In-Reply-To: References: Message-ID: <1EX97OtyE9iOAVUa48x4s3ayheMnLwrCG8BCHaM4G64=.b33baf1a-303d-489c-ba32-5e8abaf04036@github.com> On Mon, 12 Dec 2022 06:53:34 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8298459](https://bugs.openjdk.org/browse/JDK-8298459), commit [d624debe](https://github.com/openjdk/jdk20/commit/d624debe23f60d778d7be43f28d06e9454057217) from the [openjdk/jdk20](https://git.openjdk.org/jdk20) repository. > > The commit being backported was authored by Christoph Langer on 11 Dec 2022 and was reviewed by Erik Joelsson. > > Thanks! This pull request has now been integrated. Changeset: 399a52dc Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/399a52dccb2a53a4309fdff479a14d944829cd54 Stats: 27 lines in 2 files changed: 20 ins; 0 del; 7 mod 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation Backport-of: d624debe23f60d778d7be43f28d06e9454057217 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/950 From clanger at openjdk.org Wed Dec 14 16:40:29 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 16:40:29 GMT Subject: [jdk11u-dev] Integrated: 8259267: Refactor LoaderLeak shell test as java test. In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 15:28:44 GMT, Christoph Langer wrote: > Another prerequisite for #1554 > > I had to confirm deletion of LoaderLeak.sh and Main.java due to the absence of JDK-8244224 and JDK-8225648. > Furthermore I had to adapt the test to Java 11 syntax. > Incorporated JDK-8225648 and added it to the list of resolved bugs. This pull request has now been integrated. Changeset: 7d50d519 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/7d50d5199b82c041b473bc83901ac299784e6414 Stats: 441 lines in 6 files changed: 137 ins; 304 del; 0 mod 8259267: Refactor LoaderLeak shell test as java test. 8225648: [TESTBUG] java/lang/annotation/loaderLeak/Main.java fails with -Xcomp Reviewed-by: mdoerr Backport-of: 75aa15467ec3d88a26f7c28518a24caf132818bf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1588 From goetz at openjdk.org Wed Dec 14 16:59:08 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Dec 2022 16:59:08 GMT Subject: [jdk11u] RFR: 8298737: 8296772 backport to jdk11u caused build error on sparc In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 13:03:35 GMT, Aleksei Voitylov wrote: > This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 LGTM ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.org/jdk11u/pull/64 From clanger at openjdk.org Wed Dec 14 16:59:23 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 16:59:23 GMT Subject: [jdk11u-dev] Integrated: 8179317: [TESTBUG] rewrite runtime shell tests in java In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 15:09:06 GMT, Christoph Langer wrote: > This is a backport of JDK-8179317 and also includes the fix JDK-8247741. Backporting this test fix is a prerequisite for #1554. > > I had to resolve a few places. Also, test/hotspot/jtreg/runtime/TLS/testtls.sh is not part of jdk11u-dev, so I skipped it. This pull request has now been integrated. Changeset: 604dd4d9 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/604dd4d9c683b67de6ec77fadafc82aae202eadc Stats: 704 lines in 17 files changed: 429 ins; 268 del; 7 mod 8179317: [TESTBUG] rewrite runtime shell tests in java 8247741: Test test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java fails when -XX:+IgnoreUnrecognizedVMOptions is set Converted shell tests to Java Reviewed-by: mdoerr Backport-of: ccb4ab5499275888e6a088d8bec2faccd6b4db28 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1587 From goetz at openjdk.org Wed Dec 14 17:00:21 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Dec 2022 17:00:21 GMT Subject: [jdk11u-dev] RFR: 8298737: 8296772 backport to jdk11u caused build error on sparc In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 12:11:33 GMT, Aleksei Voitylov wrote: > This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 Please close this PR. The change will automatically be integrated to jdk11u-dev from jdk11u next Wednesday. Thanks. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1594 From clanger at openjdk.org Wed Dec 14 17:13:12 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 17:13:12 GMT Subject: [jdk11u-dev] Integrated: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation In-Reply-To: <1RdfeUruZaLwpxdZkXeKt1AoJe5S4D4RSECbCnTTkjs=.aa10eb71-05a1-4aff-a8f2-ee38edb4c63c@github.com> References: <1RdfeUruZaLwpxdZkXeKt1AoJe5S4D4RSECbCnTTkjs=.aa10eb71-05a1-4aff-a8f2-ee38edb4c63c@github.com> Message-ID: On Mon, 12 Dec 2022 07:48:29 GMT, Christoph Langer wrote: > I had to resolve make/ZipSource.gmk due to missing JDK-8241073. This pull request has now been integrated. Changeset: b3c7b287 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/b3c7b287c3843444690669cccfc73785b5970ca4 Stats: 27 lines in 2 files changed: 20 ins; 0 del; 7 mod 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation Reviewed-by: mdoerr Backport-of: d624debe23f60d778d7be43f28d06e9454057217 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1586 From gdams at openjdk.org Wed Dec 14 17:18:46 2022 From: gdams at openjdk.org (George Adams) Date: Wed, 14 Dec 2022 17:18:46 GMT Subject: [jdk11u-dev] RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4] In-Reply-To: References: Message-ID: > The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete. > > Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout. George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into actions - fixup build/test failures - remove GTEST code blocks - macOS bump to 11 - Backport 3df72a359e402b929b210f88ed85a86f9f10231f - Backport bebb61224b163a70d79392e41ede4e61dbb04288 - Backport 881ff368ceaff83ae78b1a17896c1ee45524bc84 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1554/files - new: https://git.openjdk.org/jdk11u-dev/pull/1554/files/201d839f..44199a4f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1554&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1554&range=02-03 Stats: 1687 lines in 52 files changed: 1071 ins; 536 del; 80 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1554.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1554/head:pull/1554 PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From duke at openjdk.org Wed Dec 14 19:02:07 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 14 Dec 2022 19:02:07 GMT Subject: [jdk11u-dev] Integrated: 8256126: Create implementation for NSAccessibilityImage protocol peer In-Reply-To: References: Message-ID: <8seKHSfeHIdXbvMoFSS3MGbyLnmDNpSRLy9v9_cG6yE=.877a194d-39c6-4cb8-b4ea-b9bccd2fc244@github.com> On Tue, 13 Dec 2022 02:37:48 GMT, Autumn Capasso wrote: > Clean Backport [JDK-8256126](https://bugs.openjdk.org/browse/JDK-8256126). One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 This pull request has now been integrated. Changeset: 12eca2f8 Author: Pankaj Bansal Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/12eca2f8ac6e8127f1d698aef50db03cf278a7b8 Stats: 42 lines in 3 files changed: 39 ins; 1 del; 2 mod 8256126: Create implementation for NSAccessibilityImage protocol peer Backport-of: bbb93ca3c80968d4f167bb4cd9e5d3e60e4a6a5b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1589 From jbhateja at openjdk.org Wed Dec 14 19:34:17 2022 From: jbhateja at openjdk.org (Jatin Bhateja) Date: Wed, 14 Dec 2022 19:34:17 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v3] In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 15:24:50 GMT, Goetz Lindenmaier wrote: > Hi @jatin-bhateja, > > 1. The change is not clean if it requires merges. Using the clean command is not allowed in this case. Obviously you even introduced two formatting errors when resolving (which might make follow up backports unclean). > 2. you should not type integrate if you do not have a fix-yes label on the JBS bug. > Please follow the instructions in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix for your next backport. Hi @GoeLin , Thanks for your guidance and suggestions, I have updated the patch description to reflect the exact change from original pull request and removed the mention of 'clean backport', will take precautions in future. Patch is regressed and approved by JDK reviewers. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/917 From duke at openjdk.org Wed Dec 14 20:07:29 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 14 Dec 2022 20:07:29 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol [v2] In-Reply-To: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> References: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> Message-ID: <8QUE1a8OIzaB0bAfyoQPDJ-7NRtE_1cLDCeYFzBg7i0=.39fdefda-122a-44bf-bc0d-31e2010bc109@github.com> > Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) > Clean. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 > --author "Autumn Capasso " Autumn Capasso has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8256110: Create implementation for NSAccessibilityStepper protocol Reviewed-by: pbansal, serb (cherry picked from commit 5dc5d9401e7a176da53a14293fb59e97b644b31a) Signed-off-by: Autumn808 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1591/files - new: https://git.openjdk.org/jdk11u-dev/pull/1591/files/2b6089d8..b9e50998 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1591&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1591&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1591.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1591/head:pull/1591 PR: https://git.openjdk.org/jdk11u-dev/pull/1591 From duke at openjdk.org Wed Dec 14 20:22:54 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 14 Dec 2022 20:22:54 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol [v3] In-Reply-To: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> References: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> Message-ID: > Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) > Clean. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 > --author "Autumn Capasso " Autumn Capasso has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport acbcde8c3c004efe3d95166f471ee77ac8415af7 By: Autumn808 Signed-off-by: Autumn808 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1591/files - new: https://git.openjdk.org/jdk11u-dev/pull/1591/files/b9e50998..98db7df2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1591&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1591&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1591.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1591/head:pull/1591 PR: https://git.openjdk.org/jdk11u-dev/pull/1591 From clanger at openjdk.org Wed Dec 14 20:42:08 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 20:42:08 GMT Subject: [jdk11u-dev] RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4] In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 17:18:46 GMT, George Adams wrote: >> The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete. >> >> Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout. > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into actions > - fixup build/test failures > - remove GTEST code blocks > - macOS bump to 11 > - Backport 3df72a359e402b929b210f88ed85a86f9f10231f > - Backport bebb61224b163a70d79392e41ede4e61dbb04288 > - Backport 881ff368ceaff83ae78b1a17896c1ee45524bc84 This looks good now! ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From phh at openjdk.org Wed Dec 14 20:48:23 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 Dec 2022 20:48:23 GMT Subject: [jdk11u-dev] RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4] In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 17:18:46 GMT, George Adams wrote: >> The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete. >> >> Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout. > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into actions > - fixup build/test failures > - remove GTEST code blocks > - macOS bump to 11 > - Backport 3df72a359e402b929b210f88ed85a86f9f10231f > - Backport bebb61224b163a70d79392e41ede4e61dbb04288 > - Backport 881ff368ceaff83ae78b1a17896c1ee45524bc84 If that's the policy, lgtm. :) ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From clanger at openjdk.org Wed Dec 14 20:48:24 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Dec 2022 20:48:24 GMT Subject: [jdk11u-dev] RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v3] In-Reply-To: <5HBc7hXLTw-SlVxWJjsebXu2yq6oM4RGmLbYzJZwTk8=.dab66397-a951-45e0-b283-51873743b40c@github.com> References: <5HBc7hXLTw-SlVxWJjsebXu2yq6oM4RGmLbYzJZwTk8=.dab66397-a951-45e0-b283-51873743b40c@github.com> Message-ID: On Mon, 28 Nov 2022 23:42:08 GMT, Paul Hohensee wrote: > The backport of [JDK-8288499](https://bugs.openjdk.org/browse/JDK-8288499), though trivial, should be done separately. Hi, @phohensee, yes, usually that's the process. But I think for this type of little regression fixes, it's ok and pragmatic to do that inline. The Skara bots also help to resolve the JBS items correctly. We've been doing that here and there already and I personally endorse this pattern. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From duke at openjdk.org Wed Dec 14 22:33:28 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 14 Dec 2022 22:33:28 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol [v4] In-Reply-To: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> References: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> Message-ID: > Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) > Clean. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 > --author "Autumn Capasso " Autumn Capasso has updated the pull request incrementally with six additional commits since the last revision: - 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation Reviewed-by: mdoerr Backport-of: d624debe23f60d778d7be43f28d06e9454057217 - 8179317: [TESTBUG] rewrite runtime shell tests in java 8247741: Test test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java fails when -XX:+IgnoreUnrecognizedVMOptions is set Converted shell tests to Java Reviewed-by: mdoerr Backport-of: ccb4ab5499275888e6a088d8bec2faccd6b4db28 - 8259267: Refactor LoaderLeak shell test as java test. 8225648: [TESTBUG] java/lang/annotation/loaderLeak/Main.java fails with -Xcomp Reviewed-by: mdoerr Backport-of: 75aa15467ec3d88a26f7c28518a24caf132818bf - 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters Reviewed-by: phh Backport-of: 87f00f4a1bfb392be0684edcdfa0254caec4ca03 - backport bbb93ca3c80968d4f167bb4cd9e5d3e60e4a6a5b - Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 one of 28. Clean. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1591/files - new: https://git.openjdk.org/jdk11u-dev/pull/1591/files/98db7df2..98753268 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1591&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1591&range=02-03 Stats: 1380 lines in 30 files changed: 779 ins; 574 del; 27 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1591.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1591/head:pull/1591 PR: https://git.openjdk.org/jdk11u-dev/pull/1591 From duke at openjdk.org Wed Dec 14 22:43:54 2022 From: duke at openjdk.org (Dhamoder Nalla) Date: Wed, 14 Dec 2022 22:43:54 GMT Subject: [jdk11u-dev] RFR: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg Message-ID: assert in print_inlining_update_delayed is checking for an empty inline stream buffer which is expected to be empty. Fix is to call print_inlining_update_delayed() only when do_late_inline_check() fails in do_late_inline() which is similar to JDK17 code where this issue doesn't reproduce. ------------- Commit messages: - assert(_print_inlining_stream->size() > 0) failed: missing inlining msg Changes: https://git.openjdk.org/jdk11u-dev/pull/1595/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1595&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292863 Stats: 3 lines in 1 file changed: 1 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1595.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1595/head:pull/1595 PR: https://git.openjdk.org/jdk11u-dev/pull/1595 From duke at openjdk.org Wed Dec 14 22:51:12 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 14 Dec 2022 22:51:12 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol Message-ID: Clean backport for oracle parity. ------------- Commit messages: - Backport 5dc5d9401e7a176da53a14293fb59e97b644b31a Changes: https://git.openjdk.org/jdk11u-dev/pull/1596/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1596&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256110 Stats: 131 lines in 5 files changed: 114 ins; 15 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1596.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1596/head:pull/1596 PR: https://git.openjdk.org/jdk11u-dev/pull/1596 From duke at openjdk.org Wed Dec 14 22:54:23 2022 From: duke at openjdk.org (Jeff) Date: Wed, 14 Dec 2022 22:54:23 GMT Subject: [jdk17u-dev] RFR: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic In-Reply-To: References: Message-ID: <8Oy2utVm8UO36aHSqhE3GOH9dcvBSLdS_CI-kaKFe78=.301d5ece-ec8d-4554-9b60-f79854251ef2@github.com> On Tue, 13 Dec 2022 11:58:23 GMT, Martin Doerr wrote: > Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: > The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). Thanks! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/951 From phh at openjdk.org Wed Dec 14 23:07:04 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 Dec 2022 23:07:04 GMT Subject: [jdk11u-dev] RFR: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 22:35:01 GMT, Dhamoder Nalla wrote: > assert in print_inlining_update_delayed is checking for an empty inline stream buffer which is expected to be empty. > > Fix is to call print_inlining_update_delayed() only when do_late_inline_check() fails in do_late_inline() which is similar to JDK17 code where this issue doesn't reproduce. Looks like you intended to post a PR against JDK tip, i.e., a commit to your fork of https://github.com/openjdk/jdk.git, not https://github.com/openjdk/jdk11u-dev. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1595 From duke at openjdk.org Wed Dec 14 23:24:02 2022 From: duke at openjdk.org (Dhamoder Nalla) Date: Wed, 14 Dec 2022 23:24:02 GMT Subject: [jdk11u-dev] RFR: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg In-Reply-To: References: Message-ID: <8E0sPDF4bjoxtkVFvUcf7r7NkHVMRK6LtkOxdYja1U8=.c81a8687-7680-4ba3-b49f-415f96fca868@github.com> On Wed, 14 Dec 2022 22:35:01 GMT, Dhamoder Nalla wrote: > assert in print_inlining_update_delayed is checking for an empty inline stream buffer which is expected to be empty. > > Fix is to call print_inlining_update_delayed() only when do_late_inline_check() fails in do_late_inline() which is similar to JDK17 code where this issue doesn't reproduce. > > Note: This issue is already fixed in JDK17+ branches. > Thanks for looking at this PR @phohensee I am targeting only JDK11 branch as this issue is already fixed in JDK17+ branches. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1595 From phh at openjdk.org Wed Dec 14 23:36:03 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 Dec 2022 23:36:03 GMT Subject: [jdk11u-dev] RFR: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 22:35:01 GMT, Dhamoder Nalla wrote: > assert in print_inlining_update_delayed is checking for an empty inline stream buffer which is expected to be empty. > > Fix is to call print_inlining_update_delayed() only when do_late_inline_check() fails in do_late_inline() which is similar to JDK17 code where this issue doesn't reproduce. > > Note: This issue is already fixed in JDK17+ branches. You're right! My bad. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1595 From phh at openjdk.org Thu Dec 15 00:31:13 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Dec 2022 00:31:13 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 22:42:56 GMT, Autumn Capasso wrote: > Clean backport for oracle parity. Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1596 From andrew at openjdk.org Thu Dec 15 01:49:08 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 15 Dec 2022 01:49:08 GMT Subject: [jdk11u] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Tue, 13 Dec 2022 18:29:29 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. > > Thanks! I see `jdk11u-critical-yes` ------------- PR: https://git.openjdk.org/jdk11u/pull/63 From andrew at openjdk.org Thu Dec 15 01:49:09 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 15 Dec 2022 01:49:09 GMT Subject: [jdk11u] Integrated: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Tue, 13 Dec 2022 18:29:29 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. > > Thanks! This pull request has now been integrated. Changeset: 77d919a8 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk11u/commit/77d919a870810f88a9f6a4d9b864ecac718448f7 Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod 8297804: (tz) Update Timezone Data to 2022g Backport-of: ce896731d38866c2bf99cd49525062e150d94160 ------------- PR: https://git.openjdk.org/jdk11u/pull/63 From mbaesken at openjdk.org Thu Dec 15 07:57:05 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Dec 2022 07:57:05 GMT Subject: [jdk11u-dev] Integrated: 8287011: Improve container information In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 13:43:23 GMT, Matthias Baesken wrote: > Backport 8287011; os_linux.cpp had to be adjusted manually , the other file patches went in cleanly. This pull request has now been integrated. Changeset: 01f5a197 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/01f5a197102c377c6ce29b1e695657a75c414c3a Stats: 125 lines in 9 files changed: 104 ins; 13 del; 8 mod 8287011: Improve container information Backport-of: e60939850e5328b9c0f2002ac5ed7744375bf18b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1577 From clanger at openjdk.org Thu Dec 15 08:08:43 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 15 Dec 2022 08:08:43 GMT Subject: [jdk11u-dev] RFR: 8244592: Start supporting SOURCE_DATE_EPOCH Message-ID: After the backport of [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679), a non-debug build on Windows in a build directory that's outside the repository will fail. The problem unveiled by the backport is that in those builds, the `ALLOW_ABSOLUTE_PATHS_IN_OUTPUT` flag is set to false, causing the code [here](https://github.com/openjdk/jdk11u-dev/blob/12eca2f8ac6e8127f1d698aef50db03cf278a7b8/make/common/NativeCompilation.gmk#L220) to relativize the make command. This seemed to have worked fine with the old fixpath before [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) but now it breaks the build. In later releases, we get new code by [JDK-8256240](https://bugs.openjdk.org/browse/JDK-8256240) that removes the absolute paths on Windows by setting a new compiler option. After the change, `FILE_MACRO_CFLAGS` is set (e.g. [here](https://github.com/openjdk/jdk17u-dev/blob/399a52dccb2a53a4309fdff479a14d944829cd54/make/autoconf/flags-cflags.m4#L823)) which will cause MakeCommandRelative to not relativize the paths in NativeCompilation.gmk. I propose to backport this behavior to jdk11u by backporting [JDK-8244592 Start supporting SOURCE_DATE_EPOCH](https://bugs.openjdk.org/browse/JDK-8244592) and [JDK-8256240 Reproducible builds should turn on the "deterministic" flag for Visual Studio](https://bugs.openjdk.org/browse/JDK-8256240). This will bring some functionality of reproducible builds to jdk11u. I don't see an issue with that, since the behavior is off by default. The only larger risk I see is whether the newly used Visual Studio compiler options could break existing downstream builds on older VS versions. However, if such a thing occurs, we could add a condition to fall back to the old behavior then. As for this backport: I bring in a part of [JDK-8240820](https://bugs.openjdk.org/browse/JDK-8240820), namely the new configure function `UTIL_ARG_ENABLE` which is used by [JDK-8244592](https://bugs.openjdk.org/browse/JDK-8244592). Furthermore I incorporated the changes to jdk-options.m4 of the already backported [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679), which didn't fit at that time. ------------- Commit messages: - 8244592: Start supporting SOURCE_DATE_EPOCH Changes: https://git.openjdk.org/jdk11u-dev/pull/1597/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1597&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8244592 Stats: 336 lines in 7 files changed: 332 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1597.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1597/head:pull/1597 PR: https://git.openjdk.org/jdk11u-dev/pull/1597 From clanger at openjdk.org Thu Dec 15 08:24:44 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 15 Dec 2022 08:24:44 GMT Subject: [jdk11u-dev] RFR: 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio Message-ID: This is the backport of [JDK-8256240](https://bugs.openjdk.org/browse/JDK-8256240). I incorporated [JDK-8281262](https://bugs.openjdk.org/browse/JDK-8281262) because the code that was removed by it in flags-cflags.m4 did not work in 11u-dev due to some missing requirements. I will hence mark JDK-8281262 as fixed by this change. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1597 Commit messages: - 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio Changes: https://git.openjdk.org/jdk11u-dev/pull/1598/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1598&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256240 Stats: 66 lines in 5 files changed: 52 ins; 6 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1598/head:pull/1598 PR: https://git.openjdk.org/jdk11u-dev/pull/1598 From rrich at openjdk.org Thu Dec 15 08:25:29 2022 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 15 Dec 2022 08:25:29 GMT Subject: [jdk17u-dev] Integrated: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame In-Reply-To: References: Message-ID: On Tue, 13 Dec 2022 13:31:15 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/bdb4ed0fb136e9e5391cfa520048de6b7f83067d. > > The commit being backported was authored by Richard Reingruber on 12 Oct 2022 and was reviewed by dholmes and mdoerr. It applied cleanly. > > The fix passed our CI testing which includes JCK and JTREG tests on the standard platforms and also on Linux/PPC64le. > > Thanks! This pull request has now been integrated. Changeset: 9fdaa338 Author: Richard Reingruber URL: https://git.openjdk.org/jdk17u-dev/commit/9fdaa338b727353a259b09ed215117449829c5a1 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame Backport-of: bdb4ed0fb136e9e5391cfa520048de6b7f83067d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/952 From rrich at openjdk.org Thu Dec 15 08:27:10 2022 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 15 Dec 2022 08:27:10 GMT Subject: [jdk11u-dev] Integrated: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame In-Reply-To: References: Message-ID: <7RlXylMeUoCS6pH-89V9xXEMf7Ho3GQUipMuvEFxtI4=.f75f0b41-9368-4e4a-88b0-9cbd1ae58dd6@github.com> On Tue, 13 Dec 2022 14:17:28 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit [openjdk/jdk at bdb4ed0](https://github.com/openjdk/jdk/commit/bdb4ed0fb136e9e5391cfa520048de6b7f83067d). > > The commit being backported was authored by Richard Reingruber on 12 Oct 2022 and was reviewed by dholmes and mdoerr. It applied cleanly but did not compile. As a fix, `nullptr` was replaced with `NULL`. > > The fix passed our CI testing which includes JCK and JTREG tests on the standard platforms and also on Linux/PPC64le. > > Thanks! This pull request has now been integrated. Changeset: 3f66b162 Author: Richard Reingruber URL: https://git.openjdk.org/jdk11u-dev/commit/3f66b16257c0c444209fa5c8cf00c9b8c08c0fd0 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame Reviewed-by: mdoerr Backport-of: bdb4ed0fb136e9e5391cfa520048de6b7f83067d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1590 From avoitylov at openjdk.org Thu Dec 15 09:54:05 2022 From: avoitylov at openjdk.org (Aleksei Voitylov) Date: Thu, 15 Dec 2022 09:54:05 GMT Subject: [jdk11u-dev] RFR: 8298737: 8296772 backport to jdk11u caused build error on sparc In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 12:11:33 GMT, Aleksei Voitylov wrote: > This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 Closing as the PR is being integrated into jdk11u. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1594 From avoitylov at openjdk.org Thu Dec 15 10:06:15 2022 From: avoitylov at openjdk.org (Aleksei Voitylov) Date: Thu, 15 Dec 2022 10:06:15 GMT Subject: [jdk11u-dev] Withdrawn: 8298737: 8296772 backport to jdk11u caused build error on sparc In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 12:11:33 GMT, Aleksei Voitylov wrote: > This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1594 From phh at openjdk.org Thu Dec 15 15:47:15 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Dec 2022 15:47:15 GMT Subject: [jdk11u-dev] RFR: 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio In-Reply-To: References: Message-ID: On Thu, 15 Dec 2022 08:16:01 GMT, Christoph Langer wrote: > This is the backport of [JDK-8256240](https://bugs.openjdk.org/browse/JDK-8256240). I incorporated [JDK-8281262](https://bugs.openjdk.org/browse/JDK-8281262) because the code that was removed by it in flags-cflags.m4 did not work in 11u-dev due to some missing requirements. I will hence mark JDK-8281262 as fixed by this change. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1598 From phh at openjdk.org Thu Dec 15 15:54:15 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Dec 2022 15:54:15 GMT Subject: [jdk11u-dev] RFR: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 22:35:01 GMT, Dhamoder Nalla wrote: > assert in print_inlining_update_delayed is checking for an empty inline stream buffer which is expected to be empty. > > Fix is to call print_inlining_update_delayed() only when do_late_inline_check() fails in do_late_inline() which is similar to JDK17 code where this issue doesn't reproduce. > > Note: This issue is already fixed in JDK17+ branches. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1595 From duke at openjdk.org Thu Dec 15 17:53:16 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 15 Dec 2022 17:53:16 GMT Subject: [jdk11u-dev] Withdrawn: 8256110: Create implementation for NSAccessibilityStepper protocol In-Reply-To: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> References: <0PbqtH1ACkp62wRPaIsq9UBJ7QI_iMs3ICfmC8tZUzc=.fbc252db-c816-4752-821d-d059b30482d9@github.com> Message-ID: On Tue, 13 Dec 2022 18:13:57 GMT, Autumn Capasso wrote: > Backport [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8256110) > Clean. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350 > --author "Autumn Capasso " This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1591 From duke at openjdk.org Thu Dec 15 18:09:18 2022 From: duke at openjdk.org (Dhamoder Nalla) Date: Thu, 15 Dec 2022 18:09:18 GMT Subject: [jdk11u-dev] RFR: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg In-Reply-To: References: Message-ID: On Thu, 15 Dec 2022 15:51:05 GMT, Paul Hohensee wrote: > Lgtm. Thanks for the review @phohensee ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1595 From duke at openjdk.org Thu Dec 15 23:40:13 2022 From: duke at openjdk.org (Yi-Fan Tsai) Date: Thu, 15 Dec 2022 23:40:13 GMT Subject: [jdk17u-dev] RFR: 8296548: Improve MD5 intrinsic for x86_64 Message-ID: Reviewed-by: kvn, sviswanathan, luhenry ------------- Commit messages: - 8296548: Improve MD5 intrinsic for x86_64 Changes: https://git.openjdk.org/jdk17u-dev/pull/954/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=954&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296548 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/954.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/954/head:pull/954 PR: https://git.openjdk.org/jdk17u-dev/pull/954 From serb at openjdk.org Fri Dec 16 10:31:03 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 16 Dec 2022 10:31:03 GMT Subject: [jdk11u-dev] RFR: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86 Message-ID: Hi all, This pull request contains a backport of commit [2bb727c4](https://github.com/openjdk/jdk/commit/2bb727c4eaf8a948f17f6416a1e6fbaeade4d7ce) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 16 Dec 2022 and was reviewed by Jaikiran Pai and Paul Hohensee. Thanks! ------------- Commit messages: - Backport 2bb727c4eaf8a948f17f6416a1e6fbaeade4d7ce Changes: https://git.openjdk.org/jdk11u-dev/pull/1599/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1599&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290899 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1599.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1599/head:pull/1599 PR: https://git.openjdk.org/jdk11u-dev/pull/1599 From serb at openjdk.org Fri Dec 16 10:31:08 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 16 Dec 2022 10:31:08 GMT Subject: [jdk17u-dev] RFR: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86 Message-ID: Hi all, This pull request contains a backport of commit [2bb727c4](https://github.com/openjdk/jdk/commit/2bb727c4eaf8a948f17f6416a1e6fbaeade4d7ce) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 16 Dec 2022 and was reviewed by Jaikiran Pai and Paul Hohensee. Thanks! ------------- Commit messages: - Backport 2bb727c4eaf8a948f17f6416a1e6fbaeade4d7ce Changes: https://git.openjdk.org/jdk17u-dev/pull/955/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=955&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290899 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/955.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/955/head:pull/955 PR: https://git.openjdk.org/jdk17u-dev/pull/955 From duke at openjdk.org Fri Dec 16 14:35:48 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Fri, 16 Dec 2022 14:35:48 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: <69An28aw1FdwZWdL_rMuN8aoae0QVjiNACb9UMYpuGs=.e9f86454-c2c6-46a9-bbc9-652516b9bd9b@github.com> Message-ID: On Mon, 12 Dec 2022 15:19:58 GMT, Daniel Fuchs wrote: >> Hello @dfuch, @jerboaa, @phohensee, @jaikiran >> >> I'd like this tets change to go forward: https://github.com/openjdk/jdk/pull/11486 >> It correctly fails without JDK-8245245 and passes with it. It is not necessary to be checking the body. >> >> When that test change is integrated, I'd initiate its backport. Close this pr (https://github.com/openjdk/jdk11u-dev/pull/1558) and open a new one, that would just cleanly add JDK-8245245... >> >> >> I hope that is all right process wise. > >> It correctly fails without JDK-8245245 and passes with it. It is not necessary to be checking the body. > > Thanks for double checking. In that case I believed you're covered, I personally have no objection in that case. I mostly commented because I don't think there's a bug in the original test. It just uses a different method to check for success. As for approval I'll defer to the JDK 11 maintainers. Hello @dfuch, @phohensee, With jdk/pull/11486 merged, I would kindly ask for a review of this backport to JDK11u. - the patch in OpeningHandshake.java did not require any changes - the diff for the test between what is in mainline and what I propose here is this: https://editor.mergely.com/Hh1c3Z1N/ thx K. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From sgehwolf at openjdk.org Fri Dec 16 15:06:03 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 Dec 2022 15:06:03 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 14:32:22 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Synchronized with jdk/pull/11486 Please use `/issue add JDK-8298588` as the test now contains those changes too. test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java line 132: > 130: final String expectedBody = "/?" + expectedRawQuery; > 131: assertEquals(body, expectedBody); > 132: } Please add a comment here that this `if` is present because [JDK-8240666](https://bugs.openjdk.org/browse/JDK-8240666) isn't in 11u. So that if it got backported eventually, somebody might notice it. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From phh at openjdk.org Fri Dec 16 16:33:00 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 16 Dec 2022 16:33:00 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 14:32:22 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Synchronized with jdk/pull/11486 Only a few format issues. Lgtm with Severin's recommendations. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From phh at openjdk.org Fri Dec 16 16:33:50 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 16 Dec 2022 16:33:50 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 14:32:22 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Synchronized with jdk/pull/11486 Only a few format issues. Lgtm with Severin's recommendations. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Fri Dec 16 14:32:22 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Fri, 16 Dec 2022 14:32:22 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: Synchronized with jdk/pull/11486 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1558/files - new: https://git.openjdk.org/jdk11u-dev/pull/1558/files/5feb6ef4..3e5b03e5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=01-02 Stats: 45 lines in 1 file changed: 11 ins; 3 del; 31 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1558.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1558/head:pull/1558 PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From serb at openjdk.org Sun Dec 18 02:04:51 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 18 Dec 2022 02:04:51 GMT Subject: [jdk11u-dev] RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS Message-ID: <8mSRpDNpRMojmF_BRdH9zDhA1GkqqoNWnFe9hdBPFTI=.9dbb474c-990f-45ad-927b-7f1426624944@github.com> Hi all, This pull request contains a backport of commit [eff5dafb](https://github.com/openjdk/jdk/commit/eff5dafba9f72bd0612357712ffa472ce1c9166a) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Feb 2022 and was reviewed by Alexey Ivanov and Phil Race. The change is not clean because of the context difference caused by the missing [JDK-8211300](https://bugs.openjdk.org/browse/JDK-8211300) in jdk11u-dev. Thanks! ------------- Commit messages: - Backport eff5dafba9f72bd0612357712ffa472ce1c9166a Changes: https://git.openjdk.org/jdk11u-dev/pull/1600/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1600&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274939 Stats: 12 lines in 3 files changed: 7 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1600.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1600/head:pull/1600 PR: https://git.openjdk.org/jdk11u-dev/pull/1600 From duke at openjdk.org Sun Dec 18 18:00:06 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Sun, 18 Dec 2022 18:00:06 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 16:30:12 GMT, Paul Hohensee wrote: >> Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: >> >> Synchronized with jdk/pull/11486 > > Lgtm with Severin's recommendations. @phohensee @jerboaa Ready ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Sun Dec 18 18:00:05 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Sun, 18 Dec 2022 18:00:05 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v4] In-Reply-To: References: Message-ID: > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: Adds comment about [JDK-8240666] ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1558/files - new: https://git.openjdk.org/jdk11u-dev/pull/1558/files/3e5b03e5..401b4528 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=02-03 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1558.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1558/head:pull/1558 PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From kusrinivasan at vmware.com Sun Dec 18 18:55:09 2022 From: kusrinivasan at vmware.com (Kumar Srinivasan) Date: Sun, 18 Dec 2022 18:55:09 +0000 Subject: Please approve: JDK-8234484 back-port to jdk8u Message-ID: Hi jdk8 approvers, Can someone please approve the back-port of JDK-8234484 ? a CSR has been obtained for the back-port. The fix has been in jdk15+ for some time now and has been reasonably soaked for 2 years. Given the Freeze date for 8u362-b09 is Dec 23rd, it would be preferable to get this in earlier than later, ie. well before the holidays and shutdown. Thanks Kumar Srinivasan -------------- next part -------------- An HTML attachment was scrubbed... URL: From kusrinivasan at vmware.com Sun Dec 18 18:56:02 2022 From: kusrinivasan at vmware.com (Kumar Srinivasan) Date: Sun, 18 Dec 2022 18:56:02 +0000 Subject: Please approve: JDK-8234484 back-port to jdk8u In-Reply-To: References: Message-ID: + added Vyom Tewari who did the heavy lifting. From: Kumar Srinivasan Date: Sunday, December 18, 2022 at 10:55 AM To: jdk8u-dev at openjdk.org , jdk-updates-dev at openjdk.org Subject: Please approve: JDK-8234484 back-port to jdk8u Hi jdk8 approvers, Can someone please approve the back-port of JDK-8234484 ? a CSR has been obtained for the back-port. The fix has been in jdk15+ for some time now and has been reasonably soaked for 2 years. Given the Freeze date for 8u362-b09 is Dec 23rd, it would be preferable to get this in earlier than later, ie. well before the holidays and shutdown. Thanks Kumar Srinivasan -------------- next part -------------- An HTML attachment was scrubbed... URL: From yan at openjdk.org Mon Dec 19 07:18:54 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 19 Dec 2022 07:18:54 GMT Subject: [jdk15u-dev] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 16:04:37 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. > > Thanks! Thank you, @gnu-andrew ! Marked jdk15u-fix-yes. Sorry I was away for a week. Hope you will integrate before Dec 21-th; otherwise we'll change repository to jdk15u and label to critical. ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/317 From avoitylov at openjdk.org Mon Dec 19 08:19:59 2022 From: avoitylov at openjdk.org (Aleksei Voitylov) Date: Mon, 19 Dec 2022 08:19:59 GMT Subject: [jdk11u] Integrated: 8298737: 8296772 backport to jdk11u caused build error on sparc In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 13:03:35 GMT, Aleksei Voitylov wrote: > This PR fixes a build regression on Solaris Sparc caused by JDK-8296772 This pull request has now been integrated. Changeset: 88954e1e Author: Aleksei Voitylov Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u/commit/88954e1e812296abb4e876ed1f37cd6458d00c89 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8298737: 8296772 backport to jdk11u caused build error on sparc Reviewed-by: goetz ------------- PR: https://git.openjdk.org/jdk11u/pull/64 From serb at openjdk.org Mon Dec 19 08:20:45 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 19 Dec 2022 08:20:45 GMT Subject: [jdk11u-dev] RFR: 8238936: The crash in XRobotPeer when the custom GraphicsDevice is used Message-ID: Hi all, This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/9d0a4875d75421e416747271e3f229d068cf0dd0 from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. Backport is clean, but I had to change the dates and imports. The new test is passed after the fix, and no new issues were found by the jdk_desktop tests. ------------- Commit messages: - Backport 9d0a4875d75421e416747271e3f229d068cf0dd0 Changes: https://git.openjdk.org/jdk11u-dev/pull/1601/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1601&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8238936 Stats: 289 lines in 9 files changed: 216 ins; 37 del; 36 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1601.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1601/head:pull/1601 PR: https://git.openjdk.org/jdk11u-dev/pull/1601 From serb at openjdk.org Mon Dec 19 08:22:56 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 19 Dec 2022 08:22:56 GMT Subject: [jdk17u-dev] Integrated: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86 In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 06:42:25 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [2bb727c4](https://github.com/openjdk/jdk/commit/2bb727c4eaf8a948f17f6416a1e6fbaeade4d7ce) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 16 Dec 2022 and was reviewed by Jaikiran Pai and Paul Hohensee. > Thanks! This pull request has now been integrated. Changeset: 31a18b5e Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/31a18b5ee2c1be6c4e14b88da01a5daf14f8b1f3 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86 Backport-of: 2bb727c4eaf8a948f17f6416a1e6fbaeade4d7ce ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/955 From serb at openjdk.org Mon Dec 19 08:25:04 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 19 Dec 2022 08:25:04 GMT Subject: [jdk11u-dev] Integrated: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86 In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 06:44:57 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [2bb727c4](https://github.com/openjdk/jdk/commit/2bb727c4eaf8a948f17f6416a1e6fbaeade4d7ce) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 16 Dec 2022 and was reviewed by Jaikiran Pai and Paul Hohensee. > Thanks! This pull request has now been integrated. Changeset: 5f4b38a4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/5f4b38a490ca41ce7d868cb46acfacdb4e7937f6 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86 Backport-of: 2bb727c4eaf8a948f17f6416a1e6fbaeade4d7ce ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1599 From clanger at openjdk.org Mon Dec 19 09:15:58 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 09:15:58 GMT Subject: [jdk11u-dev] Integrated: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: On Sun, 11 Dec 2022 20:38:38 GMT, Christoph Langer wrote: > This is a backport of JDK-8296904. Changes to make/autoconf/basic.m4 from jdk17u-dev apply cleanly. > I resolved building.md to the state of jdk11u-dev and regenerated the html files with Pandoc 2.3.1. This also modified testing.html. This pull request has now been integrated. Changeset: 8a4915e5 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/8a4915e5e0fae857106b4a461d07cedbb7fc730a Stats: 91 lines in 4 files changed: 24 ins; 1 del; 66 mod 8296904: Improve handling of macos xcode toolchain Reviewed-by: mbaesken Backport-of: 57e6d92a6ddbfe78cbf250a4502ce0911ee6f75a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1584 From rmarchenko at openjdk.org Mon Dec 19 09:16:46 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Mon, 19 Dec 2022 09:16:46 GMT Subject: [jdk11u-dev] RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled In-Reply-To: <679ZstRtigSRyPPut3Mz6KoEY6NU2GiCXH78t1Z8KuY=.d6362e8e-1d10-43a9-879e-4c2c2c949094@github.com> References: <679ZstRtigSRyPPut3Mz6KoEY6NU2GiCXH78t1Z8KuY=.d6362e8e-1d10-43a9-879e-4c2c2c949094@github.com> Message-ID: On Mon, 12 Dec 2022 14:17:13 GMT, Goetz Lindenmaier wrote: >> Clean backport >> >> JDK11 has the same issue with processing host names for SNI. It'd be good to keep JDK11 up to date with the upstream. No risks. >> >> Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs >> >> - #1575 >> - #1576 > > Hi @wkla > please give reason why you backport and assess the risk in the JBS fix request comment. > > I remove the fix-request tag in the meantime. Feel free to add again after giving the reason. Hi @GoeLin I've updated both the PR and the bug with the reason description and risk assessment. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1574 From gdams at openjdk.org Mon Dec 19 09:34:49 2022 From: gdams at openjdk.org (George Adams) Date: Mon, 19 Dec 2022 09:34:49 GMT Subject: [jdk11u-dev] Integrated: 8287906: Rewrite of GitHub Actions (GHA) sanity tests In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 12:09:16 GMT, George Adams wrote: > The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete. > > Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout. This pull request has now been integrated. Changeset: 674218b0 Author: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/674218b0b0ff3602f2082a70f752f05c29732ec6 Stats: 3924 lines in 19 files changed: 1843 ins; 2081 del; 0 mod 8287906: Rewrite of GitHub Actions (GHA) sanity tests 8288499: Restore cancel-in-progress in GHA Reviewed-by: phh, clanger Backport-of: 881ff368ceaff83ae78b1a17896c1ee45524bc84 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From sgehwolf at redhat.com Mon Dec 19 09:51:50 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Mon, 19 Dec 2022 10:51:50 +0100 Subject: Please approve: JDK-8234484 back-port to jdk8u In-Reply-To: References: Message-ID: <24bd7b0162324e82edb4b096a9486ad673d3b488.camel@redhat.com> On Sun, 2022-12-18 at 18:56 +0000, Kumar Srinivasan wrote: > + added Vyom Tewari who did the heavy lifting. > ? > From:Kumar Srinivasan > Date: Sunday, December 18, 2022 at 10:55 AM > To: jdk8u-dev at openjdk.org , > jdk-updates-dev at openjdk.org > Subject: Please approve: JDK-8234484 back-port to jdk8u > Hi jdk8 approvers, > ? > Can someone please approve the back-port of JDK-8234484 ? a CSR has > been obtained for the back-port. > ? > The fix has been in jdk15+ for some time now and has been reasonably > ?soaked for 2 years. > ? > Given the Freeze date for 8u362-b09 is Dec 23rd, it would be > preferable to get this in earlier than > later, ie. well before the holidays and shutdown. Approved for 8u372 (April CPU). I don't think this one warrants it getting included as a critical fix for 8u362 in January. jdk8u-dev branched for 8u372 in early December. Thanks, Severin From sgehwolf at openjdk.org Mon Dec 19 10:27:48 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 19 Dec 2022 10:27:48 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: <4fyYS-uBqqK7aJeRHwhB2VfIMQaSRrhuIxxQeFxHHXA=.bd7fe504-7364-4ec2-85e6-cef62434d1b7@github.com> On Sun, 18 Dec 2022 17:56:07 GMT, Michal Karm Babacek wrote: >> Lgtm with Severin's recommendations. > > @phohensee @jerboaa Ready ? @Karm For backport bugs please only `/integrate` once you've got approval for push to `jdk11u-dev` on the bug via the `jdk11u-fix-yes` label. See last point in: https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix If you don't yet have JBS access, please provide me with the relevant text and I'll add it on your behalf. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From sgehwolf at openjdk.org Mon Dec 19 10:36:57 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 19 Dec 2022 10:36:57 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v4] In-Reply-To: References: Message-ID: On Sun, 18 Dec 2022 18:00:05 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Adds comment about [JDK-8240666] test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java line 127: > 125: final String expectedRawQuery = "&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz"; > 126: assertEquals(rawQuery, expectedRawQuery); > 127: // [JDK-8240666] Websocket client's OpeningHandshake discards the HTTP response body A better comment would be: `JDK-8240666 is not currently in 11u unlike later JDKs and we, therefore, need to check whether or not a body is present. This is OK as previous assertions verify a fix of JDK-8245245`. Something like that. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From jbhateja at openjdk.org Mon Dec 19 14:05:16 2022 From: jbhateja at openjdk.org (Jatin Bhateja) Date: Mon, 19 Dec 2022 14:05:16 GMT Subject: [jdk17u-dev] Integrated: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 17:41:05 GMT, Jatin Bhateja wrote: > Backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322). > > Due to merge conflicts, original patch could not be auto-merged by bot, only change w.r.t original PR is in > predicate conditions of instruction patterns, in JDK17 vector_length and vector_element_basic_type were static functions defined in AD files which were moved into Matcher class in latest code. > > Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. > > Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. > > Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) This pull request has now been integrated. Changeset: 27b75a87 Author: Jatin Bhateja Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/27b75a87df44560b560a311f96c28de9e1abc1bb Stats: 194 lines in 6 files changed: 189 ins; 4 del; 1 mod 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. Reviewed-by: phh, sviswanathan Backport-of: 38a81913d33c856d64b7c26f934026815a482e43 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/917 From sgehwolf at openjdk.org Mon Dec 19 17:40:50 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 19 Dec 2022 17:40:50 GMT Subject: [jdk11u-dev] RFR: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun Message-ID: Clean backport. Fixes a test issue on some cg v2 systems (podman + crun). ------------- Commit messages: - 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun Changes: https://git.openjdk.org/jdk11u-dev/pull/1602/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1602&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289695 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1602.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1602/head:pull/1602 PR: https://git.openjdk.org/jdk11u-dev/pull/1602 From duke at openjdk.org Mon Dec 19 18:01:44 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Mon, 19 Dec 2022 18:01:44 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: References: Message-ID: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: Replaces a comment about JDK-8240666 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1558/files - new: https://git.openjdk.org/jdk11u-dev/pull/1558/files/401b4528..73066140 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=03-04 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1558.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1558/head:pull/1558 PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Mon Dec 19 18:06:03 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Mon, 19 Dec 2022 18:06:03 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v4] In-Reply-To: References: Message-ID: On Mon, 19 Dec 2022 10:33:54 GMT, Severin Gehwolf wrote: >> Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: >> >> Adds comment about [JDK-8240666] > > test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java line 127: > >> 125: final String expectedRawQuery = "&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz"; >> 126: assertEquals(rawQuery, expectedRawQuery); >> 127: // [JDK-8240666] Websocket client's OpeningHandshake discards the HTTP response body > > A better comment would be: `JDK-8240666 is not currently in 11u unlike later JDKs and we, therefore, need to check whether or not a body is present. This is OK as previous assertions verify a fix of JDK-8245245`. Something like that. Ack. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From clanger at openjdk.org Mon Dec 19 21:45:50 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 21:45:50 GMT Subject: [jdk11u-dev] RFR: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg In-Reply-To: References: Message-ID: On Thu, 15 Dec 2022 18:06:50 GMT, Dhamoder Nalla wrote: >> Lgtm. > >> Lgtm. > Thanks for the review @phohensee @dhanalla For JDK Updates projects, it's not sufficient to get a PR reviewed but you also need maintainer approval. This can be requested by adding the label `jdk11u-fix-request` to the [JBS bug](https://bugs.openjdk.org/browse/JDK-8292863) and adding some request comment, why you want to get this backport/patch in, the risk involved, the testing done etc. Please do so, or, if you don't have a JBS account, please post the request comment here and I can post it in JBS on your behalf. You find a more detailed process description [here](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix) Furthermore, please enable Github Actions on your repository and run the tests to get some basic verification of your patch. Thanks! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1595 From duke at openjdk.org Mon Dec 19 21:54:06 2022 From: duke at openjdk.org (Autumn Capasso) Date: Mon, 19 Dec 2022 21:54:06 GMT Subject: [jdk11u-dev] Integrated: 8256110: Create implementation for NSAccessibilityStepper protocol In-Reply-To: References: Message-ID: <3CUb9cuoC7o-t-3WMCmSVJAASysFLedSPlRNn1-K4oA=.fc14f915-c2a3-4312-989b-a138330b7b8c@github.com> On Wed, 14 Dec 2022 22:42:56 GMT, Autumn Capasso wrote: > Clean backport for oracle parity. This pull request has now been integrated. Changeset: 3990eb25 Author: Autumn Capasso Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/3990eb250749d136f9dbe598fb38b5e9754d9c11 Stats: 131 lines in 5 files changed: 114 ins; 15 del; 2 mod 8256110: Create implementation for NSAccessibilityStepper protocol Backport-of: 5dc5d9401e7a176da53a14293fb59e97b644b31a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1596 From clanger at openjdk.org Mon Dec 19 22:04:49 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 22:04:49 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Sun, 18 Dec 2022 17:56:07 GMT, Michal Karm Babacek wrote: >> Lgtm with Severin's recommendations. > > @phohensee @jerboaa Ready ? @Karm Thanks for contributing this backport to JDK 11 Updates. This looks good to me. As @jerboaa mentioned, the next step would be to add the fix request label and information to the JBS bug. I'd have one further request: Can you please backport your fix for [JDK-8298588](https://bugs.openjdk.org/browse/JDK-8298588) to JDK 20 and JDK17 that we don't miss it out there. For JDK20, you can use the "/backport jdk20" comment on the commit in head. If the backport is clean, which I assume, you can right away integrate as it complies to the RDP1 rules (testfix). For jdk17u-dev, you'll need a PR and maintainer approval by labeling `jdk17u-fix-request` ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From clanger at openjdk.org Mon Dec 19 22:07:48 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 22:07:48 GMT Subject: [jdk11u-dev] RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS In-Reply-To: <8mSRpDNpRMojmF_BRdH9zDhA1GkqqoNWnFe9hdBPFTI=.9dbb474c-990f-45ad-927b-7f1426624944@github.com> References: <8mSRpDNpRMojmF_BRdH9zDhA1GkqqoNWnFe9hdBPFTI=.9dbb474c-990f-45ad-927b-7f1426624944@github.com> Message-ID: On Sat, 17 Dec 2022 02:37:20 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [eff5dafb](https://github.com/openjdk/jdk/commit/eff5dafba9f72bd0612357712ffa472ce1c9166a) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Feb 2022 and was reviewed by Alexey Ivanov and Phil Race. > > The change is not clean because of the context difference caused by the missing [JDK-8211300](https://bugs.openjdk.org/browse/JDK-8211300) in jdk11u-dev. > > Thanks! Marked as reviewed by clanger (Reviewer). You could have used /clean on that one, I guess ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1600 From clanger at openjdk.org Mon Dec 19 22:33:10 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 22:33:10 GMT Subject: [jdk19u] RFR: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 09:19:23 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [51f0a1ce](https://github.com/openjdk/jdk20/commit/51f0a1ce4b0d72cf7e82e01f7014274d8b7d1575) from the [openjdk/jdk20](https://git.openjdk.org/jdk20) repository. > > The commit being backported was authored by Christoph Langer on 14 Dec 2022 and was reviewed by Erik Joelsson. > > Thanks! Just seen that the 19.0.2 timeline has passed. ------------- PR: https://git.openjdk.org/jdk19u/pull/106 From clanger at openjdk.org Mon Dec 19 22:33:10 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 22:33:10 GMT Subject: [jdk19u] Withdrawn: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 09:19:23 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [51f0a1ce](https://github.com/openjdk/jdk20/commit/51f0a1ce4b0d72cf7e82e01f7014274d8b7d1575) from the [openjdk/jdk20](https://git.openjdk.org/jdk20) repository. > > The commit being backported was authored by Christoph Langer on 14 Dec 2022 and was reviewed by Erik Joelsson. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk19u/pull/106 From clanger at openjdk.org Mon Dec 19 22:35:06 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 22:35:06 GMT Subject: [jdk19u] RFR: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 06:52:58 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8298459](https://bugs.openjdk.org/browse/JDK-8298459), commit [d624debe](https://github.com/openjdk/jdk20/commit/d624debe23f60d778d7be43f28d06e9454057217) from the [openjdk/jdk20](https://git.openjdk.org/jdk20) repository. > > The commit being backported was authored by Christoph Langer on 11 Dec 2022 and was reviewed by Erik Joelsson. > > Thanks! 19.0.2 already closed. ------------- PR: https://git.openjdk.org/jdk19u/pull/104 From clanger at openjdk.org Mon Dec 19 22:35:06 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 22:35:06 GMT Subject: [jdk19u] Withdrawn: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation In-Reply-To: References: Message-ID: <4igS3kOHzVtKO1mZwq7z_EWF19jAWt84EaMGtUbxe00=.fd9a8f1e-9233-4f43-a203-7cb47873a266@github.com> On Mon, 12 Dec 2022 06:52:58 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8298459](https://bugs.openjdk.org/browse/JDK-8298459), commit [d624debe](https://github.com/openjdk/jdk20/commit/d624debe23f60d778d7be43f28d06e9454057217) from the [openjdk/jdk20](https://git.openjdk.org/jdk20) repository. > > The commit being backported was authored by Christoph Langer on 11 Dec 2022 and was reviewed by Erik Joelsson. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk19u/pull/104 From clanger at openjdk.org Mon Dec 19 23:04:04 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 23:04:04 GMT Subject: [jdk17u-dev] RFR: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 03:40:09 GMT, Denghui Dong wrote: > This is a backport of JDK-8283870. It's not clean since there doesn't exist jdeprscan_de.properties in 17. > > Some developers need to use this tool to help java 17 migration, so imo it's necessary to backport it. LGTM ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/949 From clanger at openjdk.org Mon Dec 19 23:05:00 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Dec 2022 23:05:00 GMT Subject: [jdk11u-dev] RFR: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de In-Reply-To: <42O0lAuvWpBeKv5Z0kQ9UC5Uok4AIMR0J2HSn17Oz0Q=.14c69e7e-fb6f-4413-9522-748f0808c8b1@github.com> References: <42O0lAuvWpBeKv5Z0kQ9UC5Uok4AIMR0J2HSn17Oz0Q=.14c69e7e-fb6f-4413-9522-748f0808c8b1@github.com> Message-ID: <2E89p3GGV30m_PgWrc2_aCebesxb1ap14SVNTQUs89Y=.b25fe14d-3cb0-4f99-a4dd-78cb026e20b3@github.com> On Mon, 12 Dec 2022 03:27:47 GMT, Denghui Dong wrote: > This is a backport of JDK-8283870. It's not clean since there doesn't exist jdeprscan_de.properties in 11 and the other two files have different contexts caused by the license header. > > Some developers need to use this tool to help java 11 migration, so imo it's necessary to backport it. LGTM ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1585 From gnu.andrew at redhat.com Tue Dec 20 00:41:19 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Tue, 20 Dec 2022 00:41:19 +0000 Subject: Please approve: JDK-8234484 back-port to jdk8u In-Reply-To: <24bd7b0162324e82edb4b096a9486ad673d3b488.camel@redhat.com> References: <24bd7b0162324e82edb4b096a9486ad673d3b488.camel@redhat.com> Message-ID: On 10:51 Mon 19 Dec , Severin Gehwolf wrote: > On Sun, 2022-12-18 at 18:56 +0000, Kumar Srinivasan wrote: > > + added Vyom Tewari who did the heavy lifting. > > ? > > From:Kumar Srinivasan > > Date: Sunday, December 18, 2022 at 10:55 AM > > To: jdk8u-dev at openjdk.org , > > jdk-updates-dev at openjdk.org > > Subject: Please approve: JDK-8234484 back-port to jdk8u > > Hi jdk8 approvers, > > ? > > Can someone please approve the back-port of JDK-8234484 ? a CSR has > > been obtained for the back-port. > > ? > > The fix has been in jdk15+ for some time now and has been reasonably > > ?soaked for 2 years. > > ? > > Given the Freeze date for 8u362-b09 is Dec 23rd, it would be > > preferable to get this in earlier than > > later, ie. well before the holidays and shutdown. > > Approved for 8u372 (April CPU). I don't think this one warrants it > getting included as a critical fix for 8u362 in January. jdk8u-dev > branched for 8u372 in early December. > > Thanks, > Severin > I concur. 8u362 is currently in rampdown and only open for time-critical fixes and regressions from 8u352. An enhancement that warrants a CSR certainly doesn't meet that criteria. Why has this not been backported to 11u first? This will now an inconsistency between the three LTS releases (8u & 17u with the behaviour, 11u without). This should be rectified. Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From serb at openjdk.org Tue Dec 20 01:11:49 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 20 Dec 2022 01:11:49 GMT Subject: [jdk11u-dev] Integrated: 8274939: Incorrect size of the pixel storage is used by the robot on macOS In-Reply-To: <8mSRpDNpRMojmF_BRdH9zDhA1GkqqoNWnFe9hdBPFTI=.9dbb474c-990f-45ad-927b-7f1426624944@github.com> References: <8mSRpDNpRMojmF_BRdH9zDhA1GkqqoNWnFe9hdBPFTI=.9dbb474c-990f-45ad-927b-7f1426624944@github.com> Message-ID: On Sat, 17 Dec 2022 02:37:20 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [eff5dafb](https://github.com/openjdk/jdk/commit/eff5dafba9f72bd0612357712ffa472ce1c9166a) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Feb 2022 and was reviewed by Alexey Ivanov and Phil Race. > > The change is not clean because of the context difference caused by the missing [JDK-8211300](https://bugs.openjdk.org/browse/JDK-8211300) in jdk11u-dev. > > Thanks! This pull request has now been integrated. Changeset: 1acc508f Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/1acc508f2ec2c575be683557ce08c19699d73830 Stats: 12 lines in 3 files changed: 7 ins; 0 del; 5 mod 8274939: Incorrect size of the pixel storage is used by the robot on macOS Reviewed-by: clanger Backport-of: eff5dafba9f72bd0612357712ffa472ce1c9166a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1600 From serb at openjdk.org Tue Dec 20 01:17:05 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 20 Dec 2022 01:17:05 GMT Subject: [jdk11u-dev] RFR: 8238936: The crash in XRobotPeer when the custom GraphicsDevice is used [v2] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/9d0a4875d75421e416747271e3f229d068cf0dd0 from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > Backport is clean, but I had to change the dates and imports. The new test is passed after the fix, and no new issues were found by the jdk_desktop tests. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into mrserb-backport-9d0a4875 - Backport 9d0a4875d75421e416747271e3f229d068cf0dd0 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1601/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1601&range=01 Stats: 288 lines in 9 files changed: 216 ins; 37 del; 35 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1601.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1601/head:pull/1601 PR: https://git.openjdk.org/jdk11u-dev/pull/1601 From mbaesken at openjdk.org Tue Dec 20 08:23:49 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 20 Dec 2022 08:23:49 GMT Subject: [jdk11u-dev] RFR: 8244592: Start supporting SOURCE_DATE_EPOCH In-Reply-To: References: Message-ID: On Thu, 15 Dec 2022 07:50:13 GMT, Christoph Langer wrote: > After the backport of [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679), a non-debug build on Windows in a build directory that's outside the repository will fail. The problem unveiled by the backport is that in those builds, the `ALLOW_ABSOLUTE_PATHS_IN_OUTPUT` flag is set to false, causing the code [here](https://github.com/openjdk/jdk11u-dev/blob/12eca2f8ac6e8127f1d698aef50db03cf278a7b8/make/common/NativeCompilation.gmk#L220) to relativize the make command. This seemed to have worked fine with the old fixpath before [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) but now it breaks the build. > In later releases, we get new code by [JDK-8256240](https://bugs.openjdk.org/browse/JDK-8256240) that removes the absolute paths on Windows by setting a new compiler option. After the change, `FILE_MACRO_CFLAGS` is set (e.g. [here](https://github.com/openjdk/jdk17u-dev/blob/399a52dccb2a53a4309fdff479a14d944829cd54/make/autoconf/flags-cflags.m4#L823)) which will cause MakeCommandRelative to not relativize the paths in NativeCompilation.gmk. > > I propose to backport this behavior to jdk11u by backporting [JDK-8244592 Start supporting SOURCE_DATE_EPOCH](https://bugs.openjdk.org/browse/JDK-8244592) and [JDK-8256240 Reproducible builds should turn on the "deterministic" flag for Visual Studio](https://bugs.openjdk.org/browse/JDK-8256240). This will bring some functionality of reproducible builds to jdk11u. I don't see an issue with that, since the behavior is off by default. The only larger risk I see is whether the newly used Visual Studio compiler options could break existing downstream builds on older VS versions. However, if such a thing occurs, we could add a condition to fall back to the old behavior then. > > As for this backport: > I bring in a part of [JDK-8240820](https://bugs.openjdk.org/browse/JDK-8240820), namely the new configure function `UTIL_ARG_ENABLE` which is used by [JDK-8244592](https://bugs.openjdk.org/browse/JDK-8244592). Furthermore I incorporated the changes to jdk-options.m4 of the already backported [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679), which didn't fit at that time. LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1597 From serb at openjdk.org Tue Dec 20 08:57:00 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 20 Dec 2022 08:57:00 GMT Subject: [jdk11u-dev] Integrated: 8238936: The crash in XRobotPeer when the custom GraphicsDevice is used In-Reply-To: References: Message-ID: On Sun, 18 Dec 2022 02:34:33 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/9d0a4875d75421e416747271e3f229d068cf0dd0 from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > Backport is clean, but I had to change the dates and imports. The new test is passed after the fix, and no new issues were found by the jdk_desktop tests. This pull request has now been integrated. Changeset: dba30227 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/dba30227215ba29e0d469bd1938f186993f9d64e Stats: 288 lines in 9 files changed: 216 ins; 37 del; 35 mod 8238936: The crash in XRobotPeer when the custom GraphicsDevice is used Backport-of: 9d0a4875d75421e416747271e3f229d068cf0dd0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1601 From sgehwolf at openjdk.org Tue Dec 20 10:26:49 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Dec 2022 10:26:49 GMT Subject: [jdk11u-dev] Integrated: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun In-Reply-To: References: Message-ID: On Mon, 19 Dec 2022 17:32:22 GMT, Severin Gehwolf wrote: > Clean backport. Fixes a test issue on some cg v2 systems (podman + crun). This pull request has now been integrated. Changeset: 2a5ae36d Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/2a5ae36da24ff39c1e531951e83072bb9f4aafb8 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun Backport-of: ac6be165196457a26d837760b5f5030fe010d633 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1602 From rmarchenko at openjdk.org Tue Dec 20 10:45:55 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Tue, 20 Dec 2022 10:45:55 GMT Subject: [jdk11u-dev] Integrated: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 09:32:44 GMT, Roman Marchenko wrote: > Clean backport > > JDK11 has the same issue with processing host names for SNI. It'd be good to keep JDK11 up to date with the upstream. No risks. > > Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs > > - #1575 > - #1576 This pull request has now been integrated. Changeset: 31b51844 Author: Roman Marchenko Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk11u-dev/commit/31b51844bca9904d34f4d8eb7540a9014f657cdb Stats: 616 lines in 4 files changed: 613 ins; 0 del; 3 mod 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled Backport-of: a95ee5ada230a0177517efd3a417f319066169dd ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1574 From rmarchenko at openjdk.org Tue Dec 20 10:53:20 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Tue, 20 Dec 2022 10:53:20 GMT Subject: [jdk11u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v2] In-Reply-To: <44c22Q6fNW511vUhu86NDv6nWwXSh0PqdaF2Qp-WuNU=.7c1c1a2c-f399-442d-8c33-7aac292f256e@github.com> References: <44c22Q6fNW511vUhu86NDv6nWwXSh0PqdaF2Qp-WuNU=.7c1c1a2c-f399-442d-8c33-7aac292f256e@github.com> Message-ID: <3G8-Fa0-wmimHyJTCItDQs6B9Y5RW5lCB6VTRFjCsVU=.5eb09f01-cc70-45bb-9712-cc0974fee58d@github.com> > Clean backport > > Please note that this PR is a part of dependant PR chain: > > - Prev PR: #1574 > - Next PR: #1576 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1575/files - new: https://git.openjdk.org/jdk11u-dev/pull/1575/files/19de0717..19de0717 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1575&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1575&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1575.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1575/head:pull/1575 PR: https://git.openjdk.org/jdk11u-dev/pull/1575 From sgehwolf at openjdk.org Tue Dec 20 11:32:54 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Dec 2022 11:32:54 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Mon, 19 Dec 2022 22:02:35 GMT, Christoph Langer wrote: > For JDK20, you can use the "/backport jdk20" comment on the commit in head. I think that's only available for committers. Just FYI. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Tue Dec 20 11:53:56 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Tue, 20 Dec 2022 11:53:56 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 11:29:53 GMT, Severin Gehwolf wrote: > > For JDK20, you can use the "/backport jdk20" comment on the commit in head. > > I think that's only available for committers. Just FYI. It is. I tried that the other day: https://github.com/openjdk/jdk/commit/c07ce7eec71aefbd3cb624e03ca53f5148d01f19#commitcomment-91811154 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From goetz at openjdk.org Tue Dec 20 12:09:17 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Dec 2022 12:09:17 GMT Subject: [jdk17u-dev] RFR: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 03:40:09 GMT, Denghui Dong wrote: > This is a backport of JDK-8283870. It's not clean since there doesn't exist jdeprscan_de.properties in 17. > > Some developers need to use this tool to help java 17 migration, so imo it's necessary to backport it. Hi @D-D-H can you please enable the pre-submit tests! Thanks. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/949 From rmarchenko at openjdk.org Tue Dec 20 12:18:20 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Tue, 20 Dec 2022 12:18:20 GMT Subject: [jdk11u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2] In-Reply-To: References: Message-ID: > Clean backport > > Please note that this PR is a part of dependant PR chain > > Prev PRs: > - #1574 > - #1575 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1576/files - new: https://git.openjdk.org/jdk11u-dev/pull/1576/files/c92d93e5..c92d93e5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1576&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1576&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1576.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1576/head:pull/1576 PR: https://git.openjdk.org/jdk11u-dev/pull/1576 From rmarchenko at openjdk.org Tue Dec 20 12:18:47 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Tue, 20 Dec 2022 12:18:47 GMT Subject: [jdk11u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v3] In-Reply-To: <44c22Q6fNW511vUhu86NDv6nWwXSh0PqdaF2Qp-WuNU=.7c1c1a2c-f399-442d-8c33-7aac292f256e@github.com> References: <44c22Q6fNW511vUhu86NDv6nWwXSh0PqdaF2Qp-WuNU=.7c1c1a2c-f399-442d-8c33-7aac292f256e@github.com> Message-ID: > Clean backport > > Please note that this PR is a part of dependant PR chain: > > - Prev PR: #1574 > - Next PR: #1576 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1575/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1575&range=02 Stats: 202 lines in 2 files changed: 30 ins; 2 del; 170 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1575.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1575/head:pull/1575 PR: https://git.openjdk.org/jdk11u-dev/pull/1575 From duke at openjdk.org Tue Dec 20 12:40:05 2022 From: duke at openjdk.org (duke) Date: Tue, 20 Dec 2022 12:40:05 GMT Subject: [jdk17u-dev] Withdrawn: 8253779: Amalloc may be wasting space by overaligning In-Reply-To: References: Message-ID: On Mon, 24 Oct 2022 15:17:24 GMT, Thomas Stuefe wrote: > One in a small chain of patches improving memory footprint of arena memory. > > This pull request contains a backport of commit [ac75a53f](https://github.com/openjdk/jdk/commit/ac75a53fc513cce2a1aa266f0b7235d150a76c01) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Coleen Phillimore on 11 Jul 2021 and was reviewed by Kim Barrett and Thomas Stuefe. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/823 From ddong at openjdk.org Tue Dec 20 14:32:15 2022 From: ddong at openjdk.org (Denghui Dong) Date: Tue, 20 Dec 2022 14:32:15 GMT Subject: [jdk17u-dev] RFR: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 12:05:49 GMT, Goetz Lindenmaier wrote: >> This is a backport of JDK-8283870. It's not clean since there doesn't exist jdeprscan_de.properties in 17. >> >> Some developers need to use this tool to help java 17 migration, so imo it's necessary to backport it. > > Hi @D-D-H > can you please enable the pre-submit tests! > Thanks. Hi @GoeLin , Thanks for the reminder. I have enabled the workflow, and it's running now. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/949 From avoitylov at openjdk.org Tue Dec 20 14:32:37 2022 From: avoitylov at openjdk.org (Aleksei Voitylov) Date: Tue, 20 Dec 2022 14:32:37 GMT Subject: [jdk17u-dev] RFR: 8288005: HotSpot build with disabled PCH fails for Windows AArch64 Message-ID: This backport fixes non-PCH builds on Windows AArch64 which helps Windows AArch64 builds reproducibility on VS2019+. This is a clean backport. ------------- Commit messages: - backport of JDK-8288005 Changes: https://git.openjdk.org/jdk17u-dev/pull/956/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=956&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288005 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/956.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/956/head:pull/956 PR: https://git.openjdk.org/jdk17u-dev/pull/956 From duke at openjdk.org Tue Dec 20 15:44:02 2022 From: duke at openjdk.org (Stewart X Addison) Date: Tue, 20 Dec 2022 15:44:02 GMT Subject: [jdk17u-dev] RFR: JDK-8298726: Backport 5f63f7a (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds Message-ID: This is a clean backport of https://github.com/openjdk/jdk/pull/11665 which fixes a compliance issue on AIX. Relevant issue: https://bugs.openjdk.org/browse/JDK-8298726 ------------- Commit messages: - Backport 5f63f7a Changes: https://git.openjdk.org/jdk17u-dev/pull/957/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=957&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298726 Stats: 15 lines in 1 file changed: 2 ins; 4 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/957.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/957/head:pull/957 PR: https://git.openjdk.org/jdk17u-dev/pull/957 From clanger at openjdk.org Tue Dec 20 16:08:57 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 20 Dec 2022 16:08:57 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> Message-ID: On Mon, 19 Dec 2022 18:01:44 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Replaces a comment about JDK-8240666 OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)... ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From clanger at openjdk.org Tue Dec 20 16:15:08 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 20 Dec 2022 16:15:08 GMT Subject: [jdk17u] RFR: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: <3A7ZV1m3rMDGWr0eJphyeYQtwkblsmZlUTnwO2Tsgy0=.34d94c6c-50f8-43b8-b7b2-066172055e9c@github.com> References: <3A7ZV1m3rMDGWr0eJphyeYQtwkblsmZlUTnwO2Tsgy0=.34d94c6c-50f8-43b8-b7b2-066172055e9c@github.com> Message-ID: On Wed, 14 Dec 2022 09:30:07 GMT, Christoph Langer wrote: > Needed to resolve due to missing change for RISCV support. not urgent as latest cygwin fixed the output again. We can backport this to jdk17u-dev. ------------- PR: https://git.openjdk.org/jdk17u/pull/362 From clanger at openjdk.org Tue Dec 20 16:15:08 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 20 Dec 2022 16:15:08 GMT Subject: [jdk17u] Withdrawn: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: <3A7ZV1m3rMDGWr0eJphyeYQtwkblsmZlUTnwO2Tsgy0=.34d94c6c-50f8-43b8-b7b2-066172055e9c@github.com> References: <3A7ZV1m3rMDGWr0eJphyeYQtwkblsmZlUTnwO2Tsgy0=.34d94c6c-50f8-43b8-b7b2-066172055e9c@github.com> Message-ID: On Wed, 14 Dec 2022 09:30:07 GMT, Christoph Langer wrote: > Needed to resolve due to missing change for RISCV support. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u/pull/362 From clanger at openjdk.org Tue Dec 20 16:16:44 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 20 Dec 2022 16:16:44 GMT Subject: [jdk17u-dev] RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body Message-ID: Hi all, This pull request contains a backport of [JDK-8298588](https://bugs.openjdk.org/browse/JDK-8298588), commit [909d0cb4](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Michal Karm Babacek on 16 Dec 2022 and was reviewed by Daniel Fuchs. Thanks! ------------- Commit messages: - Backport 909d0cb4d9475fd367b8bc64a6b50c5a324e9a01 Changes: https://git.openjdk.org/jdk17u-dev/pull/958/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=958&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298588 Stats: 16 lines in 1 file changed: 7 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/958.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/958/head:pull/958 PR: https://git.openjdk.org/jdk17u-dev/pull/958 From clanger at openjdk.org Tue Dec 20 17:16:42 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 20 Dec 2022 17:16:42 GMT Subject: [jdk17u-dev] RFR: 8298527: Cygwin's uname -m returns different string than before Message-ID: Backport of a small build system fix/cleanup. I had to resolve because RISCV was not handled in jdk17u-dev yet. For this backport, in the new code, I chose to leave the RISCV branch in. It should do no harm. ------------- Commit messages: - Backport 51f0a1ce4b0d72cf7e82e01f7014274d8b7d1575 Changes: https://git.openjdk.org/jdk17u-dev/pull/959/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=959&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298527 Stats: 64 lines in 1 file changed: 33 ins; 30 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/959.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/959/head:pull/959 PR: https://git.openjdk.org/jdk17u-dev/pull/959 From andrew at openjdk.org Tue Dec 20 18:08:59 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 20 Dec 2022 18:08:59 GMT Subject: [jdk17u-dev] RFR: 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 15:30:32 GMT, Stewart X Addison wrote: > This is a clean backport of https://github.com/openjdk/jdk/pull/11665 which fixes a compliance issue on AIX. > Relevant issue: https://bugs.openjdk.org/browse/JDK-8298726 Looks good to me. Approved for 17u. ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/957 From andrew at openjdk.org Tue Dec 20 18:16:55 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 20 Dec 2022 18:16:55 GMT Subject: [jdk15u-dev] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Mon, 19 Dec 2022 07:16:25 GMT, Yuri Nesterenko wrote: > Thank you, @gnu-andrew ! Marked jdk15u-fix-yes. Sorry I was away for a week. Hope you will integrate before Dec 21-th; otherwise we'll change repository to jdk15u and label to critical. No worries and thanks for the approval. I'll integrate now. I also have 13u in the pipeline. Should I target that to jdk13u or is there still time to get it in via jdk13u-dev? Should have a PR ready in the next few hours. ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/317 From andrew at openjdk.org Tue Dec 20 18:16:56 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 20 Dec 2022 18:16:56 GMT Subject: [jdk15u-dev] Integrated: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Wed, 14 Dec 2022 16:04:37 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass. > > Thanks! This pull request has now been integrated. Changeset: 5c1a24f7 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk15u-dev/commit/5c1a24f7da08764cac971b887f275b1e55e201eb Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod 8297804: (tz) Update Timezone Data to 2022g Backport-of: ce896731d38866c2bf99cd49525062e150d94160 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/317 From duke at openjdk.org Tue Dec 20 18:29:38 2022 From: duke at openjdk.org (Joshua Cao) Date: Tue, 20 Dec 2022 18:29:38 GMT Subject: [jdk11u-dev] RFR: 8221621: FindTests.gmk cannot handle "=" in TEST.groups comments Message-ID: clean backport ------------- Commit messages: - 8221621: FindTests.gmk cannot handle "=" in TEST.groups comments Changes: https://git.openjdk.org/jdk11u-dev/pull/1603/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1603&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8221621 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1603.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1603/head:pull/1603 PR: https://git.openjdk.org/jdk11u-dev/pull/1603 From duke at openjdk.org Tue Dec 20 18:45:28 2022 From: duke at openjdk.org (Joshua Cao) Date: Tue, 20 Dec 2022 18:45:28 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook Message-ID: This fixes a crash in JDK 11. Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1603 Commit messages: - 8221621: Crash in KlassFactory::check_shared_class_file_load_hook - 8221621: FindTests.gmk cannot handle "=" in TEST.groups comments Changes: https://git.openjdk.org/jdk11u-dev/pull/1604/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1604&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8221351 Stats: 119 lines in 12 files changed: 86 ins; 17 del; 16 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1604.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1604/head:pull/1604 PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From duke at openjdk.org Tue Dec 20 18:45:28 2022 From: duke at openjdk.org (Joshua Cao) Date: Tue, 20 Dec 2022 18:45:28 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook In-Reply-To: References: Message-ID: <4GVPTKdRtIOh4jdNh1rsdImhzMsJfd57wSGmyjbTupM=.0c6e8695-46b8-4ea6-8981-cdbc04ea1b71@github.com> On Tue, 20 Dec 2022 18:34:28 GMT, Joshua Cao wrote: > This fixes a crash in JDK 11. > > Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. I entered in the wrong commit ID the first time. I just edited the PR title, but not sure if the bots will fix things. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From duke at openjdk.org Tue Dec 20 18:49:48 2022 From: duke at openjdk.org (Joshua Cao) Date: Tue, 20 Dec 2022 18:49:48 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:34:28 GMT, Joshua Cao wrote: > This fixes a crash in JDK 11. > > Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. looks like the bot is smart! the PR info looks correct now ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From mdoerr at openjdk.org Tue Dec 20 22:42:52 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Dec 2022 22:42:52 GMT Subject: [jdk17u-dev] RFR: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic [v2] In-Reply-To: References: Message-ID: > Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: > The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). > Includes trivial fix for [JDK-8298947](https://bugs.openjdk.org/browse/JDK-8298947) Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: Backport 3d4d9fd6e6de037950f94482d4e33f178eb15daa ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/951/files - new: https://git.openjdk.org/jdk17u-dev/pull/951/files/8f833de1..24a54993 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=951&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=951&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/951.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/951/head:pull/951 PR: https://git.openjdk.org/jdk17u-dev/pull/951 From andrew at openjdk.org Wed Dec 21 03:52:57 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 21 Dec 2022 03:52:57 GMT Subject: [jdk15u-dev] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:12:35 GMT, Andrew John Hughes wrote: > > Thank you, @gnu-andrew ! Marked jdk15u-fix-yes. Sorry I was away for a week. Hope you will integrate before Dec 21-th; otherwise we'll change repository to jdk15u and label to critical. > > No worries and thanks for the approval. I'll integrate now. > > I also have 13u in the pipeline. Should I target that to jdk13u or is there still time to get it in via jdk13u-dev? Should have a PR ready in the next few hours. 13u: https://github.com/openjdk/jdk13u-dev/pull/444 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/317 From andrew at openjdk.org Wed Dec 21 03:58:51 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 21 Dec 2022 03:58:51 GMT Subject: [jdk13u-dev] RFR: 8297804: (tz) Update Timezone Data to 2022g Message-ID: Clean backport of the latest tzdata update. This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass. Thanks! ------------- Commit messages: - Backport ce896731d38866c2bf99cd49525062e150d94160 Changes: https://git.openjdk.org/jdk13u-dev/pull/444/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=444&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297804 Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/444.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/444/head:pull/444 PR: https://git.openjdk.org/jdk13u-dev/pull/444 From ddong at openjdk.org Wed Dec 21 06:33:03 2022 From: ddong at openjdk.org (Denghui Dong) Date: Wed, 21 Dec 2022 06:33:03 GMT Subject: [jdk17u-dev] Integrated: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de In-Reply-To: References: Message-ID: On Mon, 12 Dec 2022 03:40:09 GMT, Denghui Dong wrote: > This is a backport of JDK-8283870. It's not clean since there doesn't exist jdeprscan_de.properties in 17. > > Some developers need to use this tool to help java 17 migration, so imo it's necessary to backport it. This pull request has now been integrated. Changeset: 4634a653 Author: Denghui Dong Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/4634a6534732683d599546f6f8b5d6d4cc418c1e Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de Reviewed-by: clanger Backport-of: ef25e189c7f987b6c7b049ce481ee832cc7f70aa ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/949 From ddong at openjdk.org Wed Dec 21 06:35:54 2022 From: ddong at openjdk.org (Denghui Dong) Date: Wed, 21 Dec 2022 06:35:54 GMT Subject: [jdk11u-dev] Integrated: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de In-Reply-To: <42O0lAuvWpBeKv5Z0kQ9UC5Uok4AIMR0J2HSn17Oz0Q=.14c69e7e-fb6f-4413-9522-748f0808c8b1@github.com> References: <42O0lAuvWpBeKv5Z0kQ9UC5Uok4AIMR0J2HSn17Oz0Q=.14c69e7e-fb6f-4413-9522-748f0808c8b1@github.com> Message-ID: On Mon, 12 Dec 2022 03:27:47 GMT, Denghui Dong wrote: > This is a backport of JDK-8283870. It's not clean since there doesn't exist jdeprscan_de.properties in 11 and the other two files have different contexts caused by the license header. > > Some developers need to use this tool to help java 11 migration, so imo it's necessary to backport it. This pull request has now been integrated. Changeset: 6a4603f8 Author: Denghui Dong Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/6a4603f829bbb293575b1fbab126231fec9a6f67 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de Reviewed-by: clanger Backport-of: ef25e189c7f987b6c7b049ce481ee832cc7f70aa ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1585 From yan at openjdk.org Wed Dec 21 06:35:55 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 21 Dec 2022 06:35:55 GMT Subject: [jdk13u-dev] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 03:48:57 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass. > > Thanks! Thank you! This PR will be likely the last one in jdk13u-dev. I'll close it just after your integration. ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/444 From goetz at openjdk.org Wed Dec 21 07:44:16 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Dec 2022 07:44:16 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: <60_UZQCyPoLOeV7tiSjKdsJiAAqEfLmf2cgdPIgTG1U=.4610efe3-5059-4bd2-8bcf-c0ad6f5af7b7@github.com> Merge build tag 17.0.6+8 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8297804: (tz) Update Timezone Data to 2022g The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/960/files Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/960.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/960/head:pull/960 PR: https://git.openjdk.org/jdk17u-dev/pull/960 From mbaesken at openjdk.org Wed Dec 21 08:18:07 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 21 Dec 2022 08:18:07 GMT Subject: [jdk17u-dev] RFR: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 17:09:53 GMT, Christoph Langer wrote: > Backport of a small build system fix/cleanup. I had to resolve because RISCV was not handled in jdk17u-dev yet. > For this backport, in the new code, I chose to leave the RISCV branch in. It should do no harm. LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/959 From goetz at openjdk.org Wed Dec 21 08:20:57 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Dec 2022 08:20:57 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.18+8 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8298737: 8296772 backport to jdk11u caused build error on sparc - 8297804: (tz) Update Timezone Data to 2022g The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/1605/files Stats: 244 lines in 27 files changed: 148 ins; 57 del; 39 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1605.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1605/head:pull/1605 PR: https://git.openjdk.org/jdk11u-dev/pull/1605 From goetz at openjdk.org Wed Dec 21 08:20:59 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Dec 2022 08:20:59 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: <60_UZQCyPoLOeV7tiSjKdsJiAAqEfLmf2cgdPIgTG1U=.4610efe3-5059-4bd2-8bcf-c0ad6f5af7b7@github.com> References: <60_UZQCyPoLOeV7tiSjKdsJiAAqEfLmf2cgdPIgTG1U=.4610efe3-5059-4bd2-8bcf-c0ad6f5af7b7@github.com> Message-ID: On Wed, 21 Dec 2022 07:37:51 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.6+8 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: c9d12d41 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c9d12d419f3edd6ee9a3da3786493e2f9a47a0b7 Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/960 From clanger at openjdk.org Wed Dec 21 09:09:49 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 21 Dec 2022 09:09:49 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:34:28 GMT, Joshua Cao wrote: > This fixes a crash in JDK 11. > > Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. Looks good but you should resolve the copyright in test/hotspot/jtreg/runtime/appcds/customLoader/HelloCustom.java to 2019. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From goetz at openjdk.org Wed Dec 21 09:12:57 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Dec 2022 09:12:57 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 08:14:09 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.18+8 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: c356873b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/c356873bff042eb42a4eeaf86ce0886b18a5f72c Stats: 244 lines in 27 files changed: 148 ins; 57 del; 39 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1605 From yan at azul.com Wed Dec 21 09:11:18 2022 From: yan at azul.com (Yuri Nesterenko) Date: Wed, 21 Dec 2022 12:11:18 +0300 Subject: [15u notice] jdk15u-dev closed Message-ID: Hi, note that repository https://github.com/openjdk/jdk15u-dev is closed in 15.0.10 state. No new release number exists as of now. Any change targeted to that January release of jdk15u should be labeled jdk15u-critical-request in JBS and will go directly to https://github.com/openjdk/jdk15u. Thank you! --yan From mbaesken at openjdk.org Wed Dec 21 09:22:50 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 21 Dec 2022 09:22:50 GMT Subject: [jdk17u-dev] RFR: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved Message-ID: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved ------------- Commit messages: - Backport d6e2d0d03d2161f934474fa1d4299513d14cb9c5 Changes: https://git.openjdk.org/jdk17u-dev/pull/961/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=961&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296611 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/961.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/961/head:pull/961 PR: https://git.openjdk.org/jdk17u-dev/pull/961 From mbaesken at openjdk.org Wed Dec 21 09:32:43 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 21 Dec 2022 09:32:43 GMT Subject: [jdk11u-dev] RFR: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved Message-ID: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved ------------- Commit messages: - Backport d6e2d0d03d2161f934474fa1d4299513d14cb9c5 Changes: https://git.openjdk.org/jdk11u-dev/pull/1606/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1606&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296611 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1606.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1606/head:pull/1606 PR: https://git.openjdk.org/jdk11u-dev/pull/1606 From duke at openjdk.org Wed Dec 21 09:44:49 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Wed, 21 Dec 2022 09:44:49 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> Message-ID: On Mon, 19 Dec 2022 18:01:44 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Replaces a comment about JDK-8240666 Thanks, lemme process it today. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Wed Dec 21 10:08:49 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Wed, 21 Dec 2022 10:08:49 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 11:29:53 GMT, Severin Gehwolf wrote: >> @Karm Thanks for contributing this backport to JDK 11 Updates. This looks good to me. As @jerboaa mentioned, the next step would be to add the fix request label and information to the JBS bug. >> >> I'd have one further request: Can you please backport your fix for [JDK-8298588](https://bugs.openjdk.org/browse/JDK-8298588) to JDK 20 and JDK17 that we don't miss it out there. For JDK20, you can use the "/backport jdk20" comment on the commit in head. If the backport is clean, which I assume, you can right away integrate as it complies to the RDP1 rules (testfix). For jdk17u-dev, you'll need a PR and maintainer approval by labeling `jdk17u-fix-request` > >> For JDK20, you can use the "/backport jdk20" comment on the commit in head. > > I think that's only available for committers. Just FYI. Hello, @jerboaa, This is the JBS text proposal, formatted for JIRA: I would like [JDK-8245245|https://bugs.openjdk.org/browse/JDK-8245245] to get backported to JDK 11 so as more libraries can start using JDK's own WebSocket client instead of depending on other implementations. For instance, [Fabric8 Kubernetes client|https://github.com/fabric8io/kubernetes-client/blob/master/httpclient-jdk/README.md#jdk-client-for-fabric8] has this very issue with JDK's WebSocket client and it uses OkHttp3 or Vert.x implementations instead. I used these [JBang|https://www.jbang.dev/] scripts to briefly showcase that both Vert.x and OkHttp3 implementations are fine running on JDK 11 and JDK 11's WebSocket client needs fixing: (It uses Undertow as the server) [JDKClient.java|https://gist.github.com/Karm/58959f7bc1d3ef675eecd1e12e56094c] [OKHttp3Client.java|https://gist.github.com/Karm/6ed845a22a8b8331f95292bb992ee7e0] [VertXClient.java|https://gist.github.com/Karm/a04a778f352e8d29667eb38a219d4e4b] {code} $ java --version openjdk 11.0.17 2022-10-18 $ ./JDKClient.java [jbang] Building jar... The query string was: &raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz $ ./OKHttp3Client.java [jbang] Building jar... The query string was: raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz $ ./VertXClient.java [jbang] Building jar... The query string was: raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz {code} Patched, see the JDK client fixed: {code} $ java --version openjdk 11.0.255-internal 2023-01-17 $ ./JDKClient.java The query string was: &raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz $ ./OKHttp3Client.java The query string was: raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz $ ./VertXClient.java The query string was: raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz {code} Thanks K. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From rmarchenko at openjdk.org Wed Dec 21 11:00:58 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 21 Dec 2022 11:00:58 GMT Subject: [jdk11u-dev] Integrated: 8282398: EndingDotHostname.java test fails because SSL cert expired In-Reply-To: <44c22Q6fNW511vUhu86NDv6nWwXSh0PqdaF2Qp-WuNU=.7c1c1a2c-f399-442d-8c33-7aac292f256e@github.com> References: <44c22Q6fNW511vUhu86NDv6nWwXSh0PqdaF2Qp-WuNU=.7c1c1a2c-f399-442d-8c33-7aac292f256e@github.com> Message-ID: On Fri, 9 Dec 2022 09:47:21 GMT, Roman Marchenko wrote: > Clean backport > > Please note that this PR is a part of dependant PR chain: > > - Prev PR: #1574 > - Next PR: #1576 This pull request has now been integrated. Changeset: a3d05229 Author: Roman Marchenko Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk11u-dev/commit/a3d052291069ab18e63f41ba2884d7fb416c3f53 Stats: 202 lines in 2 files changed: 30 ins; 2 del; 170 mod 8282398: EndingDotHostname.java test fails because SSL cert expired Backport-of: afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1575 From goetz at openjdk.org Wed Dec 21 11:07:35 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Dec 2022 11:07:35 GMT Subject: [jdk17u-dev] RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 46684a4efa165d97c0ef8f56248ee82003acdb7b Changes: https://git.openjdk.org/jdk17u-dev/pull/962/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=962&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8262386 Stats: 84 lines in 2 files changed: 57 ins; 5 del; 22 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/962.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/962/head:pull/962 PR: https://git.openjdk.org/jdk17u-dev/pull/962 From rmarchenko at openjdk.org Wed Dec 21 11:19:34 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 21 Dec 2022 11:19:34 GMT Subject: [jdk11u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3] In-Reply-To: References: Message-ID: > Clean backport > > Please note that this PR is a part of dependant PR chain > > Prev PRs: > - #1574 > - #1575 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 268fa693188b685de6289927ee5a1e99473a50f6 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1576/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1576&range=02 Stats: 218 lines in 2 files changed: 37 ins; 2 del; 179 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1576.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1576/head:pull/1576 PR: https://git.openjdk.org/jdk11u-dev/pull/1576 From mbaesken at openjdk.org Wed Dec 21 12:59:50 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 21 Dec 2022 12:59:50 GMT Subject: [jdk11u-dev] Integrated: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 09:25:20 GMT, Matthias Baesken wrote: > 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved This pull request has now been integrated. Changeset: 23aeca9b Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/23aeca9be6ee296aa96dddd9dc16b5a761ff91d5 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved Backport-of: d6e2d0d03d2161f934474fa1d4299513d14cb9c5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1606 From mbaesken at openjdk.org Wed Dec 21 12:59:56 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 21 Dec 2022 12:59:56 GMT Subject: [jdk17u-dev] Integrated: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 09:13:22 GMT, Matthias Baesken wrote: > 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved This pull request has now been integrated. Changeset: a11f38a1 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/a11f38a14e9911082930c6d0e68361eae15a8ec4 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved Backport-of: d6e2d0d03d2161f934474fa1d4299513d14cb9c5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/961 From sgehwolf at openjdk.org Wed Dec 21 14:27:50 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 21 Dec 2022 14:27:50 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> Message-ID: On Mon, 19 Dec 2022 18:01:44 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Replaces a comment about JDK-8240666 Seems OK to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Wed Dec 21 16:16:59 2022 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 21 Dec 2022 16:16:59 GMT Subject: [jdk17u-dev] Integrated: 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 15:30:32 GMT, Stewart X Addison wrote: > This is a clean backport of https://github.com/openjdk/jdk/pull/11665 which fixes a compliance issue on AIX. > Relevant issue: https://bugs.openjdk.org/browse/JDK-8298726 This pull request has now been integrated. Changeset: d5e0d44e Author: Alan Bateman Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/d5e0d44e2aade89b542b3d1700aed42d345b71c6 Stats: 15 lines in 1 file changed: 2 ins; 4 del; 9 mod 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds Reviewed-by: andrew Backport-of: 5f63f7a742a1071a87ca69463bae6e04a44fe462 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/957 From andrew at openjdk.org Wed Dec 21 16:24:59 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 21 Dec 2022 16:24:59 GMT Subject: [jdk13u-dev] RFR: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 06:33:32 GMT, Yuri Nesterenko wrote: > Thank you! This PR will be likely the last one in jdk13u-dev. I'll close it just after your integration. Thanks. Hope I haven't delayed you too long. ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/444 From andrew at openjdk.org Wed Dec 21 16:25:01 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 21 Dec 2022 16:25:01 GMT Subject: [jdk13u-dev] Integrated: 8297804: (tz) Update Timezone Data to 2022g In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 03:48:57 GMT, Andrew John Hughes wrote: > Clean backport of the latest tzdata update. > > This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato. > > Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass. > > Thanks! This pull request has now been integrated. Changeset: 1ca8a24f Author: Andrew John Hughes URL: https://git.openjdk.org/jdk13u-dev/commit/1ca8a24fdf902caee91e72bc5097e05e5eeb5afc Stats: 240 lines in 26 files changed: 144 ins; 57 del; 39 mod 8297804: (tz) Update Timezone Data to 2022g Backport-of: ce896731d38866c2bf99cd49525062e150d94160 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/444 From phh at openjdk.org Wed Dec 21 19:17:52 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Dec 2022 19:17:52 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> Message-ID: <0OLM4iktRWOfpXtx2zMK-BuSzvDkc5kZq4uWDcz5lNo=.965041e0-e358-4280-a165-49f2ec152d44@github.com> On Mon, 19 Dec 2022 18:01:44 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Replaces a comment about JDK-8240666 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Thu Dec 22 03:18:59 2022 From: duke at openjdk.org (Nagata-Haruhito) Date: Thu, 22 Dec 2022 03:18:59 GMT Subject: [jdk17u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS Message-ID: I would like to backport JDK-8283606 to JDK17u. This fix can be applied cleanly. I tried to run these tests on Japanese Windows 10, and all tests are passed. But, I am not a author, so need a sponsor. Thank you. ------------- Commit messages: - Backport 7d545084f45af44386cb38172fd783f889a8c4e7 Changes: https://git.openjdk.org/jdk17u-dev/pull/963/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=963&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283606 Stats: 37 lines in 9 files changed: 14 ins; 0 del; 23 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/963.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/963/head:pull/963 PR: https://git.openjdk.org/jdk17u-dev/pull/963 From yan at azul.com Thu Dec 22 07:15:50 2022 From: yan at azul.com (Yuri Nesterenko) Date: Thu, 22 Dec 2022 10:15:50 +0300 Subject: [13u-dev notice] jdk13u-dev closed Message-ID: <6c4d2bab-e072-e1ec-59b3-0f277fc01e1e@azul.com> Hi, note that repository https://github.com/openjdk/jdk13u-dev is closed in 13.0.14 state. No new release number exists as of now. Any change targeted to January release of jdk13u should be labeled jdk13u-critical-request in JBS and will go directly to https://github.com/openjdk/jdk13u. Thank you! --yan From rmarchenko at openjdk.org Thu Dec 22 08:05:04 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 22 Dec 2022 08:05:04 GMT Subject: [jdk11u-dev] Integrated: 8282511: Use fixed certificate validation date in SSLExampleCert template In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 10:00:16 GMT, Roman Marchenko wrote: > Clean backport > > Please note that this PR is a part of dependant PR chain > > Prev PRs: > - #1574 > - #1575 This pull request has now been integrated. Changeset: 3e65a7c5 Author: Roman Marchenko Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk11u-dev/commit/3e65a7c5d35b82e14b549ee8ea4bf3a49cfec2e3 Stats: 218 lines in 2 files changed: 37 ins; 2 del; 179 mod 8282511: Use fixed certificate validation date in SSLExampleCert template Backport-of: 268fa693188b685de6289927ee5a1e99473a50f6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1576 From chegar at openjdk.org Thu Dec 22 09:14:47 2022 From: chegar at openjdk.org (Chris Hegarty) Date: Thu, 22 Dec 2022 09:14:47 GMT Subject: [jdk17u-dev] RFR: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes Message-ID: <_QZEkGlLTo3mj94cWJrhe7o2tup5YAAyOMDRg0KXDyk=.b4947e69-f81f-4e72-88e9-c07a6899752f@github.com> Hi all, This pull request contains a backport of commit [a7d6de71](https://github.com/openjdk/jdk/commit/a7d6de71bb83c8715654f61dd166aad6e8dab847) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Chris Hegarty on 21 Dec 2022 and was reviewed by Daniel Fuchs, Daniel Jeli?ski and Jaikiran Pai. Thanks ------------- Commit messages: - Backport a7d6de71bb83c8715654f61dd166aad6e8dab847 Changes: https://git.openjdk.org/jdk17u-dev/pull/964/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=964&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299015 Stats: 42 lines in 3 files changed: 39 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/964.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/964/head:pull/964 PR: https://git.openjdk.org/jdk17u-dev/pull/964 From goetz at openjdk.org Thu Dec 22 09:17:59 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 09:17:59 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:34:28 GMT, Joshua Cao wrote: > This fixes a crash in JDK 11. > > Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. Hi, your change is not ready to be flagged -fix-request. Please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix The same for your other change. I remove the tags for now. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From mbaesken at openjdk.org Thu Dec 22 09:23:15 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 22 Dec 2022 09:23:15 GMT Subject: [jdk17u-dev] RFR: 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check Message-ID: 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check ------------- Commit messages: - Backport 2f8a5c2eca0dc3dad08b7b2c33394ac214907008 Changes: https://git.openjdk.org/jdk17u-dev/pull/965/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=965&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297480 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/965.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/965/head:pull/965 PR: https://git.openjdk.org/jdk17u-dev/pull/965 From phh at openjdk.org Thu Dec 22 09:26:01 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Dec 2022 09:26:01 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> Message-ID: On Mon, 19 Dec 2022 18:01:44 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Replaces a comment about JDK-8240666 Tagged [JDK-8298588](https://bugs.openjdk.org/browse/JDK-8298588). Commit pending jdk11u-fix-yes on [JDk-8245245](https://bugs.openjdk.org/browse/JDK-8245245) and [JDK-8298588](https://bugs.openjdk.org/browse/JDK-8298588). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From goetz at openjdk.org Thu Dec 22 09:26:03 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 09:26:03 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v3] In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 10:05:48 GMT, Michal Karm Babacek wrote: >>> For JDK20, you can use the "/backport jdk20" comment on the commit in head. >> >> I think that's only available for committers. Just FYI. > > Hello, @jerboaa, This is the JBS text proposal, formatted for JIRA: > > > > I would like [JDK-8245245|https://bugs.openjdk.org/browse/JDK-8245245] to get backported to JDK 11 > so as more libraries can start using JDK's own WebSocket client instead of depending > on other implementations. > > For instance, [Fabric8 Kubernetes client|https://github.com/fabric8io/kubernetes-client/blob/master/httpclient-jdk/README.md#jdk-client-for-fabric8] > has this very issue with JDK's WebSocket client and it uses OkHttp3 or Vert.x implementations instead. > > I used these [JBang|https://www.jbang.dev/] scripts to briefly showcase that both Vert.x and OkHttp3 implementations > are fine running on JDK 11 and JDK 11's WebSocket client needs fixing: (It uses Undertow as the server) > > [JDKClient.java|https://gist.github.com/Karm/58959f7bc1d3ef675eecd1e12e56094c] > [OKHttp3Client.java|https://gist.github.com/Karm/6ed845a22a8b8331f95292bb992ee7e0] > [VertXClient.java|https://gist.github.com/Karm/a04a778f352e8d29667eb38a219d4e4b] > > {code} > $ java --version > openjdk 11.0.17 2022-10-18 > > $ ./JDKClient.java > [jbang] Building jar... > The query string was: &raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > $ ./OKHttp3Client.java > [jbang] Building jar... > The query string was: raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > $ ./VertXClient.java > [jbang] Building jar... > The query string was: raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > {code} > > Patched, see the JDK client fixed: > {code} > $ java --version > openjdk 11.0.255-internal 2023-01-17 > > $ ./JDKClient.java > The query string was: &raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > $ ./OKHttp3Client.java > The query string was: raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > $ ./VertXClient.java > The query string was: raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > {code} > > Thanks > K. > > > Edit, short version: > > Fix Request > Approve backporting JDK-8245245 to 11u. It fixes a WebSocket client related query param encoding issue and should be a low risk one. > Testing: ran jdk_net tests without regressions. Patch doesn't apply clean as the test needed changing. > Reviewed by Paul Hohensee , Daniel Fuchs , Severin Gehwolf . Hi @Karm, I saw your JBS comment. Next time please reason why you consider the risk low. Thanks. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From mbaesken at openjdk.org Thu Dec 22 09:47:55 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 22 Dec 2022 09:47:55 GMT Subject: [jdk17u-dev] RFR: 8297959: Provide better descriptions for some Operating System JFR events Message-ID: 8297959: Provide better descriptions for some Operating System JFR events ------------- Commit messages: - Backport dea2161f069a88553bc514c7210dc1d31febd90a Changes: https://git.openjdk.org/jdk17u-dev/pull/966/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=966&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297959 Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/966.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/966/head:pull/966 PR: https://git.openjdk.org/jdk17u-dev/pull/966 From sgehwolf at openjdk.org Thu Dec 22 09:57:06 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Dec 2022 09:57:06 GMT Subject: [jdk17u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Message-ID: <7PWWC76tVH1sU2rRbLJ9Iap5IU8YPsGtTzMflc8vLb8=.48c571ec-158d-43b3-bf22-e6b8cdc5910d@github.com> Clean backport fixing a regression introduced with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in 17.0.5. This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars. See [JDK-8297684](https://bugs.openjdk.org/browse/JDK-8297684) for details. ------------- Commit messages: - 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Changes: https://git.openjdk.org/jdk17u/pull/363/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=363&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280890 Stats: 186 lines in 4 files changed: 142 ins; 28 del; 16 mod Patch: https://git.openjdk.org/jdk17u/pull/363.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/363/head:pull/363 PR: https://git.openjdk.org/jdk17u/pull/363 From clanger at openjdk.org Thu Dec 22 10:02:14 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:02:14 GMT Subject: [jdk17u-dev] Integrated: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body In-Reply-To: References: Message-ID: <-AYDJLh18WQ9CfOTKTGnUPYtLx5wgv4Zg8cfxnQyf20=.26ef5eee-8c97-486c-9c0b-f9cca711bf3b@github.com> On Tue, 20 Dec 2022 16:09:12 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8298588](https://bugs.openjdk.org/browse/JDK-8298588), commit [909d0cb4](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Michal Karm Babacek on 16 Dec 2022 and was reviewed by Daniel Fuchs. > > Thanks! This pull request has now been integrated. Changeset: d973531c Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/d973531cb7e9a5e398df1fb8b15e130f0ae63323 Stats: 16 lines in 1 file changed: 7 ins; 6 del; 3 mod 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body Backport-of: 909d0cb4d9475fd367b8bc64a6b50c5a324e9a01 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/958 From goetz at openjdk.org Thu Dec 22 10:09:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 10:09:56 GMT Subject: [jdk17u-dev] RFR: 8279024: Remove javascript references from clhsdb.html Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport d0ea7c9db9cc9ce80b60c2f94c53bb307792fc51 Changes: https://git.openjdk.org/jdk17u-dev/pull/967/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=967&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279024 Stats: 52 lines in 2 files changed: 1 ins; 49 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/967.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/967/head:pull/967 PR: https://git.openjdk.org/jdk17u-dev/pull/967 From clanger at openjdk.org Thu Dec 22 10:14:05 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:14:05 GMT Subject: [jdk17u-dev] Integrated: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 17:09:53 GMT, Christoph Langer wrote: > Backport of a small build system fix/cleanup. I had to resolve because RISCV was not handled in jdk17u-dev yet. > For this backport, in the new code, I chose to leave the RISCV branch in. It should do no harm. This pull request has now been integrated. Changeset: 1da982b4 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/1da982b4f4653002177b1bb2deee7688f2600c05 Stats: 64 lines in 1 file changed: 33 ins; 30 del; 1 mod 8298527: Cygwin's uname -m returns different string than before Reviewed-by: mbaesken Backport-of: 51f0a1ce4b0d72cf7e82e01f7014274d8b7d1575 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/959 From avoitylov at openjdk.org Thu Dec 22 10:21:07 2022 From: avoitylov at openjdk.org (Aleksei Voitylov) Date: Thu, 22 Dec 2022 10:21:07 GMT Subject: [jdk17u-dev] Integrated: 8288005: HotSpot build with disabled PCH fails for Windows AArch64 In-Reply-To: References: Message-ID: <_-xSpHtOcAM7SythmAtk2pUHaW3hAEb4qLvuazygvDY=.bd867bbf-56ea-4e13-bc59-3c092bfa3808@github.com> On Tue, 20 Dec 2022 14:17:24 GMT, Aleksei Voitylov wrote: > This backport fixes non-PCH builds on Windows AArch64 which helps Windows AArch64 builds reproducibility on VS2019+. > > This is a clean backport. This pull request has now been integrated. Changeset: e262f644 Author: Aleksei Voitylov Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/e262f644706c4dce5e5ef4c8d9dda3e8e9f6fffe Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8288005: HotSpot build with disabled PCH fails for Windows AArch64 Backport-of: b2a58bec4a4f70a06b23013cc4c351b36a413521 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/956 From clanger at openjdk.org Thu Dec 22 10:27:48 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:27:48 GMT Subject: [jdk11u-dev] Integrated: 8244592: Start supporting SOURCE_DATE_EPOCH In-Reply-To: References: Message-ID: On Thu, 15 Dec 2022 07:50:13 GMT, Christoph Langer wrote: > After the backport of [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679), a non-debug build on Windows in a build directory that's outside the repository will fail. The problem unveiled by the backport is that in those builds, the `ALLOW_ABSOLUTE_PATHS_IN_OUTPUT` flag is set to false, causing the code [here](https://github.com/openjdk/jdk11u-dev/blob/12eca2f8ac6e8127f1d698aef50db03cf278a7b8/make/common/NativeCompilation.gmk#L220) to relativize the make command. This seemed to have worked fine with the old fixpath before [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) but now it breaks the build. > In later releases, we get new code by [JDK-8256240](https://bugs.openjdk.org/browse/JDK-8256240) that removes the absolute paths on Windows by setting a new compiler option. After the change, `FILE_MACRO_CFLAGS` is set (e.g. [here](https://github.com/openjdk/jdk17u-dev/blob/399a52dccb2a53a4309fdff479a14d944829cd54/make/autoconf/flags-cflags.m4#L823)) which will cause MakeCommandRelative to not relativize the paths in NativeCompilation.gmk. > > I propose to backport this behavior to jdk11u by backporting [JDK-8244592 Start supporting SOURCE_DATE_EPOCH](https://bugs.openjdk.org/browse/JDK-8244592) and [JDK-8256240 Reproducible builds should turn on the "deterministic" flag for Visual Studio](https://bugs.openjdk.org/browse/JDK-8256240). This will bring some functionality of reproducible builds to jdk11u. I don't see an issue with that, since the behavior is off by default. The only larger risk I see is whether the newly used Visual Studio compiler options could break existing downstream builds on older VS versions. However, if such a thing occurs, we could add a condition to fall back to the old behavior then. > > As for this backport: > I bring in a part of [JDK-8240820](https://bugs.openjdk.org/browse/JDK-8240820), namely the new configure function `UTIL_ARG_ENABLE` which is used by [JDK-8244592](https://bugs.openjdk.org/browse/JDK-8244592). Furthermore I incorporated the changes to jdk-options.m4 of the already backported [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679), which didn't fit at that time. This pull request has now been integrated. Changeset: ffea9137 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/ffea91377b86ed221c9d4bdd6db351f8654ad6a0 Stats: 336 lines in 7 files changed: 332 ins; 0 del; 4 mod 8244592: Start supporting SOURCE_DATE_EPOCH Reviewed-by: mbaesken Backport-of: 1a16a4b62829e54a4af5446ef15b981212a70718 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1597 From clanger at openjdk.org Thu Dec 22 10:32:20 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:32:20 GMT Subject: [jdk11u-dev] RFR: 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio [v2] In-Reply-To: References: Message-ID: <5yugKBnaFCVNWlh8yr1UaXgsE5Y-TXZo1_8i2ORXmnw=.336a6891-c887-4400-9e63-21c543923c90@github.com> > This is the backport of [JDK-8256240](https://bugs.openjdk.org/browse/JDK-8256240). I incorporated [JDK-8281262](https://bugs.openjdk.org/browse/JDK-8281262) because the code that was removed by it in flags-cflags.m4 did not work in 11u-dev due to some missing requirements. I will hence mark JDK-8281262 as fixed by this change. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1598/files - new: https://git.openjdk.org/jdk11u-dev/pull/1598/files/33d5caf9..33d5caf9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1598&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1598&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1598/head:pull/1598 PR: https://git.openjdk.org/jdk11u-dev/pull/1598 From clanger at openjdk.org Thu Dec 22 10:37:23 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:37:23 GMT Subject: [jdk11u-dev] RFR: 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio [v3] In-Reply-To: References: Message-ID: <_c9jpjb6aXElDb7pQyDul8BfQlH19HkkHEM_T9j7vmA=.0957f8e9-4f2e-4979-9d3a-34daddd15986@github.com> > This is the backport of [JDK-8256240](https://bugs.openjdk.org/browse/JDK-8256240). I incorporated [JDK-8281262](https://bugs.openjdk.org/browse/JDK-8281262) because the code that was removed by it in flags-cflags.m4 did not work in 11u-dev due to some missing requirements. I will hence mark JDK-8281262 as fixed by this change. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8256240 - 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio Reviewed-by: erikj - 8244592: Start supporting SOURCE_DATE_EPOCH Reviewed-by: erikj ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1598/files - new: https://git.openjdk.org/jdk11u-dev/pull/1598/files/33d5caf9..5c399661 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1598&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1598&range=01-02 Stats: 5510 lines in 86 files changed: 3141 ins; 2205 del; 164 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1598/head:pull/1598 PR: https://git.openjdk.org/jdk11u-dev/pull/1598 From clanger at openjdk.org Thu Dec 22 10:42:49 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:42:49 GMT Subject: [jdk11u-dev] RFR: 8298527: Cygwin's uname -m returns different string than before Message-ID: Hi all, This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [1da982b4](https://github.com/openjdk/jdk17u-dev/commit/1da982b4f4653002177b1bb2deee7688f2600c05) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken. Thanks! ------------- Commit messages: - Backport 1da982b4f4653002177b1bb2deee7688f2600c05 Changes: https://git.openjdk.org/jdk11u-dev/pull/1607/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1607&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298527 Stats: 64 lines in 1 file changed: 33 ins; 30 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1607.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1607/head:pull/1607 PR: https://git.openjdk.org/jdk11u-dev/pull/1607 From goetz at openjdk.org Thu Dec 22 10:47:35 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 10:47:35 GMT Subject: [jdk17u-dev] RFR: 8244669: convert clhsdb "mem" command from javascript to java Message-ID: I backport this for parity with 17.0.7-oracle. Did not apply clean because in head dead variable String format = ""; was removed in CommandProcessor (8277413). I removed that too. ------------- Commit messages: - Backport eaefb1a1ed9edea440628e3a5c5483ebd52bfcb0 Changes: https://git.openjdk.org/jdk17u-dev/pull/968/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=968&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8244669 Stats: 158 lines in 3 files changed: 121 ins; 29 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/968.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/968/head:pull/968 PR: https://git.openjdk.org/jdk17u-dev/pull/968 From sgehwolf at openjdk.org Thu Dec 22 10:54:01 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Dec 2022 10:54:01 GMT Subject: [jdk17u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: <7PWWC76tVH1sU2rRbLJ9Iap5IU8YPsGtTzMflc8vLb8=.48c571ec-158d-43b3-bf22-e6b8cdc5910d@github.com> References: <7PWWC76tVH1sU2rRbLJ9Iap5IU8YPsGtTzMflc8vLb8=.48c571ec-158d-43b3-bf22-e6b8cdc5910d@github.com> Message-ID: On Thu, 22 Dec 2022 09:50:33 GMT, Severin Gehwolf wrote: > Clean backport (modulo copyright header in `DisabledAlgorithmConstraints`) fixing a regression introduced with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in 17.0.5. This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars. See [JDK-8297684](https://bugs.openjdk.org/browse/JDK-8297684) for details. @RealCLanger Could you please review this? Thank you! ------------- PR: https://git.openjdk.org/jdk17u/pull/363 From clanger at openjdk.org Thu Dec 22 10:54:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:54:55 GMT Subject: [jdk17u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: <-AkHm25ZGL-r7-XPFNejtBcQSt3dEisCBIemHsivPrw=.aec96524-abe0-4e19-971f-272dc22736b3@github.com> On Thu, 22 Dec 2022 03:12:05 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK17u. This fix can be applied cleanly. > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > > Thank you. Looks good. Seems clean apart from some copyright header fixes. Please enable Github Actions in your fork repo and run the tests there to get some quality gate check. Thanks. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/963 From clanger at openjdk.org Thu Dec 22 10:58:02 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:58:02 GMT Subject: [jdk17u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: <7PWWC76tVH1sU2rRbLJ9Iap5IU8YPsGtTzMflc8vLb8=.48c571ec-158d-43b3-bf22-e6b8cdc5910d@github.com> References: <7PWWC76tVH1sU2rRbLJ9Iap5IU8YPsGtTzMflc8vLb8=.48c571ec-158d-43b3-bf22-e6b8cdc5910d@github.com> Message-ID: On Thu, 22 Dec 2022 09:50:33 GMT, Severin Gehwolf wrote: > Clean backport (modulo copyright header in `DisabledAlgorithmConstraints`) fixing a regression introduced with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in 17.0.5. This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars. See [JDK-8297684](https://bugs.openjdk.org/browse/JDK-8297684) for details. LGTM ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk17u/pull/363 From clanger at openjdk.org Thu Dec 22 10:59:56 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 10:59:56 GMT Subject: [jdk17u-dev] RFR: 8244669: convert clhsdb "mem" command from javascript to java In-Reply-To: References: Message-ID: <-WuwE-30lEGwCQLxW2YKnVcbPh8PsBzWAtMrbXxu_v8=.9a3c3b0f-354c-452b-8677-14036f1dd70c@github.com> On Thu, 22 Dec 2022 10:40:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > Did not apply clean because in head dead variable > String format = ""; > was removed in CommandProcessor (8277413). > I removed that too. LGTM ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/968 From sgehwolf at openjdk.org Thu Dec 22 11:07:01 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Dec 2022 11:07:01 GMT Subject: [jdk11u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Message-ID: Please review this almost clean backport (modulo copyright header in `DisabledAlgorithmConstraints`) in the product code. The test needed some changes to make it work (removal of text block syntax, `ClassFileInstaller` import change). It fixes a regression introduced with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `11.0.17` (note that `11.0.16` is not affected as JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars. See [JDK-8297684](https://bugs.openjdk.org/browse/JDK-8297684) for details. Proposing as critical fix so that we don't have another release with that regression. Regression test fails prior and passes after the product fix. ------------- Commit messages: - 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Changes: https://git.openjdk.org/jdk11u/pull/65/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=65&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280890 Stats: 183 lines in 4 files changed: 139 ins; 28 del; 16 mod Patch: https://git.openjdk.org/jdk11u/pull/65.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/65/head:pull/65 PR: https://git.openjdk.org/jdk11u/pull/65 From goetz at openjdk.org Thu Dec 22 13:12:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 13:12:39 GMT Subject: [jdk17u-dev] RFR: 8271471: [IR Framework] Rare occurrence of "" in PrintIdeal/PrintOptoAssembly can let tests fail Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 3677734584859e1b4bea65f6719e839f949c9236 Changes: https://git.openjdk.org/jdk17u-dev/pull/969/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=969&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8271471 Stats: 102 lines in 5 files changed: 78 ins; 11 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/969.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/969/head:pull/969 PR: https://git.openjdk.org/jdk17u-dev/pull/969 From goetz at openjdk.org Thu Dec 22 13:50:28 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 13:50:28 GMT Subject: [jdk17u-dev] RFR: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport f66070b00d4311c6e3a6fbf38956fa2d5da5fada Changes: https://git.openjdk.org/jdk17u-dev/pull/970/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=970&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282577 Stats: 98 lines in 3 files changed: 89 ins; 3 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/970.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/970/head:pull/970 PR: https://git.openjdk.org/jdk17u-dev/pull/970 From goetz at openjdk.org Thu Dec 22 14:25:44 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 14:25:44 GMT Subject: [jdk17u-dev] RFR: 8288130: compiler error with AP and explicit record accessor Message-ID: <3uY-sFPKCeUgy6wHuZ-tg62MR0TYXYKeXvG5R7TOuIg=.d2486215-243c-4bec-bbf0-2d74090062c2@github.com> I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 53b37fe1535388eb14e04c620a6b0118ed8884a0 Changes: https://git.openjdk.org/jdk17u-dev/pull/971/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=971&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288130 Stats: 308 lines in 5 files changed: 124 ins; 79 del; 105 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/971.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/971/head:pull/971 PR: https://git.openjdk.org/jdk17u-dev/pull/971 From goetz at openjdk.org Thu Dec 22 14:29:24 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 14:29:24 GMT Subject: [jdk17u-dev] RFR: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432 Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport c156bcc599534ae989bc9cbd001e7c150da8096c Changes: https://git.openjdk.org/jdk17u-dev/pull/972/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=972&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285399 Stats: 5 lines in 2 files changed: 4 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/972.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/972/head:pull/972 PR: https://git.openjdk.org/jdk17u-dev/pull/972 From clanger at openjdk.org Thu Dec 22 15:13:51 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Dec 2022 15:13:51 GMT Subject: [jdk11u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: References: Message-ID: <74Gei3gHN_zeeGYVRzTi9BZAjn3BYXpjIv7Sju3ZYho=.95f020dc-60d4-4b5d-8746-4cae487cadd7@github.com> On Thu, 22 Dec 2022 10:58:34 GMT, Severin Gehwolf wrote: > Please review this almost clean backport (modulo copyright header in `DisabledAlgorithmConstraints`) in the product code. The test needed some changes to make it work (removal of text block syntax, `ClassFileInstaller` import change). > > It fixes a regression introduced with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `11.0.17` (note that `11.0.16` is not affected as JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars. See [JDK-8297684](https://bugs.openjdk.org/browse/JDK-8297684) for details. > > Proposing as critical fix so that we don't have another release with that regression. > > Regression test fails prior and passes after the product fix. Looks good. I'll run this PR and the 17u one through our nightlies. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u/pull/65 From goetz at openjdk.org Thu Dec 22 15:23:54 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 15:23:54 GMT Subject: [jdk17u-dev] RFR: 8155246: Throw error if default java.security file is missing Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 9d7c13eb14c525485e7739fcfacd044aa3bbc12d Changes: https://git.openjdk.org/jdk17u-dev/pull/973/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=973&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8155246 Stats: 125 lines in 4 files changed: 107 ins; 17 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/973.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/973/head:pull/973 PR: https://git.openjdk.org/jdk17u-dev/pull/973 From goetz at openjdk.org Thu Dec 22 15:31:48 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 15:31:48 GMT Subject: [jdk17u-dev] RFR: 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion Message-ID: I backport this for parity with 17.0.7-oracle. Requires follow-up 8292660. ------------- Commit messages: - Backport a25e1dc53cecc5dd917ac0f76fd86ef1f074adba Changes: https://git.openjdk.org/jdk17u-dev/pull/974/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=974&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292285 Stats: 24 lines in 1 file changed: 18 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/974.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/974/head:pull/974 PR: https://git.openjdk.org/jdk17u-dev/pull/974 From goetz at openjdk.org Thu Dec 22 15:36:33 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 15:36:33 GMT Subject: [jdk17u-dev] RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport caae53f4dadd146426a1a2cd121ac00bb98ebc97 Changes: https://git.openjdk.org/jdk17u-dev/pull/975/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=975&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289508 Stats: 371 lines in 2 files changed: 371 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/975.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/975/head:pull/975 PR: https://git.openjdk.org/jdk17u-dev/pull/975 From goetz at openjdk.org Thu Dec 22 15:55:30 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 15:55:30 GMT Subject: [jdk17u-dev] RFR: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency Message-ID: I backport this for parity with 17.0.7-oracle. I needed to resolve around phaseX.cpp:1770 because JDK-8289051: C2: Cleanup PhaseCCP::analyze() is not in 17. ------------- Commit messages: - Backport 379f3094db0b8afe90ed6b7a341164222744085f Changes: https://git.openjdk.org/jdk17u-dev/pull/976/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=976&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287217 Stats: 102 lines in 5 files changed: 81 ins; 2 del; 19 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/976.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/976/head:pull/976 PR: https://git.openjdk.org/jdk17u-dev/pull/976 From sgehwolf at openjdk.org Thu Dec 22 17:11:46 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Dec 2022 17:11:46 GMT Subject: [jdk17u-dev] RFR: 8298108: Add a regression test for JDK-8297684 Message-ID: Clean backport. Adds another reg-test for the issue fixed with https://github.com/openjdk/jdk17u/pull/363 ------------- Commit messages: - 8298108: Add a regression test for JDK-8297684 Changes: https://git.openjdk.org/jdk17u-dev/pull/977/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=977&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298108 Stats: 181 lines in 3 files changed: 181 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/977.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/977/head:pull/977 PR: https://git.openjdk.org/jdk17u-dev/pull/977 From sgehwolf at openjdk.org Thu Dec 22 17:26:36 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Dec 2022 17:26:36 GMT Subject: [jdk17u-dev] RFR: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows Message-ID: Not clean backport, because the problem list bug [JDK-8298274](https://bugs.openjdk.org/browse/JDK-8298274) won't get backported. Omitted the ProblemList.txt hunk. Instead I propose to backport the fix (this PR) instead. Follow up for https://github.com/openjdk/jdk17u-dev/pull/977 Please review this test-only backport. Thanks! Test passes with the fix of https://github.com/openjdk/jdk17u/pull/363 included. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/977 Commit messages: - 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows Changes: https://git.openjdk.org/jdk17u-dev/pull/978/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=978&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298271 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/978.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/978/head:pull/978 PR: https://git.openjdk.org/jdk17u-dev/pull/978 From duke at openjdk.org Thu Dec 22 19:22:18 2022 From: duke at openjdk.org (Joshua Cao) Date: Thu, 22 Dec 2022 19:22:18 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook [v2] In-Reply-To: References: Message-ID: > This fixes a crash in JDK 11. > > Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. Joshua Cao has updated the pull request incrementally with one additional commit since the last revision: Update HelloCustom copyright year ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1604/files - new: https://git.openjdk.org/jdk11u-dev/pull/1604/files/6b7ae232..666c4eca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1604&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1604&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1604.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1604/head:pull/1604 PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From goetz at openjdk.org Thu Dec 22 21:22:32 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 21:22:32 GMT Subject: [jdk17u-dev] RFR: 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly Message-ID: I backport this for parity with 17.0.7-oracle. Clean. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/974 Commit messages: - Backport 730ced9a109953ca1c3b7bfd6a3eeac5b85892c5 Changes: https://git.openjdk.org/jdk17u-dev/pull/979/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=979&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292660 Stats: 67 lines in 3 files changed: 52 ins; 13 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/979.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/979/head:pull/979 PR: https://git.openjdk.org/jdk17u-dev/pull/979 From goetz at openjdk.org Thu Dec 22 21:42:04 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Dec 2022 21:42:04 GMT Subject: [jdk17u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 03f25a9c6924430ec4063b801b2b6ca55b9067c9 Changes: https://git.openjdk.org/jdk17u-dev/pull/980/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=980&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293562 Stats: 346 lines in 3 files changed: 278 ins; 43 del; 25 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/980.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/980/head:pull/980 PR: https://git.openjdk.org/jdk17u-dev/pull/980 From goetz at openjdk.org Fri Dec 23 06:45:29 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 06:45:29 GMT Subject: [jdk17u-dev] RFR: 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.7-oracle. > > Clean. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add test forgotten in first push ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/979/files - new: https://git.openjdk.org/jdk17u-dev/pull/979/files/dfe77c18..3c25de22 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=979&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=979&range=00-01 Stats: 56 lines in 1 file changed: 56 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/979.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/979/head:pull/979 PR: https://git.openjdk.org/jdk17u-dev/pull/979 From clanger at openjdk.org Fri Dec 23 06:47:51 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 23 Dec 2022 06:47:51 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook [v2] In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 19:22:18 GMT, Joshua Cao wrote: >> This fixes a crash in JDK 11. >> >> Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. > > Joshua Cao has updated the pull request incrementally with one additional commit since the last revision: > > Update HelloCustom copyright year Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From goetz at openjdk.org Fri Dec 23 06:49:05 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 06:49:05 GMT Subject: [jdk17u-dev] RFR: 8288130: compiler error with AP and explicit record accessor In-Reply-To: <3uY-sFPKCeUgy6wHuZ-tg62MR0TYXYKeXvG5R7TOuIg=.d2486215-243c-4bec-bbf0-2d74090062c2@github.com> References: <3uY-sFPKCeUgy6wHuZ-tg62MR0TYXYKeXvG5R7TOuIg=.d2486215-243c-4bec-bbf0-2d74090062c2@github.com> Message-ID: On Thu, 22 Dec 2022 14:18:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. Pre-submit test: download of boot jdk failed. Unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/971 From goetz at openjdk.org Fri Dec 23 06:50:04 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 06:50:04 GMT Subject: [jdk17u-dev] RFR: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432 In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 14:21:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. Pre-submit test: download of boot jdk failed. Unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/972 From clanger at openjdk.org Fri Dec 23 06:51:56 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 23 Dec 2022 06:51:56 GMT Subject: [jdk17u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 03:12:05 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK17u. This fix can be applied cleanly. > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > > Thank you. Hi @Nagata-Haruhito, for JDK-Updates you must not just integrate a PR once its reviewed but you also need to seek maintainer approval. Please read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix for more details. In short, please add a jdk17u-fix-request label to the JBS bug and add a comment about why you want to backport the fix, what are the involved risks and what testing you did. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/963 From goetz at openjdk.org Fri Dec 23 07:01:53 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 07:01:53 GMT Subject: [jdk17u-dev] RFR: 8298108: Add a regression test for JDK-8297684 In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 17:03:31 GMT, Severin Gehwolf wrote: > Clean backport. Adds another reg-test for the issue fixed with https://github.com/openjdk/jdk17u/pull/363 Hi @jerboaa, why are the pre-submit tests red? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/977 From clanger at openjdk.org Fri Dec 23 08:32:08 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 23 Dec 2022 08:32:08 GMT Subject: [jdk11u-dev] Integrated: 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio In-Reply-To: References: Message-ID: <4pXCoH_QLsenltInNf9aEHijOIeOkBq57Fx12_AUc4E=.183b1d4b-412e-4e06-9492-ac75fae5c5ec@github.com> On Thu, 15 Dec 2022 08:16:01 GMT, Christoph Langer wrote: > This is the backport of [JDK-8256240](https://bugs.openjdk.org/browse/JDK-8256240). I incorporated [JDK-8281262](https://bugs.openjdk.org/browse/JDK-8281262) because the code that was removed by it in flags-cflags.m4 did not work in 11u-dev due to some missing requirements. I will hence mark JDK-8281262 as fixed by this change. This pull request has now been integrated. Changeset: bcda0410 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/bcda0410a9e9f49449bb7869ee894026fa109de8 Stats: 65 lines in 5 files changed: 52 ins; 5 del; 8 mod 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio 8281262: Windows builds in different directories are not fully reproducible Reviewed-by: phh Backport-of: b0485b9632e3879365497de9e6c2c55d839236db ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1598 From clanger at openjdk.org Fri Dec 23 08:49:59 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 23 Dec 2022 08:49:59 GMT Subject: [jdk11u-dev] Integrated: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 10:34:35 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [1da982b4](https://github.com/openjdk/jdk17u-dev/commit/1da982b4f4653002177b1bb2deee7688f2600c05) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken. > > Thanks! This pull request has now been integrated. Changeset: ca49dbf3 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/ca49dbf39916e4d68e81e139a14d922f6144e8ee Stats: 64 lines in 1 file changed: 33 ins; 30 del; 1 mod 8298527: Cygwin's uname -m returns different string than before Backport-of: 1da982b4f4653002177b1bb2deee7688f2600c05 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1607 From sgehwolf at openjdk.org Fri Dec 23 09:48:04 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 09:48:04 GMT Subject: [jdk17u-dev] RFR: 8298108: Add a regression test for JDK-8297684 In-Reply-To: References: Message-ID: On Fri, 23 Dec 2022 06:58:54 GMT, Goetz Lindenmaier wrote: > Hi @jerboaa, why are the pre-submit tests red? Seems unrelated both fail with this when trying to download the boot jdk: HTTP request sent, awaiting response... 503 Egress is over the account limit. Not sure what's up. Probably running against a limit somewhere. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/977 From duke at openjdk.org Fri Dec 23 09:52:09 2022 From: duke at openjdk.org (Nagata-Haruhito) Date: Fri, 23 Dec 2022 09:52:09 GMT Subject: [jdk17u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 03:12:05 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK17u. This fix can be applied cleanly. > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > > Thank you. Thank you for your advice. Will I need retype "/integrate" after JBS label and comment is updated ? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/963 From sgehwolf at openjdk.org Fri Dec 23 10:10:54 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 10:10:54 GMT Subject: [jdk11u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: <74Gei3gHN_zeeGYVRzTi9BZAjn3BYXpjIv7Sju3ZYho=.95f020dc-60d4-4b5d-8746-4cae487cadd7@github.com> References: <74Gei3gHN_zeeGYVRzTi9BZAjn3BYXpjIv7Sju3ZYho=.95f020dc-60d4-4b5d-8746-4cae487cadd7@github.com> Message-ID: On Thu, 22 Dec 2022 15:11:32 GMT, Christoph Langer wrote: > Looks good. I'll run this PR and the 17u one through our nightlies. @RealCLanger Thanks for the review! How do your nightlies look? OK to integrate (I see `jdk11u-critical-yes` on the bug)? ------------- PR: https://git.openjdk.org/jdk11u/pull/65 From goetz at openjdk.org Fri Dec 23 10:24:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 10:24:56 GMT Subject: [jdk11u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 10:58:34 GMT, Severin Gehwolf wrote: > Please review this almost clean backport (modulo copyright header in `DisabledAlgorithmConstraints`) in the product code. The test needed some changes to make it work (removal of text block syntax, `ClassFileInstaller` import change). > > It fixes a regression introduced with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `11.0.17` (note that `11.0.16` is not affected as JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars. See [JDK-8297684](https://bugs.openjdk.org/browse/JDK-8297684) for details. > > Proposing as critical fix so that we don't have another release with that regression. > > Regression test fails prior and passes after the product fix. The nighties are all green. ok to go. I checked before approving :) ------------- PR: https://git.openjdk.org/jdk11u/pull/65 From sgehwolf at openjdk.org Fri Dec 23 10:34:56 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 10:34:56 GMT Subject: [jdk11u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: References: Message-ID: On Fri, 23 Dec 2022 10:22:30 GMT, Goetz Lindenmaier wrote: > The nighties are all green. ok to go. I checked before approving :) Ah, thanks. ------------- PR: https://git.openjdk.org/jdk11u/pull/65 From sgehwolf at openjdk.org Fri Dec 23 10:34:58 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 10:34:58 GMT Subject: [jdk11u] Integrated: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 10:58:34 GMT, Severin Gehwolf wrote: > Please review this almost clean backport (modulo copyright header in `DisabledAlgorithmConstraints`) in the product code. The test needed some changes to make it work (removal of text block syntax, `ClassFileInstaller` import change). > > It fixes a regression introduced with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `11.0.17` (note that `11.0.16` is not affected as JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars. See [JDK-8297684](https://bugs.openjdk.org/browse/JDK-8297684) for details. > > Proposing as critical fix so that we don't have another release with that regression. > > Regression test fails prior and passes after the product fix. This pull request has now been integrated. Changeset: 445ab521 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u/commit/445ab521954ba92a0d7435b811bd38ccfccb5b95 Stats: 183 lines in 4 files changed: 139 ins; 28 del; 16 mod 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Reviewed-by: clanger Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d ------------- PR: https://git.openjdk.org/jdk11u/pull/65 From sgehwolf at openjdk.org Fri Dec 23 10:36:09 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 10:36:09 GMT Subject: [jdk17u] Integrated: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: <7PWWC76tVH1sU2rRbLJ9Iap5IU8YPsGtTzMflc8vLb8=.48c571ec-158d-43b3-bf22-e6b8cdc5910d@github.com> References: <7PWWC76tVH1sU2rRbLJ9Iap5IU8YPsGtTzMflc8vLb8=.48c571ec-158d-43b3-bf22-e6b8cdc5910d@github.com> Message-ID: On Thu, 22 Dec 2022 09:50:33 GMT, Severin Gehwolf wrote: > Clean backport (modulo copyright header in `DisabledAlgorithmConstraints`) fixing a regression introduced with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in 17.0.5. This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars. See [JDK-8297684](https://bugs.openjdk.org/browse/JDK-8297684) for details. This pull request has now been integrated. Changeset: 0ab310ea Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u/commit/0ab310eafb4b1225c7db19f7a3d1d4620ee5c7df Stats: 186 lines in 4 files changed: 142 ins; 28 del; 16 mod 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Reviewed-by: clanger Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d ------------- PR: https://git.openjdk.org/jdk17u/pull/363 From goetz at openjdk.org Fri Dec 23 10:41:05 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 10:41:05 GMT Subject: [jdk17u-dev] RFR: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception" Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/969 Commit messages: - Backport f62346066869b681d1cc9f63775393b11a48722a Changes: https://git.openjdk.org/jdk17u-dev/pull/981/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=981&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274911 Stats: 128 lines in 4 files changed: 55 ins; 38 del; 35 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/981.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/981/head:pull/981 PR: https://git.openjdk.org/jdk17u-dev/pull/981 From duke at openjdk.org Fri Dec 23 13:34:48 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Fri, 23 Dec 2022 13:34:48 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> Message-ID: <90114JidTpjiaCPlDdgHodvD0Bl7ZL8VN8hdAPrdfD0=.80906307-a11d-43bc-b582-1024e42750f0@github.com> On Tue, 20 Dec 2022 16:06:25 GMT, Christoph Langer wrote: > OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)... THX @RealCLanger JDK 17 https://github.com/openjdk/jdk17u-dev/pull/982 JDK 20 https://github.com/openjdk/jdk20/pull/76 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Fri Dec 23 13:50:49 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Fri, 23 Dec 2022 13:50:49 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <90114JidTpjiaCPlDdgHodvD0Bl7ZL8VN8hdAPrdfD0=.80906307-a11d-43bc-b582-1024e42750f0@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> <90114JidTpjiaCPlDdgHodvD0Bl7ZL8VN8hdAPrdfD0=.80906307-a11d-43bc-b582-1024e42750f0@github.com> Message-ID: On Fri, 23 Dec 2022 13:31:40 GMT, Michal Karm Babacek wrote: >> OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)... > >> OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)... > > THX @RealCLanger > JDK 17 https://github.com/openjdk/jdk17u-dev/pull/982 > JDK 20 https://github.com/openjdk/jdk20/pull/76 > Hi @Karm, I saw your JBS comment. Next time please reason why you consider the risk low. Thanks. @GoeLin Ack. Will do. My own thinking is along the lines that it is a well isolated change in a very comprehensible part of code, it aligns with the spec and it does not bring any surprising behavior when compared to some popular WebSocket client libs used with JDK 11, as noted in https://github.com/openjdk/jdk11u-dev/pull/1558#issuecomment-1361109845. If there is code out there workarounding it, it's likely based on a string substitution and will turn to no-op now. I will try to be more eloquent about risks of particular backports in the it in future. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From goetz at openjdk.org Fri Dec 23 14:37:24 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 14:37:24 GMT Subject: [jdk17u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 0c13d66622a8c2be654bb867aa8c17421d1557ca Changes: https://git.openjdk.org/jdk17u-dev/pull/983/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=983&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295530 Stats: 11195 lines in 24 files changed: 9975 ins; 274 del; 946 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/983.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/983/head:pull/983 PR: https://git.openjdk.org/jdk17u-dev/pull/983 From goetz at openjdk.org Fri Dec 23 14:52:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 14:52:39 GMT Subject: [jdk17u-dev] RFR: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/967 Commit messages: - Backport 2a59ebbba391ee0d70604027081712f1c2dfd1fe Changes: https://git.openjdk.org/jdk17u-dev/pull/984/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=984&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279119 Stats: 189 lines in 1 file changed: 0 ins; 165 del; 24 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/984.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/984/head:pull/984 PR: https://git.openjdk.org/jdk17u-dev/pull/984 From sgehwolf at openjdk.org Fri Dec 23 17:03:48 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 17:03:48 GMT Subject: [jdk11u-dev] RFR: 8298108: Add a regression test for JDK-8297684 Message-ID: Clean backport. Adds another reg-test for the issue fixed with https://github.com/openjdk/jdk11u/pull/65 Fails without the fix, passes with it. ------------- Commit messages: - 8298108: Add a regression test for JDK-8297684 Changes: https://git.openjdk.org/jdk11u-dev/pull/1608/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1608&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298108 Stats: 181 lines in 3 files changed: 181 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1608.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1608/head:pull/1608 PR: https://git.openjdk.org/jdk11u-dev/pull/1608 From sgehwolf at openjdk.org Fri Dec 23 17:18:45 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 17:18:45 GMT Subject: [jdk11u-dev] RFR: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows Message-ID: Not clean backport, because the problem list bug [JDK-8298274](https://bugs.openjdk.org/browse/JDK-8298274) won't get backported. Omitted the ProblemList.txt hunk. Instead I propose to backport the fix (this PR) instead. Follow up for #1608 in order to fix the test on Windows. Please review this test-only backport. Thanks! Test passes with the fix of https://github.com/openjdk/jdk11u/pull/65 included. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1608 Commit messages: - 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows Changes: https://git.openjdk.org/jdk11u-dev/pull/1609/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1609&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298271 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1609.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1609/head:pull/1609 PR: https://git.openjdk.org/jdk11u-dev/pull/1609 From duke at openjdk.org Fri Dec 23 18:03:03 2022 From: duke at openjdk.org (Alexander Veit) Date: Fri, 23 Dec 2022 18:03:03 GMT Subject: [jdk17u-dev] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Message-ID: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d ------------- Commit messages: - 8297684: NullPointerException in JarVerifier prevents JVM from starting - 8297684: NullPointerException in JarVerifier prevents JVM from starting Changes: https://git.openjdk.org/jdk17u-dev/pull/947/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=947&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280890 Stats: 192 lines in 4 files changed: 145 ins; 31 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/947.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/947/head:pull/947 PR: https://git.openjdk.org/jdk17u-dev/pull/947 From duke at openjdk.org Fri Dec 23 18:03:04 2022 From: duke at openjdk.org (Alexander Veit) Date: Fri, 23 Dec 2022 18:03:04 GMT Subject: [jdk17u-dev] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> References: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> Message-ID: On Sat, 3 Dec 2022 22:42:54 GMT, Alexander Veit wrote: > Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d OCA has been /signed and submitted at 2022-12-02. Still under review. OCA /signed 2022-12-02 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/947 From sgehwolf at openjdk.org Fri Dec 23 18:03:04 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 18:03:04 GMT Subject: [jdk17u-dev] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: References: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> Message-ID: On Sat, 3 Dec 2022 22:57:02 GMT, Alexander Veit wrote: >> Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d > > OCA /signed 2022-12-02 @veita Please change the PR title to `Backport a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d`. That will help the bots recognize it as a backport and will subsequently change the PR title back to the original bug synopsis. It also seems the tests are missing. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/947 From duke at openjdk.org Fri Dec 23 18:03:04 2022 From: duke at openjdk.org (Alexander Veit) Date: Fri, 23 Dec 2022 18:03:04 GMT Subject: [jdk17u-dev] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: References: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> Message-ID: On Mon, 5 Dec 2022 10:05:02 GMT, Severin Gehwolf wrote: > It also seems the tests are missing. https://bugs.openjdk.org/browse/JDK-8280890 seems to cover a slightly different issue than https://bugs.openjdk.org/browse/JDK-8297684. I don't know if the changes in `keytool` are applicable for Java 17. So to be as least invasive as possible I've only backported the parts relevant for the latter issue. Regarding the test, I could copy the files that were added in 19 to the PR. However, I don't know if they actually test `keytool` or the algorithm constraints, or both. One last question: Does there exist documentation about how to configure an IDE (preferably Eclipse) to compile the JDK. Currently I don't have a workspace that compiles `test/jdk` without errors. So making changes there is kind of blind flying. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/947 From duke at openjdk.org Fri Dec 23 18:03:04 2022 From: duke at openjdk.org (Alexander Veit) Date: Fri, 23 Dec 2022 18:03:04 GMT Subject: [jdk17u-dev] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: References: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> Message-ID: On Mon, 5 Dec 2022 12:48:59 GMT, Alexander Veit wrote: > It also seems the tests are missing. Backported the full patch for JDK-8280890 (including tests). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/947 From sgehwolf at openjdk.org Fri Dec 23 18:21:05 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 23 Dec 2022 18:21:05 GMT Subject: [jdk17u-dev] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: References: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> Message-ID: On Tue, 6 Dec 2022 08:30:42 GMT, Alexander Veit wrote: >>> It also seems the tests are missing. >> >> https://bugs.openjdk.org/browse/JDK-8280890 seems to cover a slightly different issue than https://bugs.openjdk.org/browse/JDK-8297684. I don't know if the changes in `keytool` are applicable for Java 17. So to be as least invasive as possible I've only backported the parts relevant for the latter issue. >> >> Regarding the test, I could copy the files that were added in 19 to the PR. However, I don't know if they actually test `keytool` or the algorithm constraints, or both. >> >> One last question: Does there exist documentation about how to configure an IDE (preferably Eclipse) to compile the JDK. Currently I don't have a workspace that compiles `test/jdk` without errors. So making changes there is kind of blind flying. > >> It also seems the tests are missing. > > Backported the full patch for JDK-8280890 (including tests). @veita Shame this took so long. But this has been fixed with: https://github.com/openjdk/jdk17u/commit/0ab310eafb4b1225c7db19f7a3d1d4620ee5c7df (should be in 17.0.6) in January. Feel free to verify with a nightly build once available. This PR should be closed. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/947 From duke at openjdk.org Fri Dec 23 18:28:08 2022 From: duke at openjdk.org (Alexander Veit) Date: Fri, 23 Dec 2022 18:28:08 GMT Subject: [jdk17u-dev] RFR: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> References: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> Message-ID: On Sat, 3 Dec 2022 22:42:54 GMT, Alexander Veit wrote: > Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d Great. Thank you! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/947 From duke at openjdk.org Fri Dec 23 18:38:03 2022 From: duke at openjdk.org (Alexander Veit) Date: Fri, 23 Dec 2022 18:38:03 GMT Subject: [jdk17u-dev] Withdrawn: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR In-Reply-To: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> References: <9g5Rr7gquxqDWr0bRKsl-NCMR_Qr6IUxc1VqCJIEOsY=.1cdebc1f-b1d3-4f9e-ac2a-485f306320db@github.com> Message-ID: On Sat, 3 Dec 2022 22:42:54 GMT, Alexander Veit wrote: > Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/947 From goetz at openjdk.org Fri Dec 23 20:42:30 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Dec 2022 20:42:30 GMT Subject: [jdk17u-dev] RFR: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 251bff6beeafcd98824dab60e9831c0175fe0689 Changes: https://git.openjdk.org/jdk17u-dev/pull/985/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=985&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292877 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/985.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/985/head:pull/985 PR: https://git.openjdk.org/jdk17u-dev/pull/985 From goetz at openjdk.org Sat Dec 24 10:33:43 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 24 Dec 2022 10:33:43 GMT Subject: [jdk17u] RFR: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking Message-ID: This is a follow up to JDK-8291456 and JDK-8256811 which were backported to 17.0.6. I had to resolve this. ------------- Commit messages: - Backport 99c3ab01773fcab885aa041345aab1a1ad4d852f Changes: https://git.openjdk.org/jdk17u/pull/364/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=364&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293010 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u/pull/364.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/364/head:pull/364 PR: https://git.openjdk.org/jdk17u/pull/364 From goetz at openjdk.org Sat Dec 24 10:33:44 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 24 Dec 2022 10:33:44 GMT Subject: [jdk17u] RFR: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking In-Reply-To: References: Message-ID: <0TWDW9jLkFoplJy5u8El1k7CdItLMAwUXBINVo2fuQg=.2092aaec-d87c-444e-ba9d-4f3fc148cbc8@github.com> On Sat, 24 Dec 2022 10:26:26 GMT, Goetz Lindenmaier wrote: > This is a follow up to JDK-8291456 and JDK-8256811 which were backported to 17.0.6. > > I had to resolve this. @adinn you might want to have a look at this. ------------- PR: https://git.openjdk.org/jdk17u/pull/364 From goetz at openjdk.org Sat Dec 24 10:47:00 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 24 Dec 2022 10:47:00 GMT Subject: [jdk17u-dev] RFR: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist In-Reply-To: References: Message-ID: On Fri, 23 Dec 2022 14:43:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. Pre submit failure: java/util/DoubleStreamSums/CompensatedSums.java known to be failing, unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/984 From adinn at openjdk.org Sat Dec 24 11:19:02 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Sat, 24 Dec 2022 11:19:02 GMT Subject: [jdk17u] RFR: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking In-Reply-To: References: Message-ID: On Sat, 24 Dec 2022 10:26:26 GMT, Goetz Lindenmaier wrote: > This is a follow up to JDK-8291456 and JDK-8256811 which were backported to 17.0.6. > > I had to resolve this. @GoeLin I agree this needs backporting to jdk17u. ------------- Marked as reviewed by adinn (Reviewer). PR: https://git.openjdk.org/jdk17u/pull/364 From chegar at openjdk.org Sat Dec 24 13:24:02 2022 From: chegar at openjdk.org (Chris Hegarty) Date: Sat, 24 Dec 2022 13:24:02 GMT Subject: [jdk17u-dev] RFR: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes In-Reply-To: <_QZEkGlLTo3mj94cWJrhe7o2tup5YAAyOMDRg0KXDyk=.b4947e69-f81f-4e72-88e9-c07a6899752f@github.com> References: <_QZEkGlLTo3mj94cWJrhe7o2tup5YAAyOMDRg0KXDyk=.b4947e69-f81f-4e72-88e9-c07a6899752f@github.com> Message-ID: On Thu, 22 Dec 2022 09:08:03 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [a7d6de71](https://github.com/openjdk/jdk/commit/a7d6de71bb83c8715654f61dd166aad6e8dab847) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 21 Dec 2022 and was reviewed by Daniel Fuchs, Daniel Jeli?ski and Jaikiran Pai. > > Thanks Clean backport, just awaiting fix request approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/964 From serb at openjdk.org Sat Dec 24 22:33:30 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 24 Dec 2022 22:33:30 GMT Subject: [jdk11u-dev] RFR: 8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux Message-ID: Hi all, This pull request contains a backport of commit [d0f4366a](https://github.com/openjdk/jdk/commit/d0f4366a859dd7ba9243495dadb460e78ad27006) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Phil Race on 5 Sep 2020 and was reviewed by Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport d0f4366a859dd7ba9243495dadb460e78ad27006 Changes: https://git.openjdk.org/jdk11u-dev/pull/1610/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1610&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8252715 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1610.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1610/head:pull/1610 PR: https://git.openjdk.org/jdk11u-dev/pull/1610 From serb at openjdk.org Sun Dec 25 05:58:39 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 25 Dec 2022 05:58:39 GMT Subject: [jdk17u-dev] RFR: 8298027: Remove SCCS id's from awt jtreg tests Message-ID: Hi all, This pull request contains a backport of commit [ba2d28e9](https://github.com/openjdk/jdk/commit/ba2d28e911f4f523334f98fd0186680acafb6f0a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jayathirth D V on 6 Dec 2022 and was reviewed by Alexey Ivanov. Thanks! ------------- Commit messages: - Backport ba2d28e911f4f523334f98fd0186680acafb6f0a Changes: https://git.openjdk.org/jdk17u-dev/pull/987/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=987&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298027 Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/987.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/987/head:pull/987 PR: https://git.openjdk.org/jdk17u-dev/pull/987 From serb at openjdk.org Sun Dec 25 05:58:57 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 25 Dec 2022 05:58:57 GMT Subject: [jdk17u-dev] RFR: 8293767: AWT test TestSinhalaChar.java has old SCCS markings Message-ID: <2IgNR_WXAIQAVCPcYZ9upq9Dub5GZmQUJmdTiK1Uy64=.8a8beb00-bd61-45be-b818-e318c66a5fe2@github.com> Hi all, This pull request contains a backport of commit [141d5f5d](https://github.com/openjdk/jdk/commit/141d5f5deec488531e410af875c781f4b70490da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Prasanta Sadhukhan on 16 Sep 2022 and was reviewed by Iris Clark. Thanks! ------------- Commit messages: - Backport 141d5f5deec488531e410af875c781f4b70490da Changes: https://git.openjdk.org/jdk17u-dev/pull/986/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=986&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293767 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/986.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/986/head:pull/986 PR: https://git.openjdk.org/jdk17u-dev/pull/986 From clanger at openjdk.org Sun Dec 25 06:59:01 2022 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 25 Dec 2022 06:59:01 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> Message-ID: On Mon, 19 Dec 2022 18:01:44 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Replaces a comment about JDK-8240666 > > OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)... > > THX @RealCLanger JDK 17 [openjdk/jdk17u-dev#982](https://github.com/openjdk/jdk17u-dev/pull/982) JDK 20 [openjdk/jdk20#76](https://github.com/openjdk/jdk20/pull/76) Hi @Karm, I already did the backports, they are already integrated. You can close your PRs... ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From clanger at openjdk.org Sun Dec 25 07:17:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 25 Dec 2022 07:17:55 GMT Subject: [jdk17u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Fri, 23 Dec 2022 09:48:50 GMT, Nagata-Haruhito wrote: > Thank you for your advice. Will I need retype "/integrate" after JBS label and comment is updated ? No, I just approved the backport. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/963 From duke at openjdk.org Sun Dec 25 07:17:56 2022 From: duke at openjdk.org (Nagata-Haruhito) Date: Sun, 25 Dec 2022 07:17:56 GMT Subject: [jdk17u-dev] Integrated: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 03:12:05 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK17u. This fix can be applied cleanly. > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > > Thank you. This pull request has now been integrated. Changeset: e0368a2a Author: Nagata, Haruhito Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/e0368a2a48111a0f0ddfeb3a5a5342677fa11e0c Stats: 37 lines in 9 files changed: 14 ins; 0 del; 23 mod 8283606: Tests may fail with zh locale on MacOS Reviewed-by: clanger Backport-of: 7d545084f45af44386cb38172fd783f889a8c4e7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/963 From duke at openjdk.org Sun Dec 25 23:38:02 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Sun, 25 Dec 2022 23:38:02 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> Message-ID: <-HzYqhHr4vm7mny881s5GIgSWIzAoPDhGxT8M2nQOZA=.6c835013-380f-403c-99af-c272651ad6be@github.com> On Mon, 19 Dec 2022 18:01:44 GMT, Michal Karm Babacek wrote: >> Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). >> >> The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. >> >> The test passes with the patch, fails without it. >> >> >> $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Stopping sjavac server >> Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' >> >> In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. >> >> >> ## Unpatched Temurin-11.0.17+8 ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz >> >> >> ## Patched jdk11u ? >> >> $ java WebSocketTest >> Http Request >> http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> WebSocket Request >> ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz >> >> The patched version correctly leaves the latter part of the query param encoded. > > Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Replaces a comment about JDK-8240666 > > > OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)... > > > > > > THX @RealCLanger JDK 17 [openjdk/jdk17u-dev#982](https://github.com/openjdk/jdk17u-dev/pull/982) JDK 20 [openjdk/jdk20#76](https://github.com/openjdk/jdk20/pull/76) > > Hi @Karm, I already did the backports, they are already integrated. You can close your PRs... smile @RealCLanger, Oh, I see :-D Sorry for the noise. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Mon Dec 26 02:06:51 2022 From: duke at openjdk.org (Nagata-Haruhito) Date: Mon, 26 Dec 2022 02:06:51 GMT Subject: [jdk11u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS Message-ID: I would like to backport JDK-8283606 to JDK11u. This fix cannot be applied cleanly. - Test does not provided in JDK11u (test/langtools/jdk/javadoc/tool/testLocaleOption/TestLocaleOption.java) - Need to add test items that is removed from the following test in the latest version (test/langtools/jdk/javadoc/tool/EnsureNewOldDoclet.java) - Need to add more tests that are removed in latest version and have same problem. (test/langtools/tools/javadoc/6964914/TestStdDoclet.java, test/langtools/tools/javadoc/6964914/TestUserDoclet.java, and test/jdk/tools/pack200/DeprecatePack200.java) I tried to run these tests on Japanese Windows 10, and all tests are passed. But, I am not a author, so need a sponsor. Would you plese review this fix? Thank you. ------------- Commit messages: - Backport 7d545084f45af44386cb38172fd783f889a8c4e7 Changes: https://git.openjdk.org/jdk11u-dev/pull/1611/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1611&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283606 Stats: 54 lines in 11 files changed: 16 ins; 0 del; 38 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1611.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1611/head:pull/1611 PR: https://git.openjdk.org/jdk11u-dev/pull/1611 From clanger at openjdk.org Mon Dec 26 15:41:05 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 26 Dec 2022 15:41:05 GMT Subject: [jdk11u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Mon, 26 Dec 2022 02:00:01 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK11u. This fix cannot be applied cleanly. > - Test does not provided in JDK11u > (test/langtools/jdk/javadoc/tool/testLocaleOption/TestLocaleOption.java) > - Need to add test items that is removed from the following test in the latest version > (test/langtools/jdk/javadoc/tool/EnsureNewOldDoclet.java) > - Need to add more tests that are removed in latest version and have same problem. > (test/langtools/tools/javadoc/6964914/TestStdDoclet.java, > test/langtools/tools/javadoc/6964914/TestUserDoclet.java, and > test/jdk/tools/pack200/DeprecatePack200.java) > > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > Would you plese review this fix? > > Thank you. Looks good, thanks for the description of diffs. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1611 From chegar at openjdk.org Mon Dec 26 19:33:56 2022 From: chegar at openjdk.org (Chris Hegarty) Date: Mon, 26 Dec 2022 19:33:56 GMT Subject: [jdk17u-dev] Integrated: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes In-Reply-To: <_QZEkGlLTo3mj94cWJrhe7o2tup5YAAyOMDRg0KXDyk=.b4947e69-f81f-4e72-88e9-c07a6899752f@github.com> References: <_QZEkGlLTo3mj94cWJrhe7o2tup5YAAyOMDRg0KXDyk=.b4947e69-f81f-4e72-88e9-c07a6899752f@github.com> Message-ID: <0iYzvWYcIt8ogU3U7B_niYE6_qFhIr6TiP_TQiU9IoI=.77d80454-9f9b-4830-8d2b-cc1aa83d27d2@github.com> On Thu, 22 Dec 2022 09:08:03 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [a7d6de71](https://github.com/openjdk/jdk/commit/a7d6de71bb83c8715654f61dd166aad6e8dab847) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 21 Dec 2022 and was reviewed by Daniel Fuchs, Daniel Jeli?ski and Jaikiran Pai. > > Thanks This pull request has now been integrated. Changeset: 3ff9669b Author: Chris Hegarty URL: https://git.openjdk.org/jdk17u-dev/commit/3ff9669b3f2612ecc9b970412dd4bcfdf4e0bf01 Stats: 42 lines in 3 files changed: 39 ins; 0 del; 3 mod 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes Backport-of: a7d6de71bb83c8715654f61dd166aad6e8dab847 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/964 From serb at openjdk.org Mon Dec 26 23:19:59 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 26 Dec 2022 23:19:59 GMT Subject: [jdk11u-dev] Integrated: 8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux In-Reply-To: References: Message-ID: On Sat, 24 Dec 2022 22:21:11 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [d0f4366a](https://github.com/openjdk/jdk/commit/d0f4366a859dd7ba9243495dadb460e78ad27006) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Phil Race on 5 Sep 2020 and was reviewed by Sergey Bylokhov. > Thanks! This pull request has now been integrated. Changeset: c46dcc56 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/c46dcc56aa5824b14b37069d8ab85dda1eec0f3f Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux Backport-of: d0f4366a859dd7ba9243495dadb460e78ad27006 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1610 From goetz at openjdk.org Tue Dec 27 08:56:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 08:56:02 GMT Subject: [jdk17u] Integrated: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking In-Reply-To: References: Message-ID: On Sat, 24 Dec 2022 10:26:26 GMT, Goetz Lindenmaier wrote: > This is a follow up to JDK-8291456 and JDK-8256811 which were backported to 17.0.6. > > I had to resolve this. This pull request has now been integrated. Changeset: 41c9d7dc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/41c9d7dc572340e80f46bc40bd673cc2c14ec3e1 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking Reviewed-by: adinn Backport-of: 99c3ab01773fcab885aa041345aab1a1ad4d852f ------------- PR: https://git.openjdk.org/jdk17u/pull/364 From goetz at openjdk.org Tue Dec 27 09:02:17 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:02:17 GMT Subject: [jdk17u-dev] Integrated: 8271471: [IR Framework] Rare occurrence of "" in PrintIdeal/PrintOptoAssembly can let tests fail In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 13:05:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: e6d369c6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e6d369c6d72d7d49c323e603555b6c2f8a4668d9 Stats: 102 lines in 5 files changed: 78 ins; 11 del; 13 mod 8271471: [IR Framework] Rare occurrence of "" in PrintIdeal/PrintOptoAssembly can let tests fail Backport-of: 3677734584859e1b4bea65f6719e839f949c9236 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/969 From goetz at openjdk.org Tue Dec 27 09:05:01 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:05:01 GMT Subject: [jdk17u-dev] Integrated: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 11:01:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 5194b981 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5194b981ac59fefe5b01f1898ac78ca59c482c19 Stats: 84 lines in 2 files changed: 57 ins; 5 del; 22 mod 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out Backport-of: 46684a4efa165d97c0ef8f56248ee82003acdb7b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/962 From goetz at openjdk.org Tue Dec 27 09:07:08 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:07:08 GMT Subject: [jdk17u-dev] Integrated: 8279024: Remove javascript references from clhsdb.html In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 10:02:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: c8caf68e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c8caf68e3f2e803d7651016e996446038c03afad Stats: 52 lines in 2 files changed: 1 ins; 49 del; 2 mod 8279024: Remove javascript references from clhsdb.html Backport-of: d0ea7c9db9cc9ce80b60c2f94c53bb307792fc51 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/967 From goetz at openjdk.org Tue Dec 27 09:10:15 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:10:15 GMT Subject: [jdk17u-dev] Integrated: 8244669: convert clhsdb "mem" command from javascript to java In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 10:40:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > Did not apply clean because in head dead variable > String format = ""; > was removed in CommandProcessor (8277413). > I removed that too. This pull request has now been integrated. Changeset: 554f17b0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/554f17b0b649dcd4a65b1f37b0873776e5dfaa32 Stats: 158 lines in 3 files changed: 121 ins; 29 del; 8 mod 8244669: convert clhsdb "mem" command from javascript to java Reviewed-by: clanger Backport-of: eaefb1a1ed9edea440628e3a5c5483ebd52bfcb0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/968 From goetz at openjdk.org Tue Dec 27 09:10:27 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:10:27 GMT Subject: [jdk17u-dev] RFR: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception" [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.7-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/981/files - new: https://git.openjdk.org/jdk17u-dev/pull/981/files/5fd10f1b..5fd10f1b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=981&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=981&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/981.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/981/head:pull/981 PR: https://git.openjdk.org/jdk17u-dev/pull/981 From goetz at openjdk.org Tue Dec 27 09:12:36 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:12:36 GMT Subject: [jdk17u-dev] RFR: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.7-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/984/files - new: https://git.openjdk.org/jdk17u-dev/pull/984/files/5b3cd24d..5b3cd24d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=984&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=984&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/984.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/984/head:pull/984 PR: https://git.openjdk.org/jdk17u-dev/pull/984 From goetz at openjdk.org Tue Dec 27 09:17:36 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:17:36 GMT Subject: [jdk17u-dev] RFR: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception" [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.7-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8274911 - Backport f62346066869b681d1cc9f63775393b11a48722a - Backport 3677734584859e1b4bea65f6719e839f949c9236 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/981/files - new: https://git.openjdk.org/jdk17u-dev/pull/981/files/5fd10f1b..7ac9d46c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=981&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=981&range=01-02 Stats: 373 lines in 18 files changed: 232 ins; 83 del; 58 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/981.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/981/head:pull/981 PR: https://git.openjdk.org/jdk17u-dev/pull/981 From goetz at openjdk.org Tue Dec 27 09:22:36 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:22:36 GMT Subject: [jdk17u-dev] RFR: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.7-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8279119-2 - Backport 2a59ebbba391ee0d70604027081712f1c2dfd1fe - Backport d0ea7c9db9cc9ce80b60c2f94c53bb307792fc51 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/984/files - new: https://git.openjdk.org/jdk17u-dev/pull/984/files/5b3cd24d..5ebcd08c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=984&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=984&range=01-02 Stats: 488 lines in 24 files changed: 343 ins; 75 del; 70 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/984.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/984/head:pull/984 PR: https://git.openjdk.org/jdk17u-dev/pull/984 From goetz at openjdk.org Tue Dec 27 09:23:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:23:56 GMT Subject: [jdk17u-dev] Integrated: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception" In-Reply-To: References: Message-ID: On Fri, 23 Dec 2022 10:33:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 98045382 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/98045382c3402e7b6b638cdd8c1e627ecda6a3b1 Stats: 128 lines in 4 files changed: 55 ins; 38 del; 35 mod 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception" Backport-of: f62346066869b681d1cc9f63775393b11a48722a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/981 From goetz at openjdk.org Tue Dec 27 09:25:55 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:25:55 GMT Subject: [jdk17u-dev] Integrated: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist In-Reply-To: References: Message-ID: <7pDefERXI4LuQBicmwJY-mO17E45iHtR7QGK89aixIs=.cb48a225-482d-41e4-98dd-46c5c2a9273f@github.com> On Fri, 23 Dec 2022 14:43:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: ddaa77b0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ddaa77b0185f25e3ea080e0624dcd7598af77b9f Stats: 189 lines in 1 file changed: 0 ins; 165 del; 24 mod 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist Backport-of: 2a59ebbba391ee0d70604027081712f1c2dfd1fe ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/984 From goetz at openjdk.org Tue Dec 27 09:29:01 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:29:01 GMT Subject: [jdk17u-dev] Integrated: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 13:43:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: d8cc8a8e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d8cc8a8e44c3b6d065d9e631725bbce1d7483bce Stats: 98 lines in 3 files changed: 89 ins; 3 del; 6 mod 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile Backport-of: f66070b00d4311c6e3a6fbf38956fa2d5da5fada ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/970 From goetz at openjdk.org Tue Dec 27 09:30:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:30:56 GMT Subject: [jdk17u-dev] Integrated: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432 In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 14:21:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: d72709ff Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d72709ffc8cc17a7d7fa309403a3f4858e65360e Stats: 5 lines in 2 files changed: 4 ins; 1 del; 0 mod 8285399: JNI exception pending in awt_GraphicsEnv.c:1432 Backport-of: c156bcc599534ae989bc9cbd001e7c150da8096c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/972 From goetz at openjdk.org Tue Dec 27 09:33:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 09:33:56 GMT Subject: [jdk17u-dev] Integrated: 8288130: compiler error with AP and explicit record accessor In-Reply-To: <3uY-sFPKCeUgy6wHuZ-tg62MR0TYXYKeXvG5R7TOuIg=.d2486215-243c-4bec-bbf0-2d74090062c2@github.com> References: <3uY-sFPKCeUgy6wHuZ-tg62MR0TYXYKeXvG5R7TOuIg=.d2486215-243c-4bec-bbf0-2d74090062c2@github.com> Message-ID: On Thu, 22 Dec 2022 14:18:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: e770114a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e770114a850d6e049c60a37f52fc4b3c1ab8687b Stats: 308 lines in 5 files changed: 124 ins; 79 del; 105 mod 8288130: compiler error with AP and explicit record accessor Backport-of: 53b37fe1535388eb14e04c620a6b0118ed8884a0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/971 From goetz at openjdk.org Tue Dec 27 10:02:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 10:02:02 GMT Subject: [jdk17u-dev] Integrated: 8155246: Throw error if default java.security file is missing In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 15:17:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 6262937f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6262937f5e9561181aee6d87dd01bd4cd4bb5a99 Stats: 125 lines in 4 files changed: 107 ins; 17 del; 1 mod 8155246: Throw error if default java.security file is missing Backport-of: 9d7c13eb14c525485e7739fcfacd044aa3bbc12d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/973 From goetz at openjdk.org Tue Dec 27 10:05:57 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 10:05:57 GMT Subject: [jdk17u-dev] Integrated: 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 15:24:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > Requires follow-up 8292660. This pull request has now been integrated. Changeset: ade0edf8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ade0edf8a5aac03082a440a154d2a7c23fb63672 Stats: 24 lines in 1 file changed: 18 ins; 0 del; 6 mod 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion Backport-of: a25e1dc53cecc5dd917ac0f76fd86ef1f074adba ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/974 From goetz at openjdk.org Tue Dec 27 10:07:55 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 10:07:55 GMT Subject: [jdk17u-dev] Integrated: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly In-Reply-To: References: Message-ID: On Fri, 23 Dec 2022 20:35:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 9729dad0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9729dad09c391b694c3ac769517458617fe2c86d Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly Backport-of: 251bff6beeafcd98824dab60e9831c0175fe0689 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/985 From goetz at openjdk.org Tue Dec 27 10:15:09 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 10:15:09 GMT Subject: [jdk17u-dev] RFR: 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly [v3] In-Reply-To: References: Message-ID: <9zQgGx1oASsx_2fFGVqduN6GDKEfxJA3B98ck9z5FRM=.46833109-1ede-4e4b-a584-1021bbcc9b22@github.com> > I backport this for parity with 17.0.7-oracle. > > Clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into goetz_backport_8292660 - Add test forgotten in first push - Backport 730ced9a109953ca1c3b7bfd6a3eeac5b85892c5 - Backport a25e1dc53cecc5dd917ac0f76fd86ef1f074adba ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/979/files - new: https://git.openjdk.org/jdk17u-dev/pull/979/files/3c25de22..d8b84772 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=979&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=979&range=01-02 Stats: 1323 lines in 38 files changed: 689 ins; 397 del; 237 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/979.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/979/head:pull/979 PR: https://git.openjdk.org/jdk17u-dev/pull/979 From goetz at openjdk.org Tue Dec 27 10:15:10 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 10:15:10 GMT Subject: [jdk17u-dev] Integrated: 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 21:14:52 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > Clean. This pull request has now been integrated. Changeset: 8b0c5b92 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8b0c5b924cf8b10d1368aae2202fe9ab3bb6f78b Stats: 123 lines in 4 files changed: 108 ins; 13 del; 2 mod 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly Backport-of: 730ced9a109953ca1c3b7bfd6a3eeac5b85892c5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/979 From goetz at openjdk.org Tue Dec 27 10:17:10 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 10:17:10 GMT Subject: [jdk17u-dev] Integrated: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 15:29:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: eb95804c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/eb95804cfc3f4c0bd6fcd884d9d3b6b9bd45cd68 Stats: 371 lines in 2 files changed: 371 ins; 0 del; 0 mod 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling Backport-of: caae53f4dadd146426a1a2cd121ac00bb98ebc97 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/975 From goetz at openjdk.org Tue Dec 27 10:17:57 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 10:17:57 GMT Subject: [jdk17u-dev] Integrated: 8293562: KeepAliveCache Blocks Threads while Closing Connections In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 21:33:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 244d1942 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/244d1942d2e9f2ba75267acc16a02041c1e8080e Stats: 346 lines in 3 files changed: 278 ins; 43 del; 25 mod 8293562: KeepAliveCache Blocks Threads while Closing Connections Backport-of: 03f25a9c6924430ec4063b801b2b6ca55b9067c9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/980 From serb at openjdk.org Tue Dec 27 11:11:24 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 27 Dec 2022 11:11:24 GMT Subject: [jdk11u-dev] RFR: 8298027: Remove SCCS id's from awt jtreg tests Message-ID: Hi all, This pull request contains a backport of commit [ba2d28e9](https://github.com/openjdk/jdk/commit/ba2d28e911f4f523334f98fd0186680acafb6f0a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jayathirth D V on 6 Dec 2022 and was reviewed by Alexey Ivanov. Thanks! ------------- Commit messages: - Backport ba2d28e911f4f523334f98fd0186680acafb6f0a Changes: https://git.openjdk.org/jdk11u-dev/pull/1613/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1613&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298027 Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1613.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1613/head:pull/1613 PR: https://git.openjdk.org/jdk11u-dev/pull/1613 From serb at openjdk.org Tue Dec 27 11:12:52 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 27 Dec 2022 11:12:52 GMT Subject: [jdk11u-dev] RFR: 8293767: AWT test TestSinhalaChar.java has old SCCS markings Message-ID: Hi all, This pull request contains a backport of commit [141d5f5d](https://github.com/openjdk/jdk/commit/141d5f5deec488531e410af875c781f4b70490da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Prasanta Sadhukhan on 16 Sep 2022 and was reviewed by Iris Clark. Thanks! ------------- Commit messages: - Backport 141d5f5deec488531e410af875c781f4b70490da Changes: https://git.openjdk.org/jdk11u-dev/pull/1612/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1612&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293767 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1612.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1612/head:pull/1612 PR: https://git.openjdk.org/jdk11u-dev/pull/1612 From goetz at openjdk.org Tue Dec 27 11:43:38 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 11:43:38 GMT Subject: [jdk17u-dev] RFR: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap" Message-ID: I backport this for parity with 17.0.7-oracle. Requires follwo up 8275173 ------------- Commit messages: - Backport df125f680b6a4517109be80512a113064ca6281d Changes: https://git.openjdk.org/jdk17u-dev/pull/988/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=988&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273410 Stats: 233 lines in 3 files changed: 232 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/988.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/988/head:pull/988 PR: https://git.openjdk.org/jdk17u-dev/pull/988 From goetz at openjdk.org Tue Dec 27 17:26:49 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 17:26:49 GMT Subject: [jdk17u-dev] RFR: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 649f2d8835027128c6c8cf37236808094a12a35f Changes: https://git.openjdk.org/jdk17u-dev/pull/990/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=990&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8065097 Stats: 131 lines in 2 files changed: 37 ins; 4 del; 90 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/990.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/990/head:pull/990 PR: https://git.openjdk.org/jdk17u-dev/pull/990 From goetz at openjdk.org Tue Dec 27 17:29:35 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Dec 2022 17:29:35 GMT Subject: [jdk17u-dev] RFR: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 Message-ID: I backport this for parity with 17.0.7-oracle. Follow up to 8273410. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/988 Commit messages: - Backport 451a296510994ff9fe1e0381900ffa9a8a1caa54 Changes: https://git.openjdk.org/jdk17u-dev/pull/989/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=989&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275173 Stats: 12 lines in 1 file changed: 10 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/989.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/989/head:pull/989 PR: https://git.openjdk.org/jdk17u-dev/pull/989 From phh at openjdk.org Tue Dec 27 20:52:02 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 27 Dec 2022 20:52:02 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <-HzYqhHr4vm7mny881s5GIgSWIzAoPDhGxT8M2nQOZA=.6c835013-380f-403c-99af-c272651ad6be@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> <-HzYqhHr4vm7mny881s5GIgSWIzAoPDhGxT8M2nQOZA=.6c835013-380f-403c-99af-c272651ad6be@github.com> Message-ID: <3ymiw6TeCzZmMB1rYsPBfMJ1nhOUvPsm7nziz_HABzE=.aec3b8e1-8213-48a5-a8ce-7819b000932f@github.com> On Sun, 25 Dec 2022 23:35:27 GMT, Michal Karm Babacek wrote: >> Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision: >> >> Replaces a comment about JDK-8240666 > >> > > OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)... >> > >> > >> > THX @RealCLanger JDK 17 [openjdk/jdk17u-dev#982](https://github.com/openjdk/jdk17u-dev/pull/982) JDK 20 [openjdk/jdk20#76](https://github.com/openjdk/jdk20/pull/76) >> >> Hi @Karm, I already did the backports, they are already integrated. You can close your PRs... smile > > @RealCLanger, Oh, I see :-D Sorry for the noise. @Karm, please add /integrate and I'll sponsor. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Tue Dec 27 21:36:50 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Tue, 27 Dec 2022 21:36:50 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5] In-Reply-To: <3ymiw6TeCzZmMB1rYsPBfMJ1nhOUvPsm7nziz_HABzE=.aec3b8e1-8213-48a5-a8ce-7819b000932f@github.com> References: <2w2TIOorYiyP8A-SiuKQ0v4AK9T1F605m-VtYpgvNhY=.96544db3-8c8f-4b39-bdf2-4e42fb08988a@github.com> <-HzYqhHr4vm7mny881s5GIgSWIzAoPDhGxT8M2nQOZA=.6c835013-380f-403c-99af-c272651ad6be@github.com> <3ymiw6TeCzZmMB1rYsPBfMJ1nhOUvPsm7nziz_HABzE=.aec3b8e1-8213-48a5-a8ce-7819b000932f@github.com> Message-ID: <86X4r4uGsi8rT3dyZV2ontxB08k71DMXX6Usqctact8=.b22594d3-52c5-437a-be3f-f445f9303b34@github.com> On Tue, 27 Dec 2022 20:49:21 GMT, Paul Hohensee wrote: >>> > > OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)... >>> > >>> > >>> > THX @RealCLanger JDK 17 [openjdk/jdk17u-dev#982](https://github.com/openjdk/jdk17u-dev/pull/982) JDK 20 [openjdk/jdk20#76](https://github.com/openjdk/jdk20/pull/76) >>> >>> Hi @Karm, I already did the backports, they are already integrated. You can close your PRs... smile >> >> @RealCLanger, Oh, I see :-D Sorry for the noise. > > @Karm, please add /integrate and I'll sponsor. THX @phohensee : ) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Tue Dec 27 21:59:03 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Tue, 27 Dec 2022 21:59:03 GMT Subject: [jdk11u-dev] Integrated: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 01:52:47 GMT, Michal Karm Babacek wrote: > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. This pull request has now been integrated. Changeset: ce106888 Author: Karm Michal Babacek Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/ce10688829436a4172ce303283ead277b7e4c8db Stats: 228 lines in 2 files changed: 220 ins; 6 del; 2 mod 8245245: WebSocket can lose the URL encoding of URI query parameters 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body The fix updates jdk.internal.net.http.websocket.OpeningHandshake to avoid double encoding and decoding of URL Reviewed-by: phh, sgehwolf Backport-of: c07ce7eec71aefbd3cb624e03ca53f5148d01f19 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From duke at openjdk.org Tue Dec 27 22:08:54 2022 From: duke at openjdk.org (Nagata-Haruhito) Date: Tue, 27 Dec 2022 22:08:54 GMT Subject: [jdk11u-dev] Integrated: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Mon, 26 Dec 2022 02:00:01 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK11u. This fix cannot be applied cleanly. > - Test does not provided in JDK11u > (test/langtools/jdk/javadoc/tool/testLocaleOption/TestLocaleOption.java) > - Need to add test items that is removed from the following test in the latest version > (test/langtools/jdk/javadoc/tool/EnsureNewOldDoclet.java) > - Need to add more tests that are removed in latest version and have same problem. > (test/langtools/tools/javadoc/6964914/TestStdDoclet.java, > test/langtools/tools/javadoc/6964914/TestUserDoclet.java, and > test/jdk/tools/pack200/DeprecatePack200.java) > > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > Would you plese review this fix? > > Thank you. This pull request has now been integrated. Changeset: 4895d4ce Author: Nagata, Haruhito Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/4895d4ce5e2f9acefa6656471ebfb510125b3c31 Stats: 54 lines in 11 files changed: 16 ins; 0 del; 38 mod 8283606: Tests may fail with zh locale on MacOS Reviewed-by: clanger Backport-of: 7d545084f45af44386cb38172fd783f889a8c4e7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1611 From serb at openjdk.org Wed Dec 28 03:58:26 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 28 Dec 2022 03:58:26 GMT Subject: [jdk11u-dev] RFR: 8213130: Update ProblemList after verification of jtreg tests in Win 7 Message-ID: Hi all, This pull request contains a backport of commit [04104cea](https://github.com/openjdk/jdk/commit/04104ceaea8cf2f2c52b85baa24f7da4f1e49f6b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jayathirth D V on 26 Oct 2018 and was reviewed by Prasanta Sadhukhan. Thanks! ------------- Commit messages: - Backport 04104ceaea8cf2f2c52b85baa24f7da4f1e49f6b Changes: https://git.openjdk.org/jdk11u-dev/pull/1614/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1614&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8213130 Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1614.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1614/head:pull/1614 PR: https://git.openjdk.org/jdk11u-dev/pull/1614 From serb at openjdk.org Wed Dec 28 06:14:09 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 28 Dec 2022 06:14:09 GMT Subject: [jdk11u-dev] RFR: 8255710: Opensource unit/regression tests for CMM Message-ID: Hi all, This pull request contains a backport of commit [98ccfbf4](https://github.com/openjdk/jdk/commit/98ccfbf46915791208f80b51f68f3916a68b8aaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Jan 2021 and was reviewed by Pankaj Bansal and Phil Race. Thanks! ------------- Commit messages: - Backport 98ccfbf46915791208f80b51f68f3916a68b8aaf Changes: https://git.openjdk.org/jdk11u-dev/pull/1615/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1615&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8255710 Stats: 457 lines in 8 files changed: 457 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1615.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1615/head:pull/1615 PR: https://git.openjdk.org/jdk11u-dev/pull/1615 From goetz at openjdk.org Wed Dec 28 09:28:58 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Dec 2022 09:28:58 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.6+9 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking - 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/991/files Stats: 189 lines in 5 files changed: 144 ins; 28 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/991.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/991/head:pull/991 PR: https://git.openjdk.org/jdk17u-dev/pull/991 From goetz at openjdk.org Wed Dec 28 09:38:57 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Dec 2022 09:38:57 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: <1p9WXXtPOejdDeoK7THhdOnicUFZoP9E_KBfYtWZW5I=.2c16afeb-d5e2-4641-aba0-c4abd2a31145@github.com> Merge build tag 11.0.18+9 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/1616/files Stats: 183 lines in 4 files changed: 139 ins; 28 del; 16 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1616.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1616/head:pull/1616 PR: https://git.openjdk.org/jdk11u-dev/pull/1616 From goetz at openjdk.org Wed Dec 28 09:39:58 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Dec 2022 09:39:58 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: <8Ku_D6qDCEFHwMjH6d7ut7SSu-kBp9NFia-xmWEpKSQ=.4f3dcfa7-9921-401a-bbbc-cf9562051247@github.com> On Wed, 28 Dec 2022 09:22:51 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.6+9 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: 11a53b76 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/11a53b76cfb2426ba5ce04079c2a95132a389998 Stats: 189 lines in 5 files changed: 144 ins; 28 del; 17 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/991 From goetz at openjdk.org Wed Dec 28 09:46:51 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Dec 2022 09:46:51 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: <1p9WXXtPOejdDeoK7THhdOnicUFZoP9E_KBfYtWZW5I=.2c16afeb-d5e2-4641-aba0-c4abd2a31145@github.com> References: <1p9WXXtPOejdDeoK7THhdOnicUFZoP9E_KBfYtWZW5I=.2c16afeb-d5e2-4641-aba0-c4abd2a31145@github.com> Message-ID: On Wed, 28 Dec 2022 09:34:10 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.18+9 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: b5e97eeb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b5e97eebba23b873e2e928ef8f0630e63ae284a7 Stats: 183 lines in 4 files changed: 139 ins; 28 del; 16 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1616 From goetz at openjdk.org Wed Dec 28 10:02:57 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Dec 2022 10:02:57 GMT Subject: [jdk17u-dev] RFR: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap" In-Reply-To: References: Message-ID: On Tue, 27 Dec 2022 11:37:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > Requires follwo up 8275173 Pre-submit failure: CompensatedSums.java Known to be shaky, unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/988 From duke at openjdk.org Wed Dec 28 12:02:56 2022 From: duke at openjdk.org (xpbob) Date: Wed, 28 Dec 2022 12:02:56 GMT Subject: [jdk17u-dev] RFR: 8298526: JFR: Generate missing filename for time-bound recordings Message-ID: Backport de8153cab76606350eb0ecc4302b23c52f0565a6 ------------- Commit messages: - Backport de8153cab76606350eb0ecc4302b23c52f0565a6 Changes: https://git.openjdk.org/jdk17u-dev/pull/992/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=992&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298526 Stats: 38 lines in 2 files changed: 24 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/992.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/992/head:pull/992 PR: https://git.openjdk.org/jdk17u-dev/pull/992 From egahlin at openjdk.org Wed Dec 28 13:42:06 2022 From: egahlin at openjdk.org (Erik Gahlin) Date: Wed, 28 Dec 2022 13:42:06 GMT Subject: [jdk17u-dev] RFR: 8298526: JFR: Generate missing filename for time-bound recordings In-Reply-To: References: Message-ID: On Wed, 28 Dec 2022 11:56:11 GMT, xpbob wrote: > Backport de8153cab76606350eb0ecc4302b23c52f0565a6 This is more of an enhancement than a bug as it changes how -XX:StartFlightRecording and icmd JFR.start work. This is not a low risk fix as it may impact scripts. There is also a very simple workaround, specify the filename manually, i.e -XX:StartFlightRecording:filename=recording.jfr If backporting this issue at all, we should wait until we are sure it works as expected in production, which means waiting after JDK 21 has been released. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/992 From duke at openjdk.org Wed Dec 28 14:36:54 2022 From: duke at openjdk.org (xpbob) Date: Wed, 28 Dec 2022 14:36:54 GMT Subject: [jdk17u-dev] Withdrawn: 8298526: JFR: Generate missing filename for time-bound recordings In-Reply-To: References: Message-ID: On Wed, 28 Dec 2022 11:56:11 GMT, xpbob wrote: > Backport de8153cab76606350eb0ecc4302b23c52f0565a6 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/992 From phh at openjdk.org Wed Dec 28 17:26:47 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 28 Dec 2022 17:26:47 GMT Subject: [jdk11u-dev] RFR: 8221621: FindTests.gmk cannot handle "=" in TEST.groups comments In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:23:09 GMT, Joshua Cao wrote: > clean backport Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1603 From phh at openjdk.org Wed Dec 28 17:32:57 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 28 Dec 2022 17:32:57 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook [v2] In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 19:22:18 GMT, Joshua Cao wrote: >> This fixes a crash in JDK 11. >> >> Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. > > Joshua Cao has updated the pull request incrementally with one additional commit since the last revision: > > Update HelloCustom copyright year The [JDK-8221621](https://bugs.openjdk.org/browse/JDK-8221621) backport https://github.com/openjdk/jdk11u-dev/pull/1603 is prerequisite for this one and is clean and trivial, so I've tagged it. This PR has been reviewed by @RealCLanger. We can wait for [JDK-8221621](https://bugs.openjdk.org/browse/JDK-8221621) approval before tagging [JDK-8221351](https://bugs.openjdk.org/browse/JDK-8221351). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From serb at openjdk.org Thu Dec 29 02:37:07 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Dec 2022 02:37:07 GMT Subject: [jdk17u-dev] Integrated: 8293767: AWT test TestSinhalaChar.java has old SCCS markings In-Reply-To: <2IgNR_WXAIQAVCPcYZ9upq9Dub5GZmQUJmdTiK1Uy64=.8a8beb00-bd61-45be-b818-e318c66a5fe2@github.com> References: <2IgNR_WXAIQAVCPcYZ9upq9Dub5GZmQUJmdTiK1Uy64=.8a8beb00-bd61-45be-b818-e318c66a5fe2@github.com> Message-ID: On Sun, 25 Dec 2022 05:03:42 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [141d5f5d](https://github.com/openjdk/jdk/commit/141d5f5deec488531e410af875c781f4b70490da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Prasanta Sadhukhan on 16 Sep 2022 and was reviewed by Iris Clark. > Thanks! This pull request has now been integrated. Changeset: 70f235d3 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/70f235d34e8d96caaf5a55940db863088ae76d72 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8293767: AWT test TestSinhalaChar.java has old SCCS markings Backport-of: 141d5f5deec488531e410af875c781f4b70490da ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/986 From serb at openjdk.org Thu Dec 29 02:44:02 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Dec 2022 02:44:02 GMT Subject: [jdk17u-dev] Integrated: 8298027: Remove SCCS id's from awt jtreg tests In-Reply-To: References: Message-ID: On Sun, 25 Dec 2022 05:09:03 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [ba2d28e9](https://github.com/openjdk/jdk/commit/ba2d28e911f4f523334f98fd0186680acafb6f0a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Jayathirth D V on 6 Dec 2022 and was reviewed by Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: bcdaebfa Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/bcdaebfa89bb26ba8a136f35142f1fa626b7dd5c Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod 8298027: Remove SCCS id's from awt jtreg tests Backport-of: ba2d28e911f4f523334f98fd0186680acafb6f0a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/987 From goetz at openjdk.org Thu Dec 29 09:33:59 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 09:33:59 GMT Subject: [jdk17u-dev] Integrated: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap" In-Reply-To: References: Message-ID: On Tue, 27 Dec 2022 11:37:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > Requires follwo up 8275173 This pull request has now been integrated. Changeset: 032f007f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/032f007f48940b008399780d57efafef0b152795 Stats: 233 lines in 3 files changed: 232 ins; 0 del; 1 mod 8273410: IR verification framework fails with "Should find method name in validIrRulesMap" Backport-of: df125f680b6a4517109be80512a113064ca6281d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/988 From goetz at openjdk.org Thu Dec 29 09:38:05 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 09:38:05 GMT Subject: [jdk17u-dev] Integrated: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off In-Reply-To: References: Message-ID: On Tue, 27 Dec 2022 17:18:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: e33c8717 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e33c871717fb6a97edb6ce27774b47d33507a4e0 Stats: 131 lines in 2 files changed: 37 ins; 4 del; 90 mod 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off Backport-of: 649f2d8835027128c6c8cf37236808094a12a35f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/990 From serb at openjdk.org Thu Dec 29 09:38:44 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Dec 2022 09:38:44 GMT Subject: [jdk17u-dev] RFR: 8288854: getLocalGraphicsEnvironment() on for multi-screen setups throws exception NPE Message-ID: Hi all, This pull request contains a backport of commit [cfc9a881](https://github.com/openjdk/jdk/commit/cfc9a881afd300bd7c1ce784287d1669308e89fc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 2 Jul 2022 and was reviewed by Alexander Zvegintsev and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport cfc9a881afd300bd7c1ce784287d1669308e89fc Changes: https://git.openjdk.org/jdk17u-dev/pull/994/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=994&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288854 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/994.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/994/head:pull/994 PR: https://git.openjdk.org/jdk17u-dev/pull/994 From goetz at openjdk.org Thu Dec 29 09:40:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 09:40:02 GMT Subject: [jdk17u-dev] Integrated: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency In-Reply-To: References: Message-ID: <1cvsRqi40SX8MoZcGCnAZWUIpb_eI5zW1dJTQKmFCms=.e3f314b2-4585-4fb4-8df3-3cb4500a5613@github.com> On Thu, 22 Dec 2022 15:47:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > I needed to resolve around phaseX.cpp:1770 because JDK-8289051: C2: Cleanup PhaseCCP::analyze() > is not in 17. This pull request has now been integrated. Changeset: c603f828 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c603f82804dfa1ed7e168b7d5fa4ac7afbf905ca Stats: 102 lines in 5 files changed: 81 ins; 2 del; 19 mod 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency Backport-of: 379f3094db0b8afe90ed6b7a341164222744085f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/976 From goetz at openjdk.org Thu Dec 29 09:46:18 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 09:46:18 GMT Subject: [jdk17u-dev] RFR: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.7-oracle. > > Follow up to 8273410. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8275173 - Backport 451a296510994ff9fe1e0381900ffa9a8a1caa54 - Backport df125f680b6a4517109be80512a113064ca6281d ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/989/files - new: https://git.openjdk.org/jdk17u-dev/pull/989/files/82ae269e..8e2220c2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=989&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=989&range=00-01 Stats: 325 lines in 10 files changed: 181 ins; 34 del; 110 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/989.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/989/head:pull/989 PR: https://git.openjdk.org/jdk17u-dev/pull/989 From goetz at openjdk.org Thu Dec 29 09:46:18 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 09:46:18 GMT Subject: [jdk17u-dev] Integrated: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 In-Reply-To: References: Message-ID: On Tue, 27 Dec 2022 11:56:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > Follow up to 8273410. This pull request has now been integrated. Changeset: 219041d7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/219041d77c17914b49a70b0252e1bd57427b395d Stats: 12 lines in 1 file changed: 10 ins; 0 del; 2 mod 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 Backport-of: 451a296510994ff9fe1e0381900ffa9a8a1caa54 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/989 From goetz at openjdk.org Thu Dec 29 09:47:55 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 09:47:55 GMT Subject: [jdk17u-dev] Integrated: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: On Fri, 23 Dec 2022 14:29:24 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 6042c6b9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6042c6b9bbacbff1bd47f087f0f19646a20eef97 Stats: 11195 lines in 24 files changed: 9975 ins; 274 del; 946 mod 8295530: Update Zlib Data Compression Library to Version 1.2.13 Backport-of: 0c13d66622a8c2be654bb867aa8c17421d1557ca ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/983 From goetz at openjdk.org Thu Dec 29 10:09:29 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 10:09:29 GMT Subject: [jdk17u-dev] RFR: 8281122: [IR Framework] Cleanup IR matching code in preparation for JDK-8280378 Message-ID: I backport this for parity with 17.0.7-oracle. Clean except for omitting the patch to TestMaskedMacroLogicVector.java. That test came with "8273322: Enhance macro logic optimization for masked logic operations." which is not backported. ------------- Commit messages: - Backport 2da677793f562236d473afe12b5c941f25f41377 Changes: https://git.openjdk.org/jdk17u-dev/pull/995/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=995&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8281122 Stats: 3589 lines in 56 files changed: 2756 ins; 766 del; 67 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/995.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/995/head:pull/995 PR: https://git.openjdk.org/jdk17u-dev/pull/995 From goetz at openjdk.org Thu Dec 29 10:10:36 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 10:10:36 GMT Subject: [jdk17u-dev] RFR: 8292297: Fix up loading of override java.security properties file Message-ID: <5l8evXLcIx6Z9l4tRYnHb-3pBogYe7Jsn6NeR6TDOO0=.6d3b1488-48be-464d-bb61-f634b51a93ce@github.com> I backport this for parity with 17.0.7-oracle. I had to resolve as 8280010: Remove double buffering of InputStream for Properties.load is not in 17. The new code comes without the double buffering, but as I understand it is also not needed in 17 and thus I left it as-is. ------------- Commit messages: - Backport 1f9ff413126fb68e07b8fc1f36dd3cb17093a484 Changes: https://git.openjdk.org/jdk17u-dev/pull/996/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=996&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292297 Stats: 166 lines in 3 files changed: 69 ins; 71 del; 26 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/996.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/996/head:pull/996 PR: https://git.openjdk.org/jdk17u-dev/pull/996 From goetz at openjdk.org Thu Dec 29 10:39:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 10:39:52 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook [v2] In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 19:22:18 GMT, Joshua Cao wrote: >> This fixes a crash in JDK 11. >> >> Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. > > Joshua Cao has updated the pull request incrementally with one additional commit since the last revision: > > Update HelloCustom copyright year Hi, I will not approve prerequisites if their only purpose is being preparation for another change as long as I did not decide to approve the other change. So I need the fix request for this here along with a good reason to backport it. Thanks. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From goetz at openjdk.org Thu Dec 29 12:27:35 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 12:27:35 GMT Subject: [jdk17u-dev] RFR: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport eec992c6b0ac77d08478d852a80c9470418d925d Changes: https://git.openjdk.org/jdk17u-dev/pull/997/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=997&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292602 Stats: 69 lines in 4 files changed: 69 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/997.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/997/head:pull/997 PR: https://git.openjdk.org/jdk17u-dev/pull/997 From goetz at openjdk.org Thu Dec 29 12:50:30 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 12:50:30 GMT Subject: [jdk17u-dev] RFR: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop Message-ID: <4RCCzB_6_FMmzkOARyq-j6d4khYIKeH5hirq8S_Ji6g=.f0b9efda-dbcf-419d-8a18-4520a96fe3d4@github.com> I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport dd51f7e0b75d3a16403608d89cd206ac0bedf882 Changes: https://git.openjdk.org/jdk17u-dev/pull/998/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=998&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293996 Stats: 65 lines in 2 files changed: 38 ins; 17 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/998.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/998/head:pull/998 PR: https://git.openjdk.org/jdk17u-dev/pull/998 From serb at openjdk.org Thu Dec 29 13:01:49 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Dec 2022 13:01:49 GMT Subject: [jdk11u-dev] Integrated: 8293767: AWT test TestSinhalaChar.java has old SCCS markings In-Reply-To: References: Message-ID: On Tue, 27 Dec 2022 10:22:38 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [141d5f5d](https://github.com/openjdk/jdk/commit/141d5f5deec488531e410af875c781f4b70490da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Prasanta Sadhukhan on 16 Sep 2022 and was reviewed by Iris Clark. > Thanks! This pull request has now been integrated. Changeset: 96fded95 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/96fded9518dd25bfa2ac66311df8ba14675c0cae Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8293767: AWT test TestSinhalaChar.java has old SCCS markings Backport-of: 141d5f5deec488531e410af875c781f4b70490da ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1612 From goetz at openjdk.org Thu Dec 29 13:02:37 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 13:02:37 GMT Subject: [jdk17u-dev] RFR: 8242115: C2 SATB barriers are not safepoint-safe Message-ID: <09GEDEaan3UjUvmvclPbpeAPPSLCqRkmYDSZk9s5zc0=.e38d01ee-48ea-4137-8d0f-d94a9f609094@github.com> I backport this for parity with 17.0.7-oracle. I had to resolve memnode.hpp and added control_dependency() which is called by this change. ------------- Commit messages: - Backport c6e3daa5fa0bdbe70e5bb63302bbce1abc5453fe Changes: https://git.openjdk.org/jdk17u-dev/pull/999/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=999&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8242115 Stats: 185 lines in 6 files changed: 174 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/999.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/999/head:pull/999 PR: https://git.openjdk.org/jdk17u-dev/pull/999 From serb at openjdk.org Thu Dec 29 13:02:58 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Dec 2022 13:02:58 GMT Subject: [jdk11u-dev] Integrated: 8298027: Remove SCCS id's from awt jtreg tests In-Reply-To: References: Message-ID: On Tue, 27 Dec 2022 10:23:09 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [ba2d28e9](https://github.com/openjdk/jdk/commit/ba2d28e911f4f523334f98fd0186680acafb6f0a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Jayathirth D V on 6 Dec 2022 and was reviewed by Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: a3f37e5b Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/a3f37e5b5ca7113e21176052187abab9b9d3795a Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod 8298027: Remove SCCS id's from awt jtreg tests Backport-of: ba2d28e911f4f523334f98fd0186680acafb6f0a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1613 From goetz at openjdk.org Thu Dec 29 13:21:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 13:21:39 GMT Subject: [jdk17u-dev] RFR: 8292780: misc tests failed "assert(false) failed: graph should be schedulable" Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 16047e8308a845436f7003e09e604a88bb370632 Changes: https://git.openjdk.org/jdk17u-dev/pull/1000/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1000&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292780 Stats: 52 lines in 2 files changed: 51 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1000.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1000/head:pull/1000 PR: https://git.openjdk.org/jdk17u-dev/pull/1000 From dchuyko at openjdk.org Thu Dec 29 14:18:56 2022 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 29 Dec 2022 14:18:56 GMT Subject: [jdk17u-dev] RFR: 8265263: AArch64: Combine vneg with right shift count [v5] In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 16:29:04 GMT, Dmitry Chuyko wrote: >> This is a performance improvement for AArch64. There are several differences from the original change. >> >> https://bugs.openjdk.org/browse/JDK-8267356 (Vector API SVE codegen support) is not in 17u, so `UseSVE == 0` parts in predicates are missing/excluded. >> >> https://bugs.openjdk.org/browse/JDK-8288445 (C2 compilation fails) is a subsequent bugfix already backported in 17u, so some `immI` arguments in rules became `immI_positive`. >> >> https://bugs.openjdk.org/browse/JDK-8277239 (SIGSEGV in vrshift_reg_maskedNode::emit) is also related to Vector API and is not in 17u, so `!n->as_ShiftV()->is_var_shift()` is replaced by `VectorNode::is_vshift_cnt(n->in(2))`. This substitution may raise doubts. >> >> Testing: jtreg test/hotspot/jtreg/compiler, tier1, tier2 on aarch64. >> >> Performance improvements in the added benchmark VectorShiftRight on Graviton 2 for default size=1024 correspond to the original review: >> >> >> rShiftByte 16% >> rShiftInt 27% >> rShiftLong 16% >> rShiftShort 20% >> urShiftByte 0% >> urShiftChar 20% >> urShiftInt 27% >> urShiftLong 16% > > Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8265263 > - Merge branch 'openjdk:master' into JDK-8265263 > - Fixed m4 mismatch > - No SVE checks in vsrcnt8B, vsrcnt16B > - Backport 49245131e98c1c72c447536e5527acecb3311add I consider backporting of JDK-8277239 first, however the test mentioned there is stable on 17u in my experiments and the change doesn't apply cleanly. And there is also arm32 follow-up (JDK-8278267) that may be considered. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/811 From duke at openjdk.org Thu Dec 29 15:41:01 2022 From: duke at openjdk.org (Yi-Fan Tsai) Date: Thu, 29 Dec 2022 15:41:01 GMT Subject: [jdk17u-dev] Integrated: 8296548: Improve MD5 intrinsic for x86_64 In-Reply-To: References: Message-ID: On Thu, 15 Dec 2022 23:26:57 GMT, Yi-Fan Tsai wrote: > This is a clean backport to improve the performance of MD5 intrinsic. > > The change has been tested with TestMD5Intrinsics and TestMD5MultiBlockIntrinsics (with the patch [f43bb9f](https://github.com/openjdk/jdk/commit/f43bb9feaa03008bad9708a4d7ed850d2532e102)). This pull request has now been integrated. Changeset: 838ca6ad Author: Yi-Fan Tsai Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/838ca6ad500ce6d67a4a6493de33850c948f50b8 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod 8296548: Improve MD5 intrinsic for x86_64 Backport-of: 6ead2b019595f9b54a70603da84f11271ee070b6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/954 From phh at openjdk.org Thu Dec 29 16:06:52 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 29 Dec 2022 16:06:52 GMT Subject: [jdk11u-dev] RFR: 8221621: FindTests.gmk cannot handle "=" in TEST.groups comments In-Reply-To: References: Message-ID: <1ZZnQ_f_oc7aHGhjVtdCqticfHUDF5rrhZddcsnhmus=.d0c46ba8-302f-4dab-9f60-83dff53fa5c9@github.com> On Tue, 20 Dec 2022 18:23:09 GMT, Joshua Cao wrote: > clean backport Tagged the JBS issue. Clean backport of trival makefile fix that fixes a build error. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1603 From phh at openjdk.org Thu Dec 29 16:08:47 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 29 Dec 2022 16:08:47 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook [v2] In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 19:22:18 GMT, Joshua Cao wrote: >> This fixes a crash in JDK 11. >> >> Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. > > Joshua Cao has updated the pull request incrementally with one additional commit since the last revision: > > Update HelloCustom copyright year We believe the [JDK-8221621](https://bugs.openjdk.org/browse/JDK-8221621) backport to be useful in it's own right since it fixes a build error. I've updated that fix request comment to reflect that. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From phh at openjdk.org Thu Dec 29 16:15:57 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 29 Dec 2022 16:15:57 GMT Subject: [jdk11u-dev] RFR: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook [v2] In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 19:22:18 GMT, Joshua Cao wrote: >> This fixes a crash in JDK 11. >> >> Merge conflicts are mostly trivial. We can keep hunks from both HEAD and the backport. There is one merge conflict in licensing. > > Joshua Cao has updated the pull request incrementally with one additional commit since the last revision: > > Update HelloCustom copyright year This backport fixes a crash we've seen in production. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1604 From goetz at openjdk.org Thu Dec 29 18:03:42 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Dec 2022 18:03:42 GMT Subject: [jdk17u-dev] RFR: 8295066: Folding of loads is broken in C2 after JDK-8242115 Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/999 Commit messages: - Add forgotten test - Backport 58a7141a0dea5d1b4bfe6d56a95d860c854b3461 Changes: https://git.openjdk.org/jdk17u-dev/pull/1001/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1001&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295066 Stats: 260 lines in 9 files changed: 178 ins; 46 del; 36 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1001.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1001/head:pull/1001 PR: https://git.openjdk.org/jdk17u-dev/pull/1001 From serb at openjdk.org Thu Dec 29 21:31:55 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Dec 2022 21:31:55 GMT Subject: [jdk17u-dev] Integrated: 8288854: getLocalGraphicsEnvironment() on for multi-screen setups throws exception NPE In-Reply-To: References: Message-ID: On Thu, 29 Dec 2022 07:43:26 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [cfc9a881](https://github.com/openjdk/jdk/commit/cfc9a881afd300bd7c1ce784287d1669308e89fc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 2 Jul 2022 and was reviewed by Alexander Zvegintsev and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: cec5a0ce Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/cec5a0ce48a898228b461809e004fec2559a4cad Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8288854: getLocalGraphicsEnvironment() on for multi-screen setups throws exception NPE Backport-of: cfc9a881afd300bd7c1ce784287d1669308e89fc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/994 From serb at openjdk.org Thu Dec 29 21:34:59 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Dec 2022 21:34:59 GMT Subject: [jdk11u-dev] Integrated: 8255710: Opensource unit/regression tests for CMM In-Reply-To: References: Message-ID: <75JKe3ZS3smn6l-I-6nMW1vnRM_3tt6kqvo2YKSV80A=.96732c5f-9575-43cb-90b8-262495cab398@github.com> On Wed, 28 Dec 2022 04:07:58 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [98ccfbf4](https://github.com/openjdk/jdk/commit/98ccfbf46915791208f80b51f68f3916a68b8aaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Jan 2021 and was reviewed by Pankaj Bansal and Phil Race. > Thanks! This pull request has now been integrated. Changeset: 4640c05b Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/4640c05b2dc9b0fb871df57dc72ca8255aecfede Stats: 457 lines in 8 files changed: 457 ins; 0 del; 0 mod 8255710: Opensource unit/regression tests for CMM Backport-of: 98ccfbf46915791208f80b51f68f3916a68b8aaf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1615 From serb at openjdk.org Fri Dec 30 08:19:53 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 30 Dec 2022 08:19:53 GMT Subject: [jdk11u-dev] Integrated: 8213130: Update ProblemList after verification of jtreg tests in Win 7 In-Reply-To: References: Message-ID: On Wed, 28 Dec 2022 03:44:18 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [04104cea](https://github.com/openjdk/jdk/commit/04104ceaea8cf2f2c52b85baa24f7da4f1e49f6b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Jayathirth D V on 26 Oct 2018 and was reviewed by Prasanta Sadhukhan. > Thanks! This pull request has now been integrated. Changeset: 7f2cea16 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/7f2cea1626ede6ed77fd7e61187ec1078d6cb904 Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod 8213130: Update ProblemList after verification of jtreg tests in Win 7 Backport-of: 04104ceaea8cf2f2c52b85baa24f7da4f1e49f6b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1614 From mbaesken at openjdk.org Fri Dec 30 08:56:55 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Dec 2022 08:56:55 GMT Subject: [jdk17u-dev] Integrated: 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 09:15:21 GMT, Matthias Baesken wrote: > 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check This pull request has now been integrated. Changeset: c0a3bf14 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/c0a3bf14ccde2facb0cc70e6de12f7dc369ea5f5 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check Backport-of: 2f8a5c2eca0dc3dad08b7b2c33394ac214907008 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/965 From mbaesken at openjdk.org Fri Dec 30 09:03:56 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Dec 2022 09:03:56 GMT Subject: [jdk17u-dev] Integrated: 8297959: Provide better descriptions for some Operating System JFR events In-Reply-To: References: Message-ID: On Thu, 22 Dec 2022 09:40:51 GMT, Matthias Baesken wrote: > 8297959: Provide better descriptions for some Operating System JFR events This pull request has now been integrated. Changeset: 633a763b Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/633a763b3793f4f83cea2c3990f35c6b081582fd Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod 8297959: Provide better descriptions for some Operating System JFR events Backport-of: dea2161f069a88553bc514c7210dc1d31febd90a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/966 From mbaesken at openjdk.org Fri Dec 30 09:28:34 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Dec 2022 09:28:34 GMT Subject: [jdk17u-dev] RFR: 8298093: improve cleanup and error handling of awt_parseColorModel in awt_parseImage.c Message-ID: <-8uZv67L1Xf6NSvK8Plkd06SBQ00NiOfJ6abw6xkYxE=.d88130bd-29fa-436f-a95e-c521d1f67a1c@github.com> 8298093: improve cleanup and error handling of awt_parseColorModel in awt_parseImage.c ------------- Commit messages: - Backport 98fa48c330941efe6588a907b383802a11ed0e6b Changes: https://git.openjdk.org/jdk17u-dev/pull/1002/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1002&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298093 Stats: 22 lines in 1 file changed: 14 ins; 1 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1002.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1002/head:pull/1002 PR: https://git.openjdk.org/jdk17u-dev/pull/1002 From goetz at openjdk.org Fri Dec 30 09:28:56 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Dec 2022 09:28:56 GMT Subject: [jdk17u-dev] RFR: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information In-Reply-To: References: Message-ID: On Thu, 29 Dec 2022 12:20:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. Pre-submit failure: CompensatedSums.java, known to be failing, Unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/997 From goetz at openjdk.org Fri Dec 30 09:29:58 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Dec 2022 09:29:58 GMT Subject: [jdk17u-dev] RFR: 8242115: C2 SATB barriers are not safepoint-safe In-Reply-To: <09GEDEaan3UjUvmvclPbpeAPPSLCqRkmYDSZk9s5zc0=.e38d01ee-48ea-4137-8d0f-d94a9f609094@github.com> References: <09GEDEaan3UjUvmvclPbpeAPPSLCqRkmYDSZk9s5zc0=.e38d01ee-48ea-4137-8d0f-d94a9f609094@github.com> Message-ID: On Thu, 29 Dec 2022 12:55:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > I had to resolve memnode.hpp and added control_dependency() > which is called by this change. Pre-submit failure: Couldn't download packages: libmnl0, infra issue, unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/999 From dchuyko at openjdk.org Fri Dec 30 10:35:28 2022 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Fri, 30 Dec 2022 10:35:28 GMT Subject: [jdk17u-dev] RFR: 8284578: Relax InterpreterCodelet stub alignment [v6] In-Reply-To: <-S-PuYwXrek_TJNEUgFE7-5zClVhBKFK9CKEvX59iYY=.49d64463-b100-4589-a0f3-c0b57bc6935f@github.com> References: <-S-PuYwXrek_TJNEUgFE7-5zClVhBKFK9CKEvX59iYY=.49d64463-b100-4589-a0f3-c0b57bc6935f@github.com> Message-ID: > This change improves density of interpreter codelets. I have no intent to backport JDK-8281467 [1] (Allow larger OptoLoopAlignment and CodeEntryAlignment), entire JDK-8283298 [2] (productize CodeCacheSegmentSize) and its related change in stubRoutines.cpp JDK-8282355 [3]. > > However I suppose that Modification of MethodHandles::generate_adapters() from JDK-8283298 which makes blob size more accurate is related to this fix, so I included it here. JDK-8283298 modifications of TemplateInterpreter::initialize_stub() are overwritten by the changes from the original JDK-8284578 patch. > > So this patch consists of > - Original JDK-8284578 altered to be applicable without JDK-8283298 and JDK-8264207 [4] (can be backported afterwards). > - MethodHandles::generate_adapters() and copyrights from JDK-8283298. > > Testing: tier1, tier2 on x86 and aarch64 (release) > > [0] https://bugs.openjdk.org/browse/JDK-8284578 > [1] https://bugs.openjdk.org/browse/JDK-8281467 > [2] https://bugs.openjdk.org/browse/JDK-8283298 > [3] https://bugs.openjdk.org/browse/JDK-8282355 > [4] https://bugs.openjdk.org/browse/JDK-8264207 Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8284578 - Merge branch 'openjdk:master' into JDK-8284578 - Merge branch 'openjdk:master' into JDK-8284578 - Backport 2241a057050ed521cfbfbe8a758353e621dee15f ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/753/files - new: https://git.openjdk.org/jdk17u-dev/pull/753/files/04b6b21a..6eba856d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=753&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=753&range=04-05 Stats: 21170 lines in 259 files changed: 17234 ins; 1940 del; 1996 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/753.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/753/head:pull/753 PR: https://git.openjdk.org/jdk17u-dev/pull/753 From mdoerr at openjdk.org Fri Dec 30 10:35:58 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 30 Dec 2022 10:35:58 GMT Subject: [jdk17u-dev] RFR: 8281122: [IR Framework] Cleanup IR matching code in preparation for JDK-8280378 In-Reply-To: References: Message-ID: On Thu, 29 Dec 2022 10:00:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > Clean except for omitting the patch to TestMaskedMacroLogicVector.java. > That test came with "8273322: Enhance macro logic optimization for masked logic operations." which is not backported. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/995 From mdoerr at openjdk.org Fri Dec 30 10:40:56 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 30 Dec 2022 10:40:56 GMT Subject: [jdk17u-dev] RFR: 8242115: C2 SATB barriers are not safepoint-safe In-Reply-To: <09GEDEaan3UjUvmvclPbpeAPPSLCqRkmYDSZk9s5zc0=.e38d01ee-48ea-4137-8d0f-d94a9f609094@github.com> References: <09GEDEaan3UjUvmvclPbpeAPPSLCqRkmYDSZk9s5zc0=.e38d01ee-48ea-4137-8d0f-d94a9f609094@github.com> Message-ID: <9VaVBLufY7TkWHG4E1gNimiOjGbd7efTRKNFh3UadRw=.9e8719c3-020e-4a84-8307-2d7a1c79c419@github.com> On Thu, 29 Dec 2022 12:55:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > I had to resolve memnode.hpp and added control_dependency() > which is called by this change. LGTM. Thanks for backporting! ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/999 From mdoerr at openjdk.org Fri Dec 30 11:22:53 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 30 Dec 2022 11:22:53 GMT Subject: [jdk17u-dev] RFR: 8292297: Fix up loading of override java.security properties file In-Reply-To: <5l8evXLcIx6Z9l4tRYnHb-3pBogYe7Jsn6NeR6TDOO0=.6d3b1488-48be-464d-bb61-f634b51a93ce@github.com> References: <5l8evXLcIx6Z9l4tRYnHb-3pBogYe7Jsn6NeR6TDOO0=.6d3b1488-48be-464d-bb61-f634b51a93ce@github.com> Message-ID: On Thu, 29 Dec 2022 10:04:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > I had to resolve as > 8280010: Remove double buffering of InputStream for Properties.load is not in 17. > The new code comes without the double buffering, but as I understand it is > also not needed in 17 and thus I left it as-is. LGTM. The double buffering is redundant anyway (see description of [JDK-8280010](https://bugs.openjdk.org/browse/JDK-8280010) which will probably not get backported because it's a P5 enhancement). ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/996 From mbaesken at openjdk.org Fri Dec 30 11:22:54 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Dec 2022 11:22:54 GMT Subject: [jdk17u-dev] RFR: 8292297: Fix up loading of override java.security properties file In-Reply-To: <5l8evXLcIx6Z9l4tRYnHb-3pBogYe7Jsn6NeR6TDOO0=.6d3b1488-48be-464d-bb61-f634b51a93ce@github.com> References: <5l8evXLcIx6Z9l4tRYnHb-3pBogYe7Jsn6NeR6TDOO0=.6d3b1488-48be-464d-bb61-f634b51a93ce@github.com> Message-ID: On Thu, 29 Dec 2022 10:04:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > I had to resolve as > 8280010: Remove double buffering of InputStream for Properties.load is not in 17. > The new code comes without the double buffering, but as I understand it is > also not needed in 17 and thus I left it as-is. Marked as reviewed by mbaesken (Reviewer). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/996 From mbaesken at openjdk.org Fri Dec 30 13:30:54 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Dec 2022 13:30:54 GMT Subject: [jdk17u-dev] RFR: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic [v2] In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 22:42:52 GMT, Martin Doerr wrote: >> Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: >> The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). >> Includes trivial fix for [JDK-8298947](https://bugs.openjdk.org/browse/JDK-8298947) > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Backport 3d4d9fd6e6de037950f94482d4e33f178eb15daa Marked as reviewed by mbaesken (Reviewer). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/951 From mdoerr at openjdk.org Fri Dec 30 13:30:54 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 30 Dec 2022 13:30:54 GMT Subject: [jdk17u-dev] RFR: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic [v2] In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 22:42:52 GMT, Martin Doerr wrote: >> Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: >> The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). >> Includes trivial fix for [JDK-8298947](https://bugs.openjdk.org/browse/JDK-8298947) > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Backport 3d4d9fd6e6de037950f94482d4e33f178eb15daa Thanks for the reviews! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/951 From mbaesken at openjdk.org Fri Dec 30 14:59:31 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Dec 2022 14:59:31 GMT Subject: [jdk17u-dev] RFR: 8235297: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java fails intermittent Message-ID: 8235297: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java fails intermittent ------------- Commit messages: - Backport d490f15e3b8222d0ba80e2161cc3f063092fc460 Changes: https://git.openjdk.org/jdk17u-dev/pull/1003/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1003&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8235297 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1003.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1003/head:pull/1003 PR: https://git.openjdk.org/jdk17u-dev/pull/1003 From goetz at openjdk.org Fri Dec 30 16:31:01 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Dec 2022 16:31:01 GMT Subject: [jdk17u-dev] RFR: 8292177: InitialSecurityProperty JFR event Message-ID: I backport this for parity with 17.0.7-oracle. I resolved the following code: src/java.base/share/classes/module-info.java Trivial resolve. src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java Resolved imports. test/lib/jdk/test/lib/jfr/EventNames.java Does not match because, for example, later change 8295419: JFR: Change name of jdk.JitRestart was already backported. This was tedious to resolve, because the larger part of the change is a cleanup exchanging "final static" by "static final". Besides that I spotted the addition of a single new line for "InitialSecurityProperty". ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/996 Commit messages: - Backport 8c40b7dc8cd7b6a6d0c9349b991e0e01b69349c3 Changes: https://git.openjdk.org/jdk17u-dev/pull/1004/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1004&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292177 Stats: 401 lines in 12 files changed: 248 ins; 0 del; 153 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1004.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1004/head:pull/1004 PR: https://git.openjdk.org/jdk17u-dev/pull/1004 From goetz at openjdk.org Fri Dec 30 16:47:33 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Dec 2022 16:47:33 GMT Subject: [jdk17u-dev] RFR: 8296136: Use correct register in aarch64_enc_fast_unlock() Message-ID: I backport this for parity with 17.0.7-oracle. Omitted riskv part. Will mark as clean. ------------- Commit messages: - Backport 7619602c365acee73a490f05be2bd0d3dd09d7a4 Changes: https://git.openjdk.org/jdk17u-dev/pull/1005/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1005&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296136 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1005.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1005/head:pull/1005 PR: https://git.openjdk.org/jdk17u-dev/pull/1005 From goetz at openjdk.org Fri Dec 30 16:58:42 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Dec 2022 16:58:42 GMT Subject: [jdk17u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update Message-ID: <0vo72xAjrSDPyz-HJHUX3u751AeVEwZRzGLipMSVKUw=.1ade9a1a-c759-4a4e-b49c-8dd4a7f1ae7e@github.com> I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport fd837649811c866c144c9133d211fb5ad8f994a7 Changes: https://git.openjdk.org/jdk17u-dev/pull/1006/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1006&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296239 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1006.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1006/head:pull/1006 PR: https://git.openjdk.org/jdk17u-dev/pull/1006 From goetz at openjdk.org Fri Dec 30 17:06:34 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Dec 2022 17:06:34 GMT Subject: [jdk17u-dev] RFR: 8294378: URLPermission constructor exception when using tr locale Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport ff2c987669523613f3e5dc19493a41f849f882f6 Changes: https://git.openjdk.org/jdk17u-dev/pull/1007/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1007&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294378 Stats: 13 lines in 3 files changed: 8 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1007.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1007/head:pull/1007 PR: https://git.openjdk.org/jdk17u-dev/pull/1007 From goetz at openjdk.org Fri Dec 30 17:53:32 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Dec 2022 17:53:32 GMT Subject: [jdk17u-dev] RFR: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes" Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 4bdd1c914859e221c64208d47ef309d463609953 Changes: https://git.openjdk.org/jdk17u-dev/pull/1008/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1008&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290964 Stats: 21 lines in 3 files changed: 0 ins; 21 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1008.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1008/head:pull/1008 PR: https://git.openjdk.org/jdk17u-dev/pull/1008 From goetz at openjdk.org Fri Dec 30 18:30:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Dec 2022 18:30:39 GMT Subject: [jdk17u-dev] RFR: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222 Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 0043d58c5d52c3b299a4b6dfcec34a7db5041aea Changes: https://git.openjdk.org/jdk17u-dev/pull/1009/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1009&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293531 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1009.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1009/head:pull/1009 PR: https://git.openjdk.org/jdk17u-dev/pull/1009 From serb at openjdk.org Sat Dec 31 05:33:43 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 31 Dec 2022 05:33:43 GMT Subject: [jdk17u-dev] RFR: 8275843: Random crashes while the UI code is executed Message-ID: Hi all, This pull request contains a backport of commit [a9c1acbb](https://github.com/openjdk/jdk/commit/a9c1acbb8aec46e4a488b7c77bb6318af87747f6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 14 Dec 2021 and was reviewed by Alexander Zvegintsev. Thanks! ------------- Commit messages: - Backport a9c1acbb8aec46e4a488b7c77bb6318af87747f6 Changes: https://git.openjdk.org/jdk17u-dev/pull/993/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=993&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275843 Stats: 141 lines in 6 files changed: 91 ins; 19 del; 31 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/993.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/993/head:pull/993 PR: https://git.openjdk.org/jdk17u-dev/pull/993 From goetz at openjdk.org Sat Dec 31 11:13:40 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 11:13:40 GMT Subject: [jdk11u-dev] RFR: 8212165: JGSS: Fix cut/paste error in NativeUtil.c Message-ID: I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport 2a105069423ca7bcd82e8e8453be1f7686616008 Changes: https://git.openjdk.org/jdk11u-dev/pull/1617/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1617&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8212165 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1617.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1617/head:pull/1617 PR: https://git.openjdk.org/jdk11u-dev/pull/1617 From goetz at openjdk.org Sat Dec 31 11:14:36 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 11:14:36 GMT Subject: [jdk11u-dev] RFR: 8212216: JGSS: Fix leak in exception cases in getJavaOID() Message-ID: I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport 10027304cdf135738eb558ae533c4751cac7b71e Changes: https://git.openjdk.org/jdk11u-dev/pull/1618/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1618&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8212216 Stats: 9 lines in 1 file changed: 0 ins; 3 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1618.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1618/head:pull/1618 PR: https://git.openjdk.org/jdk11u-dev/pull/1618 From goetz at openjdk.org Sat Dec 31 11:21:20 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 11:21:20 GMT Subject: [jdk11u-dev] RFR: 8230731: SA tests fail with "Windbg Error: ReadVirtual failed" Message-ID: I backport this for parity with 11.0.19-oracle. Patches to ProblemLists don't apply, but are pointless: test/hotspot/jtreg/ProblemList.txt: Test is only ProblemListed for solaris. I leave that unchanged as I can not double-checke the test is passing there. test/jdk/ProblemList.txt: Test is not problemlisted there. Will mark as clean. ------------- Commit messages: - Backport c6c1f9bad9c1742bc3fe44607df864ed05fe2195 Changes: https://git.openjdk.org/jdk11u-dev/pull/1619/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1619&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8230731 Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1619.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1619/head:pull/1619 PR: https://git.openjdk.org/jdk11u-dev/pull/1619 From mdoerr at openjdk.org Sat Dec 31 11:54:01 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Sat, 31 Dec 2022 11:54:01 GMT Subject: [jdk17u-dev] Integrated: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic In-Reply-To: References: Message-ID: On Tue, 13 Dec 2022 11:58:23 GMT, Martin Doerr wrote: > Mostly clean backport of [JDK-8295724](https://bugs.openjdk.org/browse/JDK-8295724). Manual integration was needed because of unrelated changes in the surrounding code. There's only one significant difference: > The hunk from gcBehaviours.cpp needs to get integrated into `nmethod::is_unloading()` because the usage of `IsUnloadingBehaviour::current()` is there before [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). > Includes trivial fix for [JDK-8298947](https://bugs.openjdk.org/browse/JDK-8298947) This pull request has now been integrated. Changeset: 82790b03 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/82790b03da58d812e6067e12d66424fa32252dc4 Stats: 147 lines in 4 files changed: 144 ins; 0 del; 3 mod 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic 8298947: compiler/codecache/MHIntrinsicAllocFailureTest.java fails intermittently Reviewed-by: kvn, mbaesken Backport-of: cd2182a9967917e733e486d918e9aeba3bd35ee8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/951 From goetz at openjdk.org Sat Dec 31 16:09:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 16:09:39 GMT Subject: [jdk11u-dev] RFR: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit Message-ID: I backport this for parity with 11.0.19-oracle. I resolved one hunk in loopopts.cpp because 11 uses old-style formatting. ------------- Commit messages: - Backport 9ad19f7838e6f6e128583c191c5507c1e2bd5083 Changes: https://git.openjdk.org/jdk11u-dev/pull/1620/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1620&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256934 Stats: 15 lines in 1 file changed: 12 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1620.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1620/head:pull/1620 PR: https://git.openjdk.org/jdk11u-dev/pull/1620 From goetz at openjdk.org Sat Dec 31 16:39:35 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 16:39:35 GMT Subject: [jdk11u-dev] RFR: 8271506: Add ResourceHashtable support for deleting selected entries Message-ID: I backport this for parity with 11.0.19-oracle. I backported this from 17 because that already contains a needed adaption. The test file did not resolve properly, context differs slightly. ------------- Commit messages: - Backport 0b51fe2bce55991e608352954a2266f4702642bf Changes: https://git.openjdk.org/jdk11u-dev/pull/1621/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1621&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8271506 Stats: 51 lines in 2 files changed: 51 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1621.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1621/head:pull/1621 PR: https://git.openjdk.org/jdk11u-dev/pull/1621 From goetz at openjdk.org Sat Dec 31 16:41:49 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 16:41:49 GMT Subject: [jdk11u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3] In-Reply-To: References: Message-ID: On Wed, 21 Dec 2022 11:19:34 GMT, Roman Marchenko wrote: >> Clean backport >> >> Please note that this PR is a part of dependant PR chain >> >> Prev PRs: >> - #1574 >> - #1575 > > Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 268fa693188b685de6289927ee5a1e99473a50f6 @wkia, @yan-too, we see the test failing in our CI. It does not compile. There are jdk17 strings used!!! Did you ever run the test before pushing? Please prepare a fix! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1576 From goetz at openjdk.org Sat Dec 31 16:46:23 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 16:46:23 GMT Subject: [jdk11u-dev] RFR: 8280391: NMT: Correct NMT tag on CollectedHeap Message-ID: I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport 44db4794d29c6e0755a6dc0ea1346f48f918155b Changes: https://git.openjdk.org/jdk11u-dev/pull/1622/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1622&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280391 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1622.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1622/head:pull/1622 PR: https://git.openjdk.org/jdk11u-dev/pull/1622 From goetz at openjdk.org Sat Dec 31 17:03:26 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 17:03:26 GMT Subject: [jdk11u-dev] RFR: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo Message-ID: I backport this for parity with 11.0.19-oracle. I had to place the code by hand, patching hit the wrong method. ------------- Commit messages: - Backport ec205f68a883cef6b98f26a06baf675f7da26928 Changes: https://git.openjdk.org/jdk11u-dev/pull/1623/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1623&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284023 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1623.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1623/head:pull/1623 PR: https://git.openjdk.org/jdk11u-dev/pull/1623 From goetz at openjdk.org Sat Dec 31 17:18:27 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 17:18:27 GMT Subject: [jdk11u-dev] RFR: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432 Message-ID: <7FsVNqi71Onv-cC4Y78Ul5Jm9HLWyuDdiFGO6e0K8PA=.8e6c25cd-5f49-407e-b58a-80cdbddecfe8@github.com> I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport c156bcc599534ae989bc9cbd001e7c150da8096c Changes: https://git.openjdk.org/jdk11u-dev/pull/1624/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1624&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285399 Stats: 5 lines in 2 files changed: 4 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1624.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1624/head:pull/1624 PR: https://git.openjdk.org/jdk11u-dev/pull/1624 From goetz at openjdk.org Sat Dec 31 17:31:15 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 17:31:15 GMT Subject: [jdk11u-dev] RFR: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.19-oracle. > > I resolved one hunk in loopopts.cpp because 11 uses old-style formatting. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 9ad19f7838e6f6e128583c191c5507c1e2bd5083 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1620/files - new: https://git.openjdk.org/jdk11u-dev/pull/1620/files/b9dab1b7..529f152e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1620&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1620&range=00-01 Stats: 73 lines in 1 file changed: 73 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1620.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1620/head:pull/1620 PR: https://git.openjdk.org/jdk11u-dev/pull/1620 From goetz at openjdk.org Sat Dec 31 17:34:45 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 17:34:45 GMT Subject: [jdk11u-dev] RFR: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off Message-ID: I backport this for parity with 11.0.19-oracle. I resolved the ProblemList, will mark as clean. ------------- Commit messages: - Backport 649f2d8835027128c6c8cf37236808094a12a35f Changes: https://git.openjdk.org/jdk11u-dev/pull/1625/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1625&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8065097 Stats: 131 lines in 2 files changed: 37 ins; 4 del; 90 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1625.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1625/head:pull/1625 PR: https://git.openjdk.org/jdk11u-dev/pull/1625 From goetz at openjdk.org Sat Dec 31 18:05:34 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 18:05:34 GMT Subject: [jdk17u-dev] RFR: 8212961: [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport fde183130bc6379fe0d4624bbeaf252d0e9a15c8 Changes: https://git.openjdk.org/jdk17u-dev/pull/1010/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1010&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8212961 Stats: 777 lines in 8 files changed: 111 ins; 121 del; 545 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1010.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1010/head:pull/1010 PR: https://git.openjdk.org/jdk17u-dev/pull/1010 From goetz at openjdk.org Sat Dec 31 18:08:43 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 18:08:43 GMT Subject: [jdk17u-dev] RFR: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 653a612a5aac266509f414c570871b7141b9347d Changes: https://git.openjdk.org/jdk17u-dev/pull/1011/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1011&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8270156 Stats: 10 lines in 8 files changed: 8 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1011.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1011/head:pull/1011 PR: https://git.openjdk.org/jdk17u-dev/pull/1011 From goetz at openjdk.org Sat Dec 31 18:12:37 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 18:12:37 GMT Subject: [jdk17u-dev] RFR: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6 Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 19ce33d5e770dc3fd7a9588e7954bbb499b7a05c Changes: https://git.openjdk.org/jdk17u-dev/pull/1012/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1012&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8258512 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1012.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1012/head:pull/1012 PR: https://git.openjdk.org/jdk17u-dev/pull/1012 From goetz at openjdk.org Sat Dec 31 18:21:37 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 31 Dec 2022 18:21:37 GMT Subject: [jdk17u-dev] RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 76fe03fe01a7c824e2e9263de95b8bcbb4b9d752 Changes: https://git.openjdk.org/jdk17u-dev/pull/1013/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1013&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280166 Stats: 89 lines in 1 file changed: 62 ins; 0 del; 27 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1013.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1013/head:pull/1013 PR: https://git.openjdk.org/jdk17u-dev/pull/1013