[jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters

[Michal Karm Babacek]

On Fri, 2 Dec 2022 08:52:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> @phohensee Thank you for the review.
>> 
>> Ad formatting: Ack. Will do.
>> 
>> Ad
>> 
>>> The change to use getResponse().uri() instead of getResponse().body() fixes a bug in tip, so can't be part of a backport.
>> 
>> Oh...I see. So the fact that the body is returned even though there was a failure is a bug, not a feature/desirable chage? I will browse the Jira and check the spec to make sure I am not bending the test to a faulty implementation then.
>> 
>> 
>> Cheers
>> Karm
>
>> Oh...I see. So the fact that the body is returned even though there was a failure is a bug, not a feature/desirable chage? I will browse the Jira and check the spec to make sure I am not bending the test to a faulty implementation then.
> 
> Even if you discover a discrepancy, this would need to get fixed in [JDK head](https://github.com/openjdk/jdk) first and then backported. Please keep that in mind.

@jerboaa I realized the patch is already backported to JDK 19 and JDK 17. So it's just JDK 11 I'd like to backport JDK-8245245 to.   And IIUC, the change in https://github.com/openjdk/jdk/pull/11486 needed for JDK 11 will need backporting to JDK 19, JDK 17 too.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1558