[jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive

[Leslie Zhai]

On Thu, 8 Dec 2022 13:12:41 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Hi,
>> 
>> Backporting JDK-8267189 as a prerequisite for JDK-8275731 (CDS archived enums objects are recreated at runtime)
>> 
>> The patch applies clean except manually edit the source file:
>> 
>> * src/hotspot/share/classfile/systemDictionaryShared.hpp
>> Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context.
>> 
>> Tested jtreg tier1~3, no regression.
>> 
>> Thanks,
>> Leslie Zhai
>
> @xiangzha Hi Leslie,
> 
> please have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
> 
> You really should not integrate before you have a fix-yes label!
> 
> Also, please edit the comment in the JBS issue to contain the required information:
>  * Why do you backport the change?
>  * What is the risk of doing so?  E.g., will existing archives still work?
>  * How you tested this
>  * Only the fact whether it is clean or required edits is of interest in the JBS issue.  How you adapted the change goes into the PR as it is addressed at the reivewers.
> 
> Fix this for all your backports please. 
> Best, Goetz.

Hi @GoeLin 

Thanks for your teaching!

> You really should not integrate before you have a fix-yes label!

I see.

> Also, please edit the comment in the JBS issue to contain the required information:

Updated my comment in the JDK-8267189, please review it.

Thanks,
Leslie Zhai

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/939