[jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters

[Michal Karm Babacek]

On Mon, 12 Dec 2022 15:19:58 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Hello @dfuch, @jerboaa, @phohensee, @jaikiran 
>> 
>> I'd like this tets change to go forward: https://github.com/openjdk/jdk/pull/11486
>> It correctly fails without JDK-8245245 and passes with it. It is not necessary to be checking the body.
>> 
>> When that test change is integrated, I'd initiate its backport.  Close this pr (https://github.com/openjdk/jdk11u-dev/pull/1558) and open a new one, that would just cleanly add JDK-8245245...
>> 
>> 
>> I hope that is all right process wise.
>
>> It correctly fails without JDK-8245245 and passes with it. It is not necessary to be checking the body.
> 
> Thanks for double checking. In that case I believed you're covered, I personally have no objection in that case. I mostly commented because I don't think there's a bug in the original test. It just uses a different method to check for success. As for approval I'll defer to the JDK 11 maintainers.

Hello @dfuch, @phohensee,

With jdk/pull/11486 merged, I would kindly ask for a review of this backport to JDK11u.
- the patch in OpeningHandshake.java did not require any changes
- the diff for the test between what is in mainline and what I propose here is this: https://editor.mergely.com/Hh1c3Z1N/

thx
K.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1558