[jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v4]

[Michal Karm Babacek]

On Mon, 19 Dec 2022 10:33:54 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adds comment about [JDK-8240666]
>
> test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java line 127:
> 
>> 125:                 final String expectedRawQuery = "&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz";
>> 126:                 assertEquals(rawQuery, expectedRawQuery);
>> 127:                 // [JDK-8240666] Websocket client's OpeningHandshake discards the HTTP response body
> 
> A better comment would be: `JDK-8240666 is not currently in 11u unlike later JDKs and we, therefore, need to check whether or not a body is present. This is OK as previous assertions verify a fix of JDK-8245245`. Something like that.

Ack.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1558