[jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters [v5]

[Michal Karm Babacek]

On Fri, 23 Dec 2022 13:31:40 GMT, Michal Karm Babacek <duke at openjdk.org> wrote:

>> OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)...
>
>> OK, let me try to trigger the backports for you, see [here](https://github.com/openjdk/jdk/commit/909d0cb4d9475fd367b8bc64a6b50c5a324e9a01#commitcomment-93691813)...
> 
> THX @RealCLanger 
> JDK 17 https://github.com/openjdk/jdk17u-dev/pull/982
> JDK 20 https://github.com/openjdk/jdk20/pull/76

> Hi @Karm, I saw your JBS comment. Next time please reason why you consider the risk low. Thanks.

@GoeLin Ack. Will do.

My own thinking is along the lines that it is a well isolated change in a very comprehensible part of code, it aligns with the spec and it does not bring any surprising behavior when compared to some popular WebSocket client libs used with JDK 11, as noted in https://github.com/openjdk/jdk11u-dev/pull/1558#issuecomment-1361109845. If there is code out there workarounding it, it's likely based on a string substitution and will turn to no-op now.

I will try to be more eloquent about risks of particular backports in the it in future.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1558