From yan at openjdk.java.net Tue Feb 1 07:14:47 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 1 Feb 2022 07:14:47 GMT Subject: [jdk13u-dev] RFR: 8275082: Update XML Security for Java to 2.3.0 Message-ID: The cumulative fix prepared for 15u applies here perfectly (thus, a fix "Catching a few NumberFormatExceptions" backported in full). ------------- Commit messages: - Backport 2c31a1735d5b8646ed8984a5475d5c8c9c91c19d Changes: https://git.openjdk.java.net/jdk13u-dev/pull/322/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=322&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275082 Stats: 413 lines in 33 files changed: 63 ins; 267 del; 83 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/322.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/322/head:pull/322 PR: https://git.openjdk.java.net/jdk13u-dev/pull/322 From goetz at openjdk.java.net Tue Feb 1 07:47:27 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 07:47:27 GMT Subject: [jdk17u-dev] Integrated: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error In-Reply-To: References: Message-ID: On Fri, 28 Jan 2022 15:55:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: cb769c03 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/cb769c03c1155361c8e897a5076620f1b823509a Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error Backport-of: 8785737ba5f398888816ddd0f50adeea6a75bb0f ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/127 From goetz at openjdk.java.net Tue Feb 1 07:49:13 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 07:49:13 GMT Subject: [jdk11u-dev] Integrated: 8177814: jdk/editpad is not in jdk TEST.groups In-Reply-To: References: Message-ID: On Sun, 30 Jan 2022 13:10:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > I had to resolve because of different context. This pull request has now been integrated. Changeset: ef288cd3 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/ef288cd3cc2bd6e201cc1127b41c40f7c00a9aed Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8177814: jdk/editpad is not in jdk TEST.groups Reviewed-by: mbaesken Backport-of: cfe7471f1769eca2a4e623f5ba9cddceb005f0bf ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/801 From goetz at openjdk.java.net Tue Feb 1 07:49:22 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 07:49:22 GMT Subject: [jdk17u-dev] Integrated: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm In-Reply-To: References: Message-ID: On Fri, 28 Jan 2022 16:05:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: c5815984 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/c5815984ae0f430eefdf1836d3fb2fbd44f99067 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm Backport-of: c80a612709f1e483575e2843c1f0ea84e1b9a257 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/128 From mbaesken at openjdk.java.net Tue Feb 1 07:50:24 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 1 Feb 2022 07:50:24 GMT Subject: [jdk17u-dev] Integrated: 8280414: Memory leak in DefaultProxySelector In-Reply-To: <6HiwY3dheIqvLUImUGBYvORPrTUFJD49cg9p9OYWfUo=.b8d5d3ec-ae09-4a2e-99af-e4b3e291f40d@github.com> References: <6HiwY3dheIqvLUImUGBYvORPrTUFJD49cg9p9OYWfUo=.b8d5d3ec-ae09-4a2e-99af-e4b3e291f40d@github.com> Message-ID: On Mon, 31 Jan 2022 13:00:58 GMT, Matthias Baesken wrote: > 8280414: Memory leak in DefaultProxySelector This pull request has now been integrated. Changeset: 869bb36c Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/869bb36c58c1cb25e298c73246995a74cc07d4b4 Stats: 11 lines in 1 file changed: 1 ins; 3 del; 7 mod 8280414: Memory leak in DefaultProxySelector Backport-of: fe77250fa450ec803d2818dc90c5bf156521d537 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/135 From goetz at openjdk.java.net Tue Feb 1 07:51:27 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 07:51:27 GMT Subject: [jdk17u-dev] Integrated: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64 In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 07:27:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: 952f9c71 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/952f9c7159dbef4ca6d919e2f3b81eb011547cfc Stats: 63 lines in 6 files changed: 41 ins; 1 del; 21 mod 8275645: [JVMCI] avoid unaligned volatile reads on AArch64 Backport-of: 4dec8fc4cc2b1762fba554d0401da8be0d6d1166 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/130 From mbaesken at openjdk.java.net Tue Feb 1 08:12:54 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 1 Feb 2022 08:12:54 GMT Subject: [jdk18u] RFR: 8280414: Memory leak in DefaultProxySelector Message-ID: 8280414: Memory leak in DefaultProxySelector ------------- Commit messages: - Backport fe77250fa450ec803d2818dc90c5bf156521d537 Changes: https://git.openjdk.java.net/jdk18u/pull/12/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=12&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280414 Stats: 11 lines in 1 file changed: 1 ins; 3 del; 7 mod Patch: https://git.openjdk.java.net/jdk18u/pull/12.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/12/head:pull/12 PR: https://git.openjdk.java.net/jdk18u/pull/12 From goetz at openjdk.java.net Tue Feb 1 08:25:57 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 08:25:57 GMT Subject: [jdk17u-dev] RFR: 8271506: Add ResourceHashtable support for deleting selected entries [v3] In-Reply-To: References: Message-ID: > I backport this as prerequisite to JDK-8274944 which calls the new method unlink(). > > I had to adapt the code to work in jdk17 because ""JDK-8269004: Implement ResizableResourceHashtable" is missing in 17. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport f15d6cbcaf191b9718ab51b1e8b72938c0abdd6b ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/132/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/132/files/d68ad89f..dcbda7e6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=132&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=132&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/132.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/132/head:pull/132 PR: https://git.openjdk.java.net/jdk17u-dev/pull/132 From sgehwolf at openjdk.java.net Tue Feb 1 09:48:07 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 1 Feb 2022 09:48:07 GMT Subject: [jdk11u-dev] RFR: 8280999 array_bounds should be array-bounds after 8278507 In-Reply-To: <9cZwayty1_NBYTO58hhsRd-DyN0aj1dHy3XXG0uF_Rg=.73f9cf0b-afff-4ae5-ab48-f86b09b31135@github.com> References: <9cZwayty1_NBYTO58hhsRd-DyN0aj1dHy3XXG0uF_Rg=.73f9cf0b-afff-4ae5-ab48-f86b09b31135@github.com> Message-ID: On Mon, 31 Jan 2022 22:31:48 GMT, Dan Lutker wrote: > Reverting the backport which mistakenly changed array-bounds to array_bounds and re-apply the change. > > Creating new PR after updating bug id. Old PR was https://github.com/openjdk/jdk11u-dev/pull/800 Marked as reviewed by sgehwolf (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/803 From bae at openjdk.java.net Tue Feb 1 10:02:18 2022 From: bae at openjdk.java.net (Andrew Brygin) Date: Tue, 1 Feb 2022 10:02:18 GMT Subject: [jdk13u-dev] RFR: 8275082: Update XML Security for Java to 2.3.0 In-Reply-To: References: Message-ID: <-jUk4KnW4HPe5GROhkwwFR3XnthZLFTvTPpeACfGmGk=.3f7fa9e8-e3c0-4095-97b5-f72f1bca89e4@github.com> On Tue, 1 Feb 2022 07:04:54 GMT, Yuri Nesterenko wrote: > The cumulative fix prepared for 15u applies here perfectly (thus, a fix "Catching a few NumberFormatExceptions" backported in full). The proposed change looks OK to me. ------------- Marked as reviewed by bae (Reviewer). PR: https://git.openjdk.java.net/jdk13u-dev/pull/322 From yan at openjdk.java.net Tue Feb 1 10:12:18 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 1 Feb 2022 10:12:18 GMT Subject: [jdk13u-dev] Integrated: 8275082: Update XML Security for Java to 2.3.0 In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 07:04:54 GMT, Yuri Nesterenko wrote: > The cumulative fix prepared for 15u applies here perfectly (thus, a fix "Catching a few NumberFormatExceptions" backported in full). This pull request has now been integrated. Changeset: 1082544d Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/1082544d23ee4cd1d81cdd707f136adc951eca00 Stats: 413 lines in 33 files changed: 63 ins; 267 del; 83 mod 8275082: Update XML Security for Java to 2.3.0 Reviewed-by: bae Backport-of: 2c31a1735d5b8646ed8984a5475d5c8c9c91c19d ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/322 From thartmann at openjdk.java.net Tue Feb 1 10:34:48 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 1 Feb 2022 10:34:48 GMT Subject: [jdk18u] RFR: 8258814: Compilation logging crashes for thread suspension / debugging tests Message-ID: Backport of [JDK-8258814](https://bugs.openjdk.java.net/browse/JDK-8258814). Applies cleanly. Fix request is pending. ------------- Commit messages: - 8258814: Compilation logging crashes for thread suspension / debugging tests Changes: https://git.openjdk.java.net/jdk18u/pull/13/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=13&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258814 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/13.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/13/head:pull/13 PR: https://git.openjdk.java.net/jdk18u/pull/13 From goetz at openjdk.java.net Tue Feb 1 09:25:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 09:25:37 GMT Subject: [jdk17u-dev] RFR: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue Message-ID: I backport this for parity with 17.0.3-oracle. ------------- Commit messages: - Backport 2448b3f5f96ec4d9ea8fe9dae32a0aab725fb4ad Changes: https://git.openjdk.java.net/jdk17u-dev/pull/138/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=138&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275874 Stats: 52 lines in 5 files changed: 21 ins; 19 del; 12 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/138.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/138/head:pull/138 PR: https://git.openjdk.java.net/jdk17u-dev/pull/138 From thartmann at openjdk.java.net Tue Feb 1 10:37:32 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 1 Feb 2022 10:37:32 GMT Subject: [jdk18u] RFR: 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency Message-ID: Backport of [JDK-8273139](https://bugs.openjdk.java.net/browse/JDK-8273139). Applies cleanly. Fix request is pending. ------------- Commit messages: - 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency Changes: https://git.openjdk.java.net/jdk18u/pull/14/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=14&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273139 Stats: 19 lines in 1 file changed: 2 ins; 5 del; 12 mod Patch: https://git.openjdk.java.net/jdk18u/pull/14.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/14/head:pull/14 PR: https://git.openjdk.java.net/jdk18u/pull/14 From thartmann at openjdk.java.net Tue Feb 1 10:41:54 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 1 Feb 2022 10:41:54 GMT Subject: [jdk18u] RFR: 8279225: [arm32] C1 longs comparison operation destroys argument registers Message-ID: Backport of [JDK-8279225](https://bugs.openjdk.java.net/browse/JDK-8279225). Applies cleanly. Fix request is pending. ------------- Commit messages: - 8279225: [arm32] C1 longs comparison operation destroys argument registers Changes: https://git.openjdk.java.net/jdk18u/pull/15/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=15&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279225 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/15.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/15/head:pull/15 PR: https://git.openjdk.java.net/jdk18u/pull/15 From thartmann at openjdk.java.net Tue Feb 1 10:42:57 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 1 Feb 2022 10:42:57 GMT Subject: [jdk18u] RFR: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it Message-ID: Backport of [JDK-8279412](https://bugs.openjdk.java.net/browse/JDK-8279412). Applies cleanly. Fix request is pending. ------------- Commit messages: - 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it Changes: https://git.openjdk.java.net/jdk18u/pull/16/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=16&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279412 Stats: 41 lines in 2 files changed: 29 ins; 10 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/16.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/16/head:pull/16 PR: https://git.openjdk.java.net/jdk18u/pull/16 From thartmann at openjdk.java.net Tue Feb 1 10:43:52 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 1 Feb 2022 10:43:52 GMT Subject: [jdk18u] RFR: 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN Message-ID: Backport of [JDK-8280123](https://bugs.openjdk.java.net/browse/JDK-8280123). Applies cleanly. Fix request is pending. ------------- Commit messages: - 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN Changes: https://git.openjdk.java.net/jdk18u/pull/18/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=18&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280123 Stats: 93 lines in 2 files changed: 72 ins; 4 del; 17 mod Patch: https://git.openjdk.java.net/jdk18u/pull/18.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/18/head:pull/18 PR: https://git.openjdk.java.net/jdk18u/pull/18 From goetz at openjdk.java.net Tue Feb 1 10:43:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 10:43:55 GMT Subject: [jdk17u-dev] RFR: 8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg Message-ID: I backport this for parity with 17.0.3-oracle. Requires follow-up test fix. ------------- Commit messages: - Backport 47564caeb0628e5c03a0e7f04093adce77d6dd3b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/139/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=139&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275643 Stats: 51 lines in 2 files changed: 51 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/139.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/139/head:pull/139 PR: https://git.openjdk.java.net/jdk17u-dev/pull/139 From thartmann at openjdk.java.net Tue Feb 1 10:44:01 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 1 Feb 2022 10:44:01 GMT Subject: [jdk18u] RFR: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM Message-ID: Backport of [JDK-8279437](https://bugs.openjdk.java.net/browse/JDK-8279437). Applies cleanly. Fix request is pending. ------------- Commit messages: - 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM Changes: https://git.openjdk.java.net/jdk18u/pull/17/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=17&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279437 Stats: 492 lines in 10 files changed: 359 ins; 32 del; 101 mod Patch: https://git.openjdk.java.net/jdk18u/pull/17.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/17/head:pull/17 PR: https://git.openjdk.java.net/jdk18u/pull/17 From stuefe at openjdk.java.net Tue Feb 1 10:45:28 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 1 Feb 2022 10:45:28 GMT Subject: [jdk17u-dev] RFR: 8271506: Add ResourceHashtable support for deleting selected entries [v3] In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 08:25:57 GMT, Goetz Lindenmaier wrote: >> I backport this as prerequisite to JDK-8274944 which calls the new method unlink(). >> >> I had to adapt the code to work in jdk17 because ""JDK-8269004: Implement ResizableResourceHashtable" is missing in 17. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport f15d6cbcaf191b9718ab51b1e8b72938c0abdd6b Looks good now. Small note, please do not modify history with patches in review. If you do incremental commits instead of amending as recommended, I can see what changed since last time I looked at the code. Also messes up conversation history. Cheers, Thomas ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/132 From goetz at openjdk.java.net Tue Feb 1 10:53:25 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 10:53:25 GMT Subject: [jdk17u-dev] RFR: 8271506: Add ResourceHashtable support for deleting selected entries [v3] In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 08:25:57 GMT, Goetz Lindenmaier wrote: >> I backport this as prerequisite to JDK-8274944 which calls the new method unlink(). >> >> I had to adapt the code to work in jdk17 because ""JDK-8269004: Implement ResizableResourceHashtable" is missing in 17. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport f15d6cbcaf191b9718ab51b1e8b72938c0abdd6b Pre-submit failure is tracked in https://bugs.openjdk.java.net/browse/JDK-8274517, unrelated. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/132 From goetz at openjdk.java.net Tue Feb 1 11:00:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 11:00:51 GMT Subject: [jdk17u-dev] RFR: 8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs Message-ID: <8ylvkkkUO8lNyqatNwUqz4Y2H2SEIUIpxY3xQxg6YY8=.941bd0b2-b2ff-4b78-8292-e457a50b1902@github.com> I backport this for parity with 17.0.3-oracle. Follow up to JDK-8275643 ------------- Depends on: https://git.openjdk.java.net/jdk17u-dev/pull/139 Commit messages: - Backport b15e6f076afe5ac68e9af68756860d0b25adea4b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/140/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=140&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277449 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/140.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/140/head:pull/140 PR: https://git.openjdk.java.net/jdk17u-dev/pull/140 From goetz.lindenmaier at sap.com Tue Feb 1 11:17:28 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 1 Feb 2022 11:17:28 +0000 Subject: [11u] Should we make patch 11.0.14.1 with JDK-8218546 and JDK-8280786? Message-ID: Hi, we (SAP) checked with our internal stakeholders and decided to release a patch for SapMachine 11.0.14 with JDK-8218546. We would prefer to have an "official" patch 11.0.14.1 in OpenJDK jdk11u including this change. Alternatively, we could also release a patch 11.0.14.0.1 only for SapMachine. I think JDK-8218546 is a clear regression in 11.0.14 and thus jdk11u should tag a release that fixes this. Nobody is forced to release a build with this, but anyone who runs into this problem has a clear path to solve it. I would propose to include the Solaris build fix JDK-8280786 in this patch, too. After all, tagging such a release in jdk11u is not much effort. Both issues are fixed in 11.0.15/jdk11u-dev and can easily be cherry-picked to jdk11u. I would hold back consolidating 11.0.15/jdk11u-dev to jdk11u until this is done. Tag 11.0.15+1 is scheduled for tonight. Best regards, Goetz https://bugs.openjdk.java.net/browse/8218546: Unable to connect to https://google.com using java.net.HttpClient https://bugs.openjdk.java.net/browse/8280786: Build failure on Solaris after 8262392 From goetz at openjdk.java.net Tue Feb 1 12:39:38 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Feb 2022 12:39:38 GMT Subject: [jdk17u-dev] RFR: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.3-oracle. > > I had to adapt the tests: I removed one check from dynamicArchive/LambdaContainsOldInf.java. > > This depends on JDK-8271506. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport e5cd2692da6327c6fde954f86595a08fe5edf43f ------------- Changes: https://git.openjdk.java.net/jdk17u-dev/pull/133/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=133&range=02 Stats: 248 lines in 9 files changed: 248 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/133.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/133/head:pull/133 PR: https://git.openjdk.java.net/jdk17u-dev/pull/133 From stuefe at openjdk.java.net Tue Feb 1 13:36:24 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 1 Feb 2022 13:36:24 GMT Subject: [jdk17u-dev] RFR: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info [v3] In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 12:39:38 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.3-oracle. >> >> I had to adapt the tests: I removed one check from dynamicArchive/LambdaContainsOldInf.java. >> >> This depends on JDK-8271506. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport e5cd2692da6327c6fde954f86595a08fe5edf43f LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/133 From duke at openjdk.java.net Tue Feb 1 13:47:13 2022 From: duke at openjdk.java.net (Dan Lutker) Date: Tue, 1 Feb 2022 13:47:13 GMT Subject: [jdk11u-dev] Integrated: 8280999 array_bounds should be array-bounds after 8278507 In-Reply-To: <9cZwayty1_NBYTO58hhsRd-DyN0aj1dHy3XXG0uF_Rg=.73f9cf0b-afff-4ae5-ab48-f86b09b31135@github.com> References: <9cZwayty1_NBYTO58hhsRd-DyN0aj1dHy3XXG0uF_Rg=.73f9cf0b-afff-4ae5-ab48-f86b09b31135@github.com> Message-ID: On Mon, 31 Jan 2022 22:31:48 GMT, Dan Lutker wrote: > Reverting the backport which mistakenly changed array-bounds to array_bounds and re-apply the change. > > Creating new PR after updating bug id. Old PR was https://github.com/openjdk/jdk11u-dev/pull/800 This pull request has now been integrated. Changeset: 85c81d95 Author: Dan Lutker Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/85c81d9515ba2b98eda9442b3b07c29a230f2a56 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8280999: array_bounds should be array-bounds after 8278507 Reviewed-by: phh, sgehwolf ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/803 From asemenov at openjdk.java.net Tue Feb 1 14:02:23 2022 From: asemenov at openjdk.java.net (Artem Semenov) Date: Tue, 1 Feb 2022 14:02:23 GMT Subject: [jdk17u-dev] Integrated: 8278604: SwingSet2 table demo does not have accessible description set for images In-Reply-To: <9lFy7TxHUwsY763tliUOCvnJrR42TI2vJjg7wRXWD84=.b7da4fb0-5a42-4640-a8f7-287065099cee@github.com> References: <9lFy7TxHUwsY763tliUOCvnJrR42TI2vJjg7wRXWD84=.b7da4fb0-5a42-4640-a8f7-287065099cee@github.com> Message-ID: On Thu, 27 Jan 2022 09:13:00 GMT, Artem Semenov wrote: > Hi all, > > This pull request contains a backport of commit 8fbe1724 from the openjdk/jdk repository. > > The commit being backported was authored by Artem Semenov on 17 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. > > Thanks! This pull request has now been integrated. Changeset: 592adc85 Author: Artem Semenov Committer: Anton Tarasov URL: https://git.openjdk.java.net/jdk17u-dev/commit/592adc85d109a4d93f01c60e791ab5af6c31756e Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod 8278604: SwingSet2 table demo does not have accessible description set for images 8278526: [macos] Screen reader reads SwingSet2 JTable row selection as null, dimmed row for last column Reviewed-by: ant, kizune Backport-of: 8fbe1724e0f783132a65c45503addad9d98a329e ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/125 From asemenov at openjdk.java.net Tue Feb 1 14:03:19 2022 From: asemenov at openjdk.java.net (Artem Semenov) Date: Tue, 1 Feb 2022 14:03:19 GMT Subject: [jdk17u-dev] Integrated: 8277497: Last column cell in the JTable row is read as empty cell In-Reply-To: References: Message-ID: On Thu, 23 Dec 2021 09:24:28 GMT, Artem Semenov wrote: > Hi all, > > This pull request contains a backport of commit 70bad89b from the openjdk/jdk repository. > > The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. > > Thanks! This pull request has now been integrated. Changeset: 45002c0e Author: Artem Semenov Committer: Anton Tarasov URL: https://git.openjdk.java.net/jdk17u-dev/commit/45002c0e675212989dbdfa97ae32066e0e806054 Stats: 22 lines in 1 file changed: 22 ins; 0 del; 0 mod 8277497: Last column cell in the JTable row is read as empty cell Reviewed-by: ant, kizune Backport-of: 70bad89b012eb200ca1e76f384a6e5fb307cf26d ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/34 From goetz.lindenmaier at sap.com Tue Feb 1 14:07:34 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 1 Feb 2022 14:07:34 +0000 Subject: [11u] RFC: Stack dump improvements In-Reply-To: References: Message-ID: Hi, I think this are useful improvements to the thread dumps which are also on our side heavily used. The changes are of limited scope, I would not expect any problems with this. Best regards, Goetz. > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Aleksey Shipilev > Sent: Wednesday, January 26, 2022 12:00 PM > To: jdk-updates-dev at openjdk.java.net > Subject: [11u] RFC: Stack dump improvements > > Hi, > > I was looking at customer support case in 11u recently, which looks like yet > another a class > initialization deadlock. JDK 12+ has two very good improvements to stack > dumps, would these > backports be acceptable? > > I am asking because the dependency tree between these issues is a bit > complicated, and it would > probably raise questions if I suggest 6 dependent backports at once. So I > though I'd give an > overview here. > > The dependency tree looks like this: > > - JDK-8150689: Thread dump report "waiting to re-lock in wait()" shows > incorrectly > - JDK-8214499: SA should follow 8150689 > - JDK-8214148: [TESTBUG] > serviceability/tmtools/jstack/WaitNotifyThreadTest.java... > - JDK-8215050: [TESTBUG] > serviceability/tmtools/jstack/WaitNotifyThreadTest.java... > - JDK-8213397: Stack dump should show more clearly when a thread is > blocked... > - JDK-8217337: [TESTBUG] TestThreadDumpClassInitMonitor.java fails > with Unexpected > > The key issues are JDK-8150689 and JDK-8213397. JDK-8150689 is apparently a > regression from JDK 9. > Doing JDK-8150689 before JDK-8213397 makes all backports clean. The rest > are SA/testbug fixups. > > The overall change is not large: > > $ git diff master --stat > src/hotspot/share/oops/instanceKlass.cpp | 23 +++++---- > src/hotspot/share/runtime/thread.cpp | 3 +- > src/hotspot/share/runtime/thread.hpp | 10 ++++ > src/hotspot/share/runtime/thread.inline.hpp | 12 +++++ > src/hotspot/share/runtime/vframe.cpp | 33 +++++------ > - > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/OopUtilities.jav > a | 22 ++++---- > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaVFrame > .java | 14 ++---- > test/hotspot/jtreg/runtime/Thread/TestThreadDumpClassInitMonitor.java > | 202 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++ > test/hotspot/jtreg/serviceability/tmtools/jstack/WaitNotifyThreadTest.java > | 53 ++++++++++---------- > 9 files changed, 293 insertions(+), 79 deletions(-) > > I ran the composite patch through tier{1,2,3} and jdk_svc on Linux x86_64 > {fastdebug,release} > without problems. > > Thoughts? > > -- > Thanks, > -Aleksey From phh at openjdk.java.net Tue Feb 1 14:22:25 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 1 Feb 2022 14:22:25 GMT Subject: [jdk15u-dev] RFR: 8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic" In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 22:36:46 GMT, Paul Hohensee wrote: > I'd like to backport this as a necessary follow-up to [JDK-8280978](https://bugs.openjdk.java.net/browse/JDK-8280978), which latter is the 15u backport of [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902). > > Applies cleanly, test-only fix that disables MD5/SHA tests for AOT. Patch approved. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/166 From phh at openjdk.java.net Tue Feb 1 14:22:26 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 1 Feb 2022 14:22:26 GMT Subject: [jdk15u-dev] Integrated: 8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic" In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 22:36:46 GMT, Paul Hohensee wrote: > I'd like to backport this as a necessary follow-up to [JDK-8280978](https://bugs.openjdk.java.net/browse/JDK-8280978), which latter is the 15u backport of [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902). > > Applies cleanly, test-only fix that disables MD5/SHA tests for AOT. This pull request has now been integrated. Changeset: 7bf914d6 Author: Paul Hohensee URL: https://git.openjdk.java.net/jdk15u-dev/commit/7bf914d63b90e09a8316fa98deea2e560c7f8959 Stats: 31 lines in 9 files changed: 24 ins; 7 del; 0 mod 8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic" Do not run intrinsics/sha/sanity tests with AOTed java.base Backport-of: 1ad165941313bbaa9e886946081c321f35374f6e ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/166 From phh at openjdk.java.net Tue Feb 1 17:28:37 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 1 Feb 2022 17:28:37 GMT Subject: [jdk17u-dev] RFR: 8278381: [GCC 11] Address::make_raw() does not initialize rspec Message-ID: Trivial gcc 11 compatibility patch, applies cleanly. ------------- Commit messages: - Backport 4f594e6a28ad85d46d3252fb960f1c116f414899 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/141/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=141&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278381 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/141.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/141/head:pull/141 PR: https://git.openjdk.java.net/jdk17u-dev/pull/141 From phh at openjdk.java.net Tue Feb 1 17:45:46 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 1 Feb 2022 17:45:46 GMT Subject: [jdk15u-dev] RFR: 8251216: Implement MD5 intrinsics on AArch64 Message-ID: This backport completes the series whose prefix is JDK-8250902 and JDK-8251260. See https://git.openjdk.java.net/jdk15u-dev/pull/163 and https://git.openjdk.java.net/jdk15u-dev/pull/166 respectively. The backport is clean except for a minor conflict in stubRoutines_aarch64.hpp, where code_size2 is changed to 4500. ------------- Commit messages: - Backport 088b244ec6d9393a1fcd2233fa5b4cf46f9ae0dd Changes: https://git.openjdk.java.net/jdk15u-dev/pull/167/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=167&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251216 Stats: 199 lines in 4 files changed: 193 ins; 1 del; 5 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/167.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/167/head:pull/167 PR: https://git.openjdk.java.net/jdk15u-dev/pull/167 From xliu at openjdk.java.net Tue Feb 1 18:09:16 2022 From: xliu at openjdk.java.net (Xin Liu) Date: Tue, 1 Feb 2022 18:09:16 GMT Subject: [jdk17u-dev] Integrated: 8279124: VM does not handle SIGQUIT during initialization In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 22:59:47 GMT, Xin Liu wrote: > It reduces the risk that the launching JVMs are suppressed due to SIGQUIT sent by attaching clients(such as jcmd) on Posix systems. The patch applies cleanly to jdk17u. The risk is low because it only changes the signal handling of SIGQUIT at the early initialization phrase. > > Testing: tier1. passed all-tiered tests of jdk. This pull request has now been integrated. Changeset: c03b95dc Author: Xin Liu Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u-dev/commit/c03b95dc5929751ae93df9856fd52b362ee9d7d0 Stats: 14 lines in 1 file changed: 10 ins; 0 del; 4 mod 8279124: VM does not handle SIGQUIT during initialization Backport-of: 9bf6ffa19f1ea9efcadb3396d921305c9ec0b1d1 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/137 From phh at openjdk.java.net Tue Feb 1 21:48:10 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 1 Feb 2022 21:48:10 GMT Subject: [jdk11u-dev] RFR: 8261205: AssertionError: Cannot add metadata to an intersection type [v2] In-Reply-To: References: Message-ID: On Sat, 29 Jan 2022 09:05:53 GMT, Liam Miller-Cushon wrote: >> This is a backport of [JDK-8888888: AssertionError: Cannot add metadata to an intersection type](https://bugs.openjdk.java.net/browse/JDK-8261205) >> >> Original patch does not apply cleanly to 11u >> >> * I resolved a conflict where the loop in `JavacParser` that sets `declaredUsingVar = true;` was modified by JDK-8210742 >> * I adjusted the changes to imports, the original patch removed an import of `com.sun.tools.javac.code.Attribute.Array` from `TypeAnnotations.java` that was still being used in 11 >> * I removed the use of multi-line string literals in the test >> >> Testing: x86_64 build, affected tests, tier1 > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 81f39ed3e0176b75dee1c8db24041545bcc68a86 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/794 From phh at openjdk.java.net Tue Feb 1 22:09:34 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 1 Feb 2022 22:09:34 GMT Subject: [jdk11u-dev] RFR: 8278381: [GCC 11] Address::make_raw() does not initialize rspec Message-ID: Trivial gcc 11 compatibility patch, applies cleanly. ------------- Commit messages: - Backport 4f594e6a28ad85d46d3252fb960f1c116f414899 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/804/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=804&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278381 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/804.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/804/head:pull/804 PR: https://git.openjdk.java.net/jdk11u-dev/pull/804 From shade at redhat.com Wed Feb 2 09:50:34 2022 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 2 Feb 2022 12:50:34 +0300 Subject: [11u] RFC: Stack dump improvements In-Reply-To: References: Message-ID: <533469b8-352d-1865-9a57-71050c2b5d98@redhat.com> On 2/1/22 17:07, Lindenmaier, Goetz wrote: > I think this are useful improvements to the thread dumps > which are also on our side heavily used. > The changes are of limited scope, I would not expect > any problems with this. Thanks for the input! I'd like to see other 11u maintainers to chime in too, before I invest time in backporting the whole patch chain :) I realized I should have uploaded the combined patch to demonstrate where the changes are. The substantial changes are in stack printing code, which makes the patches low risk. Here it is: https://cr.openjdk.java.net/~shade/11u-stack-info/combined.patch -- Thanks, -Aleksey From jhuttana at redhat.com Wed Feb 2 09:52:29 2022 From: jhuttana at redhat.com (Jayashree Huttanagoudar) Date: Wed, 2 Feb 2022 15:22:29 +0530 Subject: OpenJDK 11.0.14 Released In-Reply-To: References: Message-ID: Hi, On Tue, Jan 25, 2022 at 1:01 AM Andrew Hughes wrote: > We are pleased to announce the release of OpenJDK 11.0.14. > > The source tarball is available from: > > * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.14-ga.tar.xz > > The tarball is accompanied by a digital signature available at: > > * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.14-ga.tar.xz.sig > > This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): > > PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) > Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F > > SHA256 checksums: > > 45260e906573fcf3665060a71b159a09d79364906d12e984aaf1a3dd2da6d976 > openjdk-11.0.14-ga.tar.xz > b62896e3e84a7c0039cc5bf48261ba4fe08ba38b864d231fb725d45647b9be7f > openjdk-11.0.14-ga.tar.xz.sig > > The checksums can be downloaded from: > > * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.14-ga.sha256 > > The binaries to go with this are here : https://adoptopenjdk.net/upstream.html?variant=openjdk11&jvmVariant=hotspot Thanks & Regards, Jaya > > Thanks, > -- > Andrew :) > Pronouns: he / him or they / them > Senior Free Java Software Engineer > OpenJDK Package Owner > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > From simonis at openjdk.java.net Wed Feb 2 10:00:26 2022 From: simonis at openjdk.java.net (Volker Simonis) Date: Wed, 2 Feb 2022 10:00:26 GMT Subject: [jdk15u-dev] RFR: 8251216: Implement MD5 intrinsics on AArch64 In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 17:36:06 GMT, Paul Hohensee wrote: > This backport completes the series whose prefix is JDK-8250902 and JDK-8251260. See https://git.openjdk.java.net/jdk15u-dev/pull/163 and https://git.openjdk.java.net/jdk15u-dev/pull/166 respectively. > > The backport is clean except for a minor conflict in stubRoutines_aarch64.hpp, where code_size2 is changed to 4500. > > Testing: tier1, including MD5/SHA jtreg tests. Looks good to me. The new code size is probably a little to high because in 18 there are additional stubs which haven't been downported yet, but better be on the safe side :) ------------- Marked as reviewed by simonis (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/167 From duke at openjdk.java.net Wed Feb 2 10:44:31 2022 From: duke at openjdk.java.net (Danil Bubnov) Date: Wed, 2 Feb 2022 10:44:31 GMT Subject: [jdk15u-dev] RFR: 8253639: Change os::attempt_reserve_memory_at parameter order Message-ID: This backport is a part of MacOS/aarch64 support backport. It is needed to backport JDK-8234930. It has been tested (tier1) on Linux x64 and x86, on Windows x64 and on MacOS x64 (https://github.com/KaperD/jdk15u-dev/actions/runs/1769438706) ------------- Commit messages: - 8253639: Change os::attempt_reserve_memory_at parameter order Changes: https://git.openjdk.java.net/jdk15u-dev/pull/168/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=168&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253639 Stats: 27 lines in 10 files changed: 0 ins; 0 del; 27 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/168.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/168/head:pull/168 PR: https://git.openjdk.java.net/jdk15u-dev/pull/168 From duke at openjdk.java.net Wed Feb 2 12:31:05 2022 From: duke at openjdk.java.net (Ivan Tsenov) Date: Wed, 2 Feb 2022 12:31:05 GMT Subject: [jdk11u-dev] RFR: 8218546: Unable to connect to https://google.com using java.net.HttpClient In-Reply-To: References: Message-ID: On Thu, 27 Jan 2022 09:16:03 GMT, Aleksey Shipilev wrote: > Clean backport to fix 11.0.14 regression. There are multiple reports about this breakage. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] Linux x86_64 `{fastdebug, release}`, `java/net/httpclient` passes > - [x] Linux x86_64 `{fastdebug, release}`, `tier1` passes > - [x] Linux x86_64 `{fastdebug, release}`, `tier2` passes > - [x] Linux x86_64 `{fastdebug, release}`, `tier3` passes Hello, For the past 2 days we have been fighting with this topic. Turns out that nginx 1.20.0 also forbids this behavior and returns 400 bad request. Could be only this version, or the specific version included in Amazon Linux 2. I don't know if they make their own changes. Best, Ivan ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/798 From phh at openjdk.java.net Wed Feb 2 13:02:14 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 2 Feb 2022 13:02:14 GMT Subject: [jdk15u-dev] RFR: 8251216: Implement MD5 intrinsics on AArch64 In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 17:36:06 GMT, Paul Hohensee wrote: > This backport completes the series whose prefix is JDK-8250902 and JDK-8251260. See https://git.openjdk.java.net/jdk15u-dev/pull/163 and https://git.openjdk.java.net/jdk15u-dev/pull/166 respectively. > > The backport is clean except for a minor conflict in stubRoutines_aarch64.hpp, where code_size2 is changed to 45000. > > Testing: tier1, including MD5/SHA jtreg tests. That's what I thought too. Also, it's a tiny bit less different from the original patch to leave it at 45000. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/167 From phh at openjdk.java.net Wed Feb 2 13:29:10 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 2 Feb 2022 13:29:10 GMT Subject: [jdk17u-dev] RFR: 8278381: [GCC 11] Address::make_raw() does not initialize rspec In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 17:20:54 GMT, Paul Hohensee wrote: > Trivial gcc 11 compatibility patch, applies cleanly. Approved. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/141 From phh at openjdk.java.net Wed Feb 2 13:29:10 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 2 Feb 2022 13:29:10 GMT Subject: [jdk17u-dev] Integrated: 8278381: [GCC 11] Address::make_raw() does not initialize rspec In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 17:20:54 GMT, Paul Hohensee wrote: > Trivial gcc 11 compatibility patch, applies cleanly. This pull request has now been integrated. Changeset: 6cacf9af Author: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u-dev/commit/6cacf9afd904f692445b5566e4ec192c3771e53c Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8278381: [GCC 11] Address::make_raw() does not initialize rspec Backport-of: 4f594e6a28ad85d46d3252fb960f1c116f414899 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/141 From phh at openjdk.java.net Wed Feb 2 13:35:17 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 2 Feb 2022 13:35:17 GMT Subject: [jdk15u-dev] RFR: 8251216: Implement MD5 intrinsics on AArch64 In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 17:36:06 GMT, Paul Hohensee wrote: > This backport completes the series whose prefix is JDK-8250902 and JDK-8251260. See https://git.openjdk.java.net/jdk15u-dev/pull/163 and https://git.openjdk.java.net/jdk15u-dev/pull/166 respectively. > > The backport is clean except for a minor conflict in stubRoutines_aarch64.hpp, where code_size2 is changed to 45000. > > Testing: tier1, including MD5/SHA jtreg tests. Approved. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/167 From phh at openjdk.java.net Wed Feb 2 13:35:18 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 2 Feb 2022 13:35:18 GMT Subject: [jdk15u-dev] Integrated: 8251216: Implement MD5 intrinsics on AArch64 In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 17:36:06 GMT, Paul Hohensee wrote: > This backport completes the series whose prefix is JDK-8250902 and JDK-8251260. See https://git.openjdk.java.net/jdk15u-dev/pull/163 and https://git.openjdk.java.net/jdk15u-dev/pull/166 respectively. > > The backport is clean except for a minor conflict in stubRoutines_aarch64.hpp, where code_size2 is changed to 45000. > > Testing: tier1, including MD5/SHA jtreg tests. This pull request has now been integrated. Changeset: 2802620c Author: Paul Hohensee URL: https://git.openjdk.java.net/jdk15u-dev/commit/2802620cb8cf38e221c735581623fbf0afbd21c9 Stats: 199 lines in 4 files changed: 193 ins; 1 del; 5 mod 8251216: Implement MD5 intrinsics on AArch64 Reviewed-by: simonis Backport-of: 088b244ec6d9393a1fcd2233fa5b4cf46f9ae0dd ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/167 From asemenov at openjdk.java.net Wed Feb 2 13:52:26 2022 From: asemenov at openjdk.java.net (Artem Semenov) Date: Wed, 2 Feb 2022 13:52:26 GMT Subject: [jdk17u] Withdrawn: 8277497: Last column cell in the JTable row is read as empty cell In-Reply-To: References: Message-ID: <14xXnFIcZ4-km9W4hZbzne5vOLN_zE8z2e2c7DSG2Ds=.6f4c8ef7-0681-43ef-84f4-0d762fb2acb6@github.com> On Wed, 8 Dec 2021 11:09:48 GMT, Artem Semenov wrote: > Hi all, > > This pull request contains a backport of commit 70bad89b from the openjdk/jdk repository. > > The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/324 From goetz at openjdk.java.net Wed Feb 2 14:21:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 2 Feb 2022 14:21:46 GMT Subject: [jdk17u-dev] RFR: 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions Message-ID: I backport this for parity with 17.0.3-oracle. ------------- Commit messages: - Backport 3e798dd40c68439f3220445e679b9e0e495435d8 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/143/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=143&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275330 Stats: 190 lines in 8 files changed: 135 ins; 22 del; 33 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/143.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/143/head:pull/143 PR: https://git.openjdk.java.net/jdk17u-dev/pull/143 From volker.simonis at gmail.com Wed Feb 2 19:27:07 2022 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 2 Feb 2022 20:27:07 +0100 Subject: [11u] Should we make patch 11.0.14.1 with JDK-8218546 and JDK-8280786? In-Reply-To: References: Message-ID: Hi Goetz, we would welcome an "official" patch 11.0.14.1. We identified some internal customers who are affected of this issue and decided to respin a fixed version of Corretto 11.0.14 anyway. But having this fix in an official 11.0.14.1 would be obviously the preferred solution. So in case you do it, we will wait for you. Thanks for driving this, Volker On Tue, Feb 1, 2022 at 12:18 PM Lindenmaier, Goetz wrote: > > Hi, > > we (SAP) checked with our internal stakeholders and decided to > release a patch for SapMachine 11.0.14 with JDK-8218546. > > We would prefer to have an "official" patch 11.0.14.1 in > OpenJDK jdk11u including this change. Alternatively, we could > also release a patch 11.0.14.0.1 only for SapMachine. > > I think JDK-8218546 is a clear regression in 11.0.14 and > thus jdk11u should tag a release that fixes this. Nobody is > forced to release a build with this, but anyone who runs > into this problem has a clear path to solve it. > > I would propose to include the Solaris build fix JDK-8280786 > in this patch, too. > > After all, tagging such a release in jdk11u is not much > effort. Both issues are fixed in 11.0.15/jdk11u-dev and can > easily be cherry-picked to jdk11u. > > I would hold back consolidating 11.0.15/jdk11u-dev to jdk11u > until this is done. Tag 11.0.15+1 is scheduled for tonight. > > Best regards, > Goetz > > > https://bugs.openjdk.java.net/browse/8218546: > Unable to connect to https://google.com using java.net.HttpClient > https://bugs.openjdk.java.net/browse/8280786: > Build failure on Solaris after 8262392 From serb at openjdk.java.net Wed Feb 2 21:20:38 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Wed, 2 Feb 2022 21:20:38 GMT Subject: [jdk17u-dev] RFR: 8274751: Drag And Drop hangs on Windows Message-ID: Hi all, This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport 7a0a6c95a53c6cb3340328d6543a97807320b740 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/142/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=142&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274751 Stats: 19 lines in 4 files changed: 2 ins; 0 del; 17 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/142.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/142/head:pull/142 PR: https://git.openjdk.java.net/jdk17u-dev/pull/142 From phh at openjdk.java.net Wed Feb 2 22:21:41 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 2 Feb 2022 22:21:41 GMT Subject: [jdk15u-dev] RFR: 8278381: [GCC 11] Address::make_raw() does not initialize rspec Message-ID: Trivial gcc 11 compatibility patch, applies cleanly. ------------- Commit messages: - Backport 4f594e6a28ad85d46d3252fb960f1c116f414899 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/169/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=169&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278381 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/169.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/169/head:pull/169 PR: https://git.openjdk.java.net/jdk15u-dev/pull/169 From serb at openjdk.java.net Wed Feb 2 22:54:25 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Wed, 2 Feb 2022 22:54:25 GMT Subject: [jdk18u] Integrated: 8280910: Update openjdk project in jcheck to "jdk-updates" for jdk18u In-Reply-To: References: Message-ID: On Sat, 29 Jan 2022 01:47:00 GMT, Sergey Bylokhov wrote: > The openjdk project in jcheck should be changed to "jdk-updates" for jdk18u This pull request has now been integrated. Changeset: e32fb7fc Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk18u/commit/e32fb7fc20239cf6f7321f7ffbbe48879c5b1909 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8280910: Update openjdk project in jcheck to "jdk-updates" for jdk18u Reviewed-by: erikj ------------- PR: https://git.openjdk.java.net/jdk18u/pull/11 From duke at openjdk.java.net Wed Feb 2 23:18:52 2022 From: duke at openjdk.java.net (GlebSolovev) Date: Wed, 2 Feb 2022 23:18:52 GMT Subject: [jdk15u-dev] RFR: 8253639: Change os::attempt_reserve_memory_at parameter order Message-ID: Clean backport of https://bugs.openjdk.java.net/browse/JDK-8253639: simple changing parameter order to improve code consistency. Testing: tier1 on Linux x86 didn't regress. ------------- Commit messages: - 8253639: Change os::attempt_reserve_memory_at parameter order Changes: https://git.openjdk.java.net/jdk15u-dev/pull/156/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=156&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253639 Stats: 27 lines in 10 files changed: 0 ins; 0 del; 27 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/156.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/156/head:pull/156 PR: https://git.openjdk.java.net/jdk15u-dev/pull/156 From robilad at openjdk.java.net Wed Feb 2 23:18:53 2022 From: robilad at openjdk.java.net (Dalibor Topic) Date: Wed, 2 Feb 2022 23:18:53 GMT Subject: [jdk15u-dev] RFR: 8253639: Change os::attempt_reserve_memory_at parameter order In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 17:10:45 GMT, GlebSolovev wrote: > Clean backport of https://bugs.openjdk.java.net/browse/JDK-8253639: simple changing parameter order to improve code consistency. > > Testing: tier1 on Linux x86 didn't regress. Hi Gleb, can you please send me an e-mail at Dalibor.topic at oracle.com so that I can mark your account as verified? ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/156 From serb at openjdk.java.net Thu Feb 3 01:13:07 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Thu, 3 Feb 2022 01:13:07 GMT Subject: [jdk11u-dev] RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3 In-Reply-To: References: Message-ID: On Wed, 19 Jan 2022 10:16:24 GMT, Aleksey Shipilev wrote: > Unclean backport to improve 11u testing. It does not apply cleanly for two reasons: > > - https://bugs.openjdk.java.net/browse/JDK-8265793 is not in 11u yet, and I think it would be cleaner to backport that one *after* this issue; > - https://github.com/openjdk/jdk/commit/1b45bf2d581bf75fabefa13e56ecec6e6ae9036c is not in 11u, and it would be not that relevant after this backport; > > The avaiability of catch-all `jdk:tier4` protects us from skipping the tests. If there are test group mistakes that drop some tests from `jdk:tier3`, they would be captured by `jdk:tier4`. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk:tier3` I am not sure we should backport the JDK-8265793, the OpenJDK does not have duplicate tests in tier3 like described in that bug. ------------- Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/780 From duke at openjdk.java.net Thu Feb 3 04:40:12 2022 From: duke at openjdk.java.net (duke) Date: Thu, 3 Feb 2022 04:40:12 GMT Subject: [jdk11u-dev] Withdrawn: 7107615: scalability bloker in javax.crypto.JceSecurity In-Reply-To: References: Message-ID: On Tue, 7 Dec 2021 11:10:45 GMT, olivergillespie wrote: > Clean backport of https://github.com/openjdk/jdk/commit/74d45e481d1ad6aa5d7c6315ea86681e1a978ce0 > which addresses https://bugs.openjdk.java.net/browse/JDK-7107615. > The improved performance is useful for me and I expect many other people. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/690 From thartmann at openjdk.java.net Thu Feb 3 06:22:12 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Thu, 3 Feb 2022 06:22:12 GMT Subject: [jdk18u] Integrated: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 10:32:45 GMT, Tobias Hartmann wrote: > Backport of [JDK-8279437](https://bugs.openjdk.java.net/browse/JDK-8279437). Applies cleanly. Fix request is pending. This pull request has now been integrated. Changeset: 2b74a8d2 Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk18u/commit/2b74a8d2a1c2c3f27d6d3a701802c6205f7419c9 Stats: 492 lines in 10 files changed: 359 ins; 32 del; 101 mod 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM Backport-of: e14fb4f4aa9c4569615005e474f897c54094f024 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/17 From thartmann at openjdk.java.net Thu Feb 3 06:24:21 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Thu, 3 Feb 2022 06:24:21 GMT Subject: [jdk18u] Integrated: 8279225: [arm32] C1 longs comparison operation destroys argument registers In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 10:29:15 GMT, Tobias Hartmann wrote: > Backport of [JDK-8279225](https://bugs.openjdk.java.net/browse/JDK-8279225). Applies cleanly. Fix request is pending. This pull request has now been integrated. Changeset: 313932af Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk18u/commit/313932af0acb0ab23089a2b3bd34e1613874fa8b Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8279225: [arm32] C1 longs comparison operation destroys argument registers Backport-of: 299022dfacbcb49e3bc5beca8ff9b1fca1101493 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/15 From thartmann at openjdk.java.net Thu Feb 3 06:25:14 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Thu, 3 Feb 2022 06:25:14 GMT Subject: [jdk18u] Integrated: 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 10:27:20 GMT, Tobias Hartmann wrote: > Backport of [JDK-8273139](https://bugs.openjdk.java.net/browse/JDK-8273139). Applies cleanly. Fix request is pending. This pull request has now been integrated. Changeset: 34f28646 Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk18u/commit/34f2864680f8928541b302d574e8d4b56db050ed Stats: 19 lines in 1 file changed: 2 ins; 5 del; 12 mod 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency Backport-of: 68b40ec28658a2dd829c77281b0025e16095c170 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/14 From thartmann at openjdk.java.net Thu Feb 3 06:26:23 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Thu, 3 Feb 2022 06:26:23 GMT Subject: [jdk18u] Integrated: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 10:31:03 GMT, Tobias Hartmann wrote: > Backport of [JDK-8279412](https://bugs.openjdk.java.net/browse/JDK-8279412). Applies cleanly. Fix request is pending. This pull request has now been integrated. Changeset: d21b5e77 Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk18u/commit/d21b5e77fad0b8c0ea1de4459408390e56e157cc Stats: 41 lines in 2 files changed: 29 ins; 10 del; 2 mod 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it Backport-of: 1ffdc52cf0ab88458e0583bff28d35ca33d244b7 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/16 From thartmann at openjdk.java.net Thu Feb 3 06:27:20 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Thu, 3 Feb 2022 06:27:20 GMT Subject: [jdk18u] Integrated: 8258814: Compilation logging crashes for thread suspension / debugging tests In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 10:25:15 GMT, Tobias Hartmann wrote: > Backport of [JDK-8258814](https://bugs.openjdk.java.net/browse/JDK-8258814). Applies cleanly. Fix request is pending. This pull request has now been integrated. Changeset: 93453364 Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk18u/commit/93453364ed48314d6349759d8ea22f209e19a6f0 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8258814: Compilation logging crashes for thread suspension / debugging tests Backport-of: 35ee0f38c6d5e35fb50a059a189e032df7f7e7c5 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/13 From thartmann at openjdk.java.net Thu Feb 3 06:28:17 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Thu, 3 Feb 2022 06:28:17 GMT Subject: [jdk18u] Integrated: 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN In-Reply-To: References: Message-ID: <8xipFSbI79tE15em0lJfdyj1LbqcnaxLIR68P99MlxY=.5ad11f16-5eaf-46b6-bdc5-3641a1df8517@github.com> On Tue, 1 Feb 2022 10:34:17 GMT, Tobias Hartmann wrote: > Backport of [JDK-8280123](https://bugs.openjdk.java.net/browse/JDK-8280123). Applies cleanly. Fix request is pending. This pull request has now been integrated. Changeset: 68a08070 Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk18u/commit/68a08070caa7b8f0e8d582a208b3cb90a02f7091 Stats: 93 lines in 2 files changed: 72 ins; 4 del; 17 mod 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN Backport-of: 3f747368b9a5c321d2724ba57103f17edc166251 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/18 From duke at openjdk.java.net Thu Feb 3 07:51:13 2022 From: duke at openjdk.java.net (Danil Bubnov) Date: Thu, 3 Feb 2022 07:51:13 GMT Subject: [jdk15u-dev] Integrated: 8253639: Change os::attempt_reserve_memory_at parameter order In-Reply-To: References: Message-ID: On Wed, 2 Feb 2022 10:37:47 GMT, Danil Bubnov wrote: > This backport is a part of MacOS/aarch64 support backport. It is needed to backport JDK-8234930. > > It has been tested (tier1) on Linux x64 and x86, on Windows x64 and on MacOS x64 (https://github.com/KaperD/jdk15u-dev/actions/runs/1769438706) This pull request has now been integrated. Changeset: 78948158 Author: Danil Bubnov Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/78948158d6ade26f87cc3b05cc0719af4db8d00a Stats: 27 lines in 10 files changed: 0 ins; 0 del; 27 mod 8253639: Change os::attempt_reserve_memory_at parameter order Backport-of: ca1ed16292492d256d076122d124be8978fce4c3 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/168 From mbaesken at openjdk.java.net Thu Feb 3 08:12:14 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 3 Feb 2022 08:12:14 GMT Subject: [jdk18u] Integrated: 8280414: Memory leak in DefaultProxySelector In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 08:02:55 GMT, Matthias Baesken wrote: > 8280414: Memory leak in DefaultProxySelector This pull request has now been integrated. Changeset: 1f039b3e Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk18u/commit/1f039b3e1d724f53c69c86609bb48f393076dfcb Stats: 11 lines in 1 file changed: 1 ins; 3 del; 7 mod 8280414: Memory leak in DefaultProxySelector Backport-of: fe77250fa450ec803d2818dc90c5bf156521d537 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/12 From serb at openjdk.java.net Thu Feb 3 08:18:22 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Thu, 3 Feb 2022 08:18:22 GMT Subject: [jdk11u-dev] Integrated: 8256321: Some "inactive" color profiles use the wrong profile class In-Reply-To: <8JhaqeGxF44Tb7Y79S0tcjebPljTqcdP5sLLXur26n0=.dfe249bf-6f57-4571-bc73-c3b0677a1c0c@github.com> References: <8JhaqeGxF44Tb7Y79S0tcjebPljTqcdP5sLLXur26n0=.dfe249bf-6f57-4571-bc73-c3b0677a1c0c@github.com> Message-ID: On Tue, 25 Jan 2022 22:55:41 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [a6c08813](https://github.com/openjdk/jdk/commit/a6c08813) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 5 Jan 2021 and was reviewed by Phil Race. > See more details [here](https://github.com/openjdk/jdk/pull/1211). > > This change is one of the steps to update the CMM deferral machinery, see (https://bugs.openjdk.java.net/browse/JDK-6986863) > > The added test is red before the fix and green after. The jdk_desktop tests are green. This pull request has now been integrated. Changeset: 01c38c4f Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk11u-dev/commit/01c38c4ffa1f408061caee9aed2e4e863d01207f Stats: 87 lines in 2 files changed: 85 ins; 0 del; 2 mod 8256321: Some "inactive" color profiles use the wrong profile class Backport-of: a6c088131bfeec1ce44e43b513ce3f857fa6e44f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/793 From goetz at openjdk.java.net Thu Feb 3 08:25:21 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 08:25:21 GMT Subject: [jdk17u-dev] Integrated: 8271506: Add ResourceHashtable support for deleting selected entries In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 08:38:32 GMT, Goetz Lindenmaier wrote: > I backport this as prerequisite to JDK-8274944 which calls the new method unlink(). > > I had to adapt the code to work in jdk17 because ""JDK-8269004: Implement ResizableResourceHashtable" is missing in 17. This pull request has now been integrated. Changeset: 0b51fe2b Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/0b51fe2bce55991e608352954a2266f4702642bf Stats: 50 lines in 2 files changed: 50 ins; 0 del; 0 mod 8271506: Add ResourceHashtable support for deleting selected entries Reviewed-by: stuefe Backport-of: f15d6cbcaf191b9718ab51b1e8b72938c0abdd6b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/132 From duke at openjdk.java.net Thu Feb 3 08:27:23 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Thu, 3 Feb 2022 08:27:23 GMT Subject: [jdk17u-dev] RFR: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info [v3] In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 12:39:38 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.3-oracle. >> >> I had to adapt the tests: I removed one check from dynamicArchive/LambdaContainsOldInf.java. >> >> This depends on JDK-8271506. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport e5cd2692da6327c6fde954f86595a08fe5edf43f The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8271506 git fetch https://git.openjdk.java.net/jdk17u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/133 From goetz at openjdk.java.net Thu Feb 3 08:32:29 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 08:32:29 GMT Subject: [jdk17u-dev] Integrated: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 09:17:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: e459c8cb Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/e459c8cbaa33ab63bd5d48540852906255f4dd24 Stats: 52 lines in 5 files changed: 21 ins; 19 del; 12 mod 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue Backport-of: 2448b3f5f96ec4d9ea8fe9dae32a0aab725fb4ad ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/138 From goetz at openjdk.java.net Thu Feb 3 08:34:14 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 08:34:14 GMT Subject: [jdk17u-dev] Integrated: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 09:16:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > > I had to adapt the tests: I removed one check from dynamicArchive/LambdaContainsOldInf.java. > > This depends on JDK-8271506. This pull request has now been integrated. Changeset: 5d54bf50 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/5d54bf504ecfd5c0f112deb2fde3fa7168357ac3 Stats: 248 lines in 9 files changed: 248 ins; 0 del; 0 mod 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info Reviewed-by: stuefe Backport-of: e5cd2692da6327c6fde954f86595a08fe5edf43f ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/133 From goetz at openjdk.java.net Thu Feb 3 08:38:32 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 08:38:32 GMT Subject: [jdk17u-dev] Integrated: 8275847: Scheduling fails with "too many D-U pinch points" on small method In-Reply-To: <9cuFFTYI9AxBV-0lIdlB8hAYg9j1Er_NjIGrHXRzfh8=.4ef30f84-6d2f-4e72-af6c-6fd13d02486e@github.com> References: <9cuFFTYI9AxBV-0lIdlB8hAYg9j1Er_NjIGrHXRzfh8=.4ef30f84-6d2f-4e72-af6c-6fd13d02486e@github.com> Message-ID: On Mon, 31 Jan 2022 12:53:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: ff3eec18 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/ff3eec181b1ddbda0f1aa9f274b5069d8d4d654e Stats: 89 lines in 4 files changed: 74 ins; 10 del; 5 mod 8275847: Scheduling fails with "too many D-U pinch points" on small method Backport-of: 3934fe54b4c3e51add6d3fe1f145e5aebfe3b2fc ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/134 From goetz at openjdk.java.net Thu Feb 3 08:40:16 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 08:40:16 GMT Subject: [jdk17u-dev] Integrated: 8271056: C2: "assert(no_dead_loop) failed: dead loop detected" due to cmoving identity In-Reply-To: References: Message-ID: <-1tr2ZHoGNtvG7gltpIJDenQf-OjN5dGdSN15DT0dWM=.af81e971-9138-4e5c-9721-f6d4e792b542@github.com> On Mon, 31 Jan 2022 13:09:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: 27cbe247 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/27cbe247e6934faa66ff56ff19e1d77b7752a973 Stats: 87 lines in 2 files changed: 85 ins; 0 del; 2 mod 8271056: C2: "assert(no_dead_loop) failed: dead loop detected" due to cmoving identity Backport-of: 54481394a3b7d36b2326e22e4aa910a3e8041b5c ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/136 From goetz at openjdk.java.net Thu Feb 3 08:48:31 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 08:48:31 GMT Subject: [jdk17u-dev] Integrated: 8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 10:36:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > Requires follow-up test fix. This pull request has now been integrated. Changeset: f7235889 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/f7235889bb046dce52f2733b2af25de5f5236415 Stats: 51 lines in 2 files changed: 51 ins; 0 del; 0 mod 8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg Backport-of: 47564caeb0628e5c03a0e7f04093adce77d6dd3b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/139 From goetz at openjdk.java.net Thu Feb 3 08:56:01 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 08:56:01 GMT Subject: [jdk17u-dev] RFR: 8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs [v2] In-Reply-To: <8ylvkkkUO8lNyqatNwUqz4Y2H2SEIUIpxY3xQxg6YY8=.941bd0b2-b2ff-4b78-8292-e457a50b1902@github.com> References: <8ylvkkkUO8lNyqatNwUqz4Y2H2SEIUIpxY3xQxg6YY8=.941bd0b2-b2ff-4b78-8292-e457a50b1902@github.com> Message-ID: <4IF-H2sPDrVlfFQmlLO05Kt0WylJ_idhd9CYhTQDMic=.f7a2e321-e81d-4051-ae83-42178000e930@github.com> > I backport this for parity with 17.0.3-oracle. > Follow up to JDK-8275643 Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport b15e6f076afe5ac68e9af68756860d0b25adea4b ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/140/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/140/files/f1953348..99fdb5d6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=140&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=140&range=00-01 Stats: 573 lines in 27 files changed: 519 ins; 29 del; 25 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/140.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/140/head:pull/140 PR: https://git.openjdk.java.net/jdk17u-dev/pull/140 From goetz at openjdk.java.net Thu Feb 3 08:56:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 08:56:02 GMT Subject: [jdk17u-dev] Integrated: 8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs In-Reply-To: <8ylvkkkUO8lNyqatNwUqz4Y2H2SEIUIpxY3xQxg6YY8=.941bd0b2-b2ff-4b78-8292-e457a50b1902@github.com> References: <8ylvkkkUO8lNyqatNwUqz4Y2H2SEIUIpxY3xQxg6YY8=.941bd0b2-b2ff-4b78-8292-e457a50b1902@github.com> Message-ID: On Tue, 1 Feb 2022 10:53:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > Follow up to JDK-8275643 This pull request has now been integrated. Changeset: cd730957 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/cd730957d0b490af1fbb0fef77112bcd519d99ae Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs Backport-of: b15e6f076afe5ac68e9af68756860d0b25adea4b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/140 From duke at openjdk.java.net Thu Feb 3 10:13:09 2022 From: duke at openjdk.java.net (GlebSolovev) Date: Thu, 3 Feb 2022 10:13:09 GMT Subject: [jdk15u-dev] RFR: 8253639: Change os::attempt_reserve_memory_at parameter order In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 17:10:45 GMT, GlebSolovev wrote: > Clean backport of https://bugs.openjdk.java.net/browse/JDK-8253639: simple changing parameter order to improve code consistency. > > Testing: tier1 on Linux x86 didn't regress. As a result of race-condition in out team, this change has already been made here: https://github.com/openjdk/jdk15u-dev/pull/168. I'm sorry, I'm closing this pull request. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/156 From duke at openjdk.java.net Thu Feb 3 10:13:09 2022 From: duke at openjdk.java.net (GlebSolovev) Date: Thu, 3 Feb 2022 10:13:09 GMT Subject: [jdk15u-dev] Withdrawn: 8253639: Change os::attempt_reserve_memory_at parameter order In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 17:10:45 GMT, GlebSolovev wrote: > Clean backport of https://bugs.openjdk.java.net/browse/JDK-8253639: simple changing parameter order to improve code consistency. > > Testing: tier1 on Linux x86 didn't regress. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/156 From shade at openjdk.java.net Thu Feb 3 10:49:15 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 3 Feb 2022 10:49:15 GMT Subject: [jdk11u-dev] RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3 In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 01:10:03 GMT, Sergey Bylokhov wrote: > I am not sure we should backport the JDK-8265793, the OpenJDK does not have duplicate tests in tier3 like described in that bug. Thanks! Indeed. I was just saying if we were to backport that one, it would probably make sense to do after this one. I tagged the issue for 11u approvals. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/780 From coffeys at openjdk.java.net Thu Feb 3 14:49:42 2022 From: coffeys at openjdk.java.net (Sean Coffey) Date: Thu, 3 Feb 2022 14:49:42 GMT Subject: [jdk18u] RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs Message-ID: Clean port to jdk18u. Awaiting 18u integration approval. ------------- Commit messages: - Backport 61b8944327e3d12cf58dc3f6bc45ecbeba4ef611 Changes: https://git.openjdk.java.net/jdk18u/pull/19/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=19&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278851 Stats: 264 lines in 3 files changed: 214 ins; 20 del; 30 mod Patch: https://git.openjdk.java.net/jdk18u/pull/19.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/19/head:pull/19 PR: https://git.openjdk.java.net/jdk18u/pull/19 From dchuyko at openjdk.java.net Thu Feb 3 16:11:19 2022 From: dchuyko at openjdk.java.net (Dmitry Chuyko) Date: Thu, 3 Feb 2022 16:11:19 GMT Subject: [jdk17u-dev] Integrated: 8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64 In-Reply-To: References: Message-ID: On Thu, 27 Jan 2022 15:08:08 GMT, Dmitry Chuyko wrote: > This change for 2 ISAs fixes the performance regression seen between 11 and 17. Numbers in the issue (x86 I guess) mention 17% in Dacapo h2. AArch64 results for 17u in that benchmark are slightly different but still impressive: 17u now is ~3% worse than 11u, this patch improves the score by 10%. > > Original patch applies cleanly. > > Testing: jtreg tier1, tier2 in dev environment, pre-submit checks. This pull request has now been integrated. Changeset: dba064ae Author: Dmitry Chuyko Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u-dev/commit/dba064ae107120109f792909475810afde7705e8 Stats: 44 lines in 2 files changed: 31 ins; 6 del; 7 mod 8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64 Backport-of: d93b238f9725727ae1e2e9f203943b5ddf778f35 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/126 From omikhaltcova at openjdk.java.net Thu Feb 3 16:30:31 2022 From: omikhaltcova at openjdk.java.net (Olga Mikhaltsova) Date: Thu, 3 Feb 2022 16:30:31 GMT Subject: [jdk15u-dev] RFR: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 Message-ID: I'd like to backport JDK-8280373 to jdk15u in order to align after JDK-8270492 the copy `src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java` to its origin `src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/SystemIDResolver.java` All regular tests passed. ------------- Commit messages: - Backport c180070cb59b8e075376ae913c5db9a4ed868303 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/170/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=170&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280373 Stats: 5 lines in 1 file changed: 2 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/170.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/170/head:pull/170 PR: https://git.openjdk.java.net/jdk15u-dev/pull/170 From omikhaltcova at openjdk.java.net Thu Feb 3 16:30:37 2022 From: omikhaltcova at openjdk.java.net (Olga Mikhaltsova) Date: Thu, 3 Feb 2022 16:30:37 GMT Subject: [jdk13u-dev] RFR: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 Message-ID: I'd like to backport JDK-8280373 to jdk13u in order to align after JDK-8270492 the copy `src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java` to its origin `src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/SystemIDResolver.java` All regular tests passed. ------------- Commit messages: - Backport c180070cb59b8e075376ae913c5db9a4ed868303 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/323/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=323&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280373 Stats: 5 lines in 1 file changed: 2 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/323.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/323/head:pull/323 PR: https://git.openjdk.java.net/jdk13u-dev/pull/323 From goetz at openjdk.java.net Thu Feb 3 19:41:44 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Feb 2022 19:41:44 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider Message-ID: I backport this for parity with 11.0.15-oracle. I had to do a row of adaptions. There are some implementation differences, and many Java 17 usages that had to be changed. In the original change in SunPKCS11.java, dA() is used to give alias names of algorithms. It calls to SecurityProviderConstants.getAliases(). In SunPKCS11.java of jdk11 neither dA() nore getAliases() are available. It uses d() instead of da() and calls a s() with a list of literal strings to give the alias names. SecurityProviderConstants.java is in java.base. The jdk11 version does not contain the list of aliases that can be found in 17. I looked up whether there are aliases listed for "ChaCha20-Poly1305" in 17, but found none, so I added an empty call s() in SunPKCS11.java. In P11AEADCipher.java I had to modify the syntax of a switch statement. In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java I had to replace HexFormat.of().formatHex(...) which is a java.util class not in 11. The tests use HexFormat heavily. I replaced it by HexToBytes() from TestKATForGCM and by toHexString() from TestLeadingZeroesP11.java. To make these methods available I moved them to the superclass PKCS11Test.java. This way they can be used for potential later backports, too. I also had to adapt a switch statement using '->' to syntax know to 11. ------------- Commit messages: - Backport 5d8c1cc8a05e0d9aedd6d54b8147d374c2290024 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/805/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=805&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255410 Stats: 1690 lines in 19 files changed: 1530 ins; 75 del; 85 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/805.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/805/head:pull/805 PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From phh at openjdk.java.net Thu Feb 3 20:26:51 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 3 Feb 2022 20:26:51 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 Message-ID: I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. Testing: tier1, including the new and existing sha tests. Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. 1. Copyright date conflicts. 2. Context differences. 3. Changing SHAOptionsBase to DigestOptionsBase. 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). ------------- Commit messages: - Backport 339016a0f2cbbbbc3560e50c6726e14afbf547f6 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/806/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=806&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8250902 Stats: 1983 lines in 57 files changed: 1193 ins; 457 del; 333 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/806.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/806/head:pull/806 PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From omikhaltcova at openjdk.java.net Fri Feb 4 07:43:26 2022 From: omikhaltcova at openjdk.java.net (Olga Mikhaltsova) Date: Fri, 4 Feb 2022 07:43:26 GMT Subject: [jdk15u-dev] Integrated: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 16:22:34 GMT, Olga Mikhaltsova wrote: > I'd like to backport JDK-8280373 to jdk15u in order to align after JDK-8270492 the copy > `src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java` > to its origin > `src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/SystemIDResolver.java` > All regular tests passed. This pull request has now been integrated. Changeset: 6ea7ef60 Author: Olga Mikhaltsova URL: https://git.openjdk.java.net/jdk15u-dev/commit/6ea7ef60d92de20e312837a1fe8fd6279a0e37af Stats: 5 lines in 1 file changed: 2 ins; 1 del; 2 mod 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 Backport-of: c180070cb59b8e075376ae913c5db9a4ed868303 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/170 From omikhaltcova at openjdk.java.net Fri Feb 4 07:44:19 2022 From: omikhaltcova at openjdk.java.net (Olga Mikhaltsova) Date: Fri, 4 Feb 2022 07:44:19 GMT Subject: [jdk13u-dev] Integrated: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 16:21:30 GMT, Olga Mikhaltsova wrote: > I'd like to backport JDK-8280373 to jdk13u in order to align after JDK-8270492 the copy > `src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java` > to its origin > `src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/SystemIDResolver.java` > All regular tests passed. This pull request has now been integrated. Changeset: e77beca5 Author: Olga Mikhaltsova URL: https://git.openjdk.java.net/jdk13u-dev/commit/e77beca5dc19896409c2cc1c78257e3d4320b67c Stats: 5 lines in 1 file changed: 2 ins; 1 del; 2 mod 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 Backport-of: c180070cb59b8e075376ae913c5db9a4ed868303 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/323 From goetz at openjdk.java.net Fri Feb 4 09:25:43 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 4 Feb 2022 09:25:43 GMT Subject: [jdk17u-dev] RFR: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently Message-ID: I backport this for parity with 17.0.3-oracle. ------------- Commit messages: - Backport f1c20e91d822c6df4c5da895f2abd6305e00bf8b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/144/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=144&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8190748 Stats: 12 lines in 2 files changed: 6 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/144.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/144/head:pull/144 PR: https://git.openjdk.java.net/jdk17u-dev/pull/144 From aph-open at littlepinkcloud.com Fri Feb 4 10:18:42 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Fri, 4 Feb 2022 10:18:42 +0000 Subject: [11u] Should we make patch 11.0.14.1 with JDK-8218546 and JDK-8280786? In-Reply-To: References: Message-ID: On 2/1/22 11:17, Lindenmaier, Goetz wrote: > we (SAP) checked with our internal stakeholders and decided to > release a patch for SapMachine 11.0.14 with JDK-8218546. > > We would prefer to have an "official" patch 11.0.14.1 in > OpenJDK jdk11u including this change. Alternatively, we could > also release a patch 11.0.14.0.1 only for SapMachine. > > I think JDK-8218546 is a clear regression in 11.0.14 and > thus jdk11u should tag a release that fixes this. This reasoning does not necessarily follow: a regression in a point release does not always justify a respin. It must be a serious regression to qualify. In other words, a respin has to be justified on its own merits, not simply because it fixes a regression. That it was a regression doesn't matter; what matters is the result of the bug. > Nobody is > forced to release a build with this, but anyone who runs > into this problem has a clear path to solve it. > > I would propose to include the Solaris build fix JDK-8280786 > in this patch, too. > > After all, tagging such a release in jdk11u is not much > effort. Both issues are fixed in 11.0.15/jdk11u-dev and can > easily be cherry-picked to jdk11u. > > I would hold back consolidating 11.0.15/jdk11u-dev to jdk11u > until this is done. Tag 11.0.15+1 is scheduled for tonight. OK. I'm in two minds about this one. One the one hand this is not a failure in core Java, but on the other I have heard about failures in production that it has caused, so I think it is severe enough to qualify. We might use this as an opportunity to review our processes. We backported a patch, but we didn't backport a subsequent patch which fixed it. We've seen this pattern several times: a desirable backport candidate appears, but it's not always obvious to the engineer doing the work that the patch is itself buggy, and needs its own backport. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From jdowland at openjdk.java.net Fri Feb 4 12:07:38 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 4 Feb 2022 12:07:38 GMT Subject: [jdk17u-dev] RFR: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also Message-ID: Good Morning This pull request contains a backport of commit [86d0abb6](https://github.com/openjdk/jdk/commit/86d0abb66bd2fe1edd15b81d351ea3b3c90fd256) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Fairoz Matte on 11 Jan 2022 and was reviewed by Nils Eliasson. This is a test-only change, for Oracle parity. The affected test passes for me on jdk17u-dev master before and afterwards. Thanks! ------------- Commit messages: - Backport 86d0abb66bd2fe1edd15b81d351ea3b3c90fd256 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/145/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=145&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279695 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/145.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/145/head:pull/145 PR: https://git.openjdk.java.net/jdk17u-dev/pull/145 From jdowland at openjdk.java.net Fri Feb 4 12:31:56 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 4 Feb 2022 12:31:56 GMT Subject: [jdk17u-dev] RFR: 8270117: Broken jtreg link in "Building the JDK" page Message-ID: Hi all, This pull request contains a backport of commit [41a5eb43](https://github.com/openjdk/jdk/commit/41a5eb437204a650d6cc271f41e1d186ee812a88) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Magnus Ihse Bursie on 12 Jul 2021 and was reviewed by Severin Gehwolf. It's a very minor doc fix but I tripped over the broken URI in jdk17u-dev just now (I'm getting back into backports work after a hiatus) so felt it was worthy of consideration. Thanks! ------------- Commit messages: - Backport 41a5eb437204a650d6cc271f41e1d186ee812a88 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/146/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=146&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270117 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/146.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/146/head:pull/146 PR: https://git.openjdk.java.net/jdk17u-dev/pull/146 From jdowland at openjdk.java.net Fri Feb 4 12:38:44 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 4 Feb 2022 12:38:44 GMT Subject: [jdk17u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() Message-ID: Hi This pull request contains a backport of commit [1e9ed54d](https://github.com/openjdk/jdk/commit/1e9ed54d362b8c57be5fbbac2de5afbd0f05435f) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Ravi Reddy on 1 Dec 2021 and was reviewed by Lance Andersen and Sean Coffey. This is a backport for Oracle parity. The patch introduces a new test for the bug. The test fails against jdk17u-dev master prior to the patch and passes afterwards. Thanks! ------------- Commit messages: - Backport 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f Changes: https://git.openjdk.java.net/jdk17u-dev/pull/147/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=147&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8193682 Stats: 258 lines in 4 files changed: 191 ins; 29 del; 38 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/147.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/147/head:pull/147 PR: https://git.openjdk.java.net/jdk17u-dev/pull/147 From vkempik at openjdk.java.net Fri Feb 4 14:01:35 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 4 Feb 2022 14:01:35 GMT Subject: [jdk11u-dev] RFR: 8264650: Cross-compilation to macos/aarch64 Message-ID: Clean backport, to be done in advance of jep-391 backport ------------- Commit messages: - Backport 7f9ece23dc62e911c78be3fa4b8e297e3ac90bd1 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/807/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=807&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264650 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/807.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/807/head:pull/807 PR: https://git.openjdk.java.net/jdk11u-dev/pull/807 From sgehwolf at openjdk.java.net Fri Feb 4 14:13:21 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 4 Feb 2022 14:13:21 GMT Subject: [jdk11u-dev] RFR: 8236210: javac generates wrong annotation for fields generated from record components [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 11:20:06 GMT, Goetz Lindenmaier wrote: > Maybe we should restrict us to only 11 for bootjdk at some point. That wouldn't be a good move as new bootstrapping work would need to first bootstrap some special version of JDK 11 (perhaps GA?) with JDK 10 and then do it again for the current version of JDK 11 with JDK 11 itself. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/771 From burban at openjdk.java.net Fri Feb 4 14:29:11 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Fri, 4 Feb 2022 14:29:11 GMT Subject: [jdk11u-dev] RFR: 8264650: Cross-compilation to macos/aarch64 In-Reply-To: References: Message-ID: On Fri, 4 Feb 2022 13:53:53 GMT, Vladimir Kempik wrote: > Clean backport, to be done in advance of jep-391 backport Marked as reviewed by burban (no project role). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/807 From burban at openjdk.java.net Fri Feb 4 14:31:30 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Fri, 4 Feb 2022 14:31:30 GMT Subject: [jdk17u-dev] RFR: 8279702: [macosx] ignore xcodebuild warnings on M1 In-Reply-To: <9FN5uihRn17su8acadvHBDHdFBFL5Hxz6D_T2Nguv1E=.0f1a35de-e73b-4536-bf85-6e40ff0938af@github.com> References: <9FN5uihRn17su8acadvHBDHdFBFL5Hxz6D_T2Nguv1E=.0f1a35de-e73b-4536-bf85-6e40ff0938af@github.com> Message-ID: On Mon, 31 Jan 2022 08:34:39 GMT, Bernhard Urban-Forster wrote: > Hi all, > > This pull request contains a backport of commit [4b520f00](https://github.com/openjdk/jdk/commit/4b520f0001be5f33996d5ab7d9ad75773a847e54) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > The commit being backported was authored by Johannes Bechberger on 14 Jan 2022 and was reviewed by Goetz Lindenmaier and Erik Joelsson. > > Thanks! Could someone sponsor this change please? /cc @RealClanger @GoeLin ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/131 From burban at openjdk.java.net Fri Feb 4 14:43:15 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Fri, 4 Feb 2022 14:43:15 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 20:19:10 GMT, Paul Hohensee wrote: > I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. > > Testing: tier1, including the new and existing sha tests. > > Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. > > 1. Copyright date conflicts. > 2. Context differences. > 3. Changing SHAOptionsBase to DigestOptionsBase. > 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. > > This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). Looks good to me, but I'm not an official reviewer. There was a proposal to backport it to 11u, but to the wrong mailing list: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-August/039412.html I think it has baked enough on tip now ?? /cc @luhenry ------------- Marked as reviewed by burban (no project role). PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From clanger at openjdk.java.net Fri Feb 4 14:49:19 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 4 Feb 2022 14:49:19 GMT Subject: [jdk17u-dev] RFR: 8279702: [macosx] ignore xcodebuild warnings on M1 In-Reply-To: <9FN5uihRn17su8acadvHBDHdFBFL5Hxz6D_T2Nguv1E=.0f1a35de-e73b-4536-bf85-6e40ff0938af@github.com> References: <9FN5uihRn17su8acadvHBDHdFBFL5Hxz6D_T2Nguv1E=.0f1a35de-e73b-4536-bf85-6e40ff0938af@github.com> Message-ID: On Mon, 31 Jan 2022 08:34:39 GMT, Bernhard Urban-Forster wrote: > Hi all, > > This pull request contains a backport of commit [4b520f00](https://github.com/openjdk/jdk/commit/4b520f0001be5f33996d5ab7d9ad75773a847e54) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > The commit being backported was authored by Johannes Bechberger on 14 Jan 2022 and was reviewed by Goetz Lindenmaier and Erik Joelsson. > > Thanks! Done. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/131 From burban at openjdk.java.net Fri Feb 4 14:49:19 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Fri, 4 Feb 2022 14:49:19 GMT Subject: [jdk17u-dev] Integrated: 8279702: [macosx] ignore xcodebuild warnings on M1 In-Reply-To: <9FN5uihRn17su8acadvHBDHdFBFL5Hxz6D_T2Nguv1E=.0f1a35de-e73b-4536-bf85-6e40ff0938af@github.com> References: <9FN5uihRn17su8acadvHBDHdFBFL5Hxz6D_T2Nguv1E=.0f1a35de-e73b-4536-bf85-6e40ff0938af@github.com> Message-ID: <_MHTY1YO_Kj_s6Cco868_WuMlhEOGSM2ec6xTQzTrrU=.2a941c29-f0a7-4d27-9a29-e74a9fdb2540@github.com> On Mon, 31 Jan 2022 08:34:39 GMT, Bernhard Urban-Forster wrote: > Hi all, > > This pull request contains a backport of commit [4b520f00](https://github.com/openjdk/jdk/commit/4b520f0001be5f33996d5ab7d9ad75773a847e54) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > The commit being backported was authored by Johannes Bechberger on 14 Jan 2022 and was reviewed by Goetz Lindenmaier and Erik Joelsson. > > Thanks! This pull request has now been integrated. Changeset: c36c1c22 Author: Bernhard Urban-Forster Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk17u-dev/commit/c36c1c2213f0ce92eed1dd3ed994d0309c4cc3d8 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8279702: [macosx] ignore xcodebuild warnings on M1 Backport-of: 4b520f0001be5f33996d5ab7d9ad75773a847e54 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/131 From sgehwolf at redhat.com Fri Feb 4 14:54:46 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Fri, 04 Feb 2022 15:54:46 +0100 Subject: Heads up: planned Harfbuzz update in jdk11u-dev In-Reply-To: References: <876bffc4-cb67-a92d-9be8-a8fcef1769e4@littlepinkcloud.com> Message-ID: <6f8f3b7be829565e23703572bddcbd8541202c59.camel@redhat.com> On Tue, 2022-01-25 at 14:02 +0000, Lindenmaier, Goetz wrote: > Hi Andrew Haley, Andrew Hughes, Matthias, Christoph, others... > > > While I take your point, I'll note that a Harfbuzz update doesn't seem > > to meet any of the criteria required for backports > > I think updates to libraries that are not developed in OpenJDK are > special.? We are OpenJDK experts, not harfbuzz / siphash / jline etc. > Tracking all changes to such components to identify needed > ones would be a considerable additional effort.? Andrew Hughes, thanks > for fixing 8279541! We missed those fixes because we left out [2] > in 11.0.11. It was the first time we left out such an update that > was done by Oracle. We did it because of the C++11 issue. > > Other points why I think we should try to update harfbuzz > ? * Updates fix errors > ? * Oracle did it, openJDK should not stay behind > ? * The default of the VM should be secure. > ??? > If people want a newer HarfBuzz, they can use --with-harfbuzz=system > ??? If someone needs something special the someone should > ??? go the hard way (use the system lib) > ? * Severe CVEs might appear in harfbuzz in the future. > ??? If we need to make an update on short notice, or coming > ??? with the embargoed changes, others do not have the necessary > ??? time to upgrade their compilers.? So better do it now with > ??? enough time. > ???????? > And yes, increasing the C++ version is a bad thing. But because of > the points above I think we should try to resolve all downstream > issues with C++11 and then update harfbuzz. > > > I have been wondering for some time about building > > Vanillas with a more recent > > version of GCC but still using the old libc for compatibility > > and maybe this is the time to put that idea into effect. > Andrew Haley, I appreciate this plan! FYI: We are able to use GCC 8 for the Vanilla JDK 11 builds. GCC 8 supports C++11. Builds are still RHEL 6/7 based as before. No objection for this harfbuzz update from our end. Thanks, Severin From vkempik at openjdk.java.net Fri Feb 4 15:03:11 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 4 Feb 2022 15:03:11 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v7] In-Reply-To: References: Message-ID: <9qqRd5a3wAuQsOcKtZe24OYD6NeZUvbfGJ_aE9AjcAw=.9edcd4c4-ca15-4f24-93ce-b74ce0e90b64@github.com> On Thu, 27 Jan 2022 23:12:11 GMT, Ahmed Muhsin wrote: >>> Is any of this reproducible on MacOS 12? >> >> The forkAndExec crash did not occur on MacOS 12. The NMT issues did, but the missing backport fixed the issue for all OS versions. > >> @ahmedmuhsin, could you possible try to replicate the issue with zulu11 ? >> https://www.azul.com/downloads/?version=java-11-lts&os=macos&architecture=arm-64-bit&package=jdk >> also, you test very old version of macos11.0.1 (Darwin 20.1.0) >> IIRC we saw very strange issues (not even java related) with first versions of macos_arm too, would it be possible for you to recheck with macos 11.4+ ? > > @VladimirKempik I'll give it a shot. > Thanks for the input everyone. @ahmedmuhsin were you able to test with a newer macos11 ? for example macos 11.1 IIRC we might have seen similar forkAndExec issues in pre-release versions of macos11 on DTKs, but nothing similar on macoses 11.1+ ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From neugens at redhat.com Fri Feb 4 15:09:25 2022 From: neugens at redhat.com (Mario Torre) Date: Fri, 4 Feb 2022 16:09:25 +0100 Subject: Heads up: planned Harfbuzz update in jdk11u-dev In-Reply-To: <6f8f3b7be829565e23703572bddcbd8541202c59.camel@redhat.com> References: <876bffc4-cb67-a92d-9be8-a8fcef1769e4@littlepinkcloud.com> <6f8f3b7be829565e23703572bddcbd8541202c59.camel@redhat.com> Message-ID: On Fri, Feb 4, 2022 at 3:55 PM Severin Gehwolf wrote: > > On Tue, 2022-01-25 at 14:02 +0000, Lindenmaier, Goetz wrote: > > Hi Andrew Haley, Andrew Hughes, Matthias, Christoph, others... > > > > > While I take your point, I'll note that a Harfbuzz update doesn't seem > > > to meet any of the criteria required for backports > > > > I think updates to libraries that are not developed in OpenJDK are > > special. We are OpenJDK experts, not harfbuzz / siphash / jline etc I can relate a bit, but I don't fully agree with this. The in tree libraries are still an essential component of OpenJDK, it bothers me to not be sure of what's in there. That of course goes both ways, to be able to update when we know there's a security issue or an important fix, and to be able to say that we don't want to update when we need to be more conservative. Cheers, Mario -- Mario Torre Manager, Software Engineering, core OpenJDK Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From luhenry at openjdk.java.net Fri Feb 4 15:20:07 2022 From: luhenry at openjdk.java.net (Ludovic Henry) Date: Fri, 4 Feb 2022 15:20:07 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 20:19:10 GMT, Paul Hohensee wrote: > I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. > > Testing: tier1, including the new and existing sha tests. > > Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. > > 1. Copyright date conflicts. > 2. Context differences. > 3. Changing SHAOptionsBase to DigestOptionsBase. > 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. > > This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). Marked as reviewed by luhenry (no project role). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From matthias.baesken at sap.com Fri Feb 4 15:31:08 2022 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Fri, 4 Feb 2022 15:31:08 +0000 Subject: Heads up: planned Harfbuzz update in jdk11u-dev In-Reply-To: <6f8f3b7be829565e23703572bddcbd8541202c59.camel@redhat.com> References: <876bffc4-cb67-a92d-9be8-a8fcef1769e4@littlepinkcloud.com> <6f8f3b7be829565e23703572bddcbd8541202c59.camel@redhat.com> Message-ID: Hi Severin, thanks for the update ! That's great news . Best regards, Matthias >FYI: We are able to use GCC 8 for the Vanilla JDK 11 builds. GCC 8 >supports C++11. Builds are still RHEL 6/7 based as before. > >No objection for this harfbuzz update from our end. From phh at openjdk.java.net Fri Feb 4 15:37:17 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 4 Feb 2022 15:37:17 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 20:19:10 GMT, Paul Hohensee wrote: > I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. > > Testing: tier1, including the new and existing sha tests. > > Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. > > 1. Copyright date conflicts. > 2. Context differences. > 3. Changing SHAOptionsBase to DigestOptionsBase. > 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. > > This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). Ludovic's the original author, which is as "official" as it gets. Thanks for the review, Ludovic! Thanks for the review, Bernhard! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From phh at openjdk.java.net Fri Feb 4 15:56:25 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 4 Feb 2022 15:56:25 GMT Subject: [jdk15u-dev] RFR: 8278381: [GCC 11] Address::make_raw() does not initialize rspec In-Reply-To: References: Message-ID: On Wed, 2 Feb 2022 22:06:08 GMT, Paul Hohensee wrote: > Trivial gcc 11 compatibility patch, applies cleanly. Approved. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/169 From phh at openjdk.java.net Fri Feb 4 15:56:26 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 4 Feb 2022 15:56:26 GMT Subject: [jdk15u-dev] Integrated: 8278381: [GCC 11] Address::make_raw() does not initialize rspec In-Reply-To: References: Message-ID: On Wed, 2 Feb 2022 22:06:08 GMT, Paul Hohensee wrote: > Trivial gcc 11 compatibility patch, applies cleanly. This pull request has now been integrated. Changeset: 7b8073a4 Author: Paul Hohensee URL: https://git.openjdk.java.net/jdk15u-dev/commit/7b8073a4f91457a82668123f625b7f853b26e42c Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8278381: [GCC 11] Address::make_raw() does not initialize rspec Backport-of: 4f594e6a28ad85d46d3252fb960f1c116f414899 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/169 From mbaesken at openjdk.java.net Fri Feb 4 16:30:27 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 4 Feb 2022 16:30:27 GMT Subject: [jdk17u-dev] Integrated: 8273387: remove some unreferenced gtk-related functions In-Reply-To: References: Message-ID: On Fri, 7 Jan 2022 11:18:25 GMT, Matthias Baesken wrote: > 8273387: remove some unreferenced gtk-related functions This pull request has now been integrated. Changeset: bda9cb44 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/bda9cb446994c05715922f7c9c8bb49311687f9c Stats: 68 lines in 2 files changed: 0 ins; 66 del; 2 mod 8273387: remove some unreferenced gtk-related functions Backport-of: 6eba443428ff7abe7c0509047ec76432affebe65 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/65 From duke at openjdk.java.net Sat Feb 5 08:22:20 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Sat, 5 Feb 2022 08:22:20 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v7] In-Reply-To: <9qqRd5a3wAuQsOcKtZe24OYD6NeZUvbfGJ_aE9AjcAw=.9edcd4c4-ca15-4f24-93ce-b74ce0e90b64@github.com> References: <9qqRd5a3wAuQsOcKtZe24OYD6NeZUvbfGJ_aE9AjcAw=.9edcd4c4-ca15-4f24-93ce-b74ce0e90b64@github.com> Message-ID: On Fri, 4 Feb 2022 15:00:20 GMT, Vladimir Kempik wrote: >>> @ahmedmuhsin, could you possible try to replicate the issue with zulu11 ? >>> https://www.azul.com/downloads/?version=java-11-lts&os=macos&architecture=arm-64-bit&package=jdk >>> also, you test very old version of macos11.0.1 (Darwin 20.1.0) >>> IIRC we saw very strange issues (not even java related) with first versions of macos_arm too, would it be possible for you to recheck with macos 11.4+ ? >> >> @VladimirKempik I'll give it a shot. >> Thanks for the input everyone. > > @ahmedmuhsin were you able to test with a newer macos11 ? for example macos 11.1 > > IIRC we might have seen similar forkAndExec issues in pre-release versions of macos11 on DTKs, but nothing similar on macoses 11.1+ @VladimirKempik, Apologies about the delay :) I have been busy with other tasks since my last post. Nevertheless, today I was able to focus on testing the issue based on your suggestions. I tested both my build of this branch and the zulu11 build on MacOS versions `11.0`, `11.2.1`, `11.5.2`, and `11.6.2`. Here are my results: | OS Version | My Build | Zulu11 | | :--- | :----: | ---: | | 11.0 | Crash | No Crash | | 11.2.1 | Crash | No Crash | | 11.5.2 | No Crash | No Crash | | 11.6.2 | No Crash | No Crash | ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From vkempik at openjdk.java.net Sat Feb 5 12:25:17 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Sat, 5 Feb 2022 12:25:17 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v7] In-Reply-To: References: Message-ID: On Thu, 20 Jan 2022 15:43:46 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Ignore TestOnError.java on macos_aarch64 Great, thanks, I have access to some 11.1 host and will try to replicate the issue there. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From vkempik at openjdk.java.net Sat Feb 5 13:10:12 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Sat, 5 Feb 2022 13:10:12 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v7] In-Reply-To: References: Message-ID: On Thu, 20 Jan 2022 15:43:46 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Ignore TestOnError.java on macos_aarch64 Crashlog with hsdis - https://pastebin.com/5kz2vfEH SIGBUS (0xa) at pc=0x000000012100bbfc, pid=76024, tid=39683 siginfo: si_signo: 10 (SIGBUS), si_code: 1 (BUS_ADRALN), si_addr: 0x000000012100bbfc #128 0x000000012100bbc0: movk x8, #0x2100, lsl #16 0x000000012100bbc4: movk x8, #0x1, lsl #32 0x000000012100bbc8: br x8 0x000000012100bbcc: ldp x22, x24, [x29, #-72] 0x000000012100bbd0: ldur x12, [x29, #-24] 0x000000012100bbd4: ldr x10, [x12, #80] 0x000000012100bbd8: add x0, x28, #0x350 0x000000012100bbdc: adr x8, 0x000000012100bbfc 0x000000012100bbe0: str x8, [x28, #824] 0x000000012100bbe4: str x20, [x28, #816] 0x000000012100bbe8: str x29, [x28, #832] 0x000000012100bbec: orr x8, xzr, #0x4 0x000000012100bbf0: add x9, x28, #0x3c8 0x000000012100bbf4: stlr w8, [x9] 0x000000012100bbf8: blr x10 **0x000000012100bbfc: isb** 0x000000012100bc00: ldur x12, [x29, #-24] 0x000000012100bc04: sub x8, x20, #0x20 0x000000012100bc08: and sp, x8, #0xfffffffffffffff0 0x000000012100bc0c: str d0, [x20, #-16]! 0x000000012100bc10: str xzr, [x20, #-8]! 0x000000012100bc14: str x0, [x20, #-8]! 0x000000012100bc18: mov x8, #0x5 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From vkempik at openjdk.java.net Sat Feb 5 15:30:59 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Sat, 5 Feb 2022 15:30:59 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8] In-Reply-To: References: Message-ID: > Initial version of JEP-391 backport to jdk11u. > Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. > Things needing attention: os_bsd_aarch64.cpp and W^X transitions. > serviceability agent is mostly clean. > This passed GHA_tier1 testing. > Full regression testing is running now on Azul's infra, will report/update PR when done. > **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** > Sharing this PR slightly earlier to let other interested parties to run the tests too. > Example of cross-building on intel mac (needs Xcode12/13): > sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: Add two missing WX transitions ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/715/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/715/files/e48a9f83..787ccf85 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=715&range=07 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=715&range=06-07 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/715.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/715/head:pull/715 PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From vkempik at openjdk.java.net Sat Feb 5 15:35:09 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Sat, 5 Feb 2022 15:35:09 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v7] In-Reply-To: References: Message-ID: <9ITN7VPni76jyAaY9xkWX600C1r2-y4DCFp2JRcpPM8=.80216f96-2c01-4b3c-8125-79ba6b617091@github.com> On Thu, 20 Jan 2022 15:43:46 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Ignore TestOnError.java on macos_aarch64 Looks like it was two missing WX transitions in JNI_QUICK_ENTRY and JVM_QUICK_ENTRY These transitions are present in zulu11 JNI_QUICK_ENTRY and JVM_QUICK_ENTRY macros are missing in jdk17/upstream. That explains everything, except the macos version reproducibility. @ahmedmuhsin, when you will have a time, please check the updated PR on macos 11.0.1 or 11.2.1, for me it doesn't crash anymore ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From goetz.lindenmaier at sap.com Mon Feb 7 08:49:17 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 7 Feb 2022 08:49:17 +0000 Subject: [11u] Should we make patch 11.0.14.1 with JDK-8218546 and JDK-8280786? In-Reply-To: References: Message-ID: Hi Andrew, > I think it is severe enough to qualify. Thank you, I take this for a yes. So I will take the following steps: I will tag the current state of jdk11u as jdk-11.0.14.1+0. I will open an issue "Bump update version for OpenJDK: jdk-11.0.14.1" similar to JDK-8272902 and add the date 2/8/2022. I will backport JDK-8218546 and JDK-8280786 from jdk11u-dev to jdk11u. I will tag all three changes with jdk11.0.14.1+1 and jdk11.0.14.1-ga. Best regards, Goetz. https://bugs.openjdk.java.net/browse/JDK-8272902: Bump update version for OpenJDK: jdk-11.0.14 https://bugs.openjdk.java.net/browse/JDK-8218546: Unable to connect to https://google.com using java.net.HttpClient https://bugs.openjdk.java.net/browse/JDK-8280786: Build failure on Solaris after 8262392 > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Andrew Haley > Sent: Friday, February 4, 2022 11:19 AM > To: jdk-updates-dev at openjdk.java.net > Subject: Re: [11u] Should we make patch 11.0.14.1 with JDK-8218546 and > JDK-8280786? > > On 2/1/22 11:17, Lindenmaier, Goetz wrote: > > we (SAP) checked with our internal stakeholders and decided to > > release a patch for SapMachine 11.0.14 with JDK-8218546. > > > > We would prefer to have an "official" patch 11.0.14.1 in > > OpenJDK jdk11u including this change. Alternatively, we could > > also release a patch 11.0.14.0.1 only for SapMachine. > > > > I think JDK-8218546 is a clear regression in 11.0.14 and > > thus jdk11u should tag a release that fixes this. > > This reasoning does not necessarily follow: a regression in a point > release does not always justify a respin. It must be a serious > regression to qualify. > > In other words, a respin has to be justified on its own merits, not > simply because it fixes a regression. That it was a regression > doesn't matter; what matters is the result of the bug. > > > Nobody is > > forced to release a build with this, but anyone who runs > > into this problem has a clear path to solve it. > > > > I would propose to include the Solaris build fix JDK-8280786 > > in this patch, too. > > > > After all, tagging such a release in jdk11u is not much > > effort. Both issues are fixed in 11.0.15/jdk11u-dev and can > > easily be cherry-picked to jdk11u. > > > > I would hold back consolidating 11.0.15/jdk11u-dev to jdk11u > > until this is done. Tag 11.0.15+1 is scheduled for tonight. > > OK. I'm in two minds about this one. One the one hand this is not a > failure in core Java, but on the other I have heard about failures in > production that it has caused, so I think it is severe enough to > qualify. > > We might use this as an opportunity to review our processes. We > backported a patch, but we didn't backport a subsequent patch > which fixed it. We've seen this pattern several times: a desirable > backport candidate appears, but it's not always obvious to the > engineer doing the work that the patch is itself buggy, and needs > its own backport. > > -- > Andrew Haley (he/him) > Java Platform Lead Engineer > Red Hat UK Ltd. > w.redhat.com%2F&data=04%7C01%7Cgoetz.lindenmaier%40sap.com% > 7Cc5ce70b90dda49592c5d08d9e7c7d784%7C42f7676cf455423c82f6dc2d99791 > af7%7C0%7C0%7C637795667803062024%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > 7C3000&sdata=IVM8C3gdGKxvCJSBo7uwpdFdA%2FhkVfs%2FUVgrwaP > oHAQ%3D&reserved=0> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeyb > ase.io%2Fandrewhaley&data=04%7C01%7Cgoetz.lindenmaier%40sap.c > om%7Cc5ce70b90dda49592c5d08d9e7c7d784%7C42f7676cf455423c82f6dc2d9 > 9791af7%7C0%7C0%7C637795667803062024%7CUnknown%7CTWFpbGZsb3d > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > 3D%7C3000&sdata=lv1yCc4GOTmz0D5pZMxT%2FxthQpofl%2FW8C3twq > U%2BVqRs%3D&reserved=0 > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From goetz at openjdk.java.net Mon Feb 7 09:29:36 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 09:29:36 GMT Subject: [jdk11u] RFR: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 Message-ID: Necessary version bump ------------- Commit messages: - 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 Changes: https://git.openjdk.java.net/jdk11u/pull/25/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=25&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281324 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/25/head:pull/25 PR: https://git.openjdk.java.net/jdk11u/pull/25 From sgehwolf at openjdk.java.net Mon Feb 7 10:24:15 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 7 Feb 2022 10:24:15 GMT Subject: [jdk11u] RFR: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 09:24:25 GMT, Goetz Lindenmaier wrote: > Necessary version bump Marked as reviewed by sgehwolf (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u/pull/25 From simonis at openjdk.java.net Mon Feb 7 10:28:16 2022 From: simonis at openjdk.java.net (Volker Simonis) Date: Mon, 7 Feb 2022 10:28:16 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 20:19:10 GMT, Paul Hohensee wrote: > I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. > > Testing: tier1, including the new and existing sha tests. > > Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. > > 1. Copyright date conflicts. > 2. Context differences. > 3. Changing SHAOptionsBase to DigestOptionsBase. > 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. > > This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). Hi Paul, thanks for doing this downport. The changes look good except for one comment in `CheckGraalIntrinsics.java` Best regards, Volker src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java line 393: > 391: } > 392: > 393: if (isJDK16OrHigher()) { If we downport the MD5 intrinsic to JDK11, shouldn't this be changed to `isJDK11OrHigher()`? src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java line 556: > 554: return JavaVersionUtil.JAVA_SPEC >= 16; > 555: } > 556: I don't think we need these checks here at all because the GraalVM in the JDK11 repository will probably never support JDK15 or 16. ------------- Changes requested by simonis (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From goetz at openjdk.java.net Mon Feb 7 10:58:40 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 10:58:40 GMT Subject: [jdk11u] RFR: 8280786: Build failure on Solaris after 8262392 Message-ID: <0rVKRRS3e_D55Dzp25cKK3_vc1YRI-10KT8IVoQNbfc=.db6ebc10-2d70-4704-b660-02a2f26b3b13@github.com> See See http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/011862.html ------------- Commit messages: - Backport 6837e1484bbeda710cde3763f0b0edb9c02351c2 Changes: https://git.openjdk.java.net/jdk11u/pull/27/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=27&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280786 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u/pull/27.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/27/head:pull/27 PR: https://git.openjdk.java.net/jdk11u/pull/27 From goetz at openjdk.java.net Mon Feb 7 10:59:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 10:59:46 GMT Subject: [jdk11u] RFR: 8218546: Unable to connect to https://google.com using java.net.HttpClient Message-ID: See http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/011862.html ------------- Commit messages: - Backport b240c60427e693c4e8afc34fc52b2f9f70584537 Changes: https://git.openjdk.java.net/jdk11u/pull/26/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=26&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8218546 Stats: 72 lines in 2 files changed: 44 ins; 9 del; 19 mod Patch: https://git.openjdk.java.net/jdk11u/pull/26.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/26/head:pull/26 PR: https://git.openjdk.java.net/jdk11u/pull/26 From phh at openjdk.java.net Mon Feb 7 12:50:45 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 7 Feb 2022 12:50:45 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 [v2] In-Reply-To: References: Message-ID: > I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. > > Testing: tier1, including the new and existing sha tests. > > Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. > > 1. Copyright date conflicts. > 2. Context differences. > 3. Changing SHAOptionsBase to DigestOptionsBase. > 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. > > This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - 8250902: Implement MD5 Intrinsics on x86 - Merge branch 'master' into backport-339016a0 - 8250902: Implement MD5 Intrinsics on x86 - Backport 339016a0f2cbbbbc3560e50c6726e14afbf547f6 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/806/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/806/files/9fd44b55..d033727c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=806&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=806&range=00-01 Stats: 100 lines in 3 files changed: 85 ins; 12 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/806.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/806/head:pull/806 PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From phh at openjdk.java.net Mon Feb 7 13:00:12 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 7 Feb 2022 13:00:12 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 [v2] In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 12:50:45 GMT, Paul Hohensee wrote: >> I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. >> >> Testing: tier1, including the new and existing sha tests. >> >> Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. >> >> 1. Copyright date conflicts. >> 2. Context differences. >> 3. Changing SHAOptionsBase to DigestOptionsBase. >> 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. >> >> This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). > > Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8250902: Implement MD5 Intrinsics on x86 > - Merge branch 'master' into backport-339016a0 > - 8250902: Implement MD5 Intrinsics on x86 > - Backport 339016a0f2cbbbbc3560e50c6726e14afbf547f6 Fixed, see incremental webrev. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From clanger at openjdk.java.net Mon Feb 7 13:13:02 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 7 Feb 2022 13:13:02 GMT Subject: [jdk11u] RFR: 8218546: Unable to connect to https://google.com using java.net.HttpClient In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 10:49:00 GMT, Goetz Lindenmaier wrote: > See http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/011862.html Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u/pull/26 From clanger at openjdk.java.net Mon Feb 7 13:14:08 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 7 Feb 2022 13:14:08 GMT Subject: [jdk11u] RFR: 8280786: Build failure on Solaris after 8262392 In-Reply-To: <0rVKRRS3e_D55Dzp25cKK3_vc1YRI-10KT8IVoQNbfc=.db6ebc10-2d70-4704-b660-02a2f26b3b13@github.com> References: <0rVKRRS3e_D55Dzp25cKK3_vc1YRI-10KT8IVoQNbfc=.db6ebc10-2d70-4704-b660-02a2f26b3b13@github.com> Message-ID: On Mon, 7 Feb 2022 10:49:34 GMT, Goetz Lindenmaier wrote: > See See http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/011862.html Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u/pull/27 From simonis at openjdk.java.net Mon Feb 7 13:25:12 2022 From: simonis at openjdk.java.net (Volker Simonis) Date: Mon, 7 Feb 2022 13:25:12 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 [v2] In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 12:50:45 GMT, Paul Hohensee wrote: >> I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. >> >> Testing: tier1, including the new and existing sha tests. >> >> Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. >> >> 1. Copyright date conflicts. >> 2. Context differences. >> 3. Changing SHAOptionsBase to DigestOptionsBase. >> 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. >> >> This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). > > Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8250902: Implement MD5 Intrinsics on x86 > - Merge branch 'master' into backport-339016a0 > - 8250902: Implement MD5 Intrinsics on x86 > - Backport 339016a0f2cbbbbc3560e50c6726e14afbf547f6 Thanks, looks good now. ------------- Marked as reviewed by simonis (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From clanger at openjdk.java.net Mon Feb 7 13:14:17 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 7 Feb 2022 13:14:17 GMT Subject: [jdk11u] RFR: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 09:24:25 GMT, Goetz Lindenmaier wrote: > Necessary version bump Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u/pull/25 From clanger at openjdk.java.net Mon Feb 7 14:01:00 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 7 Feb 2022 14:01:00 GMT Subject: [jdk11u] RFR: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 09:24:25 GMT, Goetz Lindenmaier wrote: > Necessary version bump Seems like GHA does not like the new versioning but we can live with it, I guess... ------------- PR: https://git.openjdk.java.net/jdk11u/pull/25 From phh at openjdk.java.net Mon Feb 7 14:16:17 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 7 Feb 2022 14:16:17 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 [v2] In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 12:50:45 GMT, Paul Hohensee wrote: >> I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. >> >> Testing: tier1, including the new and existing sha tests. >> >> Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. >> >> 1. Copyright date conflicts. >> 2. Context differences. >> 3. Changing SHAOptionsBase to DigestOptionsBase. >> 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. >> >> This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). > > Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8250902: Implement MD5 Intrinsics on x86 > - Merge branch 'master' into backport-339016a0 > - 8250902: Implement MD5 Intrinsics on x86 > - Backport 339016a0f2cbbbbc3560e50c6726e14afbf547f6 Thanks, Volker. Tagged. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From coffeys at openjdk.java.net Mon Feb 7 14:41:35 2022 From: coffeys at openjdk.java.net (Sean Coffey) Date: Mon, 7 Feb 2022 14:41:35 GMT Subject: [jdk18u] Integrated: 8278851: Correct signer logic for jars signed with multiple digestalgs In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 14:40:26 GMT, Sean Coffey wrote: > Clean port to jdk18u. Awaiting 18u integration approval. This pull request has now been integrated. Changeset: fbc28a70 Author: Sean Coffey URL: https://git.openjdk.java.net/jdk18u/commit/fbc28a7047dd99544ccb14c0f8e5775160537641 Stats: 264 lines in 3 files changed: 214 ins; 20 del; 30 mod 8278851: Correct signer logic for jars signed with multiple digestalgs Backport-of: 61b8944327e3d12cf58dc3f6bc45ecbeba4ef611 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/19 From goetz at openjdk.java.net Mon Feb 7 15:12:57 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 15:12:57 GMT Subject: [jdk11u] RFR: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 [v2] In-Reply-To: References: Message-ID: > Necessary version bump Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Update version in jcheck/conf ------------- Changes: - all: https://git.openjdk.java.net/jdk11u/pull/25/files - new: https://git.openjdk.java.net/jdk11u/pull/25/files/594a27e1..690f4358 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=25&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=25&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/25/head:pull/25 PR: https://git.openjdk.java.net/jdk11u/pull/25 From goetz at openjdk.java.net Mon Feb 7 15:14:31 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 15:14:31 GMT Subject: [jdk11u] RFR: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 09:24:25 GMT, Goetz Lindenmaier wrote: > Necessary version bump 11.0.14.1 was created in JBS (thanks Kevin!), so I also changed .jcheck/conf version now. ------------- PR: https://git.openjdk.java.net/jdk11u/pull/25 From clanger at openjdk.java.net Mon Feb 7 15:26:04 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 7 Feb 2022 15:26:04 GMT Subject: [jdk11u] RFR: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 [v2] In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 15:12:57 GMT, Goetz Lindenmaier wrote: >> Necessary version bump > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Update version in jcheck/conf Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u/pull/25 From goetz at openjdk.java.net Mon Feb 7 15:31:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 15:31:15 GMT Subject: [jdk11u] RFR: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 [v2] In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 15:12:57 GMT, Goetz Lindenmaier wrote: >> Necessary version bump > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Update version in jcheck/conf Severin, Christoph, thanks for the reviews! ------------- PR: https://git.openjdk.java.net/jdk11u/pull/25 From goetz at openjdk.java.net Mon Feb 7 15:31:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 15:31:15 GMT Subject: [jdk11u] Integrated: 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 09:24:25 GMT, Goetz Lindenmaier wrote: > Necessary version bump This pull request has now been integrated. Changeset: 8359d7fe Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/8359d7fe09639407c18d6e4d41a32547856566e1 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 Reviewed-by: sgehwolf, clanger ------------- PR: https://git.openjdk.java.net/jdk11u/pull/25 From phh at openjdk.java.net Mon Feb 7 15:40:32 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 7 Feb 2022 15:40:32 GMT Subject: [jdk15u-dev] RFR: 8281374: Add MD5.implCompress0 to Graal toBeInvestigated list after 8280978 Message-ID: Patch to fix [JDK-8280978](https://bugs.openjdk.java.net/browse/JDK-8280978), the 15u backport of [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902). Add MD5.implCompress0 to Graal toBeInvestigated list for JDK 15 and above rather than JDK 16 and above. ------------- Commit messages: - 8281374: Add MD5.implCompress0 to Graal toBeInvestigated list after 8280978 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/171/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=171&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281374 Stats: 5 lines in 1 file changed: 0 ins; 4 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/171.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/171/head:pull/171 PR: https://git.openjdk.java.net/jdk15u-dev/pull/171 From simonis at openjdk.java.net Mon Feb 7 15:44:25 2022 From: simonis at openjdk.java.net (Volker Simonis) Date: Mon, 7 Feb 2022 15:44:25 GMT Subject: [jdk15u-dev] RFR: 8281374: Add MD5.implCompress0 to Graal toBeInvestigated list after 8280978 In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 15:33:03 GMT, Paul Hohensee wrote: > Patch to fix [JDK-8280978](https://bugs.openjdk.java.net/browse/JDK-8280978), the 15u backport of [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902). Add MD5.implCompress0 to Graal toBeInvestigated list for JDK 15 and above rather than JDK 16 and above. Looks good to me. ------------- Marked as reviewed by simonis (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/171 From phh at openjdk.java.net Mon Feb 7 16:06:19 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 7 Feb 2022 16:06:19 GMT Subject: [jdk15u-dev] RFR: 8281374: Add MD5.implCompress0 to Graal toBeInvestigated list after 8280978 In-Reply-To: References: Message-ID: <2ccdaLgOAW-wFiTtwEQbWu5eWPyvLzTCavtHreBy4tE=.472a3b9e-8d2c-4596-9a52-0808e2eb5890@github.com> On Mon, 7 Feb 2022 15:33:03 GMT, Paul Hohensee wrote: > Patch to fix [JDK-8280978](https://bugs.openjdk.java.net/browse/JDK-8280978), the 15u backport of [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902). Add MD5.implCompress0 to Graal toBeInvestigated list for JDK 15 and above rather than JDK 16 and above. Thanks, Volker. Tagged. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/171 From goetz at openjdk.java.net Mon Feb 7 16:19:09 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 16:19:09 GMT Subject: [jdk11u] Integrated: 8218546: Unable to connect to https://google.com using java.net.HttpClient In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 10:49:00 GMT, Goetz Lindenmaier wrote: > See http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/011862.html This pull request has now been integrated. Changeset: ef5fff53 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/ef5fff53ef1b047c2fca47047fe743689cc2734f Stats: 72 lines in 2 files changed: 44 ins; 9 del; 19 mod 8218546: Unable to connect to https://google.com using java.net.HttpClient Reviewed-by: clanger Backport-of: b240c60427e693c4e8afc34fc52b2f9f70584537 ------------- PR: https://git.openjdk.java.net/jdk11u/pull/26 From goetz at openjdk.java.net Mon Feb 7 16:30:09 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 16:30:09 GMT Subject: [jdk11u] Integrated: 8280786: Build failure on Solaris after 8262392 In-Reply-To: <0rVKRRS3e_D55Dzp25cKK3_vc1YRI-10KT8IVoQNbfc=.db6ebc10-2d70-4704-b660-02a2f26b3b13@github.com> References: <0rVKRRS3e_D55Dzp25cKK3_vc1YRI-10KT8IVoQNbfc=.db6ebc10-2d70-4704-b660-02a2f26b3b13@github.com> Message-ID: On Mon, 7 Feb 2022 10:49:34 GMT, Goetz Lindenmaier wrote: > See See http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/011862.html This pull request has now been integrated. Changeset: b8cdf1ae Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/b8cdf1ae18bb8301e289b827751a2e0aa9f3f50b Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8280786: Build failure on Solaris after 8262392 Reviewed-by: clanger Backport-of: 6837e1484bbeda710cde3763f0b0edb9c02351c2 ------------- PR: https://git.openjdk.java.net/jdk11u/pull/27 From goetz at openjdk.java.net Mon Feb 7 16:30:09 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Feb 2022 16:30:09 GMT Subject: [jdk11u] RFR: 8280786: Build failure on Solaris after 8262392 In-Reply-To: <0rVKRRS3e_D55Dzp25cKK3_vc1YRI-10KT8IVoQNbfc=.db6ebc10-2d70-4704-b660-02a2f26b3b13@github.com> References: <0rVKRRS3e_D55Dzp25cKK3_vc1YRI-10KT8IVoQNbfc=.db6ebc10-2d70-4704-b660-02a2f26b3b13@github.com> Message-ID: On Mon, 7 Feb 2022 10:49:34 GMT, Goetz Lindenmaier wrote: > See See http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/011862.html Pre-submit test failure: gc/metaspace/TestMetaspacePerfCounters.java#id1, this test keeps failing in the Pre-submit tests; unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u/pull/27 From zgu at openjdk.java.net Mon Feb 7 19:10:14 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 7 Feb 2022 19:10:14 GMT Subject: [jdk17u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: Message-ID: On Fri, 4 Feb 2022 12:28:57 GMT, Jonathan Dowland wrote: > Hi > > This pull request contains a backport of commit [1e9ed54d](https://github.com/openjdk/jdk/commit/1e9ed54d362b8c57be5fbbac2de5afbd0f05435f) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Ravi Reddy on 1 Dec 2021 and was reviewed by Lance Andersen and Sean Coffey. > > This is a backport for Oracle parity. The patch introduces a new test for the bug. The test fails against jdk17u-dev master prior to the patch and passes afterwards. > > Thanks! @jmtd This is a clean backport, you don't need code review. Please tag the bug for approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/147 From robm at openjdk.java.net Mon Feb 7 19:54:59 2022 From: robm at openjdk.java.net (Rob McKenna) Date: Mon, 7 Feb 2022 19:54:59 GMT Subject: [jdk18u] RFR: 8277795: ldap connection timeout not honoured under contention Message-ID: <8h01fZMUla_eubewHh4224yksePRbbg87rhbBT3SPy0=.062c2edb-8cb0-47e8-b80a-cfc50cb13c36@github.com> 8277795: ldap connection timeout not honoured under contention ------------- Commit messages: - Backport 3d926dd66ef6551e91a4ebbbc59dcff58f5ede5a Changes: https://git.openjdk.java.net/jdk18u/pull/20/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=20&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277795 Stats: 467 lines in 5 files changed: 324 ins; 72 del; 71 mod Patch: https://git.openjdk.java.net/jdk18u/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk18u/pull/20 From robm at openjdk.java.net Mon Feb 7 20:10:26 2022 From: robm at openjdk.java.net (Rob McKenna) Date: Mon, 7 Feb 2022 20:10:26 GMT Subject: [jdk18u] Integrated: 8277795: ldap connection timeout not honoured under contention In-Reply-To: <8h01fZMUla_eubewHh4224yksePRbbg87rhbBT3SPy0=.062c2edb-8cb0-47e8-b80a-cfc50cb13c36@github.com> References: <8h01fZMUla_eubewHh4224yksePRbbg87rhbBT3SPy0=.062c2edb-8cb0-47e8-b80a-cfc50cb13c36@github.com> Message-ID: On Mon, 7 Feb 2022 19:47:41 GMT, Rob McKenna wrote: > 8277795: ldap connection timeout not honoured under contention This pull request has now been integrated. Changeset: f1c76946 Author: Rob McKenna URL: https://git.openjdk.java.net/jdk18u/commit/f1c769462d678ed135b37fa2840ae3a5d53eab80 Stats: 467 lines in 5 files changed: 324 ins; 72 del; 71 mod 8277795: ldap connection timeout not honoured under contention Backport-of: 3d926dd66ef6551e91a4ebbbc59dcff58f5ede5a ------------- PR: https://git.openjdk.java.net/jdk18u/pull/20 From jdowland at openjdk.java.net Mon Feb 7 22:09:14 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Mon, 7 Feb 2022 22:09:14 GMT Subject: [jdk17u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: Message-ID: <4DpUi5DwcXjmaSojcPrnurkMU4kNYmZZujoAnzHcAAc=.b57f88b4-be53-4f82-8347-23168fea88e6@github.com> On Mon, 7 Feb 2022 19:06:51 GMT, Zhengyu Gu wrote: >> Hi >> >> This pull request contains a backport of commit [1e9ed54d](https://github.com/openjdk/jdk/commit/1e9ed54d362b8c57be5fbbac2de5afbd0f05435f) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. >> >> The commit being backported was authored by Ravi Reddy on 1 Dec 2021 and was reviewed by Lance Andersen and Sean Coffey. >> >> This is a backport for Oracle parity. The patch introduces a new test for the bug. The test fails against jdk17u-dev master prior to the patch and passes afterwards. >> >> Thanks! > > @jmtd This is a clean backport, you don't need code review. Please tag the bug for approval. @zhengyu123 thank you for your reply! I meant to get back to this one today. It is clean, but the original bug needed a CSR, so I believe I need to raise a CSR for the backport too. I just didn't get around to looking into that yet. Am I right? ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/147 From duke at openjdk.java.net Mon Feb 7 22:56:12 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Mon, 7 Feb 2022 22:56:12 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v7] In-Reply-To: <9ITN7VPni76jyAaY9xkWX600C1r2-y4DCFp2JRcpPM8=.80216f96-2c01-4b3c-8125-79ba6b617091@github.com> References: <9ITN7VPni76jyAaY9xkWX600C1r2-y4DCFp2JRcpPM8=.80216f96-2c01-4b3c-8125-79ba6b617091@github.com> Message-ID: On Sat, 5 Feb 2022 15:30:10 GMT, Vladimir Kempik wrote: >> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: >> >> Ignore TestOnError.java on macos_aarch64 > > Looks like it was two missing WX transitions in JNI_QUICK_ENTRY and JVM_QUICK_ENTRY > These transitions are present in zulu11 > JNI_QUICK_ENTRY and JVM_QUICK_ENTRY macros are missing in jdk17/upstream. > > That explains everything, except the macos version reproducibility, which is probably due to the difference in library calls leaving different w^x state up on exit. > > @ahmedmuhsin, when you will have a time, please check the updated PR on macos 11.0.1 or 11.2.1, for me it doesn't crash anymore @VladimirKempik I tested again on all the OS versions that I mentioned above and everything looks very good. No crashes. Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From vkempik at openjdk.java.net Tue Feb 8 06:51:11 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 8 Feb 2022 06:51:11 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8] In-Reply-To: References: Message-ID: <3BIxpBz5rFyKw1y_GUvJvePsPU-n3NBqiDRQVByotYM=.787d2cd6-3fe6-48cc-9a13-b9be6cb48cb1@github.com> On Sat, 5 Feb 2022 15:30:59 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Add two missing WX transitions @rnkovacs , parts of your jep-388 backport ( https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1495, https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1558, https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1671 ) results in more warning for this PR: ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From stuefe at openjdk.java.net Tue Feb 8 07:13:49 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 8 Feb 2022 07:13:49 GMT Subject: [jdk17u] RFR: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests Message-ID: <-VqDm9pdNsO6xWJmhRdDLqnJjhWdP5pDLwykobh84Wo=.3b0b52f2-061e-4626-8c00-257758436e25@github.com> Hi all, I'd like to backport this little enhancement to cut down on testing time in jdk17u. The fix is low risk and has been in jdk18+ since last September. Fix applies cleanly. The commit being backported was authored by Thomas Stuefe on 4 Aug 2021 and was reviewed by Thomas Schatzl and Richard Reingruber. Thanks! ------------- Commit messages: - Backport 66c653c561b3b5e904579af62e23ff94952bca05 Changes: https://git.openjdk.java.net/jdk17u/pull/332/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=332&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271721 Stats: 35 lines in 1 file changed: 23 ins; 5 del; 7 mod Patch: https://git.openjdk.java.net/jdk17u/pull/332.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/332/head:pull/332 PR: https://git.openjdk.java.net/jdk17u/pull/332 From stuefe at openjdk.java.net Tue Feb 8 07:19:27 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 8 Feb 2022 07:19:27 GMT Subject: [jdk17u] RFR: 8277383: VM.metaspace optionally show chunk freelist details Message-ID: <25g9vykTSEDr0Py2Pgwo_4RxVSveo-S21Cvm_c9ZzTU=.872a5a47-a204-41e3-a5ca-f1db6c1b66e9@github.com> I'd like to backport this to jdk17 since it adds a useful option for metaspace analysis. Fix is low risk and applies cleanly. The commit being backported was authored by Thomas Stuefe on 7 Dec 2021 and was reviewed by Coleen Phillimore and Aleksey Shipilev. ------------- Commit messages: - Backport 35361270cb3aae9fa560736f8d05f1b258704c87 Changes: https://git.openjdk.java.net/jdk17u/pull/333/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=333&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277383 Stats: 48 lines in 5 files changed: 47 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/333.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/333/head:pull/333 PR: https://git.openjdk.java.net/jdk17u/pull/333 From goetz at openjdk.java.net Tue Feb 8 07:35:16 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Feb 2022 07:35:16 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master Message-ID: <3PQ4yUv7XV7kd9spPk9ESaaJxr1xI243G9HxKODNqn8=.f509467f-4c05-4853-af3e-e6d8c48c9612@github.com> Merge build tag 11.0.14.1-ga from jdk11u to jdk11u-dev. ------------- Commit messages: - Merge - 8256321: Some "inactive" color profiles use the wrong profile class - 8280999: array_bounds should be array-bounds after 8278507 - 8177814: jdk/editpad is not in jdk TEST.groups - 8279702: [macosx] ignore xcodebuild warnings on M1 - 8280786: Build failure on Solaris after 8262392 - 8218546: Unable to connect to https://google.com using java.net.HttpClient - 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134 - 8279833: Loop optimization issue in String.encodeUTF8_UTF16 - 8273277: C2: Move conditional negation into rc_predicate - ... and 111 more: https://git.openjdk.java.net/jdk11u-dev/compare/b8cdf1ae...abfa5c9a The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u-dev/pull/808/files Stats: 11112 lines in 667 files changed: 5538 ins; 1706 del; 3868 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/808.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/808/head:pull/808 PR: https://git.openjdk.java.net/jdk11u-dev/pull/808 From goetz at openjdk.java.net Tue Feb 8 07:35:17 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Feb 2022 07:35:17 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: <3PQ4yUv7XV7kd9spPk9ESaaJxr1xI243G9HxKODNqn8=.f509467f-4c05-4853-af3e-e6d8c48c9612@github.com> References: <3PQ4yUv7XV7kd9spPk9ESaaJxr1xI243G9HxKODNqn8=.f509467f-4c05-4853-af3e-e6d8c48c9612@github.com> Message-ID: <1h8jG6UqpVxy0PEK7eWX4_OiPvq0lv-N5Wu7CRzkKoU=.28c86de1-6766-41eb-9d51-1f4e39d1414b@github.com> On Tue, 8 Feb 2022 07:29:10 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.14.1-ga from jdk11u to jdk11u-dev. This pull request has now been integrated. Changeset: 562e4feb Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/562e4febbec6319f511f8ea098258ae3c28c4c42 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/808 From goetz at openjdk.java.net Tue Feb 8 07:58:27 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Feb 2022 07:58:27 GMT Subject: [jdk11u-dev] RFR: 8216969: ParseException thrown for certain months with russian locale Message-ID: I think this is a useful, safe fix for 11. ------------- Commit messages: - Backport 0623444ae5a0bbf143c288c7ae2eb2fd5a4ca7ae Changes: https://git.openjdk.java.net/jdk11u-dev/pull/809/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=809&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8216969 Stats: 35 lines in 2 files changed: 31 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/809.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/809/head:pull/809 PR: https://git.openjdk.java.net/jdk11u-dev/pull/809 From vkempik at openjdk.java.net Tue Feb 8 08:22:37 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 8 Feb 2022 08:22:37 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 Message-ID: The backport is not applying clean due to the context code difference. It's needed mostly to resolve this compilation error on macos-aarch64 splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] ------------- Commit messages: - 8260518: Change default -mmacosx-version-min to 10.12 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/810/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=810&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260518 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/810.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/810/head:pull/810 PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From aph at openjdk.java.net Tue Feb 8 10:04:11 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Tue, 8 Feb 2022 10:04:11 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8] In-Reply-To: References: Message-ID: <_UWWoigZIwfNOwcOS06b2MF71x0Lyml1cHzu1jaQSNo=.03950dd6-8834-41ab-ade4-2b45946b5970@github.com> On Sat, 5 Feb 2022 15:30:59 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Add two missing WX transitions On 2/8/22 06:48, VladimirKempik wrote: > @rnkovacs , parts of your jep-388 backport reverted ( https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1495, https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1558, https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1671 ) results in more warning for this PR: > > /Users/runner/work/jdk11u-dev/jdk11u-dev/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:1495:52: error: format specifies type 'unsigned long long' but the argument has type 'uintptr_t' (aka 'unsigned long') [-Werror,-Wformat] > snprintf(buffer, sizeof(buffer), PTR64_FORMAT, imm64); > ~~~~~~~~~~~~ ^~~~~ > 1 error generated. > > was these three changes really needed or can I revert them ? What does this refer to? I can't find any such thing in the current state of the patch. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From goetz at openjdk.java.net Tue Feb 8 10:18:12 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Feb 2022 10:18:12 GMT Subject: [jdk17u-dev] Integrated: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 In-Reply-To: References: Message-ID: On Sun, 30 Jan 2022 13:40:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. This pull request has now been integrated. Changeset: 0965996c Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/0965996c5c6d63051f0711c40843c030771a2d7b Stats: 5 lines in 1 file changed: 2 ins; 1 del; 2 mod 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 Backport-of: 13265f9901ab8334bbe1e7a571a9c5f386275dbf ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/129 From vkempik at openjdk.java.net Tue Feb 8 10:23:10 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 8 Feb 2022 10:23:10 GMT Subject: [jdk11u-dev] Integrated: 8264650: Cross-compilation to macos/aarch64 In-Reply-To: References: Message-ID: On Fri, 4 Feb 2022 13:53:53 GMT, Vladimir Kempik wrote: > Clean backport, to be done in advance of jep-391 backport This pull request has now been integrated. Changeset: afb94aea Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/afb94aeae8ffab20ca07dd0fad3765fd65a15255 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod 8264650: Cross-compilation to macos/aarch64 Reviewed-by: burban Backport-of: 7f9ece23dc62e911c78be3fa4b8e297e3ac90bd1 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/807 From goetz at openjdk.java.net Tue Feb 8 10:25:27 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Feb 2022 10:25:27 GMT Subject: [jdk17u-dev] Integrated: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently In-Reply-To: References: Message-ID: <9OHOmEP3dsnGo_F1TCscD1pIcO6cAV7bu2nEGgboZg8=.b89cb356-a568-4d4e-85f8-470a631eb687@github.com> On Fri, 4 Feb 2022 09:18:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: 5159ffd4 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/5159ffd487d858f33eb50f0bb8f2bfb28fcce5ae Stats: 12 lines in 2 files changed: 6 ins; 0 del; 6 mod 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently Backport-of: f1c20e91d822c6df4c5da895f2abd6305e00bf8b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/144 From vkempik at openjdk.java.net Tue Feb 8 10:29:07 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 8 Feb 2022 10:29:07 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8] In-Reply-To: References: Message-ID: On Sat, 5 Feb 2022 15:30:59 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Add two missing WX transitions These three line changes are part of jep-388 (win-arm64) backport to jdk11u-dev, they cause troubles ( warnings which are under Werror becomes an issue) these changes aren't present in upstream (jdk19), for example - https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L1316 so I wonder why did they became part of jep-388 backport to jdk11u-dev if there is no good reason, then I would like to revert these changes as part of this PR. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From vkempik at openjdk.java.net Tue Feb 8 10:42:02 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 8 Feb 2022 10:42:02 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9] In-Reply-To: References: Message-ID: > Initial version of JEP-391 backport to jdk11u. > Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. > Things needing attention: os_bsd_aarch64.cpp and W^X transitions. > serviceability agent is mostly clean. > This passed GHA_tier1 testing. > Full regression testing is running now on Azul's infra, will report/update PR when done. > **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** > Sharing this PR slightly earlier to let other interested parties to run the tests too. > Example of cross-building on intel mac (needs Xcode12/13): > sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision: - Fix wrong patch from jep-388 backport - Merge branch 'master' into JDK-8253795 - Add two missing WX transitions - Ignore TestOnError.java on macos_aarch64 - Merge branch 'master' into JDK-8253795 - remove unused at_rsp from aarch64 - Fix warning about c++11 extension - Exclude test CompressedClassPointers.java on macarm - Merge pull request #1 from VladimirKempik/JEP391_and_8262896 8262896: [macos_aarch64] Crash in jni_fast_GetLongField - 8262896: [macos_aarch64] Crash in jni_fast_GetLongField - ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/a7cad9ad...6d037958 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/715/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/715/files/787ccf85..6d037958 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=715&range=08 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=715&range=07-08 Stats: 15648 lines in 594 files changed: 10817 ins; 2515 del; 2316 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/715.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/715/head:pull/715 PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From aph at openjdk.java.net Tue Feb 8 10:42:02 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Tue, 8 Feb 2022 10:42:02 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8] In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 10:25:57 GMT, Vladimir Kempik wrote: > so I wonder why did they became part of jep-388 backport to jdk11u-dev if there is no good reason, then I would like to revert these changes as part of this PR. There can be no good reason for an incorrect change, so please do that. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From vkempik at openjdk.java.net Tue Feb 8 10:42:03 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 8 Feb 2022 10:42:03 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8] In-Reply-To: References: Message-ID: On Sat, 5 Feb 2022 15:30:59 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64' > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Add two missing WX transitions Ok. Also. After latest merge with master this can now be crosscompiled without -with-extra-"c/ld/cxx"flags ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From phh at openjdk.java.net Tue Feb 8 14:59:10 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 8 Feb 2022 14:59:10 GMT Subject: [jdk11u-dev] RFR: 8278381: [GCC 11] Address::make_raw() does not initialize rspec In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 22:01:30 GMT, Paul Hohensee wrote: > Trivial gcc 11 compatibility patch, applies cleanly. Approved. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/804 From phh at openjdk.java.net Tue Feb 8 14:59:10 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 8 Feb 2022 14:59:10 GMT Subject: [jdk11u-dev] Integrated: 8278381: [GCC 11] Address::make_raw() does not initialize rspec In-Reply-To: References: Message-ID: On Tue, 1 Feb 2022 22:01:30 GMT, Paul Hohensee wrote: > Trivial gcc 11 compatibility patch, applies cleanly. This pull request has now been integrated. Changeset: 288c9f7d Author: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/288c9f7d6ac6057216d3c7756ea667cfb65fc6a3 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8278381: [GCC 11] Address::make_raw() does not initialize rspec Backport-of: 4f594e6a28ad85d46d3252fb960f1c116f414899 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/804 From phh at openjdk.java.net Tue Feb 8 15:06:21 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 8 Feb 2022 15:06:21 GMT Subject: [jdk15u-dev] RFR: 8281374: Add MD5.implCompress0 to Graal toBeInvestigated list after 8280978 In-Reply-To: References: Message-ID: <7hIDbmAEtNiYnEfWj29r_iladFD23YAQiBpq0FWvndI=.0e3bd6c2-5b82-48ff-a6cc-83dc0f53a327@github.com> On Mon, 7 Feb 2022 15:33:03 GMT, Paul Hohensee wrote: > Patch to fix [JDK-8280978](https://bugs.openjdk.java.net/browse/JDK-8280978), the 15u backport of [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902). Add MD5.implCompress0 to Graal toBeInvestigated list for JDK 15 and above rather than JDK 16 and above. Approved. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/171 From phh at openjdk.java.net Tue Feb 8 15:06:22 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 8 Feb 2022 15:06:22 GMT Subject: [jdk15u-dev] Integrated: 8281374: Add MD5.implCompress0 to Graal toBeInvestigated list after 8280978 In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 15:33:03 GMT, Paul Hohensee wrote: > Patch to fix [JDK-8280978](https://bugs.openjdk.java.net/browse/JDK-8280978), the 15u backport of [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902). Add MD5.implCompress0 to Graal toBeInvestigated list for JDK 15 and above rather than JDK 16 and above. This pull request has now been integrated. Changeset: 8612163b Author: Paul Hohensee URL: https://git.openjdk.java.net/jdk15u-dev/commit/8612163b04e0f414d4ea0c0dbff99ac98302f82f Stats: 5 lines in 1 file changed: 0 ins; 4 del; 1 mod 8281374: Add MD5.implCompress0 to Graal toBeInvestigated list after 8280978 Reviewed-by: simonis ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/171 From goetz.lindenmaier at sap.com Tue Feb 8 15:54:36 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 8 Feb 2022 15:54:36 +0000 Subject: [11u] Patch release jdk-11.0.14.1-ga Message-ID: Hi, we tagged patch 11.0.14.1 in open jdk11u containing a fix for the regression JDK-8218546 in 11.0.14. tag 11.0.14.1-ga: https://github.com/openjdk/jdk11u/releases/tag/jdk-11.0.14.1-ga Changes: - 8280786: Build failure on Solaris after 8262392 - 8218546: Unable to connect to https://google.com using java.net.HttpClient - 8281324: Bump update version for OpenJDK: jdk-11.0.14.1 Best regards, Goetz. From zgu at openjdk.java.net Tue Feb 8 16:34:50 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 8 Feb 2022 16:34:50 GMT Subject: [jdk17u-dev] RFR: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted Message-ID: A clean and test only backport for parity with Oracle 17.0.4. Test: - [x] Test passed on Linux x86_64. ------------- Commit messages: - Backport aaedac635a0a7ca1f73dcf85336230cc537fcdf2 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/148/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=148&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265261 Stats: 60 lines in 1 file changed: 39 ins; 0 del; 21 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/148.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/148/head:pull/148 PR: https://git.openjdk.java.net/jdk17u-dev/pull/148 From phh at openjdk.java.net Tue Feb 8 17:36:09 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 8 Feb 2022 17:36:09 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 08:16:59 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8260518 to jdk11u-dev > The backport is not applying clean due to the context code difference. > It's needed mostly to resolve this compilation error on macos-aarch64 > splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] > This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) Lgtm. Note to Maintainers: 10.9 through 10.14 are eol, and the oldest machines supported by 10.12 are from 2009/2010, see https://support.apple.com/kb/SP742?locale=en_USh. Imo it's safe to say that it's very unlikely there are machines running OSX versions earlier than 10.12. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From duke at openjdk.java.net Tue Feb 8 17:37:24 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Tue, 8 Feb 2022 17:37:24 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: <63gt641awibA-UYWPIUat0fEpGTDyBmrrdA1vmiK2ik=.19993fe0-1323-481a-b0ed-4ecd8b90ca25@github.com> On Fri, 24 Dec 2021 17:23:26 GMT, Alexey Pavlyutkin wrote: > This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u > > I'd like to backport JDK-8274471 to jdk17u-dev > > The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS > > The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) > - imported few required packages > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security @TheRealMDoerr, could you checked this one. This is just a copy of https://github.com/openjdk/jdk17u/pull/248 that was reviewed by you but missed 17.0.2 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From vkempik at openjdk.java.net Tue Feb 8 17:43:16 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 8 Feb 2022 17:43:16 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 08:16:59 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8260518 to jdk11u-dev > The backport is not applying clean due to the context code difference. > It's needed mostly to resolve this compilation error on macos-aarch64 > splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] > This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) Thanks Paul. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From mdoerr at openjdk.java.net Tue Feb 8 17:48:34 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Feb 2022 17:48:34 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: On Fri, 24 Dec 2021 17:23:26 GMT, Alexey Pavlyutkin wrote: > This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u > > I'd like to backport JDK-8274471 to jdk17u-dev > > The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS > > The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) > - imported few required packages > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security Still good. Thanks for the new PR. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From mdoerr at openjdk.java.net Tue Feb 8 18:10:49 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Feb 2022 18:10:49 GMT Subject: [jdk11u-dev] RFR: 8280155: [PPC64, s390] frame size checks are not yet correct [v2] In-Reply-To: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> References: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> Message-ID: <786ujUMBMr5xSQBtBJVxu6EWmKkBcZ9e_8Pad-3nJtM=.474e8b98-299b-4ca7-9c48-7375414a1de8@github.com> > Backport of JDK-8280155. Applies cleanly except Copyright update. Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport f37bfeadcf036a75defc64ad7f4a9f5596cd7407 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/797/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=797&range=01 Stats: 11 lines in 3 files changed: 4 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/797.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/797/head:pull/797 PR: https://git.openjdk.java.net/jdk11u-dev/pull/797 From mdoerr at openjdk.java.net Tue Feb 8 18:17:26 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Feb 2022 18:17:26 GMT Subject: [jdk17u-dev] RFR: 8281061: [s390] JFR runs into assertions while validating interpreter frames Message-ID: Clean backport of JDK-8281061. ------------- Commit messages: - Backport 7f19c700707573000a37910dd6d2f2bb6e8439ad Changes: https://git.openjdk.java.net/jdk17u-dev/pull/149/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=149&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281061 Stats: 18 lines in 2 files changed: 2 ins; 3 del; 13 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/149.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/149/head:pull/149 PR: https://git.openjdk.java.net/jdk17u-dev/pull/149 From mdoerr at openjdk.java.net Tue Feb 8 18:30:29 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Feb 2022 18:30:29 GMT Subject: [jdk11u-dev] RFR: 8281061: [s390] JFR runs into assertions while validating interpreter frames Message-ID: Mostly clean backport of JDK-8281061. Some hunks needed to get integrated manually due to different context. `is_in_full_stack` does not exist in 11u, so the `istate` in stack check line is different. Fix is the same. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/797 Commit messages: - Backport 7f19c700707573000a37910dd6d2f2bb6e8439ad Changes: https://git.openjdk.java.net/jdk11u-dev/pull/811/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=811&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281061 Stats: 18 lines in 2 files changed: 2 ins; 3 del; 13 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/811.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/811/head:pull/811 PR: https://git.openjdk.java.net/jdk11u-dev/pull/811 From lucy at openjdk.java.net Tue Feb 8 20:10:19 2022 From: lucy at openjdk.java.net (Lutz Schmidt) Date: Tue, 8 Feb 2022 20:10:19 GMT Subject: [jdk11u-dev] RFR: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks [v3] In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 16:25:59 GMT, Martin Doerr wrote: >> Backport of JDK-8279924. Applies cleanly except Copyright update. `is_in_stack_range_incl` needs to get replaced by 11u code like on other platforms (see 2nd commit). An old assertion is not compatible with this code and the removal needs to get backported (integrated with 3rd commit). > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Integrate bad assert removal from JDK-8254158 (x86 was already changed by JDK-8146546). The changes look good to me. Please note that I'm not a idk-updates reviewer. How about changing the copyright year in in the os_*.cpp files? ------------- Marked as reviewed by lucy (Committer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/796 From lucy at openjdk.java.net Tue Feb 8 20:11:19 2022 From: lucy at openjdk.java.net (Lutz Schmidt) Date: Tue, 8 Feb 2022 20:11:19 GMT Subject: [jdk11u-dev] RFR: 8280155: [PPC64, s390] frame size checks are not yet correct [v2] In-Reply-To: <786ujUMBMr5xSQBtBJVxu6EWmKkBcZ9e_8Pad-3nJtM=.474e8b98-299b-4ca7-9c48-7375414a1de8@github.com> References: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> <786ujUMBMr5xSQBtBJVxu6EWmKkBcZ9e_8Pad-3nJtM=.474e8b98-299b-4ca7-9c48-7375414a1de8@github.com> Message-ID: On Tue, 8 Feb 2022 18:10:49 GMT, Martin Doerr wrote: >> Backport of JDK-8280155. Applies cleanly except Copyright update. > > Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport f37bfeadcf036a75defc64ad7f4a9f5596cd7407 The changes look good to me. Please note that I'm not a idk-updates reviewer. ------------- Marked as reviewed by lucy (Committer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/797 From lucy at openjdk.java.net Tue Feb 8 20:11:20 2022 From: lucy at openjdk.java.net (Lutz Schmidt) Date: Tue, 8 Feb 2022 20:11:20 GMT Subject: [jdk11u-dev] RFR: 8281061: [s390] JFR runs into assertions while validating interpreter frames In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 18:22:46 GMT, Martin Doerr wrote: > Mostly clean backport of JDK-8281061. Some hunks needed to get integrated manually due to different context. `is_in_full_stack` does not exist in 11u, so the `istate` in stack check line is different. Fix is the same. The changes look good to me. Please note that I'm not a idk-updates reviewer. ------------- Marked as reviewed by lucy (Committer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/811 From duke at openjdk.java.net Tue Feb 8 21:16:06 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Tue, 8 Feb 2022 21:16:06 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8] In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 10:33:52 GMT, Vladimir Kempik wrote: >> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: >> >> Add two missing WX transitions > > Ok. > Also. After latest merge with master this can now be crosscompiled without -with-extra-"c/ld/cxx"flags @VladimirKempik should I submit a PR to backport [8241004: NMT tests fail on unaligned thread size with debug build](https://github.com/openjdk/jdk/commit/0b20eafb30cc1de372141f2a427d13fdc6565e3a) or is it already on your radar? The backport solves issue 2 from my post here: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1020401252 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From vkempik at openjdk.java.net Tue Feb 8 21:16:11 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 8 Feb 2022 21:16:11 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9] In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 10:42:02 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin > > Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision: > > - Fix wrong patch from jep-388 backport > - Merge branch 'master' into JDK-8253795 > - Add two missing WX transitions > - Ignore TestOnError.java on macos_aarch64 > - Merge branch 'master' into JDK-8253795 > - remove unused at_rsp from aarch64 > - Fix warning about c++11 extension > - Exclude test CompressedClassPointers.java on macarm > - Merge pull request #1 from VladimirKempik/JEP391_and_8262896 > > 8262896: [macos_aarch64] Crash in jni_fast_GetLongField > - 8262896: [macos_aarch64] Crash in jni_fast_GetLongField > - ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/037f3254...6d037958 Please proceed with 8241004, I have few other macarm related issues on my radar atm. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From duke at openjdk.java.net Wed Feb 9 01:46:33 2022 From: duke at openjdk.java.net (Campbell Jones) Date: Wed, 9 Feb 2022 01:46:33 GMT Subject: [jdk11u] RFR: 8229258: Backport patch from JDK 14 to allow building with Clang 13 Message-ID: This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. See the following for more information: - https://bugs.openjdk.java.net/browse/JDK-8229258 - https://bugs.gentoo.org/817995 - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html - https://reviews.llvm.org/D99790#2678384 ------------- Commit messages: - 8229258: Backport patch from JDK 14 to allow building with Clang 13 Changes: https://git.openjdk.java.net/jdk11u/pull/23/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=23&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8229258 Stats: 788 lines in 103 files changed: 51 ins; 6 del; 731 mod Patch: https://git.openjdk.java.net/jdk11u/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/23/head:pull/23 PR: https://git.openjdk.java.net/jdk11u/pull/23 From duke at openjdk.java.net Wed Feb 9 01:46:33 2022 From: duke at openjdk.java.net (Campbell Jones) Date: Wed, 9 Feb 2022 01:46:33 GMT Subject: [jdk11u] RFR: 8229258: Backport patch from JDK 14 to allow building with Clang 13 In-Reply-To: References: Message-ID: <2W00Z-no_bSmrSNcbHxSzRLMypNQnw0bDS5cKC-j_JQ=.6eaf3c55-0a9c-4ea0-b65a-7e596f592800@github.com> On Sun, 19 Dec 2021 02:55:01 GMT, Campbell Jones wrote: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > - https://bugs.openjdk.java.net/browse/JDK-8229258 > - https://bugs.gentoo.org/817995 > - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > - https://reviews.llvm.org/D99790#2678384 I signed the OCA two weeks ago?no updates? ------------- PR: https://git.openjdk.java.net/jdk11u/pull/23 From duke at openjdk.java.net Wed Feb 9 01:46:34 2022 From: duke at openjdk.java.net (James Beddek) Date: Wed, 9 Feb 2022 01:46:34 GMT Subject: [jdk11u] RFR: 8229258: Backport patch from JDK 14 to allow building with Clang 13 In-Reply-To: References: Message-ID: <5F2gHFnGhqRII_lr26uv29CsvrWEvsNxXl_g5B_bRqk=.161cd192-45cc-41ba-8fa9-da7c55577471@github.com> On Sun, 19 Dec 2021 02:55:01 GMT, Campbell Jones wrote: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > - https://bugs.openjdk.java.net/browse/JDK-8229258 > - https://bugs.gentoo.org/817995 > - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > - https://reviews.llvm.org/D99790#2678384 I'm not sure this repo is checked at all, maybe try https://github.com/openjdk/jdk11u-dev/ ? ------------- PR: https://git.openjdk.java.net/jdk11u/pull/23 From ddong at openjdk.java.net Wed Feb 9 06:59:37 2022 From: ddong at openjdk.java.net (Denghui Dong) Date: Wed, 9 Feb 2022 06:59:37 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter Message-ID: Hi team, Could I have a review of this fix? The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter: 387 } else { 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload); 389 CompositeKlassWriter ckw(&lkw, &kw); 390 CompositeKlassWriterRegistration ckwr(&ckw, ®); 391 CompositeKlassCallback callback(&ckwr); 392 _subsystem_callback = &callback; 393 do_klasses(); 394 } This problem is introduced by JDK-8225797 and fixed by JDK-8233111. I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment. testing: test/jdk/jdk/jfr Thanks, Denghui ------------- Commit messages: - JFR: A wrong parameter is passed to the constructor of LeakKlassWriter Changes: https://git.openjdk.java.net/jdk11u-dev/pull/813/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=813&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281520 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/813.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/813/head:pull/813 PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From goetz at openjdk.java.net Wed Feb 9 07:59:05 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Feb 2022 07:59:05 GMT Subject: [jdk11u-dev] Integrated: 8216969: ParseException thrown for certain months with russian locale In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 07:50:56 GMT, Goetz Lindenmaier wrote: > I think this is a useful, safe fix for 11. This pull request has now been integrated. Changeset: cd7d8c6c Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/cd7d8c6c5d51eb9999b88f793b1e69bbdcb27353 Stats: 35 lines in 2 files changed: 31 ins; 0 del; 4 mod 8216969: ParseException thrown for certain months with russian locale Backport-of: 0623444ae5a0bbf143c288c7ae2eb2fd5a4ca7ae ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/809 From vkempik at openjdk.java.net Wed Feb 9 08:01:07 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 9 Feb 2022 08:01:07 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8] In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 10:33:10 GMT, Andrew Haley wrote: >> These three line changes are part of jep-388 (win-arm64) backport to jdk11u-dev, they cause troubles ( warnings which are under Werror becomes an issue) >> these changes aren't present in upstream (jdk19), for example - https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L1316 >> >> so I wonder why did they became part of jep-388 backport to jdk11u-dev >> if there is no good reason, then I would like to revert these changes as part of this PR. > >> so I wonder why did they became part of jep-388 backport to jdk11u-dev if there is no good reason, then I would like to revert these changes as part of this PR. > > There can be no good reason for an incorrect change, so please do that. @theRealAph what do you think, is this PR ready to go jdk11u-dev ? it would be good to merge it some time before rdp2 to have a time for non-critical fixes. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From goetz at openjdk.java.net Wed Feb 9 08:20:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Feb 2022 08:20:06 GMT Subject: [jdk11u-dev] RFR: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks [v3] In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 16:25:59 GMT, Martin Doerr wrote: >> Backport of JDK-8279924. Applies cleanly except Copyright update. `is_in_stack_range_incl` needs to get replaced by 11u code like on other platforms (see 2nd commit). An old assertion is not compatible with this code and the removal needs to get backported (integrated with 3rd commit). > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Integrate bad assert removal from JDK-8254158 (x86 was already changed by JDK-8146546). LGTM ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/796 From goetz at openjdk.java.net Wed Feb 9 08:20:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Feb 2022 08:20:06 GMT Subject: [jdk11u-dev] RFR: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks [v3] In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 20:07:23 GMT, Lutz Schmidt wrote: >> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: >> >> Integrate bad assert removal from JDK-8254158 (x86 was already changed by JDK-8146546). > > The changes look good to me. > Please note that I'm not a idk-updates reviewer. > How about changing the copyright year in in the os_*.cpp files? @RealLucy we don't change copyrights in backports. We follow what the original change did. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/796 From goetz at openjdk.java.net Wed Feb 9 08:21:05 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Feb 2022 08:21:05 GMT Subject: [jdk11u-dev] RFR: 8281061: [s390] JFR runs into assertions while validating interpreter frames In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 18:22:46 GMT, Martin Doerr wrote: > Mostly clean backport of JDK-8281061. Some hunks needed to get integrated manually due to different context. `is_in_full_stack` does not exist in 11u, so the `istate` in stack check line is different. Fix is the same. LGTM ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/811 From aph at openjdk.java.net Wed Feb 9 08:47:08 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Wed, 9 Feb 2022 08:47:08 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9] In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 10:42:02 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin > > Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision: > > - Fix wrong patch from jep-388 backport > - Merge branch 'master' into JDK-8253795 > - Add two missing WX transitions > - Ignore TestOnError.java on macos_aarch64 > - Merge branch 'master' into JDK-8253795 > - remove unused at_rsp from aarch64 > - Fix warning about c++11 extension > - Exclude test CompressedClassPointers.java on macarm > - Merge pull request #1 from VladimirKempik/JEP391_and_8262896 > > 8262896: [macos_aarch64] Crash in jni_fast_GetLongField > - 8262896: [macos_aarch64] Crash in jni_fast_GetLongField > - ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/a11da5bc...6d037958 This looks good enough. ------------- Marked as reviewed by aph (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From goetz at openjdk.java.net Wed Feb 9 09:38:23 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Feb 2022 09:38:23 GMT Subject: [jdk11u-dev] RFR: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently Message-ID: <0cEcGpMNf8eTttnuS3vi45Bf0fsG_YWfVvPNx4ibI0k=.be329394-ade5-452a-aaa4-0f26a9d65e04@github.com> I backport this for parity with 11.0.15-oracle. ------------- Commit messages: - Backport f1c20e91d822c6df4c5da895f2abd6305e00bf8b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/814/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=814&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8190748 Stats: 12 lines in 2 files changed: 6 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/814.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/814/head:pull/814 PR: https://git.openjdk.java.net/jdk11u-dev/pull/814 From vkempik at azul.com Wed Feb 9 10:01:19 2022 From: vkempik at azul.com (Vladimir Kempik) Date: Wed, 9 Feb 2022 10:01:19 +0000 Subject: Heads up: planning to drop macos support older than 10.12 Message-ID: <80E24076-90CE-4C2A-A953-F4F8759C562F@azul.com> For one of the next jdk11 updates, an update to the minimally supported macos version is planned. Right now it?s macos 10.9, the plan is to move to macos 10.12 as minimally supported macos version. The similar patch was applied to jdk17 about an year ago: https://git.openjdk.java.net/jdk/commit/53f1b938 The JBS bug - https://bugs.openjdk.java.net/browse/JDK-8260518 Macos 10.9 through 10.14 are eol, and the oldest machines supported by 10.12 are from 2009/2010. Best regards, Vladimir From yan at openjdk.java.net Wed Feb 9 11:21:36 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 9 Feb 2022 11:21:36 GMT Subject: [jdk15u-dev] Integrated: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily Message-ID: clean backport; new and old tests do pass. ------------- Commit messages: - Backport 8822d41fdcc2c2d568badd72635dc587d21dbd63 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/172/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=172&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274736 Stats: 429 lines in 3 files changed: 425 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/172.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/172/head:pull/172 PR: https://git.openjdk.java.net/jdk15u-dev/pull/172 From yan at openjdk.java.net Wed Feb 9 11:21:37 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 9 Feb 2022 11:21:37 GMT Subject: [jdk15u-dev] Integrated: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 11:10:09 GMT, Yuri Nesterenko wrote: > clean backport; new and old tests do pass. This pull request has now been integrated. Changeset: c9a3110b Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/c9a3110b58b6c241599892ec8b22b2c923b413cd Stats: 429 lines in 3 files changed: 425 ins; 0 del; 4 mod 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily Backport-of: 8822d41fdcc2c2d568badd72635dc587d21dbd63 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/172 From shade at openjdk.java.net Wed Feb 9 11:36:15 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 9 Feb 2022 11:36:15 GMT Subject: [jdk11u-dev] RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3 In-Reply-To: References: Message-ID: On Wed, 19 Jan 2022 10:16:24 GMT, Aleksey Shipilev wrote: > Unclean backport to improve 11u testing. It does not apply cleanly for two reasons: > > - https://bugs.openjdk.java.net/browse/JDK-8265793 is not in 11u yet, and I think it would be cleaner to backport that one *after* this issue; > - https://github.com/openjdk/jdk/commit/1b45bf2d581bf75fabefa13e56ecec6e6ae9036c is not in 11u, and it would be not that relevant after this backport; > > The avaiability of catch-all `jdk:tier4` protects us from skipping the tests. If there are test group mistakes that drop some tests from `jdk:tier3`, they would be captured by `jdk:tier4`. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk:tier3` Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/780 From shade at openjdk.java.net Wed Feb 9 11:36:15 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 9 Feb 2022 11:36:15 GMT Subject: [jdk11u-dev] Integrated: 8277992: Add fast jdk_svc subtests to jdk:tier3 In-Reply-To: References: Message-ID: On Wed, 19 Jan 2022 10:16:24 GMT, Aleksey Shipilev wrote: > Unclean backport to improve 11u testing. It does not apply cleanly for two reasons: > > - https://bugs.openjdk.java.net/browse/JDK-8265793 is not in 11u yet, and I think it would be cleaner to backport that one *after* this issue; > - https://github.com/openjdk/jdk/commit/1b45bf2d581bf75fabefa13e56ecec6e6ae9036c is not in 11u, and it would be not that relevant after this backport; > > The avaiability of catch-all `jdk:tier4` protects us from skipping the tests. If there are test group mistakes that drop some tests from `jdk:tier3`, they would be captured by `jdk:tier4`. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk:tier3` This pull request has now been integrated. Changeset: 18a08833 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/18a088335bb0c14abdfb6c3f3bf777a0ce3b5d97 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8277992: Add fast jdk_svc subtests to jdk:tier3 Reviewed-by: serb Backport-of: 30f0c6475359516ce454722f06ac0c997e09868b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/780 From mdoerr at openjdk.java.net Wed Feb 9 11:36:16 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Feb 2022 11:36:16 GMT Subject: [jdk17u-dev] RFR: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also In-Reply-To: References: Message-ID: On Fri, 4 Feb 2022 11:59:21 GMT, Jonathan Dowland wrote: > Good Morning > > This pull request contains a backport of commit [86d0abb6](https://github.com/openjdk/jdk/commit/86d0abb66bd2fe1edd15b81d351ea3b3c90fd256) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Fairoz Matte on 11 Jan 2022 and was reviewed by Nils Eliasson. > > This is a test-only change, for Oracle parity. The affected test passes for me on jdk17u-dev master before and afterwards. > > Thanks! Marked as reviewed by mdoerr (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/145 From shade at openjdk.java.net Wed Feb 9 11:48:22 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 9 Feb 2022 11:48:22 GMT Subject: [jdk11u-dev] RFR: 8265343: Update Debian-based cross-compilation recipes [v2] In-Reply-To: References: <7CC6WPGbUdVXErgaSHvhY98bp9JygorbdilS6rdqzHw=.45fe9557-9b56-4a68-b3d3-bd8d5f0b6202@github.com> Message-ID: On Wed, 5 Jan 2022 10:02:59 GMT, Aleksey Shipilev wrote: >> Another (hopefully final) backport to improve cross-compilation docs. The simplified cross-compilation recipe matches what we have in 11u GHA: only `--openjdk-target` and `--with-sysroot` is supplied. >> >> It had minor contextual conflicts that precluded the automatic merge. I checked that the platforms listed in compatible platforms list is indeed buildable (see https://builds.shipilev.net/openjdk-jdk11-dev/ for example). > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8265343-update-debian > - Backport 7879adbe88ec54b8f5ac9543d80142bc1b12112b Any opinions? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/601 From mdoerr at openjdk.java.net Wed Feb 9 11:57:29 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Feb 2022 11:57:29 GMT Subject: [jdk17u-dev] RFR: 8281043: Intrinsify recursive ObjectMonitor locking for PPC64 Message-ID: Clean backport of JDK-8281043. It addresses a performance regression from jdk16. ------------- Commit messages: - Backport 46c6c6f308b5ec0ec3b762df4b76de555287474c Changes: https://git.openjdk.java.net/jdk17u-dev/pull/150/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=150&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281043 Stats: 23 lines in 1 file changed: 8 ins; 3 del; 12 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/150.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/150/head:pull/150 PR: https://git.openjdk.java.net/jdk17u-dev/pull/150 From yan at openjdk.java.net Wed Feb 9 12:03:41 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 9 Feb 2022 12:03:41 GMT Subject: [jdk13u-dev] RFR: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily Message-ID: <2R2WOLQx8JWPinKQI7BpevgcWVxJ85aK0l42x9H0wtc=.5739f3bc-eed6-4e67-aa01-4146ced7cc64@github.com> I'd like to port it for parity with major releases. The patch applies cleanly but like in 11u (and unlike 15u), there's a necessary addition to the test at line 270. ------------- Commit messages: - Backport 8822d41fdcc2c2d568badd72635dc587d21dbd63 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/324/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=324&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274736 Stats: 431 lines in 3 files changed: 427 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/324.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/324/head:pull/324 PR: https://git.openjdk.java.net/jdk13u-dev/pull/324 From dcherepanov at openjdk.java.net Wed Feb 9 12:21:19 2022 From: dcherepanov at openjdk.java.net (Dmitry Cherepanov) Date: Wed, 9 Feb 2022 12:21:19 GMT Subject: [jdk13u-dev] RFR: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily In-Reply-To: <2R2WOLQx8JWPinKQI7BpevgcWVxJ85aK0l42x9H0wtc=.5739f3bc-eed6-4e67-aa01-4146ced7cc64@github.com> References: <2R2WOLQx8JWPinKQI7BpevgcWVxJ85aK0l42x9H0wtc=.5739f3bc-eed6-4e67-aa01-4146ced7cc64@github.com> Message-ID: <03A01zjIRE9Pm4mfEUxvo-A3OBXvTpa2TuhKCUuKIRo=.5c06e7bf-b73f-49ec-8fd7-ffbf99031cd9@github.com> On Wed, 9 Feb 2022 11:56:50 GMT, Yuri Nesterenko wrote: > I'd like to port it for parity with major releases. The patch applies cleanly but like in 11u (and unlike 15u), there's a necessary addition to the test at line 270. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/324 From yan at openjdk.java.net Wed Feb 9 12:33:19 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 9 Feb 2022 12:33:19 GMT Subject: [jdk13u-dev] Integrated: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily In-Reply-To: <2R2WOLQx8JWPinKQI7BpevgcWVxJ85aK0l42x9H0wtc=.5739f3bc-eed6-4e67-aa01-4146ced7cc64@github.com> References: <2R2WOLQx8JWPinKQI7BpevgcWVxJ85aK0l42x9H0wtc=.5739f3bc-eed6-4e67-aa01-4146ced7cc64@github.com> Message-ID: On Wed, 9 Feb 2022 11:56:50 GMT, Yuri Nesterenko wrote: > I'd like to port it for parity with major releases. The patch applies cleanly but like in 11u (and unlike 15u), there's a necessary addition to the test at line 270. This pull request has now been integrated. Changeset: d959f811 Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/d959f811c43d83e34e141a5b5b0f654ff80f8783 Stats: 431 lines in 3 files changed: 427 ins; 0 del; 4 mod 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily Reviewed-by: dcherepanov Backport-of: 8822d41fdcc2c2d568badd72635dc587d21dbd63 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/324 From yan at azul.com Wed Feb 9 12:43:27 2022 From: yan at azul.com (Yuri Nesterenko) Date: Wed, 9 Feb 2022 15:43:27 +0300 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik Message-ID: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project Reviewer. Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last 9 years on behalf of Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) and drives the work on backporting that JEP into jdk11u. Votes are due by Feb 23, 2022, 13:00 UTC. Only current JDK Updates Reviewers [6] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [7]. [0] https://openjdk.java.net/census#vkempik [1] https://github.com/openjdk/jdk11u-dev/commits/master?author=vkempik%40openjdk.org [2] https://github.com/openjdk/jdk13u-dev/commits/master?author=vkempik%40openjdk.org [3] https://github.com/openjdk/jdk15u-dev/commits/master?author=vkempik%40openjdk.org [4] https://github.com/openjdk/jdk17u-dev/commits/master?author=vkempik%40openjdk.org [5] https://openjdk.java.net/jeps/391 [6] https://openjdk.java.net/census#jdk-updates [7] https://openjdk.java.net/bylaws#three-vote-consensus From goetz.lindenmaier at sap.com Wed Feb 9 12:56:21 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 9 Feb 2022 12:56:21 +0000 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: Vote: yes Best Goetz > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Yuri Nesterenko > Sent: Wednesday, February 9, 2022 1:43 PM > To: jdk-updates-dev at openjdk.java.net > Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik > > I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project > Reviewer. > > Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last > 9 years on behalf of > Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) > and drives the work on > backporting that JEP into jdk11u. > > Votes are due by Feb 23, 2022, 13:00 UTC. > > Only current JDK Updates Reviewers [6] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [7]. > > [0] https://openjdk.java.net/census#vkempik > [1] https://github.com/openjdk/jdk11u- > dev/commits/master?author=vkempik%40openjdk.org > [2] https://github.com/openjdk/jdk13u- > dev/commits/master?author=vkempik%40openjdk.org > [3] https://github.com/openjdk/jdk15u- > dev/commits/master?author=vkempik%40openjdk.org > [4] https://github.com/openjdk/jdk17u- > dev/commits/master?author=vkempik%40openjdk.org > [5] https://openjdk.java.net/jeps/391 > [6] https://openjdk.java.net/census#jdk-updates > [7] https://openjdk.java.net/bylaws#three-vote-consensus From thomas.stuefe at gmail.com Wed Feb 9 12:59:01 2022 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Wed, 9 Feb 2022 13:59:01 +0100 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: Vote: yes On Wed, Feb 9, 2022, 13:43 Yuri Nesterenko wrote: > I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project > Reviewer. > > Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the > last 9 years on behalf of > Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) > and drives the work on > backporting that JEP into jdk11u. > > Votes are due by Feb 23, 2022, 13:00 UTC. > > Only current JDK Updates Reviewers [6] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [7]. > > [0] https://openjdk.java.net/census#vkempik > [1] > https://github.com/openjdk/jdk11u-dev/commits/master?author=vkempik%40openjdk.org > [2] > https://github.com/openjdk/jdk13u-dev/commits/master?author=vkempik%40openjdk.org > [3] > https://github.com/openjdk/jdk15u-dev/commits/master?author=vkempik%40openjdk.org > [4] > https://github.com/openjdk/jdk17u-dev/commits/master?author=vkempik%40openjdk.org > [5] https://openjdk.java.net/jeps/391 > [6] https://openjdk.java.net/census#jdk-updates > [7] https://openjdk.java.net/bylaws#three-vote-consensus > From abrygin at azul.com Wed Feb 9 12:59:08 2022 From: abrygin at azul.com (Andrew Brygin) Date: Wed, 9 Feb 2022 15:59:08 +0300 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: Vote: yes Thanks, Andrew On 09.02.2022 15:43, Yuri Nesterenko wrote: > I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project Reviewer. > > Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last 9 years on behalf of > Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) and drives the work on > backporting that JEP into jdk11u. > > Votes are due by Feb 23, 2022, 13:00 UTC. > > Only current JDK Updates Reviewers [6] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [7]. > > [0] https://openjdk.java.net/census#vkempik > [1] https://github.com/openjdk/jdk11u-dev/commits/master?author=vkempik%40openjdk.org > [2] https://github.com/openjdk/jdk13u-dev/commits/master?author=vkempik%40openjdk.org > [3] https://github.com/openjdk/jdk15u-dev/commits/master?author=vkempik%40openjdk.org > [4] https://github.com/openjdk/jdk17u-dev/commits/master?author=vkempik%40openjdk.org > [5] https://openjdk.java.net/jeps/391 > [6] https://openjdk.java.net/census#jdk-updates > [7] https://openjdk.java.net/bylaws#three-vote-consensus From duke at openjdk.java.net Wed Feb 9 13:45:58 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Wed, 9 Feb 2022 13:45:58 GMT Subject: [jdk17u-dev] RFR: 8268582: javadoc throws NPE with --ignore-source-errors option Message-ID: I'd like to backport JDK-8268582 to jdk17u-dev The patch fixes javadoc NPE when using the --ignore-source-errors option with an non-existing type. Original patch applied cleanly Verification: `javadoc --ignore-source-errors ./Test.java` where Test.java has the following content import invalid.example.OtherClass; public class Test extends OtherClass { } Regression: langtools_javadoc (20.04/amd64) ------------- Commit messages: - Backport 0dfb3a705d2ad0ce4ac0f7dd18fb65d7ae735f16 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/152/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=152&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268582 Stats: 21 lines in 2 files changed: 16 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/152.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/152/head:pull/152 PR: https://git.openjdk.java.net/jdk17u-dev/pull/152 From goetz at openjdk.java.net Wed Feb 9 14:17:31 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Feb 2022 14:17:31 GMT Subject: [jdk17u-dev] Integrated: 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions In-Reply-To: References: Message-ID: On Wed, 2 Feb 2022 14:13:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: f3916545 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/f3916545a4eb2e9ff30d2f4090d94f389494d2fc Stats: 190 lines in 8 files changed: 135 ins; 22 del; 33 mod 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions Backport-of: 3e798dd40c68439f3220445e679b9e0e495435d8 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/143 From goetz at openjdk.java.net Wed Feb 9 14:34:45 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Feb 2022 14:34:45 GMT Subject: [jdk17u-dev] RFR: 8272600: (test) Use native "sleep" in Basic.java Message-ID: <8mMGfnOZAk0jUi_GkXaeGXu-T0Nw1VRTDlgYcs0ekz0=.e17506f7-bf2b-4d61-a639-359f5fa8ccb5@github.com> I backport this for parity with 17.0.3-oracle. ------------- Commit messages: - Backport 0a361638c5ea4d3e109d950e34a61b4737c8f670 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/153/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=153&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272600 Stats: 174 lines in 2 files changed: 111 ins; 35 del; 28 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/153.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/153/head:pull/153 PR: https://git.openjdk.java.net/jdk17u-dev/pull/153 From mdoerr at openjdk.java.net Wed Feb 9 14:57:12 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Feb 2022 14:57:12 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 19:33:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > I had to do a row of adaptions. There are some implementation > differences, and many Java 17 usages that had to be changed. > > In the original change in SunPKCS11.java, dA() is used > to give alias names of algorithms. It calls to > SecurityProviderConstants.getAliases(). > In SunPKCS11.java of jdk11 neither dA() nore getAliases() > are available. It uses d() instead of da() and calls a > s() with a list of literal strings to give the alias names. > SecurityProviderConstants.java is in java.base. The jdk11 > version does not contain the list of aliases that can be > found in 17. > > I looked up whether there are aliases listed for > "ChaCha20-Poly1305" in 17, but found none, so I added > an empty call s() in SunPKCS11.java. > > In P11AEADCipher.java I had to modify the syntax of > a switch statement. > > In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java > I had to replace HexFormat.of().formatHex(...) > which is a java.util class not in 11. > > The tests use HexFormat heavily. > I replaced it by HexToBytes() from TestKATForGCM and > by toHexString() from TestLeadingZeroesP11.java. > To make these methods available I moved them to the > superclass PKCS11Test.java. > This way they can be used for potential later backports, too. > I also had to adapt a switch statement using '->' to syntax > know to 11. Hi G?tz, thanks for doing this large backport. Looks basically good, but I have a couple of requests. The small test code refactoring makes sense. src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 635: > 633: d(AGP, "ChaCha20-Poly1305", > 634: "com.sun.crypto.provider.ChaCha20Poly1305Parameters", > 635: s(), aliases should be taken from KnowsOIDs: CHACHA20_POLY1305("1.2.840.113549.1.9.16.3.18", "CHACHA20-POLY1305"), src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 724: > 722: > 723: d(CIP, "ChaCha20-Poly1305", P11AEADCipher, > 724: s(), like above src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 727: > 725: m(CKM_CHACHA20_POLY1305)); > 726: > 727: extra newline src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_SALSA20_CHACHA20_POLY1305_PARAMS.java line 64: > 62: sb.append("0x"); > 63: for (byte b: nonce) { > 64: sb.append(String.format("0%02X", b)); other code uses `String.format("%02x", b & 0xff)`. I believe it gets converted to int with sign extend otherwise. Did you check the output? src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_SALSA20_CHACHA20_POLY1305_PARAMS.java line 75: > 73: sb.append("0x"); > 74: for (byte b: aad) { > 75: sb.append(String.format("0%02X", b)); like above ------------- Changes requested by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From hohensee at amazon.com Wed Feb 9 15:23:44 2022 From: hohensee at amazon.com (Hohensee, Paul) Date: Wed, 9 Feb 2022 15:23:44 +0000 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik Message-ID: <90BD88A9-734B-4337-8036-9D90A659D649@amazon.com> Vote: yes ?-----Original Message----- From: jdk-updates-dev on behalf of Yuri Nesterenko Date: Wednesday, February 9, 2022 at 4:44 AM To: "jdk-updates-dev at openjdk.java.net" Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project Reviewer. Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last 9 years on behalf of Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) and drives the work on backporting that JEP into jdk11u. Votes are due by Feb 23, 2022, 13:00 UTC. Only current JDK Updates Reviewers [6] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [7]. [0] https://openjdk.java.net/census#vkempik [1] https://github.com/openjdk/jdk11u-dev/commits/master?author=vkempik%40openjdk.org [2] https://github.com/openjdk/jdk13u-dev/commits/master?author=vkempik%40openjdk.org [3] https://github.com/openjdk/jdk15u-dev/commits/master?author=vkempik%40openjdk.org [4] https://github.com/openjdk/jdk17u-dev/commits/master?author=vkempik%40openjdk.org [5] https://openjdk.java.net/jeps/391 [6] https://openjdk.java.net/census#jdk-updates [7] https://openjdk.java.net/bylaws#three-vote-consensus From phh at openjdk.java.net Wed Feb 9 15:31:17 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 9 Feb 2022 15:31:17 GMT Subject: [jdk11u] RFR: 8229258: Backport patch from JDK 14 to allow building with Clang 13 In-Reply-To: References: Message-ID: On Sun, 19 Dec 2021 02:55:01 GMT, Campbell Jones wrote: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > - https://bugs.openjdk.java.net/browse/JDK-8229258 > - https://bugs.gentoo.org/817995 > - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > - https://reviews.llvm.org/D99790#2678384 That's correct, jdk11u is the 11u master repo, while jdk11u-dev is the development repo. Please submit PRs against jdk11u-dev. ------------- PR: https://git.openjdk.java.net/jdk11u/pull/23 From zgu at openjdk.java.net Wed Feb 9 16:03:29 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 9 Feb 2022 16:03:29 GMT Subject: [jdk11u-dev] RFR: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted Message-ID: A clean, test only backport for parity with Oracle 11.0.16. The test passed on Windows 10. ------------- Commit messages: - Backport aaedac635a0a7ca1f73dcf85336230cc537fcdf2 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/815/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=815&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265261 Stats: 60 lines in 1 file changed: 39 ins; 0 del; 21 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/815.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/815/head:pull/815 PR: https://git.openjdk.java.net/jdk11u-dev/pull/815 From andrew at openjdk.java.net Wed Feb 9 16:03:43 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 9 Feb 2022 16:03:43 GMT Subject: [jdk17u-dev] RFR: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication Message-ID: <96WJt39G8ACNEqygcI7tJSnSHH1vh2AkjuOYFOY-y0o=.ec0eceac-984f-4126-ad36-98aed599fb7a@github.com> Clean backport. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. ------------- Commit messages: - Backport d1aeca117ccc4334d67b2692ff087a9f8d808a59 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/154/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=154&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272541 Stats: 30 lines in 2 files changed: 18 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/154.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/154/head:pull/154 PR: https://git.openjdk.java.net/jdk17u-dev/pull/154 From mdoerr at openjdk.java.net Wed Feb 9 16:38:24 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Feb 2022 16:38:24 GMT Subject: [jdk17u-dev] RFR: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also In-Reply-To: References: Message-ID: On Fri, 4 Feb 2022 11:59:21 GMT, Jonathan Dowland wrote: > Good Morning > > This pull request contains a backport of commit [86d0abb6](https://github.com/openjdk/jdk/commit/86d0abb66bd2fe1edd15b81d351ea3b3c90fd256) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Fairoz Matte on 11 Jan 2022 and was reviewed by Nils Eliasson. > > This is a test-only change, for Oracle parity. The affected test passes for me on jdk17u-dev master before and afterwards. > > Thanks! Please add "jdk17u-fix-request" label and "Fix Request" comment to the bug. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/145 From jdowland at openjdk.java.net Wed Feb 9 17:06:17 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Wed, 9 Feb 2022 17:06:17 GMT Subject: [jdk17u-dev] RFR: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 16:35:21 GMT, Martin Doerr wrote: >> Good Morning >> >> This pull request contains a backport of commit [86d0abb6](https://github.com/openjdk/jdk/commit/86d0abb66bd2fe1edd15b81d351ea3b3c90fd256) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. >> >> The commit being backported was authored by Fairoz Matte on 11 Jan 2022 and was reviewed by Nils Eliasson. >> >> This is a test-only change, for Oracle parity. The affected test passes for me on jdk17u-dev master before and afterwards. >> >> Thanks! > > Please add "jdk17u-fix-request" label and "Fix Request" comment to the bug. @TheRealMDoerr sorry, thanks, done. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/145 From cushon at openjdk.java.net Wed Feb 9 17:31:13 2022 From: cushon at openjdk.java.net (Liam Miller-Cushon) Date: Wed, 9 Feb 2022 17:31:13 GMT Subject: [jdk11u-dev] Integrated: 8261205: AssertionError: Cannot add metadata to an intersection type In-Reply-To: References: Message-ID: On Tue, 25 Jan 2022 23:03:34 GMT, Liam Miller-Cushon wrote: > This is a backport of [JDK-8888888: AssertionError: Cannot add metadata to an intersection type](https://bugs.openjdk.java.net/browse/JDK-8261205) > > Original patch does not apply cleanly to 11u > > * I resolved a conflict where the loop in `JavacParser` that sets `declaredUsingVar = true;` was modified by JDK-8210742 > * I adjusted the changes to imports, the original patch removed an import of `com.sun.tools.javac.code.Attribute.Array` from `TypeAnnotations.java` that was still being used in 11 > * I removed the use of multi-line string literals in the test > > Testing: x86_64 build, affected tests, tier1 This pull request has now been integrated. Changeset: 1db4ed1a Author: Liam Miller-Cushon Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/1db4ed1a62e1c93c4f32d51685723b3ec99aae03 Stats: 168 lines in 5 files changed: 163 ins; 0 del; 5 mod 8261205: AssertionError: Cannot add metadata to an intersection type Reviewed-by: phh Backport-of: 81f39ed3e0176b75dee1c8db24041545bcc68a86 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/794 From phh at openjdk.java.net Wed Feb 9 18:07:08 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 9 Feb 2022 18:07:08 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 06:53:33 GMT, Denghui Dong wrote: > Hi team, > > Could I have a review of this fix? > > The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter: > > 387 } else { > 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload); > 389 CompositeKlassWriter ckw(&lkw, &kw); > 390 CompositeKlassWriterRegistration ckwr(&ckw, ®); > 391 CompositeKlassCallback callback(&ckwr); > 392 _subsystem_callback = &callback; > 393 do_klasses(); > 394 } > > > This problem is introduced by JDK-8225797 and fixed by JDK-8233111. > > I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment. > > testing: test/jdk/jdk/jfr > > Thanks, > Denghui Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From darcy at openjdk.java.net Wed Feb 9 18:36:06 2022 From: darcy at openjdk.java.net (Joe Darcy) Date: Wed, 9 Feb 2022 18:36:06 GMT Subject: [jdk18u] Integrated: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound Message-ID: <18-ZYkLMZmwzmlNZ22L1L4HSOH0GMQ8Xzvq_my6k30Q=.893c4281-9873-4acc-8513-894bd22e3b8d@github.com> 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound ------------- Commit messages: - Backport 0c42e43f77b91a50fedc3fddb74e17f910d8df2a Changes: https://git.openjdk.java.net/jdk18u/pull/21/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=21&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280550 Stats: 54 lines in 2 files changed: 52 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/21.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/21/head:pull/21 PR: https://git.openjdk.java.net/jdk18u/pull/21 From darcy at openjdk.java.net Wed Feb 9 18:36:07 2022 From: darcy at openjdk.java.net (Joe Darcy) Date: Wed, 9 Feb 2022 18:36:07 GMT Subject: [jdk18u] Integrated: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound In-Reply-To: <18-ZYkLMZmwzmlNZ22L1L4HSOH0GMQ8Xzvq_my6k30Q=.893c4281-9873-4acc-8513-894bd22e3b8d@github.com> References: <18-ZYkLMZmwzmlNZ22L1L4HSOH0GMQ8Xzvq_my6k30Q=.893c4281-9873-4acc-8513-894bd22e3b8d@github.com> Message-ID: On Wed, 9 Feb 2022 18:25:01 GMT, Joe Darcy wrote: > 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound This pull request has now been integrated. Changeset: 9d4b5edf Author: Joe Darcy URL: https://git.openjdk.java.net/jdk18u/commit/9d4b5edf2cc690a602cab6238b9d8950d317327e Stats: 54 lines in 2 files changed: 52 ins; 0 del; 2 mod 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound Backport-of: 0c42e43f77b91a50fedc3fddb74e17f910d8df2a ------------- PR: https://git.openjdk.java.net/jdk18u/pull/21 From darcy at openjdk.java.net Wed Feb 9 18:43:35 2022 From: darcy at openjdk.java.net (Joe Darcy) Date: Wed, 9 Feb 2022 18:43:35 GMT Subject: [jdk18u] Integrated: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix Message-ID: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix ------------- Commit messages: - Backport 0e70d4504c267174738485c7da82a2ac0ef09770 Changes: https://git.openjdk.java.net/jdk18u/pull/22/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=22&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280950 Stats: 42 lines in 2 files changed: 39 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk18u/pull/22.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/22/head:pull/22 PR: https://git.openjdk.java.net/jdk18u/pull/22 From darcy at openjdk.java.net Wed Feb 9 18:43:36 2022 From: darcy at openjdk.java.net (Joe Darcy) Date: Wed, 9 Feb 2022 18:43:36 GMT Subject: [jdk18u] Integrated: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 18:35:11 GMT, Joe Darcy wrote: > 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix This pull request has now been integrated. Changeset: e1dfd9fa Author: Joe Darcy URL: https://git.openjdk.java.net/jdk18u/commit/e1dfd9fa3cf262e64fdd617f2d13d57f4c61dc58 Stats: 42 lines in 2 files changed: 39 ins; 0 del; 3 mod 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix Backport-of: 0e70d4504c267174738485c7da82a2ac0ef09770 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/22 From darcy at openjdk.java.net Wed Feb 9 18:52:47 2022 From: darcy at openjdk.java.net (Joe Darcy) Date: Wed, 9 Feb 2022 18:52:47 GMT Subject: [jdk18u] Integrated: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 Message-ID: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 ------------- Commit messages: - Backport 77b0240d44fd356711d75bc241e198f6f89ada8f Changes: https://git.openjdk.java.net/jdk18u/pull/23/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=23&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281183 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk18u/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/23/head:pull/23 PR: https://git.openjdk.java.net/jdk18u/pull/23 From darcy at openjdk.java.net Wed Feb 9 18:52:48 2022 From: darcy at openjdk.java.net (Joe Darcy) Date: Wed, 9 Feb 2022 18:52:48 GMT Subject: [jdk18u] Integrated: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 18:43:37 GMT, Joe Darcy wrote: > 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 This pull request has now been integrated. Changeset: 6202ea57 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk18u/commit/6202ea57fa8998481f7db7c3febf9e6abcdef3c4 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 Backport-of: 77b0240d44fd356711d75bc241e198f6f89ada8f ------------- PR: https://git.openjdk.java.net/jdk18u/pull/23 From vladimir.kozlov at oracle.com Wed Feb 9 19:37:32 2022 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 9 Feb 2022 11:37:32 -0800 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: Vote: yes Thanks, Vladimir K On 2/9/22 4:43 AM, Yuri Nesterenko wrote: > I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project Reviewer. > > Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last 9 years on behalf of > Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) and drives the work on > backporting that JEP into jdk11u. > > Votes are due by Feb 23, 2022, 13:00 UTC. > > Only current JDK Updates Reviewers [6] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [7]. > > [0] https://openjdk.java.net/census#vkempik > [1] https://github.com/openjdk/jdk11u-dev/commits/master?author=vkempik%40openjdk.org > [2] https://github.com/openjdk/jdk13u-dev/commits/master?author=vkempik%40openjdk.org > [3] https://github.com/openjdk/jdk15u-dev/commits/master?author=vkempik%40openjdk.org > [4] https://github.com/openjdk/jdk17u-dev/commits/master?author=vkempik%40openjdk.org > [5] https://openjdk.java.net/jeps/391 > [6] https://openjdk.java.net/census#jdk-updates > [7] https://openjdk.java.net/bylaws#three-vote-consensus From vkempik at openjdk.java.net Wed Feb 9 21:42:46 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 9 Feb 2022 21:42:46 GMT Subject: [jdk11u-dev] RFR: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 Message-ID: Pleas review this backport to jdk11u-dev. It's one of few follow up fixes for jep-391 backport. This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread Not applying clean due to context code difference in chunk 2. In JDK17 it's - ThreadStateTransition::transition() in JDK11 it's - ThreadStateTransition::transition_and_fence() ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/715 Commit messages: - 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/816/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=816&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262894 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/816.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/816/head:pull/816 PR: https://git.openjdk.java.net/jdk11u-dev/pull/816 From ddong at openjdk.java.net Thu Feb 10 02:32:09 2022 From: ddong at openjdk.java.net (Denghui Dong) Date: Thu, 10 Feb 2022 02:32:09 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 18:04:28 GMT, Paul Hohensee wrote: >> Hi team, >> >> Could I have a review of this fix? >> >> The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter: >> >> 387 } else { >> 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload); >> 389 CompositeKlassWriter ckw(&lkw, &kw); >> 390 CompositeKlassWriterRegistration ckwr(&ckw, ®); >> 391 CompositeKlassCallback callback(&ckwr); >> 392 _subsystem_callback = &callback; >> 393 do_klasses(); >> 394 } >> >> >> This problem is introduced by JDK-8225797 and fixed by JDK-8233111. >> >> I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment. >> >> testing: test/jdk/jdk/jfr >> >> Thanks, >> Denghui > > Lgtm. @phohensee Thank you for the review. Is it need a second review? If not, could you help sponsor it? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From phh at openjdk.java.net Thu Feb 10 02:46:02 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 10 Feb 2022 02:46:02 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 06:53:33 GMT, Denghui Dong wrote: > Hi team, > > Could I have a review of this fix? > > The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter: > > 387 } else { > 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload); > 389 CompositeKlassWriter ckw(&lkw, &kw); > 390 CompositeKlassWriterRegistration ckwr(&ckw, ®); > 391 CompositeKlassCallback callback(&ckwr); > 392 _subsystem_callback = &callback; > 393 do_klasses(); > 394 } > > > This problem is introduced by JDK-8225797 and fixed by JDK-8233111. > > I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment. > > testing: test/jdk/jdk/jfr > > Thanks, > Denghui No need for another review, but you have to go through the usual process of tagging the issue, adding a Fix Request comment, and getting it approved before I can sponsor it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From ddong at openjdk.java.net Thu Feb 10 02:46:02 2022 From: ddong at openjdk.java.net (Denghui Dong) Date: Thu, 10 Feb 2022 02:46:02 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 06:53:33 GMT, Denghui Dong wrote: > Hi team, > > Could I have a review of this fix? > > The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter: > > 387 } else { > 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload); > 389 CompositeKlassWriter ckw(&lkw, &kw); > 390 CompositeKlassWriterRegistration ckwr(&ckw, ®); > 391 CompositeKlassCallback callback(&ckwr); > 392 _subsystem_callback = &callback; > 393 do_klasses(); > 394 } > > > This problem is introduced by JDK-8225797 and fixed by JDK-8233111. > > I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment. > > testing: test/jdk/jdk/jfr > > Thanks, > Denghui > Okay, thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From vkempik at openjdk.java.net Thu Feb 10 07:15:32 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 10 Feb 2022 07:15:32 GMT Subject: [jdk11u-dev] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run Message-ID: Please review this backport. Not applying clean. A follow up patch for jep-391 backport ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/715 Commit messages: - [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run Changes: https://git.openjdk.java.net/jdk11u-dev/pull/817/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=817&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266889 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/817.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/817/head:pull/817 PR: https://git.openjdk.java.net/jdk11u-dev/pull/817 From goetz at openjdk.java.net Thu Feb 10 08:29:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Feb 2022 08:29:15 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 02:43:59 GMT, Denghui Dong wrote: >> Hi team, >> >> Could I have a review of this fix? >> >> The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter: >> >> 387 } else { >> 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload); >> 389 CompositeKlassWriter ckw(&lkw, &kw); >> 390 CompositeKlassWriterRegistration ckwr(&ckw, ®); >> 391 CompositeKlassCallback callback(&ckwr); >> 392 _subsystem_callback = &callback; >> 393 do_klasses(); >> 394 } >> >> >> This problem is introduced by JDK-8225797 and fixed by JDK-8233111. >> >> I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment. >> >> testing: test/jdk/jdk/jfr >> >> Thanks, >> Denghui > >> > > Okay, thanks. @D-D-H Please follow the instructions for backports: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix See point 6. You should only add the tag _after_ writing the corresponding comment in the JBS issue. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From ddong at openjdk.java.net Thu Feb 10 08:39:08 2022 From: ddong at openjdk.java.net (Denghui Dong) Date: Thu, 10 Feb 2022 08:39:08 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 08:25:53 GMT, Goetz Lindenmaier wrote: >>> >> >> Okay, thanks. > > @D-D-H > Please follow the instructions for backports: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix > See point 6. You should only add the tag _after_ writing the corresponding comment in the JBS issue. Hi @GoeLin , Thanks for the reminder. But this fix is a new issue rather than a backport, do I still need to add a comment? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From goetz at openjdk.java.net Thu Feb 10 08:54:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Feb 2022 08:54:15 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 08:35:39 GMT, Denghui Dong wrote: >> @D-D-H >> Please follow the instructions for backports: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix >> See point 6. You should only add the tag _after_ writing the corresponding comment in the JBS issue. > > Hi @GoeLin , > > Thanks for the reminder. > But this fix is a new issue rather than a backport, do I still need to add a comment? > > And I found an issue(JDK-8277815) of 11u, it is also not a backport, and there is no "Fix request" comment. So, I'm not very sure... @D-D-H yes, please. Any change that goes to jdk11u-dev needs a jdk11u-fix-yes by the maintainers. The comment is the information we need to make a profound decision. It is your way to address the maintainers. The PR text addresses the reviewers (if you need any). Maybe I need to improve the documentation, I'll have a look. -- I checked, it expliciely says that for new fixes you need to follow the steps starting at 3. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From ddong at openjdk.java.net Thu Feb 10 09:07:09 2022 From: ddong at openjdk.java.net (Denghui Dong) Date: Thu, 10 Feb 2022 09:07:09 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 08:47:55 GMT, Goetz Lindenmaier wrote: >> Hi @GoeLin , >> >> Thanks for the reminder. >> But this fix is a new issue rather than a backport, do I still need to add a comment? >> >> And I found an issue(JDK-8277815) of 11u, it is also not a backport, and there is no "Fix request" comment. So, I'm not very sure... > > @D-D-H > yes, please. > Any change that goes to jdk11u-dev needs a jdk11u-fix-yes by the maintainers. > The comment is the information we need to make a profound decision. It is your > way to address the maintainers. The PR text addresses the reviewers (if you need any). > Maybe I need to improve the documentation, I'll have a look. -- I checked, it expliciely says > that for new fixes you need to follow the steps starting at 3. @GoeLin , Thanks, "Fix Request" is added. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From mdoerr at openjdk.java.net Thu Feb 10 09:31:21 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 09:31:21 GMT Subject: [jdk17u-dev] Integrated: 8281061: [s390] JFR runs into assertions while validating interpreter frames In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 18:08:07 GMT, Martin Doerr wrote: > Clean backport of JDK-8281061. This pull request has now been integrated. Changeset: a5d00fb0 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/a5d00fb089d8eecc5ac4265f83197b81e156ce7f Stats: 18 lines in 2 files changed: 2 ins; 3 del; 13 mod 8281061: [s390] JFR runs into assertions while validating interpreter frames Backport-of: 7f19c700707573000a37910dd6d2f2bb6e8439ad ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/149 From mdoerr at openjdk.java.net Thu Feb 10 09:37:07 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 09:37:07 GMT Subject: [jdk11u-dev] RFR: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks [v3] In-Reply-To: References: Message-ID: On Mon, 31 Jan 2022 16:25:59 GMT, Martin Doerr wrote: >> Backport of JDK-8279924. Applies cleanly except Copyright update. `is_in_stack_range_incl` needs to get replaced by 11u code like on other platforms (see 2nd commit). An old assertion is not compatible with this code and the removal needs to get backported (integrated with 3rd commit). > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Integrate bad assert removal from JDK-8254158 (x86 was already changed by JDK-8146546). Thanks for the reviews and the approvals. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/796 From duke at openjdk.java.net Thu Feb 10 09:37:13 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Thu, 10 Feb 2022 09:37:13 GMT Subject: [jdk11u-dev] RFR: 8280155: [PPC64, s390] frame size checks are not yet correct [v2] In-Reply-To: <786ujUMBMr5xSQBtBJVxu6EWmKkBcZ9e_8Pad-3nJtM=.474e8b98-299b-4ca7-9c48-7375414a1de8@github.com> References: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> <786ujUMBMr5xSQBtBJVxu6EWmKkBcZ9e_8Pad-3nJtM=.474e8b98-299b-4ca7-9c48-7375414a1de8@github.com> Message-ID: On Tue, 8 Feb 2022 18:10:49 GMT, Martin Doerr wrote: >> Backport of JDK-8280155. Applies cleanly except Copyright update. > > Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport f37bfeadcf036a75defc64ad7f4a9f5596cd7407 The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8280155_ppc64_s390_frame_checks git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/797 From mdoerr at openjdk.java.net Thu Feb 10 09:37:08 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 09:37:08 GMT Subject: [jdk11u-dev] Integrated: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks In-Reply-To: References: Message-ID: On Wed, 26 Jan 2022 11:59:40 GMT, Martin Doerr wrote: > Backport of JDK-8279924. Applies cleanly except Copyright update. `is_in_stack_range_incl` needs to get replaced by 11u code like on other platforms (see 2nd commit). An old assertion is not compatible with this code and the removal needs to get backported (integrated with 3rd commit). This pull request has now been integrated. Changeset: 6921496c Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/6921496c51985f6e49465fb3de18a32b431960da Stats: 122 lines in 5 files changed: 110 ins; 2 del; 10 mod 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks Reviewed-by: lucy, goetz Backport-of: c809d34f9ec0d8e9f77adc73ee772ce90efbe58d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/796 From mdoerr at openjdk.java.net Thu Feb 10 09:44:25 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 09:44:25 GMT Subject: [jdk11u-dev] RFR: 8280155: [PPC64, s390] frame size checks are not yet correct [v3] In-Reply-To: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> References: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> Message-ID: <0Pvytxv_VQyUjFuI1HQk5FhMoxckg4V4lnGfa-02CME=.348a23d9-bca1-437c-a42c-2c2526e265ca@github.com> > Backport of JDK-8280155. Applies cleanly except Copyright update. Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into 8280155_ppc64_s390_frame_checks2 - Backport f37bfeadcf036a75defc64ad7f4a9f5596cd7407 - Integrate bad assert removal from JDK-8254158 (x86 was already changed by JDK-8146546). - Replace is_in_stack_range_incl(locals, (address)fp()) by 11u code like on other platforms. - Backport c809d34f9ec0d8e9f77adc73ee772ce90efbe58d ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/797/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=797&range=02 Stats: 11 lines in 3 files changed: 4 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/797.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/797/head:pull/797 PR: https://git.openjdk.java.net/jdk11u-dev/pull/797 From matthias.baesken at sap.com Thu Feb 10 10:11:58 2022 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Thu, 10 Feb 2022 10:11:58 +0000 Subject: Heads up: planning to drop macos support older than 10.12 Message-ID: Hi Vladimir, this sounds okay for SapMachine 11 and for our internal OpenJDK 11 builds at SAP . Thanks for the heads up ! Best regards, Matthias ------------------------------ For one of the next jdk11 updates, an update to the minimally supported macos version is planned. Right now it?s macos 10.9, the plan is to move to macos 10.12 as minimally supported macos version. The similar patch was applied to jdk17 about an year ago: https://git.openjdk.java.net/jdk/commit/53f1b938 The JBS bug - https://bugs.openjdk.java.net/browse/JDK-8260518 Macos 10.9 through 10.14 are eol, and the oldest machines supported by 10.12 are from 2009/2010. Best regards, Vladimir From mdoerr at openjdk.java.net Thu Feb 10 10:25:16 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 10:25:16 GMT Subject: [jdk11u-dev] RFR: 8280155: [PPC64, s390] frame size checks are not yet correct [v3] In-Reply-To: <0Pvytxv_VQyUjFuI1HQk5FhMoxckg4V4lnGfa-02CME=.348a23d9-bca1-437c-a42c-2c2526e265ca@github.com> References: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> <0Pvytxv_VQyUjFuI1HQk5FhMoxckg4V4lnGfa-02CME=.348a23d9-bca1-437c-a42c-2c2526e265ca@github.com> Message-ID: On Thu, 10 Feb 2022 09:44:25 GMT, Martin Doerr wrote: >> Backport of JDK-8280155. Applies cleanly except Copyright update. > > Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Merge branch 'master' into 8280155_ppc64_s390_frame_checks2 > - Backport f37bfeadcf036a75defc64ad7f4a9f5596cd7407 > - Integrate bad assert removal from JDK-8254158 (x86 was already changed by JDK-8146546). > - Replace is_in_stack_range_incl(locals, (address)fp()) by 11u code like on other platforms. > - Backport c809d34f9ec0d8e9f77adc73ee772ce90efbe58d Still clean except Copyright. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/797 From mdoerr at openjdk.java.net Thu Feb 10 10:25:17 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 10:25:17 GMT Subject: [jdk11u-dev] Integrated: 8280155: [PPC64, s390] frame size checks are not yet correct In-Reply-To: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> References: <5n7qr1dPEEu_1_Z7p8Yh0BVMADx48WWGllzJ45psXSk=.b194f105-11ab-4745-998b-fadb0e5e6c4c@github.com> Message-ID: On Wed, 26 Jan 2022 12:04:57 GMT, Martin Doerr wrote: > Backport of JDK-8280155. Applies cleanly except Copyright update. This pull request has now been integrated. Changeset: 668c2003 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/668c20035de0ad0b355ecfcfd6b564d8ae6764ff Stats: 11 lines in 3 files changed: 4 ins; 1 del; 6 mod 8280155: [PPC64, s390] frame size checks are not yet correct Reviewed-by: lucy Backport-of: f37bfeadcf036a75defc64ad7f4a9f5596cd7407 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/797 From vkempik at openjdk.java.net Thu Feb 10 10:30:41 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 10 Feb 2022 10:30:41 GMT Subject: [jdk11u-dev] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2] In-Reply-To: References: Message-ID: > Please review this backport. Not applying clean. A follow up patch for jep-391 backport Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: Redo the fix, start trannsition earlier ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/817/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/817/files/f6c86be7..e175c0e9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=817&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=817&range=00-01 Stats: 12 lines in 1 file changed: 4 ins; 8 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/817.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/817/head:pull/817 PR: https://git.openjdk.java.net/jdk11u-dev/pull/817 From mdoerr at openjdk.java.net Thu Feb 10 10:33:28 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 10:33:28 GMT Subject: [jdk11u-dev] Integrated: 8281061: [s390] JFR runs into assertions while validating interpreter frames In-Reply-To: References: Message-ID: <0e9SCcVFhXbB3HwplE6P85_1bhGvVpRksalxUbRWy3E=.8d2c7c79-2823-46a6-b013-83f409b75bcb@github.com> On Tue, 8 Feb 2022 18:22:46 GMT, Martin Doerr wrote: > Mostly clean backport of JDK-8281061. Some hunks needed to get integrated manually due to different context. `is_in_full_stack` does not exist in 11u, so the `istate` in stack check line is different. Fix is the same. This pull request has now been integrated. Changeset: f4e14a68 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/f4e14a685ef4c8eb7c3f861b9c0bd981e5544c36 Stats: 18 lines in 2 files changed: 2 ins; 3 del; 13 mod 8281061: [s390] JFR runs into assertions while validating interpreter frames Reviewed-by: lucy, goetz Backport-of: 7f19c700707573000a37910dd6d2f2bb6e8439ad ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/811 From duke at openjdk.java.net Thu Feb 10 10:33:26 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Thu, 10 Feb 2022 10:33:26 GMT Subject: [jdk11u-dev] RFR: 8281061: [s390] JFR runs into assertions while validating interpreter frames In-Reply-To: References: Message-ID: <8jJGIxFfP6yd2vOKArquK9eLsXuOzLBgWyTldGw7gY8=.918df404-4cd8-4d3e-a17c-b1eae9cdd47b@github.com> On Tue, 8 Feb 2022 18:22:46 GMT, Martin Doerr wrote: > Mostly clean backport of JDK-8281061. Some hunks needed to get integrated manually due to different context. `is_in_full_stack` does not exist in 11u, so the `istate` in stack check line is different. Fix is the same. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8280155_ppc64_s390_frame_checks2 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/811 From mdoerr at openjdk.java.net Thu Feb 10 10:33:25 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 10:33:25 GMT Subject: [jdk11u-dev] RFR: 8281061: [s390] JFR runs into assertions while validating interpreter frames [v2] In-Reply-To: References: Message-ID: <1Sd32RNzfcTIYsW-0Ylhwt_QMV2fHhKOo9vzd2YwexQ=.f389529e-e761-4eec-bef8-1501322cfeec@github.com> > Mostly clean backport of JDK-8281061. Some hunks needed to get integrated manually due to different context. `is_in_full_stack` does not exist in 11u, so the `istate` in stack check line is different. Fix is the same. Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into 8280155_ppc64_s390_frame_checks3 - Backport 7f19c700707573000a37910dd6d2f2bb6e8439ad - Backport f37bfeadcf036a75defc64ad7f4a9f5596cd7407 - Integrate bad assert removal from JDK-8254158 (x86 was already changed by JDK-8146546). - Replace is_in_stack_range_incl(locals, (address)fp()) by 11u code like on other platforms. - Backport c809d34f9ec0d8e9f77adc73ee772ce90efbe58d ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/811/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=811&range=01 Stats: 18 lines in 2 files changed: 2 ins; 3 del; 13 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/811.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/811/head:pull/811 PR: https://git.openjdk.java.net/jdk11u-dev/pull/811 From akozlov at openjdk.java.net Thu Feb 10 10:47:10 2022 From: akozlov at openjdk.java.net (Anton Kozlov) Date: Thu, 10 Feb 2022 10:47:10 GMT Subject: [jdk11u-dev] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2] In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 10:30:41 GMT, Vladimir Kempik wrote: >> Please review this backport. Not applying clean. A follow up patch for jep-391 backport > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Redo the fix, start trannsition earlier Looks good. It's probably possible to move W^X flip under `thread->is_Java_thread()` condition, but the current code is safer. ------------- Marked as reviewed by akozlov (no project role). PR: https://git.openjdk.java.net/jdk11u-dev/pull/817 From adinn at openjdk.java.net Thu Feb 10 11:49:02 2022 From: adinn at openjdk.java.net (Andrew Dinn) Date: Thu, 10 Feb 2022 11:49:02 GMT Subject: [jdk11u-dev] RFR: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 21:35:38 GMT, Vladimir Kempik wrote: > Pleas review this backport to jdk11u-dev. > It's one of few follow up fixes for jep-391 backport. > This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread > Not applying clean due to context code difference in chunk 2. > In JDK17 it's - ThreadStateTransition::transition() > in JDK11 it's - ThreadStateTransition::transition_and_fence() Looks good ------------- Marked as reviewed by adinn (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/816 From goetz at openjdk.java.net Thu Feb 10 11:50:10 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Feb 2022 11:50:10 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 14:03:08 GMT, Martin Doerr wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 727: > >> 725: m(CKM_CHACHA20_POLY1305)); >> 726: >> 727: > > extra newline Fixed. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From adinn at openjdk.java.net Thu Feb 10 11:54:05 2022 From: adinn at openjdk.java.net (Andrew Dinn) Date: Thu, 10 Feb 2022 11:54:05 GMT Subject: [jdk11u-dev] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2] In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 10:30:41 GMT, Vladimir Kempik wrote: >> Please review this backport. Not applying clean. A follow up patch for jep-391 backport > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Redo the fix, start trannsition earlier Looks good ------------- Marked as reviewed by adinn (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/817 From goetz at openjdk.java.net Thu Feb 10 11:54:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Feb 2022 11:54:06 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 14:19:42 GMT, Martin Doerr wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 724: > >> 722: >> 723: d(CIP, "ChaCha20-Poly1305", P11AEADCipher, >> 724: s(), > > like above Both fixed. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From adinn at redhat.com Thu Feb 10 12:15:57 2022 From: adinn at redhat.com (Andrew Dinn) Date: Thu, 10 Feb 2022 12:15:57 +0000 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: Vote: yes On 09/02/2022 12:43, Yuri Nesterenko wrote: > I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project Reviewer. > > Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last 9 years on behalf of > Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) and drives the work on > backporting that JEP into jdk11u. > > Votes are due by Feb 23, 2022, 13:00 UTC. > > Only current JDK Updates Reviewers [6] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [7]. > > [0] https://openjdk.java.net/census#vkempik > [1] https://github.com/openjdk/jdk11u-dev/commits/master?author=vkempik%40openjdk.org > [2] https://github.com/openjdk/jdk13u-dev/commits/master?author=vkempik%40openjdk.org > [3] https://github.com/openjdk/jdk15u-dev/commits/master?author=vkempik%40openjdk.org > [4] https://github.com/openjdk/jdk17u-dev/commits/master?author=vkempik%40openjdk.org > [5] https://openjdk.java.net/jeps/391 > [6] https://openjdk.java.net/census#jdk-updates > [7] https://openjdk.java.net/bylaws#three-vote-consensus > -- regards, Andrew Dinn ----------- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill From dmitry.markov at oracle.com Thu Feb 10 12:38:58 2022 From: dmitry.markov at oracle.com (Dmitrii Markov) Date: Thu, 10 Feb 2022 12:38:58 +0000 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: <767D51A0-18AD-4FB4-8801-24A51C5A8A89@oracle.com> Vote: yes Regards, Dmitry > On 9 Feb 2022, at 12:43, Yuri Nesterenko wrote: > > I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project Reviewer. > > Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last 9 years on behalf of > Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) and drives the work on > backporting that JEP into jdk11u. > > Votes are due by Feb 23, 2022, 13:00 UTC. > > Only current JDK Updates Reviewers [6] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [7]. > > [0] https://openjdk.java.net/census#vkempik > [1] https://github.com/openjdk/jdk11u-dev/commits/master?author=vkempik%40openjdk.org > [2] https://github.com/openjdk/jdk13u-dev/commits/master?author=vkempik%40openjdk.org > [3] https://github.com/openjdk/jdk15u-dev/commits/master?author=vkempik%40openjdk.org > [4] https://github.com/openjdk/jdk17u-dev/commits/master?author=vkempik%40openjdk.org > [5] https://openjdk.java.net/jeps/391 > [6] https://openjdk.java.net/census#jdk-updates > [7] https://openjdk.java.net/bylaws#three-vote-consensus From goetz at openjdk.java.net Thu Feb 10 13:09:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Feb 2022 13:09:06 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 14:36:35 GMT, Martin Doerr wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_SALSA20_CHACHA20_POLY1305_PARAMS.java line 64: > >> 62: sb.append("0x"); >> 63: for (byte b: nonce) { >> 64: sb.append(String.format("0%02X", b)); > > other code uses `String.format("%02x", b & 0xff)`. I believe it gets converted to int with sign extend otherwise. Did you check the output? The formatter should get a java.lang.Byte. A simple test shows it's the same as HexFormat.of().formatHex(). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From goetz at openjdk.java.net Thu Feb 10 13:22:39 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Feb 2022 13:22:39 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.15-oracle. > > I had to do a row of adaptions. There are some implementation > differences, and many Java 17 usages that had to be changed. > > In the original change in SunPKCS11.java, dA() is used > to give alias names of algorithms. It calls to > SecurityProviderConstants.getAliases(). > In SunPKCS11.java of jdk11 neither dA() nore getAliases() > are available. It uses d() instead of da() and calls a > s() with a list of literal strings to give the alias names. > SecurityProviderConstants.java is in java.base. The jdk11 > version does not contain the list of aliases that can be > found in 17. > > I looked up whether there are aliases listed for > "ChaCha20-Poly1305" in 17, but found none, so I added > an empty call s() in SunPKCS11.java. > > In P11AEADCipher.java I had to modify the syntax of > a switch statement. > > In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java > I had to replace HexFormat.of().formatHex(...) > which is a java.util class not in 11. > > The tests use HexFormat heavily. > I replaced it by HexToBytes() from TestKATForGCM and > by toHexString() from TestLeadingZeroesP11.java. > To make these methods available I moved them to the > superclass PKCS11Test.java. > This way they can be used for potential later backports, too. > I also had to adapt a switch statement using '->' to syntax > know to 11. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Fixes proposed by Martin. CK_SALSA: also don't capitalize Hex - Backport 5d8c1cc8a05e0d9aedd6d54b8147d374c2290024 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/805/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=805&range=01 Stats: 1689 lines in 19 files changed: 1529 ins; 75 del; 85 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/805.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/805/head:pull/805 PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From mdoerr at openjdk.java.net Thu Feb 10 13:47:06 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 13:47:06 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v2] In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 13:22:39 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Fixes proposed by Martin. CK_SALSA: also don't capitalize Hex > - Backport 5d8c1cc8a05e0d9aedd6d54b8147d374c2290024 Please consider my proposal. Otherwise, good. Thanks for the backport work! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 635: > 633: d(AGP, "ChaCha20-Poly1305", > 634: "com.sun.crypto.provider.ChaCha20Poly1305Parameters", > 635: s("1.2.840.113549.1.9.16.3.18", "CHACHA20-POLY1305"), I've looked a bit more through the code and it seems like the algorithm name is compared case insensitive (`algorithm = algorithm.toUpperCase(Locale.ENGLISH);` in P11SecretKeyFactory.java). So, it seems like "CHACHA20-POLY1305" is redundant because it matches the original name (case insensitive). Other places have an extra entry starting with "OID". I'd use: `s("1.2.840.113549.1.9.16.3.18", "OID.1.2.840.113549.1.9.16.3.18")` which looks consistent with the remaining code. Maybe another reviewer can confirm this. src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 725: > 723: d(CIP, "ChaCha20-Poly1305", P11AEADCipher, > 724: s("1.2.840.113549.1.9.16.3.18", "CHACHA20-POLY1305"), > 725: m(CKM_CHACHA20_POLY1305)); like above ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From dchuyko at openjdk.java.net Thu Feb 10 14:25:18 2022 From: dchuyko at openjdk.java.net (Dmitry Chuyko) Date: Thu, 10 Feb 2022 14:25:18 GMT Subject: [jdk17u-dev] RFR: 8268231: Aarch64: Use Ldp in intrinsics for String.compareTo In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 14:48:40 GMT, Dmitry Chuyko wrote: > Original patch applies cleanly. > > Benchmark results of test/micro/org/openjdk/bench/java/lang/StringCompareToDifferentLength.java correspond to original issue, 10-25% 17u improvements on Graviton 2 for long enough strings (72+ chars). > > Testing: tier1, tier2 (aarch64). I think it is actually a win for many actual aarch64 implementations. For example here is a chart for L-L string comparison on A72 (RPi4) up to length 128. Starting from size 72 there is a constant 16-17% time reduction. If we go to really long strings there which can be considred a rare use, the improvement grows to 38% for size 256 and even over 50% for size 512. ![image](https://user-images.githubusercontent.com/31855791/153425712-1089f494-f0ae-4cb1-b5a8-f8d1a3b3eb9d.png) ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/91 From yan at openjdk.java.net Thu Feb 10 14:27:31 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Thu, 10 Feb 2022 14:27:31 GMT Subject: [jdk13u-dev] RFR: 8278309: [windows] use of uninitialized OSThread::_state Message-ID: It was easy to find where to patch src/hotspot/os/windows/os_windows.cpp but not automatically (because of context difference). ------------- Commit messages: - Backport 54993b13078ceb05736bb0e1d7ed7415c390442e Changes: https://git.openjdk.java.net/jdk13u-dev/pull/325/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=325&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278309 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/325.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/325/head:pull/325 PR: https://git.openjdk.java.net/jdk13u-dev/pull/325 From adinn at openjdk.java.net Thu Feb 10 14:32:20 2022 From: adinn at openjdk.java.net (Andrew Dinn) Date: Thu, 10 Feb 2022 14:32:20 GMT Subject: [jdk17u-dev] RFR: 8268231: Aarch64: Use Ldp in intrinsics for String.compareTo In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 14:48:40 GMT, Dmitry Chuyko wrote: > Original patch applies cleanly. > > Benchmark results of test/micro/org/openjdk/bench/java/lang/StringCompareToDifferentLength.java correspond to original issue, 10-25% 17u improvements on Graviton 2 for long enough strings (72+ chars). > > Testing: tier1, tier2 (aarch64). Thank you for that further input, Dmitry. I'll leave it to the maintainers to make the final decision. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/91 From mdoerr at openjdk.java.net Thu Feb 10 14:31:25 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 14:31:25 GMT Subject: [jdk11u-dev] RFR: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801 Message-ID: Cleanup after https://github.com/openjdk/jdk11u/commit/256c17f85328f5548b84b67b609afad9b89f026a. Test copy was introduced with backport of JDK-8153005: https://github.com/openjdk/jdk11u-dev/commit/596cc70c9724b31ffee454b7a21ecefec731c4ba ------------- Commit messages: - 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/818/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=818&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281599 Stats: 522 lines in 5 files changed: 3 ins; 516 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/818.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/818/head:pull/818 PR: https://git.openjdk.java.net/jdk11u-dev/pull/818 From yan at openjdk.java.net Thu Feb 10 14:34:17 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Thu, 10 Feb 2022 14:34:17 GMT Subject: [jdk13u-dev] Integrated: 8278309: [windows] use of uninitialized OSThread::_state In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 14:20:17 GMT, Yuri Nesterenko wrote: > It was easy to find where to patch src/hotspot/os/windows/os_windows.cpp but not automatically (because of context difference). This pull request has now been integrated. Changeset: 279be06e Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/279be06ec7bb54ade64c6055e9f9a05bb8a9f13b Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8278309: [windows] use of uninitialized OSThread::_state Backport-of: 54993b13078ceb05736bb0e1d7ed7415c390442e ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/325 From yan at openjdk.java.net Thu Feb 10 14:56:33 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Thu, 10 Feb 2022 14:56:33 GMT Subject: [jdk15u-dev] Integrated: 8278309: [windows] use of uninitialized OSThread::_state Message-ID: <6NZUqRK5GfhnxTDgpgRE2jWn4BnlfSjp5HAwvtAY3AU=.5a3c5f87-2c7c-4266-bd91-4550a60e2a86@github.com> clean backport of a simple useful fix ------------- Commit messages: - Backport 54993b13078ceb05736bb0e1d7ed7415c390442e Changes: https://git.openjdk.java.net/jdk15u-dev/pull/173/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=173&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278309 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/173.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/173/head:pull/173 PR: https://git.openjdk.java.net/jdk15u-dev/pull/173 From yan at openjdk.java.net Thu Feb 10 14:56:34 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Thu, 10 Feb 2022 14:56:34 GMT Subject: [jdk15u-dev] Integrated: 8278309: [windows] use of uninitialized OSThread::_state In-Reply-To: <6NZUqRK5GfhnxTDgpgRE2jWn4BnlfSjp5HAwvtAY3AU=.5a3c5f87-2c7c-4266-bd91-4550a60e2a86@github.com> References: <6NZUqRK5GfhnxTDgpgRE2jWn4BnlfSjp5HAwvtAY3AU=.5a3c5f87-2c7c-4266-bd91-4550a60e2a86@github.com> Message-ID: On Thu, 10 Feb 2022 14:41:50 GMT, Yuri Nesterenko wrote: > clean backport of a simple useful fix This pull request has now been integrated. Changeset: 5fb0e1af Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/5fb0e1af099db7b8746b8d44fba7d987a945b7bb Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8278309: [windows] use of uninitialized OSThread::_state Backport-of: 54993b13078ceb05736bb0e1d7ed7415c390442e ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/173 From phh at openjdk.java.net Thu Feb 10 15:00:05 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 10 Feb 2022 15:00:05 GMT Subject: [jdk11u-dev] RFR: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801 In-Reply-To: References: Message-ID: <3Ih28e7DRFNpGgqZroAFwIq91IsfwKTxTkByBOJTcwo=.25d3de96-2864-4650-8356-a8d521a1a59e@github.com> On Thu, 10 Feb 2022 14:16:44 GMT, Martin Doerr wrote: > Cleanup after https://github.com/openjdk/jdk11u/commit/256c17f85328f5548b84b67b609afad9b89f026a. > Test copy was introduced with backport of JDK-8153005: https://github.com/openjdk/jdk11u-dev/commit/596cc70c9724b31ffee454b7a21ecefec731c4ba Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/818 From andrew at openjdk.java.net Thu Feb 10 16:11:25 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Thu, 10 Feb 2022 16:11:25 GMT Subject: [jdk17u-dev] RFR: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication In-Reply-To: <96WJt39G8ACNEqygcI7tJSnSHH1vh2AkjuOYFOY-y0o=.ec0eceac-984f-4126-ad36-98aed599fb7a@github.com> References: <96WJt39G8ACNEqygcI7tJSnSHH1vh2AkjuOYFOY-y0o=.ec0eceac-984f-4126-ad36-98aed599fb7a@github.com> Message-ID: On Wed, 9 Feb 2022 15:56:59 GMT, Andrew John Hughes wrote: > Clean backport. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. Failed test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 seems unrelated to this change. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/154 From goetz at openjdk.java.net Thu Feb 10 18:34:19 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Feb 2022 18:34:19 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: On Fri, 24 Dec 2021 17:23:26 GMT, Alexey Pavlyutkin wrote: > This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u > > I'd like to backport JDK-8274471 to jdk17u-dev > > The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS > > The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) > - imported few required packages > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security Hi Alexey, you may not integrate as long as you don't have jdk17u-fix-yes label on the JBS issue. Please see https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix for how to contribute backports and changes. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From mdoerr at openjdk.java.net Thu Feb 10 18:44:09 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Feb 2022 18:44:09 GMT Subject: [jdk11u-dev] RFR: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801 In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 14:16:44 GMT, Martin Doerr wrote: > Cleanup after https://github.com/openjdk/jdk11u/commit/256c17f85328f5548b84b67b609afad9b89f026a. > Test copy was introduced with backport of JDK-8153005: https://github.com/openjdk/jdk11u-dev/commit/596cc70c9724b31ffee454b7a21ecefec731c4ba Thanks for the review! A second one would be nice since this is not a backport. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/818 From dchuyko at openjdk.java.net Thu Feb 10 20:15:33 2022 From: dchuyko at openjdk.java.net (Dmitry Chuyko) Date: Thu, 10 Feb 2022 20:15:33 GMT Subject: [jdk17u-dev] RFR: 8271579: G1: Move copy before CAS in do_copy_to_survivor_space In-Reply-To: <4o3GGnIv2fF6QemMphQktNCIifTMiyFi_NK3m_C2jmI=.1f3b389a-6fbc-4744-a16c-27a4b5412269@github.com> References: <4o3GGnIv2fF6QemMphQktNCIifTMiyFi_NK3m_C2jmI=.1f3b389a-6fbc-4744-a16c-27a4b5412269@github.com> Message-ID: On Wed, 29 Dec 2021 15:58:57 GMT, Dmitry Chuyko wrote: > Small change in G1 with good performance effect. Original patch applies cleanly. > > Testing: jtreg tier1 & gc (aarch64 build). No failures in test/hotspot/jtreg/applications/jcstress on Graviton2, 64 cpus. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/42 From christoph.langer at sap.com Thu Feb 10 21:37:46 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 10 Feb 2022 21:37:46 +0000 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: Vote: yes /Christoph > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Yuri Nesterenko > Sent: Mittwoch, 9. Februar 2022 13:43 > To: jdk-updates-dev at openjdk.java.net > Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik > > I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project > Reviewer. > > Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last > 9 years on behalf of Oracle and Azul. He has co-authored JEP-391 [5] (macos- > aarch64 support) and drives the work on backporting that JEP into jdk11u. > > Votes are due by Feb 23, 2022, 13:00 UTC. > > Only current JDK Updates Reviewers [6] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [7]. > > [0] https://openjdk.java.net/census#vkempik > [1] https://github.com/openjdk/jdk11u- > dev/commits/master?author=vkempik%40openjdk.org > [2] https://github.com/openjdk/jdk13u- > dev/commits/master?author=vkempik%40openjdk.org > [3] https://github.com/openjdk/jdk15u- > dev/commits/master?author=vkempik%40openjdk.org > [4] https://github.com/openjdk/jdk17u- > dev/commits/master?author=vkempik%40openjdk.org > [5] https://openjdk.java.net/jeps/391 > [6] https://openjdk.java.net/census#jdk-updates > [7] https://openjdk.java.net/bylaws#three-vote-consensus From vladimir.x.ivanov at oracle.com Thu Feb 10 21:48:28 2022 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Fri, 11 Feb 2022 00:48:28 +0300 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: <607c7192-8fdc-00cb-e39d-3099595ce8f8@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 09.02.2022 15:43, Yuri Nesterenko wrote: > I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project Reviewer. From duke at openjdk.java.net Thu Feb 10 22:14:42 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Thu, 10 Feb 2022 22:14:42 GMT Subject: [jdk11u-dev] RFR: 8241004: NMT tests fail on unaligned thread size with debug build Message-ID: Backport of [JDK-8241004](https://bugs.openjdk.java.net/browse/JDK-8241004). Applies cleanly. This is will prevent hotspot runtime/NMT test failures on mac-aarch64. See issue 2 in this comment for more context: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1020401252 ------------- Commit messages: - Backport 0b20eafb30cc1de372141f2a427d13fdc6565e3a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/812/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=812&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8241004 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/812.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/812/head:pull/812 PR: https://git.openjdk.java.net/jdk11u-dev/pull/812 From rkovacs at openjdk.java.net Fri Feb 11 00:55:47 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 11 Feb 2022 00:55:47 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v3] In-Reply-To: References: Message-ID: > Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: > > - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. > - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. > - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). > - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. > - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) > > This is part of the Windows/AArch64 port. Reka Kovacs has updated the pull request incrementally with three additional commits since the last revision: - Use size_t in generate_disjoint_copy - Explain disabled MSVC warning C4146 in comment - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/280/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/280/files/d7975df8..09587d5e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=280&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=280&range=01-02 Stats: 10 lines in 4 files changed: 5 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/280.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/280/head:pull/280 PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From rkovacs at openjdk.java.net Fri Feb 11 01:07:15 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 11 Feb 2022 01:07:15 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2] In-Reply-To: <8kObCbGVy2dooJ_1k8Y30-ZTFwz_IkhHc5qW_aEGUyg=.f140151a-942c-44cc-9d91-95b5ed9ff5d2@github.com> References: <8kObCbGVy2dooJ_1k8Y30-ZTFwz_IkhHc5qW_aEGUyg=.f140151a-942c-44cc-9d91-95b5ed9ff5d2@github.com> Message-ID: On Tue, 5 Oct 2021 08:29:20 GMT, Andrew Haley wrote: >> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> Backport d2812f780e87511736f2d41bc57a69c2a898b583 > > make/hotspot/lib/CompileGtest.gmk line 81: > >> 79: tautological-undefined-compare $(BUILD_LIBJVM_DISABLED_WARNINGS_clang), \ >> 80: DISABLED_WARNINGS_solstudio := identexpected, \ >> 81: DISABLED_WARNINGS_microsoft := 4146, \ > > What does this do? Need a comment here. Added comments to both cases. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From rkovacs at openjdk.java.net Fri Feb 11 01:12:15 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 11 Feb 2022 01:12:15 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v3] In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 00:55:47 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request incrementally with three additional commits since the last revision: > > - Use size_t in generate_disjoint_copy > - Explain disabled MSVC warning C4146 in comment > - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits Sorry for the delay. The new changes are: - a [one-character fix](https://github.com/openjdk/jdk11u-dev/pull/280/commits/83b002996dd162601926f506ec9d4b513987161f) for a bitshift warning that's new since the previous iteration - [added comments](https://github.com/openjdk/jdk11u-dev/pull/280/commits/4c800447cac021ef52c44beb165c724975c8cd6d) to explain the disabled warning about unary minus operations - [switched back the parameter type to `size_t`](https://github.com/openjdk/jdk11u-dev/pull/280/commits/09587d5e38d8bdd2ad70a585ace7c156c9be1418) in the stub generator ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From rkovacs at openjdk.java.net Fri Feb 11 01:17:11 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 11 Feb 2022 01:17:11 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2] In-Reply-To: <8kObCbGVy2dooJ_1k8Y30-ZTFwz_IkhHc5qW_aEGUyg=.f140151a-942c-44cc-9d91-95b5ed9ff5d2@github.com> References: <8kObCbGVy2dooJ_1k8Y30-ZTFwz_IkhHc5qW_aEGUyg=.f140151a-942c-44cc-9d91-95b5ed9ff5d2@github.com> Message-ID: On Tue, 5 Oct 2021 08:34:44 GMT, Andrew Haley wrote: >> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> Backport d2812f780e87511736f2d41bc57a69c2a898b583 > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 1336: > >> 1334: // used by generate_conjoint_int_oop_copy(). >> 1335: // >> 1336: address generate_disjoint_copy(int size, bool aligned, bool is_oop, address *entry, > > size_t is correct here. I switched back: https://github.com/openjdk/jdk11u-dev/pull/280/commits/09587d5e38d8bdd2ad70a585ace7c156c9be1418 This way, however, I had to add casts to the two call sites where `size` is used, to avoid a `size_t` to `int` truncation warning ([C4267](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4267?view=msvc-170)). Both calls expect integers. Making `size` an `int` here avoided both the warning and the casts. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From goetz at openjdk.java.net Fri Feb 11 07:15:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Feb 2022 07:15:07 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: References: Message-ID: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> > I backport this for parity with 11.0.15-oracle. > > I had to do a row of adaptions. There are some implementation > differences, and many Java 17 usages that had to be changed. > > In the original change in SunPKCS11.java, dA() is used > to give alias names of algorithms. It calls to > SecurityProviderConstants.getAliases(). > In SunPKCS11.java of jdk11 neither dA() nore getAliases() > are available. It uses d() instead of da() and calls a > s() with a list of literal strings to give the alias names. > SecurityProviderConstants.java is in java.base. The jdk11 > version does not contain the list of aliases that can be > found in 17. > > I looked up whether there are aliases listed for > "ChaCha20-Poly1305" in 17, but found none, so I added > an empty call s() in SunPKCS11.java. > > In P11AEADCipher.java I had to modify the syntax of > a switch statement. > > In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java > I had to replace HexFormat.of().formatHex(...) > which is a java.util class not in 11. > > The tests use HexFormat heavily. > I replaced it by HexToBytes() from TestKATForGCM and > by toHexString() from TestLeadingZeroesP11.java. > To make these methods available I moved them to the > superclass PKCS11Test.java. > This way they can be used for potential later backports, too. > I also had to adapt a switch statement using '->' to syntax > know to 11. Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: - One more tiny detail - These changes sneaked in from anonther backport ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/805/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/805/files/e5dea49a..7a7ba53d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=805&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=805&range=01-02 Stats: 6 lines in 1 file changed: 0 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/805.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/805/head:pull/805 PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From shade at redhat.com Fri Feb 11 07:17:52 2022 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 11 Feb 2022 10:17:52 +0300 Subject: [11u] RFC: Stack dump improvements In-Reply-To: <533469b8-352d-1865-9a57-71050c2b5d98@redhat.com> References: <533469b8-352d-1865-9a57-71050c2b5d98@redhat.com> Message-ID: <92a75454-e071-9290-034a-335b7a68efbb@redhat.com> On 2/2/22 12:50, Aleksey Shipilev wrote: > On 2/1/22 17:07, Lindenmaier, Goetz wrote: >> I think this are useful improvements to the thread dumps >> which are also on our side heavily used. >> The changes are of limited scope, I would not expect >> any problems with this. > > Thanks for the input! I'd like to see other 11u maintainers to chime in too, before I invest time in > backporting the whole patch chain :) > > I realized I should have uploaded the combined patch to demonstrate where the changes are. The > substantial changes are in stack printing code, which makes the patches low risk. Here it is: > https://cr.openjdk.java.net/~shade/11u-stack-info/combined.patch Any other comments? Should I suggest these backports? -- Thanks, -Aleksey From clanger at openjdk.java.net Fri Feb 11 07:52:09 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 11 Feb 2022 07:52:09 GMT Subject: [jdk11u-dev] RFR: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801 In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 14:16:44 GMT, Martin Doerr wrote: > Cleanup after https://github.com/openjdk/jdk11u/commit/256c17f85328f5548b84b67b609afad9b89f026a. > Test copy was introduced with backport of JDK-8153005: https://github.com/openjdk/jdk11u-dev/commit/596cc70c9724b31ffee454b7a21ecefec731c4ba Good to see this cleaned up. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/818 From shade at openjdk.java.net Fri Feb 11 08:00:40 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Feb 2022 08:00:40 GMT Subject: [jdk11u-dev] RFR: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 Message-ID: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> Unclean backport to fix the x86_32 problem. It is not clean, because Panama is not in 11u, so context in `.ad` is different. Additional testing: - [x] Linux x86_32 fails new test without the fix, passes with it ------------- Commit messages: - Backport 9d5ae2e38074c3df354aeab19ebbab7d4872165a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/819/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=819&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279076 Stats: 64 lines in 2 files changed: 64 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/819.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/819/head:pull/819 PR: https://git.openjdk.java.net/jdk11u-dev/pull/819 From goetz at openjdk.java.net Fri Feb 11 08:16:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Feb 2022 08:16:08 GMT Subject: [jdk11u-dev] Integrated: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently In-Reply-To: <0cEcGpMNf8eTttnuS3vi45Bf0fsG_YWfVvPNx4ibI0k=.be329394-ade5-452a-aaa4-0f26a9d65e04@github.com> References: <0cEcGpMNf8eTttnuS3vi45Bf0fsG_YWfVvPNx4ibI0k=.be329394-ade5-452a-aaa4-0f26a9d65e04@github.com> Message-ID: On Wed, 9 Feb 2022 09:31:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. This pull request has now been integrated. Changeset: 6c26ba25 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/6c26ba2599a08ef65270ade24c93f521a24fd796 Stats: 12 lines in 2 files changed: 6 ins; 0 del; 6 mod 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently Backport-of: f1c20e91d822c6df4c5da895f2abd6305e00bf8b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/814 From goetz at openjdk.java.net Fri Feb 11 08:36:04 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Feb 2022 08:36:04 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> Message-ID: On Fri, 11 Feb 2022 07:15:07 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: > > - One more tiny detail > - These changes sneaked in from anonther backport Hi, I would appreciate a second review. Does anyone have an opinion on the aliases? @martinuy If I remember correctly you have made changes to the security files in the past. Could you have a look? Or @shipilev or @zhengyu123, would you find time? Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From shade at openjdk.java.net Fri Feb 11 08:36:04 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Feb 2022 08:36:04 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> Message-ID: On Fri, 11 Feb 2022 08:30:57 GMT, Goetz Lindenmaier wrote: > Hi, I would appreciate a second review. Does anyone have an opinion on the aliases? @martinuy If I remember correctly you have made changes to the security files in the past. Could you have a look? Or @shipilev or @zhengyu123, would you find time? Thanks! @martinuy is our security expert, please wait for him to reply :) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From roland at openjdk.java.net Fri Feb 11 08:57:04 2022 From: roland at openjdk.java.net (Roland Westrelin) Date: Fri, 11 Feb 2022 08:57:04 GMT Subject: [jdk11u-dev] RFR: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 In-Reply-To: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> References: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> Message-ID: On Fri, 11 Feb 2022 07:53:05 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the x86_32 problem. It is not clean, because Panama is not in 11u, so context in `.ad` is different. > > Additional testing: > - [x] Linux x86_32 fails new test without the fix, passes with it Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/819 From shade at openjdk.java.net Fri Feb 11 08:59:32 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Feb 2022 08:59:32 GMT Subject: [jdk11u-dev] RFR: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} Message-ID: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> Follow up to JDK-8279076 backport. Additional testing: - [x] The test from JDK-8279076 still passes ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/819 Commit messages: - Backport a24f44d17de586c72c8343f8891e72ad8a514597 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/820/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=820&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280526 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/820.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/820/head:pull/820 PR: https://git.openjdk.java.net/jdk11u-dev/pull/820 From goetz at openjdk.java.net Fri Feb 11 09:02:54 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Feb 2022 09:02:54 GMT Subject: [jdk17u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 Message-ID: I backport this for parity with 17.0.3-oracle. ------------- Commit messages: - Backport 35172cdaf38d83cd3ed57a5436bf985dde2d802b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/155/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=155&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278951 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/155.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/155/head:pull/155 PR: https://git.openjdk.java.net/jdk17u-dev/pull/155 From mdoerr at openjdk.java.net Fri Feb 11 09:08:04 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Feb 2022 09:08:04 GMT Subject: [jdk11u-dev] Integrated: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801 In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 14:16:44 GMT, Martin Doerr wrote: > Cleanup after https://github.com/openjdk/jdk11u/commit/256c17f85328f5548b84b67b609afad9b89f026a. > Test copy was introduced with backport of JDK-8153005: https://github.com/openjdk/jdk11u-dev/commit/596cc70c9724b31ffee454b7a21ecefec731c4ba This pull request has now been integrated. Changeset: d79e7105 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/d79e7105cffe16d8e8ffff88eb14e263bc55806a Stats: 522 lines in 5 files changed: 3 ins; 516 del; 3 mod 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801 Reviewed-by: phh, clanger ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/818 From mdoerr at openjdk.java.net Fri Feb 11 09:08:04 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Feb 2022 09:08:04 GMT Subject: [jdk11u-dev] RFR: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801 In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 14:16:44 GMT, Martin Doerr wrote: > Cleanup after https://github.com/openjdk/jdk11u/commit/256c17f85328f5548b84b67b609afad9b89f026a. > Test copy was introduced with backport of JDK-8153005: https://github.com/openjdk/jdk11u-dev/commit/596cc70c9724b31ffee454b7a21ecefec731c4ba Thanks for the 2nd review! Tests have passed. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/818 From mdoerr at openjdk.java.net Fri Feb 11 09:15:14 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Feb 2022 09:15:14 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> Message-ID: On Fri, 11 Feb 2022 07:15:07 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: > > - One more tiny detail > - These changes sneaked in from anonther backport For the 2nd reviewer: I had proposed to use `s("1.2.840.113549.1.9.16.3.18", "OID.1.2.840.113549.1.9.16.3.18")` to be more consistent with jdk11. Please check. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From simonis at openjdk.java.net Fri Feb 11 09:54:11 2022 From: simonis at openjdk.java.net (Volker Simonis) Date: Fri, 11 Feb 2022 09:54:11 GMT Subject: [jdk17u] RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories In-Reply-To: References: Message-ID: <6qGdWpJgfyKYihu7p5dV5giT9SrAKHHjZ0CkniKgrwo=.470f546f-9fc1-405a-ab10-9e857e3f2047@github.com> On Tue, 30 Nov 2021 00:03:32 GMT, Mandy Chung wrote: > This pull request contains a backport of commit 7e54d065 from the openjdk/jdk repository. > > The commit being backported was authored by Mandy Chung on 26 Nov 2021 and was reviewed by Jorn Vernee and Alan Bateman. > > Thanks! What's the state of this downport? We have a customer who is affected by this problem and would like to fix it in 17. As far as I understand @GoeLin, this PR should be redone in jdk17u-dev, right? @mlchung, do you want to do that or is it fine if I pick it up? ------------- PR: https://git.openjdk.java.net/jdk17u/pull/314 From christoph.langer at sap.com Fri Feb 11 10:08:07 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 11 Feb 2022 10:08:07 +0000 Subject: [11u] RFC: Stack dump improvements In-Reply-To: <92a75454-e071-9290-034a-335b7a68efbb@redhat.com> References: <533469b8-352d-1865-9a57-71050c2b5d98@redhat.com> <92a75454-e071-9290-034a-335b7a68efbb@redhat.com> Message-ID: Hi Aleksey, I just went over the items and I agree that it's feasible/desirable for JDK11. So go ahead, from my POV. Cheers Christoph > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Aleksey Shipilev > Sent: Freitag, 11. Februar 2022 08:18 > To: Lindenmaier, Goetz ; jdk-updates- > dev at openjdk.java.net > Subject: Re: [11u] RFC: Stack dump improvements > > On 2/2/22 12:50, Aleksey Shipilev wrote: > > On 2/1/22 17:07, Lindenmaier, Goetz wrote: > >> I think this are useful improvements to the thread dumps which are > >> also on our side heavily used. > >> The changes are of limited scope, I would not expect any problems > >> with this. > > > > Thanks for the input! I'd like to see other 11u maintainers to chime > > in too, before I invest time in backporting the whole patch chain :) > > > > I realized I should have uploaded the combined patch to demonstrate > > where the changes are. The substantial changes are in stack printing code, > which makes the patches low risk. Here it is: > > https://cr.openjdk.java.net/~shade/11u-stack-info/combined.patch > > Any other comments? Should I suggest these backports? > > -- > Thanks, > -Aleksey From mbaesken at openjdk.java.net Fri Feb 11 10:44:42 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 11 Feb 2022 10:44:42 GMT Subject: [jdk17u-dev] RFR: 8273655: content-types.properties files are missing some common types Message-ID: 8273655: content-types.properties files are missing some common types ------------- Commit messages: - Backport 65ed0a742e65fe7e661e8da2adea6cd41992869e Changes: https://git.openjdk.java.net/jdk17u-dev/pull/156/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=156&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273655 Stats: 227 lines in 3 files changed: 193 ins; 13 del; 21 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/156.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/156/head:pull/156 PR: https://git.openjdk.java.net/jdk17u-dev/pull/156 From abakhtin at openjdk.java.net Fri Feb 11 10:45:54 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Fri, 11 Feb 2022 10:45:54 GMT Subject: [jdk17u-dev] RFR: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key Message-ID: <32YOsWV_EmPLCiLS8OH3EDeMc23oxWllFV63S5fBZEo=.ee42d4d8-3a60-4747-94f7-02562d77f389@github.com> This is a clean backport of JDK-8271199 to JDK17u-dev ------------- Commit messages: - Backport f6232982b91cb2314e96ddbde3984836a810a556 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/157/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=157&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271199 Stats: 89 lines in 2 files changed: 69 ins; 14 del; 6 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/157.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/157/head:pull/157 PR: https://git.openjdk.java.net/jdk17u-dev/pull/157 From mbaesken at openjdk.java.net Fri Feb 11 10:50:48 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 11 Feb 2022 10:50:48 GMT Subject: [jdk17u-dev] RFR: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 Message-ID: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 ------------- Commit messages: - Backport 01f93ddf18daea5c0798ac949c6717c37d9cefa0 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/158/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=158&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279385 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/158.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/158/head:pull/158 PR: https://git.openjdk.java.net/jdk17u-dev/pull/158 From mbaesken at openjdk.java.net Fri Feb 11 11:01:46 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 11 Feb 2022 11:01:46 GMT Subject: [jdk17u-dev] RFR: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 Message-ID: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 ------------- Commit messages: - Backport c180070cb59b8e075376ae913c5db9a4ed868303 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/159/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=159&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280373 Stats: 5 lines in 1 file changed: 2 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/159.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/159/head:pull/159 PR: https://git.openjdk.java.net/jdk17u-dev/pull/159 From mbaesken at openjdk.java.net Fri Feb 11 11:40:39 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 11 Feb 2022 11:40:39 GMT Subject: [jdk11u-dev] RFR: 8280414: Memory leak in DefaultProxySelector Message-ID: 8280414: Memory leak in DefaultProxySelector ------------- Commit messages: - Backport fe77250fa450ec803d2818dc90c5bf156521d537 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/821/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=821&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280414 Stats: 11 lines in 1 file changed: 1 ins; 3 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/821.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/821/head:pull/821 PR: https://git.openjdk.java.net/jdk11u-dev/pull/821 From ddong at openjdk.java.net Fri Feb 11 14:08:11 2022 From: ddong at openjdk.java.net (Denghui Dong) Date: Fri, 11 Feb 2022 14:08:11 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 02:43:06 GMT, Paul Hohensee wrote: > No need for another review, but you have to go through the usual process of tagging the issue, adding a Fix Request comment, and getting it approved before I can sponsor it. Got approved, please help sponsor it when you have time, thanks in advance! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From phh at openjdk.java.net Fri Feb 11 15:09:08 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 11 Feb 2022 15:09:08 GMT Subject: [jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 06:53:33 GMT, Denghui Dong wrote: > Hi team, > > Could I have a review of this fix? > > The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter: > > 387 } else { > 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload); > 389 CompositeKlassWriter ckw(&lkw, &kw); > 390 CompositeKlassWriterRegistration ckwr(&ckw, ®); > 391 CompositeKlassCallback callback(&ckwr); > 392 _subsystem_callback = &callback; > 393 do_klasses(); > 394 } > > > This problem is introduced by JDK-8225797 and fixed by JDK-8233111. > > I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment. > > testing: test/jdk/jdk/jfr > > Thanks, > Denghui Please add a "/integrate" comment. Then I can sponsor it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From aph at openjdk.java.net Fri Feb 11 16:32:04 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Fri, 11 Feb 2022 16:32:04 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v3] In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 00:55:47 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request incrementally with three additional commits since the last revision: > > - Use size_t in generate_disjoint_copy > - Explain disabled MSVC warning C4146 in comment > - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 1477: > 1475: if (UseStackBanging) { > 1476: assert(JavaThread::stack_shadow_zone_size() == (unsigned long)(int)JavaThread::stack_shadow_zone_size(), "must be same"); > 1477: __ bang_stack_with_offset((int)JavaThread::stack_shadow_zone_size()); Suggestion: __ bang_stack_with_offset(checked_cast(JavaThread::stack_shadow_zone_size())); ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From aph at openjdk.java.net Fri Feb 11 16:38:11 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Fri, 11 Feb 2022 16:38:11 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v3] In-Reply-To: References: Message-ID: <-7YzwrtRtjESHaSFX2UOCnR7iP2AuTxdPIihXeMzMcw=.dfbc3979-7800-49ad-9f73-57a189887f04@github.com> On Fri, 11 Feb 2022 00:55:47 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request incrementally with three additional commits since the last revision: > > - Use size_t in generate_disjoint_copy > - Explain disabled MSVC warning C4146 in comment > - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits If you replace all of the `int` casts with `checked_cast`, I'll approve this. src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 1366: > 1364: __ push(RegSet::of(d, count), sp); > 1365: } > 1366: copy_memory(aligned, s, d, count, rscratch1, (int)size); Suggestion: copy_memory(aligned, s, d, count, rscratch1, checked_cast(size)); src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 1371: > 1369: __ pop(RegSet::of(d, count), sp); > 1370: if (VerifyOops) > 1371: verify_oop_array((int)size, d, count, r16); Likewise use `checked_cast`. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From jboes at openjdk.java.net Fri Feb 11 16:48:13 2022 From: jboes at openjdk.java.net (Julia Boes) Date: Fri, 11 Feb 2022 16:48:13 GMT Subject: [jdk17u-dev] RFR: 8273655: content-types.properties files are missing some common types In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 10:35:57 GMT, Matthias Baesken wrote: > 8273655: content-types.properties files are missing some common types LGTM once the copyright year in the test is fixed. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/156 From ddong at openjdk.java.net Fri Feb 11 16:51:14 2022 From: ddong at openjdk.java.net (Denghui Dong) Date: Fri, 11 Feb 2022 16:51:14 GMT Subject: [jdk11u-dev] Integrated: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 06:53:33 GMT, Denghui Dong wrote: > Hi team, > > Could I have a review of this fix? > > The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter: > > 387 } else { > 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload); > 389 CompositeKlassWriter ckw(&lkw, &kw); > 390 CompositeKlassWriterRegistration ckwr(&ckw, ®); > 391 CompositeKlassCallback callback(&ckwr); > 392 _subsystem_callback = &callback; > 393 do_klasses(); > 394 } > > > This problem is introduced by JDK-8225797 and fixed by JDK-8233111. > > I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment. > > testing: test/jdk/jdk/jfr > > Thanks, > Denghui This pull request has now been integrated. Changeset: 29eb422c Author: Denghui Dong Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/29eb422cb843e76c31bd9b3253359ceccb48082b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter Reviewed-by: phh ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/813 From mchung at openjdk.java.net Fri Feb 11 17:52:25 2022 From: mchung at openjdk.java.net (Mandy Chung) Date: Fri, 11 Feb 2022 17:52:25 GMT Subject: [jdk17u] RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories In-Reply-To: <6qGdWpJgfyKYihu7p5dV5giT9SrAKHHjZ0CkniKgrwo=.470f546f-9fc1-405a-ab10-9e857e3f2047@github.com> References: <6qGdWpJgfyKYihu7p5dV5giT9SrAKHHjZ0CkniKgrwo=.470f546f-9fc1-405a-ab10-9e857e3f2047@github.com> Message-ID: On Fri, 11 Feb 2022 09:51:06 GMT, Volker Simonis wrote: >> This pull request contains a backport of commit 7e54d065 from the openjdk/jdk repository. >> >> The commit being backported was authored by Mandy Chung on 26 Nov 2021 and was reviewed by Jorn Vernee and Alan Bateman. >> >> Thanks! > > What's the state of this downport? We have a customer who is affected by this problem and would like to fix it in 17. > > As far as I understand @GoeLin, this PR should be redone in jdk17u-dev, right? > > @mlchung, do you want to do that or is it fine if I pick it up? @simonis please go ahead and do the backport to jdk17-dev. I'll close this PR. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/314 From mchung at openjdk.java.net Fri Feb 11 17:52:28 2022 From: mchung at openjdk.java.net (Mandy Chung) Date: Fri, 11 Feb 2022 17:52:28 GMT Subject: [jdk17u] Withdrawn: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories In-Reply-To: References: Message-ID: On Tue, 30 Nov 2021 00:03:32 GMT, Mandy Chung wrote: > This pull request contains a backport of commit 7e54d065 from the openjdk/jdk repository. > > The commit being backported was authored by Mandy Chung on 26 Nov 2021 and was reviewed by Jorn Vernee and Alan Bateman. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/314 From kvn at openjdk.java.net Fri Feb 11 17:58:16 2022 From: kvn at openjdk.java.net (Vladimir Kozlov) Date: Fri, 11 Feb 2022 17:58:16 GMT Subject: [jdk11u-dev] RFR: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 In-Reply-To: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> References: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> Message-ID: On Fri, 11 Feb 2022 07:53:05 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the x86_32 problem. It is not clean, because Panama is not in 11u, so context in `.ad` is different. > > Additional testing: > - [x] Linux x86_32 fails new test without the fix, passes with it Marked as reviewed by kvn (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/819 From kvn at openjdk.java.net Fri Feb 11 18:00:17 2022 From: kvn at openjdk.java.net (Vladimir Kozlov) Date: Fri, 11 Feb 2022 18:00:17 GMT Subject: [jdk11u-dev] RFR: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} In-Reply-To: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> References: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> Message-ID: On Fri, 11 Feb 2022 08:51:59 GMT, Aleksey Shipilev wrote: > Follow up to JDK-8279076 backport. > > Additional testing: > - [x] The test from JDK-8279076 still passes Marked as reviewed by kvn (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/820 From duke at openjdk.java.net Fri Feb 11 19:01:16 2022 From: duke at openjdk.java.net (aamarsh) Date: Fri, 11 Feb 2022 19:01:16 GMT Subject: [jdk17u-dev] RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits [v3] In-Reply-To: References: Message-ID: <3Q0L50ejHUmAoU0Htb1bRONRINok-qK_CJWnBzsZv-g=.7f333e9a-7b07-48e8-9e3b-26cc9a067fdc@github.com> On Fri, 28 Jan 2022 07:02:48 GMT, Goetz Lindenmaier wrote: >> Fix request 17u: This backport avoids a stack overflow in Windows 32 bit binaries, which some external contributors release. Additionally this is a nice change for Windows 64 bit binaries as well, even though the larger stack size has avoided the problem. The risk is low, simply placing two variables on the heap instead of the stack. Additionally, Tier1 and the newly added test passes on Windows after the changes. > > @aamarsh, the comment needs to go to the JBS issue. Just have a look at the other changes recently pushed to 17u-dev. @GoeLin Thanks for helping me through the backporting process! I see that the jdk17u-fix-yes tag is now on the JBS issue, so I have integrated my changes. Is there any way you could sponsor this change? Thanks again! ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/98 From rkovacs at openjdk.java.net Sat Feb 12 17:40:37 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Sat, 12 Feb 2022 17:40:37 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4] In-Reply-To: References: Message-ID: > Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: > > - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. > - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. > - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). > - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. > - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) > > This is part of the Windows/AArch64 port. Reka Kovacs has updated the pull request incrementally with one additional commit since the last revision: Replace C-style casts with checked_cast ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/280/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/280/files/09587d5e..c5f9428f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=280&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=280&range=02-03 Stats: 5 lines in 3 files changed: 0 ins; 1 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/280.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/280/head:pull/280 PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From rkovacs at openjdk.java.net Sat Feb 12 17:53:11 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Sat, 12 Feb 2022 17:53:11 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4] In-Reply-To: References: Message-ID: On Sat, 12 Feb 2022 17:40:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request incrementally with one additional commit since the last revision: > > Replace C-style casts with checked_cast I replaced them. Thanks for the review. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From serb at openjdk.java.net Sun Feb 13 00:46:44 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sun, 13 Feb 2022 00:46:44 GMT Subject: [jdk18u] RFR: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free Message-ID: Hi all, This is a test stabilization fix, additional information [here](https://github.com/openjdk/jdk/pull/6778). This pull request contains a backport of commit [7c2c5858](https://github.com/openjdk/jdk/commit/7c2c58587d4eda5523331eae45e7d897252dc097) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Dec 2021 and was reviewed by Prasanta Sadhukhan and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 7c2c58587d4eda5523331eae45e7d897252dc097 Changes: https://git.openjdk.java.net/jdk18u/pull/24/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=24&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276819 Stats: 9 lines in 1 file changed: 3 ins; 4 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/24.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/24/head:pull/24 PR: https://git.openjdk.java.net/jdk18u/pull/24 From serb at openjdk.java.net Sun Feb 13 06:50:41 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sun, 13 Feb 2022 06:50:41 GMT Subject: [jdk15u-dev] RFR: 8272167: AbsPathsInImage.java should skip *.dSYM directories Message-ID: Hi all, This pull request contains a backport of commit [dd93c6e2](https://github.com/openjdk/jdk/commit/dd93c6e27b66acebb221583fd28d03c65bfc1f24) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Oct 2021 and was reviewed by Magnus Ihse Bursie and Erik Joelsson. The change is not "clean" because I have to restore the "import" which is still used by the version of the test in jdk15. Thanks! ------------- Commit messages: - Restore the "import java.util.stream.Collectors;" - Backport dd93c6e27b66acebb221583fd28d03c65bfc1f24 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/175/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=175&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272167 Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/175.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/175/head:pull/175 PR: https://git.openjdk.java.net/jdk15u-dev/pull/175 From aph at openjdk.java.net Sun Feb 13 10:56:10 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Sun, 13 Feb 2022 10:56:10 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4] In-Reply-To: References: Message-ID: On Sat, 12 Feb 2022 17:40:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request incrementally with one additional commit since the last revision: > > Replace C-style casts with checked_cast Marked as reviewed by aph (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From rkovacs at openjdk.java.net Mon Feb 14 06:53:13 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 14 Feb 2022 06:53:13 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4] In-Reply-To: References: Message-ID: On Sat, 12 Feb 2022 17:40:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request incrementally with one additional commit since the last revision: > > Replace C-style casts with checked_cast Issue tagged. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From yan at openjdk.java.net Mon Feb 14 07:32:22 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Mon, 14 Feb 2022 07:32:22 GMT Subject: [jdk15u-dev] RFR: 8272167: AbsPathsInImage.java should skip *.dSYM directories In-Reply-To: References: Message-ID: <2RxSFmKij7LlJr6QRmHmqM_a7ujxtD-_SJ1jS8ttvos=.288abac9-be9f-40b3-bb5d-6f4950e84827@github.com> On Sun, 13 Feb 2022 05:24:42 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [dd93c6e2](https://github.com/openjdk/jdk/commit/dd93c6e27b66acebb221583fd28d03c65bfc1f24) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Oct 2021 and was reviewed by Magnus Ihse Bursie and Erik Joelsson. > > The change is not "clean" because I have to restore the "import" which is still used by the version of the test in jdk15. > > Thanks! Fine with me! ------------- Marked as reviewed by yan (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/175 From duke at openjdk.java.net Mon Feb 14 07:38:32 2022 From: duke at openjdk.java.net (aamarsh) Date: Mon, 14 Feb 2022 07:38:32 GMT Subject: [jdk17u-dev] Integrated: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits In-Reply-To: References: Message-ID: On Fri, 14 Jan 2022 20:52:25 GMT, aamarsh wrote: > Makes colorBits and maskBits dynamic variables to force allocation on the heap instead of the stack and avoid a stackoverflow. Also adds a test to confirm this stackoverflow is no longer happening. > > Tier1 and the newly added test passes on Windows. Clean backport. This pull request has now been integrated. Changeset: 2965051f Author: Ana Marsh Committer: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/2965051f0d491751e5c34a3b3627e423e8f23a2d Stats: 83 lines in 2 files changed: 58 ins; 0 del; 25 mod 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits Backport-of: 94127f43a4a28a89094fa93cd1da49763134f9db ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/98 From goetz at openjdk.java.net Mon Feb 14 07:44:24 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Feb 2022 07:44:24 GMT Subject: [jdk17u-dev] RFR: 8273655: content-types.properties files are missing some common types In-Reply-To: References: Message-ID: <1S0K5aKB3iQmQw2-ugXst7Q9qdFgRnO--wDm7bPlXr8=.b7a62c8e-c319-48f1-b20a-c4f35afc91e0@github.com> On Fri, 11 Feb 2022 16:44:36 GMT, Julia Boes wrote: >> 8273655: content-types.properties files are missing some common types > > LGTM once the copyright year in the test is fixed. @FrauBoes, thanks for looking at this. But what is wrong with the copyright? It is the same as in the original commit. Copyrights are not changed in backports. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/156 From burban at openjdk.java.net Mon Feb 14 07:51:10 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Mon, 14 Feb 2022 07:51:10 GMT Subject: [jdk11u-dev] RFR: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 21:35:38 GMT, Vladimir Kempik wrote: > Pleas review this backport to jdk11u-dev. > It's one of few follow up fixes for jep-391 backport. > This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread > Not applying clean due to context code difference in chunk 2. > In JDK17 it's - ThreadStateTransition::transition() > in JDK11 it's - ThreadStateTransition::transition_and_fence() Marked as reviewed by burban (no project role). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/816 From burban at openjdk.java.net Mon Feb 14 07:51:09 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Mon, 14 Feb 2022 07:51:09 GMT Subject: [jdk11u-dev] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2] In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 10:30:41 GMT, Vladimir Kempik wrote: >> Please review this backport. Not applying clean. A follow up patch for jep-391 backport > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Redo the fix, start trannsition earlier Marked as reviewed by burban (no project role). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/817 From burban at openjdk.java.net Mon Feb 14 07:54:10 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Mon, 14 Feb 2022 07:54:10 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 17:32:38 GMT, Paul Hohensee wrote: > Note to Maintainers: 10.9 through 10.14 are eol, and the oldest machines supported by 10.12 are from 2009/2010, see https://support.apple.com/kb/SP742?locale=en_USh. Imo it's safe to say that it's very unlikely there are machines running OSX versions earlier than 10.12. While I agree, why take the risk? This can be easily set conditionally for aarch64. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From vkempik at openjdk.java.net Mon Feb 14 08:03:15 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Mon, 14 Feb 2022 08:03:15 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 07:50:47 GMT, Bernhard Urban-Forster wrote: > > Note to Maintainers: 10.9 through 10.14 are eol, and the oldest machines supported by 10.12 are from 2009/2010, see https://support.apple.com/kb/SP742?locale=en_USh. Imo it's safe to say that it's very unlikely there are machines running OSX versions earlier than 10.12. > > While I agree, why take the risk? This can be easily set conditionally for aarch64. This was reasoned in the bug description: >Having a large gap between the target versions becomes problematic as we hit a lot of deprecation warnings in shared code. To be able to fix these deprecation warnings, we need a smaller version gap. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From burban at openjdk.java.net Mon Feb 14 08:27:24 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Mon, 14 Feb 2022 08:27:24 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 In-Reply-To: References: Message-ID: <6eDA8cSU7HO62iChuk9H7v4sBXSY61vWk2sZan31foM=.912af0f3-9b54-45b6-9533-300ff0a08a0e@github.com> On Tue, 8 Feb 2022 08:16:59 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8260518 to jdk11u-dev > The backport is not applying clean due to the context code difference. > It's needed mostly to resolve this compilation error on macos-aarch64 > splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] > This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) Marked as reviewed by burban (no project role). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From abakhtin at openjdk.java.net Mon Feb 14 08:39:32 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 14 Feb 2022 08:39:32 GMT Subject: [jdk17u-dev] Integrated: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key In-Reply-To: <32YOsWV_EmPLCiLS8OH3EDeMc23oxWllFV63S5fBZEo=.ee42d4d8-3a60-4747-94f7-02562d77f389@github.com> References: <32YOsWV_EmPLCiLS8OH3EDeMc23oxWllFV63S5fBZEo=.ee42d4d8-3a60-4747-94f7-02562d77f389@github.com> Message-ID: On Fri, 11 Feb 2022 10:38:25 GMT, Alexey Bakhtin wrote: > This is a clean backport of JDK-8271199 to JDK17u-dev This pull request has now been integrated. Changeset: 87010e73 Author: Alexey Bakhtin Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk17u-dev/commit/87010e737c0754ce60e5cf7631db97b9edaf794b Stats: 89 lines in 2 files changed: 69 ins; 14 del; 6 mod 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key Backport-of: f6232982b91cb2314e96ddbde3984836a810a556 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/157 From shade at openjdk.java.net Mon Feb 14 08:42:11 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Feb 2022 08:42:11 GMT Subject: [jdk11u-dev] RFR: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 In-Reply-To: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> References: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> Message-ID: On Fri, 11 Feb 2022 07:53:05 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the x86_32 problem. It is not clean, because Panama is not in 11u, so context in `.ad` is different. > > Additional testing: > - [x] Linux x86_32 fails new test without the fix, passes with it Thanks, got the push approval. The GHA failure is known intermittent. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/819 From shade at openjdk.java.net Mon Feb 14 08:42:12 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Feb 2022 08:42:12 GMT Subject: [jdk11u-dev] Integrated: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 In-Reply-To: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> References: <-FTylSR3O2Iop6BBfrB5L5xOZrM2ASbgciARtQ3DAOY=.fc784181-4642-4dd4-a84d-dbb66c40a7dc@github.com> Message-ID: On Fri, 11 Feb 2022 07:53:05 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the x86_32 problem. It is not clean, because Panama is not in 11u, so context in `.ad` is different. > > Additional testing: > - [x] Linux x86_32 fails new test without the fix, passes with it This pull request has now been integrated. Changeset: bd420d2a Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/bd420d2aad229739789bf19f7014119562077769 Stats: 64 lines in 2 files changed: 64 ins; 0 del; 0 mod 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 Reviewed-by: roland, kvn Backport-of: 9d5ae2e38074c3df354aeab19ebbab7d4872165a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/819 From shade at openjdk.java.net Mon Feb 14 08:47:51 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Feb 2022 08:47:51 GMT Subject: [jdk11u-dev] RFR: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} [v2] In-Reply-To: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> References: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> Message-ID: > Follow up to JDK-8279076 backport. > > Additional testing: > - [x] The test from JDK-8279076 still passes Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - Backport a24f44d17de586c72c8343f8891e72ad8a514597 - Backport 9d5ae2e38074c3df354aeab19ebbab7d4872165a ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/820/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/820/files/1dc1616c..99d47977 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=820&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=820&range=00-01 Stats: 535 lines in 8 files changed: 9 ins; 516 del; 10 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/820.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/820/head:pull/820 PR: https://git.openjdk.java.net/jdk11u-dev/pull/820 From duke at openjdk.java.net Mon Feb 14 08:47:52 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Mon, 14 Feb 2022 08:47:52 GMT Subject: [jdk11u-dev] RFR: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} In-Reply-To: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> References: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> Message-ID: On Fri, 11 Feb 2022 08:51:59 GMT, Aleksey Shipilev wrote: > Follow up to JDK-8279076 backport. > > Additional testing: > - [x] The test from JDK-8279076 still passes The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8279076-x86_32-sqrtf git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/820 From richard.reingruber at sap.com Mon Feb 14 08:49:21 2022 From: richard.reingruber at sap.com (Reingruber, Richard) Date: Mon, 14 Feb 2022 08:49:21 +0000 Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik In-Reply-To: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> References: <2b6f2adc-9511-c30e-2673-1ec504822c6a@azul.com> Message-ID: Vote: yes Richard. From: jdk-updates-dev on behalf of Yuri Nesterenko Date: Wednesday, 9. February 2022 at 13:44 To: jdk-updates-dev at openjdk.java.net Subject: CFV: New JDK Updates Reviewer: Vladimir Kempik I hereby nominate Vladimir Kempik [0] for the role of JDK Updates Project Reviewer. Vladimir had contributed over 100 OpenJDK commits [1][2][3][4] over the last 9 years on behalf of Oracle and Azul. He has co-authored JEP-391 [5] (macos-aarch64 support) and drives the work on backporting that JEP into jdk11u. Votes are due by Feb 23, 2022, 13:00 UTC. Only current JDK Updates Reviewers [6] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [7]. [0] https://openjdk.java.net/census#vkempik [1] https://github.com/openjdk/jdk11u-dev/commits/master?author=vkempik%40openjdk.org [2] https://github.com/openjdk/jdk13u-dev/commits/master?author=vkempik%40openjdk.org [3] https://github.com/openjdk/jdk15u-dev/commits/master?author=vkempik%40openjdk.org [4] https://github.com/openjdk/jdk17u-dev/commits/master?author=vkempik%40openjdk.org [5] https://openjdk.java.net/jeps/391 [6] https://openjdk.java.net/census#jdk-updates [7] https://openjdk.java.net/bylaws#three-vote-consensus From jboes at openjdk.java.net Mon Feb 14 09:44:29 2022 From: jboes at openjdk.java.net (Julia Boes) Date: Mon, 14 Feb 2022 09:44:29 GMT Subject: [jdk17u-dev] RFR: 8273655: content-types.properties files are missing some common types In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 10:35:57 GMT, Matthias Baesken wrote: > 8273655: content-types.properties files are missing some common types You're right, my bad - sorry for the confusion. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/156 From goetz at openjdk.java.net Mon Feb 14 10:00:23 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Feb 2022 10:00:23 GMT Subject: [jdk17u-dev] Integrated: 8272600: (test) Use native "sleep" in Basic.java In-Reply-To: <8mMGfnOZAk0jUi_GkXaeGXu-T0Nw1VRTDlgYcs0ekz0=.e17506f7-bf2b-4d61-a639-359f5fa8ccb5@github.com> References: <8mMGfnOZAk0jUi_GkXaeGXu-T0Nw1VRTDlgYcs0ekz0=.e17506f7-bf2b-4d61-a639-359f5fa8ccb5@github.com> Message-ID: On Wed, 9 Feb 2022 14:25:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: 6cee0184 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/6cee0184f32f858be867bea8d14c24e65eb79a5c Stats: 174 lines in 2 files changed: 111 ins; 35 del; 28 mod 8272600: (test) Use native "sleep" in Basic.java Backport-of: 0a361638c5ea4d3e109d950e34a61b4737c8f670 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/153 From goetz at openjdk.java.net Mon Feb 14 10:03:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Feb 2022 10:03:15 GMT Subject: [jdk17u-dev] Integrated: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 08:55:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: ec1733da Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/ec1733dac673cf9aa0299469dd8a39046581f6b8 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/155 From shade at openjdk.java.net Mon Feb 14 11:18:21 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Feb 2022 11:18:21 GMT Subject: [jdk11u-dev] RFR: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} [v2] In-Reply-To: References: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> Message-ID: On Mon, 14 Feb 2022 08:47:51 GMT, Aleksey Shipilev wrote: >> Follow up to JDK-8279076 backport. >> >> Additional testing: >> - [x] The test from JDK-8279076 still passes > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - Backport a24f44d17de586c72c8343f8891e72ad8a514597 > - Backport 9d5ae2e38074c3df354aeab19ebbab7d4872165a Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/820 From shade at openjdk.java.net Mon Feb 14 11:18:21 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Feb 2022 11:18:21 GMT Subject: [jdk11u-dev] Integrated: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} In-Reply-To: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> References: <-LJfFlKqV4f22D_rQNxMvZC7K-QuuUBBki12Zn0tS4Y=.7b575fd7-f536-4d72-bc79-095044349913@github.com> Message-ID: On Fri, 11 Feb 2022 08:51:59 GMT, Aleksey Shipilev wrote: > Follow up to JDK-8279076 backport. > > Additional testing: > - [x] The test from JDK-8279076 still passes This pull request has now been integrated. Changeset: fd7d0d3d Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/fd7d0d3d687729ffe46839f5a47e85ba09ad4501 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} Reviewed-by: kvn Backport-of: a24f44d17de586c72c8343f8891e72ad8a514597 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/820 From goetz at openjdk.java.net Mon Feb 14 13:36:33 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Feb 2022 13:36:33 GMT Subject: [jdk17u-dev] RFR: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS Message-ID: A tiny bugfix for 17. ------------- Commit messages: - Backport 3d7671b65e8491f3b1fcac8b96401401f783c9f4 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/160/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=160&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274562 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/160.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/160/head:pull/160 PR: https://git.openjdk.java.net/jdk17u-dev/pull/160 From andrew at openjdk.java.net Mon Feb 14 13:42:29 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Mon, 14 Feb 2022 13:42:29 GMT Subject: [jdk17u-dev] Integrated: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication In-Reply-To: <96WJt39G8ACNEqygcI7tJSnSHH1vh2AkjuOYFOY-y0o=.ec0eceac-984f-4126-ad36-98aed599fb7a@github.com> References: <96WJt39G8ACNEqygcI7tJSnSHH1vh2AkjuOYFOY-y0o=.ec0eceac-984f-4126-ad36-98aed599fb7a@github.com> Message-ID: On Wed, 9 Feb 2022 15:56:59 GMT, Andrew John Hughes wrote: > Clean backport. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. This pull request has now been integrated. Changeset: 8207e69a Author: Andrew John Hughes URL: https://git.openjdk.java.net/jdk17u-dev/commit/8207e69aa076ba848b8496c4ea0bcbea952aae2a Stats: 30 lines in 2 files changed: 18 ins; 3 del; 9 mod 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication Backport-of: d1aeca117ccc4334d67b2692ff087a9f8d808a59 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/154 From abakhtin at openjdk.java.net Mon Feb 14 13:52:54 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 14 Feb 2022 13:52:54 GMT Subject: [jdk17u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Message-ID: This is a clean backport of JDK-8274524 to JDK17u-dev sun/security/ssl/SSLSocketImpl tests passed ------------- Commit messages: - Backport 58dae60da0711c4ae0cb23f8ce2328e051d603b2 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/161/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=161&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274524 Stats: 151 lines in 2 files changed: 151 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/161.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/161/head:pull/161 PR: https://git.openjdk.java.net/jdk17u-dev/pull/161 From andrew at openjdk.java.net Mon Feb 14 13:53:43 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Mon, 14 Feb 2022 13:53:43 GMT Subject: [jdk11u-dev] RFR: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication Message-ID: Hi all, This pull request contains a backport of commit [d1aeca11](https://github.com/openjdk/jdk/commit/d1aeca117ccc4334d67b2692ff087a9f8d808a59) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Brian Burkhalter on 27 Aug 2021 and was reviewed by Joe Darcy. It has already been backported to [jdk17u-dev](https://git.openjdk.java.net/jdk17u-dev/commit/8207e69aa076ba848b8496c4ea0bcbea952aae2a). This is a clean backport to 11u. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. Thanks! ------------- Commit messages: - Backport d1aeca117ccc4334d67b2692ff087a9f8d808a59 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/822/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=822&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272541 Stats: 30 lines in 2 files changed: 18 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/822.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/822/head:pull/822 PR: https://git.openjdk.java.net/jdk11u-dev/pull/822 From abakhtin at openjdk.java.net Mon Feb 14 13:58:49 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 14 Feb 2022 13:58:49 GMT Subject: [jdk15u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Message-ID: <_PX93y7YPEKG6NALC9cc535zVpmVDnxmcPWFUah0DJw=.50cc3a95-9b12-4e10-874e-787764fbb188@github.com> Backport of JDK-8274524 to JDK15u-dev Backport is almost clean except trivial fix for Pattern Matching in the instanceof (not available in JDK15) sun/security/ssl/SSLSocketImpl tests passed ------------- Commit messages: - Backport 58dae60da0711c4ae0cb23f8ce2328e051d603b2 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/176/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=176&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274524 Stats: 151 lines in 2 files changed: 151 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/176.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/176/head:pull/176 PR: https://git.openjdk.java.net/jdk15u-dev/pull/176 From abakhtin at openjdk.java.net Mon Feb 14 13:59:55 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 14 Feb 2022 13:59:55 GMT Subject: [jdk13u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Message-ID: Backport of JDK-8274524 to JDK13u-dev Backport is almost clean except for trivial fix for Pattern Matching in the instanceof (not available in JDK13) sun/security/ssl/SSLSocketImpl tests passed ------------- Commit messages: - Backport 58dae60da0711c4ae0cb23f8ce2328e051d603b2 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/326/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=326&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274524 Stats: 151 lines in 2 files changed: 151 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/326.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/326/head:pull/326 PR: https://git.openjdk.java.net/jdk13u-dev/pull/326 From xuelei at openjdk.java.net Mon Feb 14 15:19:20 2022 From: xuelei at openjdk.java.net (Xue-Lei Andrew Fan) Date: Mon, 14 Feb 2022 15:19:20 GMT Subject: [jdk13u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 13:51:17 GMT, Alexey Bakhtin wrote: > Backport of JDK-8274524 to JDK13u-dev > Backport is almost clean except for trivial fix for Pattern Matching in the instanceof (not available in JDK13) > sun/security/ssl/SSLSocketImpl tests passed Looks good to me except a mini coding style comment. src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1769: > 1767: } finally { > 1768: if (soTimeout == 0) > 1769: setSoTimeout(soTimeout); Braces should be used for the if-clauses. ------------- Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.java.net/jdk13u-dev/pull/326 From abakhtin at openjdk.java.net Mon Feb 14 15:42:00 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 14 Feb 2022 15:42:00 GMT Subject: [jdk13u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake [v2] In-Reply-To: References: Message-ID: > Backport of JDK-8274524 to JDK13u-dev > Backport is almost clean except for trivial fix for Pattern Matching in the instanceof (not available in JDK13) > sun/security/ssl/SSLSocketImpl tests passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Add braces ------------- Changes: - all: https://git.openjdk.java.net/jdk13u-dev/pull/326/files - new: https://git.openjdk.java.net/jdk13u-dev/pull/326/files/d4a0316a..e19145f2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=326&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=326&range=00-01 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/326.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/326/head:pull/326 PR: https://git.openjdk.java.net/jdk13u-dev/pull/326 From abakhtin at openjdk.java.net Mon Feb 14 15:42:01 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 14 Feb 2022 15:42:01 GMT Subject: [jdk13u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake [v2] In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 15:15:28 GMT, Xue-Lei Andrew Fan wrote: >> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: >> >> Add braces > > src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1769: > >> 1767: } finally { >> 1768: if (soTimeout == 0) >> 1769: setSoTimeout(soTimeout); > > Braces should be used for the if-clauses. Thank you. Braces are added ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/326 From abakhtin at openjdk.java.net Mon Feb 14 15:46:15 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 14 Feb 2022 15:46:15 GMT Subject: [jdk15u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake [v2] In-Reply-To: <_PX93y7YPEKG6NALC9cc535zVpmVDnxmcPWFUah0DJw=.50cc3a95-9b12-4e10-874e-787764fbb188@github.com> References: <_PX93y7YPEKG6NALC9cc535zVpmVDnxmcPWFUah0DJw=.50cc3a95-9b12-4e10-874e-787764fbb188@github.com> Message-ID: > Backport of JDK-8274524 to JDK15u-dev > Backport is almost clean except trivial fix for Pattern Matching in the instanceof (not available in JDK15) > sun/security/ssl/SSLSocketImpl tests passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Add braces ------------- Changes: - all: https://git.openjdk.java.net/jdk15u-dev/pull/176/files - new: https://git.openjdk.java.net/jdk15u-dev/pull/176/files/e5ff3960..77d58849 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=176&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=176&range=00-01 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/176.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/176/head:pull/176 PR: https://git.openjdk.java.net/jdk15u-dev/pull/176 From andrew at openjdk.java.net Mon Feb 14 17:10:25 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Mon, 14 Feb 2022 17:10:25 GMT Subject: [jdk13u-dev] RFR: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication Message-ID: Hi all, This pull request contains a backport of commit [d1aeca11](https://github.com/openjdk/jdk/commit/d1aeca117ccc4334d67b2692ff087a9f8d808a59) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Brian Burkhalter on 27 Aug 2021 and was reviewed by Joe Darcy. It has already been backported to [jdk17u-dev](https://git.openjdk.java.net/jdk17u-dev/commit/8207e69aa076ba848b8496c4ea0bcbea952aae2a). This is a clean backport to 11u. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. Thanks! ------------- Commit messages: - Backport d1aeca117ccc4334d67b2692ff087a9f8d808a59 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/327/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=327&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272541 Stats: 30 lines in 2 files changed: 18 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/327.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/327/head:pull/327 PR: https://git.openjdk.java.net/jdk13u-dev/pull/327 From andrew at openjdk.java.net Mon Feb 14 17:14:38 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Mon, 14 Feb 2022 17:14:38 GMT Subject: [jdk15u-dev] RFR: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication Message-ID: Hi all, This pull request contains a backport of commit [d1aeca11](https://github.com/openjdk/jdk/commit/d1aeca117ccc4334d67b2692ff087a9f8d808a59) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Brian Burkhalter on 27 Aug 2021 and was reviewed by Joe Darcy. It has already been backported to [jdk17u-dev](https://git.openjdk.java.net/jdk17u-dev/commit/8207e69aa076ba848b8496c4ea0bcbea952aae2a). This is a clean backport to 15u. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. Thanks! ------------- Commit messages: - Backport d1aeca117ccc4334d67b2692ff087a9f8d808a59 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/177/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=177&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272541 Stats: 30 lines in 2 files changed: 18 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/177.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/177/head:pull/177 PR: https://git.openjdk.java.net/jdk15u-dev/pull/177 From abakhtin at openjdk.java.net Mon Feb 14 18:06:47 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 14 Feb 2022 18:06:47 GMT Subject: [jdk11u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Message-ID: <3i4qj7zTLvkxTNVC0PDdHIpj6wmaL3Tl6f8eJs0s8yc=.ab5d95cf-f662-44b1-a38a-c8475706b457@github.com> Backport of JDK-8274524 to JDK11u-dev Backport is almost clean except for a trivial fix for Pattern Matching in the instanceof (not available in JDK11) and braces for the if-clauses. sun/security/ssl/SSLSocketImpl tests passed ------------- Commit messages: - Backport 58dae60da0711c4ae0cb23f8ce2328e051d603b2 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/823/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=823&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274524 Stats: 153 lines in 2 files changed: 153 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/823.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/823/head:pull/823 PR: https://git.openjdk.java.net/jdk11u-dev/pull/823 From yan at openjdk.java.net Mon Feb 14 18:12:18 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Mon, 14 Feb 2022 18:12:18 GMT Subject: [jdk15u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake [v2] In-Reply-To: References: <_PX93y7YPEKG6NALC9cc535zVpmVDnxmcPWFUah0DJw=.50cc3a95-9b12-4e10-874e-787764fbb188@github.com> Message-ID: On Mon, 14 Feb 2022 15:46:15 GMT, Alexey Bakhtin wrote: >> Backport of JDK-8274524 to JDK15u-dev >> Backport is almost clean except trivial fix for Pattern Matching in the instanceof (not available in JDK15) >> sun/security/ssl/SSLSocketImpl tests passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Add braces OK with me ------------- Marked as reviewed by yan (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/176 From phh at openjdk.java.net Mon Feb 14 18:23:10 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 14 Feb 2022 18:23:10 GMT Subject: [jdk11u-dev] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake In-Reply-To: <3i4qj7zTLvkxTNVC0PDdHIpj6wmaL3Tl6f8eJs0s8yc=.ab5d95cf-f662-44b1-a38a-c8475706b457@github.com> References: <3i4qj7zTLvkxTNVC0PDdHIpj6wmaL3Tl6f8eJs0s8yc=.ab5d95cf-f662-44b1-a38a-c8475706b457@github.com> Message-ID: <7V_K29YG03tU4kmg0UUYmN6We5JwXys1AQ-gc4MTURA=.9b06d236-d759-4c10-9ae1-90ac9ef81ec6@github.com> On Mon, 14 Feb 2022 17:58:42 GMT, Alexey Bakhtin wrote: > Backport of JDK-8274524 to JDK11u-dev > Backport is almost clean except for a trivial fix for Pattern Matching in the instanceof (not available in JDK11) and braces for the if-clauses. > sun/security/ssl/SSLSocketImpl tests passed Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/823 From vkempik at openjdk.java.net Mon Feb 14 18:42:14 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Mon, 14 Feb 2022 18:42:14 GMT Subject: [jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9] In-Reply-To: References: Message-ID: <2-57UA5tcKfzHzUlIpmzubiEyMJz72LbuAlfAHaxeiw=.db76da03-5aef-461f-8b7d-a6693c5dd8bb@github.com> On Tue, 8 Feb 2022 10:42:02 GMT, Vladimir Kempik wrote: >> Initial version of JEP-391 backport to jdk11u. >> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. >> Things needing attention: os_bsd_aarch64.cpp and W^X transitions. >> serviceability agent is mostly clean. >> This passed GHA_tier1 testing. >> Full regression testing is running now on Azul's infra, will report/update PR when done. >> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** >> Sharing this PR slightly earlier to let other interested parties to run the tests too. >> Example of cross-building on intel mac (needs Xcode12/13): >> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin > > Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision: > > - Fix wrong patch from jep-388 backport > - Merge branch 'master' into JDK-8253795 > - Add two missing WX transitions > - Ignore TestOnError.java on macos_aarch64 > - Merge branch 'master' into JDK-8253795 > - remove unused at_rsp from aarch64 > - Fix warning about c++11 extension > - Exclude test CompressedClassPointers.java on macarm > - Merge pull request #1 from VladimirKempik/JEP391_and_8262896 > > 8262896: [macos_aarch64] Crash in jni_fast_GetLongField > - 8262896: [macos_aarch64] Crash in jni_fast_GetLongField > - ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/98f15bf4...6d037958 Oracle has pulled this into their java11 - https://bugs.openjdk.java.net/browse/JDK-8275573 @GoeLin is there anything holding us from getting approval for 11u ? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From duke at openjdk.java.net Mon Feb 14 18:53:17 2022 From: duke at openjdk.java.net (duke) Date: Mon, 14 Feb 2022 18:53:17 GMT Subject: [jdk17u-dev] Withdrawn: 8261495: Shenandoah: reconsider update references memory ordering In-Reply-To: <7kRZS1QARmk4dcsUGCCHU5Vngu2-dTAEmTu0a0nDkF0=.ff67c485-6b1c-4303-9c25-5ff1ce21c371@github.com> References: <7kRZS1QARmk4dcsUGCCHU5Vngu2-dTAEmTu0a0nDkF0=.ff67c485-6b1c-4303-9c25-5ff1ce21c371@github.com> Message-ID: On Mon, 20 Dec 2021 10:52:56 GMT, Aleksey Shipilev wrote: > Transplanted from https://github.com/openjdk/jdk17u/pull/254 > > Additional testing: > - [ ] Linux x86_64 fastdebug `hotspot_gc_shenandoah` > - [ ] Linux x86_64 fastdebug `tier1` with Shenandoah > - [ ] Linux AArch64 fastdebug `hotspot_gc_shenandoah` > - [ ] Linux AArch64 fastdebug `tier1` with Shenandoah This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/8 From andrew at openjdk.java.net Mon Feb 14 20:02:12 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Mon, 14 Feb 2022 20:02:12 GMT Subject: [jdk13u-dev] Integrated: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 17:04:08 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [d1aeca11](https://github.com/openjdk/jdk/commit/d1aeca117ccc4334d67b2692ff087a9f8d808a59) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Brian Burkhalter on 27 Aug 2021 and was reviewed by Joe Darcy. > It has already been backported to [jdk17u-dev](https://git.openjdk.java.net/jdk17u-dev/commit/8207e69aa076ba848b8496c4ea0bcbea952aae2a). > > This is a clean backport to 11u. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. > > Thanks! This pull request has now been integrated. Changeset: 359504c4 Author: Andrew John Hughes URL: https://git.openjdk.java.net/jdk13u-dev/commit/359504c4caff72a4fec7059be6fd3795c5c0f963 Stats: 30 lines in 2 files changed: 18 ins; 3 del; 9 mod 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication Backport-of: d1aeca117ccc4334d67b2692ff087a9f8d808a59 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/327 From andrew at openjdk.java.net Mon Feb 14 20:02:12 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Mon, 14 Feb 2022 20:02:12 GMT Subject: [jdk15u-dev] Integrated: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 17:06:37 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [d1aeca11](https://github.com/openjdk/jdk/commit/d1aeca117ccc4334d67b2692ff087a9f8d808a59) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Brian Burkhalter on 27 Aug 2021 and was reviewed by Joe Darcy. > It has already been backported to [jdk17u-dev](https://git.openjdk.java.net/jdk17u-dev/commit/8207e69aa076ba848b8496c4ea0bcbea952aae2a). > > This is a clean backport to 15u. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. > > Thanks! This pull request has now been integrated. Changeset: e305f506 Author: Andrew John Hughes URL: https://git.openjdk.java.net/jdk15u-dev/commit/e305f5063301006f5dd6a203a9d65648775eb06d Stats: 30 lines in 2 files changed: 18 ins; 3 del; 9 mod 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication Backport-of: d1aeca117ccc4334d67b2692ff087a9f8d808a59 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/177 From duke at openjdk.java.net Tue Feb 15 07:37:42 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Tue, 15 Feb 2022 07:37:42 GMT Subject: [jdk11u-dev] RFR: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale Message-ID: This is a backport of JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale. Original patch applies cleanly to 11u. Testing: build on Windows x86_64 and Linux x86_64 tier1 on Windows x86_64 and Linux x86_64 a specific test to confirm the fix in Japanese locale Could you please review this PR? ------------- Commit messages: - Backport dcd8f03c06f0ca2b87c73a259f2ec1e9fdac258f Changes: https://git.openjdk.java.net/jdk11u-dev/pull/824/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=824&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255239 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/824.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/824/head:pull/824 PR: https://git.openjdk.java.net/jdk11u-dev/pull/824 From goetz at openjdk.java.net Tue Feb 15 07:51:04 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Feb 2022 07:51:04 GMT Subject: [jdk11u-dev] RFR: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 07:31:11 GMT, Kimura Yukihiro wrote: > This is a backport of JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale. > Original patch applies cleanly to 11u. > > Testing: > build on Windows x86_64 and Linux x86_64 > tier1 on Windows x86_64 and Linux x86_64 > a specific test to confirm the fix in Japanese locale > > Could you please review this PR? Thanks for addressing this issue! If this is actually clean, you did something wrong because skara should mark it as clean. And if so, no review is needed. Please change the title to "Backport ". This has the same effect as the commit message in Step 2 Option 3 in https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/824 From mbaesken at openjdk.java.net Tue Feb 15 07:53:20 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 15 Feb 2022 07:53:20 GMT Subject: [jdk11u-dev] Integrated: 8280414: Memory leak in DefaultProxySelector In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 11:30:23 GMT, Matthias Baesken wrote: > 8280414: Memory leak in DefaultProxySelector This pull request has now been integrated. Changeset: fe17b44f Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/fe17b44f3677e6deffc57241cdd4761b1c8698a5 Stats: 11 lines in 1 file changed: 1 ins; 3 del; 7 mod 8280414: Memory leak in DefaultProxySelector Backport-of: fe77250fa450ec803d2818dc90c5bf156521d537 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/821 From mbaesken at openjdk.java.net Tue Feb 15 07:57:17 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 15 Feb 2022 07:57:17 GMT Subject: [jdk17u-dev] Integrated: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 10:52:54 GMT, Matthias Baesken wrote: > 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 This pull request has now been integrated. Changeset: 7833c7d5 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/7833c7d5bf458094ef40ffa847c07c12ee47445d Stats: 5 lines in 1 file changed: 2 ins; 1 del; 2 mod 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 Backport-of: c180070cb59b8e075376ae913c5db9a4ed868303 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/159 From mbaesken at openjdk.java.net Tue Feb 15 08:00:24 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 15 Feb 2022 08:00:24 GMT Subject: [jdk17u-dev] Integrated: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 10:42:45 GMT, Matthias Baesken wrote: > 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 This pull request has now been integrated. Changeset: a7010a2f Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/a7010a2facd5a42e59e46033ebed4c36380aff80 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 Backport-of: 01f93ddf18daea5c0798ac949c6717c37d9cefa0 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/158 From mbaesken at openjdk.java.net Tue Feb 15 08:12:15 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 15 Feb 2022 08:12:15 GMT Subject: [jdk17u-dev] Integrated: 8273655: content-types.properties files are missing some common types In-Reply-To: References: Message-ID: On Fri, 11 Feb 2022 10:35:57 GMT, Matthias Baesken wrote: > 8273655: content-types.properties files are missing some common types This pull request has now been integrated. Changeset: ab3dd202 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/ab3dd202d7a51f113ec57e98ed32d27f565a9c69 Stats: 227 lines in 3 files changed: 193 ins; 13 del; 21 mod 8273655: content-types.properties files are missing some common types Backport-of: 65ed0a742e65fe7e661e8da2adea6cd41992869e ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/156 From mbaesken at openjdk.java.net Tue Feb 15 08:24:35 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 15 Feb 2022 08:24:35 GMT Subject: [jdk17u-dev] RFR: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches Message-ID: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches ------------- Commit messages: - Backport bb74ae87abee0fb550e4138242919ec791f7791c Changes: https://git.openjdk.java.net/jdk17u-dev/pull/162/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=162&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274171 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/162.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/162/head:pull/162 PR: https://git.openjdk.java.net/jdk17u-dev/pull/162 From mbaesken at openjdk.java.net Tue Feb 15 08:57:39 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 15 Feb 2022 08:57:39 GMT Subject: [jdk11u-dev] RFR: 8275082: Update XML Security for Java to 2.3.0 Message-ID: 8275082: Update XML Security for Java to 2.3.0 ------------- Commit messages: - Backport 1082544d23ee4cd1d81cdd707f136adc951eca00 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/825/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=825&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275082 Stats: 413 lines in 33 files changed: 63 ins; 267 del; 83 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/825.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/825/head:pull/825 PR: https://git.openjdk.java.net/jdk11u-dev/pull/825 From stuefe at openjdk.java.net Tue Feb 15 09:10:25 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 15 Feb 2022 09:10:25 GMT Subject: [jdk17u] RFR: 8277383: VM.metaspace optionally show chunk freelist details In-Reply-To: <25g9vykTSEDr0Py2Pgwo_4RxVSveo-S21Cvm_c9ZzTU=.872a5a47-a204-41e3-a5ca-f1db6c1b66e9@github.com> References: <25g9vykTSEDr0Py2Pgwo_4RxVSveo-S21Cvm_c9ZzTU=.872a5a47-a204-41e3-a5ca-f1db6c1b66e9@github.com> Message-ID: On Tue, 8 Feb 2022 07:10:10 GMT, Thomas Stuefe wrote: > I'd like to backport this to jdk17 since it adds a useful option for metaspace analysis. Fix is low risk and applies cleanly. > > The commit being backported was authored by Thomas Stuefe on 7 Dec 2021 and was reviewed by Coleen Phillimore and Aleksey Shipilev. Windows test error unrelated ------------- PR: https://git.openjdk.java.net/jdk17u/pull/333 From duke at openjdk.java.net Tue Feb 15 09:15:16 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Tue, 15 Feb 2022 09:15:16 GMT Subject: [jdk11u-dev] RFR: Backport dcd8f03c06f0ca2b87c73a259f2ec1e9fdac258f In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 07:31:11 GMT, Kimura Yukihiro wrote: > This is a backport of JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale. > Original patch applies cleanly to 11u. > > Testing: > build on Windows x86_64 and Linux x86_64 > tier1 on Windows x86_64 and Linux x86_64 > a specific test to confirm the fix in Japanese locale > > Could you please review this PR? Thank you for your advice. I used Option 3 in Step 2. This is my first contribution. I would appreciate it if you could give me some time to check the flow. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/824 From goetz at openjdk.java.net Tue Feb 15 09:16:26 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Feb 2022 09:16:26 GMT Subject: [jdk17u-dev] Integrated: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 13:27:38 GMT, Goetz Lindenmaier wrote: > A tiny bugfix for 17. This pull request has now been integrated. Changeset: 2011c353 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/2011c35344f5d5080bec23b66c32c8d992551173 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS Backport-of: 3d7671b65e8491f3b1fcac8b96401401f783c9f4 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/160 From anleonar at redhat.com Tue Feb 15 09:24:20 2022 From: anleonar at redhat.com (Andrew Leonard) Date: Tue, 15 Feb 2022 09:24:20 +0000 Subject: How do I backport two jdk->jdk17u-dev commits together? Message-ID: I have 2 jdk commits I want to backport to jdk17u-dev that are dependent on each other, one fixes an issue in the first one. How do I achieve that with the Skara commands? The 2nd one will not backport cleanly without the first as it modifies code from the 1st, so they sort of need doing together? Or do I just do the 1st, then do the 2nd separately. thanks Andrew From shade at redhat.com Tue Feb 15 09:38:44 2022 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 15 Feb 2022 12:38:44 +0300 Subject: How do I backport two jdk->jdk17u-dev commits together? In-Reply-To: References: Message-ID: <55db22c8-1240-8e11-de17-33c44dfb94c1@redhat.com> On 2/15/22 12:24, Andrew Leonard wrote: > I have 2 jdk commits I want to backport to jdk17u-dev that are dependent on > each other, one fixes an issue in the first one. > How do I achieve that with the Skara commands? > The 2nd one will not backport cleanly without the first as it modifies code > from the 1st, so they sort of need doing together? > Or do I just do the 1st, then do the 2nd separately. Like this: https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html -- Thanks, -Aleksey From anleonar at redhat.com Tue Feb 15 09:58:44 2022 From: anleonar at redhat.com (Andrew Leonard) Date: Tue, 15 Feb 2022 09:58:44 +0000 Subject: How do I backport two jdk->jdk17u-dev commits together? In-Reply-To: <55db22c8-1240-8e11-de17-33c44dfb94c1@redhat.com> References: <55db22c8-1240-8e11-de17-33c44dfb94c1@redhat.com> Message-ID: Thank Aleksey, If I understand that correctly, i'm not sure that will quite work for my scenario, as my 1st PR is not dependent on the 2nd PR, the 2nd PR is a fix to a problem found in the 1st PR. So essentially: PR1: added some code... PR2: fixed a problem with the code added in PR1 So PR2 depends on PR1, but ideally I don't want to integrate PR1 before PR2, but it would not harm to do so it just wouldn't fully function until PR2 is also backported. So summing that all up effectively for correct functioning PR1 depends on PR2 and PR2 depends on PR1 (gosh hope that makes sense!) I feel as though I should do PR1 but apply it manually including the PR2 fix, ie.bundle both into one backport PR ? Thanks Andrew On Tue, Feb 15, 2022 at 9:38 AM Aleksey Shipilev wrote: > On 2/15/22 12:24, Andrew Leonard wrote: > > I have 2 jdk commits I want to backport to jdk17u-dev that are dependent > on > > each other, one fixes an issue in the first one. > > How do I achieve that with the Skara commands? > > The 2nd one will not backport cleanly without the first as it modifies > code > > from the 1st, so they sort of need doing together? > > Or do I just do the 1st, then do the 2nd separately. > > Like this: > https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html > > -- > Thanks, > -Aleksey > > From anleonar at redhat.com Tue Feb 15 10:00:10 2022 From: anleonar at redhat.com (Andrew Leonard) Date: Tue, 15 Feb 2022 10:00:10 +0000 Subject: How do I backport two jdk->jdk17u-dev commits together? In-Reply-To: References: <55db22c8-1240-8e11-de17-33c44dfb94c1@redhat.com> Message-ID: Ideally I want to put two commits from jdk into 1 backport PR ... On Tue, Feb 15, 2022 at 9:58 AM Andrew Leonard wrote: > Thank Aleksey, > If I understand that correctly, i'm not sure that will quite work for my > scenario, as my 1st PR is not dependent on the 2nd PR, the 2nd PR is a fix > to a problem found in the 1st PR. > So essentially: > PR1: added some code... > PR2: fixed a problem with the code added in PR1 > So PR2 depends on PR1, but ideally I don't want to integrate PR1 before > PR2, but it would not harm to do so it just wouldn't fully function until > PR2 is also backported. > So summing that all up effectively for correct functioning PR1 depends on > PR2 and PR2 depends on PR1 (gosh hope that makes sense!) > > I feel as though I should do PR1 but apply it manually including the PR2 > fix, ie.bundle both into one backport PR ? > > Thanks > Andrew > > > On Tue, Feb 15, 2022 at 9:38 AM Aleksey Shipilev wrote: > >> On 2/15/22 12:24, Andrew Leonard wrote: >> > I have 2 jdk commits I want to backport to jdk17u-dev that are >> dependent on >> > each other, one fixes an issue in the first one. >> > How do I achieve that with the Skara commands? >> > The 2nd one will not backport cleanly without the first as it modifies >> code >> > from the 1st, so they sort of need doing together? >> > Or do I just do the 1st, then do the 2nd separately. >> >> Like this: >> https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html >> >> -- >> Thanks, >> -Aleksey >> >> From aleonard at openjdk.java.net Tue Feb 15 10:16:28 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 15 Feb 2022 10:16:28 GMT Subject: [jdk17u-dev] RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER Message-ID: Adds support for configure argument --with-build-user=, which allows openjdk builds to use a generic username to allow deterministic "reproducible" build output. ------------- Commit messages: - Backport f41e768bba2b2ce3b3cc5813ccb1ac4984dcefbd Changes: https://git.openjdk.java.net/jdk17u-dev/pull/163/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=163&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277762 Stats: 17 lines in 2 files changed: 11 ins; 5 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/163.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/163/head:pull/163 PR: https://git.openjdk.java.net/jdk17u-dev/pull/163 From sgehwolf at redhat.com Tue Feb 15 10:43:28 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Tue, 15 Feb 2022 11:43:28 +0100 Subject: How do I backport two jdk->jdk17u-dev commits together? In-Reply-To: References: <55db22c8-1240-8e11-de17-33c44dfb94c1@redhat.com> Message-ID: On Tue, 2022-02-15 at 10:00 +0000, Andrew Leonard wrote: > Ideally I want to put two commits from jdk into 1 backport PR ... We prefer backports to be done the same way as they got integrated in JDK head. So there is no great way to do this. More below. > On Tue, Feb 15, 2022 at 9:58 AM Andrew Leonard wrote: > > > Thank Aleksey, > > If I understand that correctly, i'm not sure that will quite work for my > > scenario, as my 1st PR is not dependent on the 2nd PR, the 2nd PR is a fix > > to a problem found in the 1st PR. > > So essentially: > > PR1: added some code... > > PR2: fixed a problem with the code added in PR1 > > So PR2 depends on PR1, but ideally I don't want to integrate PR1 before > > PR2, but it would not harm to do so it just wouldn't fully function until > > PR2 is also backported. > > So summing that all up effectively for correct functioning PR1 depends on > > PR2 and PR2 depends on PR1 (gosh hope that makes sense!) > > > > I feel as though I should do PR1 but apply it manually including the PR2 > > fix, ie.bundle both into one backport PR ? > > Backport the first fix, and also backport the follow-up fix. Test them together (locally). Eventually they'll get integrated at the same time (or shortly one after another). Testing wise it would be largely invisible. Using the dependent PR feature for this is a nice to have. Maintainers would (usually) insist on getting follow-up fixes backported too and making approvals conditional on the follow-up fix getting integrated at the same time. Hope that makes sense. Thanks, Severin From anleonar at redhat.com Tue Feb 15 10:57:09 2022 From: anleonar at redhat.com (Andrew Leonard) Date: Tue, 15 Feb 2022 10:57:09 +0000 Subject: How do I backport two jdk->jdk17u-dev commits together? In-Reply-To: References: <55db22c8-1240-8e11-de17-33c44dfb94c1@redhat.com> Message-ID: Thanks Severin, yes, makes sense, cheers Andrew On Tue, Feb 15, 2022 at 10:43 AM Severin Gehwolf wrote: > On Tue, 2022-02-15 at 10:00 +0000, Andrew Leonard wrote: > > Ideally I want to put two commits from jdk into 1 backport PR ... > > We prefer backports to be done the same way as they got integrated in > JDK head. So there is no great way to do this. More below. > > > On Tue, Feb 15, 2022 at 9:58 AM Andrew Leonard > wrote: > > > > > Thank Aleksey, > > > If I understand that correctly, i'm not sure that will quite work for > my > > > scenario, as my 1st PR is not dependent on the 2nd PR, the 2nd PR is a > fix > > > to a problem found in the 1st PR. > > > So essentially: > > > PR1: added some code... > > > PR2: fixed a problem with the code added in PR1 > > > So PR2 depends on PR1, but ideally I don't want to integrate PR1 before > > > PR2, but it would not harm to do so it just wouldn't fully function > until > > > PR2 is also backported. > > > So summing that all up effectively for correct functioning PR1 depends > on > > > PR2 and PR2 depends on PR1 (gosh hope that makes sense!) > > > > > > I feel as though I should do PR1 but apply it manually including the > PR2 > > > fix, ie.bundle both into one backport PR ? > > > > > Backport the first fix, and also backport the follow-up fix. Test them > together (locally). Eventually they'll get integrated at the same time > (or shortly one after another). Testing wise it would be largely > invisible. Using the dependent PR feature for this is a nice to have. > > Maintainers would (usually) insist on getting follow-up fixes > backported too and making approvals conditional on the follow-up fix > getting integrated at the same time. > > Hope that makes sense. > > Thanks, > Severin > > From abakhtin at openjdk.java.net Tue Feb 15 11:24:22 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Tue, 15 Feb 2022 11:24:22 GMT Subject: [jdk13u-dev] Integrated: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 13:51:17 GMT, Alexey Bakhtin wrote: > Backport of JDK-8274524 to JDK13u-dev > Backport is almost clean except for trivial fix for Pattern Matching in the instanceof (not available in JDK13) > sun/security/ssl/SSLSocketImpl tests passed This pull request has now been integrated. Changeset: d7b8c97f Author: Alexey Bakhtin Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/d7b8c97f92935a8b43b66f2bc6d2b7994888c5c9 Stats: 153 lines in 2 files changed: 153 ins; 0 del; 0 mod 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Reviewed-by: xuelei Backport-of: 58dae60da0711c4ae0cb23f8ce2328e051d603b2 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/326 From goetz.lindenmaier at sap.com Tue Feb 15 12:04:05 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 15 Feb 2022 12:04:05 +0000 Subject: How do I backport two jdk->jdk17u-dev commits together? In-Reply-To: References: <55db22c8-1240-8e11-de17-33c44dfb94c1@redhat.com> Message-ID: Hi, I added a short section "What to do with changes depending on each other?" in https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix For other backporting issues there is now also https://openjdk.java.net/guide/, but dependent pull requests are not yet covered there. Best regards, Goetz. > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Andrew Leonard > Sent: Tuesday, February 15, 2022 11:57 AM > To: sgehwolf > Cc: Aleksey Shipilev ; jdk-updates- > dev at openjdk.java.net > Subject: Re: How do I backport two jdk->jdk17u-dev commits together? > > Thanks Severin, > yes, makes sense, cheers > Andrew > > On Tue, Feb 15, 2022 at 10:43 AM Severin Gehwolf > wrote: > > > On Tue, 2022-02-15 at 10:00 +0000, Andrew Leonard wrote: > > > Ideally I want to put two commits from jdk into 1 backport PR ... > > > > We prefer backports to be done the same way as they got integrated in > > JDK head. So there is no great way to do this. More below. > > > > > On Tue, Feb 15, 2022 at 9:58 AM Andrew Leonard > > wrote: > > > > > > > Thank Aleksey, > > > > If I understand that correctly, i'm not sure that will quite work for > > my > > > > scenario, as my 1st PR is not dependent on the 2nd PR, the 2nd PR is a > > fix > > > > to a problem found in the 1st PR. > > > > So essentially: > > > > PR1: added some code... > > > > PR2: fixed a problem with the code added in PR1 > > > > So PR2 depends on PR1, but ideally I don't want to integrate PR1 before > > > > PR2, but it would not harm to do so it just wouldn't fully function > > until > > > > PR2 is also backported. > > > > So summing that all up effectively for correct functioning PR1 depends > > on > > > > PR2 and PR2 depends on PR1 (gosh hope that makes sense!) > > > > > > > > I feel as though I should do PR1 but apply it manually including the > > PR2 > > > > fix, ie.bundle both into one backport PR ? > > > > > > > > Backport the first fix, and also backport the follow-up fix. Test them > > together (locally). Eventually they'll get integrated at the same time > > (or shortly one after another). Testing wise it would be largely > > invisible. Using the dependent PR feature for this is a nice to have. > > > > Maintainers would (usually) insist on getting follow-up fixes > > backported too and making approvals conditional on the follow-up fix > > getting integrated at the same time. > > > > Hope that makes sense. > > > > Thanks, > > Severin > > > > From abakhtin at openjdk.java.net Tue Feb 15 12:35:26 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Tue, 15 Feb 2022 12:35:26 GMT Subject: [jdk15u-dev] Integrated: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake In-Reply-To: <_PX93y7YPEKG6NALC9cc535zVpmVDnxmcPWFUah0DJw=.50cc3a95-9b12-4e10-874e-787764fbb188@github.com> References: <_PX93y7YPEKG6NALC9cc535zVpmVDnxmcPWFUah0DJw=.50cc3a95-9b12-4e10-874e-787764fbb188@github.com> Message-ID: On Mon, 14 Feb 2022 13:50:22 GMT, Alexey Bakhtin wrote: > Backport of JDK-8274524 to JDK15u-dev > Backport is almost clean except trivial fix for Pattern Matching in the instanceof (not available in JDK15) > sun/security/ssl/SSLSocketImpl tests passed This pull request has now been integrated. Changeset: 8d25af47 Author: Alexey Bakhtin Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/8d25af47dba21054a7c2ca0d09764f2f7035cc82 Stats: 153 lines in 2 files changed: 153 ins; 0 del; 0 mod 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Reviewed-by: yan Backport-of: 58dae60da0711c4ae0cb23f8ce2328e051d603b2 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/176 From aleonard at openjdk.java.net Tue Feb 15 13:33:41 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 15 Feb 2022 13:33:41 GMT Subject: [jdk17u-dev] RFR: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation Message-ID: Provide a new configure argument --with-cacerts-src=, that allows openjdk builds to specify their own source of cacerts, similar to the existing --with-cacerts-file option for pre-built ketstores, but this new option allows builds to use the GenerateCacerts openjdk tooling which produces a deterministic "reproducible" keystore. ------------- Commit messages: - Backport dc2abc9f05c2b7c52aeb242082359c48963f9854 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/164/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=164&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278080 Stats: 22 lines in 3 files changed: 22 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/164.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/164/head:pull/164 PR: https://git.openjdk.java.net/jdk17u-dev/pull/164 From aleonard at openjdk.java.net Tue Feb 15 13:33:41 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 15 Feb 2022 13:33:41 GMT Subject: [jdk17u-dev] RFR: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 13:25:10 GMT, Andrew Leonard wrote: > Provide a new configure argument --with-cacerts-src=, that allows openjdk builds to specify their own source of cacerts, similar to the existing --with-cacerts-file option for pre-built ketstores, but this new option allows builds to use the GenerateCacerts openjdk tooling which produces a deterministic "reproducible" keystore. This PR should be merged along with the follow up fix: https://github.com/openjdk/jdk/commit/45da3aea22fd85f214e661b2c98631cb91ddb55d#commitcomment-66719435 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/164 From vkempik at openjdk.java.net Tue Feb 15 14:13:13 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 15 Feb 2022 14:13:13 GMT Subject: [jdk11u-dev] Integrated: 8253795: Implementation of JEP 391: macOS/AArch64 Port In-Reply-To: References: Message-ID: On Mon, 13 Dec 2021 20:11:31 GMT, Vladimir Kempik wrote: > Initial version of JEP-391 backport to jdk11u. > Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part. > Things needing attention: os_bsd_aarch64.cpp and W^X transitions. > serviceability agent is mostly clean. > This passed GHA_tier1 testing. > Full regression testing is running now on Azul's infra, will report/update PR when done. > **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11** > Sharing this PR slightly earlier to let other interested parties to run the tests too. > Example of cross-building on intel mac (needs Xcode12/13): > sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin This pull request has now been integrated. Changeset: eb0708f7 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/eb0708f75aa3c196e41014addfaa5667fd940cc2 Stats: 3164 lines in 76 files changed: 3051 ins; 28 del; 85 mod 8253795: Implementation of JEP 391: macOS/AArch64 Port 8253816: Support macOS W^X 8253817: Support macOS Aarch64 ABI in Interpreter 8253818: Support macOS Aarch64 ABI for compiled wrappers 8253819: Implement os/cpu for macOS/AArch64 8253839: Update tests and JDK code for macOS/Aarch64 8254941: Implement Serviceability Agent for macOS/AArch64 8255776: Change build system for macOS/AArch64 8262903: [macos_aarch64] Thread::current() called on detached thread 8262896: [macos_aarch64] Crash in jni_fast_GetLongField Reviewed-by: adinn, burban, aph Backport-of: dbc9e4b50cdda35f5712deaf440c49f50b9edc96 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/715 From duke at openjdk.java.net Tue Feb 15 14:16:11 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Tue, 15 Feb 2022 14:16:11 GMT Subject: [jdk11u-dev] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2] In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 10:30:41 GMT, Vladimir Kempik wrote: >> Please review this backport. Not applying clean. A follow up patch for jep-391 backport > > Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: > > Redo the fix, start trannsition earlier The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8253795 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/817 From vkempik at openjdk.java.net Tue Feb 15 14:20:55 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 15 Feb 2022 14:20:55 GMT Subject: [jdk11u-dev] RFR: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 [v2] In-Reply-To: References: Message-ID: > Pleas review this backport to jdk11u-dev. > It's one of few follow up fixes for jep-391 backport. > This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread > Not applying clean due to context code difference in chunk 2. > In JDK17 it's - ThreadStateTransition::transition() > in JDK11 it's - ThreadStateTransition::transition_and_fence() Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision: - 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 Co-authored-by: Mikael Vidstedt Reviewed-by: dholmes, gziemski - Fix wrong patch from jep-388 backport - Merge branch 'master' into JDK-8253795 - Add two missing WX transitions - Ignore TestOnError.java on macos_aarch64 - Merge branch 'master' into JDK-8253795 - remove unused at_rsp from aarch64 - Fix warning about c++11 extension - Exclude test CompressedClassPointers.java on macarm - Merge pull request #1 from VladimirKempik/JEP391_and_8262896 8262896: [macos_aarch64] Crash in jni_fast_GetLongField - ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/9fcf9979...720d1ee5 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/816/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/816/files/720d1ee5..720d1ee5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=816&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=816&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/816.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/816/head:pull/816 PR: https://git.openjdk.java.net/jdk11u-dev/pull/816 From duke at openjdk.java.net Tue Feb 15 14:20:55 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Tue, 15 Feb 2022 14:20:55 GMT Subject: [jdk11u-dev] RFR: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 21:35:38 GMT, Vladimir Kempik wrote: > Pleas review this backport to jdk11u-dev. > It's one of few follow up fixes for jep-391 backport. > This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread > Not applying clean due to context code difference in chunk 2. > In JDK17 it's - ThreadStateTransition::transition() > in JDK11 it's - ThreadStateTransition::transition_and_fence() The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8253795 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/816 From vkempik at openjdk.java.net Tue Feb 15 14:56:24 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 15 Feb 2022 14:56:24 GMT Subject: [jdk11u-dev] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v3] In-Reply-To: References: Message-ID: > Please review this backport. Not applying clean. A follow up patch for jep-391 backport Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Merge master - Redo the fix, start trannsition earlier - [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run - Fix wrong patch from jep-388 backport - Merge branch 'master' into JDK-8253795 - Add two missing WX transitions - Ignore TestOnError.java on macos_aarch64 - Merge branch 'master' into JDK-8253795 - remove unused at_rsp from aarch64 - Fix warning about c++11 extension - ... and 6 more: https://git.openjdk.java.net/jdk11u-dev/compare/eb0708f7...7a0f9eda ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/817/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=817&range=02 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/817.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/817/head:pull/817 PR: https://git.openjdk.java.net/jdk11u-dev/pull/817 From vkempik at openjdk.java.net Tue Feb 15 15:02:37 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 15 Feb 2022 15:02:37 GMT Subject: [jdk11u-dev] RFR: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 [v3] In-Reply-To: References: Message-ID: <-M-T_3OuyNm6VfttG_QezmkiCjdDgALviEGGICI7ajw=.d09af235-daed-46ff-be04-226c338d9e91@github.com> > Pleas review this backport to jdk11u-dev. > It's one of few follow up fixes for jep-391 backport. > This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread > Not applying clean due to context code difference in chunk 2. > In JDK17 it's - ThreadStateTransition::transition() > in JDK11 it's - ThreadStateTransition::transition_and_fence() Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits: - Merge master - 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 Co-authored-by: Mikael Vidstedt Reviewed-by: dholmes, gziemski - Fix wrong patch from jep-388 backport - Merge branch 'master' into JDK-8253795 - Add two missing WX transitions - Ignore TestOnError.java on macos_aarch64 - Merge branch 'master' into JDK-8253795 - remove unused at_rsp from aarch64 - Fix warning about c++11 extension - Exclude test CompressedClassPointers.java on macarm - ... and 5 more: https://git.openjdk.java.net/jdk11u-dev/compare/eb0708f7...f57817ef ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/816/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=816&range=02 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/816.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/816/head:pull/816 PR: https://git.openjdk.java.net/jdk11u-dev/pull/816 From yan at openjdk.java.net Tue Feb 15 15:04:48 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 15 Feb 2022 15:04:48 GMT Subject: [jdk15u-dev] RFR: 8249867: XML declaration is not followed by a newline Message-ID: The changes in original are all in copyright/comments, so this backport may be considered clean. We should wait for CSR approval, however. ------------- Commit messages: - Backport 69ee314b63a9f260e3dcbe9ccd67ddc4faec3ba0 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/178/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=178&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8249867 Stats: 478 lines in 5 files changed: 428 ins; 2 del; 48 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/178.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/178/head:pull/178 PR: https://git.openjdk.java.net/jdk15u-dev/pull/178 From goetz at openjdk.java.net Tue Feb 15 15:08:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Feb 2022 15:08:08 GMT Subject: [jdk11u-dev] RFR: 8241004: NMT tests fail on unaligned thread size with debug build In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 23:51:51 GMT, Ahmed Muhsin wrote: > Backport of [JDK-8241004](https://bugs.openjdk.java.net/browse/JDK-8241004). Applies cleanly. > > This is will prevent hotspot runtime/NMT test failures on mac-aarch64. See issue 2 in this comment for more context: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1020401252 @ahmedmuhsin should this be integrated as the aarch port was pushed? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/812 From goetz at openjdk.java.net Tue Feb 15 15:30:23 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Feb 2022 15:30:23 GMT Subject: [jdk11u-dev] RFR: Backport dcd8f03c06f0ca2b87c73a259f2ec1e9fdac258f In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 07:31:11 GMT, Kimura Yukihiro wrote: > This is a backport of JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale. > Original patch applies cleanly to 11u. > > Testing: > build on Windows x86_64 and Linux x86_64 > tier1 on Windows x86_64 and Linux x86_64 > a specific test to confirm the fix in Japanese locale > > Could you please review this PR? Hi, sure, take your time. It needs to be the hash of the existing commit: b46d73bee808af7891b699df30a5a6dec3f5139f (the full, not the abbreviated. GitHub abbreviates it) (If there are several existing commits, e.g. for 19 and 17.0.3, you can choose either.) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/824 From duke at openjdk.java.net Tue Feb 15 16:34:15 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Tue, 15 Feb 2022 16:34:15 GMT Subject: [jdk11u-dev] RFR: 8241004: NMT tests fail on unaligned thread size with debug build In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 15:04:50 GMT, Goetz Lindenmaier wrote: >> Backport of [JDK-8241004](https://bugs.openjdk.java.net/browse/JDK-8241004). Applies cleanly. >> >> This is will prevent hotspot runtime/NMT test failures on mac-aarch64. See issue 2 in this comment for more context: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1020401252 > > @ahmedmuhsin should this be integrated as the aarch port was pushed? @GoeLin Yes, it should. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/812 From vkempik at openjdk.java.net Tue Feb 15 17:18:30 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 15 Feb 2022 17:18:30 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 [v2] In-Reply-To: References: Message-ID: > Please review this backport of JDK-8260518 to jdk11u-dev > The backport is not applying clean due to the context code difference. > It's needed mostly to resolve this compilation error on macos-aarch64 > splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] > This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into JDK-8260518 - 8260518: Change default -mmacosx-version-min to 10.12 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/810/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=810&range=01 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/810.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/810/head:pull/810 PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From vkempik at openjdk.java.net Tue Feb 15 17:29:29 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 15 Feb 2022 17:29:29 GMT Subject: [jdk11u-dev] RFR: 8263856: Github Actions for macos/aarch64 cross-build Message-ID: PLease review this backport to jdk11u-dev it enables github CI crossbuilds of macos-aarch64 Not applying clean due to gtest and few configure options, remade the patch basing on macos-intel part of existing jdk11u-dev job ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/810 Commit messages: - 8263856: Github Actions for macos/aarch64 cross-build Changes: https://git.openjdk.java.net/jdk11u-dev/pull/826/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=826&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263856 Stats: 103 lines in 1 file changed: 103 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/826.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/826/head:pull/826 PR: https://git.openjdk.java.net/jdk11u-dev/pull/826 From phh at openjdk.java.net Tue Feb 15 17:44:07 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 15 Feb 2022 17:44:07 GMT Subject: [jdk11u-dev] RFR: 8263856: Github Actions for macos/aarch64 cross-build In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 17:22:20 GMT, Vladimir Kempik wrote: > PLease review this backport to jdk11u-dev > it enables github CI crossbuilds of macos-aarch64 > Not applying clean due to gtest and few configure options, remade the patch basing on macos-intel part of existing jdk11u-dev job Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/826 From duke at openjdk.java.net Tue Feb 15 18:34:06 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Tue, 15 Feb 2022 18:34:06 GMT Subject: [jdk11u-dev] RFR: 8241004: NMT tests fail on unaligned thread size with debug build In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 23:51:51 GMT, Ahmed Muhsin wrote: > Backport of [JDK-8241004](https://bugs.openjdk.java.net/browse/JDK-8241004). Applies cleanly. > > This is will prevent hotspot runtime/NMT test failures on mac-aarch64. See issue 2 in this comment for more context: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1020401252 I will need a couple of reviewers. @VladimirKempik @lewurm, If you don't mind, can you review this PR? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/812 From vkempik at openjdk.java.net Tue Feb 15 18:34:06 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 15 Feb 2022 18:34:06 GMT Subject: [jdk11u-dev] RFR: 8241004: NMT tests fail on unaligned thread size with debug build In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 23:51:51 GMT, Ahmed Muhsin wrote: > Backport of [JDK-8241004](https://bugs.openjdk.java.net/browse/JDK-8241004). Applies cleanly. > > This is will prevent hotspot runtime/NMT test failures on mac-aarch64. See issue 2 in this comment for more context: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1020401252 You don't. Your backport is a clean backport, you have "clean" label on this PR. So You don't need review for this. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/812 From duke at openjdk.java.net Tue Feb 15 19:39:08 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Tue, 15 Feb 2022 19:39:08 GMT Subject: [jdk11u-dev] Integrated: 8241004: NMT tests fail on unaligned thread size with debug build In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 23:51:51 GMT, Ahmed Muhsin wrote: > Backport of [JDK-8241004](https://bugs.openjdk.java.net/browse/JDK-8241004). Applies cleanly. > > This is will prevent hotspot runtime/NMT test failures on mac-aarch64. See issue 2 in this comment for more context: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1020401252 This pull request has now been integrated. Changeset: aa42c4d7 Author: Ahmed Muhsin Committer: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/aa42c4d71fd4c837f1a63df844e22f9d9d459bae Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8241004: NMT tests fail on unaligned thread size with debug build Backport-of: 0b20eafb30cc1de372141f2a427d13fdc6565e3a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/812 From rkovacs at openjdk.java.net Tue Feb 15 21:30:37 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 15 Feb 2022 21:30:37 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v5] In-Reply-To: References: Message-ID: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> > Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: > > - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. > - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. > - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). > - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. > - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) > > This is part of the Windows/AArch64 port. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Replace C-style casts with checked_cast - Use size_t in generate_disjoint_copy - Explain disabled MSVC warning C4146 in comment - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits - Backport d2812f780e87511736f2d41bc57a69c2a898b583 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/280/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=280&range=04 Stats: 36 lines in 11 files changed: 8 ins; 5 del; 23 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/280.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/280/head:pull/280 PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From rkovacs at openjdk.java.net Tue Feb 15 21:30:39 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 15 Feb 2022 21:30:39 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4] In-Reply-To: References: Message-ID: <53cJLJp5uAy10gydXq_bOzIlFgLJ-0-oYdJfanKfKhI=.f12569d6-ace8-4d96-96b3-63d7a02fc92c@github.com> On Sat, 12 Feb 2022 17:40:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request incrementally with one additional commit since the last revision: > > Replace C-style casts with checked_cast Rebased to latest master to fix merge conflict. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From duke at openjdk.java.net Wed Feb 16 01:26:38 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Wed, 16 Feb 2022 01:26:38 GMT Subject: [jdk11u-dev] RFR: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale [v2] In-Reply-To: References: Message-ID: > This is a backport of JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale. > Original patch applies cleanly to 11u. > > Testing: > build on Windows x86_64 and Linux x86_64 > tier1 on Windows x86_64 and Linux x86_64 > a specific test to confirm the fix in Japanese locale > > Could you please review this PR? Kimura Yukihiro has updated the pull request incrementally with two additional commits since the last revision: - Merge branch '8255239' of https://github.com/yukikimmura/jdk11u-dev into 8255239 - Backport b46d73bee808af7891b699df30a5a6dec3f5139f ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/824/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/824/files/5ff7e8aa..895a4977 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=824&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=824&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/824.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/824/head:pull/824 PR: https://git.openjdk.java.net/jdk11u-dev/pull/824 From rkovacs at openjdk.java.net Wed Feb 16 02:50:16 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Wed, 16 Feb 2022 02:50:16 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v5] In-Reply-To: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> References: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> Message-ID: <_eMOBLg3EqbQbBMd9NBxGfQEe0mYGaRVt1A6On9wODs=.4eec1dde-3da6-4367-b86d-491c4103d10c@github.com> On Tue, 15 Feb 2022 21:30:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Replace C-style casts with checked_cast > - Use size_t in generate_disjoint_copy > - Explain disabled MSVC warning C4146 in comment > - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits > - Backport d2812f780e87511736f2d41bc57a69c2a898b583 The one test that fails on Linux x64 and x86 (`runtime/Thread/StopAtExit.java`) is not specific to this patch, it also fails for this unrelated PR: https://github.com/openjdk/jdk11u-dev/pull/817 Could someone please sponsor the change? @theRealAph or @GoeLin maybe? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From duke at openjdk.java.net Wed Feb 16 06:41:21 2022 From: duke at openjdk.java.net (Yi-Fan Tsai) Date: Wed, 16 Feb 2022 06:41:21 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port Message-ID: 8247589: Implementation of Alpine Linux/x64 Port ------------- Commit messages: - Fix backports - 8247589: Implementation of Alpine Linux/x64 Port Changes: https://git.openjdk.java.net/jdk11u-dev/pull/827/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=827&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247589 Stats: 432 lines in 34 files changed: 345 ins; 42 del; 45 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/827.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/827/head:pull/827 PR: https://git.openjdk.java.net/jdk11u-dev/pull/827 From vkempik at openjdk.java.net Wed Feb 16 07:57:15 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 16 Feb 2022 07:57:15 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v5] In-Reply-To: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> References: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> Message-ID: On Tue, 15 Feb 2022 21:30:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Replace C-style casts with checked_cast > - Use size_t in generate_disjoint_copy > - Explain disabled MSVC warning C4146 in comment > - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits > - Backport d2812f780e87511736f2d41bc57a69c2a898b583 it lost label "sponsor", so you probably need to /integrate again ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From stuefe at openjdk.java.net Wed Feb 16 08:20:31 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 16 Feb 2022 08:20:31 GMT Subject: [jdk17u] Withdrawn: 8277383: VM.metaspace optionally show chunk freelist details In-Reply-To: <25g9vykTSEDr0Py2Pgwo_4RxVSveo-S21Cvm_c9ZzTU=.872a5a47-a204-41e3-a5ca-f1db6c1b66e9@github.com> References: <25g9vykTSEDr0Py2Pgwo_4RxVSveo-S21Cvm_c9ZzTU=.872a5a47-a204-41e3-a5ca-f1db6c1b66e9@github.com> Message-ID: On Tue, 8 Feb 2022 07:10:10 GMT, Thomas Stuefe wrote: > I'd like to backport this to jdk17 since it adds a useful option for metaspace analysis. Fix is low risk and applies cleanly. > > The commit being backported was authored by Thomas Stuefe on 7 Dec 2021 and was reviewed by Coleen Phillimore and Aleksey Shipilev. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/333 From stuefe at openjdk.java.net Wed Feb 16 08:21:28 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 16 Feb 2022 08:21:28 GMT Subject: [jdk17u] Withdrawn: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests In-Reply-To: <-VqDm9pdNsO6xWJmhRdDLqnJjhWdP5pDLwykobh84Wo=.3b0b52f2-061e-4626-8c00-257758436e25@github.com> References: <-VqDm9pdNsO6xWJmhRdDLqnJjhWdP5pDLwykobh84Wo=.3b0b52f2-061e-4626-8c00-257758436e25@github.com> Message-ID: On Tue, 8 Feb 2022 07:04:56 GMT, Thomas Stuefe wrote: > Hi all, > > I'd like to backport this little enhancement to cut down on testing time in jdk17u. The fix is low risk and has been in jdk18+ since last September. Fix applies cleanly. > > The commit being backported was authored by Thomas Stuefe on 4 Aug 2021 and was reviewed by Thomas Schatzl and Richard Reingruber. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/332 From mbaesken at openjdk.java.net Wed Feb 16 08:30:26 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 16 Feb 2022 08:30:26 GMT Subject: [jdk17u-dev] Integrated: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 08:16:19 GMT, Matthias Baesken wrote: > 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches This pull request has now been integrated. Changeset: 0e5810d1 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/0e5810d121d42185f53e653a620895422123d7ce Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches Backport-of: bb74ae87abee0fb550e4138242919ec791f7791c ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/162 From vkempik at openjdk.java.net Wed Feb 16 08:32:10 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 16 Feb 2022 08:32:10 GMT Subject: [jdk11u-dev] Integrated: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 07:08:28 GMT, Vladimir Kempik wrote: > Please review this backport. Not applying clean. A follow up patch for jep-391 backport This pull request has now been integrated. Changeset: 69583df3 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/69583df39b50e08ab7b21d019a5c8b7364e53165 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run Reviewed-by: akozlov, adinn, burban Backport-of: 381bd621074a13cc2f260c18371c956bc48abd4d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/817 From vkempik at openjdk.java.net Wed Feb 16 08:34:04 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 16 Feb 2022 08:34:04 GMT Subject: [jdk11u-dev] Integrated: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 21:35:38 GMT, Vladimir Kempik wrote: > Pleas review this backport to jdk11u-dev. > It's one of few follow up fixes for jep-391 backport. > This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread > Not applying clean due to context code difference in chunk 2. > In JDK17 it's - ThreadStateTransition::transition() > in JDK11 it's - ThreadStateTransition::transition_and_fence() This pull request has now been integrated. Changeset: 0aa5f75d Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/0aa5f75d7af2f04c93fd066e17e624f92f4f998f Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 Reviewed-by: adinn, burban Backport-of: 8a4a9117f5e615080c9530ad0ab1a90852bbc854 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/816 From mbaesken at openjdk.java.net Wed Feb 16 08:40:48 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 16 Feb 2022 08:40:48 GMT Subject: [jdk17u-dev] RFR: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine Message-ID: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine ------------- Commit messages: - Backport fd8cb2dae87e5726e89a1789e5a1ddd461c4400d Changes: https://git.openjdk.java.net/jdk17u-dev/pull/165/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=165&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278346 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/165.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/165/head:pull/165 PR: https://git.openjdk.java.net/jdk17u-dev/pull/165 From yan at openjdk.java.net Wed Feb 16 10:07:52 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 16 Feb 2022 10:07:52 GMT Subject: [jdk13u-dev] RFR: 8249867: XML declaration is not followed by a newline Message-ID: <12m5KmDdxb7pOmhnVRVDB49X_CHmE2KQxcUxjSZC0Cw=.4c3f38e5-5ac3-4fb7-85b6-cb27bd9e006c@github.com> Backport of this change differs from the original in copyright dates/lastchanged comments and a list of bugs in the test. We need this fix to be on par with LTS releases. Required CSR is approved. ------------- Commit messages: - Backport 69ee314b63a9f260e3dcbe9ccd67ddc4faec3ba0 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/328/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=328&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8249867 Stats: 476 lines in 5 files changed: 428 ins; 2 del; 46 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/328.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/328/head:pull/328 PR: https://git.openjdk.java.net/jdk13u-dev/pull/328 From bae at openjdk.java.net Wed Feb 16 10:16:21 2022 From: bae at openjdk.java.net (Andrew Brygin) Date: Wed, 16 Feb 2022 10:16:21 GMT Subject: [jdk15u-dev] RFR: 8249867: XML declaration is not followed by a newline In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 14:56:16 GMT, Yuri Nesterenko wrote: > The changes in original are all in copyright/comments, so this backport may be considered clean. We should wait for CSR approval, however. The proposed change looks good to me. Thanks, Andrew ------------- Marked as reviewed by bae (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/178 From yan at openjdk.java.net Wed Feb 16 10:43:08 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 16 Feb 2022 10:43:08 GMT Subject: [jdk15u-dev] Integrated: 8249867: XML declaration is not followed by a newline In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 14:56:16 GMT, Yuri Nesterenko wrote: > The changes in original are all in copyright/comments, so this backport may be considered clean. We should wait for CSR approval, however. This pull request has now been integrated. Changeset: b01d9799 Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/b01d979908690f6e677cb856b1176b84e4779b81 Stats: 478 lines in 5 files changed: 428 ins; 2 del; 48 mod 8249867: XML declaration is not followed by a newline Reviewed-by: bae Backport-of: 69ee314b63a9f260e3dcbe9ccd67ddc4faec3ba0 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/178 From stuefe at openjdk.java.net Wed Feb 16 11:46:23 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 16 Feb 2022 11:46:23 GMT Subject: [jdk17u-dev] RFR: 8281460: Let ObjectMonitor have its own NMT category Message-ID: Hi all, Clean backport, small fix and low risk. I'd like to backport this to make it more obvious if a VM uses a lot of memory for Object Monitors. Before this patch, this number was hidden in mtInternal. Thanks, Thomas ------------- Commit messages: - Backport a037b3c35831f029d23a88bdd49e7f2c2d951631 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/166/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=166&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281460 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/166.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/166/head:pull/166 PR: https://git.openjdk.java.net/jdk17u-dev/pull/166 From bae at openjdk.java.net Wed Feb 16 12:03:16 2022 From: bae at openjdk.java.net (Andrew Brygin) Date: Wed, 16 Feb 2022 12:03:16 GMT Subject: [jdk13u-dev] RFR: 8249867: XML declaration is not followed by a newline In-Reply-To: <12m5KmDdxb7pOmhnVRVDB49X_CHmE2KQxcUxjSZC0Cw=.4c3f38e5-5ac3-4fb7-85b6-cb27bd9e006c@github.com> References: <12m5KmDdxb7pOmhnVRVDB49X_CHmE2KQxcUxjSZC0Cw=.4c3f38e5-5ac3-4fb7-85b6-cb27bd9e006c@github.com> Message-ID: <2jcC5BOASWbjhkikwntXEPloBHRcoKFxHbDyIHCqMjY=.2dd3cdfd-94f4-46f8-996e-cb3e3e67da49@github.com> On Wed, 16 Feb 2022 09:59:20 GMT, Yuri Nesterenko wrote: > Backport of this change differs from the original in copyright dates/lastchanged comments and a list of bugs in the test. We need this fix to be on par with LTS releases. Required CSR is approved. The change looks fine to me. Thanks, Andrew ------------- Marked as reviewed by bae (Reviewer). PR: https://git.openjdk.java.net/jdk13u-dev/pull/328 From yan at openjdk.java.net Wed Feb 16 12:54:12 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 16 Feb 2022 12:54:12 GMT Subject: [jdk13u-dev] Integrated: 8249867: XML declaration is not followed by a newline In-Reply-To: <12m5KmDdxb7pOmhnVRVDB49X_CHmE2KQxcUxjSZC0Cw=.4c3f38e5-5ac3-4fb7-85b6-cb27bd9e006c@github.com> References: <12m5KmDdxb7pOmhnVRVDB49X_CHmE2KQxcUxjSZC0Cw=.4c3f38e5-5ac3-4fb7-85b6-cb27bd9e006c@github.com> Message-ID: On Wed, 16 Feb 2022 09:59:20 GMT, Yuri Nesterenko wrote: > Backport of this change differs from the original in copyright dates/lastchanged comments and a list of bugs in the test. We need this fix to be on par with LTS releases. Required CSR is approved. This pull request has now been integrated. Changeset: b9c0ba83 Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/b9c0ba838ea83d4e2957a3b4efcd786717d0a02f Stats: 476 lines in 5 files changed: 428 ins; 2 del; 46 mod 8249867: XML declaration is not followed by a newline Reviewed-by: bae Backport-of: 69ee314b63a9f260e3dcbe9ccd67ddc4faec3ba0 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/328 From duke at openjdk.java.net Wed Feb 16 16:01:55 2022 From: duke at openjdk.java.net (Mat Carter) Date: Wed, 16 Feb 2022 16:01:55 GMT Subject: [jdk18u] RFR: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled Message-ID: <1XUfR1FJhZHTR33TY3flyOuu0jH7dvhzO26kzXPOfb8=.d5bfa6c3-a6da-477d-90ac-8b636a9e39ac@github.com> Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 ------------- Commit messages: - Backport 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 Changes: https://git.openjdk.java.net/jdk18u/pull/25/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=25&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272996 Stats: 19 lines in 1 file changed: 11 ins; 6 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/25/head:pull/25 PR: https://git.openjdk.java.net/jdk18u/pull/25 From aleonard at openjdk.java.net Wed Feb 16 16:04:30 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Wed, 16 Feb 2022 16:04:30 GMT Subject: [jdk17u-dev] RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER In-Reply-To: References: Message-ID: <6tCGaIbVFFi5_QkXeXdki60Cv4Jm5bbDI6W0HwhWQSI=.0a78ef1e-d7f5-4b28-bb56-715c78dc0c7a@github.com> On Tue, 15 Feb 2022 10:07:56 GMT, Andrew Leonard wrote: > Adds support for configure argument --with-build-user=, which allows openjdk builds to use a generic username to allow deterministic "reproducible" build output. Is someone able to sponsor this please? ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/163 From goetz at openjdk.java.net Wed Feb 16 16:28:42 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Feb 2022 16:28:42 GMT Subject: [jdk17u-dev] RFR: 8276141: XPathFactory set/getProperty method Message-ID: I backport this for parity with 17.0.3-oracle. ------------- Commit messages: - Backport b226ab99c872e791d3ed9fca015cf92847904c34 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/167/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=167&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276141 Stats: 258 lines in 5 files changed: 247 ins; 3 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/167.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/167/head:pull/167 PR: https://git.openjdk.java.net/jdk17u-dev/pull/167 From goetz at openjdk.java.net Wed Feb 16 16:52:34 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Feb 2022 16:52:34 GMT Subject: [jdk11u-dev] RFR: 8276141: XPathFactory set/getProperty method Message-ID: I backport this for parity with 11.0.15-oracle. I had to do two straight forward fixes: XPathFactoryImpl Tag @LastModified is adapted in head but does not exist in 11. XPathTest.java A larger hunk did not apply. Simple to patch by hand. ------------- Commit messages: - Fix white space - Backport b226ab99c872e791d3ed9fca015cf92847904c34 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/828/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=828&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276141 Stats: 257 lines in 5 files changed: 247 ins; 3 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/828.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/828/head:pull/828 PR: https://git.openjdk.java.net/jdk11u-dev/pull/828 From rkovacs at openjdk.java.net Wed Feb 16 17:34:21 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Wed, 16 Feb 2022 17:34:21 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v5] In-Reply-To: References: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> Message-ID: On Wed, 16 Feb 2022 07:53:41 GMT, Vladimir Kempik wrote: >> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: >> >> - Replace C-style casts with checked_cast >> - Use size_t in generate_disjoint_copy >> - Explain disabled MSVC warning C4146 in comment >> - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits >> - Backport d2812f780e87511736f2d41bc57a69c2a898b583 > > it lost label "sponsor", so you probably need to /integrate again Ah right, thanks @VladimirKempik. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From rkovacs at openjdk.java.net Wed Feb 16 17:34:22 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Wed, 16 Feb 2022 17:34:22 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v5] In-Reply-To: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> References: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> Message-ID: On Tue, 15 Feb 2022 21:30:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Replace C-style casts with checked_cast > - Use size_t in generate_disjoint_copy > - Explain disabled MSVC warning C4146 in comment > - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits > - Backport d2812f780e87511736f2d41bc57a69c2a898b583 Sorry @adinn - could you please try again? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From erikj at openjdk.java.net Wed Feb 16 17:39:35 2022 From: erikj at openjdk.java.net (Erik Joelsson) Date: Wed, 16 Feb 2022 17:39:35 GMT Subject: [jdk18u] Integrated: 8281262: Windows builds in different directories are not fully reproducible Message-ID: Clean backport. ------------- Commit messages: - 8281262: Windows builds in different directories are not fully reproducible Changes: https://git.openjdk.java.net/jdk18u/pull/26/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=26&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281262 Stats: 12 lines in 3 files changed: 7 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jdk18u/pull/26.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/26/head:pull/26 PR: https://git.openjdk.java.net/jdk18u/pull/26 From erikj at openjdk.java.net Wed Feb 16 17:39:36 2022 From: erikj at openjdk.java.net (Erik Joelsson) Date: Wed, 16 Feb 2022 17:39:36 GMT Subject: [jdk18u] Integrated: 8281262: Windows builds in different directories are not fully reproducible In-Reply-To: References: Message-ID: <-1GLgJFElgSwj0ji-3CzvWCBokd4aU1Ne_8pBu4dtBw=.c50c6627-d274-4d6c-a20e-49b36e1f8f48@github.com> On Wed, 16 Feb 2022 17:30:16 GMT, Erik Joelsson wrote: > Clean backport. This pull request has now been integrated. Changeset: d2492c48 Author: Erik Joelsson URL: https://git.openjdk.java.net/jdk18u/commit/d2492c486bd7d6b731525e8087705e611d549dab Stats: 12 lines in 3 files changed: 7 ins; 2 del; 3 mod 8281262: Windows builds in different directories are not fully reproducible Backport-of: d442328bc2f2f4bc35dd054487a78552e3d9a759 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/26 From hseigel at openjdk.java.net Wed Feb 16 18:23:44 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Wed, 16 Feb 2022 18:23:44 GMT Subject: [jdk18u] Integrated: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths Message-ID: Backport of JDK-8281275 to JDK-18u. Patch applied cleanly and backport was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows. Harold ------------- Commit messages: - Backport 84868e39be4522ba87e603beea0f8da9efa43b6d Changes: https://git.openjdk.java.net/jdk18u/pull/27/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=27&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281275 Stats: 28 lines in 2 files changed: 23 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk18u/pull/27.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/27/head:pull/27 PR: https://git.openjdk.java.net/jdk18u/pull/27 From hseigel at openjdk.java.net Wed Feb 16 18:23:45 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Wed, 16 Feb 2022 18:23:45 GMT Subject: [jdk18u] Integrated: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths In-Reply-To: References: Message-ID: <3zaQu3cd6xLeaKqQj0OKP-i0iTmkhbnGXZmq0DYa_pY=.c773762f-4467-4225-af5c-f0a3e2eb8437@github.com> On Wed, 16 Feb 2022 18:13:17 GMT, Harold Seigel wrote: > Backport of JDK-8281275 to JDK-18u. Patch applied cleanly and backport was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows. > Harold This pull request has now been integrated. Changeset: 09dfa48c Author: Harold Seigel URL: https://git.openjdk.java.net/jdk18u/commit/09dfa48cda884c682b681ecc07a71509a44feb4e Stats: 28 lines in 2 files changed: 23 ins; 0 del; 5 mod 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths Backport-of: 84868e39be4522ba87e603beea0f8da9efa43b6d ------------- PR: https://git.openjdk.java.net/jdk18u/pull/27 From duke at openjdk.java.net Wed Feb 16 18:35:15 2022 From: duke at openjdk.java.net (Yi-Fan Tsai) Date: Wed, 16 Feb 2022 18:35:15 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 22:36:08 GMT, Yi-Fan Tsai wrote: > Other commits relating to Alpine Linux/x86 Port are included. > > 2845c3d02979cf51308fff7ce1198d2882bbb6ff 8245938: Remove unused print_stack(void) method from XToolkit.c > 5490b03160deff68a92a8af5ff012db96aad05d8 8252248: __SIGRTMAX is not declared in musl libc > b957d802e6982be56d3a344668d8fd230f20d0df 8252250: isnanf is obsolete > > The following commit is not included, but related change in jdk_util_md.h is added. > > 993b1b0afacdc8d772fe8cbf86411c003b727cca 8249612: Remove unused ISNANF and ISNAND from jdk_util_md.h Bellsoft plans to propose a backport. This PR is withdrawn in favor of the plan. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/827 From duke at openjdk.java.net Wed Feb 16 18:35:15 2022 From: duke at openjdk.java.net (Yi-Fan Tsai) Date: Wed, 16 Feb 2022 18:35:15 GMT Subject: [jdk11u-dev] Withdrawn: 8247589: Implementation of Alpine Linux/x64 Port In-Reply-To: References: Message-ID: <33OeBBkd6K0lNWiWwDeLJFT3NxulOmn586d5VuldJuo=.f5c1376c-d3c1-473a-ab93-a41350943d3a@github.com> On Tue, 15 Feb 2022 22:36:08 GMT, Yi-Fan Tsai wrote: > Other commits relating to Alpine Linux/x86 Port are included. > > 2845c3d02979cf51308fff7ce1198d2882bbb6ff 8245938: Remove unused print_stack(void) method from XToolkit.c > 5490b03160deff68a92a8af5ff012db96aad05d8 8252248: __SIGRTMAX is not declared in musl libc > b957d802e6982be56d3a344668d8fd230f20d0df 8252250: isnanf is obsolete > > The following commit is not included, but related change in jdk_util_md.h is added. > > 993b1b0afacdc8d772fe8cbf86411c003b727cca 8249612: Remove unused ISNANF and ISNAND from jdk_util_md.h This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/827 From rkovacs at openjdk.java.net Wed Feb 16 20:27:13 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Wed, 16 Feb 2022 20:27:13 GMT Subject: [jdk11u-dev] Integrated: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 15:43:20 GMT, Reka Kovacs wrote: > Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: > > - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. > - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. > - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). > - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. > - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: b5f8c318 Author: Reka Kovacs Committer: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/b5f8c318f49859b7faa0d675db6a17b5da797a54 Stats: 36 lines in 11 files changed: 8 ins; 5 del; 23 mod 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build Co-authored-by: Bernhard Urban-Forster Reviewed-by: burban, aph Backport-of: d2812f780e87511736f2d41bc57a69c2a898b583 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From rkovacs at openjdk.java.net Wed Feb 16 20:54:09 2022 From: rkovacs at openjdk.java.net (Reka Kovacs) Date: Wed, 16 Feb 2022 20:54:09 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v5] In-Reply-To: References: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> Message-ID: On Wed, 16 Feb 2022 07:53:41 GMT, Vladimir Kempik wrote: >> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: >> >> - Replace C-style casts with checked_cast >> - Use size_t in generate_disjoint_copy >> - Explain disabled MSVC warning C4146 in comment >> - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits >> - Backport d2812f780e87511736f2d41bc57a69c2a898b583 > > it lost label "sponsor", so you probably need to /integrate again Thanks so much @VladimirKempik! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From andrew at openjdk.java.net Thu Feb 17 01:52:10 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Thu, 17 Feb 2022 01:52:10 GMT Subject: [jdk11u-dev] Integrated: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 13:46:23 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [d1aeca11](https://github.com/openjdk/jdk/commit/d1aeca117ccc4334d67b2692ff087a9f8d808a59) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Brian Burkhalter on 27 Aug 2021 and was reviewed by Joe Darcy. > It has already been backported to [jdk17u-dev](https://git.openjdk.java.net/jdk17u-dev/commit/8207e69aa076ba848b8496c4ea0bcbea952aae2a). > > This is a clean backport to 11u. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well. > > Thanks! This pull request has now been integrated. Changeset: d6bf0d1e Author: Andrew John Hughes URL: https://git.openjdk.java.net/jdk11u-dev/commit/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d Stats: 30 lines in 2 files changed: 18 ins; 3 del; 9 mod 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication Backport-of: d1aeca117ccc4334d67b2692ff087a9f8d808a59 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/822 From duke at openjdk.java.net Thu Feb 17 02:36:19 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Thu, 17 Feb 2022 02:36:19 GMT Subject: [jdk11u-dev] RFR: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" Message-ID: This is a backport of JDK-8254085:javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" TestCaretPositionJTextPane.java fails also in jdk11, so needs to be fixed. This is a clean backport to 11u. I confirmed this test passed after this backport.? Testing: build on Windows x86_64 and Linux x86_64 tier1 on Windows x86_64 and Linux x86_64 ------------- Commit messages: - Backport 51a865d66a5dddbbaaa4bb656fa02ecd1bee1a0b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/829/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=829&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254085 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/829.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/829/head:pull/829 PR: https://git.openjdk.java.net/jdk11u-dev/pull/829 From serb at openjdk.java.net Thu Feb 17 04:54:20 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Thu, 17 Feb 2022 04:54:20 GMT Subject: [jdk18u] Integrated: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free In-Reply-To: References: Message-ID: On Sat, 12 Feb 2022 23:16:06 GMT, Sergey Bylokhov wrote: > Hi all, > This is a test stabilization fix, additional information [here](https://github.com/openjdk/jdk/pull/6778). > This pull request contains a backport of commit [7c2c5858](https://github.com/openjdk/jdk/commit/7c2c58587d4eda5523331eae45e7d897252dc097) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Dec 2021 and was reviewed by Prasanta Sadhukhan and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 525f17fe Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk18u/commit/525f17fe15519227e29c0f539cf5803db9ca19de Stats: 9 lines in 1 file changed: 3 ins; 4 del; 2 mod 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free Backport-of: 7c2c58587d4eda5523331eae45e7d897252dc097 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/24 From goetz.lindenmaier at sap.com Thu Feb 17 08:04:02 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 17 Feb 2022 08:04:02 +0000 Subject: [11u] Desupport building with Java 10? Message-ID: Hi, OpenJDK has the policy that each jdk should be able to be bootstrapped with the previous Java version. See also DEFAULT_ACCEPTABLE_BOOT_VERSIONS [1]. This makes sense for new Java versions but not for updates of LTSes. For jdk11u, using a Java 10 jdk for bootstrapping even is a security issue as there is no maintained jdk10. On the other side we had to fix a few changes in the past to work with Java 10. We should avoid this effort. I propose to give up supporting Java 10 in the build in 11.0.16 and to change DEFAULT_ACCEPTABLE_BOOT_VERSIONS accordingly. If there are no objections I'll do the corresponding change for 11.0.16. Best regards, Goetz. [1] https://github.com/openjdk/jdk11u-dev/blob/master/make/autoconf/version-numbers From shade at redhat.com Thu Feb 17 08:24:52 2022 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 17 Feb 2022 11:24:52 +0300 Subject: [11u] Desupport building with Java 10? In-Reply-To: References: Message-ID: <5bb94ed4-51e2-bb73-0781-8d9a605ef160@redhat.com> On 2/17/22 11:04, Lindenmaier, Goetz wrote: > Hi, > > OpenJDK has the policy that each jdk should be able to > be bootstrapped with the previous Java version. > See also DEFAULT_ACCEPTABLE_BOOT_VERSIONS [1]. > This makes sense for new Java versions but not for > updates of LTSes. For jdk11u, using a Java 10 jdk > for bootstrapping even is a security issue as there > is no maintained jdk10. > > On the other side we had to fix a few changes in > the past to work with Java 10. We should avoid this > effort. > > I propose to give up supporting Java 10 in the build > in 11.0.16 and to change DEFAULT_ACCEPTABLE_BOOT_VERSIONS > accordingly. > > If there are no objections I'll do the corresponding > change for 11.0.16. As much as I would enjoy seeing this, there is a little logistic problem here: the initial bootstrapping the 11u build without having any 11u build. The "telescoping builds" -- 8 bootstraps 9, 9 bootstraps 10, 10 bootstraps 11 -- provides the logistical continuity here. Having the downloadable 11u build from some vendor only partially solves it. Consider the OS distro that is so special it is not covered by any existing vendor 11u build, that is, any 11u build not from this OS distro straight away fails to run. Now you want to produce the OS-specific 11u build there. But 11u build requires a 11u build. What do you do? -- Thanks, -Aleksey From goetz.lindenmaier at sap.com Thu Feb 17 08:38:36 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 17 Feb 2022 08:38:36 +0000 Subject: [11u] Desupport building with Java 10? In-Reply-To: <5bb94ed4-51e2-bb73-0781-8d9a605ef160@redhat.com> References: <5bb94ed4-51e2-bb73-0781-8d9a605ef160@redhat.com> Message-ID: Hi Aleksey, Theoretically you are right. But do you think there will ever be a real use case of this? The problem is that new OS distros are not supported by 10 anyways. See mac/windows aarch64 and the alpine port. > the OS distro that is so special I think we can move the burden to solve this issue to the special distro and save the effort on our side. Obviously, to solve this, you build an old version of jdk11u with your build of jdk10. It's insecure anyways as jdk10 is not secure. With that build of the old version you can again build the current jdk11u. Best regards, Goetz. > -----Original Message----- > From: Aleksey Shipilev > Sent: Thursday, February 17, 2022 9:25 AM > To: Lindenmaier, Goetz ; jdk-updates- > dev at openjdk.java.net > Subject: Re: [11u] Desupport building with Java 10? > > On 2/17/22 11:04, Lindenmaier, Goetz wrote: > > Hi, > > > > OpenJDK has the policy that each jdk should be able to > > be bootstrapped with the previous Java version. > > See also DEFAULT_ACCEPTABLE_BOOT_VERSIONS [1]. > > This makes sense for new Java versions but not for > > updates of LTSes. For jdk11u, using a Java 10 jdk > > for bootstrapping even is a security issue as there > > is no maintained jdk10. > > > > On the other side we had to fix a few changes in > > the past to work with Java 10. We should avoid this > > effort. > > > > I propose to give up supporting Java 10 in the build > > in 11.0.16 and to change DEFAULT_ACCEPTABLE_BOOT_VERSIONS > > accordingly. > > > > If there are no objections I'll do the corresponding > > change for 11.0.16. > > As much as I would enjoy seeing this, there is a little logistic problem here: > the initial > bootstrapping the 11u build without having any 11u build. The "telescoping > builds" -- 8 bootstraps > 9, 9 bootstraps 10, 10 bootstraps 11 -- provides the logistical continuity here. > > Having the downloadable 11u build from some vendor only partially solves it. > Consider the OS distro > that is so special it is not covered by any existing vendor 11u build, that is, any > 11u build not > from this OS distro straight away fails to run. Now you want to produce the > OS-specific 11u build > there. But 11u build requires a 11u build. What do you do? > > -- > Thanks, > -Aleksey From sgehwolf at redhat.com Thu Feb 17 09:56:58 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 17 Feb 2022 10:56:58 +0100 Subject: [11u] Desupport building with Java 10? In-Reply-To: References: Message-ID: <914cf2f4e7358a1d9616510080ea0d78c5d335f6.camel@redhat.com> On Thu, 2022-02-17 at 08:04 +0000, Lindenmaier, Goetz wrote: > Hi, > > OpenJDK has the policy that each jdk should be able to > be bootstrapped with the previous Java version. > See also DEFAULT_ACCEPTABLE_BOOT_VERSIONS [1]. > This makes sense for new Java versions but not for > updates of LTSes. Why not? > For jdk11u, using a Java 10 jdk > for bootstrapping even is a security issue as there > is no maintained jdk10. I'm not sure I'm bying the security argument for the bootstrap process. > On the other side we had to fix a few changes in > the past to work with Java 10.? We should avoid this > effort. In the past getting this to work wasn't a lot of effort. Do you have some data were it is *indeed* a lot of effort? > I propose to give up supporting Java 10 in the build > in 11.0.16 and to change DEFAULT_ACCEPTABLE_BOOT_VERSIONS > accordingly. > > If there are no objections I'll do the corresponding > change for 11.0.16. This isn't a good idea. It breaks the bootstrap chain. Unless there are good cases where the "cost of maintaining JDK 10 bootstrap support" >>> "benefit of being able to bootstrap the latest JDK 11", I'm against it. Thanks, Severin From goetz.lindenmaier at sap.com Thu Feb 17 11:39:24 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 17 Feb 2022 11:39:24 +0000 Subject: [11u] Desupport building with Java 10? In-Reply-To: <914cf2f4e7358a1d9616510080ea0d78c5d335f6.camel@redhat.com> References: <914cf2f4e7358a1d9616510080ea0d78c5d335f6.camel@redhat.com> Message-ID: > Do you have some data were it is *indeed* a lot of effort? It is not a lot of effort for a single change, but it keeps popping up. I can't find the changes in question currently. I think I had to handle three in the 11.0.14/15 releases. If we want to support building with 10 we should use a jdk10 in the GHA builds to detect issues early. At least for one platform, probably linuxx86_64 dbg build. Currently it's temurin-11.0.12 everywhere. Best regards, Goetz. > -----Original Message----- > From: Severin Gehwolf > Sent: Thursday, February 17, 2022 10:57 AM > To: Lindenmaier, Goetz ; jdk-updates- > dev at openjdk.java.net > Subject: Re: [11u] Desupport building with Java 10? > > On Thu, 2022-02-17 at 08:04 +0000, Lindenmaier, Goetz wrote: > > Hi, > > > > OpenJDK has the policy that each jdk should be able to > > be bootstrapped with the previous Java version. > > See also DEFAULT_ACCEPTABLE_BOOT_VERSIONS [1]. > > This makes sense for new Java versions but not for > > updates of LTSes. > > Why not? > > > For jdk11u, using a Java 10 jdk > > for bootstrapping even is a security issue as there > > is no maintained jdk10. > > I'm not sure I'm bying the security argument for the bootstrap process. > > > On the other side we had to fix a few changes in > > the past to work with Java 10.? We should avoid this > > effort. > > In the past getting this to work wasn't a lot of effort. Do you have > some data were it is *indeed* a lot of effort? > > > I propose to give up supporting Java 10 in the build > > in 11.0.16 and to change DEFAULT_ACCEPTABLE_BOOT_VERSIONS > > accordingly. > > > > If there are no objections I'll do the corresponding > > change for 11.0.16. > > This isn't a good idea. It breaks the bootstrap chain. Unless there are > good cases where the "cost of maintaining JDK 10 bootstrap support" >>> > "benefit of being able to bootstrap the latest JDK 11", I'm against it. > > Thanks, > Severin From duke at openjdk.java.net Thu Feb 17 12:51:20 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Thu, 17 Feb 2022 12:51:20 GMT Subject: [jdk11u-dev] RFR: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64 Message-ID: <8p_iymGhc8z0DX-y6cZ29yf5p2Ieh9i0Xv34YGleFlU=.8f17d0bf-7b35-41e9-810f-2a34c7e66704@github.com> I would like to backport JDK-8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java JDK-8213181: Updation of ProblemList.txt for removal of passing swing test (dependency) Original patches do not apply cleanly to 11u. I resolved a conflict and applied only the relevant parts of JDK-8213181 related to bug8001470.java. The purpose of these backports is to exclude javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java on both Linux and Windows OS. The current ProblemList.txt has two lines containing the test and the first line is ignored. As a result, the test runs on the Linux OS unexpectedly. Testing: tier1 on Windows x86_64 and Linux x86_64 Verify that javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java does not run on Linux OS ------------- Commit messages: - 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/830/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=830&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8233986 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/830.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/830/head:pull/830 PR: https://git.openjdk.java.net/jdk11u-dev/pull/830 From mbaesken at openjdk.java.net Thu Feb 17 12:52:21 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 17 Feb 2022 12:52:21 GMT Subject: [jdk17u-dev] Integrated: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine In-Reply-To: References: Message-ID: On Wed, 16 Feb 2022 08:31:40 GMT, Matthias Baesken wrote: > 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine This pull request has now been integrated. Changeset: a59e8cbc Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/a59e8cbc0fa61c3d976ed829bf88de123904b127 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine Backport-of: fd8cb2dae87e5726e89a1789e5a1ddd461c4400d ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/165 From duke at openjdk.java.net Thu Feb 17 12:56:15 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Thu, 17 Feb 2022 12:56:15 GMT Subject: [jdk11u-dev] Integrated: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 07:31:11 GMT, Kimura Yukihiro wrote: > This is a backport of JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale. > Original patch applies cleanly to 11u. > > Testing: > build on Windows x86_64 and Linux x86_64 > tier1 on Windows x86_64 and Linux x86_64 > a specific test to confirm the fix in Japanese locale > > Could you please review this PR? This pull request has now been integrated. Changeset: e2f792c5 Author: Kimura Yukihiro Committer: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/e2f792c54919d3bb42901ed3c23e8c846db03852 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale Backport-of: b46d73bee808af7891b699df30a5a6dec3f5139f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/824 From mbaesken at openjdk.java.net Thu Feb 17 13:08:10 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 17 Feb 2022 13:08:10 GMT Subject: [jdk11u-dev] RFR: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: On Wed, 16 Feb 2022 16:06:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > I had to do two straight forward fixes: > XPathFactoryImpl Tag @LastModified is adapted in head but does not exist in 11. > XPathTest.java A larger hunk did not apply. Simple to patch by hand. LGTM mostly; However I really wonder about the since 18 tags in the API see src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java is this really what we want to have in 11 (or 17 where we find this in the backport too) ? And the JCK breaking does not sound too well, is an update confirmed ? ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/828 From abakhtin at openjdk.java.net Thu Feb 17 13:24:14 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Thu, 17 Feb 2022 13:24:14 GMT Subject: [jdk11u-dev] Integrated: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake In-Reply-To: <3i4qj7zTLvkxTNVC0PDdHIpj6wmaL3Tl6f8eJs0s8yc=.ab5d95cf-f662-44b1-a38a-c8475706b457@github.com> References: <3i4qj7zTLvkxTNVC0PDdHIpj6wmaL3Tl6f8eJs0s8yc=.ab5d95cf-f662-44b1-a38a-c8475706b457@github.com> Message-ID: On Mon, 14 Feb 2022 17:58:42 GMT, Alexey Bakhtin wrote: > Backport of JDK-8274524 to JDK11u-dev > Backport is almost clean except for a trivial fix for Pattern Matching in the instanceof (not available in JDK11) and braces for the if-clauses. > sun/security/ssl/SSLSocketImpl tests passed This pull request has now been integrated. Changeset: 57003eea Author: Alexey Bakhtin Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk11u-dev/commit/57003eea5eaf66771af6c2f6b08ea4d46cbf8a0f Stats: 153 lines in 2 files changed: 153 ins; 0 del; 0 mod 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Reviewed-by: phh Backport-of: 58dae60da0711c4ae0cb23f8ce2328e051d603b2 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/823 From abakhtin at openjdk.java.net Thu Feb 17 13:24:30 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Thu, 17 Feb 2022 13:24:30 GMT Subject: [jdk17u-dev] Integrated: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake In-Reply-To: References: Message-ID: On Mon, 14 Feb 2022 13:43:12 GMT, Alexey Bakhtin wrote: > This is a clean backport of JDK-8274524 to JDK17u-dev > sun/security/ssl/SSLSocketImpl tests passed This pull request has now been integrated. Changeset: d54675be Author: Alexey Bakhtin Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk17u-dev/commit/d54675becb2a7713fb80a0ec48ee13dea1e17bbb Stats: 151 lines in 2 files changed: 151 ins; 0 del; 0 mod 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Backport-of: 58dae60da0711c4ae0cb23f8ce2328e051d603b2 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/161 From sgehwolf at redhat.com Thu Feb 17 13:42:44 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 17 Feb 2022 14:42:44 +0100 Subject: [11u] Desupport building with Java 10? In-Reply-To: References: <914cf2f4e7358a1d9616510080ea0d78c5d335f6.camel@redhat.com> Message-ID: <5e889736d5c15cfc70ea7d0b16dce9de03013647.camel@redhat.com> On Thu, 2022-02-17 at 11:39 +0000, Lindenmaier, Goetz wrote: > If we want to support building with 10 we should use a jdk10 in the > GHA builds to detect issues early.? At least for one platform, > probably linuxx86_64 dbg build.? Currently it's temurin-11.0.12 > everywhere. Seems fine to me to add this to GHA. Thanks, Severin From aleksei.voitylov at bell-sw.com Thu Feb 17 14:12:17 2022 From: aleksei.voitylov at bell-sw.com (Aleksei Voitylov) Date: Thu, 17 Feb 2022 17:12:17 +0300 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u Message-ID: Hi, Following recent backports of JEP 388 (Windows/AArch64 Port) and JEP 391 (macOS/AArch64 Port), I?d like to propose a backport of JEP 386 (Alpine Linux Port) [1] to OpenJDK 11u. Support for this port was baked in the Portola project and integrated into OpenJDK 16. Motivation for 11u backport: the importance of this platform is explained by wide adoption of Alpine Linux in container environments [2]. Several OpenJDK vendors (Liberica, Corretto, Zulu) include patches that enable Alpine/MUSL for 11u and 8u for quite some time, without any issues. Others (MS) have recently added it. In our case the user demand for Alpine/musl support for both 11u and 8u was at least as strong as Mac/AArch64 and Windows/AArch64, I?d also like to hear if other OpenJDK vendors share our view of the importance of this platform in 11u. The set of JBS issues required to be backported for Alpine/MUSL support in 11u is: JDK-8217340 Compilation failed: tools/launcher/Test7029048.java -??? Test-only fix JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java -??? Test-only fix JDK-8245938 Remove unused print_stack(void) method from XToolkit.c -??? Code fix, removal of dead code, applies cleanly JDK-8252248 __SIGRTMAX is not declared in musl libc -??? Code fix JDK-8252250 isnanf is obsolete -??? Code fix, substitutes isnanf with isnan which was proven to be ok at least since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM version ? see the discussion in JDK-8178689 for further details. JDK-8247589 Implementation of Alpine Linux/x64 Port -??? The actual build and code changes that tidy up code for MUSL JDK-8247591 Document Alpine Linux build steps in OpenJDK build guide -??? Docs only fix All patches combined: +480 lines, -146 lines. All source code changes: +133 lines, -43 lines. For risk assessment and preliminary examination of the 11u maintainers, the full patchset can be observed in [3], separate 11u backports can be found in [4]. I plan to submit the actual PRs for individual backports one by one unless I hear reasonable concerns from 11u maintainers on the proposed changes. The patchset passes full JCK+jtreg set without any regressions to other platforms (Windows, Linux, Mac, Solaris), including non-Intel where applicable. During integration of JEP 386 SAP kindly verified that these changes do not break AIX/XLC. On the maintenance side, BellSoft will be happy to support this platform in 11u. But I?ll equally happily share the burden with other OpenJDK vendors that currently support Alpine/MUSL. Thanks, -Aleksei [1] https://openjdk.java.net/jeps/386 [2] https://hub.docker.com/_/alpine [3] https://github.com/voitylov/jdk11u-dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da398797738fbfd1eaf02e1f887e306 [4] 8217340: https://github.com/voitylov/jdk11u-dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a 8247592: https://github.com/voitylov/jdk11u-dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd 8245938: https://github.com/voitylov/jdk11u-dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a 8252248: https://github.com/voitylov/jdk11u-dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 8252250: https://github.com/voitylov/jdk11u-dev/commit/41b6b490fe60c640c90d9e594557215e669955cc 8247589: https://github.com/voitylov/jdk11u-dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 8247591: https://github.com/voitylov/jdk11u-dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 From yan at openjdk.java.net Thu Feb 17 15:22:43 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Thu, 17 Feb 2022 15:22:43 GMT Subject: [jdk13u-dev] RFR: 8276141: XPathFactory set/getProperty method Message-ID: Difference against the original: no LastModified in XPathFactoryImpl.java in 13/15; the test patch manually applied. ------------- Commit messages: - Backport b226ab99c872e791d3ed9fca015cf92847904c34 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/329/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=329&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276141 Stats: 194 lines in 5 files changed: 189 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/329.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/329/head:pull/329 PR: https://git.openjdk.java.net/jdk13u-dev/pull/329 From yan at openjdk.java.net Thu Feb 17 15:23:41 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Thu, 17 Feb 2022 15:23:41 GMT Subject: [jdk15u-dev] RFR: 8276141: XPathFactory set/getProperty method Message-ID: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> get/setProperty added plus test and presumably CSR; difference from the original is in LAstModified of XPathFactoryImpl.java and the test context. ------------- Commit messages: - Backport b226ab99c872e791d3ed9fca015cf92847904c34 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/179/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=179&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276141 Stats: 194 lines in 5 files changed: 189 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/179.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/179/head:pull/179 PR: https://git.openjdk.java.net/jdk15u-dev/pull/179 From duke at openjdk.java.net Thu Feb 17 16:34:07 2022 From: duke at openjdk.java.net (Mat Carter) Date: Thu, 17 Feb 2022 16:34:07 GMT Subject: [jdk18u] Withdrawn: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled In-Reply-To: <1XUfR1FJhZHTR33TY3flyOuu0jH7dvhzO26kzXPOfb8=.d5bfa6c3-a6da-477d-90ac-8b636a9e39ac@github.com> References: <1XUfR1FJhZHTR33TY3flyOuu0jH7dvhzO26kzXPOfb8=.d5bfa6c3-a6da-477d-90ac-8b636a9e39ac@github.com> Message-ID: <_D-GD29ki7stBWlzSh6CKFO_O464Xirkz0FqpVJD1Zg=.252e39e3-0332-41f5-ae41-f7c50b36d76d@github.com> On Wed, 16 Feb 2022 15:53:07 GMT, Mat Carter wrote: > Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/25 From duke at openjdk.java.net Thu Feb 17 16:34:06 2022 From: duke at openjdk.java.net (Mat Carter) Date: Thu, 17 Feb 2022 16:34:06 GMT Subject: [jdk18u] RFR: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled [v2] In-Reply-To: <1XUfR1FJhZHTR33TY3flyOuu0jH7dvhzO26kzXPOfb8=.d5bfa6c3-a6da-477d-90ac-8b636a9e39ac@github.com> References: <1XUfR1FJhZHTR33TY3flyOuu0jH7dvhzO26kzXPOfb8=.d5bfa6c3-a6da-477d-90ac-8b636a9e39ac@github.com> Message-ID: > Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 Mat Carter has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/25/files - new: https://git.openjdk.java.net/jdk18u/pull/25/files/697b7cf6..22f61959 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=25&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=25&range=00-01 Stats: 19 lines in 1 file changed: 6 ins; 11 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/25/head:pull/25 PR: https://git.openjdk.java.net/jdk18u/pull/25 From phh at openjdk.java.net Thu Feb 17 16:36:07 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 17 Feb 2022 16:36:07 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 [v2] In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 12:50:45 GMT, Paul Hohensee wrote: >> I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. >> >> Testing: tier1, including the new and existing sha tests. >> >> Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. >> >> 1. Copyright date conflicts. >> 2. Context differences. >> 3. Changing SHAOptionsBase to DigestOptionsBase. >> 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. >> >> This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). > > Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8250902: Implement MD5 Intrinsics on x86 > - Merge branch 'master' into backport-339016a0 > - 8250902: Implement MD5 Intrinsics on x86 > - Backport 339016a0f2cbbbbc3560e50c6726e14afbf547f6 JBS issue was tagged 10 days ago. May I have a decision please? March 1st is 11.0.15 rampdown and quite close. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From duke at openjdk.java.net Thu Feb 17 16:49:43 2022 From: duke at openjdk.java.net (Mat Carter) Date: Thu, 17 Feb 2022 16:49:43 GMT Subject: [jdk18u] RFR: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled Message-ID: <39lS1JbYrH32fzHiChMK2sxilIA1_Gc-d2XCqfRBU7A=.5b19af0c-8ffe-446d-8362-00296196a449@github.com> Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 ------------- Commit messages: - Backport 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 Changes: https://git.openjdk.java.net/jdk18u/pull/29/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=29&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272996 Stats: 19 lines in 1 file changed: 11 ins; 6 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/29.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/29/head:pull/29 PR: https://git.openjdk.java.net/jdk18u/pull/29 From phh at openjdk.java.net Thu Feb 17 18:21:25 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 17 Feb 2022 18:21:25 GMT Subject: [jdk17u-dev] RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER In-Reply-To: References: Message-ID: <-97eCxwaVph9cVNpbpR2AMz0gk9tgYfTEEMUAgFblmc=.80083cea-135a-422e-b51d-ad942f3f70a4@github.com> On Tue, 15 Feb 2022 10:07:56 GMT, Andrew Leonard wrote: > Adds support for configure argument --with-build-user=, which allows openjdk builds to use a generic username to allow deterministic "reproducible" build output. Done. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/163 From aleonard at openjdk.java.net Thu Feb 17 18:21:27 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Thu, 17 Feb 2022 18:21:27 GMT Subject: [jdk17u-dev] Integrated: 8277762: Allow configuration of HOTSPOT_BUILD_USER In-Reply-To: References: Message-ID: <7Y5b1LnYQFSJg4mU4Z2G3hmwEEjqOTDA5cM8i_VSMjM=.edc76298-509f-43df-b728-63f7f5a02a1a@github.com> On Tue, 15 Feb 2022 10:07:56 GMT, Andrew Leonard wrote: > Adds support for configure argument --with-build-user=, which allows openjdk builds to use a generic username to allow deterministic "reproducible" build output. This pull request has now been integrated. Changeset: 63fe1609 Author: Andrew Leonard Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u-dev/commit/63fe16098af9fa1c697df2325e6b679e7e017117 Stats: 17 lines in 2 files changed: 11 ins; 5 del; 1 mod 8277762: Allow configuration of HOTSPOT_BUILD_USER Backport-of: f41e768bba2b2ce3b3cc5813ccb1ac4984dcefbd ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/163 From phh at openjdk.java.net Thu Feb 17 18:41:11 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 17 Feb 2022 18:41:11 GMT Subject: [jdk11u-dev] RFR: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64 In-Reply-To: <8p_iymGhc8z0DX-y6cZ29yf5p2Ieh9i0Xv34YGleFlU=.8f17d0bf-7b35-41e9-810f-2a34c7e66704@github.com> References: <8p_iymGhc8z0DX-y6cZ29yf5p2Ieh9i0Xv34YGleFlU=.8f17d0bf-7b35-41e9-810f-2a34c7e66704@github.com> Message-ID: On Thu, 17 Feb 2022 07:31:36 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java > JDK-8213181: Updation of ProblemList.txt for removal of passing swing test (dependency) > > Original patches do not apply cleanly to 11u. > > I resolved a conflict and applied only the relevant parts of JDK-8213181 related to bug8001470.java. > The purpose of these backports is to exclude javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java on both Linux and Windows OS. The current ProblemList.txt has two lines containing the test and the first line is ignored. > As a result, the test runs on the Linux OS unexpectedly. > > Testing: > tier1 on Windows x86_64 and Linux x86_64 > Verify that javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java does not run on Linux OS Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/830 From duke at openjdk.java.net Thu Feb 17 21:36:06 2022 From: duke at openjdk.java.net (Mat Carter) Date: Thu, 17 Feb 2022 21:36:06 GMT Subject: [jdk18u] RFR: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled [v2] In-Reply-To: <39lS1JbYrH32fzHiChMK2sxilIA1_Gc-d2XCqfRBU7A=.5b19af0c-8ffe-446d-8362-00296196a449@github.com> References: <39lS1JbYrH32fzHiChMK2sxilIA1_Gc-d2XCqfRBU7A=.5b19af0c-8ffe-446d-8362-00296196a449@github.com> Message-ID: > Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 Mat Carter has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/29/files - new: https://git.openjdk.java.net/jdk18u/pull/29/files/697b7cf6..ae0a5e5c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=29&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=29&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/29.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/29/head:pull/29 PR: https://git.openjdk.java.net/jdk18u/pull/29 From duke at openjdk.java.net Fri Feb 18 05:24:17 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Fri, 18 Feb 2022 05:24:17 GMT Subject: [jdk11u-dev] RFR: 8214004: Missing space between compiler thread name and task info in hs_err Message-ID: I'd like to backport JDK-8214004. The original patch does not applies cleanly because JDK-8163511 was applied first in 11u. The change only reflects JDK-8163511 on the following line, and there is no risk. I tested tier1 with rhel and windows x86_64, and no errors found. ------------- Commit messages: - Merge branch 'openjdk:master' into 8214004 - 8214004: Missing space between compiler thread name and task info in hs_err Changes: https://git.openjdk.java.net/jdk11u-dev/pull/831/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=831&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8214004 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/831.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/831/head:pull/831 PR: https://git.openjdk.java.net/jdk11u-dev/pull/831 From aleonard at openjdk.java.net Fri Feb 18 08:39:58 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 08:39:58 GMT Subject: [jdk17u-dev] RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER In-Reply-To: <-97eCxwaVph9cVNpbpR2AMz0gk9tgYfTEEMUAgFblmc=.80083cea-135a-422e-b51d-ad942f3f70a4@github.com> References: <-97eCxwaVph9cVNpbpR2AMz0gk9tgYfTEEMUAgFblmc=.80083cea-135a-422e-b51d-ad942f3f70a4@github.com> Message-ID: On Thu, 17 Feb 2022 18:16:19 GMT, Paul Hohensee wrote: >> Adds support for configure argument --with-build-user=, which allows openjdk builds to use a generic username to allow deterministic "reproducible" build output. > > Done. thank you @phohensee ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/163 From christoph.langer at sap.com Fri Feb 18 08:51:42 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 18 Feb 2022 08:51:42 +0000 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: References: Message-ID: Hi Aleksei, speaking for SAP, I would very much welcome this backport. We also see a high demand for Alpine builds and are looking into providing these in the near future. And, speaking as a maintainer my personal tendency would be to accept this port, in line with your argumentation below. The demand is very high and lots of downstream vendors already added patches to support it. It shares the same arguments as were valid for JEP 388 (Windows/AArch64 Port) and JEP 391 (macOS/AArch64 Port). Best regards Christoph > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Aleksei Voitylov > Sent: Donnerstag, 17. Februar 2022 15:12 > To: jdk-updates-dev at openjdk.java.net > Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u > > Hi, > > Following recent backports of JEP 388 (Windows/AArch64 Port) and JEP 391 > (macOS/AArch64 Port), I?d like to propose a backport of JEP 386 (Alpine Linux > Port) [1] to OpenJDK 11u. Support for this port was baked in the Portola > project and integrated into OpenJDK 16. > > Motivation for 11u backport: the importance of this platform is explained by > wide adoption of Alpine Linux in container environments [2]. Several > OpenJDK vendors (Liberica, Corretto, Zulu) include patches that enable > Alpine/MUSL for 11u and 8u for quite some time, without any issues. Others > (MS) have recently added it. In our case the user demand for Alpine/musl > support for both 11u and 8u was at least as strong as > Mac/AArch64 and Windows/AArch64, I?d also like to hear if other OpenJDK > vendors share our view of the importance of this platform in 11u. > > The set of JBS issues required to be backported for Alpine/MUSL support in > 11u is: > > JDK-8217340 Compilation failed: tools/launcher/Test7029048.java > -??? Test-only fix > JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java > -??? Test-only fix > JDK-8245938 Remove unused print_stack(void) method from XToolkit.c > -??? Code fix, removal of dead code, applies cleanly > JDK-8252248 __SIGRTMAX is not declared in musl libc > -??? Code fix > JDK-8252250 isnanf is obsolete > -??? Code fix, substitutes isnanf with isnan which was proven to be ok at least > since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM version ? see the > discussion in JDK-8178689 for further details. > JDK-8247589 Implementation of Alpine Linux/x64 Port > -??? The actual build and code changes that tidy up code for MUSL > JDK-8247591 Document Alpine Linux build steps in OpenJDK build guide > -??? Docs only fix > > All patches combined: +480 lines, -146 lines. > All source code changes: +133 lines, -43 lines. > > For risk assessment and preliminary examination of the 11u maintainers, the > full patchset can be observed in [3], separate 11u backports can be found in > [4]. I plan to submit the actual PRs for individual backports one by one unless > I hear reasonable concerns from 11u maintainers on the proposed changes. > > The patchset passes full JCK+jtreg set without any regressions to other > platforms (Windows, Linux, Mac, Solaris), including non-Intel where > applicable. During integration of JEP 386 SAP kindly verified that these > changes do not break AIX/XLC. > > On the maintenance side, BellSoft will be happy to support this platform in > 11u. But I?ll equally happily share the burden with other OpenJDK vendors > that currently support Alpine/MUSL. > > Thanks, > -Aleksei > > [1] https://openjdk.java.net/jeps/386 > [2] > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub. > docker.com%2F_%2Falpine&data=04%7C01%7Cchristoph.langer%40sap > .com%7C1d07ffdbad094db8ffff08d9f21fa3ee%7C42f7676cf455423c82f6dc2d9 > 9791af7%7C0%7C0%7C637807039998760193%7CUnknown%7CTWFpbGZsb3d > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > 3D%7C3000&sdata=KlMvmtK3GrXXvPUjW2Qh5sy%2BqUqGKBTKJQ3Ny > 6jRGCk%3D&reserved=0 > [3] > https://github.com/voitylov/jdk11u- > dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da3 > 98797738fbfd1eaf02e1f887e306 > [4] > 8217340: > https://github.com/voitylov/jdk11u- > dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a > 8247592: > https://github.com/voitylov/jdk11u- > dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd > 8245938: > https://github.com/voitylov/jdk11u- > dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a > 8252248: > https://github.com/voitylov/jdk11u- > dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 > 8252250: > https://github.com/voitylov/jdk11u- > dev/commit/41b6b490fe60c640c90d9e594557215e669955cc > 8247589: > https://github.com/voitylov/jdk11u- > dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 > 8247591: > https://github.com/voitylov/jdk11u- > dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 > From aleonard at openjdk.java.net Fri Feb 18 09:08:22 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 09:08:22 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup Message-ID: <23_XRGZLq7AOhl5z32ltENFMqJzQXpbbcdjtK_uLuaM=.f53486ad-4322-4f81-9918-7b8327fd2c94@github.com> This is the dependent PR fix for https://github.com/openjdk/jdk17u-dev/pull/164 to correctly resolve the --with-cacerts-src recipe. ------------- Depends on: https://git.openjdk.java.net/jdk17u-dev/pull/164 Commit messages: - Backport 45da3aea22fd85f214e661b2c98631cb91ddb55d Changes: https://git.openjdk.java.net/jdk17u-dev/pull/168/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=168&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278163 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/168.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/168/head:pull/168 PR: https://git.openjdk.java.net/jdk17u-dev/pull/168 From aleonard at openjdk.java.net Fri Feb 18 09:13:03 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 09:13:03 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup In-Reply-To: <23_XRGZLq7AOhl5z32ltENFMqJzQXpbbcdjtK_uLuaM=.f53486ad-4322-4f81-9918-7b8327fd2c94@github.com> References: <23_XRGZLq7AOhl5z32ltENFMqJzQXpbbcdjtK_uLuaM=.f53486ad-4322-4f81-9918-7b8327fd2c94@github.com> Message-ID: On Fri, 18 Feb 2022 09:02:00 GMT, Andrew Leonard wrote: > This is the dependent PR fix for https://github.com/openjdk/jdk17u-dev/pull/164 to correctly resolve the --with-cacerts-src recipe. backport commit is wrong, as it's missing the deleted 3 lines ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/168 From aleonard at openjdk.java.net Fri Feb 18 09:13:04 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 09:13:04 GMT Subject: [jdk17u-dev] Withdrawn: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup In-Reply-To: <23_XRGZLq7AOhl5z32ltENFMqJzQXpbbcdjtK_uLuaM=.f53486ad-4322-4f81-9918-7b8327fd2c94@github.com> References: <23_XRGZLq7AOhl5z32ltENFMqJzQXpbbcdjtK_uLuaM=.f53486ad-4322-4f81-9918-7b8327fd2c94@github.com> Message-ID: On Fri, 18 Feb 2022 09:02:00 GMT, Andrew Leonard wrote: > This is the dependent PR fix for https://github.com/openjdk/jdk17u-dev/pull/164 to correctly resolve the --with-cacerts-src recipe. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/168 From mbaesken at openjdk.java.net Fri Feb 18 09:37:21 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 18 Feb 2022 09:37:21 GMT Subject: [jdk11u-dev] RFR: 8247515: OSX pc_to_symbol() lookup does not work with core files Message-ID: <5ksTZ-Jv0X2EJFKhq4nCPNyYxtXieMqXhNA2FlaI1Jc=.a0ea3a32-7111-46eb-ae0c-b2447f0f4846@github.com> 8247515: OSX pc_to_symbol() lookup does not work with core files ------------- Commit messages: - Backport ab729d7075d718b146b643d1b4c2735adaeb7194 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/832/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=832&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247515 Stats: 112 lines in 4 files changed: 68 ins; 12 del; 32 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/832.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/832/head:pull/832 PR: https://git.openjdk.java.net/jdk11u-dev/pull/832 From aleonard at openjdk.java.net Fri Feb 18 10:08:53 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 10:08:53 GMT Subject: [jdk17u-dev] RFR: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 13:25:10 GMT, Andrew Leonard wrote: > Provide a new configure argument --with-cacerts-src=, that allows openjdk builds to specify their own source of cacerts, similar to the existing --with-cacerts-file option for pre-built ketstores, but this new option allows builds to use the GenerateCacerts openjdk tooling which produces a deterministic "reproducible" keystore. PR for https://bugs.openjdk.java.net/browse/JDK-8278163 will follow once this is merged. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/164 From volker.simonis at gmail.com Fri Feb 18 10:20:02 2022 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 18 Feb 2022 11:20:02 +0100 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: References: Message-ID: Hi Aleksei, Thanks a lot for proposing this downport! I have no additional arguments to add in favor for this downport except that the Amazon Corretto team will be happy to help with the integration and maintenance. Best regards, Volker On Fri, Feb 18, 2022 at 9:52 AM Langer, Christoph wrote: > > Hi Aleksei, > > speaking for SAP, I would very much welcome this backport. We also see a high demand for Alpine builds and are looking into providing these in the near future. > > And, speaking as a maintainer my personal tendency would be to accept this port, in line with your argumentation below. The demand is very high and lots of downstream vendors already added patches to support it. It shares the same arguments as were valid for JEP 388 (Windows/AArch64 Port) and JEP 391 (macOS/AArch64 Port). > > Best regards > Christoph > > > -----Original Message----- > > From: jdk-updates-dev On > > Behalf Of Aleksei Voitylov > > Sent: Donnerstag, 17. Februar 2022 15:12 > > To: jdk-updates-dev at openjdk.java.net > > Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u > > > > Hi, > > > > Following recent backports of JEP 388 (Windows/AArch64 Port) and JEP 391 > > (macOS/AArch64 Port), I?d like to propose a backport of JEP 386 (Alpine Linux > > Port) [1] to OpenJDK 11u. Support for this port was baked in the Portola > > project and integrated into OpenJDK 16. > > > > Motivation for 11u backport: the importance of this platform is explained by > > wide adoption of Alpine Linux in container environments [2]. Several > > OpenJDK vendors (Liberica, Corretto, Zulu) include patches that enable > > Alpine/MUSL for 11u and 8u for quite some time, without any issues. Others > > (MS) have recently added it. In our case the user demand for Alpine/musl > > support for both 11u and 8u was at least as strong as > > Mac/AArch64 and Windows/AArch64, I?d also like to hear if other OpenJDK > > vendors share our view of the importance of this platform in 11u. > > > > The set of JBS issues required to be backported for Alpine/MUSL support in > > 11u is: > > > > JDK-8217340 Compilation failed: tools/launcher/Test7029048.java > > - Test-only fix > > JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java > > - Test-only fix > > JDK-8245938 Remove unused print_stack(void) method from XToolkit.c > > - Code fix, removal of dead code, applies cleanly > > JDK-8252248 __SIGRTMAX is not declared in musl libc > > - Code fix > > JDK-8252250 isnanf is obsolete > > - Code fix, substitutes isnanf with isnan which was proven to be ok at least > > since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM version ? see the > > discussion in JDK-8178689 for further details. > > JDK-8247589 Implementation of Alpine Linux/x64 Port > > - The actual build and code changes that tidy up code for MUSL > > JDK-8247591 Document Alpine Linux build steps in OpenJDK build guide > > - Docs only fix > > > > All patches combined: +480 lines, -146 lines. > > All source code changes: +133 lines, -43 lines. > > > > For risk assessment and preliminary examination of the 11u maintainers, the > > full patchset can be observed in [3], separate 11u backports can be found in > > [4]. I plan to submit the actual PRs for individual backports one by one unless > > I hear reasonable concerns from 11u maintainers on the proposed changes. > > > > The patchset passes full JCK+jtreg set without any regressions to other > > platforms (Windows, Linux, Mac, Solaris), including non-Intel where > > applicable. During integration of JEP 386 SAP kindly verified that these > > changes do not break AIX/XLC. > > > > On the maintenance side, BellSoft will be happy to support this platform in > > 11u. But I?ll equally happily share the burden with other OpenJDK vendors > > that currently support Alpine/MUSL. > > > > Thanks, > > -Aleksei > > > > [1] https://openjdk.java.net/jeps/386 > > [2] > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub. > > docker.com%2F_%2Falpine&data=04%7C01%7Cchristoph.langer%40sap > > .com%7C1d07ffdbad094db8ffff08d9f21fa3ee%7C42f7676cf455423c82f6dc2d9 > > 9791af7%7C0%7C0%7C637807039998760193%7CUnknown%7CTWFpbGZsb3d > > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > 3D%7C3000&sdata=KlMvmtK3GrXXvPUjW2Qh5sy%2BqUqGKBTKJQ3Ny > > 6jRGCk%3D&reserved=0 > > [3] > > https://github.com/voitylov/jdk11u- > > dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da3 > > 98797738fbfd1eaf02e1f887e306 > > [4] > > 8217340: > > https://github.com/voitylov/jdk11u- > > dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a > > 8247592: > > https://github.com/voitylov/jdk11u- > > dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd > > 8245938: > > https://github.com/voitylov/jdk11u- > > dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a > > 8252248: > > https://github.com/voitylov/jdk11u- > > dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 > > 8252250: > > https://github.com/voitylov/jdk11u- > > dev/commit/41b6b490fe60c640c90d9e594557215e669955cc > > 8247589: > > https://github.com/voitylov/jdk11u- > > dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 > > 8247591: > > https://github.com/voitylov/jdk11u- > > dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 > > > From mbaesken at openjdk.java.net Fri Feb 18 12:51:16 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 18 Feb 2022 12:51:16 GMT Subject: [jdk11u-dev] RFR: 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail Message-ID: <3HTxJuPz_gG1dYwptR8gGX5ScYcmF66WdA1YVPdWc34=.08c78a7f-cd67-4625-be11-1944e4b8496f@github.com> 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail ------------- Commit messages: - Backport fd206e1e7e2a78203305c6bf94fb2db5e410e7f7 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/833/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=833&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247272 Stats: 76 lines in 3 files changed: 35 ins; 0 del; 41 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/833.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/833/head:pull/833 PR: https://git.openjdk.java.net/jdk11u-dev/pull/833 From aleonard at openjdk.java.net Fri Feb 18 16:41:57 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 16:41:57 GMT Subject: [jdk17u-dev] Integrated: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 13:25:10 GMT, Andrew Leonard wrote: > Provide a new configure argument --with-cacerts-src=, that allows openjdk builds to specify their own source of cacerts, similar to the existing --with-cacerts-file option for pre-built ketstores, but this new option allows builds to use the GenerateCacerts openjdk tooling which produces a deterministic "reproducible" keystore. This pull request has now been integrated. Changeset: f6afde21 Author: Andrew Leonard Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u-dev/commit/f6afde21434e30ffaf6b45bef92a00ec368d84d9 Stats: 22 lines in 3 files changed: 22 ins; 0 del; 0 mod 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation Backport-of: dc2abc9f05c2b7c52aeb242082359c48963f9854 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/164 From aleonard at openjdk.java.net Fri Feb 18 16:54:31 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 16:54:31 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup Message-ID: This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. ------------- Commit messages: - Backport 45da3aea22fd85f214e661b2c98631cb91ddb55d Changes: https://git.openjdk.java.net/jdk17u-dev/pull/170/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=170&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278163 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/170.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/170/head:pull/170 PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From aleonard at openjdk.java.net Fri Feb 18 16:54:32 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 16:54:32 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 16:47:49 GMT, Andrew Leonard wrote: > This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. This is the PR to backport https://bugs.openjdk.java.net/browse/JDK-8278163 to resolve the issue for the already merged dependent PR for https://bugs.openjdk.java.net/browse/JDK-8278080. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From aleonard at openjdk.java.net Fri Feb 18 18:54:38 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 18:54:38 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v2] In-Reply-To: References: Message-ID: > This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. Andrew Leonard has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into andrew-m-leonard-backport-45da3aea - Backport 45da3aea22fd85f214e661b2c98631cb91ddb55d ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/170/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/170/files/8ddaefcd..0444bc5e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=170&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=170&range=00-01 Stats: 198 lines in 8 files changed: 184 ins; 5 del; 9 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/170.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/170/head:pull/170 PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From aleonard at openjdk.java.net Fri Feb 18 19:27:34 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 19:27:34 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v3] In-Reply-To: References: Message-ID: > This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup Signed-off-by: Andrew Leonard ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/170/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/170/files/0444bc5e..a3549b29 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=170&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=170&range=01-02 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/170.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/170/head:pull/170 PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From aleonard at openjdk.java.net Fri Feb 18 19:27:37 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Fri, 18 Feb 2022 19:27:37 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v2] In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 18:54:38 GMT, Andrew Leonard wrote: >> This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. > > Andrew Leonard has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into andrew-m-leonard-backport-45da3aea > - Backport 45da3aea22fd85f214e661b2c98631cb91ddb55d I've patched this PR to correctly mirror the head stream fix: https://github.com/openjdk/jdk/pull/6680/files which Skara incorrectly created due to the dependent PR code change not being in master when the PR was created. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From rhalade at openjdk.java.net Fri Feb 18 20:43:36 2022 From: rhalade at openjdk.java.net (Rajan Halade) Date: Fri, 18 Feb 2022 20:43:36 GMT Subject: [jdk18u] RFR: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 Message-ID: clean backport ------------- Commit messages: - Backport d3749de47832c6de4bcee9cf64a0b698e796b2f2 Changes: https://git.openjdk.java.net/jdk18u/pull/30/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=30&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277488 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/30.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/30/head:pull/30 PR: https://git.openjdk.java.net/jdk18u/pull/30 From clanger at openjdk.java.net Fri Feb 18 21:39:59 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 18 Feb 2022 21:39:59 GMT Subject: [jdk11u-dev] RFR: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64 In-Reply-To: <8p_iymGhc8z0DX-y6cZ29yf5p2Ieh9i0Xv34YGleFlU=.8f17d0bf-7b35-41e9-810f-2a34c7e66704@github.com> References: <8p_iymGhc8z0DX-y6cZ29yf5p2Ieh9i0Xv34YGleFlU=.8f17d0bf-7b35-41e9-810f-2a34c7e66704@github.com> Message-ID: <3z-S96GjoQ4XkyZzak5KKyhpGtI3ubnGWdw9Fe7GLko=.2d4e04ef-b86e-4a17-9662-4910dfcf562b@github.com> On Thu, 17 Feb 2022 07:31:36 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java > JDK-8213181: Updation of ProblemList.txt for removal of passing swing test (dependency) > > Original patches do not apply cleanly to 11u. > > I resolved a conflict and applied only the relevant parts of JDK-8213181 related to bug8001470.java. > The purpose of these backports is to exclude javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java on both Linux and Windows OS. The current ProblemList.txt has two lines containing the test and the first line is ignored. > As a result, the test runs on the Linux OS unexpectedly. > > Testing: > tier1 on Windows x86_64 and Linux x86_64 > Verify that javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java does not run on Linux OS > /integrate @yukikimmura you must not do /integrate before there's maintainer approval in the JBS issue, indicated by the "jdk11u-fix-yes" label. I have approved it now. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/830 From duke at openjdk.java.net Fri Feb 18 21:40:00 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Fri, 18 Feb 2022 21:40:00 GMT Subject: [jdk11u-dev] Integrated: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64 In-Reply-To: <8p_iymGhc8z0DX-y6cZ29yf5p2Ieh9i0Xv34YGleFlU=.8f17d0bf-7b35-41e9-810f-2a34c7e66704@github.com> References: <8p_iymGhc8z0DX-y6cZ29yf5p2Ieh9i0Xv34YGleFlU=.8f17d0bf-7b35-41e9-810f-2a34c7e66704@github.com> Message-ID: On Thu, 17 Feb 2022 07:31:36 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java > JDK-8213181: Updation of ProblemList.txt for removal of passing swing test (dependency) > > Original patches do not apply cleanly to 11u. > > I resolved a conflict and applied only the relevant parts of JDK-8213181 related to bug8001470.java. > The purpose of these backports is to exclude javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java on both Linux and Windows OS. The current ProblemList.txt has two lines containing the test and the first line is ignored. > As a result, the test runs on the Linux OS unexpectedly. > > Testing: > tier1 on Windows x86_64 and Linux x86_64 > Verify that javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java does not run on Linux OS This pull request has now been integrated. Changeset: 259bbf5f Author: Kimura Yukihiro Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/259bbf5ff5b6b77fb10b478eae65c0285428f13e Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64 Reviewed-by: phh ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/830 From clanger at openjdk.java.net Fri Feb 18 21:45:58 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 18 Feb 2022 21:45:58 GMT Subject: [jdk11u-dev] RFR: 8247515: OSX pc_to_symbol() lookup does not work with core files In-Reply-To: <5ksTZ-Jv0X2EJFKhq4nCPNyYxtXieMqXhNA2FlaI1Jc=.a0ea3a32-7111-46eb-ae0c-b2447f0f4846@github.com> References: <5ksTZ-Jv0X2EJFKhq4nCPNyYxtXieMqXhNA2FlaI1Jc=.a0ea3a32-7111-46eb-ae0c-b2447f0f4846@github.com> Message-ID: On Fri, 18 Feb 2022 09:16:26 GMT, Matthias Baesken wrote: > 8247515: OSX pc_to_symbol() lookup does not work with core files > /clean Citing from the JBS issue: The patch applies cleanly with the exception of the copyright headers in src/jdk.hotspot.agent/macosx/native/libsaproc/libproc_impl.h:1 and src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c:1 which were altered by other backports. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/832 From serb at openjdk.java.net Fri Feb 18 23:29:02 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Fri, 18 Feb 2022 23:29:02 GMT Subject: [jdk15u-dev] Integrated: 8272167: AbsPathsInImage.java should skip *.dSYM directories In-Reply-To: References: Message-ID: On Sun, 13 Feb 2022 05:24:42 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [dd93c6e2](https://github.com/openjdk/jdk/commit/dd93c6e27b66acebb221583fd28d03c65bfc1f24) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Oct 2021 and was reviewed by Magnus Ihse Bursie and Erik Joelsson. > > The change is not "clean" because I have to restore the "import" which is still used by the version of the test in jdk15. > > Thanks! This pull request has now been integrated. Changeset: 070f17df Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk15u-dev/commit/070f17dfb5ca6038e13b4ecd6436a83c79d2b86c Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod 8272167: AbsPathsInImage.java should skip *.dSYM directories Reviewed-by: yan Backport-of: dd93c6e27b66acebb221583fd28d03c65bfc1f24 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/175 From jdowland at openjdk.java.net Mon Feb 21 09:23:05 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Mon, 21 Feb 2022 09:23:05 GMT Subject: [jdk17u-dev] Integrated: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also In-Reply-To: References: Message-ID: On Fri, 4 Feb 2022 11:59:21 GMT, Jonathan Dowland wrote: > Good Morning > > This pull request contains a backport of commit [86d0abb6](https://github.com/openjdk/jdk/commit/86d0abb66bd2fe1edd15b81d351ea3b3c90fd256) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Fairoz Matte on 11 Jan 2022 and was reviewed by Nils Eliasson. > > This is a test-only change, for Oracle parity. The affected test passes for me on jdk17u-dev master before and afterwards. > > Thanks! This pull request has now been integrated. Changeset: cf55b1b8 Author: Jonathan Dowland Committer: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/cf55b1b81d0ddf503403021eb4e593b0c8d00f34 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also Reviewed-by: mdoerr Backport-of: 86d0abb66bd2fe1edd15b81d351ea3b3c90fd256 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/145 From jdowland at openjdk.java.net Mon Feb 21 10:09:12 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Mon, 21 Feb 2022 10:09:12 GMT Subject: [jdk17u-dev] Integrated: 8270117: Broken jtreg link in "Building the JDK" page In-Reply-To: References: Message-ID: On Fri, 4 Feb 2022 12:19:37 GMT, Jonathan Dowland wrote: > Hi all, > > This pull request contains a backport of commit [41a5eb43](https://github.com/openjdk/jdk/commit/41a5eb437204a650d6cc271f41e1d186ee812a88) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Magnus Ihse Bursie on 12 Jul 2021 and was reviewed by Severin Gehwolf. > > It's a very minor doc fix but I tripped over the broken URI in jdk17u-dev just now (I'm getting back > into backports work after a hiatus) so felt it was worthy of consideration. > > Thanks! This pull request has now been integrated. Changeset: f7f0b316 Author: Jonathan Dowland Committer: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/f7f0b31648c6581864fccb5feb093040ec20e8fd Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8270117: Broken jtreg link in "Building the JDK" page Backport-of: 41a5eb437204a650d6cc271f41e1d186ee812a88 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/146 From rhalade at openjdk.java.net Mon Feb 21 15:53:08 2022 From: rhalade at openjdk.java.net (Rajan Halade) Date: Mon, 21 Feb 2022 15:53:08 GMT Subject: [jdk18u] Integrated: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 20:35:38 GMT, Rajan Halade wrote: > clean backport This pull request has now been integrated. Changeset: 36ff9167 Author: Rajan Halade URL: https://git.openjdk.java.net/jdk18u/commit/36ff9167b237299519c554a35b60bb383d85331b Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 Backport-of: d3749de47832c6de4bcee9cf64a0b698e796b2f2 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/30 From serb at openjdk.java.net Mon Feb 21 21:02:41 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Mon, 21 Feb 2022 21:02:41 GMT Subject: [jdk11u-dev] RFR: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException Message-ID: This is backport of the fix for [JDK-6986863](https://bugs.openjdk.java.net/browse/JDK-6986863), pushed to the [JDK 17](https://github.com/openjdk/jdk/commit/64a150c518ed1a936cd6e4cb5e60060243496901) This change prevents intermittent exceptions in the applications and tests caused by the weak synchronization of the color profiles loading, see additional details [here](https://github.com/openjdk/jdk/pull/1613). The new tests failed before and work fine after the fix. No new issues were found by the java_desktop tests. The patch is not clean because the [getStandardProfile() ](https://github.com/openjdk/jdk/commit/64a150c518ed1a936cd6e4cb5e60060243496901#diff-b92a36346bec4c6f7d5e8921bd69b038e0932f116d627bb4f6b514e670e1fccdL923)method removed upstream is still used in the jdk11u-dev. ------------- Commit messages: - Backport 64a150c518ed1a936cd6e4cb5e60060243496901 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/834/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=834&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-6986863 Stats: 518 lines in 9 files changed: 183 ins; 263 del; 72 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/834.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/834/head:pull/834 PR: https://git.openjdk.java.net/jdk11u-dev/pull/834 From duke at openjdk.java.net Tue Feb 22 00:34:53 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Tue, 22 Feb 2022 00:34:53 GMT Subject: [jdk11u-dev] RFR: 8214004: Missing space between compiler thread name and task info in hs_err In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 05:18:04 GMT, Kimura Yukihiro wrote: > I'd like to backport JDK-8214004. > The original patch does not applies cleanly because JDK-8163511 was applied first in 11u. > > The change only reflects JDK-8163511 on the following line, and there is no risk. > I tested tier1 with rhel and windows x86_64, and no errors found. Could anyone review the fix please? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/831 From serb at openjdk.java.net Tue Feb 22 04:18:11 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Tue, 22 Feb 2022 04:18:11 GMT Subject: [jdk11u-dev] RFR: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream) Message-ID: Hi all, This pull request contains a backport of commit [06b33a0a](https://github.com/openjdk/jdk/commit/06b33a0ad78d1577711af22020cf5fdf25112523) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 4 Feb 2021 and was reviewed by Alexander Zvegintsev and Prasanta Sadhukhan. The new test failed before and works fine after the fix. No new issues were found by the java_desktop tests. Thanks! ------------- Commit messages: - Backport 06b33a0ad78d1577711af22020cf5fdf25112523 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/835/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=835&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261107 Stats: 56 lines in 2 files changed: 54 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/835.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/835/head:pull/835 PR: https://git.openjdk.java.net/jdk11u-dev/pull/835 From duke at openjdk.java.net Tue Feb 22 07:31:52 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Tue, 22 Feb 2022 07:31:52 GMT Subject: [jdk11u-dev] RFR: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" In-Reply-To: References: Message-ID: On Thu, 17 Feb 2022 02:29:19 GMT, Kimura Yukihiro wrote: > This is a backport of JDK-8254085:javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" > TestCaretPositionJTextPane.java fails also in jdk11, so needs to be fixed. > > This is a clean backport to 11u. I confirmed this test passed after this backport.? > Testing: > build on Windows x86_64 and Linux x86_64 > tier1 on Windows x86_64 and Linux x86_64 I would appliciate it if someone could sponsor the fix. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/829 From anton.tarasov at jetbrains.com Tue Feb 22 08:55:19 2022 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Tue, 22 Feb 2022 11:55:19 +0300 Subject: CFV: New JDK Updates Committer: Artem Semenov Message-ID: I hereby nominate Artem Semenov [1] to JDK Updates Committer. Artem actively contributes to the client/a11y area, noticeably improving a11y support on macOS, and he is not going to stop. The commits in Updates includes: 8 in 17u https://github.com/openjdk/jdk17u/commits/master?author=savoptik 2 ? 17u-dev https://github.com/openjdk/jdk17u-dev/commit/45002c0e675212989dbdfa97ae32066e0e806054 https://github.com/openjdk/jdk17u-dev/commit/592adc85d109a4d93f01c60e791ab5af6c31756e 2 ? 18u https://github.com/openjdk/jdk18u/commit/8fbe1724e0f783132a65c45503addad9d98a329e https://github.com/openjdk/jdk18u/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d Votes are due by 09h00 UTC on the 8th of March, 2022 Only current JDK Updates Committers (and above) [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [3]. [1] https://openjdk.java.net/census#asemenov [2] https://openjdk.java.net/census#jdk-updates [3] http://openjdk.java.net/projects/#committer-vote With regards, Anton. From yan at azul.com Tue Feb 22 09:03:31 2022 From: yan at azul.com (Yuri Nesterenko) Date: Tue, 22 Feb 2022 12:03:31 +0300 Subject: CFV: New JDK Updates Committer: Artem Semenov In-Reply-To: References: Message-ID: Vote: yes --yan On 22.02.2022 11:55, Anton Tarasov wrote: > I hereby nominate Artem Semenov [1] to JDK Updates Committer. > > Artem actively contributes to the client/a11y area, noticeably improving > a11y support on macOS, and he is not going to stop. The commits in Updates > includes: > > 8 in 17u > https://github.com/openjdk/jdk17u/commits/master?author=savoptik > > 2 ? 17u-dev > https://github.com/openjdk/jdk17u-dev/commit/45002c0e675212989dbdfa97ae32066e0e806054 > https://github.com/openjdk/jdk17u-dev/commit/592adc85d109a4d93f01c60e791ab5af6c31756e > > 2 ? 18u > https://github.com/openjdk/jdk18u/commit/8fbe1724e0f783132a65c45503addad9d98a329e > https://github.com/openjdk/jdk18u/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d > > Votes are due by 09h00 UTC on the 8th of March, 2022 > > Only current JDK Updates Committers (and above) [2] are eligible to vote on > this nomination. Votes must be cast in the open by replying to this mailing > list. For Three-Vote Consensus voting instructions, see [3]. > > [1] https://openjdk.java.net/census#asemenov > [2] https://openjdk.java.net/census#jdk-updates > [3] http://openjdk.java.net/projects/#committer-vote > > With regards, > Anton. > From mbaesken at openjdk.java.net Tue Feb 22 09:07:28 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 22 Feb 2022 09:07:28 GMT Subject: [jdk17u-dev] RFR: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 Message-ID: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 ------------- Commit messages: - Backport d3749de47832c6de4bcee9cf64a0b698e796b2f2 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/171/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=171&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277488 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/171.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/171/head:pull/171 PR: https://git.openjdk.java.net/jdk17u-dev/pull/171 From mbaesken at openjdk.java.net Tue Feb 22 09:38:20 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 22 Feb 2022 09:38:20 GMT Subject: [jdk11u-dev] RFR: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 Message-ID: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 ------------- Commit messages: - Backport d3749de47832c6de4bcee9cf64a0b698e796b2f2 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/836/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=836&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277488 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/836.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/836/head:pull/836 PR: https://git.openjdk.java.net/jdk11u-dev/pull/836 From vladimir.kempik at jetbrains.com Tue Feb 22 09:45:06 2022 From: vladimir.kempik at jetbrains.com (Vladimir Kempik) Date: Tue, 22 Feb 2022 12:45:06 +0300 Subject: CFV: New JDK Updates Committer: Artem Semenov In-Reply-To: References: Message-ID: Vote: yes > 22 ????. 2022 ?., ? 11:55, Anton Tarasov ???????(?): > > I hereby nominate Artem Semenov [1] to JDK Updates Committer. > > Artem actively contributes to the client/a11y area, noticeably improving > a11y support on macOS, and he is not going to stop. The commits in Updates > includes: > > 8 in 17u > https://github.com/openjdk/jdk17u/commits/master?author=savoptik > > 2 ? 17u-dev > https://github.com/openjdk/jdk17u-dev/commit/45002c0e675212989dbdfa97ae32066e0e806054 > https://github.com/openjdk/jdk17u-dev/commit/592adc85d109a4d93f01c60e791ab5af6c31756e > > 2 ? 18u > https://github.com/openjdk/jdk18u/commit/8fbe1724e0f783132a65c45503addad9d98a329e > https://github.com/openjdk/jdk18u/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d > > Votes are due by 09h00 UTC on the 8th of March, 2022 > > Only current JDK Updates Committers (and above) [2] are eligible to vote on > this nomination. Votes must be cast in the open by replying to this mailing > list. For Three-Vote Consensus voting instructions, see [3]. > > [1] https://openjdk.java.net/census#asemenov > [2] https://openjdk.java.net/census#jdk-updates > [3] http://openjdk.java.net/projects/#committer-vote > > With regards, > Anton. From adinn at redhat.com Tue Feb 22 10:47:12 2022 From: adinn at redhat.com (Andrew Dinn) Date: Tue, 22 Feb 2022 10:47:12 +0000 Subject: CFV: New JDK Updates Committer: Artem Semenov In-Reply-To: References: Message-ID: <727cc8d1-72e2-57f2-e9c3-b1fdeaca59b7@redhat.com> Vote: yes On 22/02/2022 08:55, Anton Tarasov wrote: > I hereby nominate Artem Semenov [1] to JDK Updates Committer. > > Artem actively contributes to the client/a11y area, noticeably improving > a11y support on macOS, and he is not going to stop. The commits in Updates > includes: > > 8 in 17u > https://github.com/openjdk/jdk17u/commits/master?author=savoptik > > 2 ? 17u-dev > https://github.com/openjdk/jdk17u-dev/commit/45002c0e675212989dbdfa97ae32066e0e806054 > https://github.com/openjdk/jdk17u-dev/commit/592adc85d109a4d93f01c60e791ab5af6c31756e > > 2 ? 18u > https://github.com/openjdk/jdk18u/commit/8fbe1724e0f783132a65c45503addad9d98a329e > https://github.com/openjdk/jdk18u/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d > > Votes are due by 09h00 UTC on the 8th of March, 2022 > > Only current JDK Updates Committers (and above) [2] are eligible to vote on > this nomination. Votes must be cast in the open by replying to this mailing > list. For Three-Vote Consensus voting instructions, see [3]. > > [1] https://openjdk.java.net/census#asemenov > [2] https://openjdk.java.net/census#jdk-updates > [3] http://openjdk.java.net/projects/#committer-vote > > With regards, > Anton. > -- regards, Andrew Dinn ----------- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill From aleonard at openjdk.java.net Tue Feb 22 11:11:12 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 22 Feb 2022 11:11:12 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v3] In-Reply-To: References: Message-ID: <2hoDPH_U_pPmZL5oWiXIRIQ5Oc4wjmFdcSKjUoOtTuU=.f80bf474-c086-4504-bc00-a3527c88a763@github.com> On Fri, 18 Feb 2022 19:27:34 GMT, Andrew Leonard wrote: >> This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. > > Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision: > > 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup > > Signed-off-by: Andrew Leonard Can I get a review of this backport please? The only reason it's not clean is because the Skara backport was created incorrectly as the dependent code which this fixes was not merged at that time (https://bugs.openjdk.java.net/browse/JDK-8278080), and thus the backport did not apply the 3 lines deletion part of the original upstream fix because those lines did not exist at that time. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From sgehwolf at openjdk.java.net Tue Feb 22 12:54:06 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 22 Feb 2022 12:54:06 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v3] In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 19:27:34 GMT, Andrew Leonard wrote: >> This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. > > Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision: > > 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup > > Signed-off-by: Andrew Leonard The reason this is not clean is the copyright change. The original change didn't include it: https://github.com/openjdk/jdk/commit/45da3aea22fd85f214e661b2c98631cb91ddb55d Remove it and it'll show up as clean :) ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From yan at openjdk.java.net Tue Feb 22 13:47:36 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 22 Feb 2022 13:47:36 GMT Subject: [jdk15u-dev] RFR: 8276141: XPathFactory set/getProperty method [v2] In-Reply-To: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> References: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> Message-ID: > get/setProperty added plus test and presumably CSR; difference from the original is in LAstModified of XPathFactoryImpl.java and the test context. Yuri Nesterenko has updated the pull request incrementally with one additional commit since the last revision: forgotten test ------------- Changes: - all: https://git.openjdk.java.net/jdk15u-dev/pull/179/files - new: https://git.openjdk.java.net/jdk15u-dev/pull/179/files/3aa59e15..61ee9a0f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=179&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=179&range=00-01 Stats: 63 lines in 1 file changed: 58 ins; 3 del; 2 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/179.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/179/head:pull/179 PR: https://git.openjdk.java.net/jdk15u-dev/pull/179 From yan at openjdk.java.net Tue Feb 22 13:55:36 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 22 Feb 2022 13:55:36 GMT Subject: [jdk13u-dev] RFR: 8276141: XPathFactory set/getProperty method [v2] In-Reply-To: References: Message-ID: > Difference against the original: no LastModified in XPathFactoryImpl.java in 13/15; the test patch manually applied. Yuri Nesterenko has updated the pull request incrementally with one additional commit since the last revision: forgotten test ------------- Changes: - all: https://git.openjdk.java.net/jdk13u-dev/pull/329/files - new: https://git.openjdk.java.net/jdk13u-dev/pull/329/files/54e1bf21..2d99ba15 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=329&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=329&range=00-01 Stats: 63 lines in 1 file changed: 58 ins; 3 del; 2 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/329.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/329/head:pull/329 PR: https://git.openjdk.java.net/jdk13u-dev/pull/329 From abakhtin at openjdk.java.net Tue Feb 22 14:52:02 2022 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Tue, 22 Feb 2022 14:52:02 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: <_7CSnuMPjV3XpQC620LgAjKc6U6yTspyGYjgEtO5rWc=.6c3dd816-7007-4b41-85bf-0e1f54e5ba20@github.com> On Fri, 24 Dec 2021 17:23:26 GMT, Alexey Pavlyutkin wrote: > This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u > > I'd like to backport JDK-8274471 to jdk17u-dev > > The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS > > The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) > - imported few required packages > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security Minor comments of the OCSP changes: The original patch removes unused imports. These unused imports were caused by JDK-8232066: ?Remove outdated code/methods from PKIX implementation? JDK-8232066 does not affect the functionality of this enhancement and can be skipped So, looks good to me (not a reviewer) ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From mbaesken at openjdk.java.net Tue Feb 22 15:37:51 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 22 Feb 2022 15:37:51 GMT Subject: [jdk11u-dev] Integrated: 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail In-Reply-To: <3HTxJuPz_gG1dYwptR8gGX5ScYcmF66WdA1YVPdWc34=.08c78a7f-cd67-4625-be11-1944e4b8496f@github.com> References: <3HTxJuPz_gG1dYwptR8gGX5ScYcmF66WdA1YVPdWc34=.08c78a7f-cd67-4625-be11-1944e4b8496f@github.com> Message-ID: On Fri, 18 Feb 2022 12:44:16 GMT, Matthias Baesken wrote: > 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail This pull request has now been integrated. Changeset: 26e599dc Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/26e599dce20b0ba21273df30ad3cc7242c67a98f Stats: 76 lines in 3 files changed: 35 ins; 0 del; 41 mod 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail Backport-of: fd206e1e7e2a78203305c6bf94fb2db5e410e7f7 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/833 From mbaesken at openjdk.java.net Tue Feb 22 15:40:03 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 22 Feb 2022 15:40:03 GMT Subject: [jdk17u-dev] Integrated: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 In-Reply-To: References: Message-ID: On Tue, 22 Feb 2022 08:58:13 GMT, Matthias Baesken wrote: > 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 This pull request has now been integrated. Changeset: 5de8b785 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/5de8b78504df916d88c9e01941c4e27bfe49e949 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 Backport-of: d3749de47832c6de4bcee9cf64a0b698e796b2f2 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/171 From aleonard at openjdk.java.net Tue Feb 22 15:56:13 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 22 Feb 2022 15:56:13 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v3] In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 19:27:34 GMT, Andrew Leonard wrote: >> This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. > > Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision: > > 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup > > Signed-off-by: Andrew Leonard Ah! nice one Severin, i'll change that. Thanks Andrew On Tue, Feb 22, 2022 at 12:50 PM Severin Gehwolf ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > The reason this is not clean is the copyright change. The original change > didn't include it: ***@***.*** > > > Remove it and it'll show up as clean :) > > ? > Reply to this email directly, view it on GitHub > , > or unsubscribe > > . > Triage notifications on the go with GitHub Mobile for iOS > > or Android > . > > You are receiving this because you authored the thread.Message ID: > ***@***.***> > ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From aleonard at openjdk.java.net Tue Feb 22 16:04:46 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 22 Feb 2022 16:04:46 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v4] In-Reply-To: References: Message-ID: > This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision: Restore copyright date change back to the original change date Signed-off-by: Andrew Leonard ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/170/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/170/files/a3549b29..7dbf3821 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=170&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=170&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/170.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/170/head:pull/170 PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From sgehwolf at openjdk.java.net Tue Feb 22 16:04:46 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 22 Feb 2022 16:04:46 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v4] In-Reply-To: References: Message-ID: On Tue, 22 Feb 2022 16:00:39 GMT, Andrew Leonard wrote: >> This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. > > Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision: > > Restore copyright date change back to the original change date > > Signed-off-by: Andrew Leonard You don't need the review, but it looks good to me anyway :) ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From aleonard at openjdk.java.net Tue Feb 22 16:04:47 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 22 Feb 2022 16:04:47 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v3] In-Reply-To: References: Message-ID: On Tue, 22 Feb 2022 12:50:19 GMT, Severin Gehwolf wrote: >> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision: >> >> 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup >> >> Signed-off-by: Andrew Leonard > > The reason this is not clean is the copyright change. The original change didn't include it: https://github.com/openjdk/jdk/commit/45da3aea22fd85f214e661b2c98631cb91ddb55d > > Remove it and it'll show up as clean :) @jerboaa thanks that's done the trick :-) ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From duke at openjdk.java.net Tue Feb 22 17:44:14 2022 From: duke at openjdk.java.net (Mat Carter) Date: Tue, 22 Feb 2022 17:44:14 GMT Subject: [jdk18u] Integrated: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled In-Reply-To: <39lS1JbYrH32fzHiChMK2sxilIA1_Gc-d2XCqfRBU7A=.5b19af0c-8ffe-446d-8362-00296196a449@github.com> References: <39lS1JbYrH32fzHiChMK2sxilIA1_Gc-d2XCqfRBU7A=.5b19af0c-8ffe-446d-8362-00296196a449@github.com> Message-ID: On Thu, 17 Feb 2022 16:36:59 GMT, Mat Carter wrote: > Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 This pull request has now been integrated. Changeset: 65d11651 Author: Mat Carter <54955201+macarte at users.noreply.github.com> Committer: Aleksei Efimov URL: https://git.openjdk.java.net/jdk18u/commit/65d11651a595ee255c22094658bcb76ee6927aa6 Stats: 19 lines in 1 file changed: 11 ins; 6 del; 2 mod 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled Backport-of: 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/29 From duke at openjdk.java.net Tue Feb 22 17:49:02 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Tue, 22 Feb 2022 17:49:02 GMT Subject: [jdk11u-dev] Integrated: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" In-Reply-To: References: Message-ID: On Thu, 17 Feb 2022 02:29:19 GMT, Kimura Yukihiro wrote: > This is a backport of JDK-8254085:javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" > TestCaretPositionJTextPane.java fails also in jdk11, so needs to be fixed. > > This is a clean backport to 11u. I confirmed this test passed after this backport.? > Testing: > build on Windows x86_64 and Linux x86_64 > tier1 on Windows x86_64 and Linux x86_64 This pull request has now been integrated. Changeset: 43788445 Author: Kimura Yukihiro Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/43788445840df8a1e043501941864eac8c3518dc Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" Backport-of: 51a865d66a5dddbbaaa4bb656fa02ecd1bee1a0b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/829 From phh at openjdk.java.net Tue Feb 22 17:49:56 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 22 Feb 2022 17:49:56 GMT Subject: [jdk11u-dev] RFR: 8214004: Missing space between compiler thread name and task info in hs_err In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 05:18:04 GMT, Kimura Yukihiro wrote: > I'd like to backport JDK-8214004. > The original patch does not applies cleanly because JDK-8163511 was applied first in 11u. > > The change only reflects JDK-8163511 on the following line, and there is no risk. > I tested tier1 with rhel and windows x86_64, and no errors found. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/831 From phh at openjdk.java.net Tue Feb 22 17:55:56 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 22 Feb 2022 17:55:56 GMT Subject: [jdk11u-dev] RFR: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException In-Reply-To: References: Message-ID: On Sat, 19 Feb 2022 04:20:24 GMT, Sergey Bylokhov wrote: > This is backport of the fix for [JDK-6986863](https://bugs.openjdk.java.net/browse/JDK-6986863), pushed to the [JDK 17](https://github.com/openjdk/jdk/commit/64a150c518ed1a936cd6e4cb5e60060243496901) > > This change prevents intermittent exceptions in the applications and tests caused by the weak synchronization of the color profiles loading, see additional details [here](https://github.com/openjdk/jdk/pull/1613). > > The new tests failed before and work fine after the fix. No new issues were found by the java_desktop tests. > The patch is not clean because the [getStandardProfile() ](https://github.com/openjdk/jdk/commit/64a150c518ed1a936cd6e4cb5e60060243496901#diff-b92a36346bec4c6f7d5e8921bd69b038e0932f116d627bb4f6b514e670e1fccdL923)method removed upstream is still used in the jdk11u-dev. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/834 From duke at openjdk.java.net Tue Feb 22 20:02:16 2022 From: duke at openjdk.java.net (Mat Carter) Date: Tue, 22 Feb 2022 20:02:16 GMT Subject: [jdk17u-dev] RFR: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled Message-ID: Backport of 65d11651a595ee255c22094658bcb76ee6927aa6 ------------- Commit messages: - Backport 65d11651a595ee255c22094658bcb76ee6927aa6 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/172/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=172&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272996 Stats: 19 lines in 1 file changed: 11 ins; 6 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/172.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/172/head:pull/172 PR: https://git.openjdk.java.net/jdk17u-dev/pull/172 From alexander.zuev at oracle.com Tue Feb 22 20:13:47 2022 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Tue, 22 Feb 2022 12:13:47 -0800 Subject: CFV: New JDK Updates Committer: Artem Semenov In-Reply-To: References: Message-ID: <689f5b69-5de1-4d71-16fd-44f1bc5fcf86@oracle.com> Vote: yes On 2/22/22 00:55, Anton Tarasov wrote: > I hereby nominate Artem Semenov [1] to JDK Updates Committer. > > Artem actively contributes to the client/a11y area, noticeably improving > a11y support on macOS, and he is not going to stop. The commits in Updates > includes: > > 8 in 17u > https://github.com/openjdk/jdk17u/commits/master?author=savoptik > > 2 ? 17u-dev > https://github.com/openjdk/jdk17u-dev/commit/45002c0e675212989dbdfa97ae32066e0e806054 > https://github.com/openjdk/jdk17u-dev/commit/592adc85d109a4d93f01c60e791ab5af6c31756e > > 2 ? 18u > https://github.com/openjdk/jdk18u/commit/8fbe1724e0f783132a65c45503addad9d98a329e > https://github.com/openjdk/jdk18u/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d > > Votes are due by 09h00 UTC on the 8th of March, 2022 > > Only current JDK Updates Committers (and above) [2] are eligible to vote on > this nomination. Votes must be cast in the open by replying to this mailing > list. For Three-Vote Consensus voting instructions, see [3]. > > [1] https://openjdk.java.net/census#asemenov > [2] https://openjdk.java.net/census#jdk-updates > [3] http://openjdk.java.net/projects/#committer-vote > > With regards, > Anton. From duke at openjdk.java.net Wed Feb 23 00:20:20 2022 From: duke at openjdk.java.net (zzambers) Date: Wed, 23 Feb 2022 00:20:20 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition Message-ID: Tested locally passed tests in test/jdk/com/sun/jdi for me. ------------- Commit messages: - Backport 4c52eb39431c2479b0d140907bdcc0311d30f871 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/837/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=837&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279669 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/837.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/837/head:pull/837 PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From serb at openjdk.java.net Wed Feb 23 03:36:18 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Wed, 23 Feb 2022 03:36:18 GMT Subject: [jdk15u-dev] RFR: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream) Message-ID: <8GwSSVa0IxcPGI3OnVdtpNk-HVvFhb325INWNwV3xwE=.269cafd9-0001-4b78-8735-469d4f6d7a09@github.com> Hi all, This pull request contains a backport of commit [06b33a0a](https://github.com/openjdk/jdk/commit/06b33a0ad78d1577711af22020cf5fdf25112523) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 4 Feb 2021 and was reviewed by Alexander Zvegintsev and Prasanta Sadhukhan. The new test failed before and works fine after the fix. No new issues were found by the java_desktop tests. Thanks! ------------- Commit messages: - Backport 06b33a0ad78d1577711af22020cf5fdf25112523 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/180/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=180&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261107 Stats: 56 lines in 2 files changed: 54 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/180.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/180/head:pull/180 PR: https://git.openjdk.java.net/jdk15u-dev/pull/180 From goetz at openjdk.java.net Wed Feb 23 08:14:59 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Feb 2022 08:14:59 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> Message-ID: On Fri, 11 Feb 2022 07:15:07 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: > > - One more tiny detail > - These changes sneaked in from anonther backport @martinuy, will you find time to look at this change this week? Next Tuesday rampdown begins, would be nice to have this pushed by then. Thanks, Goetz. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From sgehwolf at openjdk.java.net Wed Feb 23 10:20:56 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 23 Feb 2022 10:20:56 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 00:13:55 GMT, zzambers wrote: > Tested locally passed tests in test/jdk/com/sun/jdi for me. LGTM. JDK-8206330 is not in 11, thus the hunk to the else branch is not needed. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From duke at openjdk.java.net Wed Feb 23 13:24:55 2022 From: duke at openjdk.java.net (zzambers) Date: Wed, 23 Feb 2022 13:24:55 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 00:13:55 GMT, zzambers wrote: > Tested locally passed tests in test/jdk/com/sun/jdi for me. Interestingly for some reason there are some failures in git workflow tests (but nothing related to this change). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From goetz.lindenmaier at sap.com Wed Feb 23 13:34:48 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 23 Feb 2022 13:34:48 +0000 Subject: [11u reminder]: jdk 11.0.15 rampdown starts Tuesday, March 1st, 18:00 CET. Message-ID: Hi, I would like to remind everybody who is working on jdk 11 updates that rampdown of 11.0.15 starts next March 1st, at 18:00 CET. At that point in time the last merge from jdk11u-dev to jdk11u will take place. Please push all changes you want to get to 11.0.15 before that date. After that, changes for 11.0.16 must be requested with jdk11u-critical-request tags, and they need to be pushed directly to jdk11u. Best regards, Goetz See also https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u From goetz.lindenmaier at sap.com Wed Feb 23 13:37:36 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 23 Feb 2022 13:37:36 +0000 Subject: [17u reminder]: jdk 17.0.3 rampdown starts Tuesday, March 1st, 18:00 CET Message-ID: Hi, I would like to remind everybody who is working on jdk 17 updates that rampdown of 17.0.3 starts next March 1st, at 18:00 CET. At that point in time the last merge from jdk17u-dev to jdk17u will take place. Please push all changes you want to get to 17.0.3 before that date. After that, changes for 17.0.3 must be requested with jdk17u-critical-request tags, and they need to be pushed directly to jdk17u. Best regards, Goetz See also https://wiki.openjdk.java.net/display/JDKUpdates/JDK+17u From mbaesken at openjdk.java.net Wed Feb 23 13:45:54 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Feb 2022 13:45:54 GMT Subject: [jdk11u-dev] Integrated: 8247515: OSX pc_to_symbol() lookup does not work with core files In-Reply-To: <5ksTZ-Jv0X2EJFKhq4nCPNyYxtXieMqXhNA2FlaI1Jc=.a0ea3a32-7111-46eb-ae0c-b2447f0f4846@github.com> References: <5ksTZ-Jv0X2EJFKhq4nCPNyYxtXieMqXhNA2FlaI1Jc=.a0ea3a32-7111-46eb-ae0c-b2447f0f4846@github.com> Message-ID: On Fri, 18 Feb 2022 09:16:26 GMT, Matthias Baesken wrote: > 8247515: OSX pc_to_symbol() lookup does not work with core files This pull request has now been integrated. Changeset: ffa5ae86 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/ffa5ae86c93774089b29f0a1d73e7273c40d7174 Stats: 112 lines in 4 files changed: 68 ins; 12 del; 32 mod 8247515: OSX pc_to_symbol() lookup does not work with core files Backport-of: ab729d7075d718b146b643d1b4c2735adaeb7194 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/832 From mbaesken at openjdk.java.net Wed Feb 23 13:57:13 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Feb 2022 13:57:13 GMT Subject: [jdk11u-dev] RFR: 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols Message-ID: 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols ------------- Commit messages: - Backport d12fdfa3b75a72c7f78a625f3774a35ac147960e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/838/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=838&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8250750 Stats: 27 lines in 5 files changed: 13 ins; 2 del; 12 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/838.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/838/head:pull/838 PR: https://git.openjdk.java.net/jdk11u-dev/pull/838 From harold.seigel at oracle.com Wed Feb 23 14:20:16 2022 From: harold.seigel at oracle.com (Harold Seigel) Date: Wed, 23 Feb 2022 09:20:16 -0500 Subject: CFV: New JDK Updates Committer: Artem Semenov In-Reply-To: References: Message-ID: Vote: Yes Harold On 2/22/2022 3:55 AM, Anton Tarasov wrote: > I hereby nominate Artem Semenov [1] to JDK Updates Committer. > > Artem actively contributes to the client/a11y area, noticeably improving > a11y support on macOS, and he is not going to stop. The commits in Updates > includes: > > 8 in 17u > https://github.com/openjdk/jdk17u/commits/master?author=savoptik > > 2 ? 17u-dev > https://github.com/openjdk/jdk17u-dev/commit/45002c0e675212989dbdfa97ae32066e0e806054 > https://github.com/openjdk/jdk17u-dev/commit/592adc85d109a4d93f01c60e791ab5af6c31756e > > 2 ? 18u > https://github.com/openjdk/jdk18u/commit/8fbe1724e0f783132a65c45503addad9d98a329e > https://github.com/openjdk/jdk18u/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d > > Votes are due by 09h00 UTC on the 8th of March, 2022 > > Only current JDK Updates Committers (and above) [2] are eligible to vote on > this nomination. Votes must be cast in the open by replying to this mailing > list. For Three-Vote Consensus voting instructions, see [3]. > > [1] https://openjdk.java.net/census#asemenov > [2] https://openjdk.java.net/census#jdk-updates > [3] http://openjdk.java.net/projects/#committer-vote > > With regards, > Anton. From stuefe at openjdk.java.net Wed Feb 23 14:50:15 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 23 Feb 2022 14:50:15 GMT Subject: [jdk17u-dev] RFR: 8277383: VM.metaspace optionally show chunk freelist details Message-ID: <9OUcZmj0hB2ZmPGWFbbjRSZ9e8wKj3wyy5_FT7HmLFM=.e583fe34-640c-4ea9-9150-cdd09d37f997@github.com> I'd like to backport this to jdk17 since it adds a useful option for metaspace analysis. Fix is low risk and applies cleanly. The commit being backported was authored by Thomas Stuefe on 7 Dec 2021 and was reviewed by Coleen Phillimore and Aleksey Shipilev. ------------- Commit messages: - Backport 35361270cb3aae9fa560736f8d05f1b258704c87 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/173/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=173&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277383 Stats: 48 lines in 5 files changed: 47 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/173.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/173/head:pull/173 PR: https://git.openjdk.java.net/jdk17u-dev/pull/173 From stuefe at openjdk.java.net Wed Feb 23 15:18:37 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 23 Feb 2022 15:18:37 GMT Subject: [jdk17u-dev] RFR: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests Message-ID: Hi all, I'd like to backport this little enhancement to cut down on testing time in jdk17u. The fix is low risk and has been in jdk18+ since last September. Fix applies cleanly. The commit being backported was authored by Thomas Stuefe on 4 Aug 2021 and was reviewed by Thomas Schatzl and Richard Reingruber. Thanks! ------------- Commit messages: - Backport 66c653c561b3b5e904579af62e23ff94952bca05 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/174/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=174&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271721 Stats: 35 lines in 1 file changed: 23 ins; 5 del; 7 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/174.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/174/head:pull/174 PR: https://git.openjdk.java.net/jdk17u-dev/pull/174 From duke at openjdk.java.net Wed Feb 23 15:52:39 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Wed, 23 Feb 2022 15:52:39 GMT Subject: [jdk15u-dev] RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 Message-ID: A backport of a configurable implementation of _onSpinWait() intrinsic to achieve parity with x86 which has it implemented. The risk of changes is low. By default it is off. Tested for fastdebug and release builds: - `gtest`: Passed - `tier1`...`tier3`: Passed except [JDK-8261534](https://bugs.openjdk.java.net/browse/JDK-8261534) and [JDK-8277488](https://bugs.openjdk.java.net/browse/JDK-8277488) - `hotspot/jtreg/compiler/onSpinWait`: Passed Applying the patch had issues to find proper positions. No code changes are needed after repositioning. Changes to `globals_aarch64.hpp` needed the new added options definitions to be converted from the new format to the old one. `vm.flagless` was removed from the new tests. Changes to `vm_version_aarch64.cpp`, instantiation of `SpinWait`, use C++11 syntax. They needed to be changed to C++03 syntax. ------------- Commit messages: - Backport 6954b98f8faf29b6c2d13687a7a94e83302bdd85 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/181/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=181&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8186670 Stats: 765 lines in 13 files changed: 763 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/181.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/181/head:pull/181 PR: https://git.openjdk.java.net/jdk15u-dev/pull/181 From duke at openjdk.java.net Wed Feb 23 15:59:26 2022 From: duke at openjdk.java.net (zzambers) Date: Wed, 23 Feb 2022 15:59:26 GMT Subject: [jdk17u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition Message-ID: Tested locally test/jdk/com/sun/jdi tests passed for me. ------------- Commit messages: - Backport 4c52eb39431c2479b0d140907bdcc0311d30f871 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/175/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=175&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279669 Stats: 7 lines in 1 file changed: 1 ins; 2 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/175.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/175/head:pull/175 PR: https://git.openjdk.java.net/jdk17u-dev/pull/175 From duke at openjdk.java.net Wed Feb 23 16:15:24 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Wed, 23 Feb 2022 16:15:24 GMT Subject: [jdk15u-dev] RFR: 8261534: Test sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java fails on platforms where no nsslib artifacts are defined Message-ID: [JDK-8259319](https://bugs.openjdk.java.net/browse/JDK-8259319) was backported to 15u. As we see the test failing, we need to backport this testfix to 15u as well. Patch applies cleanly. No risk, testfix only. Tested: - `make run-test TEST=sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java`: Passed ------------- Commit messages: - Backport dc46aa85c6e16cb904d1c40a4577b5e48c56a3d4 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/182/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=182&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261534 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/182.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/182/head:pull/182 PR: https://git.openjdk.java.net/jdk15u-dev/pull/182 From gnu.andrew at redhat.com Wed Feb 23 16:33:15 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 23 Feb 2022 16:33:15 +0000 Subject: OpenJDK 11.0.14.1 Released Message-ID: We are pleased to announce the release of OpenJDK 11.0.14.1. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.14.1-ga.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.14.1-ga.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: 3e4709c1d8c3e6eff584c93d7c80dd0ff30a215399739e699a0d682f660d4636 openjdk-11.0.14.1-ga.tar.xz b7c9c9d77ee1acd3281804e26805a9292a718f221ff3f141c10c1e94dc4d7ddb openjdk-11.0.14.1-ga.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.14.1-ga.sha256 New in release OpenJDK 11.0.14.1 (2022-02-08): ============================================= Live versions of these release notes can be found at: * https://bitly.com/openjdk110141 * https://builds.shipilev.net/backports-monitor/release-notes-11.0.14.1.txt * Other changes - JDK-8218546: Unable to connect to https://google.com using java.net.HttpClient - JDK-8280786: Build failure on Solaris after 8262392 Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From duke at openjdk.java.net Wed Feb 23 17:10:24 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Wed, 23 Feb 2022 17:10:24 GMT Subject: [jdk15u-dev] RFR: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 Message-ID: <8WsMYmsmykXQ2gPZq80NE21-8R3EEJ7uIYAALXZI6-Q=.b0b4656f-27db-4fdc-91eb-8a288d4af89b@github.com> A backport to fix an issue with the test. When it is applied it has a conflict with a Copyright line. No other conflicts. ------------- Commit messages: - Backport d3749de47832c6de4bcee9cf64a0b698e796b2f2 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/183/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=183&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277488 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/183.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/183/head:pull/183 PR: https://git.openjdk.java.net/jdk15u-dev/pull/183 From andrew at openjdk.java.net Wed Feb 23 17:14:27 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 23 Feb 2022 17:14:27 GMT Subject: [jdk11u-dev] RFR: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32 Message-ID: The `slowdebug` build in 11u is broken in the same way as trunk was before this fix. We recently had to build 11u on x86_32 using Zero, due to issues with the new GCC 12 release, and the slowdebug build failed with this broken assert. Removing it allowed the build to complete. Backport is clean, but couldn't be automated as later JDK versions have the file in a `zero` subdirectory. Additional checks: - [x] slowdebug build on x86_32 ------------- Commit messages: - Backport df55ecd83c70e8962e9037671cd13b104d3e5620 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/839/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=839&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257794 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/839.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/839/head:pull/839 PR: https://git.openjdk.java.net/jdk11u-dev/pull/839 From sgehwolf at redhat.com Wed Feb 23 17:22:17 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Wed, 23 Feb 2022 18:22:17 +0100 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: References: Message-ID: <76dfee314dd853d752a49469b45970029d1f8a74.camel@redhat.com> Hi Aleksei, On Thu, 2022-02-17 at 17:12 +0300, Aleksei Voitylov wrote: > Hi, > > Following recent backports of JEP 388 (Windows/AArch64 Port) and JEP 391 > (macOS/AArch64 Port), I?d like to propose a backport of JEP 386 (Alpine > Linux Port) [1] to OpenJDK 11u. Support for this port was baked in the > Portola project and integrated into OpenJDK 16. > > Motivation for 11u backport: the importance of this platform is > explained by wide adoption of Alpine Linux in container environments > [2]. Several OpenJDK vendors (Liberica, Corretto, Zulu) include patches > that enable Alpine/MUSL for 11u and 8u for quite some time, without any > issues. Others (MS) have recently added it. In our case the user demand > for Alpine/musl support for both 11u and 8u was at least as strong as > Mac/AArch64 and Windows/AArch64, I?d also like to hear if other OpenJDK > vendors share our view of the importance of this platform in 11u. > > The set of JBS issues required to be backported for Alpine/MUSL support > in 11u is: > > JDK-8217340 Compilation failed: tools/launcher/Test7029048.java > -??? Test-only fix > JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java > -??? Test-only fix > JDK-8245938 Remove unused print_stack(void) method from XToolkit.c > -??? Code fix, removal of dead code, applies cleanly > JDK-8252248 __SIGRTMAX is not declared in musl libc > -??? Code fix > JDK-8252250 isnanf is obsolete > -??? Code fix, substitutes isnanf with isnan which was proven to be ok > at least since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM > version ? see the discussion in JDK-8178689 for further details. > JDK-8247589 Implementation of Alpine Linux/x64 Port > -??? The actual build and code changes that tidy up code for MUSL > JDK-8247591 Document Alpine Linux build steps in OpenJDK build guide > -??? Docs only fix > > All patches combined: +480 lines, -146 lines. > All source code changes: +133 lines, -43 lines. > > For risk assessment and preliminary examination of the 11u maintainers, > the full patchset can be observed in [3], separate 11u backports can be > found in [4]. I plan to submit the actual PRs for individual backports > one by one unless I hear reasonable concerns from 11u maintainers on the > proposed changes. > > The patchset passes full JCK+jtreg set without any regressions to other > platforms (Windows, Linux, Mac, Solaris), including non-Intel where > applicable. During integration of JEP 386 SAP kindly verified that these > changes do not break AIX/XLC. > > On the maintenance side, BellSoft will be happy to support this platform > in 11u. But I?ll equally happily share the burden with other OpenJDK > vendors that currently support Alpine/MUSL. This seems fine. We should converge local backports upstream if several downstream vendors have it. Thanks for proposing these backports upstream. Cheers, Severin > Thanks, > -Aleksei > > [1] https://openjdk.java.net/jeps/386 > [2] https://hub.docker.com/_/alpine > [3] > https://github.com/voitylov/jdk11u-dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da398797738fbfd1eaf02e1f887e306 > [4] > 8217340: > https://github.com/voitylov/jdk11u-dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a > 8247592: > https://github.com/voitylov/jdk11u-dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd > 8245938: > https://github.com/voitylov/jdk11u-dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a > 8252248: > https://github.com/voitylov/jdk11u-dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 > 8252250: > https://github.com/voitylov/jdk11u-dev/commit/41b6b490fe60c640c90d9e594557215e669955cc > 8247589: > https://github.com/voitylov/jdk11u-dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 > 8247591: > https://github.com/voitylov/jdk11u-dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 > > From thomas.stuefe at gmail.com Wed Feb 23 18:18:01 2022 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Wed, 23 Feb 2022 19:18:01 +0100 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: References: Message-ID: Hi Alexei, I think this makes sense and is probably less risky than backporting JEP 388 and JEP 391. Thanks for doing the work, this looks well prepared for review already. I have some questions, which had not been immediately clear from the mail. I may be just slow. - Did you have to make 11u specific changes to the individual backports? If yes, what and why? - are there changes to the glibc variant in 11u, and if yes, why? In other words, will anything change for the existing platforms? Because theoretically, nothing should, right? I see the change to isnan, is that motivated to just applying the upstream patch without change, or was there a deeper reason? Thank you! Thomas On Thu, Feb 17, 2022 at 3:12 PM Aleksei Voitylov < aleksei.voitylov at bell-sw.com> wrote: > Hi, > > Following recent backports of JEP 388 (Windows/AArch64 Port) and JEP 391 > (macOS/AArch64 Port), I?d like to propose a backport of JEP 386 (Alpine > Linux Port) [1] to OpenJDK 11u. Support for this port was baked in the > Portola project and integrated into OpenJDK 16. > > Motivation for 11u backport: the importance of this platform is > explained by wide adoption of Alpine Linux in container environments > [2]. Several OpenJDK vendors (Liberica, Corretto, Zulu) include patches > that enable Alpine/MUSL for 11u and 8u for quite some time, without any > issues. Others (MS) have recently added it. In our case the user demand > for Alpine/musl support for both 11u and 8u was at least as strong as > Mac/AArch64 and Windows/AArch64, I?d also like to hear if other OpenJDK > vendors share our view of the importance of this platform in 11u. > > The set of JBS issues required to be backported for Alpine/MUSL support > in 11u is: > > JDK-8217340 Compilation failed: tools/launcher/Test7029048.java > - Test-only fix > JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java > - Test-only fix > JDK-8245938 Remove unused print_stack(void) method from XToolkit.c > - Code fix, removal of dead code, applies cleanly > JDK-8252248 __SIGRTMAX is not declared in musl libc > - Code fix > JDK-8252250 isnanf is obsolete > - Code fix, substitutes isnanf with isnan which was proven to be ok > at least since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM > version ? see the discussion in JDK-8178689 for further details. > JDK-8247589 Implementation of Alpine Linux/x64 Port > - The actual build and code changes that tidy up code for MUSL > JDK-8247591 Document Alpine Linux build steps in OpenJDK build guide > - Docs only fix > > All patches combined: +480 lines, -146 lines. > All source code changes: +133 lines, -43 lines. > > For risk assessment and preliminary examination of the 11u maintainers, > the full patchset can be observed in [3], separate 11u backports can be > found in [4]. I plan to submit the actual PRs for individual backports > one by one unless I hear reasonable concerns from 11u maintainers on the > proposed changes. > > The patchset passes full JCK+jtreg set without any regressions to other > platforms (Windows, Linux, Mac, Solaris), including non-Intel where > applicable. During integration of JEP 386 SAP kindly verified that these > changes do not break AIX/XLC. > > On the maintenance side, BellSoft will be happy to support this platform > in 11u. But I?ll equally happily share the burden with other OpenJDK > vendors that currently support Alpine/MUSL. > > Thanks, > -Aleksei > > [1] https://openjdk.java.net/jeps/386 > [2] https://hub.docker.com/_/alpine > [3] > > https://github.com/voitylov/jdk11u-dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da398797738fbfd1eaf02e1f887e306 > [4] > 8217340: > > https://github.com/voitylov/jdk11u-dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a > 8247592: > > https://github.com/voitylov/jdk11u-dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd > 8245938: > > https://github.com/voitylov/jdk11u-dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a > 8252248: > > https://github.com/voitylov/jdk11u-dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 > 8252250: > > https://github.com/voitylov/jdk11u-dev/commit/41b6b490fe60c640c90d9e594557215e669955cc > 8247589: > > https://github.com/voitylov/jdk11u-dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 > 8247591: > > https://github.com/voitylov/jdk11u-dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 > > > From stuefe at openjdk.java.net Wed Feb 23 18:24:13 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 23 Feb 2022 18:24:13 GMT Subject: [jdk17u-dev] Integrated: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 15:10:05 GMT, Thomas Stuefe wrote: > Hi all, > > I'd like to backport this little enhancement to cut down on testing time in jdk17u. The fix is low risk and has been in jdk18+ since last September. Fix applies cleanly. > > The commit being backported was authored by Thomas Stuefe on 4 Aug 2021 and was reviewed by Thomas Schatzl and Richard Reingruber. > > Thanks! This pull request has now been integrated. Changeset: 9bb8b7fb Author: Thomas Stuefe URL: https://git.openjdk.java.net/jdk17u-dev/commit/9bb8b7fba279b1006e336e1b8cdd3774c464efe3 Stats: 35 lines in 1 file changed: 23 ins; 5 del; 7 mod 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests Backport-of: 66c653c561b3b5e904579af62e23ff94952bca05 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/174 From stuefe at openjdk.java.net Wed Feb 23 18:24:12 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 23 Feb 2022 18:24:12 GMT Subject: [jdk17u-dev] RFR: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 15:10:05 GMT, Thomas Stuefe wrote: > Hi all, > > I'd like to backport this little enhancement to cut down on testing time in jdk17u. The fix is low risk and has been in jdk18+ since last September. Fix applies cleanly. > > The commit being backported was authored by Thomas Stuefe on 4 Aug 2021 and was reviewed by Thomas Schatzl and Richard Reingruber. > > Thanks! Got approval. Test error has nothing to do with this test. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/174 From stuefe at openjdk.java.net Wed Feb 23 18:26:04 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 23 Feb 2022 18:26:04 GMT Subject: [jdk17u-dev] Integrated: 8277383: VM.metaspace optionally show chunk freelist details In-Reply-To: <9OUcZmj0hB2ZmPGWFbbjRSZ9e8wKj3wyy5_FT7HmLFM=.e583fe34-640c-4ea9-9150-cdd09d37f997@github.com> References: <9OUcZmj0hB2ZmPGWFbbjRSZ9e8wKj3wyy5_FT7HmLFM=.e583fe34-640c-4ea9-9150-cdd09d37f997@github.com> Message-ID: On Wed, 23 Feb 2022 14:39:26 GMT, Thomas Stuefe wrote: > I'd like to backport this to jdk17 since it adds a useful option for metaspace analysis. Fix is low risk and applies cleanly. > > The commit being backported was authored by Thomas Stuefe on 7 Dec 2021 and was reviewed by Coleen Phillimore and Aleksey Shipilev. This pull request has now been integrated. Changeset: 0c6e662f Author: Thomas Stuefe URL: https://git.openjdk.java.net/jdk17u-dev/commit/0c6e662f0a2daae12f2ab2a840941bdcae0ca22e Stats: 48 lines in 5 files changed: 47 ins; 0 del; 1 mod 8277383: VM.metaspace optionally show chunk freelist details Backport-of: 35361270cb3aae9fa560736f8d05f1b258704c87 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/173 From phh at openjdk.java.net Wed Feb 23 18:58:48 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 23 Feb 2022 18:58:48 GMT Subject: [jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 [v2] In-Reply-To: References: Message-ID: On Mon, 7 Feb 2022 12:50:45 GMT, Paul Hohensee wrote: >> I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. >> >> Testing: tier1, including the new and existing sha tests. >> >> Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. >> >> 1. Copyright date conflicts. >> 2. Context differences. >> 3. Changing SHAOptionsBase to DigestOptionsBase. >> 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. >> >> This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). > > Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8250902: Implement MD5 Intrinsics on x86 > - Merge branch 'master' into backport-339016a0 > - 8250902: Implement MD5 Intrinsics on x86 > - Backport 339016a0f2cbbbbc3560e50c6726e14afbf547f6 Backport rejected. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From phh at openjdk.java.net Wed Feb 23 18:58:48 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 23 Feb 2022 18:58:48 GMT Subject: [jdk11u-dev] Withdrawn: 8250902: Implement MD5 Intrinsics on x86 In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 20:19:10 GMT, Paul Hohensee wrote: > I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto. > > Testing: tier1, including the new and existing sha tests. > > Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean. > > 1. Copyright date conflicts. > 2. Context differences. > 3. Changing SHAOptionsBase to DigestOptionsBase. > 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11. > > This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/806 From sgehwolf at openjdk.java.net Wed Feb 23 19:22:58 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 23 Feb 2022 19:22:58 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: <50_TUzAtlOOEAqUkw7unl4HnU8YmJ0j4JLYL_rSAUWM=.7298a775-b0cf-4756-860e-49feb44980f9@github.com> On Wed, 23 Feb 2022 13:21:31 GMT, zzambers wrote: >> Tested locally passed tests in test/jdk/com/sun/jdi for me. > > Interestingly for some reason there are some failures in git workflow tests (but nothing related to this change). @zzambers Please only integrate once you've got backport approval from an 11u maintainer. Please let me know if you need help with process work. See: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u for some process documentation. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From aleonard at openjdk.java.net Wed Feb 23 19:27:56 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Wed, 23 Feb 2022 19:27:56 GMT Subject: [jdk17u-dev] Integrated: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 16:47:49 GMT, Andrew Leonard wrote: > This PR backports the fix for resolving the --with-cacerts-src variable correctly as part of https://bugs.openjdk.java.net/browse/JDK-8278080. This pull request has now been integrated. Changeset: 56f0c53c Author: Andrew Leonard Committer: Severin Gehwolf URL: https://git.openjdk.java.net/jdk17u-dev/commit/56f0c53c59d79a0d6b43b93abc0cf27eab4eac79 Stats: 8 lines in 1 file changed: 4 ins; 3 del; 1 mod 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup Reviewed-by: sgehwolf Backport-of: 45da3aea22fd85f214e661b2c98631cb91ddb55d ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From duke at openjdk.java.net Wed Feb 23 19:30:02 2022 From: duke at openjdk.java.net (Mat Carter) Date: Wed, 23 Feb 2022 19:30:02 GMT Subject: [jdk17u-dev] Withdrawn: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled In-Reply-To: References: Message-ID: On Tue, 22 Feb 2022 19:52:24 GMT, Mat Carter wrote: > Backport of 65d11651a595ee255c22094658bcb76ee6927aa6 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/172 From duke at openjdk.java.net Wed Feb 23 20:06:50 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Feb 2022 20:06:50 GMT Subject: [jdk11u-dev] Withdrawn: 8254775: Microbenchmark StringIndexOfChar doesn't compile In-Reply-To: <01_5dx6u6MUHsnB0ZLh22Z6ah7ROpagNKvun1RBsMK0=.d9cc0a27-24d5-493c-ac73-83be5b0f51de@github.com> References: <01_5dx6u6MUHsnB0ZLh22Z6ah7ROpagNKvun1RBsMK0=.d9cc0a27-24d5-493c-ac73-83be5b0f51de@github.com> Message-ID: <3bdryTbRbomOgPiEd6ye47wmC3u3P5CMbk5vfi4VR1o=.37adf311-b196-4f10-9fce-ff27e12968af@github.com> On Fri, 18 Jun 2021 18:59:34 GMT, Dmitry Chuyko wrote: > This a follow-up to https://github.com/openjdk/jdk11u-dev/pull/41. > Original patch applies cleanly after JDK-8173585. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/42 From duke at openjdk.java.net Wed Feb 23 20:10:01 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Feb 2022 20:10:01 GMT Subject: [jdk11u-dev] Withdrawn: 8173585: Intrinsify StringLatin1.indexOf(char) In-Reply-To: References: Message-ID: <6fnnLLNxS9AhDKeHK8XKs0ugu38hJrmQ6DMHTpHIOrc=.124bd95e-343c-4c58-a0ca-2da00f14872d@github.com> On Fri, 18 Jun 2021 18:55:04 GMT, Dmitry Chuyko wrote: > I'd like to backport StringLatin1.indexOf(char) intrinsic. Several issues to backport: > > JDK-8173585 - This one, main change. > JDK-8254775 - Microbenchmark compilation fix. Applies on top of JDK-8173585. > JDK-8255274 - fix for PPC. > JDK-8254785 - Graal intrinsics test fix. > JDK-8254782 - Microbenchmark cleanup. Applies on top of JDK-8254775. > > Pull requests to be opened for all of them, the ones that depend on earlier changes will be based on appropriate threads and won't be applicable initially. > > In this backport the cnahges were reapplied manually because macroAssembler files have old names in 11u and vmIntrinsics.*pp part is vmSymbols.*pp. Hunks contents (intrinsic code etc.) are the same. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/41 From vkempik at openjdk.java.net Wed Feb 23 21:06:57 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 23 Feb 2022 21:06:57 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 [v2] In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 17:18:30 GMT, Vladimir Kempik wrote: >> Please review this backport of JDK-8260518 to jdk11u-dev >> The backport is not applying clean due to the context code difference. >> It's needed mostly to resolve this compilation error on macos-aarch64 >> splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] >> This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) > > Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into JDK-8260518 > - 8260518: Change default -mmacosx-version-min to 10.12 @GoeLin, two weeks later - no objections ( https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012026.html ) can we get approval or as an alternative, I can reduce this fix and not change min macos version for intel64. I would like to make macos-aarch64 port buildable without --disable-warnings-as-errors before rdp2. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From aleonard at openjdk.java.net Wed Feb 23 21:54:18 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Wed, 23 Feb 2022 21:54:18 GMT Subject: [jdk17u-dev] RFR: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup [v4] In-Reply-To: References: Message-ID: On Tue, 22 Feb 2022 15:59:07 GMT, Severin Gehwolf wrote: >> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision: >> >> Restore copyright date change back to the original change date >> >> Signed-off-by: Andrew Leonard > > You don't need the review, but it looks good to me anyway :) Thank you @jerboaa ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/170 From andrew at openjdk.java.net Thu Feb 24 00:43:18 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Thu, 24 Feb 2022 00:43:18 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: On Fri, 24 Dec 2021 17:23:26 GMT, Alexey Pavlyutkin wrote: > This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u > > I'd like to backport JDK-8274471 to jdk17u-dev > > The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS > > The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) > - imported few required packages > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security Part of JDK-8272120 is still being dragged in with the use of `UTF_8` in `OSCP.java`. We can retain that as `"UTF-8"` and avoid adding the import that is not present in the original patch. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From duke at openjdk.java.net Thu Feb 24 00:57:11 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Thu, 24 Feb 2022 00:57:11 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v5] In-Reply-To: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> References: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> Message-ID: On Tue, 15 Feb 2022 21:30:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Replace C-style casts with checked_cast > - Use size_t in generate_disjoint_copy > - Explain disabled MSVC warning C4146 in comment > - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits > - Backport d2812f780e87511736f2d41bc57a69c2a898b583 src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 92: > 90: (uint64_t)Universe::narrow_klass_base()) > 91: && ((uint64_t)Universe::narrow_klass_base() > 92: > (1UL << log2_intptr((uintptr_t)Universe::narrow_klass_range())))); I am getting a build issue when building on MacOS/aarch64 12.2.1 using Xcode 13.1. The cause being the `uintptr_t` cast that was removed from line 92. I resolved the issue by adding the cast back like so: ` > (1UL << log2_intptr(checked_cast(Universe::narrow_klass_range())))));` If all looks well, I will have a colleague with Author status go ahead and create an issue on JBS for me so I can then submit the fix. Here's the build error: $ make images CONF=macosx-aarch64-normal-server-release Building target 'images' in configuration 'macosx-aarch64-normal-server-release' In file included from /Users/ahmed/Documents/dev/repos/jdk11u-dev-upstream/src/hotspot/share/precompiled/precompiled.hpp:111: In file included from /Users/ahmed/Documents/dev/repos/jdk11u-dev-upstream/src/hotspot/share/interpreter/abstractInterpreter.hpp:28: In file included from /Users/ahmed/Documents/dev/repos/jdk11u-dev-upstream/src/hotspot/share/asm/macroAssembler.hpp:31: ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From duke at openjdk.java.net Thu Feb 24 04:32:41 2022 From: duke at openjdk.java.net (Mat Carter) Date: Thu, 24 Feb 2022 04:32:41 GMT Subject: [jdk17u-dev] RFR: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled Message-ID: Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 ------------- Commit messages: - Backport 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/176/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=176&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272996 Stats: 19 lines in 1 file changed: 11 ins; 6 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/176.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/176/head:pull/176 PR: https://git.openjdk.java.net/jdk17u-dev/pull/176 From duke at openjdk.java.net Thu Feb 24 06:28:54 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Thu, 24 Feb 2022 06:28:54 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response [v2] In-Reply-To: References: Message-ID: > This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u > > I'd like to backport JDK-8274471 to jdk17u-dev > > The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS > > The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) > - imported few required packages > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: peer-review: removes the delta related to JDK-8272120 ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/36/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/36/files/ea686fe7..e22864b7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=36&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=36&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/36.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/36/head:pull/36 PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From duke at openjdk.java.net Thu Feb 24 06:28:54 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Thu, 24 Feb 2022 06:28:54 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 00:40:10 GMT, Andrew John Hughes wrote: > Part of JDK-8272120 is still being dragged in with the use of `UTF_8` in `OSCP.java`. We can retain that as `"UTF-8"` and avoid adding the import that is not present in the original patch. Ok, removed. BTW how about jdk11u-dev? As I understand being just an enhancement JDK-8272120 does not have a chance to be bockported to jdk11, but using "UTF-8" is still an overhead. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From bae at openjdk.java.net Thu Feb 24 06:51:16 2022 From: bae at openjdk.java.net (Andrew Brygin) Date: Thu, 24 Feb 2022 06:51:16 GMT Subject: [jdk15u-dev] RFR: 8276141: XPathFactory set/getProperty method [v2] In-Reply-To: References: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> Message-ID: On Tue, 22 Feb 2022 13:47:36 GMT, Yuri Nesterenko wrote: >> get/setProperty added plus test and presumably CSR; difference from the original is in LAstModified of XPathFactoryImpl.java and the test context. > > Yuri Nesterenko has updated the pull request incrementally with one additional commit since the last revision: > > forgotten test The proposed change looks fine. Thanks, Andrew ------------- Marked as reviewed by bae (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/179 From bae at openjdk.java.net Thu Feb 24 06:53:03 2022 From: bae at openjdk.java.net (Andrew Brygin) Date: Thu, 24 Feb 2022 06:53:03 GMT Subject: [jdk13u-dev] RFR: 8276141: XPathFactory set/getProperty method [v2] In-Reply-To: References: Message-ID: <0k6RA4cCt0l3H18C7YZkkjpsLlEmieKJdzh69-VBonY=.9de99a3f-67f0-46ae-9ed4-3f496a87c67d@github.com> On Tue, 22 Feb 2022 13:55:36 GMT, Yuri Nesterenko wrote: >> Difference against the original: no LastModified in XPathFactoryImpl.java in 13/15; the test patch manually applied. > > Yuri Nesterenko has updated the pull request incrementally with one additional commit since the last revision: > > forgotten test The proposed change looks fine. Thanks, Andrew ------------- Marked as reviewed by bae (Reviewer). PR: https://git.openjdk.java.net/jdk13u-dev/pull/329 From yan at azul.com Thu Feb 24 07:11:30 2022 From: yan at azul.com (Yuri Nesterenko) Date: Thu, 24 Feb 2022 10:11:30 +0300 Subject: Result: New JDK Updates Reviewer: Vladimir Kempik Message-ID: <6f23c074-8d0b-a65f-c60d-4fd4cb3ad027@azul.com> Voting [0] for Vladimir Kempik [1] is now closed. Yes: 10 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus [2], this is sufficient to approve the nomination. Thank you! --yan [0] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012037.html [1] https://openjdk.java.net/census#vkempik [2] http://openjdk.java.net/bylaws#three-vote-consensus From tnakamura at openjdk.java.net Thu Feb 24 07:57:42 2022 From: tnakamura at openjdk.java.net (Toshio Nakamura) Date: Thu, 24 Feb 2022 07:57:42 GMT Subject: [jdk17u-dev] RFR: 8278185: Custom JRE cannot find non-ASCII named module inside Message-ID: I'd like to backport this to jdk17 since it fixes jlink issue with non-ASCII named module. Fix is low risk and applies cleanly. tier1 and tier2 tests have no regression with the patch. ------------- Commit messages: - Backport fcd67a5242b7db06e4cb06b574972a463b209b2e Changes: https://git.openjdk.java.net/jdk17u-dev/pull/177/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=177&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278185 Stats: 99 lines in 2 files changed: 98 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/177.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/177/head:pull/177 PR: https://git.openjdk.java.net/jdk17u-dev/pull/177 From mbaesken at openjdk.java.net Thu Feb 24 08:26:10 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 24 Feb 2022 08:26:10 GMT Subject: [jdk11u-dev] Integrated: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 In-Reply-To: References: Message-ID: On Tue, 22 Feb 2022 09:31:17 GMT, Matthias Baesken wrote: > 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 This pull request has now been integrated. Changeset: 6f9d287b Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/6f9d287bbe65b0311764baf536c9046053036ff2 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 Backport-of: d3749de47832c6de4bcee9cf64a0b698e796b2f2 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/836 From aph at openjdk.java.net Thu Feb 24 09:26:15 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Thu, 24 Feb 2022 09:26:15 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v5] In-Reply-To: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> References: <-sMIHIO83_LOeu2Al9a08a_YVfe9JyESyAB-GU-Id3E=.7e15ec0a-d5ca-4c26-8490-cab91dcc1953@github.com> Message-ID: On Tue, 15 Feb 2022 21:30:37 GMT, Reka Kovacs wrote: >> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: >> >> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. >> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. >> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). >> - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. >> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Replace C-style casts with checked_cast > - Use size_t in generate_disjoint_copy > - Explain disabled MSVC warning C4146 in comment > - Fix MSVC warning C4334: result of 32-bit shift implicitly converted to 64 bits > - Backport d2812f780e87511736f2d41bc57a69c2a898b583 On 2/24/22 00:50, Ahmed Muhsin wrote: > I resolved the issue by adding the cast back like so: > ` > (1UL << log2_intptr(checked_cast(Universe::narrow_klass_range())))));` > > If all looks well, I will have a colleague with Author status go ahead and create an issue on JBS for me so I can then submit the fix. Huh. It's not pretty, but it's probably the best we can do for 11. The log2 functions have all been reworked in later JDKs. The checked_cast perhaps isn't necessary because this isn't a narrowing cast, but it doesn't hurt. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From goetz at openjdk.java.net Thu Feb 24 10:17:18 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Feb 2022 10:17:18 GMT Subject: [jdk17u-dev] RFR: 8278185: Custom JRE cannot find non-ASCII named module inside In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 07:46:35 GMT, Toshio Nakamura wrote: > I'd like to backport this to jdk17 since it fixes jlink issue with non-ASCII named module. Fix is low risk and applies cleanly. tier1 and tier2 tests have no regression with the patch. @toshiona, Please enable github actions for this repo. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/177 From goetz at openjdk.java.net Thu Feb 24 10:58:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Feb 2022 10:58:02 GMT Subject: [jdk11u-dev] RFR: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted In-Reply-To: References: Message-ID: <4vubYv7IXbbQcQ0OToACjz4R6-WdczKR7d1lTP3_HFM=.c3bbfade-8016-4542-a7df-7a203b6d2585@github.com> On Wed, 9 Feb 2022 15:53:54 GMT, Zhengyu Gu wrote: > A clean, test only backport for parity with Oracle 11.0.16. > > The test passed on Windows 10. @zhengyu123 you might want to integrate this before March 1st? Similar the 17u backport. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/815 From goetz at openjdk.java.net Thu Feb 24 11:08:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Feb 2022 11:08:37 GMT Subject: [jdk17u-dev] RFR: 8272866: java.util.random package summary contains incorrect mixing function in table Message-ID: <9gifJvx6Xd5hva2HjA206vUAVwBlQWq96DrS8MpFhdA=.03fb2022-3c48-42ad-b5e3-8dc064a596f7@github.com> Backporting as it was dedicated for backport to earlier releases but then slipped through. ------------- Commit messages: - Backport e66c8afb59b57c4546656efa97f723f084964330 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/178/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=178&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272866 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/178.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/178/head:pull/178 PR: https://git.openjdk.java.net/jdk17u-dev/pull/178 From mbaesken at openjdk.java.net Thu Feb 24 11:21:06 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 24 Feb 2022 11:21:06 GMT Subject: [jdk11u-dev] Integrated: 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 13:47:53 GMT, Matthias Baesken wrote: > 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols This pull request has now been integrated. Changeset: 16cbd329 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/16cbd3290deacb93c86201e99f95f6a021b5e469 Stats: 27 lines in 5 files changed: 13 ins; 2 del; 12 mod 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols Backport-of: d12fdfa3b75a72c7f78a625f3774a35ac147960e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/838 From duke at openjdk.java.net Thu Feb 24 12:23:09 2022 From: duke at openjdk.java.net (zzambers) Date: Thu, 24 Feb 2022 12:23:09 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: <50_TUzAtlOOEAqUkw7unl4HnU8YmJ0j4JLYL_rSAUWM=.7298a775-b0cf-4756-860e-49feb44980f9@github.com> References: <50_TUzAtlOOEAqUkw7unl4HnU8YmJ0j4JLYL_rSAUWM=.7298a775-b0cf-4756-860e-49feb44980f9@github.com> Message-ID: On Wed, 23 Feb 2022 19:19:21 GMT, Severin Gehwolf wrote: >> Interestingly for some reason there are some failures in git workflow tests (but nothing related to this change). > > @zzambers Please only integrate once you've got backport approval from an 11u maintainer. Please let me know if you need help with process work. See: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u for some process documentation. @jerboaa sorry, I got confused about the process. Can I take it (integration) back? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From aleksei.voitylov at bell-sw.com Thu Feb 24 12:56:43 2022 From: aleksei.voitylov at bell-sw.com (Aleksei Voitylov) Date: Thu, 24 Feb 2022 15:56:43 +0300 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: References: Message-ID: <0d6d4923-bd02-82e2-9d7c-e6dee09b66e6@bell-sw.com> Hi Thomas, see inline: On 23/02/2022 21:18, Thomas St?fe wrote: > Hi Alexei, > > I think this makes sense and is probably less risky than backporting > JEP 388 and JEP 391. Thanks for doing the work, this looks well > prepared for review already. > > I have some questions, which had not been immediately clear from the > mail. I may be just slow. > > - Did you have to make 11u specific changes to the individual > backports? If yes, what and why? Speaking of product code changes, all changes that had to be done for 11u are cosmetic, it's mostly lines layout that had to be taken care of. 8252248 is slightly different because of Solaris support in 11u, but these changes are under #ifdefs in libnio/ch/NativeThread.c. > - are there changes to the glibc variant in 11u, and if yes, why? In > other words, will anything change for the existing platforms? Because > theoretically, nothing should, right? I see the change to isnan, is > that motivated to just applying the upstream patch without change, or > was there a deeper reason? Yes, there are changes to glibc variant in 11u which are limited to 100 lines of code. Most of the work done for Alpine Linux support was actually cleanup to linux code. My take with the 11u backport is to keep it simple and in line with what was contributed to 16 to simplify maintenance. Let me break down the changes en large so you can also do the risk assessment - 8245938 removes dead code (also dead in 11u) - 8252248 glibc-private? __SIGRTMAX is replaced with public standard SIGRTMAX - 8252250 isnan change analysis can be found in https://bugs.openjdk.java.net/browse/JDK-8178689 comments - 8247589 First, this change uses libnuma2 if available with fallback to libnuma if libnuma2 is not found. Second, mmap and mprotect are called at VM initialization to enable JDK to work on systems with PaX grsecurity. No new API is used in terms of libc/glibc compatibility level. Both changes are not specific to Alpine (aside from the fact that Alpine enables it by default). Thanks, -Aleksei > > Thank you! > > Thomas > > > On Thu, Feb 17, 2022 at 3:12 PM Aleksei Voitylov > > > wrote: > > Hi, > > Following recent backports of JEP 388 (Windows/AArch64 Port) and > JEP 391 > (macOS/AArch64 Port), I?d like to propose a backport of JEP 386 > (Alpine > Linux Port) [1] to OpenJDK 11u. Support for this port was baked in the > Portola project and integrated into OpenJDK 16. > > Motivation for 11u backport: the importance of this platform is > explained by wide adoption of Alpine Linux in container environments > [2]. Several OpenJDK vendors (Liberica, Corretto, Zulu) include > patches > that enable Alpine/MUSL for 11u and 8u for quite some time, > without any > issues. Others (MS) have recently added it. In our case the user > demand > for Alpine/musl support for both 11u and 8u was at least as strong as > Mac/AArch64 and Windows/AArch64, I?d also like to hear if other > OpenJDK > vendors share our view of the importance of this platform in 11u. > > The set of JBS issues required to be backported for Alpine/MUSL > support > in 11u is: > > JDK-8217340 Compilation failed: tools/launcher/Test7029048.java > -??? Test-only fix > JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java > -??? Test-only fix > JDK-8245938 Remove unused print_stack(void) method from XToolkit.c > -??? Code fix, removal of dead code, applies cleanly > JDK-8252248 __SIGRTMAX is not declared in musl libc > -??? Code fix > JDK-8252250 isnanf is obsolete > -??? Code fix, substitutes isnanf with isnan which was proven to be ok > at least since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM > version ? see the discussion in JDK-8178689 for further details. > JDK-8247589 Implementation of Alpine Linux/x64 Port > -??? The actual build and code changes that tidy up code for MUSL > JDK-8247591 Document Alpine Linux build steps in OpenJDK build guide > -??? Docs only fix > > All patches combined: +480 lines, -146 lines. > All source code changes: +133 lines, -43 lines. > > For risk assessment and preliminary examination of the 11u > maintainers, > the full patchset can be observed in [3], separate 11u backports > can be > found in [4]. I plan to submit the actual PRs for individual backports > one by one unless I hear reasonable concerns from 11u maintainers > on the > proposed changes. > > The patchset passes full JCK+jtreg set without any regressions to > other > platforms (Windows, Linux, Mac, Solaris), including non-Intel where > applicable. During integration of JEP 386 SAP kindly verified that > these > changes do not break AIX/XLC. > > On the maintenance side, BellSoft will be happy to support this > platform > in 11u. But I?ll equally happily share the burden with other OpenJDK > vendors that currently support Alpine/MUSL. > > Thanks, > -Aleksei > > [1] https://openjdk.java.net/jeps/386 > [2] https://hub.docker.com/_/alpine > [3] > https://github.com/voitylov/jdk11u-dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da398797738fbfd1eaf02e1f887e306 > [4] > 8217340: > https://github.com/voitylov/jdk11u-dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a > 8247592: > https://github.com/voitylov/jdk11u-dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd > 8245938: > https://github.com/voitylov/jdk11u-dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a > 8252248: > https://github.com/voitylov/jdk11u-dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 > 8252250: > https://github.com/voitylov/jdk11u-dev/commit/41b6b490fe60c640c90d9e594557215e669955cc > 8247589: > https://github.com/voitylov/jdk11u-dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 > 8247591: > https://github.com/voitylov/jdk11u-dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 > > From aleksei.voitylov at bell-sw.com Thu Feb 24 13:07:29 2022 From: aleksei.voitylov at bell-sw.com (Aleksei Voitylov) Date: Thu, 24 Feb 2022 16:07:29 +0300 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: References: Message-ID: <6d360fcf-ac07-3a37-b47e-849d62a9d7fc@bell-sw.com> Thank you Christoph, Volker and Severin for your assessments! On 18/02/2022 13:20, Volker Simonis wrote: > Hi Aleksei, > > Thanks a lot for proposing this downport! > > I have no additional arguments to add in favor for this downport > except that the Amazon Corretto team will be happy to help with the > integration and maintenance. > > Best regards, > Volker > > On Fri, Feb 18, 2022 at 9:52 AM Langer, Christoph > wrote: >> Hi Aleksei, >> >> speaking for SAP, I would very much welcome this backport. We also see a high demand for Alpine builds and are looking into providing these in the near future. >> >> And, speaking as a maintainer my personal tendency would be to accept this port, in line with your argumentation below. The demand is very high and lots of downstream vendors already added patches to support it. It shares the same arguments as were valid for JEP 388 (Windows/AArch64 Port) and JEP 391 (macOS/AArch64 Port). >> >> Best regards >> Christoph >> >>> -----Original Message----- >>> From: jdk-updates-dev On >>> Behalf Of Aleksei Voitylov >>> Sent: Donnerstag, 17. Februar 2022 15:12 >>> To: jdk-updates-dev at openjdk.java.net >>> Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u >>> >>> Hi, >>> >>> Following recent backports of JEP 388 (Windows/AArch64 Port) and JEP 391 >>> (macOS/AArch64 Port), I?d like to propose a backport of JEP 386 (Alpine Linux >>> Port) [1] to OpenJDK 11u. Support for this port was baked in the Portola >>> project and integrated into OpenJDK 16. >>> >>> Motivation for 11u backport: the importance of this platform is explained by >>> wide adoption of Alpine Linux in container environments [2]. Several >>> OpenJDK vendors (Liberica, Corretto, Zulu) include patches that enable >>> Alpine/MUSL for 11u and 8u for quite some time, without any issues. Others >>> (MS) have recently added it. In our case the user demand for Alpine/musl >>> support for both 11u and 8u was at least as strong as >>> Mac/AArch64 and Windows/AArch64, I?d also like to hear if other OpenJDK >>> vendors share our view of the importance of this platform in 11u. >>> >>> The set of JBS issues required to be backported for Alpine/MUSL support in >>> 11u is: >>> >>> JDK-8217340 Compilation failed: tools/launcher/Test7029048.java >>> - Test-only fix >>> JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java >>> - Test-only fix >>> JDK-8245938 Remove unused print_stack(void) method from XToolkit.c >>> - Code fix, removal of dead code, applies cleanly >>> JDK-8252248 __SIGRTMAX is not declared in musl libc >>> - Code fix >>> JDK-8252250 isnanf is obsolete >>> - Code fix, substitutes isnanf with isnan which was proven to be ok at least >>> since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM version ? see the >>> discussion in JDK-8178689 for further details. >>> JDK-8247589 Implementation of Alpine Linux/x64 Port >>> - The actual build and code changes that tidy up code for MUSL >>> JDK-8247591 Document Alpine Linux build steps in OpenJDK build guide >>> - Docs only fix >>> >>> All patches combined: +480 lines, -146 lines. >>> All source code changes: +133 lines, -43 lines. >>> >>> For risk assessment and preliminary examination of the 11u maintainers, the >>> full patchset can be observed in [3], separate 11u backports can be found in >>> [4]. I plan to submit the actual PRs for individual backports one by one unless >>> I hear reasonable concerns from 11u maintainers on the proposed changes. >>> >>> The patchset passes full JCK+jtreg set without any regressions to other >>> platforms (Windows, Linux, Mac, Solaris), including non-Intel where >>> applicable. During integration of JEP 386 SAP kindly verified that these >>> changes do not break AIX/XLC. >>> >>> On the maintenance side, BellSoft will be happy to support this platform in >>> 11u. But I?ll equally happily share the burden with other OpenJDK vendors >>> that currently support Alpine/MUSL. >>> >>> Thanks, >>> -Aleksei >>> >>> [1] https://openjdk.java.net/jeps/386 >>> [2] >>> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub. >>> docker.com%2F_%2Falpine&data=04%7C01%7Cchristoph.langer%40sap >>> .com%7C1d07ffdbad094db8ffff08d9f21fa3ee%7C42f7676cf455423c82f6dc2d9 >>> 9791af7%7C0%7C0%7C637807039998760193%7CUnknown%7CTWFpbGZsb3d >>> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% >>> 3D%7C3000&sdata=KlMvmtK3GrXXvPUjW2Qh5sy%2BqUqGKBTKJQ3Ny >>> 6jRGCk%3D&reserved=0 >>> [3] >>> https://github.com/voitylov/jdk11u- >>> dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da3 >>> 98797738fbfd1eaf02e1f887e306 >>> [4] >>> 8217340: >>> https://github.com/voitylov/jdk11u- >>> dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a >>> 8247592: >>> https://github.com/voitylov/jdk11u- >>> dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd >>> 8245938: >>> https://github.com/voitylov/jdk11u- >>> dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a >>> 8252248: >>> https://github.com/voitylov/jdk11u- >>> dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 >>> 8252250: >>> https://github.com/voitylov/jdk11u- >>> dev/commit/41b6b490fe60c640c90d9e594557215e669955cc >>> 8247589: >>> https://github.com/voitylov/jdk11u- >>> dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 >>> 8247591: >>> https://github.com/voitylov/jdk11u- >>> dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 >>> From thomas.stuefe at gmail.com Thu Feb 24 13:15:24 2022 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Feb 2022 14:15:24 +0100 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: <0d6d4923-bd02-82e2-9d7c-e6dee09b66e6@bell-sw.com> References: <0d6d4923-bd02-82e2-9d7c-e6dee09b66e6@bell-sw.com> Message-ID: Hi Alexei, On Thu, Feb 24, 2022 at 1:56 PM Aleksei Voitylov < aleksei.voitylov at bell-sw.com> wrote: > Hi Thomas, > > see inline: > On 23/02/2022 21:18, Thomas St?fe wrote: > > Hi Alexei, > > I think this makes sense and is probably less risky than backporting JEP > 388 and JEP 391. Thanks for doing the work, this looks well prepared for > review already. > > I have some questions, which had not been immediately clear from the mail. > I may be just slow. > > - Did you have to make 11u specific changes to the individual backports? > If yes, what and why? > > Speaking of product code changes, all changes that had to be done for 11u > are cosmetic, it's mostly lines layout that had to be taken care of. > 8252248 is slightly different because of Solaris support in 11u, but these > changes are under #ifdefs in libnio/ch/NativeThread.c. > > - are there changes to the glibc variant in 11u, and if yes, why? In other > words, will anything change for the existing platforms? Because > theoretically, nothing should, right? I see the change to isnan, is that > motivated to just applying the upstream patch without change, or was there > a deeper reason? > > Yes, there are changes to glibc variant in 11u which are limited to 100 > lines of code. Most of the work done for Alpine Linux support was actually > cleanup to linux code. My take with the 11u backport is to keep it simple > and in line with what was contributed to 16 to simplify maintenance. Let me > break down the changes en large so you can also do the risk assessment > > - 8245938 removes dead code (also dead in 11u) > - 8252248 glibc-private __SIGRTMAX is replaced with public standard > SIGRTMAX > - 8252250 isnan change analysis can be found in > https://bugs.openjdk.java.net/browse/JDK-8178689 comments > - 8247589 First, this change uses libnuma2 if available with fallback to > libnuma if libnuma2 is not found. Second, mmap and mprotect are called at > VM initialization to enable JDK to work on systems with PaX grsecurity. No > new API is used in terms of libc/glibc compatibility level. Both changes > are not specific to Alpine (aside from the fact that Alpine enables it by > default). > Seems all reasonable. Thanks for breaking it down for me. I agree that keeping the code aligned with mainline is worth these minor behavioral changes. Thanks, Thomas > Thanks, > > -Aleksei > > > Thank you! > > Thomas > > > On Thu, Feb 17, 2022 at 3:12 PM Aleksei Voitylov < > aleksei.voitylov at bell-sw.com> wrote: > >> Hi, >> >> Following recent backports of JEP 388 (Windows/AArch64 Port) and JEP 391 >> (macOS/AArch64 Port), I?d like to propose a backport of JEP 386 (Alpine >> Linux Port) [1] to OpenJDK 11u. Support for this port was baked in the >> Portola project and integrated into OpenJDK 16. >> >> Motivation for 11u backport: the importance of this platform is >> explained by wide adoption of Alpine Linux in container environments >> [2]. Several OpenJDK vendors (Liberica, Corretto, Zulu) include patches >> that enable Alpine/MUSL for 11u and 8u for quite some time, without any >> issues. Others (MS) have recently added it. In our case the user demand >> for Alpine/musl support for both 11u and 8u was at least as strong as >> Mac/AArch64 and Windows/AArch64, I?d also like to hear if other OpenJDK >> vendors share our view of the importance of this platform in 11u. >> >> The set of JBS issues required to be backported for Alpine/MUSL support >> in 11u is: >> >> JDK-8217340 Compilation failed: tools/launcher/Test7029048.java >> - Test-only fix >> JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java >> - Test-only fix >> JDK-8245938 Remove unused print_stack(void) method from XToolkit.c >> - Code fix, removal of dead code, applies cleanly >> JDK-8252248 __SIGRTMAX is not declared in musl libc >> - Code fix >> JDK-8252250 isnanf is obsolete >> - Code fix, substitutes isnanf with isnan which was proven to be ok >> at least since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM >> version ? see the discussion in JDK-8178689 for further details. >> JDK-8247589 Implementation of Alpine Linux/x64 Port >> - The actual build and code changes that tidy up code for MUSL >> JDK-8247591 Document Alpine Linux build steps in OpenJDK build guide >> - Docs only fix >> >> All patches combined: +480 lines, -146 lines. >> All source code changes: +133 lines, -43 lines. >> >> For risk assessment and preliminary examination of the 11u maintainers, >> the full patchset can be observed in [3], separate 11u backports can be >> found in [4]. I plan to submit the actual PRs for individual backports >> one by one unless I hear reasonable concerns from 11u maintainers on the >> proposed changes. >> >> The patchset passes full JCK+jtreg set without any regressions to other >> platforms (Windows, Linux, Mac, Solaris), including non-Intel where >> applicable. During integration of JEP 386 SAP kindly verified that these >> changes do not break AIX/XLC. >> >> On the maintenance side, BellSoft will be happy to support this platform >> in 11u. But I?ll equally happily share the burden with other OpenJDK >> vendors that currently support Alpine/MUSL. >> >> Thanks, >> -Aleksei >> >> [1] https://openjdk.java.net/jeps/386 >> [2] https://hub.docker.com/_/alpine >> [3] >> >> https://github.com/voitylov/jdk11u-dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da398797738fbfd1eaf02e1f887e306 >> [4] >> 8217340: >> >> https://github.com/voitylov/jdk11u-dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a >> 8247592: >> >> https://github.com/voitylov/jdk11u-dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd >> 8245938: >> >> https://github.com/voitylov/jdk11u-dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a >> 8252248: >> >> https://github.com/voitylov/jdk11u-dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 >> 8252250: >> >> https://github.com/voitylov/jdk11u-dev/commit/41b6b490fe60c640c90d9e594557215e669955cc >> 8247589: >> >> https://github.com/voitylov/jdk11u-dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 >> 8247591: >> >> https://github.com/voitylov/jdk11u-dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 >> >> >> From duke at openjdk.java.net Thu Feb 24 13:22:15 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Thu, 24 Feb 2022 13:22:15 GMT Subject: [jdk15u-dev] Integrated: 8261534: Test sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java fails on platforms where no nsslib artifacts are defined In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 16:07:17 GMT, Evgeny Astigeevich wrote: > [JDK-8259319](https://bugs.openjdk.java.net/browse/JDK-8259319) was backported to 15u. As we see the test failing, we need to backport this testfix to 15u as well. Patch applies cleanly. No risk, testfix only. > Tested: > - `make run-test TEST=sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java`: Passed This pull request has now been integrated. Changeset: 1a1dec4b Author: Evgeny Astigeevich Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/1a1dec4b4e991fe07f8910e1a8e918a6940928cc Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8261534: Test sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java fails on platforms where no nsslib artifacts are defined Backport-of: dc46aa85c6e16cb904d1c40a4577b5e48c56a3d4 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/182 From sgehwolf at openjdk.java.net Thu Feb 24 13:23:12 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 24 Feb 2022 13:23:12 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: <50_TUzAtlOOEAqUkw7unl4HnU8YmJ0j4JLYL_rSAUWM=.7298a775-b0cf-4756-860e-49feb44980f9@github.com> References: <50_TUzAtlOOEAqUkw7unl4HnU8YmJ0j4JLYL_rSAUWM=.7298a775-b0cf-4756-860e-49feb44980f9@github.com> Message-ID: On Wed, 23 Feb 2022 19:19:21 GMT, Severin Gehwolf wrote: >> Interestingly for some reason there are some failures in git workflow tests (but nothing related to this change). > > @zzambers Please only integrate once you've got backport approval from an 11u maintainer. Please let me know if you need help with process work. See: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u for some process documentation. > @jerboaa sorry, I got confused about the process. Can I take it (integration) back? No worries. You cannot take it back, but since you need a sponsor for integration it's all fine. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From tnakamura at openjdk.java.net Thu Feb 24 13:25:08 2022 From: tnakamura at openjdk.java.net (Toshio Nakamura) Date: Thu, 24 Feb 2022 13:25:08 GMT Subject: [jdk17u-dev] RFR: 8278185: Custom JRE cannot find non-ASCII named module inside In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 10:14:21 GMT, Goetz Lindenmaier wrote: >> I'd like to backport this to jdk17 since it fixes jlink issue with non-ASCII named module. Fix is low risk and applies cleanly. tier1 and tier2 tests have no regression with the patch. > > @toshiona, Please enable github actions for this repo. @GoeLin Thank you for teaching that. Enabled it. I hope my setting is correct. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/177 From aleksei.voitylov at bell-sw.com Thu Feb 24 13:49:34 2022 From: aleksei.voitylov at bell-sw.com (Aleksei Voitylov) Date: Thu, 24 Feb 2022 16:49:34 +0300 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: References: <0d6d4923-bd02-82e2-9d7c-e6dee09b66e6@bell-sw.com> Message-ID: Thank you Thomas! By now we've heard from most of the parties, and all the concerns are addressed. Let me give another two working days for anyone to ask more questions and raise concerns, at which point I'm going to start proposing backports using the regular 11u process. -Aleksei On 24/02/2022 16:15, Thomas St?fe wrote: > Hi Alexei, > > On Thu, Feb 24, 2022 at 1:56 PM Aleksei Voitylov > > > wrote: > > Hi Thomas, > > see inline: > > On 23/02/2022 21:18, Thomas St?fe wrote: >> Hi Alexei, >> >> I think this makes sense and is probably less risky than >> backporting JEP 388 and JEP 391. Thanks for doing the work, this >> looks well prepared for review already. >> >> I have some questions, which had not been immediately clear from >> the mail. I may be just slow. >> >> - Did you have to make 11u specific changes to the individual >> backports? If yes, what and why? > Speaking of product code changes, all changes that had to be done > for 11u are cosmetic, it's mostly lines layout that had to be > taken care of. 8252248 is slightly different because of Solaris > support in 11u, but these changes are under #ifdefs in > libnio/ch/NativeThread.c. >> - are there changes to the glibc variant in 11u, and if yes, why? >> In other words, will anything change for the existing platforms? >> Because theoretically, nothing should, right? I see the change to >> isnan, is that motivated to just applying the upstream patch >> without change, or was there a deeper reason? > > Yes, there are changes to glibc variant in 11u which are limited > to 100 lines of code. Most of the work done for Alpine Linux > support was actually cleanup to linux code. My take with the 11u > backport is to keep it simple and in line with what was > contributed to 16 to simplify maintenance. Let me break down the > changes en large so you can also do the risk assessment > > - 8245938 removes dead code (also dead in 11u) > - 8252248 glibc-private? __SIGRTMAX is replaced with public > standard SIGRTMAX > - 8252250 isnan change analysis can be found in > https://bugs.openjdk.java.net/browse/JDK-8178689 comments > - 8247589 First, this change uses libnuma2 if available with > fallback to libnuma if libnuma2 is not found. Second, mmap and > mprotect are called at VM initialization to enable JDK to work on > systems with PaX grsecurity. No new API is used in terms of > libc/glibc compatibility level. Both changes are not specific to > Alpine (aside from the fact that Alpine enables it by default). > > > Seems all reasonable. Thanks for breaking it down for me.? > > I agree that keeping the code aligned with mainline is worth these > minor behavioral changes. > > Thanks, Thomas > > Thanks, > > -Aleksei > >> >> Thank you! >> >> Thomas >> >> >> On Thu, Feb 17, 2022 at 3:12 PM Aleksei Voitylov >> > > wrote: >> >> Hi, >> >> Following recent backports of JEP 388 (Windows/AArch64 Port) >> and JEP 391 >> (macOS/AArch64 Port), I?d like to propose a backport of JEP >> 386 (Alpine >> Linux Port) [1] to OpenJDK 11u. Support for this port was >> baked in the >> Portola project and integrated into OpenJDK 16. >> >> Motivation for 11u backport: the importance of this platform is >> explained by wide adoption of Alpine Linux in container >> environments >> [2]. Several OpenJDK vendors (Liberica, Corretto, Zulu) >> include patches >> that enable Alpine/MUSL for 11u and 8u for quite some time, >> without any >> issues. Others (MS) have recently added it. In our case the >> user demand >> for Alpine/musl support for both 11u and 8u was at least as >> strong as >> Mac/AArch64 and Windows/AArch64, I?d also like to hear if >> other OpenJDK >> vendors share our view of the importance of this platform in 11u. >> >> The set of JBS issues required to be backported for >> Alpine/MUSL support >> in 11u is: >> >> JDK-8217340 Compilation failed: tools/launcher/Test7029048.java >> -??? Test-only fix >> JDK-8247592 refactor test/jdk/tools/launcher/Test7029048.java >> -??? Test-only fix >> JDK-8245938 Remove unused print_stack(void) method from >> XToolkit.c >> -??? Code fix, removal of dead code, applies cleanly >> JDK-8252248 __SIGRTMAX is not declared in musl libc >> -??? Code fix >> JDK-8252250 isnanf is obsolete >> -??? Code fix, substitutes isnanf with isnan which was proven >> to be ok >> at least since GLIBC 2.8/GCC 4.6 on Linux and any reasonable LLVM >> version ? see the discussion in JDK-8178689 for further details. >> JDK-8247589 Implementation of Alpine Linux/x64 Port >> -??? The actual build and code changes that tidy up code for MUSL >> JDK-8247591 Document Alpine Linux build steps in OpenJDK >> build guide >> -??? Docs only fix >> >> All patches combined: +480 lines, -146 lines. >> All source code changes: +133 lines, -43 lines. >> >> For risk assessment and preliminary examination of the 11u >> maintainers, >> the full patchset can be observed in [3], separate 11u >> backports can be >> found in [4]. I plan to submit the actual PRs for individual >> backports >> one by one unless I hear reasonable concerns from 11u >> maintainers on the >> proposed changes. >> >> The patchset passes full JCK+jtreg set without any >> regressions to other >> platforms (Windows, Linux, Mac, Solaris), including non-Intel >> where >> applicable. During integration of JEP 386 SAP kindly verified >> that these >> changes do not break AIX/XLC. >> >> On the maintenance side, BellSoft will be happy to support >> this platform >> in 11u. But I?ll equally happily share the burden with other >> OpenJDK >> vendors that currently support Alpine/MUSL. >> >> Thanks, >> -Aleksei >> >> [1] https://openjdk.java.net/jeps/386 >> [2] https://hub.docker.com/_/alpine >> [3] >> https://github.com/voitylov/jdk11u-dev/compare/d6bf0d1e7dac4f4820e5c16ca14a162717b5818d..920d286d8da398797738fbfd1eaf02e1f887e306 >> [4] >> 8217340: >> https://github.com/voitylov/jdk11u-dev/commit/01542ba865c518c2b5d827d6c0b95488129b658a >> 8247592: >> https://github.com/voitylov/jdk11u-dev/commit/48a1e49807cc189cd23c569f4b28f20282010ffd >> 8245938: >> https://github.com/voitylov/jdk11u-dev/commit/3e41399c3471c6664302e6487d8003ecaff5e23a >> 8252248: >> https://github.com/voitylov/jdk11u-dev/commit/bd2a506a2f44e7e2c9a0007f256e5c2288cfbe34 >> 8252250: >> https://github.com/voitylov/jdk11u-dev/commit/41b6b490fe60c640c90d9e594557215e669955cc >> 8247589: >> https://github.com/voitylov/jdk11u-dev/commit/b0562ab5e2aa23f27803832f3854f0538f51b891 >> 8247591: >> https://github.com/voitylov/jdk11u-dev/commit/920d286d8da398797738fbfd1eaf02e1f887e306 >> >> From duke at openjdk.java.net Thu Feb 24 14:06:40 2022 From: duke at openjdk.java.net (zzambers) Date: Thu, 24 Feb 2022 14:06:40 GMT Subject: [jdk17u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 15:47:13 GMT, zzambers wrote: > Tested locally test/jdk/com/sun/jdi tests passed for me. sorry, integrate command was a mistake as it needs approval for jdk17u (I got confused about the process) ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/175 From aph-open at littlepinkcloud.com Thu Feb 24 14:35:22 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Thu, 24 Feb 2022 14:35:22 +0000 Subject: [RFC] Proposal to backport JEP 386 (Alpine Linux Port) to 11u In-Reply-To: References: <0d6d4923-bd02-82e2-9d7c-e6dee09b66e6@bell-sw.com> Message-ID: On 2/24/22 13:49, Aleksei Voitylov wrote: > By now we've heard from most of the parties, and all the concerns are > addressed. Let me give another two working days for anyone to ask more > questions and raise concerns, at which point I'm going to start > proposing backports using the regular 11u process. It all looks reasonable enough. We already have a general permission in the policy to adapt 11u to new computing environments, and given that people see a high demand for Alpine and the changes are not very many, it should be fine. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From phh at openjdk.java.net Thu Feb 24 15:09:03 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 24 Feb 2022 15:09:03 GMT Subject: [jdk11u-dev] RFR: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32 In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 17:05:59 GMT, Andrew John Hughes wrote: > The `slowdebug` build in 11u is broken in the same way as trunk was before this fix. We recently had to build 11u on x86_32 using Zero, due to issues with the new GCC 12 release, and the slowdebug build failed with this broken assert. Removing it allowed the build to complete. > > Backport is clean, but couldn't be automated as later JDK versions have the file in a `zero` subdirectory. > > Additional checks: > - [x] slowdebug build on x86_32 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/839 From phh at openjdk.java.net Thu Feb 24 15:25:12 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 24 Feb 2022 15:25:12 GMT Subject: [jdk15u-dev] RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 15:43:41 GMT, Evgeny Astigeevich wrote: > A backport of a configurable implementation of _onSpinWait() intrinsic to achieve parity with x86 which has it implemented. > The risk of changes is low. By default it is off. > Tested for fastdebug and release builds: > > - `gtest`: Passed > - `tier1`...`tier3`: Passed except [JDK-8261534](https://bugs.openjdk.java.net/browse/JDK-8261534) and [JDK-8277488](https://bugs.openjdk.java.net/browse/JDK-8277488) > - `hotspot/jtreg/compiler/onSpinWait`: Passed > > Applying the patch had issues to find proper positions. No code changes are needed after repositioning. > Changes to `globals_aarch64.hpp` needed the new added options definitions to be converted from the new format to the old one. `vm.flagless` was removed from the new tests. > Changes to `vm_version_aarch64.cpp`, instantiation of `SpinWait`, use C++11 syntax. They needed to be changed to C++03 syntax. Lgtm, except: I don't see any C++03 vs C++11 differences in vm_version_aarch64.cpp. What am I missing? Do [JDK-8261534](https://bugs.openjdk.java.net/browse/JDK-8261534) and [JDK-8277488](https://bugs.openjdk.java.net/browse/JDK-8277488) also fail without this patch? ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/181 From duke at openjdk.java.net Thu Feb 24 15:34:11 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Thu, 24 Feb 2022 15:34:11 GMT Subject: [jdk15u-dev] RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 15:21:27 GMT, Paul Hohensee wrote: > Lgtm, except: > > I don't see any C++03 vs C++11 differences in vm_version_aarch64.cpp. What am I missing? C++11 `return SpinWait{}` vs C++03 `return SpinWait();` > > Do [JDK-8261534](https://bugs.openjdk.java.net/browse/JDK-8261534) and [JDK-8277488](https://bugs.openjdk.java.net/browse/JDK-8277488) also fail without this patch? Yes, they do. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/181 From phh at openjdk.java.net Thu Feb 24 15:43:05 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 24 Feb 2022 15:43:05 GMT Subject: [jdk15u-dev] RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 15:43:41 GMT, Evgeny Astigeevich wrote: > A backport of a configurable implementation of _onSpinWait() intrinsic to achieve parity with x86 which has it implemented. > The risk of changes is low. By default it is off. > Tested for fastdebug and release builds: > > - `gtest`: Passed > - `tier1`...`tier3`: Passed except [JDK-8261534](https://bugs.openjdk.java.net/browse/JDK-8261534) and [JDK-8277488](https://bugs.openjdk.java.net/browse/JDK-8277488) > - `hotspot/jtreg/compiler/onSpinWait`: Passed > > Applying the patch had issues to find proper positions. No code changes are needed after repositioning. > Changes to `globals_aarch64.hpp` needed the new added options definitions to be converted from the new format to the old one. `vm.flagless` was removed from the new tests. > Changes to `vm_version_aarch64.cpp`, instantiation of `SpinWait`, use C++11 syntax. They needed to be changed to C++03 syntax. I skipped right over the {} vs ()! Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/181 From zgu at openjdk.java.net Thu Feb 24 21:25:42 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 24 Feb 2022 21:25:42 GMT Subject: [jdk11u-dev] RFR: 8230305: Cgroups v2: Container awareness Message-ID: I would like backport cgroups v2 support to openjdk11u. The original patch does not apply cleanly, conflicts are resolved manually. Test: - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS ------------- Commit messages: - Backport d462a6b5c9bd3dae5257cca42ea38c19cb742e3c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/840/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=840&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8230305 Stats: 2003 lines in 10 files changed: 1389 ins; 576 del; 38 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/840.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/840/head:pull/840 PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 From duke at openjdk.java.net Thu Feb 24 23:41:06 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Thu, 24 Feb 2022 23:41:06 GMT Subject: [jdk11u-dev] RFR: 8214004: Missing space between compiler thread name and task info in hs_err In-Reply-To: References: Message-ID: On Fri, 18 Feb 2022 05:18:04 GMT, Kimura Yukihiro wrote: > I'd like to backport JDK-8214004. > The original patch does not applies cleanly because JDK-8163511 was applied first in 11u. > > The change only reflects JDK-8163511 on the following line, and there is no risk. > I tested tier1 with rhel and windows x86_64, and no errors found. Thank you for your review, phohensee. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/831 From duke at openjdk.java.net Thu Feb 24 23:52:09 2022 From: duke at openjdk.java.net (Kimura Yukihiro) Date: Thu, 24 Feb 2022 23:52:09 GMT Subject: [jdk11u-dev] Integrated: 8214004: Missing space between compiler thread name and task info in hs_err In-Reply-To: References: Message-ID: <-lQW3maCIq2wN7lWlXtrwcYq03lY4gQSoAIz2_C2Xms=.710f4342-ca17-4603-8a2f-255ae0327265@github.com> On Fri, 18 Feb 2022 05:18:04 GMT, Kimura Yukihiro wrote: > I'd like to backport JDK-8214004. > The original patch does not applies cleanly because JDK-8163511 was applied first in 11u. > > The change only reflects JDK-8163511 on the following line, and there is no risk. > I tested tier1 with rhel and windows x86_64, and no errors found. This pull request has now been integrated. Changeset: 68c63203 Author: Kimura Yukihiro <81151783+yukikimmura at users.noreply.github.com> Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/68c63203f553cf99100c8b111837deb32a7d080a Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8214004: Missing space between compiler thread name and task info in hs_err Reviewed-by: phh ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/831 From stuefe at openjdk.java.net Fri Feb 25 09:50:05 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 25 Feb 2022 09:50:05 GMT Subject: [jdk17u-dev] Integrated: 8281460: Let ObjectMonitor have its own NMT category In-Reply-To: References: Message-ID: On Wed, 16 Feb 2022 09:37:02 GMT, Thomas Stuefe wrote: > Hi all, > > Clean backport, small fix and low risk. > > I'd like to backport this to make it more obvious if a VM uses a lot of memory for Object Monitors. Before this patch, this number was hidden in mtInternal. > > Thanks, Thomas This pull request has now been integrated. Changeset: 66506527 Author: Thomas Stuefe URL: https://git.openjdk.java.net/jdk17u-dev/commit/66506527eb4971b0c7ddc35fc25ae8305b003f76 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod 8281460: Let ObjectMonitor have its own NMT category Backport-of: a037b3c35831f029d23a88bdd49e7f2c2d951631 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/166 From sgehwolf at redhat.com Fri Feb 25 10:14:36 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Fri, 25 Feb 2022 11:14:36 +0100 Subject: [RFC] Backport cgroups v2 support to 11u? Message-ID: <13f867a7bdb6ea5a23094a1f05ae940132ea416a.camel@redhat.com> Hi, We, Red Hat, think that getting cgroups v2 support backported to JDK 11u (and perhaps 8u) would be good at this point since systems which use cgroups v2 by default become more an more widely used. For example Red Hat Enterprise Linux 9[1] will have that turned on by default. Recent Fedora and Ubuntu distributions have it on by default. Similarly, container technology such as Docker and Kubernetes support cgroups v2 as well. The risk of NOT backporting those patches is that the JVM would wrongly detect resource limits. Even though, -XX:+UseContainerSupport is on by default in 11u, container detection code would just give up early and would use the host systems' resource limits instead. That gets us back to pre-JDK-8146115[2] behaviour of the JDK when running on such systems. I.e. random OOM kills and other strange behaviour. IMHO, that would be bad. Cgroups v2 support has been available in the JDK since version 15 and up and, I believe, most bugs have been shaken out in due course. Support code has been pretty stable over the last couple of major JDK releases. The code is Linux-only and is pretty self-contained. It is our belief that the risks of introducing those patches to 11u is manageable. We propose to backport the following patch-set from JDK 15+: Cgroups v2: Container awareness https://bugs.openjdk.java.net/browse/JDK-8230305 Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy https://bugs.openjdk.java.net/browse/JDK-8231111 8230305 causes slowdebug build failure https://bugs.openjdk.java.net/browse/JDK-8237479 [cgroups v2] Soft memory limit incorrectly using memory.high https://bugs.openjdk.java.net/browse/JDK-8253714 Cgroups: Incorrect detection logic on old systems in hotspot https://bugs.openjdk.java.net/browse/JDK-8239785 Cgroups: Incorrect detection logic on some systems https://bugs.openjdk.java.net/browse/JDK-8239559 jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java https://bugs.openjdk.java.net/browse/JDK-8244500 containers/cgroup/PlainRead.java fails on Ubuntu 21.10 https://bugs.openjdk.java.net/browse/JDK-8278951 [cgroups v2] Account for the fact that swap accounting is disabled on some systems https://bugs.openjdk.java.net/browse/JDK-8253797 Cgroups: Incorrect detection logic on some systems (still reproducible) https://bugs.openjdk.java.net/browse/JDK-8245543 [Metrics] Enhance parsing of cgroup interface files for version detection https://bugs.openjdk.java.net/browse/JDK-8254001 HotSpot Not Identifying it is Running in a Container https://bugs.openjdk.java.net/browse/JDK-8252359 Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist https://bugs.openjdk.java.net/browse/JDK-8253435 [TESTBUG] Increase coverage of the cgroups detection code https://bugs.openjdk.java.net/browse/JDK-8253939 Thoughts? What do other 11u maintainers think? Thanks, Severin [1] https://www.redhat.com/en/blog/whats-new-rhel-90-beta [2] https://bugs.openjdk.java.net/browse/JDK-8146115 From aph at openjdk.java.net Fri Feb 25 11:13:48 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Fri, 25 Feb 2022 11:13:48 GMT Subject: [jdk15u-dev] RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 15:43:41 GMT, Evgeny Astigeevich wrote: > A backport of a configurable implementation of _onSpinWait() intrinsic to achieve parity with x86 which has it implemented. > The risk of changes is low. By default it is off. > Tested for fastdebug and release builds: > > - `gtest`: Passed > - `tier1`...`tier3`: Passed except [JDK-8261534](https://bugs.openjdk.java.net/browse/JDK-8261534) and [JDK-8277488](https://bugs.openjdk.java.net/browse/JDK-8277488) > - `hotspot/jtreg/compiler/onSpinWait`: Passed > > Applying the patch had issues to find proper positions. No code changes are needed after repositioning. > Changes to `globals_aarch64.hpp` needed the new added options definitions to be converted from the new format to the old one. `vm.flagless` was removed from the new tests. > Changes to `vm_version_aarch64.cpp`, instantiation of `SpinWait`, use C++11 syntax. They needed to be changed to C++03 syntax. I'm not sure about this one. With OnSpinWaitInst=isb, ThreadOnSpinWaitProducerConsumer gets better but ThreadOnSpinWaitSharedCounter gets worse. So there are cases where it's worth using, but does this patch meet the "enhancement that provides substantial benefit to OpenJDK 11u users and it is of low risk" requirement? I guess as long as the default for all platforms stays at "off" it won't cause any regressions. Do you know of any applications that substantially benefit? ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/181 From duke at openjdk.java.net Fri Feb 25 12:14:05 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Fri, 25 Feb 2022 12:14:05 GMT Subject: [jdk15u-dev] RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 In-Reply-To: References: Message-ID: On Fri, 25 Feb 2022 10:24:08 GMT, Andrew Haley wrote: > So there are cases where it's worth using, but does this patch meet the "enhancement that provides substantial benefit to OpenJDK 11u users and it is of low risk" requirement? This is for 15u not for 11u. > Do you know of any applications that substantially benefit? Yes, we have services which got improvements. Also 15u version of `java.util.concurrent.SynchronousQueue` uses `Thread.onSpinWait`. A SynchronousQueue microbenchmark (see it in https://bugs.openjdk.java.net/browse/JDK-8267502) got the following geomean ops/s when ran on 2 CPUs 60 times: - No intrinsic implementation: 226,732.8 ops/s - One ISB implementation: 1,996,916.3 ops/s The difference is 8.8x. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/181 From christoph.langer at sap.com Fri Feb 25 12:15:42 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 25 Feb 2022 12:15:42 +0000 Subject: [RFC] Backport cgroups v2 support to 11u? In-Reply-To: <13f867a7bdb6ea5a23094a1f05ae940132ea416a.camel@redhat.com> References: <13f867a7bdb6ea5a23094a1f05ae940132ea416a.camel@redhat.com> Message-ID: Hi Severin, as this falls under the category "enabling new computing environments" and the changes seem to be more on the outskirts of the core JVM I would be positive about this effort. Best regards Christoph > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Severin Gehwolf > Sent: Freitag, 25. Februar 2022 11:15 > To: jdk-updates-dev at openjdk.java.net > Subject: [RFC] Backport cgroups v2 support to 11u? > > Hi, > > We, Red Hat, think that getting cgroups v2 support backported to JDK 11u > (and perhaps 8u) would be good at this point since systems which use > cgroups v2 by default become more an more widely used. For example Red > Hat Enterprise Linux 9[1] will have that turned on by default. > Recent Fedora and Ubuntu distributions have it on by default. > Similarly, container technology such as Docker and Kubernetes support > cgroups v2 as well. > > The risk of NOT backporting those patches is that the JVM would wrongly > detect resource limits. Even though, -XX:+UseContainerSupport is on by > default in 11u, container detection code would just give up early and would > use the host systems' resource limits instead. That gets us back to pre-JDK- > 8146115[2] behaviour of the JDK when running on such systems. I.e. random > OOM kills and other strange behaviour. IMHO, that would be bad. > > Cgroups v2 support has been available in the JDK since version 15 and up and, > I believe, most bugs have been shaken out in due course. > Support code has been pretty stable over the last couple of major JDK > releases. The code is Linux-only and is pretty self-contained. It is our belief > that the risks of introducing those patches to 11u is manageable. > > We propose to backport the following patch-set from JDK 15+: > > Cgroups v2: Container awareness > https://bugs.openjdk.java.net/browse/JDK-8230305 > > Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy > https://bugs.openjdk.java.net/browse/JDK-8231111 > > 8230305 causes slowdebug build failure > https://bugs.openjdk.java.net/browse/JDK-8237479 > > [cgroups v2] Soft memory limit incorrectly using memory.high > https://bugs.openjdk.java.net/browse/JDK-8253714 > > Cgroups: Incorrect detection logic on old systems in hotspot > https://bugs.openjdk.java.net/browse/JDK-8239785 > > Cgroups: Incorrect detection logic on some systems > https://bugs.openjdk.java.net/browse/JDK-8239559 > > jtreg test error in > test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java > https://bugs.openjdk.java.net/browse/JDK-8244500 > > containers/cgroup/PlainRead.java fails on Ubuntu 21.10 > https://bugs.openjdk.java.net/browse/JDK-8278951 > > [cgroups v2] Account for the fact that swap accounting is disabled on some > systems > https://bugs.openjdk.java.net/browse/JDK-8253797 > > Cgroups: Incorrect detection logic on some systems (still reproducible) > https://bugs.openjdk.java.net/browse/JDK-8245543 > > [Metrics] Enhance parsing of cgroup interface files for version detection > https://bugs.openjdk.java.net/browse/JDK-8254001 > > HotSpot Not Identifying it is Running in a Container > https://bugs.openjdk.java.net/browse/JDK-8252359 > > Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist > https://bugs.openjdk.java.net/browse/JDK-8253435 > > [TESTBUG] Increase coverage of the cgroups detection code > https://bugs.openjdk.java.net/browse/JDK-8253939 > > Thoughts? What do other 11u maintainers think? > > Thanks, > Severin > > [1] > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww > .redhat.com%2Fen%2Fblog%2Fwhats-new-rhel-90- > beta&data=04%7C01%7Cchristoph.langer%40sap.com%7Cad88737ed6b > 7455c130c08d9f847cc82%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7 > C637813809524243235%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sda > ta=9Rht%2BlwQt4nvq7WeVAWdB6hbK25Uupz57qgprqCDtbc%3D&rese > rved=0 > [2] https://bugs.openjdk.java.net/browse/JDK-8146115 From matthias.baesken at sap.com Fri Feb 25 12:32:05 2022 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Fri, 25 Feb 2022 12:32:05 +0000 Subject: [RFC] Backport cgroups v2 support to 11u? Message-ID: Hi Severin, this sounds like a good idea, a lot of people still run jdk11 and they might face some issues on new distros without backporting this. Best regards, Matthias -------------------------------------------------------------------------------------------------------------- Hi, We, Red Hat, think that getting cgroups v2 support backported to JDK 11u (and perhaps 8u) would be good at this point since systems which use cgroups v2 by default become more an more widely used. For example Red Hat Enterprise Linux 9[1] will have that turned on by default. Recent Fedora and Ubuntu distributions have it on by default. Similarly, container technology such as Docker and Kubernetes support cgroups v2 as well. The risk of NOT backporting those patches is that the JVM would wrongly detect resource limits. Even though, -XX:+UseContainerSupport is on by default in 11u, container detection code would just give up early and would use the host systems' resource limits instead. That gets us back to pre-JDK-8146115[2] behaviour of the JDK when running on such systems. I.e. random OOM kills and other strange behaviour. IMHO, that would be bad. Cgroups v2 support has been available in the JDK since version 15 and up and, I believe, most bugs have been shaken out in due course. Support code has been pretty stable over the last couple of major JDK releases. The code is Linux-only and is pretty self-contained. It is our belief that the risks of introducing those patches to 11u is manageable. We propose to backport the following patch-set from JDK 15+: Cgroups v2: Container awareness https://bugs.openjdk.java.net/browse/JDK-8230305 Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy https://bugs.openjdk.java.net/browse/JDK-8231111 8230305 causes slowdebug build failure https://bugs.openjdk.java.net/browse/JDK-8237479 [cgroups v2] Soft memory limit incorrectly using memory.high https://bugs.openjdk.java.net/browse/JDK-8253714 Cgroups: Incorrect detection logic on old systems in hotspot https://bugs.openjdk.java.net/browse/JDK-8239785 Cgroups: Incorrect detection logic on some systems https://bugs.openjdk.java.net/browse/JDK-8239559 jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java https://bugs.openjdk.java.net/browse/JDK-8244500 containers/cgroup/PlainRead.java fails on Ubuntu 21.10 https://bugs.openjdk.java.net/browse/JDK-8278951 [cgroups v2] Account for the fact that swap accounting is disabled on some systems https://bugs.openjdk.java.net/browse/JDK-8253797 Cgroups: Incorrect detection logic on some systems (still reproducible) https://bugs.openjdk.java.net/browse/JDK-8245543 [Metrics] Enhance parsing of cgroup interface files for version detection https://bugs.openjdk.java.net/browse/JDK-8254001 HotSpot Not Identifying it is Running in a Container https://bugs.openjdk.java.net/browse/JDK-8252359 Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist https://bugs.openjdk.java.net/browse/JDK-8253435 [TESTBUG] Increase coverage of the cgroups detection code https://bugs.openjdk.java.net/browse/JDK-8253939 Thoughts? What do other 11u maintainers think? Thanks, Severin From thomas.stuefe at gmail.com Fri Feb 25 12:34:02 2022 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Fri, 25 Feb 2022 13:34:02 +0100 Subject: [RFC] Backport cgroups v2 support to 11u? In-Reply-To: <13f867a7bdb6ea5a23094a1f05ae940132ea416a.camel@redhat.com> References: <13f867a7bdb6ea5a23094a1f05ae940132ea416a.camel@redhat.com> Message-ID: I think this makes a lot of sense. Cheers, Thomas p.s. I had just glimpsed at Zhengyus backport PR for 8230305 and it does not look too bad. But tool-wise, I wish we had an easy way to see where backport patches were modified for the target release. That would make reviews of unclean patches so much easier. On Fri, Feb 25, 2022 at 11:15 AM Severin Gehwolf wrote: > Hi, > > We, Red Hat, think that getting cgroups v2 support backported to JDK > 11u (and perhaps 8u) would be good at this point since systems which > use cgroups v2 by default become more an more widely used. For example > Red Hat Enterprise Linux 9[1] will have that turned on by default. > Recent Fedora and Ubuntu distributions have it on by default. > Similarly, container technology such as Docker and Kubernetes support > cgroups v2 as well. > > The risk of NOT backporting those patches is that the JVM would wrongly > detect resource limits. Even though, -XX:+UseContainerSupport is on by > default in 11u, container detection code would just give up early and > would use the host systems' resource limits instead. That gets us back > to pre-JDK-8146115[2] behaviour of the JDK when running on such > systems. I.e. random OOM kills and other strange behaviour. IMHO, that > would be bad. > > Cgroups v2 support has been available in the JDK since version 15 and > up and, I believe, most bugs have been shaken out in due course. > Support code has been pretty stable over the last couple of major JDK > releases. The code is Linux-only and is pretty self-contained. It is > our belief that the risks of introducing those patches to 11u is > manageable. > > We propose to backport the following patch-set from JDK 15+: > > Cgroups v2: Container awareness > https://bugs.openjdk.java.net/browse/JDK-8230305 > > Cgroups v2: Rework Metrics in java.base so as to recognize unified > hierarchy > https://bugs.openjdk.java.net/browse/JDK-8231111 > > 8230305 causes slowdebug build failure > https://bugs.openjdk.java.net/browse/JDK-8237479 > > [cgroups v2] Soft memory limit incorrectly using memory.high > https://bugs.openjdk.java.net/browse/JDK-8253714 > > Cgroups: Incorrect detection logic on old systems in hotspot > https://bugs.openjdk.java.net/browse/JDK-8239785 > > Cgroups: Incorrect detection logic on some systems > https://bugs.openjdk.java.net/browse/JDK-8239559 > > jtreg test error in > test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java > https://bugs.openjdk.java.net/browse/JDK-8244500 > > containers/cgroup/PlainRead.java fails on Ubuntu 21.10 > https://bugs.openjdk.java.net/browse/JDK-8278951 > > [cgroups v2] Account for the fact that swap accounting is disabled on some > systems > https://bugs.openjdk.java.net/browse/JDK-8253797 > > Cgroups: Incorrect detection logic on some systems (still reproducible) > https://bugs.openjdk.java.net/browse/JDK-8245543 > > [Metrics] Enhance parsing of cgroup interface files for version detection > https://bugs.openjdk.java.net/browse/JDK-8254001 > > HotSpot Not Identifying it is Running in a Container > https://bugs.openjdk.java.net/browse/JDK-8252359 > > Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist > https://bugs.openjdk.java.net/browse/JDK-8253435 > > [TESTBUG] Increase coverage of the cgroups detection code > https://bugs.openjdk.java.net/browse/JDK-8253939 > > Thoughts? What do other 11u maintainers think? > > Thanks, > Severin > > [1] https://www.redhat.com/en/blog/whats-new-rhel-90-beta > [2] https://bugs.openjdk.java.net/browse/JDK-8146115 > > From goetz at openjdk.java.net Fri Feb 25 13:01:36 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 25 Feb 2022 13:01:36 GMT Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous Message-ID: ?all to 'log2_intptr' is ambiguous Fix build error. In case someone else addresses this I can well cancel this PR. ------------- Commit messages: - 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous Changes: https://git.openjdk.java.net/jdk11u-dev/pull/841/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=841&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282372 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/841.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/841/head:pull/841 PR: https://git.openjdk.java.net/jdk11u-dev/pull/841 From aph-open at littlepinkcloud.com Fri Feb 25 13:20:40 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Fri, 25 Feb 2022 13:20:40 +0000 Subject: [jdk15u-dev] RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 In-Reply-To: References: Message-ID: <2fac3e4c-2165-794e-be14-7b8ff874e543@littlepinkcloud.com> On 2/25/22 12:14, Evgeny Astigeevich wrote: > On Fri, 25 Feb 2022 10:24:08 GMT, Andrew Haley wrote: > >> So there are cases where it's worth using, but does this patch meet the "enhancement that provides substantial benefit to OpenJDK 11u users and it is of low risk" requirement? > > This is for 15u not for 11u. Sure, OK. I'm thinking ahead. >> Do you know of any applications that substantially benefit? > > Yes, we have services which got improvements. Also 15u version of `java.util.concurrent.SynchronousQueue` uses `Thread.onSpinWait`. A SynchronousQueue microbenchmark (see it in https://bugs.openjdk.java.net/browse/JDK-8267502) got the following geomean ops/s when ran on 2 CPUs 60 times: > - No intrinsic implementation: 226,732.8 ops/s > - One ISB implementation: 1,996,916.3 ops/s > > The difference is 8.8x. Interesting, so I guess that's much more dramatic than anything we have in the OpenJDK benchmarks. Maybe we want a JMH version of that. Do you think that onSpinWait() = ISB would help with 8267502? From clanger at openjdk.java.net Fri Feb 25 13:32:57 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 25 Feb 2022 13:32:57 GMT Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: On Fri, 25 Feb 2022 12:55:32 GMT, Goetz Lindenmaier wrote: > ?all to 'log2_intptr' is ambiguous > > Fix build error. > > In case someone else addresses this I can well cancel this PR. Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/841 From aph-open at littlepinkcloud.com Fri Feb 25 13:28:45 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Fri, 25 Feb 2022 13:28:45 +0000 Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: On 2/25/22 13:01, Goetz Lindenmaier wrote: > ?all to 'log2_intptr' is ambiguous > > Fix build error. > > In case someone else addresses this I can well cancel this PR. This is in progress; see The discussion at the end of https://github.com/openjdk/jdk11u-dev/pull/280 From tnakamura at openjdk.java.net Fri Feb 25 13:48:13 2022 From: tnakamura at openjdk.java.net (Toshio Nakamura) Date: Fri, 25 Feb 2022 13:48:13 GMT Subject: [jdk17u-dev] RFR: 8278185: Custom JRE cannot find non-ASCII named module inside In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 07:46:35 GMT, Toshio Nakamura wrote: > I'd like to backport this to jdk17 since it fixes jlink issue with non-ASCII named module. Fix is low risk and applies cleanly. tier1 and tier2 tests have no regression with the patch. Got approval. May I ask someone sponsor this fix? ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/177 From goetz.lindenmaier at sap.com Fri Feb 25 14:47:27 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 25 Feb 2022 14:47:27 +0000 Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: Hi, Thanks Andrew. But from the PR it's not clear who might make a fix. It's two days old now. I ran into this because I was setting up a mac aarch build in our test infrastructure. I used the proposal in 8282372 for my PR, it's just what is proposed in PR 280 of "8254072 AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build". If you Ahmed, or someone else wants to push a change, that's fine. Else I would push it later tonight. Best regards, Goetz. > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Andrew Haley > Sent: Friday, February 25, 2022 2:29 PM > To: jdk-updates-dev at openjdk.java.net > Subject: Re: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 > 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous > > On 2/25/22 13:01, Goetz Lindenmaier wrote: > > ...all to 'log2_intptr' is ambiguous > > > > Fix build error. > > > > In case someone else addresses this I can well cancel this PR. > > This is in progress; see The discussion at the end of > https://github.com/openjdk/jdk11u-dev/pull/280 From mbaesken at openjdk.java.net Fri Feb 25 15:43:34 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 25 Feb 2022 15:43:34 GMT Subject: [jdk17u-dev] RFR: 8276841: Add support for Visual Studio 2022 Message-ID: 8276841: Add support for Visual Studio 2022 ------------- Commit messages: - Backport f65db88b74911e5896d2ff536c4ac97e7f62d98b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/179/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=179&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276841 Stats: 17 lines in 1 file changed: 15 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/179.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/179/head:pull/179 PR: https://git.openjdk.java.net/jdk17u-dev/pull/179 From aph-open at littlepinkcloud.com Fri Feb 25 16:23:04 2022 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Fri, 25 Feb 2022 16:23:04 +0000 Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: <66ac4514-beb1-f6ac-0208-a2860155f5f4@littlepinkcloud.com> On 2/25/22 14:47, Lindenmaier, Goetz wrote: > I used the proposal in 8282372 for my PR, it's just what is > proposed in PR 280 of "8254072 AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build". > > If you Ahmed, or someone else wants to push a change, > that's fine. > Else I would push it later tonight. OK, I see. In any case it's a trivial change, so please do that. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From tnakamura at openjdk.java.net Fri Feb 25 18:34:16 2022 From: tnakamura at openjdk.java.net (Toshio Nakamura) Date: Fri, 25 Feb 2022 18:34:16 GMT Subject: [jdk17u-dev] Integrated: 8278185: Custom JRE cannot find non-ASCII named module inside In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 07:46:35 GMT, Toshio Nakamura wrote: > I'd like to backport this to jdk17 since it fixes jlink issue with non-ASCII named module. Fix is low risk and applies cleanly. tier1 and tier2 tests have no regression with the patch. This pull request has now been integrated. Changeset: df5a29ca Author: Toshio Nakamura Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u-dev/commit/df5a29caf1b1f498b55591b278bc0e4e8e4a294d Stats: 99 lines in 2 files changed: 98 ins; 0 del; 1 mod 8278185: Custom JRE cannot find non-ASCII named module inside Backport-of: fcd67a5242b7db06e4cb06b574972a463b209b2e ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/177 From dlong at openjdk.java.net Fri Feb 25 22:07:58 2022 From: dlong at openjdk.java.net (Dean Long) Date: Fri, 25 Feb 2022 22:07:58 GMT Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: On Fri, 25 Feb 2022 12:55:32 GMT, Goetz Lindenmaier wrote: > ?all to 'log2_intptr' is ambiguous > > Fix build error. > > In case someone else addresses this I can well cancel this PR. Does this work for Windows+ARM64? @rnkovacs ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/841 From goetz at openjdk.java.net Fri Feb 25 22:26:01 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 25 Feb 2022 22:26:01 GMT Subject: [jdk11u-dev] Integrated: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: On Fri, 25 Feb 2022 12:55:32 GMT, Goetz Lindenmaier wrote: > ?all to 'log2_intptr' is ambiguous > > Fix build error. > > In case someone else addresses this I can well cancel this PR. This pull request has now been integrated. Changeset: 80a27773 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/80a27773cbba61c0cb47de15c48f7fb9ecb69f4a Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous Reviewed-by: clanger ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/841 From serb at openjdk.java.net Sat Feb 26 04:36:12 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sat, 26 Feb 2022 04:36:12 GMT Subject: [jdk15u-dev] Integrated: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream) In-Reply-To: <8GwSSVa0IxcPGI3OnVdtpNk-HVvFhb325INWNwV3xwE=.269cafd9-0001-4b78-8735-469d4f6d7a09@github.com> References: <8GwSSVa0IxcPGI3OnVdtpNk-HVvFhb325INWNwV3xwE=.269cafd9-0001-4b78-8735-469d4f6d7a09@github.com> Message-ID: On Tue, 22 Feb 2022 22:26:21 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [06b33a0a](https://github.com/openjdk/jdk/commit/06b33a0ad78d1577711af22020cf5fdf25112523) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 4 Feb 2021 and was reviewed by Alexander Zvegintsev and Prasanta Sadhukhan. > > The new test failed before and works fine after the fix. No new issues were found by the java_desktop tests. > > Thanks! This pull request has now been integrated. Changeset: be6915ab Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk15u-dev/commit/be6915ab5b5bcc9566935d4252b5ed2aa7de1532 Stats: 56 lines in 2 files changed: 54 ins; 0 del; 2 mod 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream) Backport-of: 06b33a0ad78d1577711af22020cf5fdf25112523 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/180 From serb at openjdk.java.net Sat Feb 26 04:42:03 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sat, 26 Feb 2022 04:42:03 GMT Subject: [jdk11u-dev] Integrated: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream) In-Reply-To: References: Message-ID: On Mon, 21 Feb 2022 21:15:18 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [06b33a0a](https://github.com/openjdk/jdk/commit/06b33a0ad78d1577711af22020cf5fdf25112523) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 4 Feb 2021 and was reviewed by Alexander Zvegintsev and Prasanta Sadhukhan. > > The new test failed before and works fine after the fix. No new issues were found by the java_desktop tests. > > Thanks! This pull request has now been integrated. Changeset: ba6c4c16 Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk11u-dev/commit/ba6c4c163c5cf43fad129402f19389dde7d8aeb4 Stats: 56 lines in 2 files changed: 54 ins; 0 del; 2 mod 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream) Backport-of: 06b33a0ad78d1577711af22020cf5fdf25112523 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/835 From duke at openjdk.java.net Sat Feb 26 05:34:58 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Sat, 26 Feb 2022 05:34:58 GMT Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: On Fri, 25 Feb 2022 22:04:25 GMT, Dean Long wrote: >> ?all to 'log2_intptr' is ambiguous >> >> Fix build error. >> >> In case someone else addresses this I can well cancel this PR. > > Does this work for Windows+ARM64? > @rnkovacs @dean-long This change does not conflict with the windows-aarch64 build. However, the windows-aarch64 build does have a separate build issue that is due to this commit: https://github.com/openjdk/jdk11u-dev/pull/715/commits/6d0379585aef668dedcf1f392349ccc72d6d192b The fix is to just revert that commit. I do not have an account on JBS yet but if someone else wants to go ahead and create the bug I can submit the PR. Here's a copy of the build error: * For target hotspot_variant-server_libjvm_objs_macroAssembler_aarch64.obj: macroAssembler_aarch64.cpp d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): error C3688: invalid literal suffix 'PRIX64'; literal operator or literal operator template 'operator ""PRIX64' not found d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint64_t' to 'const char *const ' d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): error C3688: invalid literal suffix 'PRIX64'; literal operator or literal operator template 'operator ""PRIX64' not found d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint64_t' to 'const char *const ' d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): error C3688: invalid literal suffix 'PRIX32'; literal operator or literal operator template 'operator ""PRIX32' not found d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint32_t' to 'const char *const ' d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' ... (rest of output omitted) cc: @Vladimirkempik @theRealAph Although reverting the commit fixes the build issue, there was some discussion about the correctness of the original change here: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1032449457 I don't want to hijack this thread so we can continue that discussion under the new bug/PR once someone creates it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/841 From tnakamura at openjdk.java.net Mon Feb 28 01:34:11 2022 From: tnakamura at openjdk.java.net (Toshio Nakamura) Date: Mon, 28 Feb 2022 01:34:11 GMT Subject: [jdk17u-dev] RFR: 8278185: Custom JRE cannot find non-ASCII named module inside In-Reply-To: References: Message-ID: <5NrFl2hzyd3blXaOLpfe23grJg7HT2zQtwwMZ0xYnUU=.353d723b-0318-4e58-84aa-7a19218d6c23@github.com> On Thu, 24 Feb 2022 07:46:35 GMT, Toshio Nakamura wrote: > I'd like to backport this to jdk17 since it fixes jlink issue with non-ASCII named module. Fix is low risk and applies cleanly. tier1 and tier2 tests have no regression with the patch. @phohensee Thank you for your help! ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/177 From duke at openjdk.java.net Mon Feb 28 02:11:03 2022 From: duke at openjdk.java.net (Mat Carter) Date: Mon, 28 Feb 2022 02:11:03 GMT Subject: [jdk17u-dev] Integrated: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 04:23:07 GMT, Mat Carter wrote: > Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 This pull request has now been integrated. Changeset: fc57ee6d Author: Mat Carter <54955201+macarte at users.noreply.github.com> Committer: Aleksei Efimov URL: https://git.openjdk.java.net/jdk17u-dev/commit/fc57ee6d14a614c5bce3b4b5af541127e3861dba Stats: 19 lines in 1 file changed: 11 ins; 6 del; 2 mod 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled Backport-of: 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/176 From goetz at openjdk.java.net Mon Feb 28 08:14:00 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Feb 2022 08:14:00 GMT Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: On Sat, 26 Feb 2022 05:31:27 GMT, Ahmed Muhsin wrote: >> Does this work for Windows+ARM64? >> @rnkovacs > > @dean-long > > This change does not conflict with the windows-aarch64 build. > > However, the windows-aarch64 build does have a separate build issue that is due to this commit: https://github.com/openjdk/jdk11u-dev/pull/715/commits/6d0379585aef668dedcf1f392349ccc72d6d192b > > The fix is to just revert that commit. I do not have an account on JBS yet but if someone else wants to go ahead and create the bug I can submit the PR. > > Here's a copy of the build error: > > * For target hotspot_variant-server_libjvm_objs_macroAssembler_aarch64.obj: > macroAssembler_aarch64.cpp > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): error C3688: invalid literal suffix 'PRIX64'; literal operator or literal operator template 'operator ""PRIX64' not found > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint64_t' to 'const char *const ' > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast > d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): error C3688: invalid literal suffix 'PRIX64'; literal operator or literal operator template 'operator ""PRIX64' not found > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint64_t' to 'const char *const ' > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast > d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): error C3688: invalid literal suffix 'PRIX32'; literal operator or literal operator template 'operator ""PRIX32' not found > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint32_t' to 'const char *const ' > d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast > d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' > ... (rest of output omitted) > > > cc: @Vladimirkempik @theRealAph > Although reverting the commit fixes the build issue, there was some discussion about the correctness of the original change here: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1032449457 > > I don't want to hijack this thread so we can continue that discussion under the new bug/PR once someone creates it. Hi @ahmedmuhsin I think we need to backport "8211333: AArch64: Fix another build failure after JDK-8211029" to fix your problem "invalid literal suffix 'PRIX64'" above. Can you please verify? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/841 From goetz at openjdk.java.net Mon Feb 28 09:29:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Feb 2022 09:29:37 GMT Subject: [jdk17u-dev] RFR: 8277795: ldap connection timeout not honoured under contention Message-ID: I backport this for parity with 17.0.3-oracle. ------------- Commit messages: - Backport 3d926dd66ef6551e91a4ebbbc59dcff58f5ede5a Changes: https://git.openjdk.java.net/jdk17u-dev/pull/180/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=180&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277795 Stats: 467 lines in 5 files changed: 324 ins; 72 del; 71 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/180.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/180/head:pull/180 PR: https://git.openjdk.java.net/jdk17u-dev/pull/180 From goetz at openjdk.java.net Mon Feb 28 11:07:03 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Feb 2022 11:07:03 GMT Subject: [jdk17u-dev] Integrated: 8272866: java.util.random package summary contains incorrect mixing function in table In-Reply-To: <9gifJvx6Xd5hva2HjA206vUAVwBlQWq96DrS8MpFhdA=.03fb2022-3c48-42ad-b5e3-8dc064a596f7@github.com> References: <9gifJvx6Xd5hva2HjA206vUAVwBlQWq96DrS8MpFhdA=.03fb2022-3c48-42ad-b5e3-8dc064a596f7@github.com> Message-ID: On Thu, 24 Feb 2022 10:59:39 GMT, Goetz Lindenmaier wrote: > Backporting as it was dedicated for backport to earlier releases but then slipped through. This pull request has now been integrated. Changeset: 90d83a22 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/90d83a2250a112b0f48b46092f93e8e6abc7393f Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod 8272866: java.util.random package summary contains incorrect mixing function in table Backport-of: e66c8afb59b57c4546656efa97f723f084964330 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/178 From goetz at openjdk.java.net Mon Feb 28 11:51:30 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Feb 2022 11:51:30 GMT Subject: [jdk17u-dev] RFR: 8276141: XPathFactory set/getProperty method [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.3-oracle. Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: - Update XPathFactory.java - Update XPathFactoryImpl.java ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/167/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/167/files/9155026a..e8eed7b0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=167&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=167&range=00-01 Stats: 62 lines in 2 files changed: 0 ins; 59 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/167.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/167/head:pull/167 PR: https://git.openjdk.java.net/jdk17u-dev/pull/167 From mbaesken at openjdk.java.net Mon Feb 28 12:47:02 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 28 Feb 2022 12:47:02 GMT Subject: [jdk17u-dev] Integrated: 8276841: Add support for Visual Studio 2022 In-Reply-To: References: Message-ID: On Fri, 25 Feb 2022 15:34:10 GMT, Matthias Baesken wrote: > 8276841: Add support for Visual Studio 2022 This pull request has now been integrated. Changeset: 9e9c1503 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/9e9c15037a40b0b087fc7881389485f3cdf74a85 Stats: 17 lines in 1 file changed: 15 ins; 0 del; 2 mod 8276841: Add support for Visual Studio 2022 Backport-of: f65db88b74911e5896d2ff536c4ac97e7f62d98b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/179 From goetz at openjdk.java.net Mon Feb 28 13:45:16 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Feb 2022 13:45:16 GMT Subject: [jdk17u-dev] RFR: 8276141: XPathFactory set/getProperty method Message-ID: I backport this for parity with 17.0.3-oracle. I adapted it as proposed in the backport CSR. ------------- Commit messages: - Backport b226ab99c872e791d3ed9fca015cf92847904c34 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/181/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=181&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276141 Stats: 59 lines in 2 files changed: 56 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/181.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/181/head:pull/181 PR: https://git.openjdk.java.net/jdk17u-dev/pull/181 From itakiguchi at openjdk.java.net Mon Feb 28 14:31:21 2022 From: itakiguchi at openjdk.java.net (Ichiroh Takiguchi) Date: Mon, 28 Feb 2022 14:31:21 GMT Subject: [jdk17u-dev] RFR: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX Message-ID: Backport JDK-8282219 ------------- Commit messages: - Backport c5c6058fd57d4b594012035eaf18a57257f4ad85 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/182/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=182&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282219 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/182.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/182/head:pull/182 PR: https://git.openjdk.java.net/jdk17u-dev/pull/182 From zgu at openjdk.java.net Mon Feb 28 15:29:21 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 28 Feb 2022 15:29:21 GMT Subject: [jdk17u-dev] RFR: 8281615: Deadlock caused by jdwp agent Message-ID: <4RxmFSG6tOvTOM7sONXFYX8mRzUV8gRR3T8CU2DhVnY=.dcb8177a-bb86-4f95-8e36-20bcedcd4037@github.com> I would like to backport this patch to jdk17u, because without the fix, jdwp can potential deadlock whole JVM. Test: - [x] Testbase_nsk_jdi - [x] Testbase_nsk_jvmti - [x] Testbase_nsk_jdwp ------------- Commit messages: - Backport e1060bee2adb9f2e07ca09309d0f89132db30f28 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/183/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=183&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281615 Stats: 31 lines in 1 file changed: 18 ins; 5 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/183.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/183/head:pull/183 PR: https://git.openjdk.java.net/jdk17u-dev/pull/183 From zgu at openjdk.java.net Mon Feb 28 15:41:25 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 28 Feb 2022 15:41:25 GMT Subject: [jdk11u-dev] RFR: 8281615: Deadlock caused by jdwp agent Message-ID: I would like to backport this patch to jdk11u, because without the fix, jdwp can potential deadlock whole JVM. Test: - [x] Testbase_nsk_jdi - [x] Testbase_nsk_jvmti - [x] Testbase_nsk_jdwp ------------- Commit messages: - Backport e1060bee2adb9f2e07ca09309d0f89132db30f28 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/843/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=843&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281615 Stats: 31 lines in 1 file changed: 18 ins; 5 del; 8 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/843.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/843/head:pull/843 PR: https://git.openjdk.java.net/jdk11u-dev/pull/843 From phh at openjdk.java.net Mon Feb 28 16:30:13 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 28 Feb 2022 16:30:13 GMT Subject: [jdk17u-dev] RFR: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: <97J-Q6h-POH6QukVVt8Yw2QY7Tu4GSBV_8ulsoQK6UM=.ba04befb-9392-4050-a307-136ac37191aa@github.com> On Mon, 28 Feb 2022 13:36:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > > I adapted it as proposed in the backport CSR. The patch is missing the changes to XPathFactory.java. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/181 From rob.mckenna at oracle.com Mon Feb 28 16:34:18 2022 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Mon, 28 Feb 2022 16:34:18 +0000 Subject: [18u Communication] 18.0.1 cutoff Message-ID: Hi folks, We're hoping to stop accepting fixes for 18.0.1 by the end of the week. If you have a fix that you need to get in, please file your fix request as soon as possible! Thanks, -Rob From duke at openjdk.java.net Mon Feb 28 17:11:02 2022 From: duke at openjdk.java.net (zzambers) Date: Mon, 28 Feb 2022 17:11:02 GMT Subject: [jdk17u-dev] Integrated: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 15:47:13 GMT, zzambers wrote: > Tested locally test/jdk/com/sun/jdi tests passed for me. This pull request has now been integrated. Changeset: c2a62d74 Author: Zdenek Zambersky Committer: Severin Gehwolf URL: https://git.openjdk.java.net/jdk17u-dev/commit/c2a62d74a1e55b58a77a23ce2eae4239a49766d6 Stats: 7 lines in 1 file changed: 1 ins; 2 del; 4 mod 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition Backport-of: 4c52eb39431c2479b0d140907bdcc0311d30f871 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/175 From duke at openjdk.java.net Mon Feb 28 17:14:54 2022 From: duke at openjdk.java.net (zzambers) Date: Mon, 28 Feb 2022 17:14:54 GMT Subject: [jdk11u-dev] Integrated: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: <9BljKl-XBgMrkhf5sEem3-LCgxjU0_u3hcjAiYsR4W0=.7ee69271-5288-4dc7-9c9c-bf814b0e41ab@github.com> On Wed, 23 Feb 2022 00:13:55 GMT, zzambers wrote: > Tested locally passed tests in test/jdk/com/sun/jdi for me. This pull request has now been integrated. Changeset: 80919eb2 Author: Zdenek Zambersky Committer: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/80919eb2fff99409544c3c4d429912707f2fb2d5 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition Reviewed-by: sgehwolf Backport-of: 4c52eb39431c2479b0d140907bdcc0311d30f871 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From phh at openjdk.java.net Mon Feb 28 18:12:29 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 28 Feb 2022 18:12:29 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 00:13:55 GMT, zzambers wrote: > Tested locally passed tests in test/jdk/com/sun/jdi for me. I can sponsor this, but please check the pre-submit failures first. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From duke at openjdk.java.net Mon Feb 28 18:22:32 2022 From: duke at openjdk.java.net (Ahmed Muhsin) Date: Mon, 28 Feb 2022 18:22:32 GMT Subject: [jdk11u-dev] RFR: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 08:11:34 GMT, Goetz Lindenmaier wrote: >> @dean-long >> >> This change does not conflict with the windows-aarch64 build. >> >> However, the windows-aarch64 build does have a separate build issue that is due to this commit: https://github.com/openjdk/jdk11u-dev/pull/715/commits/6d0379585aef668dedcf1f392349ccc72d6d192b >> >> The fix is to just revert that commit. I do not have an account on JBS yet but if someone else wants to go ahead and create the bug I can submit the PR. >> >> Here's a copy of the build error: >> >> * For target hotspot_variant-server_libjvm_objs_macroAssembler_aarch64.obj: >> macroAssembler_aarch64.cpp >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): error C3688: invalid literal suffix 'PRIX64'; literal operator or literal operator template 'operator ""PRIX64' not found >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint64_t' to 'const char *const ' >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1495): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast >> d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): error C3688: invalid literal suffix 'PRIX64'; literal operator or literal operator template 'operator ""PRIX64' not found >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint64_t' to 'const char *const ' >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1558): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast >> d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): error C3688: invalid literal suffix 'PRIX32'; literal operator or literal operator template 'operator ""PRIX32' not found >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): error C2664: 'int snprintf(char *const ,const size_t,const char *const ,...)': cannot convert argument 3 from 'uint32_t' to 'const char *const ' >> d:/a/1/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1671): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast >> d:\a\1\openjdk-azure-devops-harness\workspace\tmp1oj032l3\10\include\ucrt\stdio.h(1919): note: see declaration of 'snprintf' >> ... (rest of output omitted) >> >> >> cc: @Vladimirkempik @theRealAph >> Although reverting the commit fixes the build issue, there was some discussion about the correctness of the original change here: https://github.com/openjdk/jdk11u-dev/pull/715#issuecomment-1032449457 >> >> I don't want to hijack this thread so we can continue that discussion under the new bug/PR once someone creates it. > > Hi @ahmedmuhsin > I think we need to backport "8211333: AArch64: Fix another build failure after JDK-8211029" > to fix your problem "invalid literal suffix 'PRIX64'" above. Can you please verify? Hey @GoeLin, Backporting 8211333 did fix the build issue. Here's my diff of the backport: diff --git a/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp b/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp index 669b08b9266..4bab77d542f 100644 --- a/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp @@ -1492,7 +1492,7 @@ void MacroAssembler::movptr(Register r, uintptr_t imm64) { #ifndef PRODUCT { char buffer[64]; - snprintf(buffer, sizeof(buffer), "0x%"PRIX64, (uint64_t)imm64); + snprintf(buffer, sizeof(buffer), "0x%" PRIX64, (uint64_t)imm64); block_comment(buffer); } #endif @@ -1555,7 +1555,7 @@ void MacroAssembler::mov_immediate64(Register dst, uint64_t imm64) #ifndef PRODUCT { char buffer[64]; - snprintf(buffer, sizeof(buffer), "0x%"PRIX64, imm64); + snprintf(buffer, sizeof(buffer), "0x%" PRIX64, imm64); block_comment(buffer); } #endif @@ -1668,7 +1668,7 @@ void MacroAssembler::mov_immediate32(Register dst, uint32_t imm32) #ifndef PRODUCT { char buffer[64]; - snprintf(buffer, sizeof(buffer), "0x%"PRIX32, imm32); + snprintf(buffer, sizeof(buffer), "0x%" PRIX32, imm32); block_comment(buffer); } #endif ``` Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/841 From zgu at openjdk.java.net Mon Feb 28 18:24:11 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 28 Feb 2022 18:24:11 GMT Subject: [jdk18u] RFR: 8281615: Deadlock caused by jdwp agent Message-ID: <-M5N5ZgKf1tKPsW7CP4YetVn3eZeAFkoou2Uy8J9VHI=.d960707f-b117-4099-b0f5-291f3e9a3f03@github.com> I would like to backport this patch to jdk18u, because without the fix, jdwp can potential deadlock whole JVM. Test: - [x] Testbase_nsk_jdi - [x] Testbase_nsk_jvmti - [x] Testbase_nsk_jdwp ------------- Commit messages: - Backport e1060bee2adb9f2e07ca09309d0f89132db30f28 Changes: https://git.openjdk.java.net/jdk18u/pull/31/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=31&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281615 Stats: 31 lines in 1 file changed: 18 ins; 5 del; 8 mod Patch: https://git.openjdk.java.net/jdk18u/pull/31.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/31/head:pull/31 PR: https://git.openjdk.java.net/jdk18u/pull/31