[jdk11u-dev] RFR: 8250902: Implement MD5 Intrinsics on x86 [v2]

Paul Hohensee phh at openjdk.java.net
Mon Feb 7 12:50:45 UTC 2022


> I'd like to backport MD5 intrinsification because it improves security related performance. I understand that it may be a bridge too far for 11u. In that case we (Amazon) intend to backport it to our internal 11u distro followed by Corretto.
> 
> Testing: tier1, including the new and existing sha tests.
> 
> Ludovic Henry did an 11u backport in 2020 (see [JDK-8251319](https://bugs.openjdk.java.net/browse/JDK-8251319)), but I can't find a review request on the jdk-updates-dev list. My backport is essentially identical to his, and is based on the [backport from jdk15u](https://github.com/openjdk/jdk15u-dev/pull/163). It was not clean.
> 
> 1. Copyright date conflicts.
> 2. Context differences.
> 3. Changing SHAOptionsBase to DigestOptionsBase.
> 4. Rewriting Assembler::roll() to use emit_int8() because emit_int16() and emit_24() don't exist in 11.
> 
> This backport would be immediately followed by a backport of [JDK-8251260](https://bugs.openjdk.java.net/browse/JDK-8251260) to fix two tests. After that, I'd like to backport the aarch64 version in [JDK-8251216](https://bugs.openjdk.java.net/browse/JDK-8251216).

Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - 8250902: Implement MD5 Intrinsics on x86
 - Merge branch 'master' into backport-339016a0
 - 8250902: Implement MD5 Intrinsics on x86
 - Backport 339016a0f2cbbbbc3560e50c6726e14afbf547f6

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk11u-dev/pull/806/files
  - new: https://git.openjdk.java.net/jdk11u-dev/pull/806/files/9fd44b55..d033727c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=806&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=806&range=00-01

  Stats: 100 lines in 3 files changed: 85 ins; 12 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk11u-dev/pull/806.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/806/head:pull/806

PR: https://git.openjdk.java.net/jdk11u-dev/pull/806


More information about the jdk-updates-dev mailing list