[jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

[Andrew Haley]

On Sat, 5 Feb 2022 15:30:59 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Initial version of JEP-391 backport to jdk11u.
>> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part.
>> Things needing attention: os_bsd_aarch64.cpp and W^X transitions.
>> serviceability agent is mostly clean.
>> This passed GHA_tier1 testing.
>> Full regression testing is running now on Azul's infra, will report/update PR when done.
>> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11**
>> Sharing this PR slightly earlier to let other interested parties to run the tests too.
>> Example of cross-building on intel mac (needs Xcode12/13):
>> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64'
>
> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add two missing WX transitions

On 2/8/22 06:48, VladimirKempik wrote:
> @rnkovacs , parts of your jep-388 backport reverted ( https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1495, https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1558, https://github.com/VladimirKempik/jdk11u-dev/commit/7bdb8ac7f9f9#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aL1671 ) results in more warning for this PR:
> 
> /Users/runner/work/jdk11u-dev/jdk11u-dev/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:1495:52: error: format specifies type 'unsigned long long' but the argument has type 'uintptr_t' (aka 'unsigned long') [-Werror,-Wformat]
>      snprintf(buffer, sizeof(buffer), PTR64_FORMAT, imm64);
>                                       ~~~~~~~~~~~~  ^~~~~
> 1 error generated.
> 
> was these three changes really needed or can I revert them ?

What does this refer to? I can't find any such thing in the current state of the patch.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/715