[jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter

Denghui Dong ddong at openjdk.java.net
Wed Feb 9 06:59:37 UTC 2022


Hi team,

Could I have a review of this fix?

The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter:

 387 } else {
 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload);
 389 CompositeKlassWriter ckw(&lkw, &kw);
 390 CompositeKlassWriterRegistration ckwr(&ckw, &reg);
 391 CompositeKlassCallback callback(&ckwr);
 392 _subsystem_callback = &callback;
 393 do_klasses();
 394 }


This problem is introduced by JDK-8225797 and fixed by JDK-8233111.

I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment.

testing: test/jdk/jdk/jfr

Thanks,
Denghui

-------------

Commit messages:
 - JFR: A wrong parameter is passed to the constructor of LeakKlassWriter

Changes: https://git.openjdk.java.net/jdk11u-dev/pull/813/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=813&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8281520
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk11u-dev/pull/813.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/813/head:pull/813

PR: https://git.openjdk.java.net/jdk11u-dev/pull/813


More information about the jdk-updates-dev mailing list