[jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter

[Denghui Dong]

On Wed, 9 Feb 2022 18:04:28 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Hi team,
>> 
>> Could I have a review of this fix?
>> 
>> The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter:
>> 
>>  387 } else {
>>  388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload);
>>  389 CompositeKlassWriter ckw(&lkw, &kw);
>>  390 CompositeKlassWriterRegistration ckwr(&ckw, &reg);
>>  391 CompositeKlassCallback callback(&ckwr);
>>  392 _subsystem_callback = &callback;
>>  393 do_klasses();
>>  394 }
>> 
>> 
>> This problem is introduced by JDK-8225797 and fixed by JDK-8233111.
>> 
>> I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment.
>> 
>> testing: test/jdk/jdk/jfr
>> 
>> Thanks,
>> Denghui
>
> Lgtm.

@phohensee 
Thank you for the review.

Is it need a second review? If not, could you help sponsor it?

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/813