[jdk11u-dev] RFR: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter

Goetz Lindenmaier goetz at openjdk.java.net
Thu Feb 10 08:29:15 UTC 2022


On Thu, 10 Feb 2022 02:43:59 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi team,
>> 
>> Could I have a review of this fix?
>> 
>> The following code(jfrTypeSet.cpp:L388) passes a wrong parameter `_artifacts` to the constructor of LeakKlassWriter:
>> 
>>  387 } else {
>>  388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload);
>>  389 CompositeKlassWriter ckw(&lkw, &kw);
>>  390 CompositeKlassWriterRegistration ckwr(&ckw, &reg);
>>  391 CompositeKlassCallback callback(&ckwr);
>>  392 _subsystem_callback = &callback;
>>  393 do_klasses();
>>  394 }
>> 
>> 
>> This problem is introduced by JDK-8225797 and fixed by JDK-8233111.
>> 
>> I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment.
>> 
>> testing: test/jdk/jdk/jfr
>> 
>> Thanks,
>> Denghui
>
>> 
> 
> Okay, thanks.

@D-D-H 
Please follow the instructions for backports: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
See point 6. You should only add the tag _after_ writing the corresponding comment in the JBS issue.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/813


More information about the jdk-updates-dev mailing list