[jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2]

Reka Kovacs rkovacs at openjdk.java.net
Fri Feb 11 01:17:11 UTC 2022


On Tue, 5 Oct 2021 08:34:44 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   Backport d2812f780e87511736f2d41bc57a69c2a898b583
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 1336:
> 
>> 1334:   //   used by generate_conjoint_int_oop_copy().
>> 1335:   //
>> 1336:   address generate_disjoint_copy(int size, bool aligned, bool is_oop, address *entry,
> 
> size_t is correct here.

I switched back: https://github.com/openjdk/jdk11u-dev/pull/280/commits/09587d5e38d8bdd2ad70a585ace7c156c9be1418
This way, however, I had to add casts to the two call sites where `size` is used, to avoid a `size_t` to `int` truncation warning ([C4267](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4267?view=msvc-170)). Both calls expect integers. Making `size` an `int` here avoided both the warning and the casts.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/280


More information about the jdk-updates-dev mailing list