[jdk17u-dev] RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits [v3]

aamarsh duke at openjdk.java.net
Fri Feb 11 19:01:16 UTC 2022


On Fri, 28 Jan 2022 07:02:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Fix request 17u: This backport avoids a stack overflow in Windows 32 bit binaries, which some external contributors release. Additionally this is a nice change for Windows 64 bit binaries as well, even though the larger stack size has avoided the problem. The risk is low, simply placing two variables on the heap instead of the stack. Additionally, Tier1 and the newly added test passes on Windows after the changes.
>
> @aamarsh, the comment needs to go to the JBS issue.  Just have a look at the other changes recently pushed to 17u-dev.

@GoeLin Thanks for helping me through the backporting process! I see that the jdk17u-fix-yes tag is now on the JBS issue, so I have integrated my changes. Is there any way you could sponsor this change? Thanks again!

-------------

PR: https://git.openjdk.java.net/jdk17u-dev/pull/98


More information about the jdk-updates-dev mailing list