[jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4]
Reka Kovacs
rkovacs at openjdk.java.net
Sat Feb 12 17:53:11 UTC 2022
On Sat, 12 Feb 2022 17:40:37 GMT, Reka Kovacs <rkovacs at openjdk.org> wrote:
>> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit:
>>
>> - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line.
>> - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`.
>> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR).
>> - <s>Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215.</s>
>> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.)
>>
>> This is part of the Windows/AArch64 port.
>
> Reka Kovacs has updated the pull request incrementally with one additional commit since the last revision:
>
> Replace C-style casts with checked_cast
I replaced them. Thanks for the review.
-------------
PR: https://git.openjdk.java.net/jdk11u-dev/pull/280
More information about the jdk-updates-dev
mailing list