[jdk11u-dev] Integrated: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build

Reka Kovacs rkovacs at openjdk.java.net
Wed Feb 16 20:27:13 UTC 2022


On Mon, 23 Aug 2021 15:43:20 GMT, Reka Kovacs <rkovacs at openjdk.org> wrote:

> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit:
> 
> - This is the first time we disable an MSVC warning for hotspot in 11, so in  `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line.
> - We disable the same warning in  `make/hotspot/lib/CompileGtest.gmk`.
> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR).
> - <s>Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215.</s>
> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.)
> 
> This is part of the Windows/AArch64 port.

This pull request has now been integrated.

Changeset: b5f8c318
Author:    Reka Kovacs <rkovacs at openjdk.org>
Committer: Vladimir Kempik <vkempik at openjdk.org>
URL:       https://git.openjdk.java.net/jdk11u-dev/commit/b5f8c318f49859b7faa0d675db6a17b5da797a54
Stats:     36 lines in 11 files changed: 8 ins; 5 del; 23 mod

8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build

Co-authored-by: Bernhard Urban-Forster <burban at openjdk.org>
Reviewed-by: burban, aph
Backport-of: d2812f780e87511736f2d41bc57a69c2a898b583

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/280


More information about the jdk-updates-dev mailing list