[jdk17u-dev] RFR: 8278627: Shenandoah: TestHeapDump test failed [v2]

Zhengyu Gu zgu at openjdk.java.net
Wed Jan 5 15:58:05 UTC 2022


On Wed, 5 Jan 2022 15:29:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Aleksey's comment
>
> src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp line 282:
> 
>> 280: void ShenandoahHeapIterationRootScanner::roots_do(OopClosure* oops) {
>> 281:   // Must use _claim_other to avoid interfering with concurrent CLDG iteration
>> 282:   CLDToOopClosure clds(oops, ClassLoaderData::_claim_other);
> 
> I am confused a bit. The original code for 17u has `ClassLoaderData::_claim_none` here, the backport changes it to `_claim_other`. The JDK 18 had `_claim_other` both in original code and in the patch. What is going on here?

Good catch! _claim_other comes from JDK-8273559. I tried to backport JDK-8273559 as well, but ran into lock rank inversion problem, as grand lock rank reshuffling is not in JDK17u.

-------------

PR: https://git.openjdk.java.net/jdk17u-dev/pull/58


More information about the jdk-updates-dev mailing list